GNU bug report logs - #61468
[PATCH] gnu: cat-avatar-generator: Update to 2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61468 in the body.
You can then email your comments to 61468 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <evgeny <at> pisemsky.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: cat-avatar-generator: Update to 2.
Date: Mon, 13 Feb 2023 06:40:05 +0300

[0001-gnu-cat-avatar-generator-Update-to-2.patch (text/x-patch, inline)]

From 7b45846379b9ef03ae578d2588a8113923a47c7b Mon Sep 17 00:00:00 2001
From: Evgeny Pisemsky <evgeny <at> pisemsky.com>
Date: Mon, 13 Feb 2023 06:30:15 +0300
Subject: [PATCH] gnu: cat-avatar-generator: Update to 2.

* gnu/packages/web.scm (cat-avatar-generator): Update to 2.
---
 gnu/packages/web.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index a2c4709855..0bf4e6c423 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -7681,16 +7681,16 @@ (define-public geomyidae
 (define-public cat-avatar-generator
   (package
     (name "cat-avatar-generator")
-    (version "1")
+    (version "2")
     (source (origin
               (method git-fetch)
               (uri (git-reference
-                     (url "https://framagit.org/Deevad/cat-avatar-generator.git")
-                     (commit "71c0c662742cafe8afd2d2d50ec84243113e35ad")))
+                    (url "https://framagit.org/Deevad/cat-avatar-generator.git")
+                    (commit "9360ea33f79d1dad3e43494b09878b5e3f6b41fa")))
               (file-name (string-append name "-" version))
               (sha256
                (base32
-                "0s7b5whqsmfa57prbgl66ym551kg6ly0z14h5dgrlx4lqm70y2yw"))))
+                "0js4grqzsm4gvmcbmxv7zw4samfzi6nk4mn977ddcvla9g222rkm"))))
     (build-system trivial-build-system)
     (arguments
      `(#:modules ((guix build utils))

base-commit: 3ab8559436356ef89aa60135d3558681d64443ae
-- 
2.39.1

Message #8 received at 61468 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Evgeny Pisemsky <evgeny <at> pisemsky.com>, 61468 <at> debbugs.gnu.org
Subject: Re: [bug#61468] [PATCH] gnu: cat-avatar-generator: Update to 2.
Date: Mon, 13 Feb 2023 12:47:05 +0100

Hi,

On Mon, 13 Feb 2023 at 06:40, Evgeny Pisemsky <evgeny <at> pisemsky.com> wrote:

>  (define-public cat-avatar-generator
>    (package
>      (name "cat-avatar-generator")
> -    (version "1")
> +    (version "2")
>      (source (origin
>                (method git-fetch)
>                (uri (git-reference
> -                     (url "https://framagit.org/Deevad/cat-avatar-generator.git")
> -                     (commit "71c0c662742cafe8afd2d2d50ec84243113e35ad")))
> +                    (url "https://framagit.org/Deevad/cat-avatar-generator.git")
> +                    (commit "9360ea33f79d1dad3e43494b09878b5e3f6b41fa")))

The common practise when it is not yet released is to use this pattern:

--8<---------------cut here---------------start------------->8---
(let ((commit "9360ea33f79d1dad3e43494b09878b5e3f6b41fa")
        (revision "2"))
    (package
      (name "cat-avatar-generator")
      (version (git-version "1" revision commit))
[...]
                    (commit commit)
--8<---------------cut here---------------end--------------->8---

Although it was not used by the initial addition
3bedac50571204643d5e3b204dc720ae7d571a1f. :-)

Even, maybe version should 0 and not 1; I do not know.

Cheers,
simon

Message #11 received at 61468 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: zimoun <zimon.toutoune <at> gmail.com>, Evgeny Pisemsky <evgeny <at> pisemsky.com>, 
 61468 <at> debbugs.gnu.org
Subject: Re: [bug#61468] [PATCH] gnu: cat-avatar-generator: Update to 2.
Date: Mon, 13 Feb 2023 13:28:08 +0100

Hehe version "1" got through review ;) I agree it would be nice to use git-version instead, but I wouldn't go back to version "0" since guix would detect a package downgrade.

Evgeny, I can take care of that don't worry.

Le 13 février 2023 12:47:05 GMT+01:00, zimoun <zimon.toutoune <at> gmail.com> a écrit :
>Hi,
>
>On Mon, 13 Feb 2023 at 06:40, Evgeny Pisemsky <evgeny <at> pisemsky.com> wrote:
>
>>  (define-public cat-avatar-generator
>>    (package
>>      (name "cat-avatar-generator")
>> -    (version "1")
>> +    (version "2")
>>      (source (origin
>>                (method git-fetch)
>>                (uri (git-reference
>> -                     (url "https://framagit.org/Deevad/cat-avatar-generator.git")
>> -                     (commit "71c0c662742cafe8afd2d2d50ec84243113e35ad")))
>> +                    (url "https://framagit.org/Deevad/cat-avatar-generator.git")
>> +                    (commit "9360ea33f79d1dad3e43494b09878b5e3f6b41fa")))
>
>The common practise when it is not yet released is to use this pattern:
>
>--8<---------------cut here---------------start------------->8---
>(let ((commit "9360ea33f79d1dad3e43494b09878b5e3f6b41fa")
>        (revision "2"))
>    (package
>      (name "cat-avatar-generator")
>      (version (git-version "1" revision commit))
>[...]
>                    (commit commit)
>--8<---------------cut here---------------end--------------->8---
>
>Although it was not used by the initial addition
>3bedac50571204643d5e3b204dc720ae7d571a1f. :-)
>
>Even, maybe version should 0 and not 1; I do not know.
>
>Cheers,
>simon
>
>
>

Message #14 received at 61468 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <evgeny <at> pisemsky.com>
To: 61468 <at> debbugs.gnu.org
Cc: Julien Lepiller <julien <at> lepiller.eu>, zimoun <zimon.toutoune <at> gmail.com>
Subject: Updated patch
Date: Sat, 25 Feb 2023 18:18:30 +0300

[Message part 1 (text/plain, inline)]

Hello.

Here is the updated patch.

I have also changed the builder to copy only necessary files.

[0001-gnu-cat-avatar-generator-Update-to-1-1.9360ea3.patch (text/x-patch, attachment)]

Message #17 received at 61468 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <evgeny <at> pisemsky.com>
To: 61468 <at> debbugs.gnu.org
Subject: Re: Updated patch
Date: Fri, 10 Mar 2023 19:31:10 +0300

Any objections?

Message #22 received at 61468-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Evgeny Pisemsky <evgeny <at> pisemsky.com>
Cc: Julien Lepiller <julien <at> lepiller.eu>, 61468-done <at> debbugs.gnu.org,
 zimoun <zimon.toutoune <at> gmail.com>
Subject: Re: bug#61468: [PATCH] gnu: cat-avatar-generator: Update to 2.
Date: Thu, 16 Mar 2023 12:36:32 +0100

Hi Evgeny,

Evgeny Pisemsky <evgeny <at> pisemsky.com> skribis:

>>From 67527806b69ad391209b9e149cd4975e582e1366 Mon Sep 17 00:00:00 2001
> From: Evgeny Pisemsky <evgeny <at> pisemsky.com>
> Date: Sat, 25 Feb 2023 17:55:10 +0300
> Subject: [PATCH] gnu: cat-avatar-generator: Update to 1-1.9360ea3.
>
> * gnu/packages/web.scm (cat-avatar-generator): Update to 1-1.9360ea3.

Applied, sorry for the delay!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.