GNU bug report logs - #61490
[PATCH 0/1] Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61490 in the body.
You can then email your comments to 61490 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH 0/1] Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵
Date: Mon, 13 Feb 2023 23:00:05 +0300

This nice optimization was discussed on emacs-devel here
https://lists.gnu.org/archive/html/emacs-devel/2022-10/msg02174.html

The thread is 3 months old at this point and nobody still picked that
change up. I mentioned in the thread that I'm going to send the patch a
day ago (it won't show up in the web-interface though, because
apparently it's unable to show a thread from more than a single month),
and now in absence of any opposition here's the patch.

Konstantin Kharlamov (1):
  Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵

 src/alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.39.0

Message #8 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <hi-angel <at> yandex.ru>
To: 61490 <at> debbugs.gnu.org
Subject: Re: bug#61490: Acknowledgement ([PATCH 0/1] Increase BLOCK_ALIGN
 from 2¹⁰to 2¹⁵)
Date: Mon, 13 Feb 2023 23:05:40 +0300

Idk if it's a feature (bugtracker is an odd way of managing the patches in general, so who knows), but for the safe case I'll mention that debbugs created for the patch email a separate page bug#61489

Message #11 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Richard Stallman <rms <at> gnu.org>
To: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
Cc: 61490 <at> debbugs.gnu.org
Subject: Re: bug#61490: [PATCH 0/1] Increase BLOCK_ALIGN from
 2¹⁰to 2¹⁵
Date: Wed, 15 Feb 2023 23:59:24 -0500

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Konstantin Kharlamov (1):
  >   Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵

Thanks for proposing a useful optimization.

For the Emacs sources, including the commit messagss, please stick to
ASCII.  Emacs itself supports UTF-8, but not all terminals can display
all of Unicode.  In particular, Linux ttys can't display those two
diamonds.

-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Message #14 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <hi-angel <at> yandex.ru>
To: rms <at> gnu.org
Cc: 61490 <at> debbugs.gnu.org
Subject: Re: bug#61490: [PATCH 0/1] Increase BLOCK_ALIGN from
 2¹⁰to 2¹⁵
Date: Thu, 16 Feb 2023 09:46:16 +0300

On Wed, 2023-02-15 at 23:59 -0500, Richard Stallman wrote:
> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
> [[[ whether defending the US Constitution against all enemies,     ]]]
> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> 
>   > Konstantin Kharlamov (1):
>   >   Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵
> 
> Thanks for proposing a useful optimization.
> 
> For the Emacs sources, including the commit messagss, please stick to
> ASCII.  Emacs itself supports UTF-8, but not all terminals can display
> all of Unicode.  In particular, Linux ttys can't display those two
> diamonds.

Thanks, okay! Will resend the patch later this evening

Message #17 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Gregory Heytings <gregory <at> heytings.org>
To: Richard Stallman <rms <at> gnu.org>
Cc: 61490 <at> debbugs.gnu.org, Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
Subject: Re: bug#61490: [PATCH 0/1] Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵
Date: Thu, 16 Feb 2023 09:31:12 +0000

[Message part 1 (text/plain, inline)]

>> Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵
>
> Emacs itself supports UTF-8, but not all terminals can display all of 
> Unicode.  In particular, Linux ttys can't display those two diamonds.
>

They can, see (info "(efaq) Emacs in a Linux console").

Message #20 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
To: 61490 <at> debbugs.gnu.org
Subject: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768
Date: Thu, 16 Feb 2023 18:05:09 +0300

Originally discovered by Tyler Dodge in his article "Significant Garbage
Collection Improvement For Emacs".

While testing this change on Archlinux system with Intel i5-7200U CPU,
average time of garbage collection gets reduced by ≈25%. Other users
report improvements up to 50%. While monitoring PSS of emacs with and
without customizations loaded before and after the patch, no
statistically significant differences were discovered. So overall, this
change is a win.

* src/alloc.c (BLOCK_ALIGN): increase from 1024 to 32768
---

v2: 
    * Richard Stallman: don't use non-ASCII in the description
    * Me: mention the report by Ihor Radchenko where performance
      improved by 50%

 src/alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/alloc.c b/src/alloc.c
index c25e81d1dde..d278b01343d 100644
--- a/src/alloc.c
+++ b/src/alloc.c
@@ -1083,7 +1083,7 @@ lisp_free (void *block)
    BLOCK_BYTES and guarantees they are aligned on a BLOCK_ALIGN boundary.  */
 
 /* Byte alignment of storage blocks.  */
-#define BLOCK_ALIGN (1 << 10)
+#define BLOCK_ALIGN (1 << 15)
 verify (POWER_OF_2 (BLOCK_ALIGN));
 
 /* Use aligned_alloc if it or a simple substitute is available.
-- 
2.39.2

Message #23 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
Cc: 61490 <at> debbugs.gnu.org
Subject: Re: bug#61490: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768
Date: Thu, 16 Feb 2023 16:29:01 +0100

>>>>> On Thu, 16 Feb 2023 18:05:09 +0300, Konstantin Kharlamov <Hi-Angel <at> yandex.ru> said:

    Konstantin> Originally discovered by Tyler Dodge in his article "Significant Garbage
    Konstantin> Collection Improvement For Emacs".

    Konstantin> While testing this change on Archlinux system with Intel i5-7200U CPU,
    Konstantin> average time of garbage collection gets reduced by ≈25%. Other users
    Konstantin> report improvements up to 50%. While monitoring PSS of emacs with and
    Konstantin> without customizations loaded before and after the patch, no
    Konstantin> statistically significant differences were discovered. So overall, this
    Konstantin> change is a win.

I havenʼt tested it yet, but it looks reasonable.

Procedural nit: if you put the bug number in the commit message rather
than the Subject, then 'git am' will strip the [PATCH v2] prefix for
us.

Robert
-- 

Message #26 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <hi-angel <at> yandex.ru>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 61490 <at> debbugs.gnu.org
Subject: Re: bug#61490: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768
Date: Thu, 16 Feb 2023 19:48:35 +0300

On Thu, 2023-02-16 at 16:29 +0100, Robert Pluim wrote:
> > > > > > On Thu, 16 Feb 2023 18:05:09 +0300, Konstantin Kharlamov
> > > > > > <Hi-Angel <at> yandex.ru> said:
> 
>     Konstantin> Originally discovered by Tyler Dodge in his article
> "Significant Garbage
>     Konstantin> Collection Improvement For Emacs".
> 
>     Konstantin> While testing this change on Archlinux system with Intel i5-
> 7200U CPU,
>     Konstantin> average time of garbage collection gets reduced by ≈25%. Other
> users
>     Konstantin> report improvements up to 50%. While monitoring PSS of emacs
> with and
>     Konstantin> without customizations loaded before and after the patch, no
>     Konstantin> statistically significant differences were discovered. So
> overall, this
>     Konstantin> change is a win.
> 
> I havenʼt tested it yet, but it looks reasonable.
> 
> Procedural nit: if you put the bug number in the commit message rather
> than the Subject, then 'git am' will strip the [PATCH v2] prefix for
> us.

I am not sure I understood. I did not put the bug number in the subject at all,
it is probably done by debbugs. E.g. if you look at this v2 patch in a browser
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61490#20 the "Subject" line
displayed there does not contain a bug number.

I can add a bug number to the body the next time, but I'm not sure it would make
debbugs stop adding the prefix.

Message #29 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <hi-angel <at> yandex.ru>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 61490 <at> debbugs.gnu.org
Subject: Re: bug#61490: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768
Date: Thu, 16 Feb 2023 20:00:50 +0300

On Thu, 2023-02-16 at 19:48 +0300, Konstantin Kharlamov wrote:
> On Thu, 2023-02-16 at 16:29 +0100, Robert Pluim wrote:
> > > > > > > On Thu, 16 Feb 2023 18:05:09 +0300, Konstantin Kharlamov
> > > > > > > <Hi-Angel <at> yandex.ru> said:
> > 
> >     Konstantin> Originally discovered by Tyler Dodge in his article
> > "Significant Garbage
> >     Konstantin> Collection Improvement For Emacs".
> > 
> >     Konstantin> While testing this change on Archlinux system with Intel i5-
> > 7200U CPU,
> >     Konstantin> average time of garbage collection gets reduced by ≈25%.
> > Other
> > users
> >     Konstantin> report improvements up to 50%. While monitoring PSS of emacs
> > with and
> >     Konstantin> without customizations loaded before and after the patch, no
> >     Konstantin> statistically significant differences were discovered. So
> > overall, this
> >     Konstantin> change is a win.
> > 
> > I havenʼt tested it yet, but it looks reasonable.
> > 
> > Procedural nit: if you put the bug number in the commit message rather
> > than the Subject, then 'git am' will strip the [PATCH v2] prefix for
> > us.
> 
> I am not sure I understood. I did not put the bug number in the subject at
> all,
> it is probably done by debbugs. E.g. if you look at this v2 patch in a browser
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61490#20 the "Subject" line
> displayed there does not contain a bug number.
> 
> I can add a bug number to the body the next time, but I'm not sure it would
> make
> debbugs stop adding the prefix.

Which kind of makes sense btw, because debbugs is a bugtracker, I don't think
its developers supposed that it will be used as a replacement to a mailing list
for patch submissions. To track patches the old-fashioned way people usually
combine a mailing list with `patchwork` interface. Linux-kernel are doing that
for a long time. Freedesktop were doing that too. These days projects are
typically just using git forges.

Message #32 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Konstantin Kharlamov <hi-angel <at> yandex.ru>
Cc: 61490 <at> debbugs.gnu.org
Subject: Re: bug#61490: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768
Date: Thu, 16 Feb 2023 18:02:09 +0100

>>>>> On Thu, 16 Feb 2023 19:48:35 +0300, Konstantin Kharlamov <hi-angel <at> yandex.ru> said:

    >> Procedural nit: if you put the bug number in the commit message rather
    >> than the Subject, then 'git am' will strip the [PATCH v2] prefix for
    >> us.

    Konstantin> I am not sure I understood. I did not put the bug number in the subject at all,
    Konstantin> it is probably done by debbugs. E.g. if you look at this v2 patch in a browser
    Konstantin> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61490#20 the "Subject" line
    Konstantin> displayed there does not contain a bug number.

Youʼre right, this was because I was reading the report via
debbugs-gnus, which adds the prefix. Sorry about that, although this
is one reason why attaching patches is sometimes better.

    Konstantin> I can add a bug number to the body the next time, but I'm not sure it would make
    Konstantin> debbugs stop adding the prefix.

It was debbugs-gnus, not debbugs, so putting it in the body is fine.

Robert
-- 

Message #35 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Richard Stallman <rms <at> gnu.org>
To: Gregory Heytings <gregory <at> heytings.org>
Cc: 61490 <at> debbugs.gnu.org, Hi-Angel <at> yandex.ru
Subject: Re: bug#61490: [PATCH 0/1] Increase BLOCK_ALIGN from
 2¹⁰to 2¹⁵
Date: Tue, 21 Feb 2023 00:22:22 -0500

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > > Emacs itself supports UTF-8, but not all terminals can display all of 
  > > Unicode.  In particular, Linux ttys can't display those two diamonds.
  > >

  > They can, see (info "(efaq) Emacs in a Linux console").

You're talking about a different mode of use (with fbterm), not the
mode that I use.


-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Message #38 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <hi-angel <at> yandex.ru>
To: 61489 <at> debbugs.gnu.org
Cc: 61490 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768
Date: Thu, 23 Feb 2023 18:30:00 +0300

So, it's been a week since version 2 was posted and 10-11 days since I started
using the change locally. Everything has been nice and dandy, and in absence of
further comments, I wonder if somebody with write permissions could merge this
patch?

P.S.: since there's a duplicate issues (one for the cover letter of the patch
and another for the patch itself, I decided to add the second issue to CC).

Message #41 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Konstantin Kharlamov <hi-angel <at> yandex.ru>
Cc: 61489 <at> debbugs.gnu.org, 61490 <at> debbugs.gnu.org
Subject: Re: bug#61489: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768
Date: Thu, 23 Feb 2023 16:49:04 +0100

>>>>> On Thu, 23 Feb 2023 18:30:00 +0300, Konstantin Kharlamov <hi-angel <at> yandex.ru> said:

    Konstantin> So, it's been a week since version 2 was posted and 10-11 days since I started
    Konstantin> using the change locally. Everything has been nice and dandy, and in absence of
    Konstantin> further comments, I wonder if somebody with write permissions could merge this
    Konstantin> patch?

Iʼve had no issues with it. Eli? Does this require 'Copyright-paperwork-exempt: yes'?

    Konstantin> P.S.: since there's a duplicate issues (one for the cover letter of the patch
    Konstantin> and another for the patch itself, I decided to add the second issue to CC).

We can close 61489 or merge it with 61490. Probably the latter is best.

Robert
-- 

Message #44 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <hi-angel <at> yandex.ru>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 61489 <at> debbugs.gnu.org, 61490 <at> debbugs.gnu.org
Subject: Re: bug#61489: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768
Date: Thu, 23 Feb 2023 18:53:02 +0300

On Thu, 2023-02-23 at 16:49 +0100, Robert Pluim wrote:
> > > > > > On Thu, 23 Feb 2023 18:30:00 +0300, Konstantin Kharlamov
> > > > > > <hi-angel <at> yandex.ru> said:
> 
>     Konstantin> So, it's been a week since version 2 was posted and 10-11 days
> since I started
>     Konstantin> using the change locally. Everything has been nice and dandy,
> and in absence of
>     Konstantin> further comments, I wonder if somebody with write permissions
> could merge this
>     Konstantin> patch?
> 
> Iʼve had no issues with it. Eli? Does this require 'Copyright-paperwork-
> exempt: yes'?

No, I have a copyright assignment with GNU for Emacs, it's just that I don't write permissions :)

Message #47 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Konstantin Kharlamov <hi-angel <at> yandex.ru>
Cc: 61489 <at> debbugs.gnu.org, 61490 <at> debbugs.gnu.org
Subject: Re: bug#61489: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768
Date: Thu, 23 Feb 2023 16:57:10 +0100

>>>>> On Thu, 23 Feb 2023 18:53:02 +0300, Konstantin Kharlamov <hi-angel <at> yandex.ru> said:

    Konstantin> On Thu, 2023-02-23 at 16:49 +0100, Robert Pluim wrote:
    >> > > > > > On Thu, 23 Feb 2023 18:30:00 +0300, Konstantin Kharlamov
    >> > > > > > <hi-angel <at> yandex.ru> said:
    >> 
    >>     Konstantin> So, it's been a week since version 2 was posted and 10-11 days
    >> since I started
    >>     Konstantin> using the change locally. Everything has been nice and dandy,
    >> and in absence of
    >>     Konstantin> further comments, I wonder if somebody with write permissions
    >> could merge this
    >>     Konstantin> patch?
    >> 
    >> Iʼve had no issues with it. Eli? Does this require 'Copyright-paperwork-
    >> exempt: yes'?

    Konstantin> No, I have a copyright assignment with GNU for Emacs, it's just that I don't write permissions :)

OK. I canʼt find any commits in your name using 'hi-angel <at> yandex.ru>'
as the email address, is it under a different one?

Thanks

Robert
-- 

Message #50 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <hi-angel <at> yandex.ru>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 61489 <at> debbugs.gnu.org, 61490 <at> debbugs.gnu.org
Subject: Re: bug#61489: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768
Date: Thu, 23 Feb 2023 19:05:22 +0300

On Thu, 2023-02-23 at 16:57 +0100, Robert Pluim wrote:
> > > > > > On Thu, 23 Feb 2023 18:53:02 +0300, Konstantin Kharlamov
> > > > > > <hi-angel <at> yandex.ru> said:
> 
>     Konstantin> On Thu, 2023-02-23 at 16:49 +0100, Robert Pluim wrote:
>     >> > > > > > On Thu, 23 Feb 2023 18:30:00 +0300, Konstantin Kharlamov
>     >> > > > > > <hi-angel <at> yandex.ru> said:
>     >> 
>     >>     Konstantin> So, it's been a week since version 2 was posted and 10-
> 11 days
>     >> since I started
>     >>     Konstantin> using the change locally. Everything has been nice and
> dandy,
>     >> and in absence of
>     >>     Konstantin> further comments, I wonder if somebody with write
> permissions
>     >> could merge this
>     >>     Konstantin> patch?
>     >> 
>     >> Iʼve had no issues with it. Eli? Does this require 'Copyright-
> paperwork-
>     >> exempt: yes'?
> 
>     Konstantin> No, I have a copyright assignment with GNU for Emacs, it's
> just that I don't write permissions :)
> 
> OK. I canʼt find any commits in your name using 'hi-angel <at> yandex.ru>'
> as the email address, is it under a different one?

Well, the "Hi-Angel" is my old nickname, so I typically upcase it, including
inside the email address. So my email inside git config is "email =
Hi-Angel <at> yandex.ru", and similarly to find my commits with `git-log` you gotta
use a:

	git log --author="Hi-Angel <at> yandex.ru"

Message #53 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Konstantin Kharlamov <hi-angel <at> yandex.ru>
Cc: 61489 <at> debbugs.gnu.org, 61490 <at> debbugs.gnu.org
Subject: Re: bug#61489: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768
Date: Thu, 23 Feb 2023 17:34:12 +0100

>>>>> On Thu, 23 Feb 2023 19:05:22 +0300, Konstantin Kharlamov <hi-angel <at> yandex.ru> said:

    Konstantin> On Thu, 2023-02-23 at 16:57 +0100, Robert Pluim wrote:
    >> > > > > > On Thu, 23 Feb 2023 18:53:02 +0300, Konstantin Kharlamov
    >> > > > > > <hi-angel <at> yandex.ru> said:
    >> 
    >>     Konstantin> On Thu, 2023-02-23 at 16:49 +0100, Robert Pluim wrote:
    >>     >> > > > > > On Thu, 23 Feb 2023 18:30:00 +0300, Konstantin Kharlamov
    >>     >> > > > > > <hi-angel <at> yandex.ru> said:
    >>     >> 
    >>     >>     Konstantin> So, it's been a week since version 2 was posted and 10-
    >> 11 days
    >>     >> since I started
    >>     >>     Konstantin> using the change locally. Everything has been nice and
    >> dandy,
    >>     >> and in absence of
    >>     >>     Konstantin> further comments, I wonder if somebody with write
    >> permissions
    >>     >> could merge this
    >>     >>     Konstantin> patch?
    >>     >> 
    >>     >> Iʼve had no issues with it. Eli? Does this require 'Copyright-
    >> paperwork-
    >>     >> exempt: yes'?
    >> 
    >>     Konstantin> No, I have a copyright assignment with GNU for Emacs, it's
    >> just that I don't write permissions :)
    >> 
    >> OK. I canʼt find any commits in your name using 'hi-angel <at> yandex.ru>'
    >> as the email address, is it under a different one?

    Konstantin> Well, the "Hi-Angel" is my old nickname, so I typically upcase it, including
    Konstantin> inside the email address. So my email inside git config is "email =
    Konstantin> Hi-Angel <at> yandex.ru", and similarly to find my commits with `git-log` you gotta
    Konstantin> use a:

    Konstantin> 	git log --author="Hi-Angel <at> yandex.ru"

TIL that I havenʼt turned on enough case-insensitivity in my git
aliases :-)

Robert
-- 

Message #56 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 61489 <at> debbugs.gnu.org, 61490 <at> debbugs.gnu.org, hi-angel <at> yandex.ru
Subject: Re: bug#61489: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768
Date: Thu, 23 Feb 2023 18:40:35 +0200

> Cc: 61489 <at> debbugs.gnu.org, 61490 <at> debbugs.gnu.org
> From: Robert Pluim <rpluim <at> gmail.com>
> Date: Thu, 23 Feb 2023 16:49:04 +0100
> 
> >>>>> On Thu, 23 Feb 2023 18:30:00 +0300, Konstantin Kharlamov <hi-angel <at> yandex.ru> said:
> 
>     Konstantin> So, it's been a week since version 2 was posted and 10-11 days since I started
>     Konstantin> using the change locally. Everything has been nice and dandy, and in absence of
>     Konstantin> further comments, I wonder if somebody with write permissions could merge this
>     Konstantin> patch?
> 
> Iʼve had no issues with it. Eli? Does this require 'Copyright-paperwork-exempt: yes'?

Yes, it does.

Message #59 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Konstantin Kharlamov <hi-angel <at> yandex.ru>
Cc: rpluim <at> gmail.com, 61489 <at> debbugs.gnu.org, 61490 <at> debbugs.gnu.org
Subject: Re: bug#61490: bug#61489: [PATCH v2] Increase BLOCK_ALIGN from 1024 to
 32768
Date: Thu, 23 Feb 2023 18:41:34 +0200

> Cc: 61489 <at> debbugs.gnu.org, 61490 <at> debbugs.gnu.org
> From: Konstantin Kharlamov <hi-angel <at> yandex.ru>
> Date: Thu, 23 Feb 2023 18:53:02 +0300
> 
> On Thu, 2023-02-23 at 16:49 +0100, Robert Pluim wrote:
> > > > > > > On Thu, 23 Feb 2023 18:30:00 +0300, Konstantin Kharlamov
> > > > > > > <hi-angel <at> yandex.ru> said:
> > 
> >     Konstantin> So, it's been a week since version 2 was posted and 10-11 days
> > since I started
> >     Konstantin> using the change locally. Everything has been nice and dandy,
> > and in absence of
> >     Konstantin> further comments, I wonder if somebody with write permissions
> > could merge this
> >     Konstantin> patch?
> > 
> > Iʼve had no issues with it. Eli? Does this require 'Copyright-paperwork-
> > exempt: yes'?
> 
> No, I have a copyright assignment with GNU for Emacs, it's just that I don't write permissions :)

Sorry, you are right.  Ignore my previous message where I said the
Copyright-paperwork-exempt thingy is necessary.

Message #64 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 61489 <at> debbugs.gnu.org, 61490 <at> debbugs.gnu.org,
 Konstantin Kharlamov <hi-angel <at> yandex.ru>
Subject: Re: bug#61489: bug#61490: bug#61489: [PATCH v2] Increase
 BLOCK_ALIGN from 1024 to 32768
Date: Fri, 24 Feb 2023 11:50:43 +0100

>>>>> On Thu, 23 Feb 2023 18:41:34 +0200, Eli Zaretskii <eliz <at> gnu.org> said:

    >> Cc: 61489 <at> debbugs.gnu.org, 61490 <at> debbugs.gnu.org
    >> From: Konstantin Kharlamov <hi-angel <at> yandex.ru>
    >> Date: Thu, 23 Feb 2023 18:53:02 +0300
    >> 
    >> On Thu, 2023-02-23 at 16:49 +0100, Robert Pluim wrote:
    >> > > > > > > On Thu, 23 Feb 2023 18:30:00 +0300, Konstantin Kharlamov
    >> > > > > > > <hi-angel <at> yandex.ru> said:
    >> > 
    >> >     Konstantin> So, it's been a week since version 2 was posted and 10-11 days
    >> > since I started
    >> >     Konstantin> using the change locally. Everything has been nice and dandy,
    >> > and in absence of
    >> >     Konstantin> further comments, I wonder if somebody with write permissions
    >> > could merge this
    >> >     Konstantin> patch?
    >> > 
    >> > Iʼve had no issues with it. Eli? Does this require 'Copyright-paperwork-
    >> > exempt: yes'?
    >> 
    >> No, I have a copyright assignment with GNU for Emacs, it's just that I don't write permissions :)

    Eli> Sorry, you are right.  Ignore my previous message where I said the
    Eli> Copyright-paperwork-exempt thingy is necessary.

OK, Iʼve merged the two bugs. I can push whenever you deem itʼs ready.

Robert
-- 

Message #67 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <hi-angel <at> yandex.ru>
To: Robert Pluim <rpluim <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 61489 <at> debbugs.gnu.org, 61490 <at> debbugs.gnu.org
Subject: Re: bug#61489: bug#61490: bug#61489: [PATCH v2] Increase
 BLOCK_ALIGN from 1024 to 32768
Date: Mon, 27 Feb 2023 13:30:10 +0300

On Fri, 2023-02-24 at 11:50 +0100, Robert Pluim wrote:
> > > > > > On Thu, 23 Feb 2023 18:41:34 +0200, Eli Zaretskii <eliz <at> gnu.org>
> > > > > > said:
> 
>     >> Cc: 61489 <at> debbugs.gnu.org, 61490 <at> debbugs.gnu.org
>     >> From: Konstantin Kharlamov <hi-angel <at> yandex.ru>
>     >> Date: Thu, 23 Feb 2023 18:53:02 +0300
>     >> 
>     >> On Thu, 2023-02-23 at 16:49 +0100, Robert Pluim wrote:
>     >> > > > > > > On Thu, 23 Feb 2023 18:30:00 +0300, Konstantin Kharlamov
>     >> > > > > > > <hi-angel <at> yandex.ru> said:
>     >> > 
>     >> >     Konstantin> So, it's been a week since version 2 was posted and
> 10-11 days
>     >> > since I started
>     >> >     Konstantin> using the change locally. Everything has been nice
> and dandy,
>     >> > and in absence of
>     >> >     Konstantin> further comments, I wonder if somebody with write
> permissions
>     >> > could merge this
>     >> >     Konstantin> patch?
>     >> > 
>     >> > Iʼve had no issues with it. Eli? Does this require 'Copyright-
> paperwork-
>     >> > exempt: yes'?
>     >> 
>     >> No, I have a copyright assignment with GNU for Emacs, it's just that I
> don't write permissions :)
> 
>     Eli> Sorry, you are right.  Ignore my previous message where I said the
>     Eli> Copyright-paperwork-exempt thingy is necessary.
> 
> OK, Iʼve merged the two bugs. I can push whenever you deem itʼs ready.

There was no opposition in any of the answers, so I presume it is ready…?

Message #70 received at 61490 <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <hi-angel <at> yandex.ru>
To: 61490 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>, 61489 <at> debbugs.gnu.org,
 Konstantin Kharlamov <hi-angel <at> yandex.ru>
Subject: Re: bug#61490: [PATCH v2] Increase BLOCK_ALIGN from 1024 to 32768
Date: Fri, 03 Mar 2023 13:44:32 +0300

Ping

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.