GNU bug report logs - #61497
emacs-lsp-treemacs unused leftover icons in sources

Previous Next

Package: guix;

Reported by: Jelle Licht <jlicht <at> fsfe.org>

Date: Tue, 14 Feb 2023 01:08:01 UTC

Severity: normal

Done: Jelle Licht <jlicht <at> fsfe.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61497 in the body.
You can then email your comments to 61497 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#61497; Package guix. (Tue, 14 Feb 2023 01:08:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jelle Licht <jlicht <at> fsfe.org>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Tue, 14 Feb 2023 01:08:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: bug-guix <at> gnu.org
Subject: emacs-lsp-treemacs unused leftover icons in sources
Date: Tue, 14 Feb 2023 02:06:55 +0100
Commit e0d2ec418bb on master removed icons that are unclearly licensed
from the sources of emacs-lsp-treemacs. Quoted here: 

--8<---------------cut here---------------start------------->8---
gnu: emacs-lsp-treemacs: Remove unclearly licensed icons.

emacs-lsp-treemacs bundles icons with unclear licenses.
See also <https://github.com/emacs-lsp/lsp-treemacs/issues/123>.
--8<---------------cut here---------------end--------------->8---

Some icons are still left in the sources, in the 'icons/vscode'
directory' of the source tarball one builds by running `guix build
--source emacs-lsp-treemacs'. I have never used vscode, and am
unfamiliar with the licensing situation of it and its related icons.

In case these icons are also unclearly licensed, I propose we follow the
same strategy as done earlier by Liliana, and remove the vscode icons
entirely.  If the icons are actually licensed under an unproblematic
license, it would be nice if they were installed when running `guix
install emacs-lsp-treemacs', and the license property of the package
updated to reflect this fact.

Thanks for any insight,
- Jelle




Information forwarded to bug-guix <at> gnu.org:
bug#61497; Package guix. (Tue, 14 Feb 2023 19:25:02 GMT) Full text and rfc822 format available.

Message #8 received at 61497 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Jelle Licht <jlicht <at> fsfe.org>, 61497 <at> debbugs.gnu.org
Subject: Re: emacs-lsp-treemacs unused leftover icons in sources
Date: Tue, 14 Feb 2023 20:24:23 +0100
Am Dienstag, dem 14.02.2023 um 02:06 +0100 schrieb Jelle Licht:
> Commit e0d2ec418bb on master removed icons that are unclearly
> licensed
> from the sources of emacs-lsp-treemacs. Quoted here: 
> 
> --8<---------------cut here---------------start------------->8---
> gnu: emacs-lsp-treemacs: Remove unclearly licensed icons.
> 
> emacs-lsp-treemacs bundles icons with unclear licenses.
> See also <https://github.com/emacs-lsp/lsp-treemacs/issues/123>.
> --8<---------------cut here---------------end--------------->8---
> 
> Some icons are still left in the sources, in the 'icons/vscode'
> directory' of the source tarball one builds by running `guix build
> --source emacs-lsp-treemacs'. I have never used vscode, and am
> unfamiliar with the licensing situation of it and its related icons.
> 
> In case these icons are also unclearly licensed, I propose we follow
> the same strategy as done earlier by Liliana, and remove the vscode
> icons entirely.  If the icons are actually licensed under an
> unproblematic license, it would be nice if they were installed when
> running `guix install emacs-lsp-treemacs', and the license property
> of the package updated to reflect this fact.
From what I could gather, vscode-icons [1] are actually CC-BY, but used
without proper attribution in this package.  As for why they're unused,
I mostly forgot to whitelist them.

Cheers

[1] https://github.com/microsoft/vscode-icons




Reply sent to Jelle Licht <jlicht <at> fsfe.org>:
You have taken responsibility. (Mon, 06 Mar 2023 14:16:01 GMT) Full text and rfc822 format available.

Notification sent to Jelle Licht <jlicht <at> fsfe.org>:
bug acknowledged by developer. (Mon, 06 Mar 2023 14:16:01 GMT) Full text and rfc822 format available.

Message #13 received at 61497-done <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 61497-done <at> debbugs.gnu.org
Subject: Re: emacs-lsp-treemacs unused leftover icons in sources
Date: Mon, 06 Mar 2023 15:15:09 +0100
Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Dienstag, dem 14.02.2023 um 02:06 +0100 schrieb Jelle Licht:
>> Commit e0d2ec418bb on master removed icons that are unclearly
>> licensed
>> from the sources of emacs-lsp-treemacs. Quoted here: 
>> 
>> --8<---------------cut here---------------start------------->8---
>> gnu: emacs-lsp-treemacs: Remove unclearly licensed icons.
>> 
>> emacs-lsp-treemacs bundles icons with unclear licenses.
>> See also <https://github.com/emacs-lsp/lsp-treemacs/issues/123>.
>> --8<---------------cut here---------------end--------------->8---
>> 
>> Some icons are still left in the sources, in the 'icons/vscode'
>> directory' of the source tarball one builds by running `guix build
>> --source emacs-lsp-treemacs'. I have never used vscode, and am
>> unfamiliar with the licensing situation of it and its related icons.
>> 
>> In case these icons are also unclearly licensed, I propose we follow
>> the same strategy as done earlier by Liliana, and remove the vscode
>> icons entirely.  If the icons are actually licensed under an
>> unproblematic license, it would be nice if they were installed when
>> running `guix install emacs-lsp-treemacs', and the license property
>> of the package updated to reflect this fact.
> From what I could gather, vscode-icons [1] are actually CC-BY, but used
> without proper attribution in this package.  As for why they're unused,
> I mostly forgot to whitelist them.
>
> Cheers
>
> [1] https://github.com/microsoft/vscode-icons

Fixed + pushed to master in #61649 / 3f222cd5ad,
closing this issue.

- Jelle




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 04 Apr 2023 11:24:13 GMT) Full text and rfc822 format available.

This bug report was last modified 359 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.