GNU logs - #61500, boring messages

Message sent to bug-guix@HIDDEN:

Subject: bug#61500: Default cache directory of cat-avatar-generator-service
Resent-From: Evgeny Pisemsky <evgeny@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Tue, 14 Feb 2023 03:11:02 +0000
Resent-Message-ID: <handler.61500.B.16763442554402 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 61500 <at> debbugs.gnu.org
From: Evgeny Pisemsky <evgeny@HIDDEN>
Date: Tue, 14 Feb 2023 06:10:45 +0300
Message-ID: <87wn4llz62.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2001:41d0:602:1f56::;
 envelope-from=evgeny@HIDDEN; helo=sofi.hosting.energy
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001,
 T_SPF_HELO_PERMERROR=0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Hello!

The cache directory must:

1. End with a slash (due to implementation of the php script).
2. Exist or be created manually.
3. Be writeable by php-fpm.

The current default value doesn't meet these requirements and leads to
broken caching and errors in php-fpm log.

The simplest solution is to change it to /tmp/, but for obvious
reasons it is not suitable for production use.

However, since this service is described as demonstration, I would
prefer unsafe default over broken (for now).

Also the requirements above should probably be mentioned in the
documentation of the service.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Evgeny Pisemsky <evgeny@HIDDEN>
Subject: bug#61500: Acknowledgement (Default cache directory of
 cat-avatar-generator-service)
Message-ID: <handler.61500.B.16763442554402.ack <at> debbugs.gnu.org>
References: <87wn4llz62.fsf@HIDDEN>
X-Gnu-PR-Message: ack 61500
X-Gnu-PR-Package: guix
Reply-To: 61500 <at> debbugs.gnu.org
Date: Tue, 14 Feb 2023 03:11:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-guix@HIDDEN

If you wish to submit further information on this problem, please
send it to 61500 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
61500: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61500
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-guix@HIDDEN:

Subject: bug#61500: [PATCH] services: cat-http-server: Fix cat-avatar-generator-service.
References: <87wn4llz62.fsf@HIDDEN>
In-Reply-To: <87wn4llz62.fsf@HIDDEN>
Resent-From: Evgeny Pisemsky <evgeny@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Thu, 30 Nov 2023 16:40:01 +0000
Resent-Message-ID: <handler.61500.B61500.170136235113873 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 61500 <at> debbugs.gnu.org
From: Evgeny Pisemsky <evgeny@HIDDEN>
Date: Thu, 30 Nov 2023 19:38:50 +0300
Message-ID: <8734wnqjqd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

--=-=-=
Content-Type: text/plain

Here is the simplest patch that changes cache directory to /tmp/ and
makes this service work with the recently added monsterid package.

--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-services-cat-http-server-Fix-cat-avatar-generator-se.patch

From d6778a511cd5c41755a8ba9853d0e9db8dd47997 Mon Sep 17 00:00:00 2001
Message-ID: <d6778a511cd5c41755a8ba9853d0e9db8dd47997.1701362094.git.evgeny@HIDDEN>
From: Evgeny Pisemsky <evgeny@HIDDEN>
Date: Thu, 30 Nov 2023 19:30:50 +0300
Subject: [PATCH] services: cat-http-server: Fix cat-avatar-generator-service.

* gnu/services/web.scm (cat-avatar-generator-service): Change default cache
directory of the service and make it compatible with the monsterid package.

Change-Id: I94b4b2d8b01e8502222e4fd2a6aea247d6480312
---
 doc/guix.texi        | 3 ++-
 gnu/services/web.scm | 5 +++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 1fd2e21608..95a2f05633 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -31752,7 +31752,7 @@ Web Services
 the hash of a user's email address.

 @deffn {Procedure} cat-avatar-generator-service @
-       [#:cache-dir "/var/cache/cat-avatar-generator"] @
+       [#:cache-dir "/tmp/"] @
        [#:package cat-avatar-generator] @
        [#:configuration (nginx-server-configuration)]
 Returns an nginx-server-configuration that inherits @code{configuration}.  It
@@ -31764,6 +31764,7 @@ Web Services
 A simple setup for cat-avatar-generator can look like this:
 @lisp
 (services (cons* (cat-avatar-generator-service
+                  #:package monsterid
                   #:configuration
                   (nginx-server-configuration
                     (server-name '("example.com"))))
diff --git a/gnu/services/web.scm b/gnu/services/web.scm
index 818226a4f7..47ca1e6968 100644
--- a/gnu/services/web.scm
+++ b/gnu/services/web.scm
@@ -1158,7 +1158,7 @@ (define* (nginx-php-location

 (define* (cat-avatar-generator-service
           #:key
-          (cache-dir "/var/cache/cat-avatar-generator")
+          (cache-dir "/tmp/")
           (package cat-avatar-generator)
           (configuration (nginx-server-configuration)))
   (simple-service
@@ -1175,7 +1175,8 @@ (define* (cat-avatar-generator-service
                                 (nginx-location-configuration-body base)))))
                 (nginx-server-configuration-locations configuration)))
             (root #~(string-append #$package
-                                   "/share/web/cat-avatar-generator"))))))
+                                   "/share/web/"
+                                   #$(package-name package)))))))

 (define-record-type* <hpcguix-web-configuration>

base-commit: c12cf2fb63bc2a5b0c5419a372ff6fff76a28a3b
-- 
2.41.0

--=-=-=--

Message sent to bug-guix@HIDDEN:

Subject: bug#61500: Default cache directory of cat-avatar-generator-service
References: <87wn4llz62.fsf@HIDDEN>
In-Reply-To: <87wn4llz62.fsf@HIDDEN>
Resent-From: Evgeny Pisemsky <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-guix@HIDDEN
Resent-Date: Sat, 14 Dec 2024 18:30:02 +0000
Resent-Message-ID: <handler.61500.B61500.173420095331778 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 61500 <at> debbugs.gnu.org
From: Evgeny Pisemsky <mail@HIDDEN>
Date: Sat, 14 Dec 2024 21:28:47 +0300
Message-ID: <87y10ijezk.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> However, since this service is described as demonstration, I would prefer unsafe default over broken (for now).

I realized that this may look like an attempt to introduce vulnerabity, while in fact I was just silly. Shame on me.

The right thing to do here is to write a normal service instead of simple and create cache directory using activation service.

Or at least to update documentation of the existing service.

If someone at guix reads and wants this, please let me know.

Last modified: Sun, 12 Jan 2025 05:45:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.