GNU bug report logs - #61545
[PATCH] gnu: Add waybar-experimental

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61545 in the body.
You can then email your comments to 61545 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Erik Giorgis <git <at> egiorg.is>
To: guix-patches <at> gnu.org
Cc: Erik Giorgis <git <at> egiorg.is>
Subject: [PATCH] gnu: Add waybar-experimental
Date: Wed, 15 Feb 2023 23:22:56 +0100

---
Waybar built with the experimental flag has support
for additional features, such as displaying the 
number of active workspaces in Hyprland.

 gnu/packages/wm.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index f2149b5be5..07e834df8a 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1875,6 +1875,15 @@ (define-public waybar-cpu-histogram
     (home-page "https://github.com/plattfot/cpu-histogram/")
     (license license:expat)))
 
+(define-public waybar-experimental
+  (let ((base waybar))
+    (package
+      (inherit base)
+      (name "waybar-experimental")
+      (arguments
+       (list #:configure-flags #~(list "-Dexperimental=true")))
+      (synopsis "Waybar with experimental features"))))
+
 (define-public wlr-randr
   (package
     (name "wlr-randr")
-- 
2.39.1

Message #10 received at 61545-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Erik Giorgis <git <at> egiorg.is>
Cc: 61545-done <at> debbugs.gnu.org
Subject: Re: bug#61545: [PATCH] gnu: Add waybar-experimental
Date: Wed, 22 Mar 2023 14:21:02 -0400

Hi,

Erik Giorgis <git <at> egiorg.is> writes:

> ---
> Waybar built with the experimental flag has support
> for additional features, such as displaying the 
> number of active workspaces in Hyprland.
>
>  gnu/packages/wm.scm | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index f2149b5be5..07e834df8a 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -1875,6 +1875,15 @@ (define-public waybar-cpu-histogram
>      (home-page "https://github.com/plattfot/cpu-histogram/")
>      (license license:expat)))
>  
> +(define-public waybar-experimental
> +  (let ((base waybar))
> +    (package
> +      (inherit base)

A subtlety of inheritance; this should be package/inherit base, as the
same source code is shared (thus same vulnerabilities may exist and need
the same replacement treatment by grafts).

> +      (name "waybar-experimental")
> +      (arguments
> +       (list #:configure-flags #~(list "-Dexperimental=true")))
> +      (synopsis "Waybar with experimental features"))))
> +
>  (define-public wlr-randr
>    (package
>      (name "wlr-randr")

I've made the above change, along a correct change log message:

--8<---------------cut here---------------start------------->8---
gnu: Add waybar-experimental.

* gnu/packages/wm.scm (waybar-experimental): New variable.
--8<---------------cut here---------------end--------------->8---

and installed the change.

Thank you!

-- 
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.