GNU bug report logs - #61590
[PATCH 0/3] Export accessors for sound services.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61590 in the body.
You can then email your comments to 61590 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: guix-patches <at> gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH 0/3] Export accessors for sound services.
Date: Sat, 18 Feb 2023 00:50:35 +0000

Export accessors for alsa, ladspa and pulseaudio services.


Bruno Victal (3):
  services: pulseaudio: Export accessors.
  services: alsa: Export accessors.
  services: ladspa: Export accessors.

 gnu/services/sound.scm | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)


base-commit: 6dce27abbba01cb4e249c9bdb3c132cecc0a5c51
-- 
2.39.1

Message #8 received at 61590 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 61590 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH 1/3] services: pulseaudio: Export accessors.
Date: Sat, 18 Feb 2023 00:51:31 +0000

* gnu/services/sound.scm: Export pulseaudio-configuration?,
pulseaudio-configuration-client-conf, pulseaudio-configuration-daemon-conf,
pulseaudio-configuration-script-file, pulseaudio-configuration-extra-script-files
and pulseaudio-configuration-system-script-file.
---
 gnu/services/sound.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
index 3e778f3cea..73bdc08b68 100644
--- a/gnu/services/sound.scm
+++ b/gnu/services/sound.scm
@@ -41,6 +41,12 @@ (define-module (gnu services sound)
             alsa-service-type
 
             pulseaudio-configuration
+            pulseaudio-configuration?
+            pulseaudio-configuration-client-conf
+            pulseaudio-configuration-daemon-conf
+            pulseaudio-configuration-script-file
+            pulseaudio-configuration-extra-script-files
+            pulseaudio-configuration-system-script-file
             pulseaudio-service-type
 
             ladspa-configuration
-- 
2.39.1

Message #11 received at 61590 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 61590 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH 2/3] services: alsa: Export accessors.
Date: Sat, 18 Feb 2023 00:51:32 +0000

* gnu/services/sound.scm: Export alsa-configuration?,
alsa-configuration-alsa-plugins, alsa-configuration-pulseaudio?
and alsa-configuration-extra-options.
---
 gnu/services/sound.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
index 73bdc08b68..c3f64171dc 100644
--- a/gnu/services/sound.scm
+++ b/gnu/services/sound.scm
@@ -38,6 +38,10 @@ (define-module (gnu services sound)
   #:use-module (ice-9 match)
   #:use-module (srfi srfi-1)
   #:export (alsa-configuration
+            alsa-configuration?
+            alsa-configuration-alsa-plugins
+            alsa-configuration-pulseaudio?
+            alsa-configuration-extra-options
             alsa-service-type
 
             pulseaudio-configuration
-- 
2.39.1

Message #14 received at 61590 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 61590 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH 3/3] services: ladspa: Export accessors.
Date: Sat, 18 Feb 2023 00:51:33 +0000

* gnu/service/sound.scm: Export ladspa-configuration? and
ladspa-configuration-plugins.
(<ladspa-configuration>)[plugins]: Rename accessor to ladspa-configuration-plugins.
(ladspa-environment): Adjust to use renamed plugin accessor.
---
 gnu/services/sound.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
index c3f64171dc..8ca7acd737 100644
--- a/gnu/services/sound.scm
+++ b/gnu/services/sound.scm
@@ -54,6 +54,8 @@ (define-module (gnu services sound)
             pulseaudio-service-type
 
             ladspa-configuration
+            ladspa-configuration?
+            ladspa-configuration-plugins
             ladspa-service-type))
 
 ;;; Commentary:
@@ -241,7 +243,7 @@ (define pulseaudio-service-type
 (define-record-type* <ladspa-configuration>
   ladspa-configuration make-ladspa-configuration
   ladspa-configuration?
-  (plugins ladspa-plugins (default '())))
+  (plugins ladspa-configuration-plugins (default '())))
 
 (define (ladspa-environment config)
   ;; Define this variable in the global environment such that
@@ -249,7 +251,7 @@ (define (ladspa-environment config)
   `(("LADSPA_PATH" .
      (string-join
       ',(map (lambda (package) (file-append package "/lib/ladspa"))
-             (ladspa-plugins config))
+             (ladspa-configuration-plugins config))
       ":"))))
 
 (define ladspa-service-type
-- 
2.39.1

Message #19 received at 61590-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: 61590-done <at> debbugs.gnu.org
Subject: Re: bug#61590: [PATCH 0/3] Export accessors for sound services.
Date: Tue, 07 Mar 2023 11:05:22 +0100

Bruno Victal <mirai <at> makinata.eu> skribis:

>   services: pulseaudio: Export accessors.
>   services: alsa: Export accessors.
>   services: ladspa: Export accessors.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.