GNU bug report logs - #61661
30.0.50; [PATCH] Define 'appt-notification' face

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61661 in the body.
You can then email your comments to 61661 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Define 'appt-notification' face
Date: Mon, 20 Feb 2023 21:15:12 +0200

[Message part 1 (text/plain, inline)]

Dear maintainers,

The appt.el library can show a notification for upcoming appointments on
the mode line.  The face it uses is hardcoded to 'mode-line-emphasis'
which, by default, is a bold weight.

With the attached patch, we have a new face that the user/theme can set
to something easier to spot like bold+red.  Decoupling this indicator
from the generic 'mode-line-emphasis' allows us to add extra styling
only to the notification without affecting other parts of the mode line
that may be using 'mode-line-emphasis'.

What do you think?

All the best,
Protesilaos (or simply "Prot")

-- 
Protesilaos Stavrou
https://protesilaos.com

[0001-Add-appt-notification-face.patch (text/x-patch, attachment)]

Message #12 received at 61661-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 61661-done <at> debbugs.gnu.org
Subject: Re: bug#61661: 30.0.50; [PATCH] Define 'appt-notification' face
Date: Mon, 4 Sep 2023 13:51:44 -0700

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> The appt.el library can show a notification for upcoming appointments on
> the mode line.  The face it uses is hardcoded to 'mode-line-emphasis'
> which, by default, is a bold weight.
>
> With the attached patch, we have a new face that the user/theme can set
> to something easier to spot like bold+red.  Decoupling this indicator
> from the generic 'mode-line-emphasis' allows us to add extra styling
> only to the notification without affecting other parts of the mode line
> that may be using 'mode-line-emphasis'.
>
> What do you think?

Makes sense to me.  I edited your NEWS message to be more clear, and
installed this on master as commit 367c3f25a16.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.