GNU bug report logs - #61672
[PATCH] gnu: Add nlohmann-json.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61672 in the body.
You can then email your comments to 61672 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: Add nlohmann-json.
Date: Tue, 21 Feb 2023 07:40:23 +0100

* gnu/packages/web.scm (nlohmann-json): New variable.
---
 gnu/packages/web.scm | 48 +++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 47 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 98db004482..e2f9dddf06 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -58,7 +58,7 @@
 ;;; Copyright © 2022 cage <cage-dev <at> twistfold.it>
 ;;; Copyright © 2022 Pradana Aumars <paumars <at> courrier.dev>
 ;;; Copyright © 2022 Petr Hodina <phodina <at> protonmail.com>
-;;; Copyright © 2022 jgart <jgart <at> dismail.de>
+;;; Copyright © 2022, 2023 jgart <jgart <at> dismail.de>
 ;;; Copyright © 2023 Paul A. Patience <paul <at> apatience.com>
 ;;; Copyright © 2022 Bruno Victal <mirai <at> makinata.eu>
 ;;; Copyright © 2023 David Thompson <dthompson2 <at> worcester.edu>
@@ -1109,6 +1109,52 @@ (define-public jansson
 data.")
     (license license:expat)))
 
+(define-public nlohmann-json
+  (package
+    (name "nlohmann-json")
+    (version "3.11.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/nlohmann/json")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0g6rfsbkvrxmacchz4kbr741yybj7mls3r4hgyfdd3pdbqhn2is9"))))
+    (build-system cmake-build-system)
+    (arguments
+      (list #:out-of-source? #t
+            #:configure-flags
+            #~(list "-DJSON_FastTests=ON"
+                    "-DJSON_MultipleHeaders=ON"
+                    "-DJSON_BuildTests=ON"
+                    (string-append "-DJSON_TestDataDirectory="
+                                   #$(this-package-native-input "json-test-data")))
+            #:phases
+            #~(modify-phases %standard-phases
+                (replace 'check
+                  (lambda* (#:key tests? #:allow-other-keys)
+                    ;; Skip tests that require git or modify “installed files”.
+                    (when tests?
+                      (invoke "make" "ARGS=-LE 'not_reproducible|git_required' --verbose")))))))
+    (native-inputs
+      `(("json-test-data"
+         ,(origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url "https://github.com/nlohmann/json_test_data")
+                  (commit "v3.1.0")))
+            (sha256
+             (base32 "0nbirc428qx0lpi940p7y24fzdjbwl6xig3h5rdbihyymmdzhvbc"))
+            (file-name (git-file-name "vis-test" version))))))
+    (home-page "https://json.nlohmann.me/")
+    (synopsis "JSON for Modern C++")
+    (description "This package provides a JSON implementation with an
+intuitive syntax for C++, a single include header file, and with a
+codebase that has 100% code coverage.")
+    (license license:expat)))
+
 (define-public json-c
   (package
     (name "json-c")
-- 
2.39.1

Message #8 received at 61672 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 61672 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH v2] gnu: Add nlohmann-json.
Date: Tue, 21 Feb 2023 07:43:55 +0100

* gnu/packages/web.scm (nlohmann-json): New variable.

v2 just rebases the history


---
 gnu/packages/web.scm | 48 +++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 47 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 98db004482..e2f9dddf06 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -58,7 +58,7 @@
 ;;; Copyright © 2022 cage <cage-dev <at> twistfold.it>
 ;;; Copyright © 2022 Pradana Aumars <paumars <at> courrier.dev>
 ;;; Copyright © 2022 Petr Hodina <phodina <at> protonmail.com>
-;;; Copyright © 2022 jgart <jgart <at> dismail.de>
+;;; Copyright © 2022, 2023 jgart <jgart <at> dismail.de>
 ;;; Copyright © 2023 Paul A. Patience <paul <at> apatience.com>
 ;;; Copyright © 2022 Bruno Victal <mirai <at> makinata.eu>
 ;;; Copyright © 2023 David Thompson <dthompson2 <at> worcester.edu>
@@ -1109,6 +1109,52 @@ (define-public jansson
 data.")
     (license license:expat)))
 
+(define-public nlohmann-json
+  (package
+    (name "nlohmann-json")
+    (version "3.11.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/nlohmann/json")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0g6rfsbkvrxmacchz4kbr741yybj7mls3r4hgyfdd3pdbqhn2is9"))))
+    (build-system cmake-build-system)
+    (arguments
+      (list #:out-of-source? #t
+            #:configure-flags
+            #~(list "-DJSON_FastTests=ON"
+                    "-DJSON_MultipleHeaders=ON"
+                    "-DJSON_BuildTests=ON"
+                    (string-append "-DJSON_TestDataDirectory="
+                                   #$(this-package-native-input "json-test-data")))
+            #:phases
+            #~(modify-phases %standard-phases
+                (replace 'check
+                  (lambda* (#:key tests? #:allow-other-keys)
+                    ;; Skip tests that require git or modify “installed files”.
+                    (when tests?
+                      (invoke "make" "ARGS=-LE 'not_reproducible|git_required' --verbose")))))))
+    (native-inputs
+      `(("json-test-data"
+         ,(origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url "https://github.com/nlohmann/json_test_data")
+                  (commit "v3.1.0")))
+            (sha256
+             (base32 "0nbirc428qx0lpi940p7y24fzdjbwl6xig3h5rdbihyymmdzhvbc"))
+            (file-name (git-file-name "vis-test" version))))))
+    (home-page "https://json.nlohmann.me/")
+    (synopsis "JSON for Modern C++")
+    (description "This package provides a JSON implementation with an
+intuitive syntax for C++, a single include header file, and with a
+codebase that has 100% code coverage.")
+    (license license:expat)))
+
 (define-public json-c
   (package
     (name "json-c")
-- 
2.39.1

Message #11 received at 61672 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> ist.tugraz.at>
To: jgart <jgart <at> dismail.de>, 61672 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Add nlohmann-json.
Date: Tue, 21 Feb 2023 09:49:46 +0100

Am Dienstag, dem 21.02.2023 um 07:43 +0100 schrieb jgart:
> * gnu/packages/web.scm (nlohmann-json): New variable.
Note, that json-modern-cxx is already defined in gnu/packages/cpp.scm.
I'd suggest renaming it, deprecating the old name and then updating it.

Cheers

Message #14 received at 61672 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: liliana.prikler <at> gmail.com, 61672 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Add nlohmann-json.
Date: Tue, 21 Feb 2023 13:37:05 +0000

hi lilyp,

> Note, that json-modern-cxx is already defined in gnu/packages/cpp.scm.

Oh didn't realize. Thanks! I'll send an update today.

all best,

jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.