GNU bug report logs - #61756
[PATCH 5/8] gnu: Add emacs-xcscope.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61756 in the body.
You can then email your comments to 61756 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Rostislav Svoboda <Rostislav.Svoboda <at> gmail.com>
Subject: [PATCH 5/8] gnu: Add emacs-xcscope.
Date: Fri, 24 Feb 2023 15:18:16 +0100

---
 gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a024ddec6a..b444ab0da0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -36086,6 +36086,26 @@ (define-public emacs-vertico-posframe
 a vertical completion UI.")
     (license license:gpl3+)))
 
+(define-public emacs-xcscope
+  (package
+    (name "emacs-xcscope")
+    (version "1.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/dkogan/xcscope.el")
+             (commit "d228d7593d762e457340f678d14b663ef66d7cee")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0pr85ywp585imjzswm04647nb4iqqvg8jgmbcs5210qmr9kh0z8d"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/dkogan/xcscope.el")
+    (synopsis "cscope interface for (X)Emacs")
+    (description
+     "cscope interface for (X)Emacs")
+    (license license:gpl3+)))
+
 ;;;
 ;;; Avoid adding new packages to the end of this file. To reduce the chances
 ;;; of a merge conflict, place them above by existing packages with similar
-- 
2.39.1

Message #8 received at 61756 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
Cc: 61756 <at> debbugs.gnu.org
Subject: Re: [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope.
Date: Wed, 08 Mar 2023 16:42:53 +0100

Hello,

Rostislav Svoboda <rostislav.svoboda <at> gmail.com> writes:

> +(define-public emacs-xcscope

Thank you. Some comments follow.

> +  (package

You need to let-bind commit and revision (set to "0" initially) around
here.

> +    (name "emacs-xcscope")
> +    (version "1.0")

Here, you should use

  (git-version "1.0" revision commit)

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/dkogan/xcscope.el")
> +             (commit "d228d7593d762e457340f678d14b663ef66d7cee")))

This should be

  (commit commit)

> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "0pr85ywp585imjzswm04647nb4iqqvg8jgmbcs5210qmr9kh0z8d"))))
> +    (build-system emacs-build-system)

You also need to add `cscope' as an input, and patch "xscope.el" so
`cscope-program' point to the proper binary, using
`emacs-substitute-variables'. See, e.g., emacs-plz package for an
example.

> +    (home-page "https://github.com/dkogan/xcscope.el")
> +    (synopsis "cscope interface for (X)Emacs")

cscope -> Cscope. You can also drop (X) from (X)Emacs.

> +    (description
> +     "cscope interface for (X)Emacs")

This should be a full sentence (with proper capitalization).

> +    (license license:gpl3+)))

License is actually license:gpl2+, per headers in xscope.el file.

>  ;;; Avoid adding new packages to the end of this file. To reduce the chances
>  ;;; of a merge conflict, place them above by existing packages with similar

  ^
  Hmmmmm…

Could you send an updated patch, with another location for the package
definition, and a proper commit message?

Regards,
-- 
Nicolas Goaziou

Message #11 received at 61756 <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 61756 <at> debbugs.gnu.org
Subject: Re: [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope.
Date: Sat, 11 Mar 2023 12:59:12 +0100

Hello Nicolas

> Could you send an updated patch, with another location for the package
> definition, and a proper commit message?

The patch is below. I hope I didn't miss any of your points. (And
thanks for reviewing my patches.)

Regards
Bost


From 95a4714eaa36608f5c3002d769516346b6df3d99 Mon Sep 17 00:00:00 2001
From: Rostislav Svoboda <Rostislav.Svoboda <at> gmail.com>
Date: Sat, 11 Mar 2023 12:50:08 +0100
Subject: [PATCH] gnu: Add emacs-xcscope.

* gnu/packages/emacs-xyz.scm (emacs-xcscope): New variable.
---
 gnu/packages/emacs-xyz.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 13caf6e882..0c440def40 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -4176,6 +4176,39 @@ (define-public emacs-form-feed
 into mode hooks and is intended to be used that way.")
     (license license:gpl3+)))

+(define-public emacs-xcscope
+  (let ((commit "d228d7593d762e457340f678d14b663ef66d7cee")
+        (revision "1.0"))
+    (package
+      (name "emacs-xcscope")
+      (version (git-version "0.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/dkogan/xcscope.el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0pr85ywp585imjzswm04647nb4iqqvg8jgmbcs5210qmr9kh0z8d"))))
+      (build-system emacs-build-system)
+      (inputs
+       (list cscope))
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'substitute-cscope-path
+              (lambda* (#:key inputs #:allow-other-keys)
+                (emacs-substitute-variables "xcscope.el"
+                  ("cscope-program" (search-input-file inputs
"/bin/cscope"))))))))
+      (home-page "https://github.com/dkogan/xcscope.el")
+      (synopsis "Interface to the source cross-referencing tool Cscope")
+      (description
+       "Xcscope is an Emacs interface to Cscope, the source
cross-referencing tool.
+  See https://cscope.sf.net")
+      (license license:gpl2+))))
+
 (define-public emacs-ggtags
   (package
     (name "emacs-ggtags")
-- 
2.39.2

Message #14 received at 61756 <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 61756 <at> debbugs.gnu.org
Subject: Re: [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope.
Date: Sat, 11 Mar 2023 14:08:45 +0100

Hello,

 I'm resending the patch yet again. See below. I missed that
'(revision "0")' and didn't run `guix lint`. (Sorry, I'm learning)

> You also need to add `cscope' as an input, and patch "xscope.el" so
> `cscope-program' point to the proper binary, using
> `emacs-substitute-variables'. See, e.g., emacs-plz package for an
> example.

`guix style` makes this line too long. I guess I can ignore that, right?

Regards
Bost

From 57e30de01ab56f5917580e43f69ce558187432fb Mon Sep 17 00:00:00 2001
From: Rostislav Svoboda <Rostislav.Svoboda <at> gmail.com>
Date: Sat, 11 Mar 2023 12:50:08 +0100
Subject: [PATCH 1/3] gnu: Add emacs-xcscope.

* gnu/packages/emacs-xyz.scm (emacs-xcscope): New variable.
---
 gnu/packages/emacs-xyz.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 13caf6e882..509c640b78 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -4176,6 +4176,39 @@ (define-public emacs-form-feed
 into mode hooks and is intended to be used that way.")
     (license license:gpl3+)))

+(define-public emacs-xcscope
+  (let ((commit "d228d7593d762e457340f678d14b663ef66d7cee")
+        (revision "0"))
+    (package
+      (name "emacs-xcscope")
+      (version (git-version "1.5" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/dkogan/xcscope.el")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0pr85ywp585imjzswm04647nb4iqqvg8jgmbcs5210qmr9kh0z8d"))))
+      (build-system emacs-build-system)
+      (inputs (list cscope))
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'substitute-cscope-path
+              (lambda* (#:key inputs #:allow-other-keys)
+                (emacs-substitute-variables "xcscope.el"
+                  ("cscope-program" (search-input-file
+                                     inputs "/bin/cscope"))))))))
+      (home-page "https://github.com/dkogan/xcscope.el")
+      (synopsis "Interface to the source cross-referencing tool Cscope")
+      (description
+       "Xcscope is an Emacs interface to Cscope, the source cross-referencing
+tool.  See https://cscope.sf.net")
+      (license license:gpl2+))))
+
 (define-public emacs-ggtags
   (package
     (name "emacs-ggtags")
-- 
2.39.2

Message #19 received at 61756-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
Cc: 61756-done <at> debbugs.gnu.org
Subject: Re: [bug#61756] [PATCH 5/8] gnu: Add emacs-xcscope.
Date: Thu, 16 Mar 2023 00:28:23 +0100

Hello,

Rostislav Svoboda <rostislav.svoboda <at> gmail.com> writes:

>  I'm resending the patch yet again. See below. I missed that
> '(revision "0")' and didn't run `guix lint`. (Sorry, I'm learning)

Applied. Thank you.

> `guix style` makes this line too long. I guess I can ignore that,
> right?

Indeed.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.