GNU bug report logs - #61761
[PATCH 0/2] Update qpdfview

Previous Next

Package: guix-patches;

Reported by: Timotej Lazar <timotej.lazar <at> araneo.si>

Date: Fri, 24 Feb 2023 16:34:02 UTC

Severity: normal

Tags: patch

Done: Leo Famulari <leo <at> famulari.name>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61761 in the body.
You can then email your comments to 61761 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#61761; Package guix-patches. (Fri, 24 Feb 2023 16:34:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Timotej Lazar <timotej.lazar <at> araneo.si>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 24 Feb 2023 16:34:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Timotej Lazar <timotej.lazar <at> araneo.si>
To: guix-patches <at> gnu.org
Cc: Timotej Lazar <timotej.lazar <at> araneo.si>
Subject: [PATCH 0/2] Update qpdfview
Date: Fri, 24 Feb 2023 17:32:41 +0100
Timotej Lazar (2):
  gnu: qpdfview: Update to 0.5.0.
  gnu: qpdfview: Use new package style.

 gnu/local.mk                                  |  1 -
 .../patches/qpdfview-qt515-compat.patch       | 17 --------------
 gnu/packages/pdf.scm                          | 23 +++++++++----------
 3 files changed, 11 insertions(+), 30 deletions(-)
 delete mode 100644 gnu/packages/patches/qpdfview-qt515-compat.patch

-- 
2.39.1





Information forwarded to guix-patches <at> gnu.org:
bug#61761; Package guix-patches. (Fri, 24 Feb 2023 16:36:01 GMT) Full text and rfc822 format available.

Message #8 received at 61761 <at> debbugs.gnu.org (full text, mbox):

From: Timotej Lazar <timotej.lazar <at> araneo.si>
To: 61761 <at> debbugs.gnu.org
Cc: Timotej Lazar <timotej.lazar <at> araneo.si>
Subject: [PATCH 1/2] gnu: qpdfview: Update to 0.5.0.
Date: Fri, 24 Feb 2023 17:35:02 +0100
* gnu/packages/pdf.scm (qpdfview): Update to 0.5.0.
* gnu/packages/patches/qpdfview-qt515-compat.patch: Delete file.
* gnu/local.mk (dist_patch_DATA): Remove it.
---
 gnu/local.mk                                    |  1 -
 .../patches/qpdfview-qt515-compat.patch         | 17 -----------------
 gnu/packages/pdf.scm                            |  7 +++----
 3 files changed, 3 insertions(+), 22 deletions(-)
 delete mode 100644 gnu/packages/patches/qpdfview-qt515-compat.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index 0838f66618..9ae37a9bb4 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1770,7 +1770,6 @@ dist_patch_DATA =						\
   %D%/packages/patches/qemu-glibc-2.27.patch 			\
   %D%/packages/patches/qemu-glibc-2.30.patch 			\
   %D%/packages/patches/qemu-fix-agent-paths.patch 		\
-  %D%/packages/patches/qpdfview-qt515-compat.patch		\
   %D%/packages/patches/qrcodegen-cpp-make-install.patch		\
   %D%/packages/patches/qtbase-absolute-runpath.patch		\
   %D%/packages/patches/qtbase-moc-ignore-gcc-macro.patch	\
diff --git a/gnu/packages/patches/qpdfview-qt515-compat.patch b/gnu/packages/patches/qpdfview-qt515-compat.patch
deleted file mode 100644
index 1fbf5ec3f1..0000000000
--- a/gnu/packages/patches/qpdfview-qt515-compat.patch
+++ /dev/null
@@ -1,17 +0,0 @@
-Fix compatibility with Qt 5.15.
-
-Patch copied from upstream source repository:
-
-https://bazaar.launchpad.net/~adamreichold/qpdfview/trunk/revision/2104
-
---- a/sources/model.h	2017-04-19 21:01:25 +0000
-+++ b/sources/model.h	2020-06-09 06:24:11 +0000
-@@ -24,6 +24,7 @@
- #define DOCUMENTMODEL_H
- 
- #include <QList>
-+#include <QPainterPath>
- #include <QtPlugin>
- #include <QWidget>
- #include <QVector>
-
diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index c040afcae7..9926739973 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -888,16 +888,15 @@ (define-public qpdf
 (define-public qpdfview
   (package
     (name "qpdfview")
-    (version "0.4.18")
+    (version "0.5.0")
     (source
      (origin
        (method url-fetch)
        (uri (string-append "https://launchpad.net/qpdfview/"
                            "trunk/" version "/+download/"
-                           "qpdfview-" version ".tar.gz"))
+                           "qpdfview-" (version-major+minor version) ".tar.gz"))
        (sha256
-        (base32 "0v1rl126hvblajnph2hkansgi0s8vjdc5yxrm4y3faa0lxzjwr6c"))
-       (patches (search-patches "qpdfview-qt515-compat.patch"))))
+        (base32 "16dy341927r2s1dza7g8ci1jyypfc4a6yfcvg9sxvjv1li0c9vs4"))))
     (build-system qt-build-system)
     (native-inputs
      (list pkg-config))
-- 
2.39.1





Information forwarded to guix-patches <at> gnu.org:
bug#61761; Package guix-patches. (Fri, 24 Feb 2023 16:36:02 GMT) Full text and rfc822 format available.

Message #11 received at 61761 <at> debbugs.gnu.org (full text, mbox):

From: Timotej Lazar <timotej.lazar <at> araneo.si>
To: 61761 <at> debbugs.gnu.org
Cc: Timotej Lazar <timotej.lazar <at> araneo.si>
Subject: [PATCH 2/2] gnu: qpdfview: Use new package style.
Date: Fri, 24 Feb 2023 17:35:04 +0100
* gnu/packages/pdf.scm (qpdfview)[arguments]: Use gexps.
---
 gnu/packages/pdf.scm | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 9926739973..6eee460740 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -908,14 +908,14 @@ (define-public qpdfview
            qtbase-5
            qtsvg-5))
     (arguments
-     `(#:tests? #f ; no tests
-       #:phases
-       (modify-phases %standard-phases
-         (replace 'configure
-           (lambda* (#:key outputs #:allow-other-keys)
-             (substitute* "qpdfview.pri"
-               (("/usr") (assoc-ref outputs "out")))
-             (invoke "qmake" "qpdfview.pro"))))))
+     (list #:tests? #f ; no tests
+           #:phases
+           #~(modify-phases %standard-phases
+               (replace 'configure
+                 (lambda _
+                   (substitute* "qpdfview.pri"
+                     (("/usr") #$output))
+                   (invoke "qmake" "qpdfview.pro"))))))
     (home-page "https://launchpad.net/qpdfview")
     (synopsis "Tabbed document viewer")
     (description "@command{qpdfview} is a document viewer for PDF, PS and DJVU
-- 
2.39.1





Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Fri, 24 Feb 2023 19:40:02 GMT) Full text and rfc822 format available.

Notification sent to Timotej Lazar <timotej.lazar <at> araneo.si>:
bug acknowledged by developer. (Fri, 24 Feb 2023 19:40:03 GMT) Full text and rfc822 format available.

Message #16 received at 61761-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Timotej Lazar <timotej.lazar <at> araneo.si>
Cc: 61761-done <at> debbugs.gnu.org
Subject: Re: [bug#61761] [PATCH 0/2] Update qpdfview
Date: Fri, 24 Feb 2023 14:39:46 -0500
On Fri, Feb 24, 2023 at 05:32:41PM +0100, Timotej Lazar wrote:
> Timotej Lazar (2):
>   gnu: qpdfview: Update to 0.5.0.
>   gnu: qpdfview: Use new package style.

Thanks! Pushed as 5609d7dab9b606247b65bd303ffdaa2b24d58f82




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 25 Mar 2023 11:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 4 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.