GNU bug report logs - #61778
30.0.50; [PATCH] Be more cautious in completing Eshell variable assignments

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61778 in the body.
You can then email your comments to 61778 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Be more cautious in completing Eshell variable
 assignments
Date: Fri, 24 Feb 2023 22:02:14 -0800

[Message part 1 (text/plain, inline)]

X-Debbugs-Cc: monnier <at> iro.umontreal.ca

Starting from "emacs -Q":

  M-x shell RET
  tar --directory=<TAB>
  ;; Notice that completions only show directories.

  M-x eshell RET
  tar --directory=<TAB>
  ;; Completions include files *and* directories(!)

After quite a bit of digging, I figured out the issue: Eshell was 
treating "--directory=" as the beginning of a local variable assignment 
(like when you run "CC=gcc make"). The function 
'eshell-complete-variable-assignment' is over-aggressive in identifying 
local variable assignments, and so it picked this up as a false positive.

Attached is a fix for this, plus a regression test.

[0001-Be-more-cautious-in-completing-Eshell-variable-assig.patch (text/plain, attachment)]

Message #8 received at 61778 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 61778 <at> debbugs.gnu.org
Subject: Re: bug#61778: 30.0.50; [PATCH] Be more cautious in completing
 Eshell variable assignments
Date: Sat, 25 Feb 2023 18:25:06 -0500

> After quite a bit of digging, I figured out the issue: Eshell was treating
>  "--directory=" as the beginning of a local variable assignment (like when
>  you run "CC=gcc make"). The function 'eshell-complete-variable-assignment'
>  is over-aggressive in identifying local variable assignments, and so it
> picked this up as a false positive.
>
> Attached is a fix for this, plus a regression test.

LGTM, thanks,


        Stefan

Message #13 received at 61778-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 61778-done <at> debbugs.gnu.org
Subject: Re: bug#61778: 30.0.50; [PATCH] Be more cautious in completing Eshell
 variable assignments
Date: Sat, 25 Feb 2023 20:40:41 -0800

On 2/25/2023 3:25 PM, Stefan Monnier via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
>> Attached is a fix for this, plus a regression test.
> 
> LGTM, thanks,

Thanks. Pushed as 9565e34762. Closing this now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.