GNU bug report logs - #61824
[PATCH] gnu: ledger: Update to 3.3.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61824 in the body.
You can then email your comments to 61824 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jlicht <at> fsfe.org
To: guix-patches <at> gnu.org
Cc: Jelle Licht <jlicht <at> fsfe.org>
Subject: [PATCH] gnu: ledger: Update to 3.3.0.
Date: Sun, 26 Feb 2023 21:50:38 +0100

From: Jelle Licht <jlicht <at> fsfe.org>

* gnu/packages/finance.scm (ledger): Update to 3.3.0.
---

 gnu/packages/finance.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index d2da017091..631985f377 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -311,7 +311,7 @@ (define-public homebank
 (define-public ledger
   (package
     (name "ledger")
-    (version "3.2.1")
+    (version "3.3.0")
     (source
      (origin
        (method git-fetch)
@@ -320,7 +320,7 @@ (define-public ledger
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0x6jxwss3wwzbzlwmnwb8yzjk8f9wfawif4f1b74z2qg6hc4r7f6"))
+        (base32 "09xn5v830lwzkmshhh42ik88gv6hazydb2jxd7kvvhd0k4g7l4yj"))
        (snippet '(begin
                    ;; Remove test that fails due to difference in
                    ;; reported error message (missing leading "./" in the
-- 
2.39.1

Message #8 received at 61824 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: jlicht <at> fsfe.org
Cc: 61824 <at> debbugs.gnu.org
Subject: Re: [bug#61824] [PATCH] gnu: ledger: Update to 3.3.0.
Date: Mon, 27 Feb 2023 13:25:17 +0000

[Message part 1 (text/plain, inline)]

Hi.
Did you try removing the snippet and the line disabling
the BaselineTest_cmd-org test in the 'check-setup' phase?
I tried and all the tests passed on my machine.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 61824 <at> debbugs.gnu.org (full text, mbox):

From: jlicht <at> fsfe.org
To: 61824 <at> debbugs.gnu.org
Cc: Guillaume Le Vaillant <glv <at> posteo.net>, Jelle Licht <jlicht <at> fsfe.org>
Subject: [PATCH v2] gnu: ledger: Update to 3.3.0.
Date: Tue, 28 Feb 2023 02:21:54 +0100

From: Jelle Licht <jlicht <at> fsfe.org>

* gnu/packages/finance.scm (ledger): Update to 3.3.0.
[source]: Remove snippet.
[arguments]<#:phases>: Re-enable old test.

---

Changes in v2:
- enable now-working tests

 gnu/packages/finance.scm | 15 ++-------------
 1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index d2da017091..82b20fd331 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -311,7 +311,7 @@ (define-public homebank
 (define-public ledger
   (package
     (name "ledger")
-    (version "3.2.1")
+    (version "3.3.0")
     (source
      (origin
        (method git-fetch)
@@ -320,14 +320,7 @@ (define-public ledger
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0x6jxwss3wwzbzlwmnwb8yzjk8f9wfawif4f1b74z2qg6hc4r7f6"))
-       (snippet '(begin
-                   ;; Remove test that fails due to difference in
-                   ;; reported error message (missing leading "./" in the
-                   ;; file name); started some time after Guix commit
-                   ;; 727f05e1e285aa52f5a19ec923fdc2259859b4b1
-                   (delete-file "test/regress/BF3C1F82-2.test")
-                   #true))))
+        (base32 "09xn5v830lwzkmshhh42ik88gv6hazydb2jxd7kvvhd0k4g7l4yj"))))
     (build-system cmake-build-system)
     (arguments
      `(#:modules (,@%cmake-build-system-modules
@@ -369,10 +362,6 @@ (define-public ledger
              (setenv "TZDIR"
                      (search-input-directory inputs
                                              "share/zoneinfo"))
-             ;; Skip failing test BaselineTest_cmd-org.
-             ;; This is a known upstream issue. See
-             ;; https://github.com/ledger/ledger/issues/550
-             (setenv "ARGS" "-E BaselineTest_cmd-org")
              #t)))))
     (inputs
      (list boost
-- 
2.39.1

Message #14 received at 61824 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: jlicht <at> fsfe.org
Cc: 61824 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: ledger: Update to 3.3.0.
Date: Tue, 28 Feb 2023 08:31:24 +0000

[Message part 1 (text/plain, inline)]

jlicht <at> fsfe.org skribis:

> From: Jelle Licht <jlicht <at> fsfe.org>
>
> * gnu/packages/finance.scm (ledger): Update to 3.3.0.
> [source]: Remove snippet.
> [arguments]<#:phases>: Re-enable old test.

LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 61824-done <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: 61824-done <at> debbugs.gnu.org
Cc: Guillaume Le Vaillant <glv <at> posteo.net>
Subject: Re: [PATCH v2] gnu: ledger: Update to 3.3.0.
Date: Mon, 06 Mar 2023 15:09:30 +0100

Pushed to master with an additional small version bump (3.3.0 -> 3.3.1)
that prevented crashes.

- Jelle

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.