GNU bug report logs - #61825
[PATCH] etc: Default to variables in tempel's git-reference... et al.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61825 in the body.
You can then email your comments to 61825 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] etc: Default to variables in tempel's git-reference... et al.
Date: Sun, 26 Feb 2023 21:56:33 +0100

Since we encourage using variables rather than magic hashes in the commit
fields, e.g. (commit version) and (commit commit), the default for
tempel to use quoted strings is rather off.  Thus, let the placeholder reflect
actual usage.

* etc/snippets/tempel/scheme-mode (git-reference...)[commit]: Use field name
as placeholder and don't quote value.
(svn-reference..., bzr-reference...)[revision]: Likewise.
(hg-reference...)[changeset]: Likewise.
---
 etc/snippets/tempel/scheme-mode | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/etc/snippets/tempel/scheme-mode b/etc/snippets/tempel/scheme-mode
index 54cb8e40a9..ef73a1e595 100644
--- a/etc/snippets/tempel/scheme-mode
+++ b/etc/snippets/tempel/scheme-mode
@@ -56,12 +56,12 @@ scheme-mode
 (git-reference...
  "(git-reference"
  n> "(url \"" p "\")"
- n> "(commit \"" p "\"))")
+ n> "(commit " (p "commit") "))")
 
 (svn-reference...
  "(svn-reference"
  n> "(url \"" p "\")"
- n> "(revision \"" p "\"))")
+ n> "(revision " (p "revision") "))")
 
 (cvs-reference...
  "(cvs-reference"
@@ -72,12 +72,12 @@ scheme-mode
 (hg-reference...
  "(hg-reference"
  n> "(url \"" p "\")"
- n> "(changeset \"" p "\"))")
+ n> "(changeset " (p "changeset") "))")
 
 (bzr-reference...
  "(bzr-reference"
  n> "(url \"" p "\")"
- n> "(revision \"" p "\"))")
+ n> "(revision " (p "revision") "))")
 
 (:phases\ "#:phases (modify-phases %standard-phases"
           n> p ")")
-- 
2.39.1

Message #8 received at 61825 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: 61825 <at> debbugs.gnu.org
Subject: Re: [PATCH] etc: Default to variables in tempel's git-reference...
 et al.
Date: Sun, 05 Mar 2023 10:03:33 +0100

Am Sonntag, dem 26.02.2023 um 21:56 +0100 schrieb Liliana Marie
Prikler:
> Since we encourage using variables rather than magic hashes in the
> commit fields, e.g. (commit version) and (commit commit), the default
> for tempel to use quoted strings is rather off.  Thus, let the
> placeholder reflect actual usage.
> 
> * etc/snippets/tempel/scheme-mode (git-reference...)[commit]: Use
> field name
> as placeholder and don't quote value.
> (svn-reference..., bzr-reference...)[revision]: Likewise.
> (hg-reference...)[changeset]: Likewise.
Pushed.

Message #13 received at 61825-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: 61825-done <at> debbugs.gnu.org
Subject: Re: [PATCH] etc: Default to variables in tempel's git-reference...
 et al.
Date: Sun, 18 Jun 2023 09:00:09 +0200

Am Sonntag, dem 05.03.2023 um 10:03 +0100 schrieb Liliana Marie
Prikler:
> Am Sonntag, dem 26.02.2023 um 21:56 +0100 schrieb Liliana Marie
> Prikler:
> > Since we encourage using variables rather than magic hashes in the
> > commit fields, e.g. (commit version) and (commit commit), the
> > default
> > for tempel to use quoted strings is rather off.  Thus, let the
> > placeholder reflect actual usage.
> > 
> > * etc/snippets/tempel/scheme-mode (git-reference...)[commit]: Use
> > field name
> > as placeholder and don't quote value.
> > (svn-reference..., bzr-reference...)[revision]: Likewise.
> > (hg-reference...)[changeset]: Likewise.
> Pushed.
Forgot to mark as done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.