GNU bug report logs - #61834
[PATCH] gnu: fish: Update to 3.6.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61834 in the body.
You can then email your comments to 61834 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Winter <winter <at> winter.cafe>
To: guix-patches <at> gnu.org
Cc: Winter <winter <at> winter.cafe>
Subject: [PATCH] gnu: fish: Update to 3.6.0.
Date: Sun, 26 Feb 2023 22:22:33 -0500

* gnu/packages/shells.scm (fish): Update to 3.6.0.
[source]: Remove snippet, as the vendored PCRE2 sources have been
removed (see upstream changelog).
---
 gnu/packages/shells.scm | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
index 0c8cbf3f4c..f550a2c943 100644
--- a/gnu/packages/shells.scm
+++ b/gnu/packages/shells.scm
@@ -118,7 +118,7 @@ (define-public dash
 (define-public fish
   (package
     (name "fish")
-    (version "3.5.1")
+    (version "3.6.0")
     (source
      (origin
        (method url-fetch)
@@ -126,15 +126,11 @@ (define-public fish
                            "releases/download/" version "/"
                            "fish-" version ".tar.xz"))
        (sha256
-        (base32 "0a39vf0wqq6asw5xcrwgdsc67h5bxkgxzy77f8bx6pd4qlympm56"))
-       (modules '((guix build utils)))
-       (snippet
-        '(begin
-           ;; Remove bundled software.
-           (delete-file-recursively "pcre2")))))
+        (base32 "10b1xa1hpmi62rzh3qgxlw7xrhyigs8kssagccawmrryfxbls14p"))
+       (modules '((guix build utils)))))
     (build-system cmake-build-system)
     (inputs
-     (list fish-foreign-env ncurses pcre2 ; don't use the bundled PCRE2
+     (list fish-foreign-env ncurses pcre2
            python))  ; for fish_config and manpage completions
     (native-inputs
      (list doxygen groff ; for 'fish --help'

base-commit: 81fbf5d71fb95367a0a93e45a86de5e930589a05
-- 
2.39.1

Message #10 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Winter <winter <at> winter.cafe>
Cc: 61834-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#61834] [PATCH] gnu: fish: Update to 3.6.0.
Date: Fri, 03 Mar 2023 00:57:25 +0100

[Message part 1 (text/plain, inline)]

Winter,

Winter via Guix-patches via 写道：
> * gnu/packages/shells.scm (fish): Update to 3.6.0.

Thanks!  Pushed as ea870a70e93e7ea93e35fa8e0afc3cfdb1b66ba2, with 
only slight edits:

> [source]: Remove snippet, as the vendored PCRE2 sources have 
> been

I boldly s/vendored/bundled/ :-)

> removed (see upstream changelog).

I wrote ‘CHANGELOG.rst’ here to make it (more) clear that it's a 
file in the sourceball.

> +       (modules '((guix build utils)))))

The only purpose of this source field is to make modules available 
to snippets, so it can go too.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.