GNU bug report logs - #61906
[PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61906 in the body.
You can then email your comments to 61906 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sarthak Shah <shahsarthakw <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Replaced Pumpa origin (https://issues.guix.gnu.org/52257)
Date: Thu, 2 Mar 2023 07:59:54 +0530

[Message part 1 (text/plain, inline)]

---
 gnu/packages/pumpio.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 2f4dd359d1..0c27041f5b 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -35,7 +35,7 @@ (define-public pumpa
     (source (origin
               (method git-fetch) ; no source tarballs
               (uri (git-reference
-                    (url "git://pumpa.branchable.com/")
+                    (url "https://source.pumpa.branchable.com/")
                     (commit (string-append "v" version))))
               (sha256
                (base32

base-commit: 7dc190f83ed29ca7e556700de13a3101e73ec745
-- 
2.39.1

[Message part 2 (text/html, inline)]

Message #8 received at 61906 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Sarthak Shah <shahsarthakw <at> gmail.com>, 61906 <at> debbugs.gnu.org
Subject: Re: [bug#61906] [PATCH] Replaced Pumpa origin
 (https://issues.guix.gnu.org/52257)
Date: Wed, 08 Mar 2023 18:19:43 +0100

Hi,

I miss a commit message which respects ChangeLog format; as documented
by the section ’(guix) Submitting Patches’ of the manual.  Please take
inspiration with other commits. :-)

Cheers,
simon

Message #11 received at 61906 <at> debbugs.gnu.org (full text, mbox):

From: Sarthak Shah <shahsarthakw <at> gmail.com>
To: 61906 <at> debbugs.gnu.org
Subject: [PATCH] Revised patch that respects changelog format
Date: Wed, 8 Mar 2023 23:49:19 +0530

[Message part 1 (text/plain, inline)]

* gnu/packages/pumio.scm (pumpa): Replace pumpa origin
---
 gnu/packages/pumpio.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 2f4dd359d1..0c27041f5b 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -35,7 +35,7 @@ (define-public pumpa
     (source (origin
               (method git-fetch) ; no source tarballs
               (uri (git-reference
-                    (url "git://pumpa.branchable.com/")
+                    (url "https://source.pumpa.branchable.com/")
                     (commit (string-append "v" version))))
               (sha256
                (base32

base-commit: 7dc190f83ed29ca7e556700de13a3101e73ec745
--

[Message part 2 (text/html, inline)]

Message #14 received at 61906 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: 61906 <at> debbugs.gnu.org
Cc: shahsarthakw <at> gmail.com
Subject: [PATCH v3] gnu: pumpa: Update upsream URL.
Date: Thu,  9 Mar 2023 10:57:29 +0100

From: Sarthak Shah <shahsarthakw <at> gmail.com>

Fixes <http://issues.guix.gnu.org/issue/52257>.

* gnu/packages/pumio.scm (pumpa)[source]: Replace pumpa origin.
---
 gnu/packages/pumpio.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 5fb6e338e8..dc5e1ec7bb 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -35,7 +35,7 @@ (define-public pumpa
     (source (origin
               (method git-fetch) ; no source tarballs
               (uri (git-reference
-                    (url "git://pumpa.branchable.com/")
+                    (url "https://source.pumpa.branchable.com/")
                     (commit (string-append "v" version))))
               (sha256
                (base32

base-commit: 203578eef286f3b44cd82fd2eb965a828e21fbe7
-- 
2.38.1

Message #17 received at 61906 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Sarthak Shah <shahsarthakw <at> gmail.com>, 61906 <at> debbugs.gnu.org
Subject: Re: [bug#61906] [PATCH] Revised patch that respects changelog format
Date: Thu, 09 Mar 2023 11:02:25 +0100

Hi,

Please see v3 for nitpicking. :-)  But since it is a more than trivial
patch, the only interesting part is the nitpicking part.


1. Since the Subject line is the Commit headline, it must also respect
   the format.  When modifying a package, it is:

      gnu: packag-name: One line summarizing the change.

On Wed, 08 Mar 2023 at 23:49, Sarthak Shah <shahsarthakw <at> gmail.com> wrote:

> * gnu/packages/pumio.scm (pumpa): Replace pumpa origin

2. The ChangeLog format ends with a period.          --^


Cheers,
simon

Message #20 received at 61906 <at> debbugs.gnu.org (full text, mbox):

From: Sarthak Shah <shahsarthakw <at> gmail.com>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 61906 <at> debbugs.gnu.org
Subject: Re: [bug#61906] [PATCH] Revised patch that respects changelog format
Date: Thu, 9 Mar 2023 16:44:09 +0530

[Message part 1 (text/plain, inline)]

Got it, thank you for your patience.
I guess it won't be necessary as you have already sent a corrected patch,
but should I resend my commit with the required fixes?

On Thu, Mar 9, 2023 at 3:32 PM Simon Tournier <zimon.toutoune <at> gmail.com>
wrote:

> Hi,
>
> Please see v3 for nitpicking. :-)  But since it is a more than trivial
> patch, the only interesting part is the nitpicking part.
>
>
> 1. Since the Subject line is the Commit headline, it must also respect
>    the format.  When modifying a package, it is:
>
>       gnu: packag-name: One line summarizing the change.
>
> On Wed, 08 Mar 2023 at 23:49, Sarthak Shah <shahsarthakw <at> gmail.com> wrote:
>
> > * gnu/packages/pumio.scm (pumpa): Replace pumpa origin
>
> 2. The ChangeLog format ends with a period.          --^
>
>
> Cheers,
> simon
>

[Message part 2 (text/html, inline)]

Message #25 received at 61906-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 61906-done <at> debbugs.gnu.org, shahsarthakw <at> gmail.com
Subject: Re: bug#61906: [PATCH] Replaced Pumpa origin
 (https://issues.guix.gnu.org/52257)
Date: Mon, 13 Mar 2023 14:49:51 +0100

Hi,

Simon Tournier <zimon.toutoune <at> gmail.com> skribis:

> From: Sarthak Shah <shahsarthakw <at> gmail.com>
>
> Fixes <http://issues.guix.gnu.org/issue/52257>.
>
> * gnu/packages/pumio.scm (pumpa)[source]: Replace pumpa origin.

Applied, thanks to the two of you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.