GNU bug report logs - #61998
29.0.60; `treesit-simple-indent-presets' `prev-line' has incorrect position

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61998 in the body.
You can then email your comments to 61998 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Troy Brown <brownts <at> troybrown.dev>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.60;
 `treesit-simple-indent-presets' `prev-line' has incorrect position
Date: Sun, 5 Mar 2023 23:29:59 -0500

I'm expecting `prev-line' to return the position of the first non-space
character on the previous line.  However, it instead returns the number
of characters skipped on the previous line to move to the first
non-space character (i.e., the result of calling `skip-chars-foward').

It appears there is a missing call to `point' that should appear at the
end of the defined lambda.

         (cons 'prev-line (lambda (_n _p bol &rest _)
                            (save-excursion
                              (goto-char bol)
                              (forward-line -1)
-                             (skip-chars-forward " \t"))))
+                             (skip-chars-forward " \t")
+                             (point))))

Message #10 received at 61998-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: brownts <at> troybrown.dev
Cc: 61998-done <at> debbugs.gnu.org
Subject: Re: bug#61998: 29.0.60; `treesit-simple-indent-presets' `prev-line' 
 has incorrect position
Date: Tue, 7 Mar 2023 16:27:54 -0800

Troy Brown <brownts <at> troybrown.dev> writes:

> I'm expecting `prev-line' to return the position of the first non-space
> character on the previous line.  However, it instead returns the number
> of characters skipped on the previous line to move to the first
> non-space character (i.e., the result of calling `skip-chars-foward').
>
> It appears there is a missing call to `point' that should appear at the
> end of the defined lambda.
>
>          (cons 'prev-line (lambda (_n _p bol &rest _)
>                             (save-excursion
>                               (goto-char bol)
>                               (forward-line -1)
> -                             (skip-chars-forward " \t"))))
> +                             (skip-chars-forward " \t")
> +                             (point))))

Thanks for the catch! I fixed it on emacs-29.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.