GNU bug report logs - #62038
[PATCH 0/2] update python-hy

Previous Next

Package: guix-patches;

Reported by: Jack Hill <jackhill <at> jackhill.us>

Date: Tue, 7 Mar 2023 19:56:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62038 in the body.
You can then email your comments to 62038 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#62038; Package guix-patches. (Tue, 07 Mar 2023 19:56:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jack Hill <jackhill <at> jackhill.us>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 07 Mar 2023 19:56:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] update python-hy
Date: Tue, 7 Mar 2023 14:55:14 -0500 (EST)
Hi Guix,

These patches update Hy to the latest non-alpha release and let Hy know 
it's version so that it can report it when invoked.

Of note, several tests are skipped. I checked and, unfortunately, this 
release does not fix any of those failing tests.

Best,
Jack

Jack Hill (2):
  gnu: python-hy: Update to 0.26.0.
  gnu: python-hy: Report version.

 gnu/packages/python-xyz.scm | 42 ++++++++++++++++++++++++-------------
 1 file changed, 27 insertions(+), 15 deletions(-)

-- 
2.39.1




Information forwarded to guix-patches <at> gnu.org:
bug#62038; Package guix-patches. (Tue, 07 Mar 2023 19:58:02 GMT) Full text and rfc822 format available.

Message #8 received at 62038 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 62038 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: python-hy: Update to 0.26.0.
Date: Tue,  7 Mar 2023 14:57:35 -0500
* gnu/packages/python-xyx.scm (python-hy): Update to 0.26.0.
[propagated-inputs]: Remove python-colorama.
---
 gnu/packages/python-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index db9067e699..7a1866314e 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -15008,7 +15008,7 @@ (define-public python-rply
 (define-public python-hy
   (package
     (name "python-hy")
-    (version "0.25.0")
+    (version "0.26.0")
     (source
      (origin
        (method git-fetch)               ; no tests in PyPI release
@@ -15017,7 +15017,7 @@ (define-public python-hy
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1am6z9m0s9svysj0wrfz069rpvbqqimphqll3912q4bvdlz6vrjp"))))
+        (base32 "1czhh7s81sg0nrnf4zv0ydqi4f7s6sywf4ks4fd59vpx441ca39v"))))
     (build-system python-build-system)
     (arguments
      '(#:phases
@@ -15034,7 +15034,7 @@ (define-public python-hy
     (native-inputs
      (list python-pytest-7.1 python-wheel))
     (propagated-inputs
-     (list python-colorama python-funcparserlib))
+     (list python-funcparserlib))
     (home-page "https://docs.hylang.org/en/stable/")
     (synopsis "Lisp frontend to Python")
     (description
-- 
2.39.1





Information forwarded to guix-patches <at> gnu.org:
bug#62038; Package guix-patches. (Tue, 07 Mar 2023 19:58:02 GMT) Full text and rfc822 format available.

Message #11 received at 62038 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 62038 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: python-hy: Report version.
Date: Tue,  7 Mar 2023 14:57:36 -0500
* gnu/packages/python-xyz.scm (python-hy)[arguments]{phases}: Add
set-version and remove-installed-build-scripts.
---
 gnu/packages/python-xyz.scm | 36 ++++++++++++++++++++++++------------
 1 file changed, 24 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 7a1866314e..88138db1f4 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -58,7 +58,7 @@
 ;;; Copyright © 2015, 2018 Pjotr Prins <pjotr.guix <at> thebird.nl>
 ;;; Copyright © 2019, 2020 Brett Gilio <brettg <at> gnu.org>
 ;;; Copyright © 2019 Sam <smbaines8 <at> gmail.com>
-;;; Copyright © 2019 Jack Hill <jackhill <at> jackhill.us>
+;;; Copyright © 2019, 2023 Jack Hill <jackhill <at> jackhill.us>
 ;;; Copyright © 2019, 2020, 2021, 2022 Guillaume Le Vaillant <glv <at> posteo.net>
 ;;; Copyright © 2019, 2020 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2019, 2020, 2021, 2022 Pierre Langlois <pierre.langlois <at> gmx.com>
@@ -15020,17 +15020,29 @@ (define-public python-hy
         (base32 "1czhh7s81sg0nrnf4zv0ydqi4f7s6sywf4ks4fd59vpx441ca39v"))))
     (build-system python-build-system)
     (arguments
-     '(#:phases
-       (modify-phases %standard-phases
-         (replace 'check
-           (lambda* (#:key tests? #:allow-other-keys)
-             (when tests?
-               (invoke "python" "-m" "pytest" "-k"
-                       (string-append   ; skip some failed tests
-                        "not test_sys_executable"
-                        " and not test_circular_macro_require"
-                        " and not test_macro_require"
-                        " and not test_requires_pollutes_core"))))))))
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          ;; Hy includes a script that writes a version.py file the Hy uses to
+          ;; report its version. That script uses information from the git
+          ;; repository or the HY_VERSION environment variable. Therefore,
+          ;; these phases et HY_VERSION and then remove the support scripts
+          ;; which get installed in the root of the output.
+          (add-after 'unpack 'set-version
+            (lambda _
+              (setenv "HY_VERSION" #$version)))
+          (add-after 'install 'remove-installed-build-scripts
+            (lambda _
+              (delete-file-recursively (string-append #$output "/get_version"))))
+          (replace 'check
+            (lambda* (#:key tests? #:allow-other-keys)
+              (when tests?
+                (invoke "python" "-m" "pytest" "-k"
+                        (string-append   ; skip some failed tests
+                         "not test_sys_executable"
+                         " and not test_circular_macro_require"
+                         " and not test_macro_require"
+                         " and not test_requires_pollutes_core"))))))))
     (native-inputs
      (list python-pytest-7.1 python-wheel))
     (propagated-inputs
-- 
2.39.1





Information forwarded to guix-patches <at> gnu.org:
bug#62038; Package guix-patches. (Thu, 16 Mar 2023 22:16:02 GMT) Full text and rfc822 format available.

Message #14 received at 62038 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 62038 <at> debbugs.gnu.org
Subject: [PATCH v2 0/2] python-hy update v2 (typo fix)
Date: Thu, 16 Mar 2023 18:15:41 -0400 (EDT)
Sending a v2 of this patch series becasue I noticed I typo I made in the 
code comment. The changes have otherwise not be modified.

Jack Hill (2):
  gnu: python-hy: Update to 0.26.0.
  gnu: python-hy: Report version.

 gnu/packages/python-xyz.scm | 42 ++++++++++++++++++++++++-------------
 1 file changed, 27 insertions(+), 15 deletions(-)

-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#62038; Package guix-patches. (Thu, 16 Mar 2023 22:18:02 GMT) Full text and rfc822 format available.

Message #17 received at 62038 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 62038 <at> debbugs.gnu.org
Subject: [PATCH v2 1/2] gnu: python-hy: Update to 0.26.0.
Date: Thu, 16 Mar 2023 18:17:33 -0400
* gnu/packages/python-xyx.scm (python-hy): Update to 0.26.0.
[propagated-inputs]: Remove python-colorama.
---
 gnu/packages/python-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 83f3ec02ea..509bfa77d6 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -15027,7 +15027,7 @@ (define-public python-rply
 (define-public python-hy
   (package
     (name "python-hy")
-    (version "0.25.0")
+    (version "0.26.0")
     (source
      (origin
        (method git-fetch)               ; no tests in PyPI release
@@ -15036,7 +15036,7 @@ (define-public python-hy
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1am6z9m0s9svysj0wrfz069rpvbqqimphqll3912q4bvdlz6vrjp"))))
+        (base32 "1czhh7s81sg0nrnf4zv0ydqi4f7s6sywf4ks4fd59vpx441ca39v"))))
     (build-system python-build-system)
     (arguments
      '(#:phases
@@ -15053,7 +15053,7 @@ (define-public python-hy
     (native-inputs
      (list python-pytest-7.1 python-wheel))
     (propagated-inputs
-     (list python-colorama python-funcparserlib))
+     (list python-funcparserlib))
     (home-page "https://docs.hylang.org/en/stable/")
     (synopsis "Lisp frontend to Python")
     (description
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#62038; Package guix-patches. (Thu, 16 Mar 2023 22:18:02 GMT) Full text and rfc822 format available.

Message #20 received at 62038 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 62038 <at> debbugs.gnu.org
Subject: [PATCH v2 2/2] gnu: python-hy: Report version.
Date: Thu, 16 Mar 2023 18:17:34 -0400
* gnu/packages/python-xyz.scm (python-hy)[arguments]{phases}: Add
set-version and remove-installed-build-scripts.
---
 gnu/packages/python-xyz.scm | 36 ++++++++++++++++++++++++------------
 1 file changed, 24 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 509bfa77d6..3dc1a0834c 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -58,7 +58,7 @@
 ;;; Copyright © 2015, 2018 Pjotr Prins <pjotr.guix <at> thebird.nl>
 ;;; Copyright © 2019, 2020 Brett Gilio <brettg <at> gnu.org>
 ;;; Copyright © 2019 Sam <smbaines8 <at> gmail.com>
-;;; Copyright © 2019 Jack Hill <jackhill <at> jackhill.us>
+;;; Copyright © 2019, 2023 Jack Hill <jackhill <at> jackhill.us>
 ;;; Copyright © 2019, 2020, 2021, 2022 Guillaume Le Vaillant <glv <at> posteo.net>
 ;;; Copyright © 2019, 2020 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2019, 2020, 2021, 2022 Pierre Langlois <pierre.langlois <at> gmx.com>
@@ -15039,17 +15039,29 @@ (define-public python-hy
         (base32 "1czhh7s81sg0nrnf4zv0ydqi4f7s6sywf4ks4fd59vpx441ca39v"))))
     (build-system python-build-system)
     (arguments
-     '(#:phases
-       (modify-phases %standard-phases
-         (replace 'check
-           (lambda* (#:key tests? #:allow-other-keys)
-             (when tests?
-               (invoke "python" "-m" "pytest" "-k"
-                       (string-append   ; skip some failed tests
-                        "not test_sys_executable"
-                        " and not test_circular_macro_require"
-                        " and not test_macro_require"
-                        " and not test_requires_pollutes_core"))))))))
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          ;; Hy includes a script that writes a version.py file that Hy uses to
+          ;; report its version. That script uses information from the git
+          ;; repository or the HY_VERSION environment variable. Therefore,
+          ;; these phases et HY_VERSION and then remove the support scripts
+          ;; which get installed in the root of the output.
+          (add-after 'unpack 'set-version
+            (lambda _
+              (setenv "HY_VERSION" #$version)))
+          (add-after 'install 'remove-installed-build-scripts
+            (lambda _
+              (delete-file-recursively (string-append #$output "/get_version"))))
+          (replace 'check
+            (lambda* (#:key tests? #:allow-other-keys)
+              (when tests?
+                (invoke "python" "-m" "pytest" "-k"
+                        (string-append   ; skip some failed tests
+                         "not test_sys_executable"
+                         " and not test_circular_macro_require"
+                         " and not test_macro_require"
+                         " and not test_requires_pollutes_core"))))))))
     (native-inputs
      (list python-pytest-7.1 python-wheel))
     (propagated-inputs
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#62038; Package guix-patches. (Thu, 16 Mar 2023 22:24:01 GMT) Full text and rfc822 format available.

Message #23 received at 62038 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 62038 <at> debbugs.gnu.org
Subject: [PATCH v3 0/2] python-hy update v3 (another typo fix)
Date: Thu, 16 Mar 2023 18:23:18 -0400 (EDT)
Oops, I found yet another typo fix in the code comment. Here's a v3

Jack Hill (2):
  gnu: python-hy: Update to 0.26.0.
  gnu: python-hy: Report version.

 gnu/packages/python-xyz.scm | 42 ++++++++++++++++++++++++-------------
 1 file changed, 27 insertions(+), 15 deletions(-)

-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#62038; Package guix-patches. (Thu, 16 Mar 2023 22:25:02 GMT) Full text and rfc822 format available.

Message #26 received at 62038 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 62038 <at> debbugs.gnu.org
Subject: [PATCH v3 2/2] gnu: python-hy: Report version.
Date: Thu, 16 Mar 2023 18:24:23 -0400
* gnu/packages/python-xyz.scm (python-hy)[arguments]{phases}: Add
set-version and remove-installed-build-scripts.
---
 gnu/packages/python-xyz.scm | 36 ++++++++++++++++++++++++------------
 1 file changed, 24 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 509bfa77d6..a5a2048fb5 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -58,7 +58,7 @@
 ;;; Copyright © 2015, 2018 Pjotr Prins <pjotr.guix <at> thebird.nl>
 ;;; Copyright © 2019, 2020 Brett Gilio <brettg <at> gnu.org>
 ;;; Copyright © 2019 Sam <smbaines8 <at> gmail.com>
-;;; Copyright © 2019 Jack Hill <jackhill <at> jackhill.us>
+;;; Copyright © 2019, 2023 Jack Hill <jackhill <at> jackhill.us>
 ;;; Copyright © 2019, 2020, 2021, 2022 Guillaume Le Vaillant <glv <at> posteo.net>
 ;;; Copyright © 2019, 2020 Alex Griffin <a <at> ajgrf.com>
 ;;; Copyright © 2019, 2020, 2021, 2022 Pierre Langlois <pierre.langlois <at> gmx.com>
@@ -15039,17 +15039,29 @@ (define-public python-hy
         (base32 "1czhh7s81sg0nrnf4zv0ydqi4f7s6sywf4ks4fd59vpx441ca39v"))))
     (build-system python-build-system)
     (arguments
-     '(#:phases
-       (modify-phases %standard-phases
-         (replace 'check
-           (lambda* (#:key tests? #:allow-other-keys)
-             (when tests?
-               (invoke "python" "-m" "pytest" "-k"
-                       (string-append   ; skip some failed tests
-                        "not test_sys_executable"
-                        " and not test_circular_macro_require"
-                        " and not test_macro_require"
-                        " and not test_requires_pollutes_core"))))))))
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          ;; Hy includes a script that writes a version.py file that Hy uses to
+          ;; report its version. That script uses information from the git
+          ;; repository or the HY_VERSION environment variable. Therefore,
+          ;; these phases set HY_VERSION and then remove the support scripts
+          ;; which get installed in the root of the output.
+          (add-after 'unpack 'set-version
+            (lambda _
+              (setenv "HY_VERSION" #$version)))
+          (add-after 'install 'remove-installed-build-scripts
+            (lambda _
+              (delete-file-recursively (string-append #$output "/get_version"))))
+          (replace 'check
+            (lambda* (#:key tests? #:allow-other-keys)
+              (when tests?
+                (invoke "python" "-m" "pytest" "-k"
+                        (string-append   ; skip some failed tests
+                         "not test_sys_executable"
+                         " and not test_circular_macro_require"
+                         " and not test_macro_require"
+                         " and not test_requires_pollutes_core"))))))))
     (native-inputs
      (list python-pytest-7.1 python-wheel))
     (propagated-inputs
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#62038; Package guix-patches. (Thu, 16 Mar 2023 22:25:02 GMT) Full text and rfc822 format available.

Message #29 received at 62038 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: 62038 <at> debbugs.gnu.org
Subject: [PATCH v3 1/2] gnu: python-hy: Update to 0.26.0.
Date: Thu, 16 Mar 2023 18:24:22 -0400
* gnu/packages/python-xyx.scm (python-hy): Update to 0.26.0.
[propagated-inputs]: Remove python-colorama.
---
 gnu/packages/python-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 83f3ec02ea..509bfa77d6 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -15027,7 +15027,7 @@ (define-public python-rply
 (define-public python-hy
   (package
     (name "python-hy")
-    (version "0.25.0")
+    (version "0.26.0")
     (source
      (origin
        (method git-fetch)               ; no tests in PyPI release
@@ -15036,7 +15036,7 @@ (define-public python-hy
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1am6z9m0s9svysj0wrfz069rpvbqqimphqll3912q4bvdlz6vrjp"))))
+        (base32 "1czhh7s81sg0nrnf4zv0ydqi4f7s6sywf4ks4fd59vpx441ca39v"))))
     (build-system python-build-system)
     (arguments
      '(#:phases
@@ -15053,7 +15053,7 @@ (define-public python-hy
     (native-inputs
      (list python-pytest-7.1 python-wheel))
     (propagated-inputs
-     (list python-colorama python-funcparserlib))
+     (list python-funcparserlib))
     (home-page "https://docs.hylang.org/en/stable/")
     (synopsis "Lisp frontend to Python")
     (description
-- 
2.39.2





Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Mon, 03 Apr 2023 16:41:01 GMT) Full text and rfc822 format available.

Notification sent to Jack Hill <jackhill <at> jackhill.us>:
bug acknowledged by developer. (Mon, 03 Apr 2023 16:41:02 GMT) Full text and rfc822 format available.

Message #34 received at 62038-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Jack Hill <jackhill <at> jackhill.us>
Cc: 62038-done <at> debbugs.gnu.org
Subject: Re: [bug#62038] [PATCH v3 0/2] python-hy update v3 (another typo fix)
Date: Mon, 03 Apr 2023 18:40:12 +0200
Hello,

Jack Hill <jackhill <at> jackhill.us> writes:

> Oops, I found yet another typo fix in the code comment. Here's a v3

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#62038; Package guix-patches. (Mon, 03 Apr 2023 18:00:03 GMT) Full text and rfc822 format available.

Message #37 received at 62038-done <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: guix-patches <at> gnu.org, 62038-done <at> debbugs.gnu.org
Subject: Re: bug#62038: [PATCH v3 0/2] python-hy update v3 (another typo fix)
Date: Mon, 3 Apr 2023 13:59:51 -0400 (EDT)
On Mon, 3 Apr 2023, Nicolas Goaziou wrote:

> Hello,
>
> Jack Hill <jackhill <at> jackhill.us> writes:
>
>> Oops, I found yet another typo fix in the code comment. Here's a v3
>
> Applied. Thank you.

Great, thank you!




Information forwarded to guix-patches <at> gnu.org:
bug#62038; Package guix-patches. (Mon, 03 Apr 2023 18:00:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 02 May 2023 11:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 352 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.