GNU bug report logs - #62041
30.0.50; RET bound to `comint-send-input` in C-mode buffer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62041 in the body.
You can then email your comments to 62041 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; RET bound to `comint-send-input` in C-mode buffer
Date: Tue, 07 Mar 2023 18:58:53 -0500

Package: Emacs
Version: 30.0.50


     % src/emacs -Q src/emacs.c
     M-x gud-gdb RET
     gdb --fullname emacs RET
     b main RET
     r -Q RET
     C-x o         (to jump to the `emacs.c` buffer)
     C-h k RET

at this last step, `C-h k` is expected to show RET is bound to `newline`
since we're inside a C mode buffer, but instead it says:

    RET (translated from <return>) runs the command comint-send-input
    (found in gud-minor-mode-map), which is an interactive native-compiled
    Lisp function in ‘comint.el’.

This seems to be because `gud-minor-mode-map` is defined as having
`gud-mode-map` as its parent.  `gud-mode-map` is a major mode map for
a Comint buffer, so it's normal for it to rebind RET to something like
`comint-send-input`, but it's clearly not right for `gud-minor-mode-map`.

This seems to come from commit 8bb5c1bfec0929f2ba419e1c503f5acc01c336c2
but I don't understand why it was done this way.  Was it a plain "typo"?


        Stefan


 In GNU Emacs 30.0.50 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw3d scroll bars) of 2023-02-28 built on pastel
Repository revision: e4ee5ddef02590ab0681c6ac1798cb4d3ac900cb
Repository branch: work
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure -C --enable-checking --enable-check-lisp-object-type --with-modules --with-cairo --with-tiff=ifavailable
 'CFLAGS=-Wall -g3 -Og -Wno-pointer-sign'
 PKG_CONFIG_PATH=/home/monnier/lib/pkgconfig'

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON
LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND
THREADS TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2
XPM LUCID ZLIB

Important settings:
  value of $LANG: fr_CH.UTF-8
  locale-coding-system: utf-8-unix

Major mode: InactiveMinibuffer

Minor modes in effect:
  server-mode: t
  electric-pair-mode: t
  global-reveal-mode: t
  reveal-mode: t
  auto-insert-mode: t
  savehist-mode: t
  minibuffer-electric-default-mode: t
  global-compact-docstrings-mode: t
  global-corfu-mode: t
  url-handler-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  global-prettify-symbols-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  line-number-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/monnier/src/emacs/nongnu/packages/org-contrib/org-contrib-autoloads hides /home/monnier/src/emacs/nongnu/packages/org-contrib/lisp/org-contrib-autoloads
/home/monnier/src/emacs/nongnu/packages/php-mode/php-mode-autoloads hides /home/monnier/src/emacs/nongnu/packages/php-mode/lisp/php-mode-autoloads
/home/monnier/src/emacs/nongnu/packages/org-contrib/lisp/ob-arduino hides /home/monnier/src/emacs/nongnu/packages/arduino-mode/ob-arduino
/home/monnier/src/emacs/nongnu/packages/stylus-mode/jade-mode hides /home/monnier/src/emacs/nongnu/packages/jade-mode/jade-mode
/home/monnier/src/emacs/nongnu/packages/stylus-mode/sws-mode hides /home/monnier/src/emacs/nongnu/packages/jade-mode/sws-mode
/home/monnier/src/emacs/nongnu/packages/stylus-mode/stylus-mode hides /home/monnier/src/emacs/nongnu/packages/jade-mode/stylus-mode
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-psql hides /home/monnier/src/emacs/nongnu/packages/emacsql-mysql/emacsql-psql
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-mysql hides /home/monnier/src/emacs/nongnu/packages/emacsql-mysql/emacsql-mysql
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-pg hides /home/monnier/src/emacs/nongnu/packages/emacsql-mysql/emacsql-pg
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql hides /home/monnier/src/emacs/nongnu/packages/emacsql-mysql/emacsql
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-sqlite-builtin hides /home/monnier/src/emacs/nongnu/packages/emacsql-mysql/emacsql-sqlite-builtin
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-sqlite hides /home/monnier/src/emacs/nongnu/packages/emacsql-mysql/emacsql-sqlite
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-compiler hides /home/monnier/src/emacs/nongnu/packages/emacsql-mysql/emacsql-compiler
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-sqlite-module hides /home/monnier/src/emacs/nongnu/packages/emacsql-mysql/emacsql-sqlite-module
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-psql hides /home/monnier/src/emacs/nongnu/packages/emacsql-sqlite/emacsql-psql
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-mysql hides /home/monnier/src/emacs/nongnu/packages/emacsql-sqlite/emacsql-mysql
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-pg hides /home/monnier/src/emacs/nongnu/packages/emacsql-sqlite/emacsql-pg
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql hides /home/monnier/src/emacs/nongnu/packages/emacsql-sqlite/emacsql
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-sqlite-builtin hides /home/monnier/src/emacs/nongnu/packages/emacsql-sqlite/emacsql-sqlite-builtin
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-sqlite hides /home/monnier/src/emacs/nongnu/packages/emacsql-sqlite/emacsql-sqlite
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-compiler hides /home/monnier/src/emacs/nongnu/packages/emacsql-sqlite/emacsql-compiler
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-sqlite-module hides /home/monnier/src/emacs/nongnu/packages/emacsql-sqlite/emacsql-sqlite-module
/home/monnier/src/emacs/nongnu/packages/magit/magit-autoloads hides /home/monnier/src/emacs/nongnu/packages/magit/lisp/magit-autoloads
/home/monnier/src/emacs/nongnu/packages/magit/git-commit-autoloads hides /home/monnier/src/emacs/nongnu/packages/magit/lisp/git-commit-autoloads
/home/monnier/src/emacs/nongnu/packages/magit/magit-pkg hides /home/monnier/src/emacs/nongnu/packages/magit/lisp/magit-pkg
/home/monnier/src/emacs/nongnu/packages/magit/magit-section-autoloads hides /home/monnier/src/emacs/nongnu/packages/magit/lisp/magit-section-autoloads
/home/monnier/src/emacs/nongnu/packages/magit/git-commit-pkg hides /home/monnier/src/emacs/nongnu/packages/magit/lisp/git-commit-pkg
/home/monnier/src/emacs/nongnu/packages/magit/magit-section-pkg hides /home/monnier/src/emacs/nongnu/packages/magit/lisp/magit-section-pkg
/home/monnier/src/emacs/nongnu/packages/pdf-tools/pdf-tools-autoloads hides /home/monnier/src/emacs/nongnu/packages/pdf-tools/lisp/pdf-tools-autoloads
/home/monnier/src/emacs/nongnu/packages/geiser-kawa/geiser-kawa-autoloads hides /home/monnier/src/emacs/nongnu/packages/geiser-kawa/elisp/geiser-kawa-autoloads
/home/monnier/src/emacs/nongnu/packages/with-editor/with-editor-autoloads hides /home/monnier/src/emacs/nongnu/packages/with-editor/lisp/with-editor-autoloads
/home/monnier/src/emacs/nongnu/packages/geiser/geiser-autoloads hides /home/monnier/src/emacs/nongnu/packages/geiser/elisp/geiser-autoloads
/home/monnier/src/emacs/nongnu/packages/subed/subed-autoloads hides /home/monnier/src/emacs/nongnu/packages/subed/subed/subed-autoloads
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-psql hides /home/monnier/src/emacs/nongnu/packages/emacsql-psql/emacsql-psql
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-mysql hides /home/monnier/src/emacs/nongnu/packages/emacsql-psql/emacsql-mysql
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-pg hides /home/monnier/src/emacs/nongnu/packages/emacsql-psql/emacsql-pg
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql hides /home/monnier/src/emacs/nongnu/packages/emacsql-psql/emacsql
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-sqlite-builtin hides /home/monnier/src/emacs/nongnu/packages/emacsql-psql/emacsql-sqlite-builtin
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-sqlite hides /home/monnier/src/emacs/nongnu/packages/emacsql-psql/emacsql-sqlite
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-compiler hides /home/monnier/src/emacs/nongnu/packages/emacsql-psql/emacsql-compiler
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-sqlite-module hides /home/monnier/src/emacs/nongnu/packages/emacsql-psql/emacsql-sqlite-module
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-psql hides /home/monnier/src/emacs/nongnu/packages/emacsql/emacsql-psql
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-mysql hides /home/monnier/src/emacs/nongnu/packages/emacsql/emacsql-mysql
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-pg hides /home/monnier/src/emacs/nongnu/packages/emacsql/emacsql-pg
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql hides /home/monnier/src/emacs/nongnu/packages/emacsql/emacsql
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-sqlite-builtin hides /home/monnier/src/emacs/nongnu/packages/emacsql/emacsql-sqlite-builtin
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-sqlite hides /home/monnier/src/emacs/nongnu/packages/emacsql/emacsql-sqlite
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-compiler hides /home/monnier/src/emacs/nongnu/packages/emacsql/emacsql-compiler
/home/monnier/src/emacs/nongnu/packages/emacsql-sqlite-builtin/emacsql-sqlite-module hides /home/monnier/src/emacs/nongnu/packages/emacsql/emacsql-sqlite-module
/home/monnier/src/emacs/nongnu/packages/flx-ido/flx-ido hides /home/monnier/src/emacs/nongnu/packages/flx/flx-ido
/home/monnier/src/emacs/nongnu/packages/flx-ido/flx hides /home/monnier/src/emacs/nongnu/packages/flx/flx
/home/monnier/src/emacs/nongnu/packages/mastodon/mastodon-autoloads hides /home/monnier/src/emacs/nongnu/packages/mastodon/lisp/mastodon-autoloads
/home/monnier/src/emacs/elpa/packages/bbdb/bbdb-autoloads hides /home/monnier/src/emacs/elpa/packages/bbdb/lisp/bbdb-autoloads
/home/monnier/src/emacs/nongnu/packages/org-contrib/lisp/org-notify hides /home/monnier/src/emacs/elpa/packages/org-notify/org-notify
/home/monnier/src/emacs/elpa/packages/srht/srht-autoloads hides /home/monnier/src/emacs/elpa/packages/srht/lisp/srht-autoloads
/home/monnier/src/emacs/elpa/packages/transient/transient-autoloads hides /home/monnier/src/emacs/elpa/packages/transient/lisp/transient-autoloads
/home/monnier/src/emacs/nongnu/packages/paredit/test hides /home/monnier/src/emacs/elpa/packages/num3-mode/test
/home/monnier/src/emacs/elpa/packages/elsa/Elsafile hides /home/monnier/src/emacs/elpa/packages/trinary/Elsafile
/home/monnier/src/emacs/elpa/packages/gpr-query/gpr-query hides /home/monnier/src/emacs/elpa/packages/ada-mode/gpr-query
/home/monnier/src/emacs/elpa/packages/gpr-query/prj hides /home/monnier/src/emacs/elpa/packages/ada-mode/prj
/home/monnier/src/emacs/nongnu/packages/org-contrib/lisp/org-contacts hides /home/monnier/src/emacs/elpa/packages/org-contacts/org-contacts
/home/monnier/src/emacs/elpa/packages/taxy-magit-section/taxy-magit-section hides /home/monnier/src/emacs/elpa/packages/taxy/taxy-magit-section
/home/monnier/src/emacs/nongnu/packages/forth-mode/build hides /home/monnier/src/emacs/elpa/packages/lentic/build
/home/monnier/src/emacs/elpa/packages/realgud-lldb/cask-install hides /home/monnier/src/emacs/elpa/packages/realgud-trepan-ni/cask-install
/home/monnier/src/emacs/nongnu/packages/mentor/url-scgi hides /home/monnier/src/emacs/elpa/packages/url-scgi/url-scgi
/home/monnier/src/emacs/elpa/packages/ada-mode/gpr-mode hides /home/monnier/src/emacs/elpa/packages/gpr-mode/gpr-mode
/home/monnier/src/emacs/elpa/packages/ada-mode/gpr-skel hides /home/monnier/src/emacs/elpa/packages/gpr-mode/gpr-skel
/home/monnier/src/emacs/elpa/packages/ada-mode/gpr-process hides /home/monnier/src/emacs/elpa/packages/gpr-mode/gpr-process
/home/monnier/src/emacs/elpa/packages/ada-mode/gpr-indent-user-options hides /home/monnier/src/emacs/elpa/packages/gpr-mode/gpr-indent-user-options
/home/monnier/src/emacs/elpa/packages/ada-mode/gnat-core hides /home/monnier/src/emacs/elpa/packages/wisi/gnat-core
/home/monnier/src/emacs/nongnu/packages/paredit/test hides /home/monnier/src/emacs/elpa/packages/easy-kill/test
/home/monnier/src/emacs/elpa/packages/use-package/use-package-tests hides /home/monnier/src/emacs/elpa/packages/bind-key/use-package-tests
/home/monnier/src/emacs/elpa/packages/use-package/use-package-delight hides /home/monnier/src/emacs/elpa/packages/bind-key/use-package-delight
/home/monnier/src/emacs/elpa/packages/use-package/use-package-diminish hides /home/monnier/src/emacs/elpa/packages/bind-key/use-package-diminish
/home/monnier/src/emacs/elpa/packages/use-package/bind-chord hides /home/monnier/src/emacs/elpa/packages/bind-key/bind-chord
/home/monnier/src/emacs/elpa/packages/use-package/use-package-lint hides /home/monnier/src/emacs/elpa/packages/bind-key/use-package-lint
/home/monnier/src/emacs/elpa/packages/use-package/use-package-core hides /home/monnier/src/emacs/elpa/packages/bind-key/use-package-core
/home/monnier/src/emacs/elpa/packages/use-package/use-package-ensure hides /home/monnier/src/emacs/elpa/packages/bind-key/use-package-ensure
/home/monnier/src/emacs/elpa/packages/use-package/use-package-chords hides /home/monnier/src/emacs/elpa/packages/bind-key/use-package-chords
/home/monnier/src/emacs/elpa/packages/use-package/bind-key hides /home/monnier/src/emacs/elpa/packages/bind-key/bind-key
/home/monnier/src/emacs/elpa/packages/use-package/use-package-chords-tests hides /home/monnier/src/emacs/elpa/packages/bind-key/use-package-chords-tests
/home/monnier/src/emacs/elpa/packages/use-package/use-package-jump hides /home/monnier/src/emacs/elpa/packages/bind-key/use-package-jump
/home/monnier/src/emacs/elpa/packages/use-package/use-package hides /home/monnier/src/emacs/elpa/packages/bind-key/use-package
/home/monnier/src/emacs/elpa/packages/use-package/use-package-bind-key hides /home/monnier/src/emacs/elpa/packages/bind-key/use-package-bind-key
/home/monnier/src/emacs/elpa/packages/use-package/use-package-ensure-system-package hides /home/monnier/src/emacs/elpa/packages/bind-key/use-package-ensure-system-package
/home/monnier/src/emacs/elpa/packages/realgud-lldb/cask-install hides /home/monnier/src/emacs/elpa/packages/realgud/cask-install
/home/monnier/src/emacs/elpa/packages/realgud-lldb/cask-install hides /home/monnier/src/emacs/elpa/packages/loc-changes/cask-install
/home/monnier/src/emacs/elpa/packages/hydra/hydra-test hides /home/monnier/src/emacs/elpa/packages/lv/hydra-test
/home/monnier/src/emacs/elpa/packages/hydra/hydra hides /home/monnier/src/emacs/elpa/packages/lv/hydra
/home/monnier/src/emacs/elpa/packages/hydra/lv hides /home/monnier/src/emacs/elpa/packages/lv/lv
/home/monnier/src/emacs/elpa/packages/hydra/hydra-ox hides /home/monnier/src/emacs/elpa/packages/lv/hydra-ox
/home/monnier/src/emacs/elpa/packages/hydra/hydra-examples hides /home/monnier/src/emacs/elpa/packages/lv/hydra-examples
/home/monnier/src/emacs/elpa/packages/embark-consult/embark-consult hides /home/monnier/src/emacs/elpa/packages/embark/embark-consult
/home/monnier/src/emacs/elpa/packages/embark-consult/embark-org hides /home/monnier/src/emacs/elpa/packages/embark/embark-org
/home/monnier/src/emacs/elpa/packages/embark-consult/embark hides /home/monnier/src/emacs/elpa/packages/embark/embark
/home/monnier/src/emacs/elpa/packages/embark-consult/avy-embark-collect hides /home/monnier/src/emacs/elpa/packages/embark/avy-embark-collect
/home/monnier/src/emacs/elpa/packages/ess/ess-autoloads hides /home/monnier/src/emacs/elpa/packages/ess/lisp/ess-autoloads
/home/monnier/src/emacs/elpa/packages/transient/lisp/transient hides /home/monnier/src/emacs/work/lisp/transient
/home/monnier/src/emacs/elpa/packages/use-package/use-package-delight hides /home/monnier/src/emacs/work/lisp/use-package/use-package-delight
/home/monnier/src/emacs/elpa/packages/use-package/use-package-diminish hides /home/monnier/src/emacs/work/lisp/use-package/use-package-diminish
/home/monnier/src/emacs/elpa/packages/use-package/use-package-lint hides /home/monnier/src/emacs/work/lisp/use-package/use-package-lint
/home/monnier/src/emacs/elpa/packages/use-package/use-package-core hides /home/monnier/src/emacs/work/lisp/use-package/use-package-core
/home/monnier/src/emacs/elpa/packages/use-package/use-package-ensure hides /home/monnier/src/emacs/work/lisp/use-package/use-package-ensure
/home/monnier/src/emacs/elpa/packages/use-package/bind-key hides /home/monnier/src/emacs/work/lisp/use-package/bind-key
/home/monnier/src/emacs/elpa/packages/use-package/use-package-jump hides /home/monnier/src/emacs/work/lisp/use-package/use-package-jump
/home/monnier/src/emacs/elpa/packages/use-package/use-package hides /home/monnier/src/emacs/work/lisp/use-package/use-package
/home/monnier/src/emacs/elpa/packages/use-package/use-package-bind-key hides /home/monnier/src/emacs/work/lisp/use-package/use-package-bind-key
/home/monnier/src/emacs/elpa/packages/use-package/use-package-ensure-system-package hides /home/monnier/src/emacs/work/lisp/use-package/use-package-ensure-system-package
/home/monnier/src/emacs/elpa/packages/eglot/eglot hides /home/monnier/src/emacs/work/lisp/progmodes/eglot
/home/monnier/src/emacs/elpa/packages/csharp-mode/csharp-mode hides /home/monnier/src/emacs/work/lisp/progmodes/csharp-mode
/home/monnier/src/emacs/nongnu/packages/lua-mode/lua-mode hides /home/monnier/src/emacs/work/lisp/progmodes/lua-mode
/home/monnier/src/emacs/nongnu/packages/org-contrib/lisp/ob-julia hides /home/monnier/src/emacs/work/lisp/org/ob-julia
/home/monnier/src/emacs/nongnu/packages/org-contrib/lisp/ol-man hides /home/monnier/src/emacs/work/lisp/org/ol-man
/home/monnier/src/emacs/nongnu/packages/org-contrib/lisp/ox-koma-letter hides /home/monnier/src/emacs/work/lisp/org/ox-koma-letter
/home/monnier/src/emacs/elpa/packages/cl-generic/cl-generic hides /home/monnier/src/emacs/work/lisp/emacs-lisp/cl-generic
/home/monnier/.emacs.d/elpa/hyperbole-8.0.0/set hides /home/monnier/src/emacs/work/lisp/emacs-lisp/set
/home/monnier/src/emacs/elpa/packages/nadvice/nadvice hides /home/monnier/src/emacs/work/lisp/emacs-lisp/nadvice
/home/monnier/src/emacs/elpa/packages/seq/seq hides /home/monnier/src/emacs/work/lisp/emacs-lisp/seq
/home/monnier/src/emacs/elpa/packages/cl-lib/cl-lib hides /home/monnier/src/emacs/work/lisp/emacs-lisp/cl-lib
/home/monnier/src/emacs/work/lisp/keymap hides /home/monnier/src/emacs/work/lisp/emacs-lisp/keymap
/home/monnier/src/emacs/elpa/packages/landmark/landmark hides /home/monnier/src/emacs/work/lisp/obsolete/landmark
/home/monnier/src/emacs/elpa/packages/crisp/crisp hides /home/monnier/src/emacs/work/lisp/obsolete/crisp

Features:
(shadow sort mail-extr emacsbug add-log log-view pcvs-util whitespace
org-eldoc org-element org-persist org-id org-refile avl-tree generator
oc-basic ol-eww eww xdg url-queue mm-url ol-rmail ol-mhe ol-irc ol-info
ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls
dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group
gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail
mail-source utf7 nnoo parse-time gnus-spec gnus-int gnus-range message
sendmail yank-media puny rfc822 mml mml-sec mm-decode mm-bodies
mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev
gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range
mm-util mail-prsvr wid-edit ol-docview doc-view filenotify jka-compr
image-mode exif dired dired-loaddefs ol-bibtex bibtex iso8601 ol-bbdb
ol-w3m ol-doi org-link-doi shortdoc help-fns radix-tree misearch
multi-isearch view cal-china lunar solar cal-dst cal-bahai cal-islam
cal-hebrew holidays holiday-loaddefs cal-french org-journal org-crypt
org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src
ob-comint org-pcomplete drupal/pcomplete pcomplete org-list org-footnote
org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table
org-keys oc org-loaddefs find-func cal-iso diary-lib diary-loaddefs
mule-util cal-move cal-menu calendar cal-loaddefs epa-file epa derived
epg rfc6068 epg-config bug-reference executable copyright vc smerge-mode
diff vc-git diff-mode easy-mmode vc-dispatcher filecache sm-c-mode smie
raku-detect server cl-extra time-date flymake-proc flymake project
compile text-property-search comint ansi-osc ansi-color ring noutline
outline flyspell ispell checkdoc lisp-mnt thingatpt help-mode elec-pair
reveal autoinsert savehist minibuf-eldef disp-table compact-docstrings
corfu compat undo-fu-autoloads inkpot-theme-autoloads keycast-autoloads
rubocop-autoloads treeview-autoloads pcmpl-args-autoloads
undo-fu-session-autoloads camera-autoloads bash-completion-autoloads
flymake-popon-autoloads drupal-mode-autoloads org-superstar-autoloads
apache-mode-autoloads dart-mode-autoloads lua-mode-autoloads
evil-goggles-autoloads monokai-theme-autoloads cyberpunk-theme-autoloads
mpv-autoloads highlight-parentheses-autoloads minibar-autoloads
multiple-cursors-autoloads dockerfile-mode-autoloads
symbol-overlay-autoloads diff-ansi-autoloads eat-autoloads
free-keys-autoloads evil-anzu-autoloads anzu-autoloads tuareg-autoloads
caml-autoloads jinja2-mode-autoloads pcre2el-autoloads paredit-autoloads
apropospriate-theme-autoloads shellcop-autoloads racket-mode-autoloads
pacmacs-autoloads gnuplot-autoloads stylus-mode-autoloads
spell-fu-autoloads nginx-mode-autoloads material-theme-autoloads
el-mock-autoloads raku-mode-autoloads denote-refs-autoloads
arduino-mode-autoloads ede/auto eieio-base guru-mode-autoloads
vc-fossil-autoloads jade-mode-autoloads subatomic-theme-autoloads
orgit-autoloads evil-nerd-commenter-autoloads typescript-mode-autoloads
why-this-autoloads emacsql-sqlite-builtin-autoloads iwindow-autoloads
workroom-autoloads gnu-indent-autoloads buttercup-autoloads
evil-numbers-autoloads emacsql-mysql-autoloads git-modes-autoloads
with-simulated-input-autoloads evil-indent-plus-autoloads
jabber-autoloads emacsql-sqlite-autoloads alect-themes-autoloads
geiser-chicken-autoloads sly-autoloads gruvbox-theme-autoloads
vcomplete-autoloads editorconfig-autoloads devhelp-autoloads
auto-dim-other-buffers-autoloads org-journal-autoloads elpher-autoloads
coffee-mode-autoloads blow-autoloads scala-mode-autoloads
ample-theme-autoloads htmlize-autoloads meow-autoloads
graphql-mode-autoloads wgrep-autoloads markdown-mode-autoloads
inf-clojure-autoloads yasnippet-snippets-autoloads autothemer-autoloads
moe-theme-autoloads evil-visualstar-autoloads gc-buffers-autoloads
org-auto-tangle-autoloads gnu-apl-mode-autoloads geiser-mit-autoloads
zenburn-theme-autoloads afternoon-theme-autoloads org-mime-autoloads
xkcd-autoloads xah-fly-keys-autoloads testcover-mark-line-autoloads
geiser-stklos-autoloads proof-general-autoloads proof-site
proof-autoloads flx-ido-autoloads lorem-ipsum-autoloads
webpaste-autoloads evil-args-autoloads org-present-autoloads
org-drill-autoloads julia-mode-autoloads corfu-terminal-autoloads
cycle-at-point-autoloads gotham-theme-autoloads
tangotango-theme-autoloads telephone-line-autoloads
geiser-gambit-autoloads d-mode-autoloads ws-butler-autoloads
nasm-mode-autoloads spacemacs-theme-autoloads opam-switch-mode-autoloads
boxquote-autoloads org-tree-slide-autoloads projectile-autoloads
nix-mode-autoloads swift-mode-autoloads ujelly-theme-autoloads
geiser-gauche-autoloads swsw-autoloads idle-highlight-mode-autoloads
flymake-kondor-autoloads hl-block-mode-autoloads web-mode-autoloads
j-mode-autoloads inf-ruby-autoloads anti-zenburn-theme-autoloads
evil-exchange-autoloads hl-column-autoloads haskell-mode-autoloads
geiser-guile-autoloads popon-autoloads evil-lisp-state-autoloads
better-jumper-autoloads annotate-autoloads doc-show-inline-autoloads
gruber-darker-theme-autoloads tablist-autoloads
rainbow-delimiters-autoloads mentor-autoloads xml-rpc-autoloads
textile-mode-autoloads bison-mode-autoloads rfc-mode-autoloads
geiser-chibi-autoloads sass-mode-autoloads haml-mode-autoloads
systemd-autoloads rust-mode-autoloads elixir-mode-autoloads
writegood-mode-autoloads cdlatex-autoloads haskell-tng-mode-autoloads
geiser-kawa-autoloads cider-autoloads parseedn-autoloads
parseclj-autoloads yaml-mode-autoloads evil-matchit-autoloads
oblivion-theme-autoloads recomplete-autoloads forth-mode-autoloads
engine-mode-autoloads scroll-on-jump-autoloads geiser-chez-autoloads
sesman-autoloads geiser-racket-autoloads geiser-autoloads helm-autoloads
popup-autoloads helm-core-autoloads scroll-on-drag-autoloads
toc-org-autoloads subed-autoloads prescient-autoloads focus-autoloads
edit-indirect-autoloads sweeprolog-autoloads
visual-fill-column-autoloads emacsql-psql-autoloads emacsql-autoloads
go-mode-autoloads dracula-theme-autoloads solarized-theme-autoloads
slime-autoloads macrostep-autoloads kotlin-mode-autoloads flx-autoloads
smartparens-autoloads evil-iedit-state-autoloads iedit-autoloads
evil-autoloads goto-chg-autoloads crux-autoloads bind-map-autoloads
clojure-mode-autoloads idris-mode-autoloads prop-menu-autoloads
mastodon-autoloads ement-autoloads gnugo-autoloads detached-autoloads
wconf-autoloads json-mode-autoloads ada-ref-man-autoloads
memory-usage-autoloads rich-minority-autoloads beardbolt-autoloads
capf-autosuggest-autoloads rt-liberation-autoloads bbdb-autoloads
auto-correct-autoloads tramp-nspawn-autoloads
yasnippet-classic-snippets-autoloads elisp-benchmarks-autoloads
luwak-autoloads gnus-mock-autoloads fontaine-autoloads vdiff-autoloads
omn-mode-autoloads osc-autoloads pspp-mode-autoloads hcel-autoloads
mines-autoloads comint-mime-autoloads tiny-autoloads phps-mode-autoloads
sql-indent-autoloads ascii-art-to-unicode-autoloads agitate-autoloads
vc-hgcmd-autoloads wpuzzle-autoloads nameless-autoloads
gle-mode-autoloads crdt-autoloads perl-doc-autoloads
ahungry-theme-autoloads nano-modeline-autoloads dired-du-autoloads
adjust-parens-autoloads dired-git-info-autoloads polymode-autoloads
pyim-basedict-autoloads sxhkdrc-mode-autoloads repology-autoloads
ace-window-autoloads easy-escape-autoloads org-notify-autoloads
flymake-proselint-autoloads yasnippet-autoloads elsa-autoloads
org-translate-autoloads highlight-escape-sequences-autoloads
lmc-autoloads counsel-autoloads landmark-autoloads diffview-autoloads
validate-autoloads muse-autoloads sql-smie-autoloads
code-cells-autoloads jgraph-mode-autoloads multishell-autoloads
modus-themes-autoloads wcheck-mode-autoloads gcmh-autoloads
marginalia-autoloads dts-mode-autoloads ediprolog-autoloads
paced-autoloads exwm-autoloads devdocs-autoloads sokoban-autoloads
valign-autoloads rnc-mode-autoloads el-search-autoloads stream-autoloads
sml-mode-autoloads scanner-autoloads djvu-autoloads
expand-region-autoloads poke-mode-autoloads org-modern-autoloads
gnu-elpa-keyring-update-autoloads minimap-autoloads plz-autoloads
sql-beeline-autoloads cycle-quotes-autoloads lin-autoloads
buffer-expose-autoloads midi-kbd-autoloads isearch-mb-autoloads
eglot-autoloads f90-interface-browser-autoloads emacspeak-autoloads
xclip-autoloads brief-autoloads company-math-autoloads
dbus-codegen-autoloads csv-mode-autoloads chess-autoloads
svg-tag-mode-autoloads visual-filename-abbrev-autoloads mct-autoloads
rcirc-menu-autoloads beacon-autoloads org-remark-autoloads
aggressive-indent-autoloads ack-autoloads arbitools-autoloads
substitute-autoloads shelisp-autoloads gpr-query-autoloads
ob-haxe-autoloads ebdb-i18n-chn-autoloads vlf-autoloads enwc-autoloads
system-packages-autoloads docbook-autoloads notmuch-indicator-autoloads
num3-mode-autoloads notes-mode-autoloads trinary-autoloads
temp-buffer-browse-autoloads scroll-restore-autoloads
html5-schema-autoloads math-symbol-lists-autoloads poke-autoloads
gnu-elpa-autoloads gnu-elpa-features vcl-mode-autoloads
jarchive-autoloads guess-language-autoloads oauth2-autoloads
svg-clock-autoloads org-real-autoloads ol rx org-fold org-fold-core
org-compat org-version org-macs format-spec inspector-autoloads
uni-confusables-autoloads register-list-autoloads excorporate-autoloads
url-http-ntlm-autoloads url-auth ada-mode-autoloads fsm-autoloads
pq-autoloads multi-mode-autoloads ftable-autoloads crisp-autoloads
captain-autoloads cursory-autoloads realgud-node-debug-autoloads
diminish-autoloads org-edna-autoloads aumix-mode-autoloads
parsec-autoloads coterm-autoloads uniquify-files-autoloads
cape-autoloads minibuffer-header-autoloads advice-patch-autoloads
org-contacts-autoloads sed-mode-autoloads beframe-autoloads
poker-autoloads wrap-search-autoloads sisu-mode-autoloads
sketch-mode-autoloads quarter-plane-autoloads markchars-autoloads
setup-autoloads engrave-faces-autoloads pinentry-autoloads
sotlisp-autoloads ggtags-autoloads gtags-mode-autoloads
hiddenquote-autoloads which-key-autoloads minibuffer-line-autoloads
epoch-view-autoloads disk-usage-autoloads rmsbolt-autoloads
debbugs-autoloads standard-themes-autoloads vc-got-autoloads
ivy-hydra-autoloads hydra-autoloads blist-autoloads ilist-autoloads
timerfunctions-autoloads spinner-autoloads smart-yank-autoloads
transcribe-autoloads ssh-deploy-autoloads path-iterator-autoloads
all-autoloads nano-agenda-autoloads electric-spacing-autoloads
tramp-theme-autoloads relint-autoloads slime-volleyball-autoloads
ergoemacs-mode-autoloads on-screen-autoloads nlinum-autoloads
bug-hunter-autoloads org-transclusion-autoloads nhexl-mode-autoloads
auto-overlays-autoloads jumpc-autoloads zones-autoloads
shell-quasiquote-autoloads nano-theme-autoloads realgud-lldb-autoloads
boxy-headlines-autoloads zuul-autoloads tempel-autoloads
delight-autoloads darkroom-autoloads cobol-mode-autoloads
visual-fill-autoloads diff-hl-autoloads ampc-autoloads
ivy-posframe-autoloads pyim-autoloads xr-autoloads frog-menu-autoloads
taxy-magit-section-autoloads taxy-autoloads smalltalk-mode-autoloads
prefixed-core-autoloads lentic-server-autoloads lentic-autoloads
logos-autoloads dismal-autoloads gited-autoloads sql-cassandra-autoloads
kind-icon-autoloads tomelr-autoloads windower-autoloads
parser-generator-autoloads javaimp-autoloads triples-autoloads
realgud-trepan-ni-autoloads async-autoloads finder-inf
orgalist-autoloads compact-docstrings-autoloads altcaps-autoloads
tmr-autoloads bluetooth-autoloads dash-autoloads peg-autoloads
rcirc-color-autoloads objed-autoloads flylisp-autoloads
dict-tree-autoloads undo-tree-autoloads xpm-autoloads denote-autoloads
realgud-ipdb-autoloads vcard-autoloads lex-autoloads cpio-mode-autoloads
vertico-posframe-autoloads kmb-autoloads gnome-c-style-autoloads
websocket-autoloads wisitoken-grammar-mode-autoloads mmm-mode-autoloads
topspace-autoloads realgud-jdb-autoloads rainbow-mode-autoloads
js2-mode-autoloads ioccur-autoloads osm-autoloads
boxy-headings-autoloads shell-command+-autoloads url-scgi-autoloads
rbit-autoloads vertico-autoloads company-statistics-autoloads
sm-c-mode-autoloads gpr-mode-autoloads gnat-compiler-autoloads
wisi-autoloads xeft-autoloads web-server-autoloads swiper-autoloads
trie-autoloads heap-autoloads tNFA-autoloads queue-autoloads
vigenere-autoloads package-fixes-autoloads toc-mode-autoloads
ebdb-gnorb-autoloads cl-seq gnorb-autoloads ivy-explorer-autoloads
buffer-env-autoloads vc-backup-autoloads satchel-autoloads
xelb-autoloads cl-generic-autoloads easy-kill-autoloads
csharp-mode-autoloads aircon-theme-autoloads loccur-autoloads
aggressive-completion-autoloads webfeeder-autoloads boxy-autoloads
nftables-mode-autoloads consult-recoll-autoloads bnf-mode-autoloads
pabbrev-autoloads leaf-autoloads adaptive-wrap-autoloads
doc-toc-autoloads ztree-autoloads use-package-autoloads
bind-key-autoloads gpastel-autoloads cpupower-autoloads
ef-themes-autoloads transient-cycles-autoloads vundo-autoloads
pulsar-autoloads context-coloring-autoloads caps-lock-autoloads
persist-autoloads realgud-node-inspect-autoloads realgud-autoloads
test-simple-autoloads loc-changes-autoloads eldoc-eval-autoloads
psgml-autoloads frame-tabs-autoloads myers-autoloads eev-autoloads
names-autoloads kiwix-autoloads request-autoloads greenbar-autoloads
rec-mode-autoloads shen-mode-autoloads greader-autoloads
orderless-autoloads graphql-autoloads load-relative-autoloads
emms-autoloads nadvice-autoloads iterators-autoloads ruby-end-autoloads
load-dir-autoloads clipboard-collector-autoloads hook-helpers-autoloads
other-frame-window-autoloads company-ebdb-autoloads info ebdb-autoloads
company-autoloads assess-autoloads m-buffer-autoloads ivy-avy-autoloads
avy-autoloads ivy-autoloads corfu-doc-autoloads corfu-autoloads
posframe-autoloads filladapt-autoloads svg-lib-autoloads metar-autoloads
cl-lib-autoloads lv-autoloads embark-consult-autoloads consult-autoloads
embark-autoloads compat-autoloads seq-autoloads windresize-autoloads
ess-autoloads ustar-withsub-autoloads rudel-autoloads rudel-backend
warnings icons package browse-url url url-proxy url-privacy url-expand
url-methods url-history url-cookie generate-lisp-file url-domsuf
url-util mailcap url-handlers url-parse auth-source eieio eieio-core
cl-macs gv pcase password-cache json subr-x map byte-opt bytecomp
byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv
eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray button loaddefs theme-loaddefs
oclosure cl-preloaded faces cus-face macroexp files window
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget keymap hashtable-print-readable backquote threads dbusbind
inotify dynamic-setting system-font-setting font-render-setting cairo
x-toolkit xinput2 x multi-tty make-network-process emacs)

Memory information:
((conses 16 388053 88106) (symbols 48 31208 0) (strings 32 136422 27754)
 (string-bytes 1 4559676) (vectors 16 62698) (vector-slots 8 1632379 95074)
 (floats 8 909 226) (intervals 56 9145 68) (buffers 984 30))

Message #8 received at 62041 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 62041 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#62041: 30.0.50;
 RET bound to `comint-send-input` in C-mode buffer
Date: Wed, 08 Mar 2023 16:37:26 +0200

> Cc: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Tue, 07 Mar 2023 18:58:53 -0500
> From:  Stefan Monnier via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
>      % src/emacs -Q src/emacs.c
>      M-x gud-gdb RET
>      gdb --fullname emacs RET
>      b main RET
>      r -Q RET
>      C-x o         (to jump to the `emacs.c` buffer)
>      C-h k RET
> 
> at this last step, `C-h k` is expected to show RET is bound to `newline`
> since we're inside a C mode buffer, but instead it says:
> 
>     RET (translated from <return>) runs the command comint-send-input
>     (found in gud-minor-mode-map), which is an interactive native-compiled
>     Lisp function in ‘comint.el’.
> 
> This seems to be because `gud-minor-mode-map` is defined as having
> `gud-mode-map` as its parent.  `gud-mode-map` is a major mode map for
> a Comint buffer, so it's normal for it to rebind RET to something like
> `comint-send-input`, but it's clearly not right for `gud-minor-mode-map`.
> 
> This seems to come from commit 8bb5c1bfec0929f2ba419e1c503f5acc01c336c2
> but I don't understand why it was done this way.  Was it a plain "typo"?

gud-minor-mode is supposed to show the same Gud menu on the menu bar
as gud-mode, and is also supposed to support mouse clicking on the
fringe to set/unset breakpoints.  I believe this is the reason for the
above; it isn't a typo.  We need a better way of keeping the Gud menu
and the fringe mouse-click bindings without inheriting all the comint
stuff with that.

See also bug#61162, bug#61271, and bug#59605.

Message #11 received at 62041 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 62041 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#62041: 30.0.50; RET bound to `comint-send-input` in C-mode
 buffer
Date: Wed, 08 Mar 2023 11:36:36 -0500

>> This seems to come from commit 8bb5c1bfec0929f2ba419e1c503f5acc01c336c2
>> but I don't understand why it was done this way.  Was it a plain "typo"?
>
> gud-minor-mode is supposed to show the same Gud menu on the menu bar
> as gud-mode, and is also supposed to support mouse clicking on the
> fringe to set/unset breakpoints.

Ah, right.
Keymap inheritance inherits too much here, but it's the right tool,
indeed, thanks.

> We need a better way of keeping the Gud menu and the fringe
> mouse-click bindings without inheriting all the comint stuff
> with that.

I should be able to come up with a good patch, now that I understand
what's going on :-)


        Stefan

Message #18 received at 62041-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 62041-done <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#62041: 30.0.50; RET bound to `comint-send-input` in C-mode
 buffer
Date: Wed, 08 Mar 2023 15:15:39 -0500

> gud-minor-mode is supposed to show the same Gud menu on the menu bar
> as gud-mode, and is also supposed to support mouse clicking on the
> fringe to set/unset breakpoints.

AFAICT the fringe handling is a separate issue because those bindings
are only placed in the `gud-minor-mode-map`, so the inheritance from
`gud-mode-map` doesn't affect those.

I just pushed a patch which introduces a new map to share the menu
between the two keymaps so `gud-minor-mode-map` doesn't (need to)
inherit from `gud-mode-map` any more.

This should fix the problem (which was also labeled bug#61162 and bug#61271).


        Stefan

Message #31 received at 62041 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 62041 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#62041: 30.0.50; RET bound to `comint-send-input` in C-mode
 buffer
Date: Thu, 09 Mar 2023 10:30:11 +0200

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: 62041-done <at> debbugs.gnu.org,  larsi <at> gnus.org
> Date: Wed, 08 Mar 2023 15:15:39 -0500
> 
> > gud-minor-mode is supposed to show the same Gud menu on the menu bar
> > as gud-mode, and is also supposed to support mouse clicking on the
> > fringe to set/unset breakpoints.
> 
> AFAICT the fringe handling is a separate issue because those bindings
> are only placed in the `gud-minor-mode-map`, so the inheritance from
> `gud-mode-map` doesn't affect those.
> 
> I just pushed a patch which introduces a new map to share the menu
> between the two keymaps so `gud-minor-mode-map` doesn't (need to)
> inherit from `gud-mode-map` any more.
> 
> This should fix the problem (which was also labeled bug#61162 and bug#61271).

Thanks.

However, the fix is incomplete AFAICT: the "pseudo-toolbar" which
gdb-mi.el should show on TTY frames was lost.  Please compare the
display in "M-x gdb" in a TTY session between emacs-29 and master: the
former shows a kind of "text-mode tool bar" on the menu-bar line when
you are in the GUD buffer, and also if you are in a source buffer when
a gdb-mi session is active.  These "pseudo-toolbar" buttons are useful
if you have a mouse on a TTY terminal: you can click on these
"buttons" , and they work like the real tool bar on GUI frames.  On
master, these buttons no longer appear.  Can we have them back,
please?  (I guess more than just the menu should be shared between
gud-mode-map and gud-minor-mode-map?)

Message #34 received at 62041 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 62041 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#62041: 30.0.50; RET bound to `comint-send-input` in C-mode
 buffer
Date: Thu, 09 Mar 2023 10:01:02 -0500

>> This should fix the problem (which was also labeled bug#61162 and bug#61271).
>
> Thanks.
>
> However, the fix is incomplete AFAICT: the "pseudo-toolbar" which
> gdb-mi.el should show on TTY frames was lost.  Please compare the
> display in "M-x gdb" in a TTY session between emacs-29 and master: the
> former shows a kind of "text-mode tool bar" on the menu-bar line when
> you are in the GUD buffer, and also if you are in a source buffer when
> a gdb-mi session is active.  These "pseudo-toolbar" buttons are useful
> if you have a mouse on a TTY terminal: you can click on these
> "buttons" , and they work like the real tool bar on GUI frames.  On
> master, these buttons no longer appear.  Can we have them back,
> please?  (I guess more than just the menu should be shared between
> gud-mode-map and gud-minor-mode-map?)

I'll take a look,


        Stefan

Message #37 received at 62041 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 62041 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#62041: 30.0.50; RET bound to `comint-send-input` in C-mode
 buffer
Date: Thu, 09 Mar 2023 12:59:59 -0500

> However, the fix is incomplete AFAICT: the "pseudo-toolbar" which
> gdb-mi.el should show on TTY frames was lost.

Hmm... I must say I'm stumped: I have no idea where this pseudo-tool-bar
comes from in `emacs-29`.  Any hint?

> Please compare the display in "M-x gdb" in a TTY session between
> emacs-29 and master: the former shows a kind of "text-mode tool bar"
> on the menu-bar line when you are in the GUD buffer,

Indeed, I see it.  I'm unable to make use of it, OTOH.  I tried to
enable/disable `xt-mouse-mode` but that didn't help: clicking on those
entries seems to do nothing at all (and `C-h k` also just tells me).
I also noticed that F10 fails to "unroll" the menus in those buffers
where there is this funny pseudo-tool-bar.

> and also if you are in a source buffer when
> a gdb-mi session is active.  These "pseudo-toolbar" buttons are useful
> if you have a mouse on a TTY terminal: you can click on these
> "buttons" , and they work like the real tool bar on GUI frames.

I can click on the menu entries to "unroll" the corresponding menu, but
clicking on those pseudo-tool-bar thingies doesn't seem to do anything
at all (nothing in the echo area or in *Messages* either).

> On master, these buttons no longer appear.  Can we have them back,
> please?  (I guess more than just the menu should be shared between
> gud-mode-map and gud-minor-mode-map?)

The disappearance of the pseudo-tool-bar affects both `gud-minor-mode`
and `gud-mode` buffers, so I think it's not directly related to the
sharing between those two keymaps.

IOW, I think this is a different bug.


        Stefan

Message #40 received at 62041 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 62041 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#62041: 30.0.50; RET bound to `comint-send-input` in C-mode
 buffer
Date: Thu, 09 Mar 2023 20:14:42 +0200

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: 62041 <at> debbugs.gnu.org,  larsi <at> gnus.org
> Date: Thu, 09 Mar 2023 12:59:59 -0500
> 
> > However, the fix is incomplete AFAICT: the "pseudo-toolbar" which
> > gdb-mi.el should show on TTY frames was lost.
> 
> Hmm... I must say I'm stumped: I have no idea where this pseudo-tool-bar
> comes from in `emacs-29`.  Any hint?

I think it comes from gud-tool-bar-map.  gdb-get-buffer-create has
this:

            (setq-local tool-bar-map gud-tool-bar-map)

> > Please compare the display in "M-x gdb" in a TTY session between
> > emacs-29 and master: the former shows a kind of "text-mode tool bar"
> > on the menu-bar line when you are in the GUD buffer,
> 
> Indeed, I see it.  I'm unable to make use of it, OTOH.  I tried to
> enable/disable `xt-mouse-mode` but that didn't help: clicking on those
> entries seems to do nothing at all (and `C-h k` also just tells me).
> I also noticed that F10 fails to "unroll" the menus in those buffers
> where there is this funny pseudo-tool-bar.

It works with a real mouse (here on MS-Windows, and I believe also
with GPM).  If xt-mouse-mode doesn't work with it, I guess it's some
bug.

> > and also if you are in a source buffer when
> > a gdb-mi session is active.  These "pseudo-toolbar" buttons are useful
> > if you have a mouse on a TTY terminal: you can click on these
> > "buttons" , and they work like the real tool bar on GUI frames.
> 
> I can click on the menu entries to "unroll" the corresponding menu, but
> clicking on those pseudo-tool-bar thingies doesn't seem to do anything
> at all (nothing in the echo area or in *Messages* either).

It does here: if I click on "next", execution moves by one source
line.

> The disappearance of the pseudo-tool-bar affects both `gud-minor-mode`
> and `gud-mode` buffers, so I think it's not directly related to the
> sharing between those two keymaps.
> 
> IOW, I think this is a different bug.

Maybe.

Message #43 received at 62041 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: monnier <at> iro.umontreal.ca
Cc: 62041 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#62041: 30.0.50;
 RET bound to `comint-send-input` in C-mode buffer
Date: Thu, 09 Mar 2023 21:38:02 +0200

> Cc: 62041 <at> debbugs.gnu.org, larsi <at> gnus.org
> Date: Thu, 09 Mar 2023 20:14:42 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> > Cc: 62041 <at> debbugs.gnu.org,  larsi <at> gnus.org
> > Date: Thu, 09 Mar 2023 12:59:59 -0500
> > 
> > > However, the fix is incomplete AFAICT: the "pseudo-toolbar" which
> > > gdb-mi.el should show on TTY frames was lost.
> > 
> > Hmm... I must say I'm stumped: I have no idea where this pseudo-tool-bar
> > comes from in `emacs-29`.  Any hint?
> 
> I think it comes from gud-tool-bar-map.  gdb-get-buffer-create has
> this:
> 
>             (setq-local tool-bar-map gud-tool-bar-map)

No, that's wrong.  Those buttons come from here:

(easy-mmode-defmap gud-minor-mode-map
  (append
     `(([menu-bar debug] . ("Gud" . ,gud-menu-map)))
     ;; Get tool bar like functionality from the menu bar on a text only
     ;; terminal.
   (unless window-system
     `(([menu-bar down]
	. (,(propertize "down" 'face 'font-lock-doc-face) . gud-down))
       ([menu-bar up]
	. (,(propertize "up" 'face 'font-lock-doc-face) . gud-up))
       ([menu-bar finish]
	. (,(propertize "finish" 'face 'font-lock-doc-face) . gud-finish))
       ([menu-bar step]
	. (,(propertize "step" 'face 'font-lock-doc-face) . gud-step))
       ([menu-bar next]
	. (,(propertize "next" 'face 'font-lock-doc-face) . gud-next))
       ([menu-bar until] menu-item
	,(propertize "until" 'face 'font-lock-doc-face) gud-until
		  :visible (memq gud-minor-mode '(gdbmi gdb perldb)))
       ([menu-bar cont] menu-item
	,(propertize "cont" 'face 'font-lock-doc-face) gud-cont
	:visible (not (eq gud-minor-mode 'gdbmi)))
       ([menu-bar run] menu-item
	,(propertize "run" 'face 'font-lock-doc-face) gud-run
	:visible (memq gud-minor-mode '(gdbmi gdb dbx jdb)))
       ([menu-bar go] menu-item
	,(propertize " go " 'face 'font-lock-doc-face) gud-go
	:visible (and (eq gud-minor-mode 'gdbmi)
                      (gdb-show-run-p)))
       ([menu-bar stop] menu-item
	,(propertize "stop" 'face 'font-lock-doc-face) gud-stop-subjob
	:visible (or (and (eq gud-minor-mode 'gdbmi)
                          (gdb-show-stop-p))
		     (not (eq gud-minor-mode 'gdbmi))))
       ([menu-bar print]
	. (,(propertize "print" 'face 'font-lock-doc-face) . gud-print))
       ([menu-bar tools] . undefined)
       ([menu-bar buffer] . undefined)
       ([menu-bar options] . undefined)
       ([menu-bar edit] . undefined)
       ([menu-bar file] . undefined))))
  "Map used in visited files.")

Message #46 received at 62041 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 62041 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#62041: 30.0.50; RET bound to `comint-send-input` in C-mode
 buffer
Date: Thu, 09 Mar 2023 15:28:07 -0500

> No, that's wrong.  Those buttons come from here:
>
> (easy-mmode-defmap gud-minor-mode-map
>   (append
>      `(([menu-bar debug] . ("Gud" . ,gud-menu-map)))
>      ;; Get tool bar like functionality from the menu bar on a text only
>      ;; terminal.
>    (unless window-system
>      `(([menu-bar down]
> 	. (,(propertize "down" 'face 'font-lock-doc-face) . gud-down))
>        ([menu-bar up]
> 	. (,(propertize "up" 'face 'font-lock-doc-face) . gud-up))
>        ([menu-bar finish]
> 	. (,(propertize "finish" 'face 'font-lock-doc-face) . gud-finish))
>        ([menu-bar step]
> 	. (,(propertize "step" 'face 'font-lock-doc-face) . gud-step))
>        ([menu-bar next]
> 	. (,(propertize "next" 'face 'font-lock-doc-face) . gud-next))
>        ([menu-bar until] menu-item
> 	,(propertize "until" 'face 'font-lock-doc-face) gud-until
> 		  :visible (memq gud-minor-mode '(gdbmi gdb perldb)))
>        ([menu-bar cont] menu-item
> 	,(propertize "cont" 'face 'font-lock-doc-face) gud-cont
> 	:visible (not (eq gud-minor-mode 'gdbmi)))
>        ([menu-bar run] menu-item
> 	,(propertize "run" 'face 'font-lock-doc-face) gud-run
> 	:visible (memq gud-minor-mode '(gdbmi gdb dbx jdb)))
>        ([menu-bar go] menu-item
> 	,(propertize " go " 'face 'font-lock-doc-face) gud-go
> 	:visible (and (eq gud-minor-mode 'gdbmi)
>                       (gdb-show-run-p)))
>        ([menu-bar stop] menu-item
> 	,(propertize "stop" 'face 'font-lock-doc-face) gud-stop-subjob
> 	:visible (or (and (eq gud-minor-mode 'gdbmi)
>                           (gdb-show-stop-p))
> 		     (not (eq gud-minor-mode 'gdbmi))))
>        ([menu-bar print]
> 	. (,(propertize "print" 'face 'font-lock-doc-face) . gud-print))
>        ([menu-bar tools] . undefined)
>        ([menu-bar buffer] . undefined)
>        ([menu-bar options] . undefined)
>        ([menu-bar edit] . undefined)
>        ([menu-bar file] . undefined))))
>   "Map used in visited files.")

Duh, I was looking at the wrong file version, no wonder I couldn't
find it.  Thanks,


        Stefan

Message #49 received at 62041 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 62041 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#62041: 30.0.50; RET bound to `comint-send-input` in C-mode
 buffer
Date: Thu, 09 Mar 2023 16:20:10 -0500

> No, that's wrong.  Those buttons come from here:

They should be back now (they work when I make them appear in GUI
frames, so I assume they'll work as well as before in text frames).


        Stefan

Message #52 received at 62041 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 62041 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#62041: 30.0.50; RET bound to `comint-send-input` in C-mode
 buffer
Date: Fri, 10 Mar 2023 09:17:11 +0200

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: 62041 <at> debbugs.gnu.org,  larsi <at> gnus.org
> Date: Thu, 09 Mar 2023 16:20:10 -0500
> 
> > No, that's wrong.  Those buttons come from here:
> 
> They should be back now (they work when I make them appear in GUI
> frames, so I assume they'll work as well as before in text frames).

They work, indeed, thanks.  But there's a strange regression: the
"Gud" menu is absent from the menu bar, only on GUI frames; it is
there on TTY frames.

Message #55 received at 62041 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 62041 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#62041: 30.0.50; RET bound to `comint-send-input` in C-mode
 buffer
Date: Fri, 10 Mar 2023 12:23:05 -0500

> They work, indeed, thanks.  But there's a strange regression: the
> "Gud" menu is absent from the menu bar, only on GUI frames; it is
> there on TTY frames.

Oops, should be fixed now,


        Stefan

Message #58 received at 62041 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 62041 <at> debbugs.gnu.org, larsi <at> gnus.org
Subject: Re: bug#62041: 30.0.50; RET bound to `comint-send-input` in C-mode
 buffer
Date: Sat, 11 Mar 2023 10:19:36 +0200

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: 62041 <at> debbugs.gnu.org,  larsi <at> gnus.org
> Date: Fri, 10 Mar 2023 12:23:05 -0500
> 
> > They work, indeed, thanks.  But there's a strange regression: the
> > "Gud" menu is absent from the menu bar, only on GUI frames; it is
> > there on TTY frames.
> 
> Oops, should be fixed now,

Yes, fixed.

Thanks, I think this issue can now be finally put to rest.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.