GNU bug report logs - #62077
[PATCH] gnu: Add python-slugid.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62077 in the body.
You can then email your comments to 62077 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Faiz <adam.faiz <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: jgart <at> dismail.de, lars <at> 6xq.net
Subject: [PATCH] gnu: Add python-slugid.
Date: Fri, 10 Mar 2023 00:46:11 +0800

From f788ce8ebc205a6e05bcc270865d793d94bf51e9 Mon Sep 17 00:00:00 2001
Message-Id: <f788ce8ebc205a6e05bcc270865d793d94bf51e9.1678379861.git.adam.faiz <at> disroot.org>
From: AwesomeAdam54321 <adam.faiz <at> disroot.org>
Date: Thu, 9 Mar 2023 21:39:13 +0800
Subject: [PATCH] gnu: Add python-slugid.

* gnu/packages/python-xyz.scm (python-slugid): New variable.
---
 gnu/packages/python-xyz.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 83f3ec02ea..4bacd86432 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -1096,6 +1096,23 @@ (define-public python-slixmpp
     (home-page "https://lab.louiz.org/poezio/slixmpp")
     (license license:expat)))
 
+(define-public python-slugid
+  (package
+    (name "python-slugid")
+    (version "2.0.0")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "slugid" version))
+              (sha256
+               (base32
+                "15x2kgzi38b023brfyng0y907am2qi1jgifnsjyph4b9fa5xjl59"))))
+    (build-system python-build-system)
+    (home-page "http://taskcluster.github.io/slugid.py/")
+    (synopsis "Module for Base64 encoded UUID v4 slugs")
+    (description "Slugid.py is a module for generating v4 UUIDs and
+encoding them into 22 character URL-safe base64 slug representation.")
+    (license license:mpl2.0)))
+
 (define-public python-tenacity
   (package
     (name "python-tenacity")

base-commit: 5befcff66edb4d72ab8e713c81836fb8519ce3e6
-- 
2.39.2

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Adam Faiz" <adam.faiz <at> disroot.org>, guix-patches <at> gnu.org
Cc: lars <at> 6xq.net
Subject: Re: [PATCH] gnu: Add python-slugid.
Date: Thu, 09 Mar 2023 18:03:33 +0000

Hi, 

I'll test this out from my end today and report back. Thanks for the patch!

all best,

jgart

Message #11 received at 62077 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 62077 <at> debbugs.gnu.org
Cc: lars <at> 6xq.net, jgart <jgart <at> dismail.de>, Adam Faiz <adam.faiz <at> disroot.org>
Subject: [PATCH v2] gnu: Add python-slugid.
Date: Fri, 31 Mar 2023 13:19:29 -0500

* gnu/packages/python-xyz.scm (python-slugid): New variable.

Co-authored-by: jgart <jgart <at> dismail.de>
---

Hi Adam,

Thanks for the patch and sorry for the delay in reviewing this. I've
been busy. I've attached a version 2 of your patch with modifications.
I've also added myself as a "co-author" since I've made a few changes
to your patch.

I modified the package to take the source from GitHub since the GitHub
repository includes the tests and the PyPi version does not. We usually
try to enable the tests on all of our packages when available and
practical. I added a phase in the arguments <package> field implementing
that.

I also added a comment mentioning that tests are run by nose via tox. In
my approach here I just run nose directly and forego using tox.

Hi Lars, 

WDYT. Can this be merged? I don't have commit access so someone
else would have to merge it.

all best,

jgart

 gnu/packages/python-xyz.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index ca6c68ec7c..5c44817afa 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -16801,6 +16801,36 @@ (define-public python-rarfile
 is made as zipfile like as possible.")
     (license license:isc)))
 
+(define-public python-slugid
+  (package
+    (name "python-slugid")
+    (version "2.0.0")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+              (url "https://github.com/taskcluster/slugid.py")
+              (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32 "1h64p2jlqv6lsmw8h2j203kx3bhv72cwzpk5gdhsaamw30cp3h1i"))))
+    (build-system python-build-system)
+    (native-inputs (list python-nose))
+    (arguments
+      (list #:phases
+        #~(modify-phases %standard-phases
+            (replace 'check
+              (lambda* (#:key inputs tests? #:allow-other-keys)
+                (when tests?
+                  ;; The project uses tox to run the tests via nose.
+                  (invoke "nosetests" "-v" "test.py")))))))
+    (home-page "http://taskcluster.github.io/slugid.py")
+    (synopsis "Module for Base64 encoded UUID v4 slugs")
+    (description "This package provides a module for generating v4
+UUIDs and encoding them into 22 character URL-safe base64 slug
+representation.")
+    (license license:mpl2.0)))
+
 (define-public python-rich
   (package
     (name "python-rich")
-- 
2.39.2

Message #14 received at 62077 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "AwesomeAdam54321" <adam.faiz <at> disroot.org>, 62077 <at> debbugs.gnu.org
Subject: RE: [PATCH v2] gnu: Add python-slugid.
Date: Fri, 19 May 2023 06:03:25 +0000

Hi Adam,

I merged v2. Thanks for your contribution to GNU Guix.

all best,

jgart

Message #17 received at 62077 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: 62077 <at> debbugs.gnu.org
Date: Fri, 19 May 2023 06:04:34 +0000

done

Message #20 received at 62077 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: 62077 <at> debbugs.gnu.org
Date: Fri, 19 May 2023 06:15:13 +0000

close 62077

Message #23 received at 62077 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: 62077 <at> debbugs.gnu.org
Date: Fri, 19 May 2023 06:27:34 +0000

"close 62077"

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.