GNU bug report logs - #62109
29.0.60; rust-ts-mode missing indentation for patterns

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62109 in the body.
You can then email your comments to 62109 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Bug Report Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.60; rust-ts-mode missing indentation for patterns
Date: Fri, 10 Mar 2023 14:32:42 -0800

X-Debbugs-CC: dev <at> rjt.dev

Try this snippet:

fn main() {
    match &cli.command {
        Commands::Run {
a,
b,
c,
d,
        } => todo!(),
    }
}


The a, b, c, d don’t have corresponding indentation rules. I can add
some myself, but I’m not sure where to add and what’s the best rule to
add.

Yuan

Message #8 received at 62109 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 62109 <at> debbugs.gnu.org
Subject: Re: bug#62109: 29.0.60; rust-ts-mode missing indentation for patterns
Date: Sat, 11 Mar 2023 02:03:13 +0000

[Message part 1 (text/plain, inline)]

On Friday, March 10th, 2023 at 17:32, Yuan Fu <casouri <at> gmail.com> wrote:
> 
> X-Debbugs-CC: dev <at> rjt.dev
> 
> Try this snippet:
> 
> fn main() {
> match &cli.command {
> Commands::Run {
> a,
> b,
> c,
> d,
> } => todo!(),
> 
> }
> }
> 
> 
> The a, b, c, d don’t have corresponding indentation rules. I can add
> some myself, but I’m not sure where to add and what’s the best rule to
> add.
> 
> Yuan
> 

Thanks for the report, I've attached a patch fixing it.

[0001-Add-missing-indentation-rule-for-rust-ts-mode.patch (text/x-patch, attachment)]

Message #11 received at 62109 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 62109 <at> debbugs.gnu.org
Subject: Re: bug#62109: 29.0.60; rust-ts-mode missing indentation for patterns
Date: Sat, 11 Mar 2023 02:04:59 +0000

[Message part 1 (text/plain, inline)]

On Friday, March 10th, 2023 at 21:03, Randy Taylor <dev <at> rjt.dev> wrote:
> 
> On Friday, March 10th, 2023 at 17:32, Yuan Fu casouri <at> gmail.com wrote:
> 
> > X-Debbugs-CC: dev <at> rjt.dev
> > 
> > Try this snippet:
> > 
> > fn main() {
> > match &cli.command {
> > Commands::Run {
> > a,
> > b,
> > c,
> > d,
> > } => todo!(),
> > 
> > }
> > }
> > 
> > The a, b, c, d don’t have corresponding indentation rules. I can add
> > some myself, but I’m not sure where to add and what’s the best rule to
> > add.
> > 
> > Yuan
> 
> 
> Thanks for the report, I've attached a patch fixing it.

Sorry, forgot to include the bug #. Same patch with the bug # this time!

[0001-Add-missing-indentation-rule-for-rust-ts-mode-Bug-62.patch (text/x-patch, attachment)]

Message #16 received at 62109-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 62109-done <at> debbugs.gnu.org
Subject: Re: bug#62109: 29.0.60; rust-ts-mode missing indentation for patterns
Date: Sat, 11 Mar 2023 15:53:21 -0800

[Message part 1 (text/plain, inline)]

> On Mar 10, 2023, at 6:04 PM, Randy Taylor <dev <at> rjt.dev> wrote:
> 
> On Friday, March 10th, 2023 at 21:03, Randy Taylor <dev <at> rjt.dev> wrote:
>> 
>> On Friday, March 10th, 2023 at 17:32, Yuan Fu casouri <at> gmail.com wrote:
>> 
>>> X-Debbugs-CC: dev <at> rjt.dev
>>> 
>>> Try this snippet:
>>> 
>>> fn main() {
>>> match &cli.command {
>>> Commands::Run {
>>> a,
>>> b,
>>> c,
>>> d,
>>> } => todo!(),
>>> 
>>> }
>>> }
>>> 
>>> The a, b, c, d don’t have corresponding indentation rules. I can add
>>> some myself, but I’m not sure where to add and what’s the best rule to
>>> add.
>>> 
>>> Yuan
>> 
>> 
>> Thanks for the report, I've attached a patch fixing it.
> 
> Sorry, forgot to include the bug #. Same patch with the bug # this time!
> 

[0001-Add-missing-indentation-rule-for-rust-ts-mode-Bug-62.patch (application/octet-stream, attachment)]

[Message part 3 (text/plain, inline)]

Brilliant, thanks! I applied it.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.