GNU bug report logs - #62123
[PATCH 3/4] gnu: Add emacs-pippel.

Previous Next

Package: guix-patches;

Reported by: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>

Date: Sat, 11 Mar 2023 14:51:03 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62123 in the body.
You can then email your comments to 62123 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#62123; Package guix-patches. (Sat, 11 Mar 2023 14:51:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Rostislav Svoboda <rostislav.svoboda <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 11 Mar 2023 14:51:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Rostislav Svoboda <Rostislav.Svoboda <at> gmail.com>
Subject: [PATCH 3/4] gnu: Add emacs-pippel.
Date: Sat, 11 Mar 2023 15:49:37 +0100
* gnu/packages/emacs-xyz.scm (emacs-pippel): New variable.
---
 gnu/packages/emacs-xyz.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d371cfd6f3..cbd0e64e65 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -17358,6 +17358,44 @@ (define-public emacs-pinyinlib
 letter of Pinyin to Simplified/Traditional Chinese characters.")
     (license license:gpl3+)))
 
+(define-public emacs-pippel
+  (let ((commit "cb194952ee150e77601d3233dabdb521b976ee79")
+        (revision "0"))
+    (package
+      (name "emacs-pippel")
+      (version (git-version "1.4" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/arifer612/pippel")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "17606l24yyrjxa4rc0p2zj50lfbayqldw4phhi59yqf61289d520"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       (list emacs-dash emacs-s))
+      (inputs
+       (list python))
+      (arguments
+       (list
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'substitute-curl-path
+              (lambda* (#:key inputs #:allow-other-keys)
+                (emacs-substitute-variables "plz.el"
+                  ("pippel-python-command" (search-input-file
+                                            inputs "/bin/python"))))))))
+      (home-page "https://github.com/arifer612/pippel")
+      (synopsis "Emacs frontend to Python package manager pip")
+      (description
+       "Emacs frontend for the Python package manager pip.  As pippel also uses
+@code{tabulated-list-mode}, it provides a similar package menu like
+@code{package-list-packages}.")
+      (license license:gpl3+))))
+
 (define-public emacs-reverse-im
   (package
     (name "emacs-reverse-im")
-- 
2.39.2





Information forwarded to guix-patches <at> gnu.org:
bug#62123; Package guix-patches. (Mon, 13 Mar 2023 13:03:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Re: [PATCH 3/4] gnu: Add emacs-pippel.
Date: Mon, 13 Mar 2023 14:01:52 +0100
Oh, the patch is broken, ignore it. sorry. Here's a correction. Please
have a look at the 'python2 vs. python3' comment. Is it OK to make it
work just for python3?

Cheers
Bost

From 29c79c13c4cdfe5c6014cd9ba35cea41a465a106 Mon Sep 17 00:00:00 2001
From: Rostislav Svoboda <Rostislav.Svoboda <at> gmail.com>
Date: Sat, 11 Mar 2023 15:36:11 +0100
Subject: [PATCH 3/4] gnu: Add emacs-pippel.

* gnu/packages/emacs-xyz.scm (emacs-pippel): New variable.
---
 gnu/packages/emacs-xyz.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d371cfd6f3..f4e557e98a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -17358,6 +17358,43 @@ (define-public emacs-pinyinlib
 letter of Pinyin to Simplified/Traditional Chinese characters.")
     (license license:gpl3+)))

+(define-public emacs-pippel
+  (let ((commit "cb194952ee150e77601d3233dabdb521b976ee79")
+        (revision "0"))
+    (package
+      (name "emacs-pippel")
+      (version (git-version "1.4" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/arifer612/pippel")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "17606l24yyrjxa4rc0p2zj50lfbayqldw4phhi59yqf61289d520"))))
+      (build-system emacs-build-system)
+      (inputs (list python))
+      (propagated-inputs (list emacs-dash emacs-s))
+      (arguments
+       (list #:phases #~(modify-phases %standard-phases
+                          (add-after 'unpack 'substitute-python-path
+                            (lambda* (#:key inputs #:allow-other-keys)
+                              (emacs-substitute-variables "pippel.el"
+
("pippel-python-command"
+                                                           (search-input-file
+                                                            inputs
+;;; For 'python2 vs. python3' see the choice:
+;;; https://github.com/arifer612/pippel/blob/cb194952ee150e77601d3233dabdb521b976ee79/pippel.el#L65
+
"/bin/python3"))))))))
+      (home-page "https://github.com/arifer612/pippel")
+      (synopsis "Emacs frontend to Python package manager pip")
+      (description
+       "Emacs frontend for the Python package manager pip.  As pippel also uses
+@code{tabulated-list-mode}, it provides a similar package menu like
+@code{package-list-packages}.")
+      (license license:gpl3+))))
+
 (define-public emacs-reverse-im
   (package
     (name "emacs-reverse-im")
-- 
2.39.2




Information forwarded to guix-patches <at> gnu.org:
bug#62123; Package guix-patches. (Fri, 17 Mar 2023 08:53:02 GMT) Full text and rfc822 format available.

Message #11 received at 62123 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
Cc: 62123 <at> debbugs.gnu.org
Subject: Re: [bug#62123] [PATCH 3/4] gnu: Add emacs-pippel.
Date: Fri, 17 Mar 2023 09:51:54 +0100
Hello,

Rostislav Svoboda <rostislav.svoboda <at> gmail.com> writes:

> Oh, the patch is broken, ignore it. sorry. Here's a correction.

Thanks. Some comments follow.

> Please have a look at the 'python2 vs. python3' comment. Is it OK to
> make it work just for python3?

Guix does not support Python 2 anymore. Note, however,
that you can provide `python-wrapper' as input instead of `python', and
use "python" executable. Anyway sticking to "python3" is OK.

> +      (inputs (list python))
> +      (propagated-inputs (list emacs-dash emacs-s))

Nitpick: usually, inputs and propagated inputs are located after arguments.

> +      (arguments
> +       (list #:phases #~(modify-phases %standard-phases

You can add a newline characther after `list' and another one after
`#:phases'.

> +                          (add-after 'unpack 'substitute-python-path
> +                            (lambda* (#:key inputs #:allow-other-keys)
> +                              (emacs-substitute-variables "pippel.el"
> +
> ("pippel-python-command"
> +                                                           (search-input-file
> +                                                            inputs
> +;;; For 'python2 vs. python3' see the choice:
> +;;; https://github.com/arifer612/pippel/blob/cb194952ee150e77601d3233dabdb521b976ee79/pippel.el#L65
> +
> "/bin/python3"))))))))
> +      (home-page "https://github.com/arifer612/pippel")
> +      (synopsis "Emacs frontend to Python package manager pip")

pip -> Pip

> +      (description
> +       "Emacs frontend for the Python package manager pip.  As pippel also uses
> +@code{tabulated-list-mode}, it provides a similar package menu like
> +@code{package-list-packages}.")

The first sentence is not complete : "Pippel is an Emacs…"

Also, pip -> Pip, pippel -> Pippel, @code{tabulated-list-mode} ->
Tabulated List mode.

> +      (license license:gpl3+))))

I think you also need to include "pippel.py" file through #:include
keyword and possibly configure `pippel-package-path'.

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#62123; Package guix-patches. (Tue, 28 Mar 2023 22:35:01 GMT) Full text and rfc822 format available.

Message #14 received at 62123 <at> debbugs.gnu.org (full text, mbox):

From: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 62123 <at> debbugs.gnu.org
Subject: Re: [bug#62123] [PATCH 3/4] gnu: Add emacs-pippel.
Date: Wed, 29 Mar 2023 00:34:13 +0200
Hi Nicolas

> Nitpick: usually, inputs and propagated inputs are located after arguments.

Done

> > +      (arguments
> > +       (list #:phases #~(modify-phases %standard-phases
>
> You can add a newline characther after `list' and another one after
> `#:phases'.

Done

> Also, pip -> Pip, pippel -> Pippel

Done

> I think you also need to include "pippel.py" file through #:include

Done

> keyword and possibly configure `pippel-package-path'.

Done. Please have a look if it's done correctly.

Cheers
Bost




From 4b83e10686d8189568b756fe514d0be0d2c54750 Mon Sep 17 00:00:00 2001
From: Rostislav Svoboda <Rostislav.Svoboda <at> gmail.com>
Date: Wed, 29 Mar 2023 00:15:12 +0200
Subject: [PATCH] gnu: Add emacs-pippel.

* gnu/packages/emacs-xyz.scm (emacs-pippel): New variable.
---
 gnu/packages/emacs-xyz.scm | 48 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index da2856abc8..1cdaccd366 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -17288,6 +17288,54 @@ (define-public emacs-php-mode
 documentation search and a source and class browser.")
     (license license:gpl3+)))

+(define-public emacs-pippel
+  (let ((commit "cb194952ee150e77601d3233dabdb521b976ee79")
+        (revision "0"))
+    (package
+      (name "emacs-pippel")
+      (version (git-version "0.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/arifer612/pippel")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "17606l24yyrjxa4rc0p2zj50lfbayqldw4phhi59yqf61289d520"))))
+      (build-system emacs-build-system)
+      (arguments
+       (list
+        #:include #~(cons "^pippel\\.py$" %default-include)
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'substitute-pippel-package-path
+              (lambda* (#:key outputs #:allow-other-keys)
+                (let* ((out (assoc-ref outputs "out"))
+                       (package-path (string-append
+                                      out
+                                      "/share/emacs/site-lisp/pippel-"
+                                      #$version)))
+                  (emacs-substitute-variables "pippel.el"
+                    ("pippel-package-path"
+                     package-path)))))
+            (add-after 'unpack 'substitute-python-path
+              (lambda* (#:key inputs #:allow-other-keys)
+                (emacs-substitute-variables "pippel.el"
+                  ("pippel-python-command"
+                   (search-input-file
+                    inputs
+                    "/bin/python"))))))))
+      (inputs (list python-wrapper))
+      (propagated-inputs (list emacs-dash emacs-s))
+      (home-page "https://github.com/arifer612/pippel")
+      (synopsis "Emacs frontend to Python package manager Pip")
+      (description
+       "Pippel is an Emacs frontend for the Python package manager Pip.  As
+Pippel also uses Tabulated List mode, it provides a similar package menu like
+@code{package-list-packages}.")
+      (license license:gpl3+))))
+
 (define-public emacs-pos-tip
   (package
     (name "emacs-pos-tip")
-- 
2.39.2




Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Thu, 30 Mar 2023 10:39:01 GMT) Full text and rfc822 format available.

Notification sent to Rostislav Svoboda <rostislav.svoboda <at> gmail.com>:
bug acknowledged by developer. (Thu, 30 Mar 2023 10:39:02 GMT) Full text and rfc822 format available.

Message #19 received at 62123-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Rostislav Svoboda <rostislav.svoboda <at> gmail.com>
Cc: 62123-done <at> debbugs.gnu.org
Subject: Re: [bug#62123] [PATCH 3/4] gnu: Add emacs-pippel.
Date: Thu, 30 Mar 2023 12:38:40 +0200
Hello,

Rostislav Svoboda <rostislav.svoboda <at> gmail.com> writes:

> Done. Please have a look if it's done correctly.

Applied with the change below. Thank you.
> +            (add-after 'unpack 'substitute-pippel-package-path
> +              (lambda* (#:key outputs #:allow-other-keys)
> +                (let* ((out (assoc-ref outputs "out"))
> +                       (package-path (string-append
> +                                      out
> +                                      "/share/emacs/site-lisp/pippel-"
> +                                      #$version)))

I used `elpa-directory' here, and removed `out' binding.

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 27 Apr 2023 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 337 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.