GNU bug report logs - #62132
[PATCH] gnu: Add cyanrip.

Previous Next

Package: guix-patches;

Reported by: simon <at> netpanic.org

Date: Sat, 11 Mar 2023 22:31:02 UTC

Severity: normal

Tags: patch

To reply to this bug, email your comments to 62132 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#62132; Package guix-patches. (Sat, 11 Mar 2023 22:31:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to simon <at> netpanic.org:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 11 Mar 2023 22:31:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: simon <at> netpanic.org
To: guix-patches <at> gnu.org
Cc: Simon Streit <simon <at> netpanic.org>
Subject: [PATCH] gnu: Add cyanrip.
Date: Sat, 11 Mar 2023 23:30:17 +0100
From: Simon Streit <simon <at> netpanic.org>

* gnu/packages/audio.scm (cyanrip): New variable.
---
 gnu/packages/audio.scm | 30 +++++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 6f3fa2a580..966a0b96f9 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -38,7 +38,7 @@
 ;;; Copyright © 2021 Aleksandr Vityazev <avityazev <at> posteo.org>
 ;;; Copyright © 2022 Arjan Adriaanse <arjan <at> adriaan.se>
 ;;; Copyright © 2022 Juliana Sims <jtsims <at> protonmail.com>
-;;; Copyright © 2022 Simon Streit <simon <at> netpanic.org>
+;;; Copyright © 2022, 2023 Simon Streit <simon <at> netpanic.org>
 ;;; Copyright © 2022 Andy Tai <atai <at> atai.org>
 ;;; Copyright © 2023 Sergiu Ivanov <sivanov <at> colimite.fr>
 ;;; Copyright © 2023 David Thompson <dthompson2 <at> worcester.edu>
@@ -68,6 +68,7 @@ (define-module (gnu packages audio)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages build-tools)
   #:use-module (gnu packages boost)
+  #:use-module (gnu packages cdrom)
   #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages curl)
@@ -124,6 +125,7 @@ (define-module (gnu packages audio)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages valgrind)
+  #:use-module (gnu packages version-control)
   #:use-module (gnu packages video)
   #:use-module (gnu packages vim) ;xxd
   #:use-module (gnu packages web)
@@ -6316,3 +6318,29 @@ (define-public cubeb
       (description "Cubeb is Mozilla's cross-platform audio library.")
       (home-page "https://github.com/mozilla/cubeb")
       (license license:isc))))
+
+(define-public cyanrip
+  (package
+    (name "cyanrip")
+    (version "0.9.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/cyanreg/cyanrip")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1pf381qmqr3p3xk26w8v4gfv5cyi5siljs4gv485spsq6icynzw0"))))
+    (build-system meson-build-system)
+    (native-inputs
+     (list pkg-config))
+    (propagated-inputs
+     (list curl ffmpeg libcdio-paranoia libmusicbrainz libxml2 neon))
+    (synopsis "Fully featured CD ripping program")
+    (description "Console CD ripper with automatic tagging through integration
+with MusicBrainz , error detection, log generation, many formats, HDCD
+decoding, covert art automatic download.")
+    (home-page "https://github.com/cyanreg/cyanrip")
+    (license license:lgpl2.1+)))
-- 
2.39.1





Information forwarded to guix-patches <at> gnu.org:
bug#62132; Package guix-patches. (Mon, 13 Mar 2023 20:43:02 GMT) Full text and rfc822 format available.

Message #8 received at 62132 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: simon <at> netpanic.org, 62132 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add cyanrip.
Date: Mon, 13 Mar 2023 21:42:30 +0100
Am Samstag, dem 11.03.2023 um 23:30 +0100 schrieb simon <at> netpanic.org:
> From: Simon Streit <simon <at> netpanic.org>
> 
> * gnu/packages/audio.scm (cyanrip): New variable.
> ---
>  gnu/packages/audio.scm | 30 +++++++++++++++++++++++++++++-
>  1 file changed, 29 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 6f3fa2a580..966a0b96f9 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -38,7 +38,7 @@
>  ;;; Copyright © 2021 Aleksandr Vityazev <avityazev <at> posteo.org>
>  ;;; Copyright © 2022 Arjan Adriaanse <arjan <at> adriaan.se>
>  ;;; Copyright © 2022 Juliana Sims <jtsims <at> protonmail.com>
> -;;; Copyright © 2022 Simon Streit <simon <at> netpanic.org>
> +;;; Copyright © 2022, 2023 Simon Streit <simon <at> netpanic.org>
>  ;;; Copyright © 2022 Andy Tai <atai <at> atai.org>
>  ;;; Copyright © 2023 Sergiu Ivanov <sivanov <at> colimite.fr>
>  ;;; Copyright © 2023 David Thompson <dthompson2 <at> worcester.edu>
> @@ -68,6 +68,7 @@ (define-module (gnu packages audio)
>    #:use-module (gnu packages bison)
>    #:use-module (gnu packages build-tools)
>    #:use-module (gnu packages boost)
> +  #:use-module (gnu packages cdrom)
>    #:use-module (gnu packages check)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages curl)
> @@ -124,6 +125,7 @@ (define-module (gnu packages audio)
>    #:use-module (gnu packages linux)
>    #:use-module (gnu packages tls)
>    #:use-module (gnu packages valgrind)
> +  #:use-module (gnu packages version-control)
>    #:use-module (gnu packages video)
>    #:use-module (gnu packages vim) ;xxd
>    #:use-module (gnu packages web)
> @@ -6316,3 +6318,29 @@ (define-public cubeb
>        (description "Cubeb is Mozilla's cross-platform audio
> library.")
>        (home-page "https://github.com/mozilla/cubeb")
>        (license license:isc))))
> +
> +(define-public cyanrip
> +  (package
> +    (name "cyanrip")
> +    (version "0.9.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/cyanreg/cyanrip")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "1pf381qmqr3p3xk26w8v4gfv5cyi5siljs4gv485spsq6icynzw0"))))
> +    (build-system meson-build-system)
> +    (native-inputs
> +     (list pkg-config))
> +    (propagated-inputs
> +     (list curl ffmpeg libcdio-paranoia libmusicbrainz libxml2
> neon))
Propagated inputs are not that great, prefer normal ones.  Also don't
let the lines get too long.
> +    (synopsis "Fully featured CD ripping program")
Avoid marketing buzzwords; perhaps use "Console CD ripper" instead?
> +    (description "Console CD ripper with automatic tagging through
> integration
> +with MusicBrainz , error detection, log generation, many formats,
> HDCD
> +decoding, covert art automatic download.")
Please use complete sentences for the description.

Cheers




This bug report was last modified 1 year and 43 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.