GNU bug report logs - #62155
30.0.50; elixir-ts-mode.elc warning

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62155 in the body.
You can then email your comments to 62155 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; elixir-ts-mode.elc warning
Date: Mon, 13 Mar 2023 10:06:50 +0800

I get this building elixir-ts-mode:

  ELC      progmodes/elixir-ts-mode.elc
Warning (treesit): Cannot activate tree-sitter, because tree-sitter library is not compiled with Emacs

Would someone please DTRT?

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ruijie Yu <ruijie <at> netyu.xyz>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 62155 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#62155: 30.0.50; elixir-ts-mode.elc warning
Date: Mon, 13 Mar 2023 19:03:46 +0800

Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org> writes:

> I get this building elixir-ts-mode:
>
>   ELC      progmodes/elixir-ts-mode.elc
> Warning (treesit): Cannot activate tree-sitter, because tree-sitter library is not compiled with Emacs
>
> Would someone please DTRT?

Have you checked mid:83sfeat1jy.fsf <at> gnu.org (the end of bug#61996
thread)?  It seems that there has since been a fix to your problem.  If
even after the fix you still observe the problem, maybe Eli and Wilhelm
can chime in to help.

--
Best,


RY

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
To: Ruijie Yu <ruijie <at> netyu.xyz>
Cc: Po Lu <luangruo <at> yahoo.com>, 62155 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#62155: 30.0.50; elixir-ts-mode.elc warning
Date: Mon, 13 Mar 2023 15:08:10 +0200

Ruijie Yu via "Bug reports for GNU Emacs, the Swiss army knife of 
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of 
> text editors" <bug-gnu-emacs <at> gnu.org> writes:
>
>> I get this building elixir-ts-mode:
>>
>>   ELC      progmodes/elixir-ts-mode.elc
>> Warning (treesit): Cannot activate tree-sitter, because 
>> tree-sitter library is not compiled with Emacs
>>
>> Would someone please DTRT?
>
> Have you checked mid:83sfeat1jy.fsf <at> gnu.org (the end of 
> bug#61996
> thread)?  It seems that there has since been a fix to your 
> problem.  If
> even after the fix you still observe the problem, maybe Eli and 
> Wilhelm
> can chime in to help.

I can see there is still an issue with loading heex-ts-mode from 
elixir-ts-mode, but not quite sure how to
immediately resolve it. I will have a look in a couple of hours.

The problem is in the top of elixir-ts-mode.el: (require 
'heex-ts-mode) and then we call
(treesit-ready-p 'heex) in heex-ts-mode. I guess the intention 
with the
convention here was to only load the -ts-mode when the user 
explicitly requires, but it
breaks the way I called (require 'heex-ts-mode) from 
elixir-ts-mode.el.

Message #20 received at 62155 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
Cc: ruijie <at> netyu.xyz, luangruo <at> yahoo.com, 62155 <at> debbugs.gnu.org
Subject: Re: bug#62155: 30.0.50; elixir-ts-mode.elc warning
Date: Mon, 13 Mar 2023 16:33:18 +0200

> Cc: luangruo <at> yahoo.com, 62155 <at> debbugs.gnu.org
> From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
> Date: Mon, 13 Mar 2023 15:08:10 +0200
> 
> I can see there is still an issue with loading heex-ts-mode from 
> elixir-ts-mode, but not quite sure how to
> immediately resolve it. I will have a look in a couple of hours.

One possibility is to add defvar for each variable defined by
heex-ts-mode that elixir-ts-mode needs to use, and remove the require
of heex-ts-mode.  Since heex-ts-mode is loaded at run time, I think
this should be enough.

> The problem is in the top of elixir-ts-mode.el: (require 
> 'heex-ts-mode) and then we call
> (treesit-ready-p 'heex) in heex-ts-mode.

Yes.

> I guess the intention with the convention here was to only load the
> -ts-mode when the user explicitly requires, but it breaks the way I
> called (require 'heex-ts-mode) from elixir-ts-mode.el.

Yes.

Message #23 received at 62155 <at> debbugs.gnu.org (full text, mbox):

From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: ruijie <at> netyu.xyz, luangruo <at> yahoo.com, 62155 <at> debbugs.gnu.org
Subject: Re: bug#62155: 30.0.50; elixir-ts-mode.elc warning
Date: Mon, 13 Mar 2023 22:07:27 +0200

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: luangruo <at> yahoo.com, 62155 <at> debbugs.gnu.org
>> From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
>> Date: Mon, 13 Mar 2023 15:08:10 +0200
>> 
>> I can see there is still an issue with loading heex-ts-mode 
>> from 
>> elixir-ts-mode, but not quite sure how to
>> immediately resolve it. I will have a look in a couple of 
>> hours.
>
> One possibility is to add defvar for each variable defined by
> heex-ts-mode that elixir-ts-mode needs to use, and remove the 
> require
> of heex-ts-mode.  Since heex-ts-mode is loaded at run time, I 
> think
> this should be enough.
>

Thank you, this seems to work well.

[0001-Fix-elixir-ts-mode.elc-warning-bug-62155.patch (text/x-patch, attachment)]

Message #28 received at 62155-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
Cc: ruijie <at> netyu.xyz, luangruo <at> yahoo.com, 62155-done <at> debbugs.gnu.org
Subject: Re: bug#62155: 30.0.50; elixir-ts-mode.elc warning
Date: Thu, 16 Mar 2023 09:53:30 +0200

> From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
> Cc: ruijie <at> netyu.xyz, luangruo <at> yahoo.com, 62155 <at> debbugs.gnu.org
> Date: Mon, 13 Mar 2023 22:07:27 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> Cc: luangruo <at> yahoo.com, 62155 <at> debbugs.gnu.org
> >> From: Wilhelm Kirschbaum <wkirschbaum <at> gmail.com>
> >> Date: Mon, 13 Mar 2023 15:08:10 +0200
> >> 
> >> I can see there is still an issue with loading heex-ts-mode 
> >> from 
> >> elixir-ts-mode, but not quite sure how to
> >> immediately resolve it. I will have a look in a couple of 
> >> hours.
> >
> > One possibility is to add defvar for each variable defined by
> > heex-ts-mode that elixir-ts-mode needs to use, and remove the 
> > require
> > of heex-ts-mode.  Since heex-ts-mode is loaded at run time, I 
> > think
> > this should be enough.
> >
> 
> Thank you, this seems to work well.

Thanks, installed on the master branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.