GNU bug report logs - #62156
[PATCH 0/1] gnu: Add atftp.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62156 in the body.
You can then email your comments to 62156 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: guix-patches <at> gnu.org
Cc: Felix Lechner <felix.lechner <at> lease-up.com>
Subject: [PATCH 0/1] gnu: Add atftp.
Date: Sun, 12 Mar 2023 21:41:38 -0700

Hi,

I am not sure whether the mirror:// URL is right. It works, but there are two
lint warnings:

gnu/packages/networking.scm:2946:15: atftp <at> 0.8.0: URI https://www.gnu.org/software/atftp/ not reachable: 404 ("Not Found")
gnu/packages/networking.scm:2921:12: atftp <at> 0.8.0: source not archived on Software Heritage and missing from the Disarchive database

Kind regards,
Felix Lechner

* * *

Felix Lechner (1):
  gnu: Add atftp.

 gnu/packages/networking.scm | 41 +++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)


base-commit: 9584b1daa687d1212550841d1c5f62e7ffa44ffc
-- 
2.39.1

Message #8 received at 62156 <at> debbugs.gnu.org (full text, mbox):

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: 62156 <at> debbugs.gnu.org
Cc: Felix Lechner <felix.lechner <at> lease-up.com>
Subject: [PATCH 1/1] gnu: Add atftp.
Date: Sun, 12 Mar 2023 21:42:29 -0700

* gnu/packages/networking.scm (atftp): New variable.
---
 gnu/packages/networking.scm | 41 +++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index b6cbd8e80a..bae7848632 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2914,6 +2914,47 @@ (define-public speedtest-cli
 speedtest.net.")
     (license license:asl2.0)))
 
+(define-public atftp
+  (package
+    (name "atftp")
+    (version "0.8.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://sourceforge/" name "/"
+                                  name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "05pk6x70wsad1fjnx4l2a7f859dn5ifqwng582mrw3v7qy4s0anz"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'autoreconf
+            (lambda _
+              (invoke "autoreconf" "-vif"))))))
+    (native-inputs
+     (list autoconf
+           automake
+           perl
+           pkg-config))
+    (inputs (list
+             pcre2
+             procps
+             readline
+             tcp-wrappers))
+    (home-page "https://www.gnu.org/software/atftp/")
+    (synopsis "Advanced TFTP server and client")
+    (description
+     "Multi-threaded TFTP server that implements all options, including all
+extensions, as specified in RFC 1350, RFC 2090, RFC 2347, RFC 2348, RFC 2349
+and RFC7440.  Atftpd also supports a multicast protocol known as mtftp, which
+was defined in the PXE specification.
+
+The server is socket activated by default but supports being started from
+inetd(8) as well as in daemon mode.")
+    (license license:gpl2)))
+
 (define-public tftp-hpa
   (package
     (name "tftp-hpa")
-- 
2.39.1

Message #11 received at 62156 <at> debbugs.gnu.org (full text, mbox):

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: 62156 <at> debbugs.gnu.org
Cc: Felix Lechner <felix.lechner <at> lease-up.com>
Subject: [PATCH v2] gnu: Add atftp.
Date: Sun, 19 Mar 2023 16:03:51 -0700

* gnu/packages/networking.scm (atftp): New variable.

The new URL still produces a lint warning. A user on IRC surmised that
sf.net may filter by user agent:

    atftp <at> 0.8.0: URI https://git.code.sf.net/p/atftp/code not reachable:
        404 ("Not Found")

The same user states that Git makes this request:

    GET /p/atftp/code/info/refs?service=git-upload-pack HTTP/1.1

Thanks to Josselin Poiret and Bruno Victal for their generous and detailed
reviews of this item!
---
 gnu/packages/networking.scm | 43 +++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 3fac05c411..7f843214fb 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2916,6 +2916,49 @@ (define-public speedtest-cli
 speedtest.net.")
     (license license:asl2.0)))
 
+(define-public atftp
+  (package
+    (name "atftp")
+    (version "0.8.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://git.code.sf.net/p/atftp/code")
+             (commit (string-append "v" version))))
+       (sha256
+        (base32 "019qrh2wpvr577ksvs3s82q6kiqm5i6869aj7qba326b59lhkxrc"))
+       (file-name (git-file-name name version))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'autoreconf
+            (lambda _
+              (invoke "autoreconf" "-vif"))))))
+    (native-inputs
+     (list autoconf
+           automake
+           perl
+           pkg-config))
+    (inputs
+     (list pcre2
+           procps
+           readline
+           tcp-wrappers))
+    (home-page "https://sourceforge.net/projects/atftp/")
+    (synopsis "Advanced TFTP server and client")
+    (description
+     "Multi-threaded TFTP server that implements all options, including all
+extensions, as specified in RFC 1350, RFC 2090, RFC 2347, RFC 2348, RFC 2349
+and RFC7440.  Atftpd also supports a multicast protocol known as mtftp, which
+was defined in the PXE specification.
+
+The server is socket activated by default but supports being started from
+inetd(8) as well as in daemon mode.")
+    (license license:gpl2+)))
+
 (define-public tftp-hpa
   (package
     (name "tftp-hpa")

base-commit: f9702aa9fdfded5c62da43197f8cea5eeba30803
-- 
2.39.1

Message #14 received at 62156 <at> debbugs.gnu.org (full text, mbox):

From: Sergey Trofimov <sarg <at> sarg.org.ru>
To: 62156 <at> debbugs.gnu.org
Cc: felix.lechner <at> lease-up.com
Subject: [bug#62156] [PATCH v2] gnu: Add atftp.
Date: Mon, 20 Mar 2023 08:34:58 +0100

Hi, I've checked that the package builds fine on my machine.
Also you might want to fix the linter, so that it appends 
`info/refs` to the git-reference url.
See here: 
https://git.savannah.gnu.org/cgit/guix.git/tree/guix/lint.scm?h=1f36534c7e8f2325bff4df5d37ecc811dc63fc38#n1227

Message #17 received at 62156 <at> debbugs.gnu.org (full text, mbox):

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: 62156 <at> debbugs.gnu.org
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>,
 Felix Lechner <felix.lechner <at> lease-up.com>
Subject: [PATCH v3 1/2] gnu: Add atftp.
Date: Mon, 20 Mar 2023 09:57:18 -0700

* gnu/packages/networking.scm (atftp): New variable.

Thanks to Josselin Poiret and Bruno Victal for their generous and detailed
reviews of this item!
---
 gnu/packages/networking.scm | 43 +++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 3fac05c411..7f843214fb 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2916,6 +2916,49 @@ (define-public speedtest-cli
 speedtest.net.")
     (license license:asl2.0)))
 
+(define-public atftp
+  (package
+    (name "atftp")
+    (version "0.8.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://git.code.sf.net/p/atftp/code")
+             (commit (string-append "v" version))))
+       (sha256
+        (base32 "019qrh2wpvr577ksvs3s82q6kiqm5i6869aj7qba326b59lhkxrc"))
+       (file-name (git-file-name name version))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'autoreconf
+            (lambda _
+              (invoke "autoreconf" "-vif"))))))
+    (native-inputs
+     (list autoconf
+           automake
+           perl
+           pkg-config))
+    (inputs
+     (list pcre2
+           procps
+           readline
+           tcp-wrappers))
+    (home-page "https://sourceforge.net/projects/atftp/")
+    (synopsis "Advanced TFTP server and client")
+    (description
+     "Multi-threaded TFTP server that implements all options, including all
+extensions, as specified in RFC 1350, RFC 2090, RFC 2347, RFC 2348, RFC 2349
+and RFC7440.  Atftpd also supports a multicast protocol known as mtftp, which
+was defined in the PXE specification.
+
+The server is socket activated by default but supports being started from
+inetd(8) as well as in daemon mode.")
+    (license license:gpl2+)))
+
 (define-public tftp-hpa
   (package
     (name "tftp-hpa")

base-commit: f9702aa9fdfded5c62da43197f8cea5eeba30803
-- 
2.39.1

Message #20 received at 62156 <at> debbugs.gnu.org (full text, mbox):

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: 62156 <at> debbugs.gnu.org
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>,
 Felix Lechner <felix.lechner <at> lease-up.com>
Subject: [PATCH v3 2/2] lint: Append "/info/refs" to git-reference-url.
Date: Mon, 20 Mar 2023 09:57:19 -0700

For the atftp package added in the preceeding commit, lint produced this
warning:

  gnu/packages/networking.scm:2924:5: atftp <at> 0.8.0:
    URI https://git.code.sf.net/p/atftp/code not reachable:
      404 ("Not Found")

Thanks to Sergey Trofimov for suggesting a fix! [1]

  [1]  https://issues.guix.gnu.org/62156#3

It was implemented here, and the warning disappeared.

* guix/lint.scm (check-source): Append "/info/refs" to git-reference-url.

Co-authored-by: Sergey Trofimov <sarg <at> sarg.org.ru>
---
 guix/lint.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/guix/lint.scm b/guix/lint.scm
index a1a27873d9..394d68c472 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -1224,7 +1224,9 @@ (define (warnings-for-uris uris)
                 '())))
          ((git-reference? (origin-uri origin))
           (warnings-for-uris
-           (list (string->uri (git-reference-url (origin-uri origin))))))
+           (list (string->uri (string-append
+                               (git-reference-url (origin-uri origin))
+                               "/info/refs")))))
          ((or (svn-reference? (origin-uri origin))
               (svn-multi-reference? (origin-uri origin)))
           (let ((uri (svn-reference-uri-with-userinfo (origin-uri origin))))
-- 
2.39.1

Message #23 received at 62156 <at> debbugs.gnu.org (full text, mbox):

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: 62156 <at> debbugs.gnu.org
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>,
 Felix Lechner <felix.lechner <at> lease-up.com>
Subject: [PATCH v4 1/2] gnu: Add atftp.
Date: Mon, 20 Mar 2023 21:25:40 -0700

* gnu/packages/networking.scm (atftp): New variable.

Thanks to Josselin Poiret and Bruno Victal for their generous and detailed
reviews of this item!
---
 gnu/packages/networking.scm | 43 +++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 3fac05c411..7f843214fb 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -2916,6 +2916,49 @@ (define-public speedtest-cli
 speedtest.net.")
     (license license:asl2.0)))
 
+(define-public atftp
+  (package
+    (name "atftp")
+    (version "0.8.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://git.code.sf.net/p/atftp/code")
+             (commit (string-append "v" version))))
+       (sha256
+        (base32 "019qrh2wpvr577ksvs3s82q6kiqm5i6869aj7qba326b59lhkxrc"))
+       (file-name (git-file-name name version))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'autoreconf
+            (lambda _
+              (invoke "autoreconf" "-vif"))))))
+    (native-inputs
+     (list autoconf
+           automake
+           perl
+           pkg-config))
+    (inputs
+     (list pcre2
+           procps
+           readline
+           tcp-wrappers))
+    (home-page "https://sourceforge.net/projects/atftp/")
+    (synopsis "Advanced TFTP server and client")
+    (description
+     "Multi-threaded TFTP server that implements all options, including all
+extensions, as specified in RFC 1350, RFC 2090, RFC 2347, RFC 2348, RFC 2349
+and RFC7440.  Atftpd also supports a multicast protocol known as mtftp, which
+was defined in the PXE specification.
+
+The server is socket activated by default but supports being started from
+inetd(8) as well as in daemon mode.")
+    (license license:gpl2+)))
+
 (define-public tftp-hpa
   (package
     (name "tftp-hpa")

base-commit: f9702aa9fdfded5c62da43197f8cea5eeba30803
-- 
2.39.1

Message #26 received at 62156 <at> debbugs.gnu.org (full text, mbox):

From: Felix Lechner <felix.lechner <at> lease-up.com>
To: 62156 <at> debbugs.gnu.org
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>,
 Felix Lechner <felix.lechner <at> lease-up.com>
Subject: [PATCH v4 2/2] lint: Append "/info/refs" to git-reference-url.
Date: Mon, 20 Mar 2023 21:25:41 -0700

For the atftp package added in the preceeding commit, lint produced this
warning:

  gnu/packages/networking.scm:2924:5: atftp <at> 0.8.0:
    URI https://git.code.sf.net/p/atftp/code not reachable:
      404 ("Not Found")

Thanks to Sergey Trofimov for suggesting a fix! [1]

  [1]  https://issues.guix.gnu.org/62156#3

It was implemented here, and the warning disappeared.

* guix/lint.scm (check-source): Append "/info/refs" to git-reference-url.

Co-authored-by: Sergey Trofimov <sarg <at> sarg.org.ru>
---
 guix/lint.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/guix/lint.scm b/guix/lint.scm
index a1a27873d9..8d0887739d 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -1224,7 +1224,14 @@ (define (warnings-for-uris uris)
                 '())))
          ((git-reference? (origin-uri origin))
           (warnings-for-uris
-           (list (string->uri (git-reference-url (origin-uri origin))))))
+           ;; for atftp, lint produced a warning:
+           ;;   gnu/packages/networking.scm:2924:5: atftp <at> 0.8.0:
+           ;;     URI https://git.code.sf.net/p/atftp/code not reachable:
+           ;;     404 ("Not Found")
+           ;; fix from here:  https://issues.guix.gnu.org/62156#3
+           (list (string->uri (string-append
+                               (git-reference-url (origin-uri origin))
+                               "/info/refs")))))
          ((or (svn-reference? (origin-uri origin))
               (svn-multi-reference? (origin-uri origin)))
           (let ((uri (svn-reference-uri-with-userinfo (origin-uri origin))))
-- 
2.39.1

Message #31 received at 62156-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Felix Lechner <felix.lechner <at> lease-up.com>
Cc: Sergey Trofimov <sarg <at> sarg.org.ru>, 62156-done <at> debbugs.gnu.org
Subject: Re: bug#62156: [PATCH 0/1] gnu: Add atftp.
Date: Mon, 27 Mar 2023 18:49:19 +0200

Hi,

Felix Lechner <felix.lechner <at> lease-up.com> skribis:

> * gnu/packages/networking.scm (atftp): New variable.
>
> Thanks to Josselin Poiret and Bruno Victal for their generous and detailed
> reviews of this item!

I tweaked the description (to start with a full sentence) and passed it
through ‘guix style’.

> For the atftp package added in the preceeding commit, lint produced this
> warning:
>
>   gnu/packages/networking.scm:2924:5: atftp <at> 0.8.0:
>     URI https://git.code.sf.net/p/atftp/code not reachable:
>       404 ("Not Found")
>
> Thanks to Sergey Trofimov for suggesting a fix! [1]
>
>   [1]  https://issues.guix.gnu.org/62156#3
>
> It was implemented here, and the warning disappeared.
>
> * guix/lint.scm (check-source): Append "/info/refs" to git-reference-url.
>
> Co-authored-by: Sergey Trofimov <sarg <at> sarg.org.ru>

Nice.  I adjusted ‘tests/lint.scm’ accordingly.

Applied both; thank you, and thanks to the reviewers!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.