GNU bug report logs - #62201
[PATCH] gnu: Add payload-dumper.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62201 in the body.
You can then email your comments to 62201 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: conses <contact <at> conses.eu>
To: guix-patches <at> gnu.org
Cc: contact <at> conses.eu
Subject: [PATCH] gnu: Add payload-dumper.
Date: Wed, 15 Mar 2023 13:34:01 +0100

* gnu/packages/android.scm (payload-dumper): New variable.
---
 gnu/packages/android.scm | 53 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
index 881b75d763..d7a308775f 100644
--- a/gnu/packages/android.scm
+++ b/gnu/packages/android.scm
@@ -51,6 +51,7 @@ (define-module (gnu packages android)
   #:use-module (gnu packages java)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages pcre)
+  #:use-module (gnu packages protobuf)
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-crypto)
   #:use-module (gnu packages python-web)
@@ -982,6 +983,58 @@ (define-public git-repo
 script that you can put anywhere in your path.")
     (license license:asl2.0)))
 
+(define-public payload-dumper
+  (let ((commit "35134a28d641deda899c30aed57aace21bfd4a3c")
+        (revision "0"))
+    (package
+      (name "payload-dumper")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/vm03/payload_dumper")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1sdq6dgva5yxz147bkv8xbf79pz60vwc33f0cmj9awgfbxha2b43"))))
+      (inputs
+       (list python-3 python-protobuf python-six python-bsdiff4))
+      (build-system python-build-system)
+      (arguments
+       (list
+        #:use-setuptools? #f
+        #:tests? #f
+        #:phases
+        #~(modify-phases %standard-phases
+            (delete 'build)
+            (replace 'install
+              (lambda* (#:key outputs #:allow-other-keys)
+                (begin
+                  (use-modules (guix build utils))
+                  (let* ((python (string-append
+                                  #$(this-package-input "python")
+                                  "/bin"))
+                         (bin (string-append #$output "/bin"))
+                         (target (string-append bin "/payload_dumper"))
+                         (version (python-version
+                                   #$(this-package-input "python")))
+                         (pydir (string-append #$output "/lib/python"
+                                               version "/site-packages")))
+                    (mkdir-p bin)
+                    (copy-file (string-append #$source "/payload_dumper.py")
+                               target)
+                    (install-file "update_metadata_pb2.py" pydir)
+                    (substitute* target
+                      (("/usr/bin/env python") (which "python3")))
+                    (chmod target #o555))))))))
+      (synopsis "Android OTA payload dumper")
+      (description "Script to extract the payload of incremental and full
+OTA's.")
+      (home-page "https://github.com/vm03/payload_dumper")
+      (license license:gpl3+))))
+
 (define-public abootimg
   (package
     (name "abootimg")
-- 
2.39.1



-- 
Best regards,
conses

Message #8 received at 62201 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: conses <contact <at> conses.eu>, 62201 <at> debbugs.gnu.org
Cc: contact <at> conses.eu, me <at> mianmoreno.com
Subject: Re: [bug#62201] [PATCH] gnu: Add payload-dumper.
Date: Tue, 13 Jun 2023 14:58:57 +0400

[Message part 1 (text/plain, inline)]

On 2023-03-15 13:34, conses wrote:

> * gnu/packages/android.scm (payload-dumper): New variable.
> ---
>  gnu/packages/android.scm | 53 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)
>
> diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
> index 881b75d763..d7a308775f 100644
> --- a/gnu/packages/android.scm
> +++ b/gnu/packages/android.scm
> @@ -51,6 +51,7 @@ (define-module (gnu packages android)
>    #:use-module (gnu packages java)
>    #:use-module (gnu packages linux)
>    #:use-module (gnu packages pcre)
> +  #:use-module (gnu packages protobuf)
>    #:use-module (gnu packages python)
>    #:use-module (gnu packages python-crypto)
>    #:use-module (gnu packages python-web)
> @@ -982,6 +983,58 @@ (define-public git-repo
>  script that you can put anywhere in your path.")
>      (license license:asl2.0)))
>  
> +(define-public payload-dumper
> +  (let ((commit "35134a28d641deda899c30aed57aace21bfd4a3c")
> +        (revision "0"))
> +    (package
> +      (name "payload-dumper")
> +      (version (git-version "0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri
> +          (git-reference
> +           (url "https://github.com/vm03/payload_dumper")
> +           (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "1sdq6dgva5yxz147bkv8xbf79pz60vwc33f0cmj9awgfbxha2b43"))))
> +      (inputs
> +       (list python-3 python-protobuf python-six python-bsdiff4))
> +      (build-system python-build-system)
> +      (arguments
> +       (list
> +        #:use-setuptools? #f
> +        #:tests? #f
> +        #:phases
> +        #~(modify-phases %standard-phases
> +            (delete 'build)
> +            (replace 'install
> +              (lambda* (#:key outputs #:allow-other-keys)
> +                (begin
> +                  (use-modules (guix build utils))
> +                  (let* ((python (string-append
> +                                  #$(this-package-input "python")
> +                                  "/bin"))
> +                         (bin (string-append #$output "/bin"))
> +                         (target (string-append bin "/payload_dumper"))
> +                         (version (python-version
> +                                   #$(this-package-input "python")))
> +                         (pydir (string-append #$output "/lib/python"
> +                                               version "/site-packages")))
> +                    (mkdir-p bin)
> +                    (copy-file (string-append #$source "/payload_dumper.py")
> +                               target)
> +                    (install-file "update_metadata_pb2.py" pydir)
> +                    (substitute* target
> +                      (("/usr/bin/env python") (which "python3")))
> +                    (chmod target #o555))))))))
> +      (synopsis "Android OTA payload dumper")
> +      (description "Script to extract the payload of incremental and full
> +OTA's.")
> +      (home-page "https://github.com/vm03/payload_dumper")
> +      (license license:gpl3+))))
> +
>  (define-public abootimg
>    (package
>      (name "abootimg")
> -- 
> 2.39.1

Hi Miguel!

I can't find the license for this project, can you ask an author to
specify it, please?

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 62201 <at> debbugs.gnu.org (full text, mbox):

From: Miguel Ángel Moreno <mail <at> migalmoreno.com>
To: 62201 <at> debbugs.gnu.org
Cc: mail <at> migalmoreno.com, Andrew Tropin <andrew <at> trop.in>
Subject: Re: [PATCH] gnu: Add payload-dumper.
Date: Wed, 28 Jun 2023 09:51:41 +0200

[Message part 1 (text/plain, inline)]

Hi Andrew,

Thanks for having a look.  I raised an issue on the repo, but
the maintainer told me he isn't the original author of the tool and thus
doesn't feel comfortable adding a license to it, see
<https://github.com/vm03/payload_dumper/issues/58>.  How should we
proceed in this case?

-- 
Best regards,
Miguel Ángel Moreno

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 62201 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Miguel Ángel Moreno <mail <at> migalmoreno.com>,
 62201 <at> debbugs.gnu.org
Cc: mail <at> migalmoreno.com, Ludovic Courtès <ludo <at> gnu.org>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [PATCH] gnu: Add payload-dumper.
Date: Thu, 29 Jun 2023 17:14:11 +0400

[Message part 1 (text/plain, inline)]

On 2023-06-28 09:51, Miguel Ángel Moreno wrote:

> Hi Andrew,
>
> Thanks for having a look.  I raised an issue on the repo, but
> the maintainer told me he isn't the original author of the tool and thus
> doesn't feel comfortable adding a license to it, see
> <https://github.com/vm03/payload_dumper/issues/58>.  How should we
> proceed in this case?

I would summon more advanced in this topic colleagues :)

CCed Ludo and Liliana.

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 62201 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Andrew Tropin <andrew <at> trop.in>, Miguel Ángel Moreno
 <mail <at> migalmoreno.com>, 62201 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [PATCH] gnu: Add payload-dumper.
Date: Thu, 29 Jun 2023 18:59:08 +0200

Am Donnerstag, dem 29.06.2023 um 17:14 +0400 schrieb Andrew Tropin:
> On 2023-06-28 09:51, Miguel Ángel Moreno wrote:
> 
> > Hi Andrew,
> > 
> > Thanks for having a look.  I raised an issue on the repo, but
> > the maintainer told me he isn't the original author of the tool and
> > thus doesn't feel comfortable adding a license to it, see
> > <https://github.com/vm03/payload_dumper/issues/58>.  How should we
> > proceed in this case?
> 
> I would summon more advanced in this topic colleagues :)
> 
> CCed Ludo and Liliana.
No license, no original source?  No, thanks.  
For more background, see [1,2].

Cheers

[1] https://www.gnu.org/licenses/license-list.html#NoLicense
[2] https://www.gnu.org/licenses/license-list.html.en#NoLicense

Message #20 received at 62201 <at> debbugs.gnu.org (full text, mbox):

From: Miguel Ángel Moreno <mail <at> migalmoreno.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: mail <at> migalmoreno.com,
 Ludovic Courtès <ludo <at> gnu.org>,
 62201 <at> debbugs.gnu.org, Andrew Tropin <andrew <at> trop.in>
Subject: Re: [PATCH] gnu: Add payload-dumper.
Date: Fri, 30 Jun 2023 10:52:13 +0200

On 2023-06-29 18:59, Liliana Marie Prikler wrote:

> Am Donnerstag, dem 29.06.2023 um 17:14 +0400 schrieb Andrew Tropin:
>> On 2023-06-28 09:51, Miguel Ángel Moreno wrote:
>> 
>> > Hi Andrew,
>> > 
>> > Thanks for having a look.  I raised an issue on the repo, but
>> > the maintainer told me he isn't the original author of the tool and
>> > thus doesn't feel comfortable adding a license to it, see
>> > <https://github.com/vm03/payload_dumper/issues/58>.  How should we
>> > proceed in this case?
>> 
>> I would summon more advanced in this topic colleagues :)
>> 
>> CCed Ludo and Liliana.
> No license, no original source?  No, thanks.  
> For more background, see [1,2].
>
> Cheers
>
> [1] https://www.gnu.org/licenses/license-list.html#NoLicense
> [2] https://www.gnu.org/licenses/license-list.html.en#NoLicense

Thanks for the heads up.  Unless Ludo or someone else has some pointers
on what could be done to tackle this scenario, I'll try to package this
elsewhere.

-- 
Best regards,
Miguel Ángel Moreno

Message #25 received at 62201-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Miguel Ángel Moreno <mail <at> migalmoreno.com>
Cc: 62201-done <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [PATCH] gnu: Add payload-dumper.
Date: Mon, 10 Jul 2023 23:29:40 +0200

Hi,

Miguel Ángel Moreno <mail <at> migalmoreno.com> skribis:

> On 2023-06-29 18:59, Liliana Marie Prikler wrote:
>
>> Am Donnerstag, dem 29.06.2023 um 17:14 +0400 schrieb Andrew Tropin:
>>> On 2023-06-28 09:51, Miguel Ángel Moreno wrote:
>>> 
>>> > Hi Andrew,
>>> > 
>>> > Thanks for having a look.  I raised an issue on the repo, but
>>> > the maintainer told me he isn't the original author of the tool and
>>> > thus doesn't feel comfortable adding a license to it, see
>>> > <https://github.com/vm03/payload_dumper/issues/58>.  How should we
>>> > proceed in this case?
>>> 
>>> I would summon more advanced in this topic colleagues :)
>>> 
>>> CCed Ludo and Liliana.
>> No license, no original source?  No, thanks.  
>> For more background, see [1,2].
>>
>> Cheers
>>
>> [1] https://www.gnu.org/licenses/license-list.html#NoLicense
>> [2] https://www.gnu.org/licenses/license-list.html.en#NoLicense
>
> Thanks for the heads up.  Unless Ludo or someone else has some pointers
> on what could be done to tackle this scenario, I'll try to package this
> elsewhere.

Sorry for the delay!  If there’s no license, it’s indeed not
even distributable, so definitely not suitable for Guix.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.