GNU bug report logs - #6221
23.1; checkdoc-ispell-lisp-words when ispell already running

Previous Next

Package: emacs;

Reported by: Kevin Ryde <user42 <at> zip.com.au>

Date: Wed, 19 May 2010 23:30:03 UTC

Severity: minor

Tags: fixed, moreinfo

Found in version 23.1

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6221 in the body.
You can then email your comments to 6221 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6221; Package emacs. (Wed, 19 May 2010 23:30:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Kevin Ryde <user42 <at> zip.com.au>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 19 May 2010 23:30:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1; checkdoc-ispell-lisp-words when ispell already running
Date: Thu, 20 May 2010 09:29:17 +1000
[Message part 1 (text/plain, inline)]
When using the spell-checking feature of M-x checkdoc, if flyspell-mode
is enabled then the checkdoc-ispell-lisp-words are not recognised as
correct.  For example with the foo.el below

    (progn
      (setq checkdoc-spellcheck-documentation-flag t)
      (find-file "foo.el")
      (turn-on-flyspell)
      (checkdoc))

    => asks to correct spelling of "keymap"

It looks like checkdoc-ispell-init assumes that if an ispell-process
exists then it was checkdoc-ispell-init which started it and therefore
doesn't need the checkdoc-ispell-lisp-words sent again.  Of course
that's not the case if using flyspell, and presumably also not if you
use ispell.el directly and still have the process running.

Perhaps a flag meaning "checkdoc-ispell-lisp-words already sent" could
to be attached to the process object, to send just once.  Does it hurt
to send the words more than once?  The simplest thing could be to just
send them every time.

[foo.el (application/emacs-lisp, attachment)]
[Message part 3 (text/plain, inline)]

In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default-enable-multibyte-characters: t

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#6221; Package emacs. (Wed, 20 Jan 2021 20:53:01 GMT) Full text and rfc822 format available.

Message #8 received at 6221 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kevin Ryde <user42 <at> zip.com.au>
Cc: 6221 <at> debbugs.gnu.org
Subject: Re: bug#6221: 23.1; checkdoc-ispell-lisp-words when ispell already
 running
Date: Wed, 20 Jan 2021 21:52:03 +0100
Kevin Ryde <user42 <at> zip.com.au> writes:

> Perhaps a flag meaning "checkdoc-ispell-lisp-words already sent" could
> to be attached to the process object, to send just once.  Does it hurt
> to send the words more than once?  The simplest thing could be to just
> send them every time.

I've now changed this as you suggest in Emacs 28, but after committing
I'm not 100% sure that this is the correct thing to do, since this means
that "keymap" etc will now be valid in other buffers you use flyspell
in, too?  I think?

Should checkdoc kill the ispell process and start a new one?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) moreinfo. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 20 Jan 2021 20:53:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#6221; Package emacs. (Wed, 20 Jan 2021 21:17:02 GMT) Full text and rfc822 format available.

Message #13 received at 6221 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kevin Ryde <user42 <at> zip.com.au>
Cc: 6221 <at> debbugs.gnu.org
Subject: Re: bug#6221: 23.1; checkdoc-ispell-lisp-words when ispell already
 running
Date: Wed, 20 Jan 2021 22:15:56 +0100
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I've now changed this as you suggest in Emacs 28, but after committing
> I'm not 100% sure that this is the correct thing to do, since this means
> that "keymap" etc will now be valid in other buffers you use flyspell
> in, too?  I think?
>
> Should checkdoc kill the ispell process and start a new one?

Indeed.  The comment says:

;;   There is a list of Lisp-specific words which checkdoc will
;; install into Ispell on the fly, but only if Ispell is not already
;; running.  Use `ispell-kill-ispell' to make checkdoc restart it with
;; these words enabled.

So I've reverted the change, and instead added this text to the
checkdoc-spellcheck-documentation-flag doc string.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 20 Jan 2021 21:17:02 GMT) Full text and rfc822 format available.

bug marked as fixed in version 28.1, send any further explanations to 6221 <at> debbugs.gnu.org and Kevin Ryde <user42 <at> zip.com.au> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 20 Jan 2021 21:17:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 18 Feb 2021 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 40 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.