GNU bug report logs - #62254
[PATCH] guix: Shorten URL for home page in texlive importer.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62254 in the body.
You can then email your comments to 62254 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] guix: Shorten URL for home page in texlive importer.
Date: Sat, 18 Mar 2023 14:13:19 +0100

* guix/import/texlive.scm (tlpdb->package): Use short URL for home page.
---
 guix/import/texlive.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/guix/import/texlive.scm b/guix/import/texlive.scm
index 82014ee568..e77b2a3f9a 100644
--- a/guix/import/texlive.scm
+++ b/guix/import/texlive.scm
@@ -286,9 +286,10 @@ (define (tlpdb->package name version package-database)
                                            (string->symbol name)))
                                        inputs))))))
               '())
-        ,@(or (and=> (assoc-ref data 'catalogue-ctan)
-                     (lambda (url)
-                       `((home-page ,(string-append "https://ctan.org" url)))))
+        ,@(or (and=> (assoc-ref data 'name)
+                     (lambda (name)
+                       `((home-page ,(string-append "https://www.ctan.org/pkg/"
+                                                    name)))))
               '((home-page "https://www.tug.org/texlive/")))
         (synopsis ,(assoc-ref data 'shortdesc))
         (description ,(beautify-description

base-commit: 3893758dac76fc30b23d4715e849e262306f268d
-- 
2.39.2

Message #8 received at 62254 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 62254 <at> debbugs.gnu.org
Subject: Re: bug#62254: [PATCH] guix: Shorten URL for home page in texlive
 importer.
Date: Sun, 26 Mar 2023 16:19:53 +0200

Hi,

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> skribis:

> * guix/import/texlive.scm (tlpdb->package): Use short URL for home page.

[...]

> +        ,@(or (and=> (assoc-ref data 'name)
> +                     (lambda (name)
> +                       `((home-page ,(string-append "https://www.ctan.org/pkg/"
> +                                                    name)))))

Are there cases where ‘data’ might be missing ‘name’?

If not, please push!

Thanks,
Ludo’.

Message #13 received at 62254-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 62254-done <at> debbugs.gnu.org
Subject: Re: [bug#62254] [PATCH] guix: Shorten URL for home page in texlive
 importer.
Date: Thu, 30 Mar 2023 18:22:56 +0200

Hello,

Ludovic Courtès <ludo <at> gnu.org> writes:

>> +        ,@(or (and=> (assoc-ref data 'name)
>> +                     (lambda (name)
>> +                       `((home-page ,(string-append "https://www.ctan.org/pkg/"
>> +                                                    name)))))
>
> Are there cases where ‘data’ might be missing ‘name’?

I don't think so. And even if assoc-ref returns #false, the template
would get the default home page.

> If not, please push!

Done. Thanks for the feedback

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.