GNU bug report logs - #62276
29.0.60; image-minor-mode broken by c-ts-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62276 in the body.
You can then email your comments to 62276 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.60; image-minor-mode broken by c-ts-mode
Date: Sun, 19 Mar 2023 19:36:30 +0200

0. emacs-29 -Q
1. C-x C-f etc/images/attach.xpm RET
2. C-c C-c toggles from image to C code
3. C-c C-c toggles back from C code to image
4. C-x k RET

Everything works correctly so far.

4. M-: (require 'c-ts-mode) RET
5. C-x C-f etc/images/attach.xpm RET

It's not displayed as an image and C-c C-c does nothing.

Message #8 received at 62276 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 62276 <at> debbugs.gnu.org
Subject: Re: bug#62276: 29.0.60; image-minor-mode broken by c-ts-mode
Date: Sun, 19 Mar 2023 22:21:23 +0200

> From: Juri Linkov <juri <at> linkov.net>
> Date: Sun, 19 Mar 2023 19:36:30 +0200
> 
> 4. M-: (require 'c-ts-mode) RET
> 5. C-x C-f etc/images/attach.xpm RET
> 
> It's not displayed as an image and C-c C-c does nothing.

Thanks, should be fixed now on the emacs-29 branch.

Message #11 received at 62276 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 62276 <at> debbugs.gnu.org
Subject: Re: bug#62276: 29.0.60; image-minor-mode broken by c-ts-mode
Date: Mon, 20 Mar 2023 20:10:19 +0200

>> 4. M-: (require 'c-ts-mode) RET
>> 5. C-x C-f etc/images/attach.xpm RET
>>
>> It's not displayed as an image and C-c C-c does nothing.
>
> Thanks, should be fixed now on the emacs-29 branch.

Are there other modes that require such ad-hoc hacks?
Is there a problem with this pair?

     ("\\.svgz?\\'" . image-mode)
     ("\\.svgz?\\'" . xml-mode)

There is only html-ts-mode, not xml-ts-mode?

Message #14 received at 62276 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 62276 <at> debbugs.gnu.org
Subject: Re: bug#62276: 29.0.60; image-minor-mode broken by c-ts-mode
Date: Mon, 20 Mar 2023 20:47:22 +0200

> From: Juri Linkov <juri <at> linkov.net>
> Cc: 62276 <at> debbugs.gnu.org
> Date: Mon, 20 Mar 2023 20:10:19 +0200
> 
> >> 4. M-: (require 'c-ts-mode) RET
> >> 5. C-x C-f etc/images/attach.xpm RET
> >>
> >> It's not displayed as an image and C-c C-c does nothing.
> >
> > Thanks, should be fixed now on the emacs-29 branch.
> 
> Are there other modes that require such ad-hoc hacks?

The ad-hocery was required because files.el itself uses an ugly (and
undocumented) hack to allow visiting XPM/XBM as either a C file or an
image file.

> Is there a problem with this pair?
> 
>      ("\\.svgz?\\'" . image-mode)
>      ("\\.svgz?\\'" . xml-mode)

I don't know.  Is there?

> There is only html-ts-mode, not xml-ts-mode?

Yes, at least for now.  I don't think there's a grammar library for
XML.

Can we close this bug now?

Message #19 received at 62276-done <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 62276-done <at> debbugs.gnu.org
Subject: Re: bug#62276: 29.0.60; image-minor-mode broken by c-ts-mode
Date: Tue, 21 Mar 2023 20:46:30 +0200

>> >> 4. M-: (require 'c-ts-mode) RET
>> >> 5. C-x C-f etc/images/attach.xpm RET
>> >>
>> >> It's not displayed as an image and C-c C-c does nothing.
>> >
>> > Thanks, should be fixed now on the emacs-29 branch.
>> 
>> Are there other modes that require such ad-hoc hacks?
>
> The ad-hocery was required because files.el itself uses an ugly (and
> undocumented) hack to allow visiting XPM/XBM as either a C file or an
> image file.
>
>> Is there a problem with this pair?
>> 
>>      ("\\.svgz?\\'" . image-mode)
>>      ("\\.svgz?\\'" . xml-mode)
>
> I don't know.  Is there?
>
>> There is only html-ts-mode, not xml-ts-mode?
>
> Yes, at least for now.  I don't think there's a grammar library for
> XML.
>
> Can we close this bug now?

It seems no more fixes are required, so now closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.