GNU bug report logs - #62293
[PATCH] gnu: add pcsc-cyberjack

Previous Next

Package: guix-patches;

Reported by: Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>

Date: Mon, 20 Mar 2023 11:50:01 UTC

Severity: normal

Tags: patch

Done: Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62293 in the body.
You can then email your comments to 62293 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#62293; Package guix-patches. (Mon, 20 Mar 2023 11:50:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 20 Mar 2023 11:50:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: add pcsc-cyberjack
Date: Mon, 20 Mar 2023 11:28:15 +0100

* gnu/packages/security-token.scm (pcsc-cyberjack): New variable.
---
 gnu/packages/security-token.scm | 34 +++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/security-token.scm 
b/gnu/packages/security-token.scm
index a7f5e3acf9..521f6f226b 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -967,3 +967,37 @@ (define-public cardpeek
 It also has limited support for Mifare Classic compatible cards 
(Thalys card)")
     (license license:gpl3+)
     (home-page "http://pannetrat.com/Cardpeek")))
+
+(define-public pcsc-cyberjack
+  (package
+    (name "pcsc-cyberjack")
+    (version "3.99.5final.sp15")
+    (synopsis "PC/SC driver for cyberJack chipcard readers")
+    (home-page "http://www.reiner-sct.com/")
+    (description
+     "REINER SCT cyberJack USB chipcard reader user space driver
+ This package includes the IFD driver for the cyberJack contactless
+ (RFID) and contact USB chipcard reader.")
+    (license license:lgpl2.1+)
+    (native-inputs (list pkg-config))
+    (inputs (list pcsc-lite libusb))
+    (outputs '("out" "tools"))
+    (source (origin
+              (method url-fetch)
+              (uri
+ 
"https://support.reiner-sct.de/downloads/LINUX/V3.99.5_SP15/pcsc-cyberjack_3.99.5final.SP15.tar.bz2")
+              (sha256
+               (base32
+ "0yj6plgb245r218v6lgdabb3422hxyrw8rrpf5b8fwah4j1w5dxc"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list #:configure-flags #~(list (string-append "--with-usbdropdir="
+                                                    (ungexp output "out")
+ "/pcsc/drivers")
+                                     (string-append "--bindir="
+                                                    (ungexp output "tools")
+                                                    "/bin"))
+           #:phases '(modify-phases %standard-phases
+                       (add-after 'install 'install-tools
+                         (lambda _
+                           (invoke "make" "-C" "tools/cjflash" 
"install"))))))))

base-commit: 3a2200e1ad2049ad7e25295e6b4e013f74dd84e2
--
2.39.2
Information forwarded to guix-patches <at> gnu.org:
bug#62293; Package guix-patches. (Mon, 20 Mar 2023 18:45:02 GMT) Full text and rfc822 format available.

Message #8 received at 62293 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>
Cc: 62293 <at> debbugs.gnu.org
Subject: Re: [bug#62293] [PATCH] gnu: add pcsc-cyberjack
Date: Mon, 20 Mar 2023 18:44:48 +0000

Hi Arvid,

On 2023-03-20 10:28, Arvid Krein wrote:
> +(define-public pcsc-cyberjack
> +  (package
> +    (name "pcsc-cyberjack")
> +    (version "3.99.5final.sp15")
> +    (synopsis "PC/SC driver for cyberJack chipcard readers")
> +    (home-page "http://www.reiner-sct.com/")
> +    (description
> +     "REINER SCT cyberJack USB chipcard reader user space driver
> + This package includes the IFD driver for the cyberJack contactless
> + (RFID) and contact USB chipcard reader.")

How about “This package includes the IFD driver for the cyberJack contactless (RFID) and contact USB chipcard readers.”

> +    (source (origin
> +              (method url-fetch)
> +              (uri
> + "https://support.reiner-sct.de/downloads/LINUX/V3.99.5_SP15/pcsc-cyberjack_3.99.5final.SP15.tar.bz2")> +              (sha256
> +               (base32
> + "0yj6plgb245r218v6lgdabb3422hxyrw8rrpf5b8fwah4j1w5dxc"))))

How about indenting this as:

(source
 (origin
   (method url-fetch)
   (uri ...)
   (sha256
     (base32 ...))))

> +    (arguments
> +     (list #:configure-flags #~(list (string-append "--with-usbdropdir="
> +                                                    (ungexp output "out")
> + "/pcsc/drivers")
> +                                     (string-append "--bindir="
> +                                                    (ungexp output "tools")
> +                                                    "/bin"))
> +           #:phases '(modify-phases %standard-phases
> +                       (add-after 'install 'install-tools
> +                         (lambda _
> +                           (invoke "make" "-C" "tools/cjflash" "install"))))))))

Do this:

(arguments
 (list
 #:configure-flags
 #~(list (string-append "--with-usbdropdir=" #$output "/pcsc/drivers")
         (string-append "--bindir=" #$output:tools  "/bin"))
 #:phases
 #~(modify-phases %standard-phases
    ... )))


Also, please reorder the package fields into something like:

(define-public ...
  (package
    (name ...)
    (version ...)
    (source ...)
    (build-system ...)
    (arguments ...)
    (native-inputs ...)
    (inputs ...)
    (outputs ...)
    (synopsis ...)
    (description ...)
    (home-page ...)
    (license ...)))


Cheers,
Bruno
Information forwarded to guix-patches <at> gnu.org:
bug#62293; Package guix-patches. (Tue, 21 Mar 2023 11:43:03 GMT) Full text and rfc822 format available.

Message #11 received at 62293 <at> debbugs.gnu.org (full text, mbox):

From: Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>
To: 62293 <at> debbugs.gnu.org
Subject: [PATCH v1] gnu: add pcsc-cyberjack
Date: Tue, 21 Mar 2023 12:26:51 +0100

* gnu/packages/security-token.scm (pcsc-cyberjack): New variable.
---
 gnu/packages/security-token.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/security-token.scm 
b/gnu/packages/security-token.scm
index a7f5e3acf9..e139c9a1cf 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -967,3 +967,34 @@ (define-public cardpeek
 It also has limited support for Mifare Classic compatible cards 
(Thalys card)")
     (license license:gpl3+)
     (home-page "http://pannetrat.com/Cardpeek")))
+
+(define-public pcsc-cyberjack
+  (package
+    (name "pcsc-cyberjack")
+    (version "3.99.5final.sp15")
+    (source
+     (origin
+       (method url-fetch)
+       (uri
+ 
"https://support.reiner-sct.de/downloads/LINUX/V3.99.5_SP15/pcsc-cyberjack_3.99.5final.SP15.tar.bz2")
+       (sha256
+        (base32
+ "0yj6plgb245r218v6lgdabb3422hxyrw8rrpf5b8fwah4j1w5dxc"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:configure-flags
+      #~(list (string-append "--with-usbdropdir=" #$output "/pcsc/drivers")
+              (string-append "--bindir=" #$output:tools "/bin"))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'install 'install-tools
+            (lambda _ (invoke "make" "-C" "tools/cjflash" "install"))))))
+    (native-inputs (list pkg-config))
+    (inputs (list pcsc-lite libusb))
+    (outputs '("out" "tools"))
+    (synopsis "PC/SC driver for cyberJack chipcard readers")
+    (description
+     "This package includes the IFD driver for the cyberJack 
contactless (RFID) and contact USB chipcard readers.")
+    (home-page "http://www.reiner-sct.com/")
+    (license license:lgpl2.1+)))

base-commit: 3a2200e1ad2049ad7e25295e6b4e013f74dd84e2
--
2.39.2
Information forwarded to guix-patches <at> gnu.org:
bug#62293; Package guix-patches. (Wed, 22 Mar 2023 15:44:02 GMT) Full text and rfc822 format available.

Message #14 received at 62293 <at> debbugs.gnu.org (full text, mbox):

From: Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>
To: 62293 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: add cyberjack-pcsc
Date: Wed, 22 Mar 2023 15:26:07 +0100

Hello Bruno,

I thought a while about package naming and now think that cyberjack-pcsc 
might be a better package name. The package is not part of pcsc but 
rather contains pcsc drivers for cyberjack so I would think 
cyberjack-pcsc is more appropriate. I am not sure about this though and 
would be happy about feedback. In general this aligns better with how I 
think guix package names are chosen.

Greetings,

Arvid

* gnu/packages/security-token.scm (cyberjack-pcsc): New variable.
---
 gnu/packages/security-token.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/security-token.scm 
b/gnu/packages/security-token.scm
index 3cf585480e..11ec681cdc 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -1025,3 +1025,34 @@ (define-public cardpeek
 It also has limited support for Mifare Classic compatible cards 
(Thalys card)")
     (license license:gpl3+)
     (home-page "http://pannetrat.com/Cardpeek")))
+
+(define-public cyberjack-pcsc
+  (package
+    (name "cyberjack-pcsc")
+    (version "3.99.5final.sp15")
+    (source
+     (origin
+       (method url-fetch)
+       (uri
+ 
"https://support.reiner-sct.de/downloads/LINUX/V3.99.5_SP15/pcsc-cyberjack_3.99.5f
inal.SP15.tar.bz2")
+       (sha256
+        (base32
+ "0yj6plgb245r218v6lgdabb3422hxyrw8rrpf5b8fwah4j1w5dxc"))))
+    (build-system gnu-build-system)
+    (arguments
+     (list
+      #:configure-flags
+      #~(list (string-append "--with-usbdropdir=" #$output "/pcsc/drivers")
+              (string-append "--bindir=" #$output:tools "/bin"))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'install 'install-tools
+            (lambda _ (invoke "make" "-C" "tools/cjflash" "install"))))))
+    (native-inputs (list pkg-config))
+    (inputs (list pcsc-lite libusb))
+    (outputs '("out" "tools"))
+    (synopsis "PC/SC driver for cyberJack chipcard readers")
+    (description
+     "This package includes the IFD driver for the cyberJack 
contactless (RFID) and contac
t USB chipcard readers.")
+    (home-page "http://www.reiner-sct.com/")
+    (license license:lgpl2.1+)))

base-commit: 4f8a13b9fbfd0efcb94ee8da46b09c6dbe84ac4b
--
2.39.2
Reply sent to Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>:
You have taken responsibility. (Fri, 02 Jun 2023 14:46:02 GMT) Full text and rfc822 format available.
Notification sent to Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>:
bug acknowledged by developer. (Fri, 02 Jun 2023 14:46:02 GMT) Full text and rfc822 format available.

Message #19 received at 62293-done <at> debbugs.gnu.org (full text, mbox):

From: Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>
To: 62293-done <at> debbugs.gnu.org
Subject: Done: Patch was pushed as commit
 a7d9cd742c3149bb014db95f88d1158d590bc124
Date: Fri, 2 Jun 2023 16:45:15 +0200

This Patch was merged in commit a7d9cd742c3149bb014db95f88d1158d590bc124 
so I am marking it as done.

Greetings,
Arvid
Information forwarded to guix-patches <at> gnu.org:
bug#62293; Package guix-patches. (Fri, 02 Jun 2023 23:03:02 GMT) Full text and rfc822 format available.

Message #22 received at 62293-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Arvid Krein <arvidkrein <at> zedat.fu-berlin.de>
Cc: 62293-done <at> debbugs.gnu.org
Subject: Re: bug#62293: [PATCH] gnu: add pcsc-cyberjack
Date: Fri, 02 Jun 2023 19:28:25 +0800

Arvid Krein <arvidkrein <at> zedat.fu-berlin.de> writes:

> Hello Bruno,
>
> I thought a while about package naming and now think that
> cyberjack-pcsc might be a better package name.

Hello, I pushed it as 'pcsc-cyberjack', as it's a driver/extension to
pcsc.  Note that Archlinux also has it:
https://aur.archlinux.org/packages/pcsc-cyberjack


Thank you!
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 01 Jul 2023 11:24:12 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 314 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.