GNU bug report logs - #62303
guix style frequently wraps lines beyond 80 characters limit

Previous Next

To reply to this bug, email your comments to 62303 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: bug-guix <bug-guix <at> gnu.org>
Subject: guix style frequently wraps lines beyond 80 characters limit
Date: Mon, 20 Mar 2023 17:20:11 -0400

Hello Guix,

The "guix style" command appears to be too lenient on our maximum width
limit; it frequently overflows the 80 characters limit, as demonstrated
in the following example:

Before (max width: 77 characters)
--8<---------------cut here---------------start------------->8---
(define-public emacs-transient
  (let ((commit "0ae0de43590b5b6984a83f9e044e7c426455ac6e")
        (revision "1"))
    (package
      (name "emacs-transient")
      (version (git-version "0.3.7" revision commit))
      (source
       (origin
         (method git-fetch)
         (uri (git-reference
               (url "https://github.com/magit/transient")
               (commit (string-append "v" version))))
         (file-name (git-file-name name version))
         (sha256
          (base32 "0c7wbd0j0b802bzdpdkrx2q7wm7b9s56rk554dnadkpywhmdiqwn"))))
      (build-system emacs-build-system)
      (arguments
       `(#:tests? #f                      ;no test suite
         #:phases
         (modify-phases %standard-phases
           (add-after 'unpack 'build-info-manual
             (lambda _
               (invoke "make" "info")
               ;; Move the info file to lisp so that it gets installed by the
               ;; emacs-build-system.
               (rename-file "docs/transient.info" "lisp/transient.info")))
           (add-after 'build-info-manual 'enter-lisp-directory
             (lambda _
               (chdir "lisp"))))))
      (native-inputs
       (list texinfo))
      (propagated-inputs
       (list emacs-dash))
      (home-page "https://magit.vc/manual/transient")
      (synopsis "Transient commands in Emacs")
      (description "Taking inspiration from prefix keys and prefix arguments
in Emacs, Transient implements a similar abstraction involving a prefix
command, infix arguments and suffix commands.  We could call this abstraction
a \"transient command\", but because it always involves at least two
commands (a prefix and a suffix) we prefer to call it just a \"transient\".")
      (license license:gpl3+))))
--8<---------------cut here---------------end--------------->8---

After (max width: 86 characters)
--8<---------------cut here---------------start------------->8---
(define-public emacs-transient
  (let ((commit "0ae0de43590b5b6984a83f9e044e7c426455ac6e")
        (revision "1"))
    (package
      (name "emacs-transient")
      (version (git-version "0.3.7" revision commit))
      (source (origin
                (method git-fetch)
                (uri (git-reference
                      (url "https://github.com/magit/transient")
                      (commit (string-append "v" version))))
                (file-name (git-file-name name version))
                (sha256
                 (base32
                  "0c7wbd0j0b802bzdpdkrx2q7wm7b9s56rk554dnadkpywhmdiqwn"))))
      (build-system emacs-build-system)
      (arguments
       `(#:tests? #f ;no test suite
         #:phases (modify-phases %standard-phases
                    (add-after 'unpack 'build-info-manual
                      (lambda _
                        (invoke "make" "info")
                        ;; Move the info file to lisp so that it gets installed by the
                        ;; emacs-build-system.
                        (rename-file "docs/transient.info"
                                     "lisp/transient.info")))
                    (add-after 'build-info-manual 'enter-lisp-directory
                      (lambda _
                        (chdir "lisp"))))))
      (native-inputs (list texinfo))
      (propagated-inputs (list emacs-dash))
      (home-page "https://magit.vc/manual/transient")
      (synopsis "Transient commands in Emacs")
      (description
       "Taking inspiration from prefix keys and prefix arguments
in Emacs, Transient implements a similar abstraction involving a prefix
command, infix arguments and suffix commands.  We could call this abstraction
a \"transient command\", but because it always involves at least two
commands (a prefix and a suffix) we prefer to call it just a \"transient\".")
      (license license:gpl3+))))
--8<---------------cut here---------------end--------------->8---

-- 
Thanks,
Maxim

Message #8 received at 62303 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 62303 <at> debbugs.gnu.org
Subject: Re: bug#62303: guix style frequently wraps lines beyond 80
 characters limit
Date: Mon, 20 Mar 2023 23:38:16 -0400

Hello,

Here's another example, on mygnuhealth (just committed):

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/medical.scm
@@ -46,19 +46,19 @@ (define-public mygnuhealth
                 "1jcrriccqzb4jx7zayhiqmpvi3cvfy3bbf9zr3m83878f94yww8j"))))
     (build-system python-build-system)
     (arguments
-     (list
-      #:imported-modules `(,@%python-build-system-modules
-                           ,@%qt-build-system-modules)
-      #:modules `(((guix build qt-build-system) #:prefix qt:)
-                  (guix build python-build-system)
-                  (guix build utils))
-      #:phases #~(modify-phases %standard-phases
-                   (add-after 'install 'qt-wrap
-                     (assoc-ref qt:%standard-phases 'qt-wrap))
-                   (add-before 'check 'env-setup
-                     (lambda _
-                       (mkdir-p "/tmp/mygh/")
-                       (setenv "HOME" "/tmp"))))))
+     (list #:imported-modules `(,@%python-build-system-modules ,@%qt-build-system-modules)
+           #:modules `(((guix build qt-build-system)
+                        #:prefix qt:)
+                       (guix build python-build-system)
+                       (guix build utils))
+           #:phases #~(modify-phases %standard-phases
+                        (add-after 'install 'qt-wrap
+                          (assoc-ref qt:%standard-phases
+                                     'qt-wrap))
+                        (add-before 'check 'env-setup
+                          (lambda _
+                            (mkdir-p "/tmp/mygh/")
+                            (setenv "HOME" "/tmp"))))))
     (native-inputs (list python-pyside-2))
     (inputs (list bash-minimal
                   kirigami
--8<---------------cut here---------------end--------------->8---

The max width reaches 90 characters.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.