GNU bug report logs - #62348
[PATCH 0/3] Update psmisc to 23.6.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62348 in the body.
You can then email your comments to 62348 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: guix-patches <at> gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH 0/3] Update psmisc to 23.6.
Date: Tue, 21 Mar 2023 17:04:07 +0000

This patch-series modernizes the package definition with G-Expressions
and updates it to 23.6.

Along the way, the patch from #34828 [1] was integrated into
this series with some minor touchups, after resolving the merge-conflicts.


[1]: https://issues.guix.gnu.org/34828


Bruno Victal (2):
  gnu: psmisc: Use G-Expressions.
  gnu: psmisc: Update to 23.6.

mikadoZero (1):
  gnu: psmisc: Make description more informative.

 gnu/packages/linux.scm | 29 ++++++++++++++++++-----------
 1 file changed, 18 insertions(+), 11 deletions(-)

-- 
2.39.1

Message #8 received at 62348 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 62348 <at> debbugs.gnu.org
Cc: ludo <at> gnu.org, Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH 3/3] gnu: psmisc: Update to 23.6.
Date: Tue, 21 Mar 2023 17:11:22 +0000

* gnu/packages/linux.scm (psmisc): Update to 23.6.
---
 gnu/packages/linux.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 8ecbf32bf8..dfd9748a67 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -2020,14 +2020,14 @@ (define-public powerstat
 (define-public psmisc
   (package
     (name "psmisc")
-    (version "23.5")
+    (version "23.6")
     (source
      (origin
       (method url-fetch)
       (uri (string-append "mirror://sourceforge/psmisc/psmisc/psmisc-"
                           version ".tar.xz"))
       (sha256
-       (base32 "12z5786dnf37n8wvv73wdcqp3nvsqzhwdk3ajna0mag4yz1fqdyw"))))
+       (base32 "0al2138z0m2bqrviv3zw2i2km4v8xg5wrw867li4jk4s2l3dwz95"))))
     (build-system gnu-build-system)
     (arguments
      (list
-- 
2.39.1

Message #11 received at 62348 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 62348 <at> debbugs.gnu.org
Cc: ludo <at> gnu.org, Bruno Victal <mirai <at> makinata.eu>,
 mikadoZero <mikadozero <at> yandex.com>
Subject: [PATCH 1/3] gnu: psmisc: Make description more informative.
Date: Tue, 21 Mar 2023 17:11:20 +0000

From: mikadoZero <mikadozero <at> yandex.com>

The text for the description is taken from the psmisc readme.

* gnu/packages/linux.scm (psmisc)[description]: Make description more informative.

Co-authored-by: Bruno Victal <mirai <at> makinata.eu>
---
 gnu/packages/linux.scm | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index ef05e77ec8..14e6f46a39 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -33,6 +33,7 @@
 ;;; Copyright © 2018, 2019 Pierre Langlois <pierre.langlois <at> gmx.com>
 ;;; Copyright © 2018 Vasile Dumitrascu <va511e <at> yahoo.com>
 ;;; Copyright © 2019 Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
+;;; Copyright © 2019 mikadoZero <mikadozero <at> yandex.com>
 ;;; Copyright © 2019, 2020, 2021, 2022 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2019 Stefan Stefanović <stefanx2ovic <at> gmail.com>
 ;;; Copyright © 2019-2022 Brice Waegeneire <brice <at> waegenei.re>
@@ -2039,9 +2040,15 @@ (define-public psmisc
     (home-page "https://gitlab.com/psmisc/psmisc")
     (synopsis "Small utilities that use the proc file system")
     (description
-     "This PSmisc package is a set of some small useful utilities that
-use the proc file system.  We're not about changing the world, but
-providing the system administrator with some help in common tasks.")
+     "A package of small utilities that use the proc file-system.
+@itemize @bullet
+@item @command{fuser} - Identifies processes using files or sockets
+@item @command{killall} - kills processes by name, e.g. @samp{killall -HUP @var{name}}
+@item @command{prtstat} - prints statistics of a process
+@item @command{pslog} - prints log path(s) of a process
+@item @command{pstree} - shows the currently running processes as a tree
+@item @command{peekfd} - shows the data travelling over a file descriptor
+@end itemize")
     (license license:gpl2+)))
 
 (define-public util-linux
-- 
2.39.1

Message #14 received at 62348 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 62348 <at> debbugs.gnu.org
Cc: ludo <at> gnu.org, Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH 2/3] gnu: psmisc: Use G-Expressions.
Date: Tue, 21 Mar 2023 17:11:21 +0000

* gnu/packages/linux.scm (psmisc): Use G-Expressions.
---
 gnu/packages/linux.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 14e6f46a39..8ecbf32bf8 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -2030,12 +2030,12 @@ (define-public psmisc
        (base32 "12z5786dnf37n8wvv73wdcqp3nvsqzhwdk3ajna0mag4yz1fqdyw"))))
     (build-system gnu-build-system)
     (arguments
-     `(,@(if (%current-target-system)
-             '(#:configure-flags
-               (list
-                "ac_cv_func_malloc_0_nonnull=yes"
-                "ac_cv_func_realloc_0_nonnull=yes"))
-             '())))
+     (list
+      #:configure-flags
+      (if (%current-target-system)
+          #~(list "ac_cv_func_malloc_0_nonnull=yes"
+                  "ac_cv_func_realloc_0_nonnull=yes")
+          #~'())))
     (inputs (list ncurses))
     (home-page "https://gitlab.com/psmisc/psmisc")
     (synopsis "Small utilities that use the proc file system")
-- 
2.39.1

Message #17 received at 62348 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: 62348 <at> debbugs.gnu.org, ludo <at> gnu.org, mikadoZero <mikadozero <at> yandex.com>
Subject: Re: [bug#62348] [PATCH 1/3] gnu: psmisc: Make description more
 informative.
Date: Tue, 21 Mar 2023 18:20:47 +0100

Hello,

Bruno Victal <mirai <at> makinata.eu> writes:

> From: mikadoZero <mikadozero <at> yandex.com>
>
> The text for the description is taken from the psmisc readme.
>
> * gnu/packages/linux.scm (psmisc)[description]: Make description more
> informative.

Thanks.

> +     "A package of small utilities that use the proc file-system.

This should be a complete sentence, e.g.,

  Psmisc is a set of small utilities…

> +@itemize @bullet
> +@item @command{fuser} - Identifies processes using files or sockets
> +@item @command{killall} - kills processes by name, e.g. @samp{killall -HUP @var{name}}
> +@item @command{prtstat} - prints statistics of a process
> +@item @command{pslog} - prints log path(s) of a process
> +@item @command{pstree} - shows the currently running processes as a tree
> +@item @command{peekfd} - shows the data travelling over a file descriptor
> +@end itemize")

I suggest to remove the dashes, and probably add semicolons at the end
of all but last item:

  @item @command{fuser} identifies processes using files or sockets;

I suggest to add a comma after "e.g.", so Texinfo cannot consider it to
be the end of a sentence:

  @item @command{killall} kills processes by name, e.g., @samp{killall -HUP @var{name}};

Actually, I even wonder if providing an example if worth being in
a generic description. I probably belongs to a user manual:

  @item @command{killall} kills processes by name;

Regards,
-- 
Nicolas Goaziou

Message #20 received at 62348 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 62348 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH v2 3/3] gnu: psmisc: Update to 23.6.
Date: Tue, 21 Mar 2023 19:23:22 +0000

* gnu/packages/linux.scm (psmisc): Update to 23.6.
---
 gnu/packages/linux.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index ffaf9aadf4..8912bfd091 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -2020,14 +2020,14 @@ (define-public powerstat
 (define-public psmisc
   (package
     (name "psmisc")
-    (version "23.5")
+    (version "23.6")
     (source
      (origin
       (method url-fetch)
       (uri (string-append "mirror://sourceforge/psmisc/psmisc/psmisc-"
                           version ".tar.xz"))
       (sha256
-       (base32 "12z5786dnf37n8wvv73wdcqp3nvsqzhwdk3ajna0mag4yz1fqdyw"))))
+       (base32 "0al2138z0m2bqrviv3zw2i2km4v8xg5wrw867li4jk4s2l3dwz95"))))
     (build-system gnu-build-system)
     (arguments
      (list
-- 
2.39.1

Message #23 received at 62348 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 62348 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH v2 2/3] gnu: psmisc: Use G-Expressions.
Date: Tue, 21 Mar 2023 19:23:21 +0000

* gnu/packages/linux.scm (psmisc): Use G-Expressions.
---
 gnu/packages/linux.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index d1d1e10741..ffaf9aadf4 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -2030,12 +2030,12 @@ (define-public psmisc
        (base32 "12z5786dnf37n8wvv73wdcqp3nvsqzhwdk3ajna0mag4yz1fqdyw"))))
     (build-system gnu-build-system)
     (arguments
-     `(,@(if (%current-target-system)
-             '(#:configure-flags
-               (list
-                "ac_cv_func_malloc_0_nonnull=yes"
-                "ac_cv_func_realloc_0_nonnull=yes"))
-             '())))
+     (list
+      #:configure-flags
+      (if (%current-target-system)
+          #~(list "ac_cv_func_malloc_0_nonnull=yes"
+                  "ac_cv_func_realloc_0_nonnull=yes")
+          #~'())))
     (inputs (list ncurses))
     (home-page "https://gitlab.com/psmisc/psmisc")
     (synopsis "Small utilities that use the proc file system")
-- 
2.39.1

Message #26 received at 62348 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 62348 <at> debbugs.gnu.org
Cc: mikadoZero <mikadozero <at> yandex.com>, Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH v2 1/3] gnu: psmisc: Make description more informative.
Date: Tue, 21 Mar 2023 19:23:20 +0000

From: mikadoZero <mikadozero <at> yandex.com>

The text for the description is taken from the psmisc readme.

* gnu/packages/linux.scm (psmisc)[description]: Make description more informative.

Co-authored-by: Bruno Victal <mirai <at> makinata.eu>
---
 gnu/packages/linux.scm | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index ef05e77ec8..d1d1e10741 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -33,6 +33,7 @@
 ;;; Copyright © 2018, 2019 Pierre Langlois <pierre.langlois <at> gmx.com>
 ;;; Copyright © 2018 Vasile Dumitrascu <va511e <at> yahoo.com>
 ;;; Copyright © 2019 Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
+;;; Copyright © 2019 mikadoZero <mikadozero <at> yandex.com>
 ;;; Copyright © 2019, 2020, 2021, 2022 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2019 Stefan Stefanović <stefanx2ovic <at> gmail.com>
 ;;; Copyright © 2019-2022 Brice Waegeneire <brice <at> waegenei.re>
@@ -2039,9 +2040,15 @@ (define-public psmisc
     (home-page "https://gitlab.com/psmisc/psmisc")
     (synopsis "Small utilities that use the proc file system")
     (description
-     "This PSmisc package is a set of some small useful utilities that
-use the proc file system.  We're not about changing the world, but
-providing the system administrator with some help in common tasks.")
+     "psmisc is a set of small utilities that use the proc file-system.
+@itemize @bullet
+@item @command{fuser} identifies processes using files or sockets;
+@item @command{killall} kills processes by name;
+@item @command{prtstat} prints statistics of a process;
+@item @command{pslog} prints log path(s) of a process;
+@item @command{pstree} shows the currently running processes as a tree;
+@item @command{peekfd} shows the data travelling over a file descriptor
+@end itemize")
     (license license:gpl2+)))
 
 (define-public util-linux
-- 
2.39.1

Message #29 received at 62348 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 62348 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH v3 0/3] Improve psmisc description & update.
Date: Thu, 24 Aug 2023 17:52:14 +0100

Notable changes since v2:
* Use '@table @command' for description.


Bruno Victal (2):
  gnu: psmisc: Use G-Expressions.
  gnu: psmisc: Update to 23.6.

mikadoZero (1):
  gnu: psmisc: Make description more informative.

 gnu/packages/linux.scm | 34 +++++++++++++++++++++++-----------
 1 file changed, 23 insertions(+), 11 deletions(-)


base-commit: 738b0e4ccc2bac3d77bb29dd6d51026d887d6b16
-- 
2.41.0

Message #32 received at 62348 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 62348 <at> debbugs.gnu.org
Cc: mikadoZero <mikadozero <at> yandex.com>, Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH v3 1/3] gnu: psmisc: Make description more informative.
Date: Thu, 24 Aug 2023 17:54:15 +0100

From: mikadoZero <mikadozero <at> yandex.com>

The text for the description is taken from the psmisc readme.

* gnu/packages/linux.scm (psmisc)[description]: Make description more informative.

Co-authored-by: Bruno Victal <mirai <at> makinata.eu>
---
 gnu/packages/linux.scm | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index ca223aea37..4c5d2fc4c7 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -2070,9 +2070,21 @@ (define-public psmisc
     (home-page "https://gitlab.com/psmisc/psmisc")
     (synopsis "Small utilities that use the proc file system")
     (description
-     "This PSmisc package is a set of some small useful utilities that
-use the proc file system.  We're not about changing the world, but
-providing the system administrator with some help in common tasks.")
+     "psmisc is a set of small utilities that use the proc file-system.
+@table @command
+@item fuser
+Identifies processes using files or sockets.
+@item killall
+Kills processes by name.
+@item prtstat
+Prints statistics of a process.
+@item pslog
+Prints log path(s) of a process.
+@item pstree
+Shows the currently running processes as a tree.
+@item peekfd
+Shows the data travelling over a file descriptor.
+@end table")
     (license license:gpl2+)))
 
 (define-public util-linux

base-commit: 738b0e4ccc2bac3d77bb29dd6d51026d887d6b16
-- 
2.40.1

Message #35 received at 62348 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 62348 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH v3 2/3] gnu: psmisc: Use G-Expressions.
Date: Thu, 24 Aug 2023 17:54:16 +0100

* gnu/packages/linux.scm (psmisc): Use G-Expressions.
---
 gnu/packages/linux.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 4c5d2fc4c7..3bd5624730 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -2060,12 +2060,12 @@ (define-public psmisc
        (base32 "12z5786dnf37n8wvv73wdcqp3nvsqzhwdk3ajna0mag4yz1fqdyw"))))
     (build-system gnu-build-system)
     (arguments
-     `(,@(if (%current-target-system)
-             '(#:configure-flags
-               (list
-                "ac_cv_func_malloc_0_nonnull=yes"
-                "ac_cv_func_realloc_0_nonnull=yes"))
-             '())))
+     (list
+      #:configure-flags
+      (if (%current-target-system)
+          #~(list "ac_cv_func_malloc_0_nonnull=yes"
+                  "ac_cv_func_realloc_0_nonnull=yes")
+          #~'())))
     (inputs (list ncurses))
     (home-page "https://gitlab.com/psmisc/psmisc")
     (synopsis "Small utilities that use the proc file system")
-- 
2.40.1

Message #38 received at 62348 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 62348 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH v3 3/3] gnu: psmisc: Update to 23.6.
Date: Thu, 24 Aug 2023 17:54:17 +0100

* gnu/packages/linux.scm (psmisc): Update to 23.6.
---
 gnu/packages/linux.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 3bd5624730..011313df4f 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -2050,14 +2050,14 @@ (define-public powerstat
 (define-public psmisc
   (package
     (name "psmisc")
-    (version "23.5")
+    (version "23.6")
     (source
      (origin
       (method url-fetch)
       (uri (string-append "mirror://sourceforge/psmisc/psmisc/psmisc-"
                           version ".tar.xz"))
       (sha256
-       (base32 "12z5786dnf37n8wvv73wdcqp3nvsqzhwdk3ajna0mag4yz1fqdyw"))))
+       (base32 "0al2138z0m2bqrviv3zw2i2km4v8xg5wrw867li4jk4s2l3dwz95"))))
     (build-system gnu-build-system)
     (arguments
      (list
-- 
2.40.1

Message #43 received at 62348-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 62348-done <at> debbugs.gnu.org, 34828-done <at> debbugs.gnu.org
Subject: Re: [PATCH] Update psmisc to 23.6.
Date: Sat, 16 Sep 2023 15:43:24 +0200

Hi mikadoZero & Bruno,

I pushed #62348 patches 1 & 2 to master as 
32b4f59433df620ab8f4b9a6c523f8ef9500d75d et al.  I fixed a minor typo 
(‘file-system’) and added a full stop.

The update patch (3/3) went to core-updates as 
725b2528a65edf7425762b99330ab1c9bd33bc86.

Thanks!

T G-R

Sent from a Web browser.  Excuse or enjoy my brevity.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.