GNU bug report logs - #62451
29.0.60; nnselect-request-threads assumes gnus-search-use-parsed-queries

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62451 in the body.
You can then email your comments to 62451 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.60; nnselect-request-threads assumes
 gnus-search-use-parsed-queries
Date: Sat, 25 Mar 2023 16:16:53 -0700

X-debbugs-cc: cohen <at> bu.edu

nnselect-request-threads generates a query in Gnus's generic search
language and expects gnus-search-prepare-query to convert it to a raw
query.  But if gnus-search-use-parsed-queries is nil, as it is by
default, then this doesn't happen, and the search engine receives a
query it can't understand.  For example, notmuch receives a query like
"id:<foo> or id:<bar>" when it should receive "id:foo or id:bar".

This breaks the gnus-summary-refer-thread command.

One way to fix it is to add a binding (gnus-search-use-parsed-queries t)
to the let* form in which the call to gnus-search-run-query is made.

-- 
Sean Whitton

Message #8 received at 62451 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Cohen <cohen <at> bu.edu>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: cohen <at> bu.edu, 62451 <at> debbugs.gnu.org
Subject: Re: bug#62451: 29.0.60; nnselect-request-threads assumes
 gnus-search-use-parsed-queries
Date: Sun, 26 Mar 2023 08:17:03 +0800

>>>>> "SW" == Sean Whitton <spwhitton <at> spwhitton.name> writes:

    SW> X-debbugs-cc: cohen <at> bu.edu nnselect-request-threads generates a
    SW> query in Gnus's generic search language and expects
    SW> gnus-search-prepare-query to convert it to a raw query.  But if
    SW> gnus-search-use-parsed-queries is nil, as it is by default, then
    SW> this doesn't happen, and the search engine receives a query it
    SW> can't understand.  For example, notmuch receives a query like
    SW> "id:<foo> or id:<bar>" when it should receive "id:foo or
    SW> id:bar".

    SW> This breaks the gnus-summary-refer-thread command.

    SW> One way to fix it is to add a binding
    SW> (gnus-search-use-parsed-queries t) to the let* form in which the
    SW> call to gnus-search-run-query is made.


This has been in my tree for ages but I never pushed it (it is part of
larger changes to thread referral/retrieval). Its worth pushing by
itself and I'll try to do that.

Sorry for the delay.

-- 
Andrew Cohen

Message #13 received at 62451-close <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> arizona.edu>
To: Andrew Cohen <cohen <at> bu.edu>
Cc: 62451-close <at> debbugs.gnu.org
Subject: Re: bug#62451: 29.0.60; nnselect-request-threads assumes
 gnus-search-use-parsed-queries
Date: Sun, 26 Mar 2023 11:05:54 -0700

Hello,

On Sun 26 Mar 2023 at 08:17AM +08, Andrew Cohen wrote:

>>>>>> "SW" == Sean Whitton <spwhitton <at> spwhitton.name> writes:
>
>     SW> X-debbugs-cc: cohen <at> bu.edu nnselect-request-threads generates a
>     SW> query in Gnus's generic search language and expects
>     SW> gnus-search-prepare-query to convert it to a raw query.  But if
>     SW> gnus-search-use-parsed-queries is nil, as it is by default, then
>     SW> this doesn't happen, and the search engine receives a query it
>     SW> can't understand.  For example, notmuch receives a query like
>     SW> "id:<foo> or id:<bar>" when it should receive "id:foo or
>     SW> id:bar".
>
>     SW> This breaks the gnus-summary-refer-thread command.
>
>     SW> One way to fix it is to add a binding
>     SW> (gnus-search-use-parsed-queries t) to the let* form in which the
>     SW> call to gnus-search-run-query is made.
>
>
> This has been in my tree for ages but I never pushed it (it is part of
> larger changes to thread referral/retrieval). Its worth pushing by
> itself and I'll try to do that.
>
> Sorry for the delay.

Thank you for installing the change.  I noticed that you didn't add the
bug number to the commit message -- it would be good if you could do
that next time.

Closing the bug.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.