GNU bug report logs - #62452
30.0.50; [PATCH] Avoid shadowing variables in some Eshell command forms

Previous Next

Package: emacs;

Reported by: Jim Porter <jporterbugs <at> gmail.com>

Date: Sun, 26 Mar 2023 04:49:01 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Done: Jim Porter <jporterbugs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62452 in the body.
You can then email your comments to 62452 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#62452; Package emacs. (Sun, 26 Mar 2023 04:49:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Jim Porter <jporterbugs <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 26 Mar 2023 04:49:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Avoid shadowing variables in some Eshell command
 forms
Date: Sat, 25 Mar 2023 21:48:13 -0700

[Message part 1 (text/plain, inline)]
To see this in action, start from "emacs -Q -f eshell", then:

  ~ $ setq value "hi there"
  hi there
  ~ $ echo $value
  hi there
  ~ $ echo ${echo $value}
  eshell-temp

The last command should *also* print "hi there", but the variable 
'value' gets shadowed by some internal Eshell code. (A similar problem 
occurs for 'for-items' when using a for loop in Eshell.)

Patch attached.
[0001-Avoid-shadowing-variables-in-some-Eshell-command-for.patch (text/plain, attachment)]
Reply sent to Jim Porter <jporterbugs <at> gmail.com>:
You have taken responsibility. (Sat, 01 Apr 2023 23:32:01 GMT) Full text and rfc822 format available.
Notification sent to Jim Porter <jporterbugs <at> gmail.com>:
bug acknowledged by developer. (Sat, 01 Apr 2023 23:32:02 GMT) Full text and rfc822 format available.

Message #10 received at 62452-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: 62452-done <at> debbugs.gnu.org
Subject: Re: bug#62452: 30.0.50; [PATCH] Avoid shadowing variables in some
 Eshell command forms
Date: Sat, 1 Apr 2023 16:31:01 -0700

On 3/25/2023 9:48 PM, Jim Porter wrote:
> Patch attached.

Pushed as 97e35b14987. Closing this bug now.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 30 Apr 2023 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 360 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.