GNU bug report logs - #62459
[PATCH] Have Xref inherit input method when reading identifiers

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62459 in the body.
You can then email your comments to 62459 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Have Xref inherit input method when reading identifiers
Date: Sun, 26 Mar 2023 11:57:25 +0000

[Message part 1 (text/plain, inline)]

Certain languages rely heavily on input methods (two examples I have
encountered are APL and Agda), and the default behaviour of Xref when
prompting an identifier can be annoying since the user is required to
manually enable the input method, if they want to look up an identifier
that contains "non-ASCII" characters.  For that reason I think it should
be OK to set the INHERIT-INPUT-METHOD argument when calling
`completing-read'.

[0001-Have-Xref-inherit-input-method-when-reading-identi.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Philip Kaludercic

Message #8 received at 62459 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Philip Kaludercic <philipk <at> posteo.net>, 62459 <at> debbugs.gnu.org
Subject: Re: bug#62459: [PATCH] Have Xref inherit input method when reading
 identifiers
Date: Sun, 26 Mar 2023 22:04:22 +0300

On 26/03/2023 14:57, Philip Kaludercic wrote:
> Certain languages rely heavily on input methods (two examples I have
> encountered are APL and Agda), and the default behaviour of Xref when
> prompting an identifier can be annoying since the user is required to
> manually enable the input method, if they want to look up an identifier
> that contains "non-ASCII" characters.  For that reason I think it should
> be OK to set the INHERIT-INPUT-METHOD argument when calling
> `completing-read'.

Sure. If you see the improvement from this, please go ahead.

Message #11 received at 62459 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 62459 <at> debbugs.gnu.org
Subject: Re: bug#62459: [PATCH] Have Xref inherit input method when reading
 identifiers
Date: Sun, 26 Mar 2023 22:05:31 +0000

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 26/03/2023 14:57, Philip Kaludercic wrote:
>> Certain languages rely heavily on input methods (two examples I have
>> encountered are APL and Agda), and the default behaviour of Xref when
>> prompting an identifier can be annoying since the user is required to
>> manually enable the input method, if they want to look up an identifier
>> that contains "non-ASCII" characters.  For that reason I think it should
>> be OK to set the INHERIT-INPUT-METHOD argument when calling
>> `completing-read'.
>
> Sure. If you see the improvement from this, please go ahead.

OK, I'll push it to master.

-- 
Philip Kaludercic

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.