GNU bug report logs - #62524
[PATCH] Support displaying all package maintainers

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62524 in the body.
You can then email your comments to 62524 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonas Bernoulli <jonas <at> bernoul.li>
To: bug-gnu-emacs <at> gnu.org
Cc: philipk <at> posteo.net, monnier <at> iro.umontreal.ca
Subject: [PATCH] Support displaying all package maintainers
Date: Wed, 29 Mar 2023 17:32:14 +0200

If the package's new `:maintainers' extra property is non-nil, then
display all of the specified maintainers, if any, like we already
do for `:authors'.  If the value is nil, then fall back to the old
`:maintainer' property.

We cannot just allow the existing `:maintainer' property to be a
list of maintainers, because that would break older versions of this
function.  We also cannot just ignore `:maintainer', because all ELPAs
still have to be updated to include `:maintainers' in archive-contents.

Even once all ELPAs have been updated to include `:maintainers', they
have to continue to also include `:maintainer', for the benefit of
older versions of this function / package.el / Emacs.  To avoid this
duplication, `package' would have to be distributed on GNU ELPA as a
"core" package.

* lisp/emacs-lisp/package.el (describe-package-1): Use new
:maintainers package extra property from "archive-contents,
if non-nil.
---
 lisp/emacs-lisp/package.el | 29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index f92afe56b76..487dfac252f 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2696,7 +2696,8 @@ describe-package-1
          (status (if desc (package-desc-status desc) "orphan"))
          (incompatible-reason (package--incompatible-p desc))
          (signed (if desc (package-desc-signed desc)))
-         (maintainer (cdr (assoc :maintainer extras)))
+         (maintainers (or (cdr (assoc :maintainers extras))
+                          (cdr (assoc :maintainer extras))))
          (authors (cdr (assoc :authors extras)))
          (news (and-let* (pkg-dir
                           ((not built-in))
@@ -2831,19 +2832,21 @@ describe-package-1
          'action 'package-keyword-button-action)
         (insert " "))
       (insert "\n"))
-    (when maintainer
-      (package--print-help-section "Maintainer")
-      (package--print-email-button maintainer))
-    (when authors
+    (when maintainers
+      (unless (car-safe (car maintainers))
+        (setq maintainers (list maintainers)))
       (package--print-help-section
-          (if (= (length authors) 1)
-              "Author"
-            "Authors"))
-      (package--print-email-button (pop authors))
-      ;; If there's more than one author, indent the rest correctly.
-      (dolist (name authors)
-        (insert (make-string 13 ?\s))
-        (package--print-email-button name)))
+          (if (cdr maintainers) "Maintainers" "Maintainer"))
+      (dolist (maintainer maintainers)
+        (when (bolp)
+          (insert (make-string 13 ?\s)))
+        (package--print-email-button maintainer)))
+    (when authors
+      (package--print-help-section (if (cdr authors) "Authors" "Author"))
+      (dolist (author authors)
+        (when (bolp)
+          (insert (make-string 13 ?\s)))
+        (package--print-email-button author)))
     (let* ((all-pkgs (append (cdr (assq name package-alist))
                              (cdr (assq name package-archive-contents))
                              (let ((bi (assq name package--builtins)))
-- 
2.39.2

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonas Bernoulli <jonas <at> bernoul.li>
To: bug-gnu-emacs <at> gnu.org
Cc: philipk <at> posteo.net, monnier <at> iro.umontreal.ca
Subject: Re: [PATCH] Support displaying all package maintainers
Date: Wed, 29 Mar 2023 18:39:05 +0200

> +      (unless (car-safe (car maintainers))
> +        (setq maintainers (list maintainers)))

s/car-safe/proper-list-p/

Message #11 received at 62524 <at> debbugs.gnu.org (full text, mbox):

From: Jonas Bernoulli <jonas <at> bernoul.li>
To: 62524 <at> debbugs.gnu.org
Subject: Support displaying all package maintainers
Date: Wed, 05 Apr 2023 16:50:49 +0200

[ I am re-sending this message because the MDS refused to deliver
  the previous iteration.

  Stefan, your reply contained a header "Cc: ??@debbugs.gnu.org". ]

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> Even once all ELPAs have been updated to include `:maintainers', they
>> have to continue to also include `:maintainer', for the benefit of
>> older versions of this function / package.el / Emacs.
>
> We could drop `:maintainer` within a few years, tho: this info is not
> super-important and it would impact only users of older Emacsen.

That's the plan.

>> To avoid this duplication, `package' would have to be distributed on
>> GNU ELPA as a "core" package.
>
> That still wouldn't help those users who didn't upgrade their built-in
> `package.el`.

I hope that we can eventually not only make Package available on GNU
Elpa, but also get users of older Emacs releases to update to that
version, see 87tty24ap2.fsf <at> bernoul.li

> Other than that: OK with me.

So should I go ahead and install this now (on master, I assume)?

Once that is done, I'll update the elpa-admin equivalent for Melpa.  I
plan to only include :maintainers in archive-contents if there actually
are multiple maintainers.  That way there is less duplicated data, and
I recommend you do the same in elpa-admin.

Oh, and the comment you added to package-buffer-info in 4e6f98cd505ed56
is wrong; shall I just replace "single string" with "single cons-cell"?

     Cheers,
     Jonas

Message #14 received at 62524 <at> debbugs.gnu.org (full text, mbox):

From: Jonas Bernoulli <jonas <at> bernoul.li>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: philipk <at> posteo.net, 62524 <at> debbugs.gnu.org
Subject: Re: [PATCH] Support displaying all package maintainers
Date: Thu, 27 Apr 2023 23:23:27 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> [ Sorry 'bout the delay.  ]
>
>>> Other than that: OK with me.
>> So should I go ahead and install this now (on master I assume)?
>
> Yes, please.

No problem ;P

I've just done that.

     Jonas

Message #17 received at 62524 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jonas Bernoulli <jonas <at> bernoul.li>
Cc: philipk <at> posteo.net, 62524 <at> debbugs.gnu.org
Subject: Re: [PATCH] Support displaying all package maintainers
Date: Sun, 30 Apr 2023 22:11:06 -0400

> I've just done that.

Thanks, Jonas!


        Stefan

Message #22 received at 62524-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: philipk <at> posteo.net, Jonas Bernoulli <jonas <at> bernoul.li>,
 62524-done <at> debbugs.gnu.org
Subject: Re: bug#62524: [PATCH] Support displaying all package maintainers
Date: Fri, 1 Sep 2023 21:36:18 +0200

This bug was accidentally left open, closing it now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.