GNU logs - #62598, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#62598: 29.0.60; url-https-proxy-connect doesn't support multi-stage auth to proxies
Resent-From: Spencer Baugh <sbaugh@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 01 Apr 2023 20:29:01 +0000
Resent-Message-ID: <handler.62598.B.168038092532347 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 62598 <at> debbugs.gnu.org
From: Spencer Baugh <sbaugh@HIDDEN>
Date: Sat, 01 Apr 2023 16:28:39 -0400
Message-ID: <ierlejb2vpk.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=64.215.233.18; envelope-from=sbaugh@HIDDEN;
 helo=mxout5.mail.janestreet.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

url-http knows how to use HTTPS proxies, primarily in
url-https-proxy-connect.  It even knows to authenticate to those
proxies, as fixed in bug#42422.

But some HTTP authentication methods (e.g. NTLM as supported by
url-http-ntlm) require multiple stages of back-and-forth in
authentication.  This works fine with regular HTTP requests and requests
to HTTP (non-S) proxies; it's handled by url-http-handle-authentication
which is called by url-http-parse-headers when it sees a 401 or 407
(auth required and proxy auth required) status.

But this does not work with the HTTPS proxy support, because if it sees
401 or 407 as a response to CONNECT, it just immediately fails.

I'm very interested in adding this but I'm unsure how to approach it.  I
guess that url-https-proxy-after-change-function should be calling
something similar to url-http-handle-authentication.  Or maybe the whole
design of how HTTPS proxy support works today is wrong, and it should be
calling url-http-parse-headers like everything else?

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Spencer Baugh <sbaugh@HIDDEN>
Subject: bug#62598: Acknowledgement (29.0.60; url-https-proxy-connect
 doesn't support multi-stage auth to proxies)
Message-ID: <handler.62598.B.168038092532347.ack <at> debbugs.gnu.org>
References: <ierlejb2vpk.fsf@HIDDEN>
X-Gnu-PR-Message: ack 62598
X-Gnu-PR-Package: emacs
Reply-To: 62598 <at> debbugs.gnu.org
Date: Sat, 01 Apr 2023 20:29:01 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 62598 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
62598: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D62598
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#62598: 29.0.60; url-https-proxy-connect doesn't support multi-stage auth to proxies
Resent-From: Thomas Fitzsimmons <fitzsim@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 05 Apr 2023 23:35:02 +0000
Resent-Message-ID: <handler.62598.B62598.168073767620739 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Spencer Baugh <sbaugh@HIDDEN>
Cc: 62598 <at> debbugs.gnu.org
From: Thomas Fitzsimmons <fitzsim@HIDDEN>
In-Reply-To: <ierlejb2vpk.fsf@HIDDEN> (Spencer Baugh's message of
 "Sat, 01 Apr 2023 16:28:39 -0400")
References: <ierlejb2vpk.fsf@HIDDEN>
Date: Wed, 05 Apr 2023 19:34:21 -0400
Message-ID: <m3bkk1dhtu.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi Spencer,

Spencer Baugh <sbaugh@HIDDEN> writes:

> url-http knows how to use HTTPS proxies, primarily in
> url-https-proxy-connect.  It even knows to authenticate to those
> proxies, as fixed in bug#42422.
>
> But some HTTP authentication methods (e.g. NTLM as supported by
> url-http-ntlm) require multiple stages of back-and-forth in
> authentication.  This works fine with regular HTTP requests and requests
> to HTTP (non-S) proxies; it's handled by url-http-handle-authentication
> which is called by url-http-parse-headers when it sees a 401 or 407
> (auth required and proxy auth required) status.
>
> But this does not work with the HTTPS proxy support, because if it sees
> 401 or 407 as a response to CONNECT, it just immediately fails.

Why can't that code path call url-http-handle-authentication instead of
just failing?  What makes HTTPS different from HTTP in this respect?

> I'm very interested in adding this but I'm unsure how to approach it.  I
> guess that url-https-proxy-after-change-function should be calling
> something similar to url-http-handle-authentication.  Or maybe the whole
> design of how HTTPS proxy support works today is wrong, and it should be
> calling url-http-parse-headers like everything else?

I'd say try to make both approaches work, and see which one results in
the minimum set of changes.

Thomas

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#62598: 29.0.60; url-https-proxy-connect doesn't support multi-stage auth to proxies
Resent-From: "J.P." <jp@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 09 Sep 2023 14:22:02 +0000
Resent-Message-ID: <handler.62598.B62598.169426928713971 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Spencer Baugh <sbaugh@HIDDEN>
Cc: 62598 <at> debbugs.gnu.org
From: "J.P." <jp@HIDDEN>
In-Reply-To: <ierlejb2vpk.fsf@HIDDEN> (Spencer Baugh's message of
 "Sat, 01 Apr 2023 16:28:39 -0400")
References: <ierlejb2vpk.fsf@HIDDEN>
Date: Sat, 09 Sep 2023 07:21:13 -0700
Message-ID: <87r0n7a0me.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi, just wondering if you might be interested in broadening the scope of
this bug into something more ambitious, namely, making proxy handling
more flexible and predictable for libraries doing business with `url'.
I've been tinkering with

  https://debbugs.gnu.org/cgi/bugreport.cgi?bug=53941

off and on for a bit, but I'm not familiar enough with the `url'
landscape to go all in. From your bug description, you seem to have a
good handle on the `url-http' parts, so perhaps you're open to exploring
ideas for improving the overall proxy situation `url'-wide. If so, I'd
be willing to investigate how best to adapt `socks' to whatever you
might propose. Just a thought, though (no pressure).

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 11 Sep 2023 23:42:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 11 19:42:01 2023
Received: from localhost ([127.0.0.1]:55221 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qfqXY-0000RP-SK
	for submit <at> debbugs.gnu.org; Mon, 11 Sep 2023 19:42:01 -0400
Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]:54357)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1qfqXX-0000RC-HF
 for control <at> debbugs.gnu.org; Mon, 11 Sep 2023 19:41:59 -0400
Received: by mail-lj1-x233.google.com with SMTP id
 38308e7fff4ca-2bf6b37859eso57929281fa.0
 for <control <at> debbugs.gnu.org>; Mon, 11 Sep 2023 16:41:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20221208; t=1694475709; x=1695080509; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=JsWXIGWDzlVmmqXhkeYMSXhnomGmfdG8Aro3xNYB1R4=;
 b=oc/0TTtj4Pu/ryF4Y0GpY7dsF3T164GR40zb385qmCAqhU87SOrRl4WVLBhuPCqgxO
 Zg8Zb/IAhlHCWtbv1/WpMiVdSy02nAxVGvuyfhTZdBjhXxsn5i4FKFD3sAizUTqgpLf5
 hi/htDzFMECVHycp7J1VYc8OFhkw+kTJd5h4AY9Mh0lPAtWiX1JDhITnBdO7iSullJ0E
 rTblCNMwhPPeWrMKemHtT8k6ToQPnYStq90dNWhUy0P3gUhTKdNLbci/0Gb4cv5345ED
 n2AzrArIMmaWiLxJXAJl2Uz+Limg9dAlaC1hQEv1Q4aOE7trHehhEXSjN7NkDNPcYwQw
 SZ2A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1694475709; x=1695080509;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=JsWXIGWDzlVmmqXhkeYMSXhnomGmfdG8Aro3xNYB1R4=;
 b=aRmBrAOwoZNjpyyCH1I5Pk/u/EMvZvyCNyPe0p3qfTw7E+qS/c48U2TRSZtKI9zJPN
 x5qY+KIeHwYAOBDsATyNcQM16Wr319UXhjKlxKuADnmYkywATcsG4e4VrO6su5RsJXUg
 FR/a9ackoFPwh0VRVuKxa9mjzlt8H5kpT3DySjlEJs+iQ1HVB7+ias22GGKC/1NzOnFu
 Srf1yXSCQZd5D49COZYo0D8dT9OPVw8EiXxd/SRnwoTwha32Mjd2OYnrLRp3xsJ5BU4s
 1p0uZ/scZFO2g8UqIRtSpsG0UDCnNd4MuPDiVz2GL9sgmyvT7e82/6sSg738NCj5KxmA
 yOMg==
X-Gm-Message-State: AOJu0YzWBt13S1ksfyTKikY1t4gw4a5Lsu0rGpa6ltCBmxVHmbm26qoQ
 oWPErD4aQi4kimgBIsanUf6M2e1QjSBymb91mPpWp0rp
X-Google-Smtp-Source: AGHT+IERGcd6Gif3qJcunc5xfSs4rLf9zlAs5qVsUAMv1xjLGf962x02gypkTA+jMN7i/Afbf8I5sf8PT3EOcBp6zl0=
X-Received: by 2002:a2e:321a:0:b0:2bc:b6a3:5a9 with SMTP id
 y26-20020a2e321a000000b002bcb6a305a9mr8558425ljy.37.1694475709249; Mon, 11
 Sep 2023 16:41:49 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Mon, 11 Sep 2023 16:41:48 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Mon, 11 Sep 2023 16:41:48 -0700
Message-ID: <CADwFkm=Z2_Vm4GMjVcEP-Fa=ezKfG_S3k9OP_VCM1jmktDaong@HIDDEN>
Subject: control message for bug #62598
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 62598 wishlist
quit

Last modified: Mon, 11 Sep 2023 23:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.