GNU bug report logs - #62629
[PATCH] gnu: guile-pipe: Remove unused install script.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62629 in the body.
You can then email your comments to 62629 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: guile-pipe: Remove unused install script.
Date: Sun,  2 Apr 2023 15:03:22 -0500

* gnu/packages/guile-xyz.scm (guile-pipe): Remove script.
---
 gnu/packages/guile-xyz.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index fd8fb25da1..691635e155 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -362,7 +362,10 @@ (define-public guile-pipe
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "038gwrhfywgs8372q478wn4623lhcmkknfj4p8yaa93bykfc0fml"))))
+          (base32 "038gwrhfywgs8372q478wn4623lhcmkknfj4p8yaa93bykfc0fml"))
+         (modules '((guix build utils)))
+         ;; Remove unused install script.
+         (snippet '(begin (delete-file "install")))))
       (build-system guile-build-system)
       (native-inputs
        (list guile-3.0))
-- 
2.39.2

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>, 62629 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: Re: [bug#62629] [PATCH] gnu: guile-pipe: Remove unused install script.
Date: Fri, 12 May 2023 20:52:02 +0200

[Message part 1 (text/plain, inline)]

Hi jgart,

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/guile-xyz.scm (guile-pipe): Remove script.
> ---
>  gnu/packages/guile-xyz.scm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
> index fd8fb25da1..691635e155 100644
> --- a/gnu/packages/guile-xyz.scm
> +++ b/gnu/packages/guile-xyz.scm
> @@ -362,7 +362,10 @@ (define-public guile-pipe
>                 (commit commit)))
>           (file-name (git-file-name name version))
>           (sha256
> -          (base32 "038gwrhfywgs8372q478wn4623lhcmkknfj4p8yaa93bykfc0fml"))))
> +          (base32 "038gwrhfywgs8372q478wn4623lhcmkknfj4p8yaa93bykfc0fml"))
> +         (modules '((guix build utils)))
> +         ;; Remove unused install script.
> +         (snippet '(begin (delete-file "install")))))
>        (build-system guile-build-system)
>        (native-inputs
>         (list guile-3.0))
> -- 
> 2.39.2

Is this really necessary?  guile-pipe builds fine without it and this
doesn't end up in the output, right?

Best,
-- 
Josselin Poiret

[signature.asc (application/pgp-signature, inline)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Josselin Poiret" <dev <at> jpoiret.xyz>, "jgart via Guix-patches via"
 <guix-patches <at> gnu.org>, 62629 <at> debbugs.gnu.org
Subject: Re: [bug#62629] [PATCH] gnu: guile-pipe: Remove unused install script.
Date: Fri, 12 May 2023 21:18:58 +0000

Hi Josselin, 

I checked that it doesn't end up in the output. Yes, this is unnecessary.

I'll give a closer read to guile-build-system to remind myself of the glob patterns that it matches on for copying to the output.

Thanks for the review,

jgart

Message #22 received at 62629-done <at> debbugs.gnu.org (full text, mbox):

From: Josselin Poiret <dev <at> jpoiret.xyz>
To: jgart <jgart <at> dismail.de>, 62629-done <at> debbugs.gnu.org
Subject: Re: [bug#62629] [PATCH] gnu: guile-pipe: Remove unused install script.
Date: Sat, 13 May 2023 09:39:42 +0200

[Message part 1 (text/plain, inline)]

Hi jgart,

"jgart" <jgart <at> dismail.de> writes:

> Hi Josselin, 
>
> I checked that it doesn't end up in the output. Yes, this is unnecessary.
>
> I'll give a closer read to guile-build-system to remind myself of the glob patterns that it matches on for copying to the output.

Closing then!

Best
-- 
Josselin Poiret

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.