X-Loop: help-debbugs@HIDDEN Subject: bug#62663: 28.2; vc-hg-state returns incorrect results on directories in some repos Resent-From: Spencer Baugh <sbaugh@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 04 Apr 2023 14:06:02 +0000 Resent-Message-ID: <handler.62663.B.16806171276202 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 62663 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 62663 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.16806171276202 (code B ref -1); Tue, 04 Apr 2023 14:06:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Apr 2023 14:05:27 +0000 Received: from localhost ([127.0.0.1]:49947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pjhHq-0001by-MS for submit <at> debbugs.gnu.org; Tue, 04 Apr 2023 10:05:27 -0400 Received: from lists.gnu.org ([209.51.188.17]:49036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <sbaugh@HIDDEN>) id 1pjhHo-0001bn-2Z for submit <at> debbugs.gnu.org; Tue, 04 Apr 2023 10:05:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <sbaugh@HIDDEN>) id 1pjhHn-0006Hy-Nk for bug-gnu-emacs@HIDDEN; Tue, 04 Apr 2023 10:05:23 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <sbaugh@HIDDEN>) id 1pjhHl-0007Ni-1r for bug-gnu-emacs@HIDDEN; Tue, 04 Apr 2023 10:05:23 -0400 From: Spencer Baugh <sbaugh@HIDDEN> Date: Tue, 04 Apr 2023 10:05:19 -0400 Message-ID: <ier5yabkajk.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.215.233.18; envelope-from=sbaugh@HIDDEN; helo=mxout5.mail.janestreet.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) The problem is with vc-hg-state-fast, which parses Mercurial data structures instead of shelling out to hg. This is a great idea but our parsing seems to be wrong right now in some way. 1. Create a new hg repo with: hg init --config format.use_share_safe=false --config format.use-persistent-nodemap=false --config format.sparse-revlog=false --config format.revlog-compression=zlib (This is disabling some recent hg features which make vc-hg-state use the slow path. You can verify that vc-hg-state-fast is going to run by checking that .hg/requirements is a subset of vc-hg-supported-requirements) 2. touch foo && hg add foo && hg commit -m. 3. (vc-hg-state-slow ".") Returns 'up-to-date which is correct (because it shells out to hg) 4. (vc-hg-state ".") Returns 'unregistered which is wrong To a user, this manifests as various hg commands failing with errors, often something like "vc-find-backend-function: Cannot open load file: No such file or directory, vc-nil" This also happens on Emacs 29. (Note that this is independent of my other bug about lack of support for certain repo requirements. That bug is about expanding vc-hg-state-fast support to new repos; this bug is showing that the already existing support is buggy!) In GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.15.12, Xaw scroll bars) of 2023-02-09 built on igm-qws-u12685a Repository revision: 739b5d0e52d83ec567bd61a5a49ac0e93e0eb469 Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: CentOS Linux 7 (Core) Configured using: 'configure --with-x-toolkit=lucid --without-gpm --without-gconf --without-selinux --without-imagemagick --with-modules --with-gif=no --with-cairo --with-rsvg --prefix=/j/office/app/emacs/builds/28.2-20230209-135825' Configured features: CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM LUCID ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: shell-dirtrack-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug sendmail dabbrev pp cl-print log-edit message rmc puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source eieio eieio-core cl-macs eieio-loaddefs password-cache json map time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log shell pcomplete comint ansi-color ring misearch multi-isearch jka-compr find-func shortdoc text-property-search vc-annotate vc-filewise thingatpt help-fns radix-tree help-mode cl-seq vc-mtn vc-hg vc-git diff-mode easy-mmode vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs vc-dir seq byte-opt gv bytecomp byte-compile cconv ewoc vc vc-dispatcher dired-aux cl-loaddefs cl-lib dired dired-loaddefs iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 119456 11097) (symbols 48 13754 1) (strings 32 40872 1164) (string-bytes 1 1248921) (vectors 16 18713) (vector-slots 8 234707 16776) (floats 8 86 32) (intervals 56 1922 0) (buffers 992 25) (heap 1024 18673 1560))
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Spencer Baugh <sbaugh@HIDDEN> Subject: bug#62663: Acknowledgement (28.2; vc-hg-state returns incorrect results on directories in some repos) Message-ID: <handler.62663.B.16806171276202.ack <at> debbugs.gnu.org> References: <ier5yabkajk.fsf@HIDDEN> X-Gnu-PR-Message: ack 62663 X-Gnu-PR-Package: emacs Reply-To: 62663 <at> debbugs.gnu.org Date: Tue, 04 Apr 2023 14:06:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 62663 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 62663: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D62663 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#62663: 28.2; vc-hg-state returns incorrect results on directories in some repos Resent-From: Dmitry Gutov <dmitry@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 13 Apr 2023 00:45:01 +0000 Resent-Message-ID: <handler.62663.B62663.168134668627158 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 62663 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Spencer Baugh <sbaugh@HIDDEN>, 62663 <at> debbugs.gnu.org, Daniel Colascione <dancol@HIDDEN> Received: via spool by 62663-submit <at> debbugs.gnu.org id=B62663.168134668627158 (code B ref 62663); Thu, 13 Apr 2023 00:45:01 +0000 Received: (at 62663) by debbugs.gnu.org; 13 Apr 2023 00:44:46 +0000 Received: from localhost ([127.0.0.1]:42113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pml4v-00073y-LK for submit <at> debbugs.gnu.org; Wed, 12 Apr 2023 20:44:45 -0400 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]:58787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1pml4r-00073i-GR for 62663 <at> debbugs.gnu.org; Wed, 12 Apr 2023 20:44:44 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id F04E12B06861; Wed, 12 Apr 2023 20:44:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 12 Apr 2023 20:44:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681346673; x=1681350273; bh=PE2O4wdjs5iFL8Md6w1U9IiosC/1nGqv8Ef PwRfTYIM=; b=oLQlMo6I/24M8r5Pjf2Wu4BTea2kH6EMiBAjsfEF4HEtUv4AJj9 j7n0ymFH/IjLTeB2Kyene+sm0TNC95I+LYID0CZIlzpaY7jirWC9JPrljNFD1LQ5 Ycb/Oai+o6SdOiMpKlRJM4B0gIppTeWIB85/AnY85fxOV+Pap7HVTaA84AeCV9GR UtV3LmtMI4ELcZpvZs63F2wbndVBtztydFiMGtDFamqtk0RVJz3uDuGue39cnxMM tTVZ7RazCwCXI7RhOW860jwwbra60/kCOmUEBh0rvcFEklybQGeiMwf/DLh3UNUI c1HMoI2EgG96wwvhj91ez57ZThU0Jj8wsqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1681346673; x= 1681350273; bh=PE2O4wdjs5iFL8Md6w1U9IiosC/1nGqv8EfPwRfTYIM=; b=O TB85VaFVPACaMlQTBCisEUo8S8rR1QtV7WBpLe7gd9hYPrF8EIu5bihC1GRasMhZ AQRoVUPx+0e7+dHQmwl7mLzveSeO8htPW3xWSJHbksnvqkC6H9Qp7DwjKDfZf3vP VjquFSdMD1/iFP/NXas1PS5C/zgwLK9zdsT1SAHGpMOVzdMeIg7Fj21PWVMVkKLu X/n38w25x46dvhEKH/0NAStd4nVMt8gmJjR3P28q6ivr9h9TLNAejB926FFr98K2 wcbR5OJrWmIJTTPKnV9EwgRCw/LYEJ9467ph95WB0j6LvFNMvvdjhLTtKiLVEzgt J9tmk1zsGA+QRDmqVxWJg== X-ME-Sender: <xms:cVA3ZGux_GS_uEX8DnT8iOR6ZwPnBhGJKM5dBMz9dBR2cpKiy8Jd6g> <xme:cVA3ZLfIl6cYhjHFuEarT3vvjjVNskQpE0y_Ct9LlVr_lXZjbJ5ZtHzNhgTV--5ii XslafjHn5J5AGU4-AU> X-ME-Received: <xmr:cVA3ZBw4CWwGp5UL6EEvc6NC99uzQ29suJmQxGC3SyWblbZb5txCIqQN7cv5Z2xG> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekjedgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeghedthedujeeiteeutddtjeekheejteeukeehffdutdejuedvfeevueeviedu udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: <xmx:cVA3ZBN4CY-bGFeoqnnMbCDcR6ofjygUoeW4XK_d_K7lpKPFopRNnw> <xmx:cVA3ZG_2sNBtZib-6l4SQmg5AyHTbFFR7CDifoz8IzBOlNfxnF3BFA> <xmx:cVA3ZJVD-8mM1hMWZGRSKFEw4WGq6ogAEJAlWsW0UD-IJ4mqzMcFtw> <xmx:cVA3ZMlS4pQhJqhWolpfVcv5BAFaJYoQXTwkg-ya50b_Ub5i6Y6ttzNyjKc> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Apr 2023 20:44:31 -0400 (EDT) Message-ID: <9272e622-ba9b-7c9d-b143-57bb97696ba3@HIDDEN> Date: Thu, 13 Apr 2023 03:44:30 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US References: <ier5yabkajk.fsf@HIDDEN> From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <ier5yabkajk.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.1 (--) Hi! Thanks for the report. On 04/04/2023 17:05, Spencer Baugh wrote: > The problem is with vc-hg-state-fast, which parses Mercurial data > structures instead of shelling out to hg. This is a great idea but our > parsing seems to be wrong right now in some way. > > 1. Create a new hg repo with: > > hg init > --config format.use_share_safe=false > --config format.use-persistent-nodemap=false > --config format.sparse-revlog=false > --config format.revlog-compression=zlib > > (This is disabling some recent hg features which make vc-hg-state use > the slow path. You can verify that vc-hg-state-fast is going to run by > checking that .hg/requirements is a subset of > vc-hg-supported-requirements) > > 2. touch foo && hg add foo && hg commit -m. > 3. (vc-hg-state-slow ".") > Returns 'up-to-date which is correct (because it shells out to hg) > 4. (vc-hg-state ".") > Returns 'unregistered which is wrong > > To a user, this manifests as various hg commands failing with errors, > often something like > "vc-find-backend-function: Cannot open load file: No such file or directory, vc-nil" > > This also happens on Emacs 29. > > (Note that this is independent of my other bug about lack of support for > certain repo requirements. That bug is about expanding vc-hg-state-fast > support to new repos; this bug is showing that the already existing > support is buggy!) Patches are welcome, of course. I'm going to Cc the original author of that code, but that's just for courtesy.
Received: (at control) by debbugs.gnu.org; 11 Sep 2023 23:39:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 11 19:39:45 2023 Received: from localhost ([127.0.0.1]:55206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qfqVM-0000MQ-SV for submit <at> debbugs.gnu.org; Mon, 11 Sep 2023 19:39:45 -0400 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]:47268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1qfqVL-0000MB-HO for control <at> debbugs.gnu.org; Mon, 11 Sep 2023 19:39:44 -0400 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2bbbda48904so83878151fa.2 for <control <at> debbugs.gnu.org>; Mon, 11 Sep 2023 16:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694475573; x=1695080373; darn=debbugs.gnu.org; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=IAm+rXuAId5AwMdH8q1Q9LELedEfKLkxSpWzgVxlA+M=; b=HcHp+AW5hW1DD2g5YpryGiSonkKeBUvdpUGRe29D4dB2w18ciK8uQO+UBI4hALYv3J hKi5cq9rdF+UVY9fJRymdRvQZKt58pELvwAsQ+pXE6cfPylgIl+EIx/Pe0W/DLc05UPO v6+Y61vVBrk/WNavABzMsFbPhcEbiHFDbee4PN5DPo+jSeyZfBT1FI9vX4rio2C2whnq TrymkwX3IU7dA0EA0xy2WNtOu/Y6X2M1qqZGLSGG7euiu+KbSUnuTLR6oSj2OnwiAowZ +yf8/z85SYija9OEhHcUxpwDxkJWCuITJaaLoT/7t4hbd95gUg8urqOxZYxqJiUyUK9p V5qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694475573; x=1695080373; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IAm+rXuAId5AwMdH8q1Q9LELedEfKLkxSpWzgVxlA+M=; b=RZgilDb52sz23waXtPHWzg1GOb0R24Swx81ZUplPxCS/ke1w/aCiVK/y8L7Z5LyPVE TvQq8mdhdZaqJTgmjFUbs2AROH5ibiuB8m6PocJGfNrbMHTU7f9+oH6bjX8rUbwc9Tzf 4Ry+9xb5RpCRngzRoUJG5D3wgAav9ryG+jkpG/0he188Mk/C07zeF7kirZ+PHKiotlPO igW0o7EmFxUCdkL0NHm3vyNgjW2ENo90lb2A6JMHZqQQdn7VquXaD5o4g34e5HBBIQWz vEGtsi7Q/f1n4cG1ZU/CJwvnCTXGjG8q0tSdRmnfuTx3OwQvnfzs+rt0JjxWfh5QVzu1 VrUQ== X-Gm-Message-State: AOJu0YzAAzDsjLnCpdo+m3bJhPuZU8DopIC+YJOLJdYK1VE3Wy9OhglI q/1mm0lAbNV5KHZg9nmnhsR0qcIFSQ6hq+BFvp1Wb8/U X-Google-Smtp-Source: AGHT+IHRM3vmeo/n8FnGtpbIAUSK/R5A3scgSckpjJWpWrUW5BRXhzP9GNbxWkK57nTFbVQoVNp8AcPJr5pWwIvK6MM= X-Received: by 2002:a2e:9098:0:b0:2bc:bece:2264 with SMTP id l24-20020a2e9098000000b002bcbece2264mr8523717ljg.50.1694475573215; Mon, 11 Sep 2023 16:39:33 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 11 Sep 2023 16:39:32 -0700 From: Stefan Kangas <stefankangas@HIDDEN> MIME-Version: 1.0 Date: Mon, 11 Sep 2023 16:39:32 -0700 Message-ID: <CADwFkmn9MuqLdLGRT8+XOzkOh5W8BBdOxDN5a74Q=cP45ka-kQ@HIDDEN> Subject: control message for bug #62663 To: control <at> debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) tags 62663 + confirmed quit
X-Loop: help-debbugs@HIDDEN Subject: bug#62663: 28.2; vc-hg-state returns incorrect results on directories in some repos Resent-From: Sean Whitton <spwhitton@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Tue, 04 Mar 2025 04:12:02 +0000 Resent-Message-ID: <handler.62663.B62663.174106150030861 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 62663 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed To: Spencer Baugh <sbaugh@HIDDEN> Cc: 62663 <at> debbugs.gnu.org, control <at> debbugs.gnu.org Received: via spool by 62663-submit <at> debbugs.gnu.org id=B62663.174106150030861 (code B ref 62663); Tue, 04 Mar 2025 04:12:02 +0000 Received: (at 62663) by debbugs.gnu.org; 4 Mar 2025 04:11:40 +0000 Received: from localhost ([127.0.0.1]:54005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tpJd5-00081h-N7 for submit <at> debbugs.gnu.org; Mon, 03 Mar 2025 23:11:40 -0500 Received: from sendmail.purelymail.com ([34.202.193.197]:35988) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1tpJd3-00081L-F3 for 62663 <at> debbugs.gnu.org; Mon, 03 Mar 2025 23:11:38 -0500 DKIM-Signature: a=rsa-sha256; b=3zpmJLR+1oGzfDsIa/9sbsXaonDVJiM9G3qRQvMjrskQsc0G5jM3xYuCeEj0MDuwQWTiS+CWpgkY52UmPIyGDOtmzfIMyKAcTJuF+yQlN5OS02bLLn5kE7xYlEOUhk+IBc18Qk23Q+Bf1Hm9TXS5SLQLIc/4h7nqLtwsFGE7wfLD/9hD+ene78Rl5gsCbuVtoEBgOzV7szGh5+Ww9XB39aESteX1uYkGdgTUoA/95+F1Kxi6AA3TF9gBr3KyZwWwYCgCrwJJ/sqGH6OkkxA4zhHD57eleCnb++Cjcd5t7/coIixXNvtyA7AEJvRmmt99m/cYorFKrFyIyeRDtWkuJQ==; s=purelymail2; d=spwhitton.name; v=1; bh=CMKpklHSWQGDNKZpKUEyA7eluz0zdmRJ52Qr3KktKZM=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=cyIYL7Y4P7owtUFW1leXUNjpB6oDzZhOCfXeauTBLRhzErmPpgLAoICWKzgCG+2MMDBRgHDzSGS5HIHCKNkvm+Ucam7WJp+64V4ihxX3/KM0gQJErs1XuzVvC+jouu1M8rYEVrS8hmaZx2HYvQr304Kf4KxoT8Vzv4A3fEzdt2gdXiIVARLRM8MijOIq+jjrYUVbDBx2jiqeoCS5KREcfmdlHWgxYUT5lbJpIqeEMSXPFCY+GNB5Z7Unvyx2Byeq6lmj/ADMgK6jz5XFcfM8b9Z0oO8+v+x9TNt0FcG1gbgbTFDwhxKfdzrqyA5BTQrKCD0VWVEjKs2SJRbRSbXI1Q==; s=purelymail2; d=purelymail.com; v=1; bh=CMKpklHSWQGDNKZpKUEyA7eluz0zdmRJ52Qr3KktKZM=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 62663 <at> debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1391808961; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 04 Mar 2025 04:11:29 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 0630A7E3866; Tue, 4 Mar 2025 12:11:23 +0800 (CST) From: Sean Whitton <spwhitton@HIDDEN> In-Reply-To: <ier5yabkajk.fsf@HIDDEN> References: <ier5yabkajk.fsf@HIDDEN> Date: Tue, 04 Mar 2025 12:11:23 +0800 Message-ID: <877c555tas.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) tag 62663 - confirmed + moreinfo thanks Hello, On Tue 04 Apr 2023 at 10:05am -04, Spencer Baugh wrote: > The problem is with vc-hg-state-fast, which parses Mercurial data > structures instead of shelling out to hg. This is a great idea but our > parsing seems to be wrong right now in some way. > > 1. Create a new hg repo with: > > hg init > --config format.use_share_safe=false > --config format.use-persistent-nodemap=false > --config format.sparse-revlog=false > --config format.revlog-compression=zlib > > (This is disabling some recent hg features which make vc-hg-state use > the slow path. You can verify that vc-hg-state-fast is going to run by > checking that .hg/requirements is a subset of > vc-hg-supported-requirements) ITYM .hg/requires, right? When I create a repository in this way, that file contains share-safe, whether or not I pass those --config options. I've hg 6.3.2 here. > 2. touch foo && hg add foo && hg commit -m. > 3. (vc-hg-state-slow ".") > Returns 'up-to-date which is correct (because it shells out to hg) > 4. (vc-hg-state ".") > Returns 'unregistered which is wrong This recipe doesn't work for me. Evaluating both of these forms yields nil. Evaluating them with "foo" instead of "." yields up-to-date in both cases. Is it possible that this problem is only reproducible with newer hg? Could you confirm your recipe still works, and let me know the version of hg, please? Thanks. -- Sean Whitton
Received: (at control) by debbugs.gnu.org; 4 Mar 2025 04:11:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 03 23:11:45 2025 Received: from localhost ([127.0.0.1]:54010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tpJdB-000821-3B for submit <at> debbugs.gnu.org; Mon, 03 Mar 2025 23:11:45 -0500 Received: from sendmail.purelymail.com ([34.202.193.197]:33786) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1tpJd9-00081Z-Fk for control <at> debbugs.gnu.org; Mon, 03 Mar 2025 23:11:43 -0500 DKIM-Signature: a=rsa-sha256; b=3zpmJLR+1oGzfDsIa/9sbsXaonDVJiM9G3qRQvMjrskQsc0G5jM3xYuCeEj0MDuwQWTiS+CWpgkY52UmPIyGDOtmzfIMyKAcTJuF+yQlN5OS02bLLn5kE7xYlEOUhk+IBc18Qk23Q+Bf1Hm9TXS5SLQLIc/4h7nqLtwsFGE7wfLD/9hD+ene78Rl5gsCbuVtoEBgOzV7szGh5+Ww9XB39aESteX1uYkGdgTUoA/95+F1Kxi6AA3TF9gBr3KyZwWwYCgCrwJJ/sqGH6OkkxA4zhHD57eleCnb++Cjcd5t7/coIixXNvtyA7AEJvRmmt99m/cYorFKrFyIyeRDtWkuJQ==; s=purelymail2; d=spwhitton.name; v=1; bh=CMKpklHSWQGDNKZpKUEyA7eluz0zdmRJ52Qr3KktKZM=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=cyIYL7Y4P7owtUFW1leXUNjpB6oDzZhOCfXeauTBLRhzErmPpgLAoICWKzgCG+2MMDBRgHDzSGS5HIHCKNkvm+Ucam7WJp+64V4ihxX3/KM0gQJErs1XuzVvC+jouu1M8rYEVrS8hmaZx2HYvQr304Kf4KxoT8Vzv4A3fEzdt2gdXiIVARLRM8MijOIq+jjrYUVbDBx2jiqeoCS5KREcfmdlHWgxYUT5lbJpIqeEMSXPFCY+GNB5Z7Unvyx2Byeq6lmj/ADMgK6jz5XFcfM8b9Z0oO8+v+x9TNt0FcG1gbgbTFDwhxKfdzrqyA5BTQrKCD0VWVEjKs2SJRbRSbXI1Q==; s=purelymail2; d=purelymail.com; v=1; bh=CMKpklHSWQGDNKZpKUEyA7eluz0zdmRJ52Qr3KktKZM=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: control <at> debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1391808961; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 04 Mar 2025 04:11:29 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 0630A7E3866; Tue, 4 Mar 2025 12:11:23 +0800 (CST) From: Sean Whitton <spwhitton@HIDDEN> To: Spencer Baugh <sbaugh@HIDDEN> Subject: Re: bug#62663: 28.2; vc-hg-state returns incorrect results on directories in some repos In-Reply-To: <ier5yabkajk.fsf@HIDDEN> References: <ier5yabkajk.fsf@HIDDEN> Date: Tue, 04 Mar 2025 12:11:23 +0800 Message-ID: <877c555tas.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 62663 <at> debbugs.gnu.org, control <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) tag 62663 - confirmed + moreinfo thanks Hello, On Tue 04 Apr 2023 at 10:05am -04, Spencer Baugh wrote: > The problem is with vc-hg-state-fast, which parses Mercurial data > structures instead of shelling out to hg. This is a great idea but our > parsing seems to be wrong right now in some way. > > 1. Create a new hg repo with: > > hg init > --config format.use_share_safe=false > --config format.use-persistent-nodemap=false > --config format.sparse-revlog=false > --config format.revlog-compression=zlib > > (This is disabling some recent hg features which make vc-hg-state use > the slow path. You can verify that vc-hg-state-fast is going to run by > checking that .hg/requirements is a subset of > vc-hg-supported-requirements) ITYM .hg/requires, right? When I create a repository in this way, that file contains share-safe, whether or not I pass those --config options. I've hg 6.3.2 here. > 2. touch foo && hg add foo && hg commit -m. > 3. (vc-hg-state-slow ".") > Returns 'up-to-date which is correct (because it shells out to hg) > 4. (vc-hg-state ".") > Returns 'unregistered which is wrong This recipe doesn't work for me. Evaluating both of these forms yields nil. Evaluating them with "foo" instead of "." yields up-to-date in both cases. Is it possible that this problem is only reproducible with newer hg? Could you confirm your recipe still works, and let me know the version of hg, please? Thanks. -- Sean Whitton
Received: (at control) by debbugs.gnu.org; 4 Mar 2025 04:11:45 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 03 23:11:45 2025 Received: from localhost ([127.0.0.1]:54010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tpJdB-000821-3B for submit <at> debbugs.gnu.org; Mon, 03 Mar 2025 23:11:45 -0500 Received: from sendmail.purelymail.com ([34.202.193.197]:33786) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1tpJd9-00081Z-Fk for control <at> debbugs.gnu.org; Mon, 03 Mar 2025 23:11:43 -0500 DKIM-Signature: a=rsa-sha256; b=3zpmJLR+1oGzfDsIa/9sbsXaonDVJiM9G3qRQvMjrskQsc0G5jM3xYuCeEj0MDuwQWTiS+CWpgkY52UmPIyGDOtmzfIMyKAcTJuF+yQlN5OS02bLLn5kE7xYlEOUhk+IBc18Qk23Q+Bf1Hm9TXS5SLQLIc/4h7nqLtwsFGE7wfLD/9hD+ene78Rl5gsCbuVtoEBgOzV7szGh5+Ww9XB39aESteX1uYkGdgTUoA/95+F1Kxi6AA3TF9gBr3KyZwWwYCgCrwJJ/sqGH6OkkxA4zhHD57eleCnb++Cjcd5t7/coIixXNvtyA7AEJvRmmt99m/cYorFKrFyIyeRDtWkuJQ==; s=purelymail2; d=spwhitton.name; v=1; bh=CMKpklHSWQGDNKZpKUEyA7eluz0zdmRJ52Qr3KktKZM=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=cyIYL7Y4P7owtUFW1leXUNjpB6oDzZhOCfXeauTBLRhzErmPpgLAoICWKzgCG+2MMDBRgHDzSGS5HIHCKNkvm+Ucam7WJp+64V4ihxX3/KM0gQJErs1XuzVvC+jouu1M8rYEVrS8hmaZx2HYvQr304Kf4KxoT8Vzv4A3fEzdt2gdXiIVARLRM8MijOIq+jjrYUVbDBx2jiqeoCS5KREcfmdlHWgxYUT5lbJpIqeEMSXPFCY+GNB5Z7Unvyx2Byeq6lmj/ADMgK6jz5XFcfM8b9Z0oO8+v+x9TNt0FcG1gbgbTFDwhxKfdzrqyA5BTQrKCD0VWVEjKs2SJRbRSbXI1Q==; s=purelymail2; d=purelymail.com; v=1; bh=CMKpklHSWQGDNKZpKUEyA7eluz0zdmRJ52Qr3KktKZM=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: control <at> debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1391808961; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 04 Mar 2025 04:11:29 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 0630A7E3866; Tue, 4 Mar 2025 12:11:23 +0800 (CST) From: Sean Whitton <spwhitton@HIDDEN> To: Spencer Baugh <sbaugh@HIDDEN> Subject: Re: bug#62663: 28.2; vc-hg-state returns incorrect results on directories in some repos In-Reply-To: <ier5yabkajk.fsf@HIDDEN> References: <ier5yabkajk.fsf@HIDDEN> Date: Tue, 04 Mar 2025 12:11:23 +0800 Message-ID: <877c555tas.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 62663 <at> debbugs.gnu.org, control <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) tag 62663 - confirmed + moreinfo thanks Hello, On Tue 04 Apr 2023 at 10:05am -04, Spencer Baugh wrote: > The problem is with vc-hg-state-fast, which parses Mercurial data > structures instead of shelling out to hg. This is a great idea but our > parsing seems to be wrong right now in some way. > > 1. Create a new hg repo with: > > hg init > --config format.use_share_safe=false > --config format.use-persistent-nodemap=false > --config format.sparse-revlog=false > --config format.revlog-compression=zlib > > (This is disabling some recent hg features which make vc-hg-state use > the slow path. You can verify that vc-hg-state-fast is going to run by > checking that .hg/requirements is a subset of > vc-hg-supported-requirements) ITYM .hg/requires, right? When I create a repository in this way, that file contains share-safe, whether or not I pass those --config options. I've hg 6.3.2 here. > 2. touch foo && hg add foo && hg commit -m. > 3. (vc-hg-state-slow ".") > Returns 'up-to-date which is correct (because it shells out to hg) > 4. (vc-hg-state ".") > Returns 'unregistered which is wrong This recipe doesn't work for me. Evaluating both of these forms yields nil. Evaluating them with "foo" instead of "." yields up-to-date in both cases. Is it possible that this problem is only reproducible with newer hg? Could you confirm your recipe still works, and let me know the version of hg, please? Thanks. -- Sean Whitton
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.