Juri Linkov <juri@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Debbugs Internal Request <help-debbugs@HIDDEN>
to internal_control <at> debbugs.gnu.org.
Full text available.Juri Linkov <juri@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 15 Nov 2023 17:45:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 15 12:45:29 2023
Received: from localhost ([127.0.0.1]:53682 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r3JxB-0001Zv-Gy
for submit <at> debbugs.gnu.org; Wed, 15 Nov 2023 12:45:29 -0500
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:35263)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>)
id 1r3Jx3-0001Z9-Qm; Wed, 15 Nov 2023 12:45:26 -0500
Received: by mail.gandi.net (Postfix) with ESMTPSA id D537CE0008;
Wed, 15 Nov 2023 17:45:14 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Spencer Baugh <sbaugh@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <86ttpoizeq.fsf@HIDDEN> (Juri Linkov's message of "Tue,
14 Nov 2023 09:39:49 +0200")
Organization: LINKOV.NET
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN> <86wn1jutxv.fsf@HIDDEN>
<83zg6eby5t.fsf@HIDDEN> <83r0qjzj22.fsf@HIDDEN>
<86h6rccz9c.fsf@HIDDEN> <83v8fsw0r9.fsf@HIDDEN>
<86v8fruwur.fsf@HIDDEN> <83352vwb6v.fsf@HIDDEN>
<ier8rcngjtk.fsf@HIDDEN> <86edjfyx84.fsf@HIDDEN>
<86ttpoizeq.fsf@HIDDEN>
Date: Wed, 15 Nov 2023 19:42:26 +0200
Message-ID: <867cmikj5p.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
close 62700 30.0.50
thanks
>> For example, with (setq completion-use-base-affixes t)
>> if there is some text in the current buffer after point,
>> then typing 'M-C-i' and selecting a candidate to insert to the buffer,
>> it replaces all the text after point with an empty string.
>>
>> Before this change, the suffix was set to the text after point,
>> and after inserting the selected candidate the suffix was
>> re-inserted to the same buffer.
>
> Here is a patch that should support 'completion-in-region':
Pushed to master now.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 14 Nov 2023 07:43:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 14 02:43:39 2023
Received: from localhost ([127.0.0.1]:59979 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1r2o5C-0003qj-TJ
for submit <at> debbugs.gnu.org; Tue, 14 Nov 2023 02:43:39 -0500
Received: from relay8-d.mail.gandi.net ([217.70.183.201]:53859)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1r2o55-0003qG-VD
for 62700 <at> debbugs.gnu.org; Tue, 14 Nov 2023 02:43:38 -0500
Received: by mail.gandi.net (Postfix) with ESMTPSA id 19FA91BF208;
Tue, 14 Nov 2023 07:42:41 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Spencer Baugh <sbaugh@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <86edjfyx84.fsf@HIDDEN> (Juri Linkov's message of "Sun,
03 Sep 2023 20:37:15 +0300")
Organization: LINKOV.NET
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN> <86wn1jutxv.fsf@HIDDEN>
<83zg6eby5t.fsf@HIDDEN> <83r0qjzj22.fsf@HIDDEN>
<86h6rccz9c.fsf@HIDDEN> <83v8fsw0r9.fsf@HIDDEN>
<86v8fruwur.fsf@HIDDEN> <83352vwb6v.fsf@HIDDEN>
<ier8rcngjtk.fsf@HIDDEN> <86edjfyx84.fsf@HIDDEN>
Date: Tue, 14 Nov 2023 09:39:49 +0200
Message-ID: <86ttpoizeq.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--=-=-=
Content-Type: text/plain
> For example, with (setq completion-use-base-affixes t)
> if there is some text in the current buffer after point,
> then typing 'M-C-i' and selecting a candidate to insert to the buffer,
> it replaces all the text after point with an empty string.
>
> Before this change, the suffix was set to the text after point,
> and after inserting the selected candidate the suffix was
> re-inserted to the same buffer.
Here is a patch that should support 'completion-in-region':
--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
filename=minibuffer-completion-help-base-suffix.patch
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index 07a284134d6..a2d0fabd9c5 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -2405,9 +2410,14 @@ minibuffer-completion-help
(base-prefix (buffer-substring (minibuffer--completion-prompt-end)
(+ start base-size)))
(base-suffix
- (if (eq (alist-get 'category (cdr md)) 'file)
- (buffer-substring (save-excursion (or (search-forward "/" nil t) (point-max)))
- (point-max))
+ (if (or (eq (alist-get 'category (cdr md)) 'file)
+ completion-in-region-mode-predicate)
+ (buffer-substring
+ (save-excursion
+ (if completion-in-region-mode-predicate
+ (point)
+ (or (search-forward "/" nil t) (point-max))))
+ (point-max))
""))
(all-md (completion--metadata (buffer-substring-no-properties
start (point))
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 4 Sep 2023 06:51:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 04 02:51:57 2023
Received: from localhost ([127.0.0.1]:48114 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qd3RF-0002Wl-Ku
for submit <at> debbugs.gnu.org; Mon, 04 Sep 2023 02:51:57 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:47989)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1qd3R9-0002WL-Po
for 62700 <at> debbugs.gnu.org; Mon, 04 Sep 2023 02:51:56 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 245BEE000A;
Mon, 4 Sep 2023 06:51:41 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: sbaugh@HIDDEN
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <87bkeird9k.fsf@HIDDEN> (sbaugh@HIDDEN's message of "Mon,
04 Sep 2023 00:30:16 +0000 (UTC)")
Organization: LINKOV.NET
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN> <86wn1jutxv.fsf@HIDDEN>
<83zg6eby5t.fsf@HIDDEN> <83r0qjzj22.fsf@HIDDEN>
<86h6rccz9c.fsf@HIDDEN> <83v8fsw0r9.fsf@HIDDEN>
<86v8fruwur.fsf@HIDDEN> <83352vwb6v.fsf@HIDDEN>
<ier8rcngjtk.fsf@HIDDEN> <86edjfyx84.fsf@HIDDEN>
<87bkeird9k.fsf@HIDDEN>
Date: Mon, 04 Sep 2023 09:51:04 +0300
Message-ID: <86r0nexwh3.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>>> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
>>> index 539206a19e4..d079dc0bcdf 100644
>>> --- a/lisp/minibuffer.el
>>> +++ b/lisp/minibuffer.el
>>> @@ -2395,7 +2395,11 @@ minibuffer-completion-help
>>> (prefix (unless (zerop base-size) (substring string 0 base-size)))
>>> (base-prefix (buffer-substring (minibuffer--completion-prompt-end)
>>> (+ start base-size)))
>>> - (base-suffix (buffer-substring (point) (point-max)))
>>> + (base-suffix
>>> + (if (eq (alist-get 'category (cdr md)) 'file)
>>> + (buffer-substring (save-excursion (or (search-forward "/" nil t) (point-max)))
>>> + (point-max))
>>> + ""))
>>
>> As was found in bug#64903, this change broke completion-in-region.
>> For example, with (setq completion-use-base-affixes t)
>> if there is some text in the current buffer after point,
>> then typing 'M-C-i' and selecting a candidate to insert to the buffer,
>> it replaces all the text after point with an empty string.
>>
>> Before this change, the suffix was set to the text after point,
>> and after inserting the selected candidate the suffix was
>> re-inserted to the same buffer.
>
> How can this be the cause of bug#64903? Wasn't that bug reproduced on
> Emacs 28? This change only went in to 29.
bug#64903 is a related but completely separate case.
The patch above went in to master, so in-buffer completion
with non-nil completion-use-base-affixes is broken only
in master, but fortunately not broken in emacs-29.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 4 Sep 2023 00:30:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Sep 03 20:30:26 2023
Received: from localhost ([127.0.0.1]:47820 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qcxU2-0007rY-03
for submit <at> debbugs.gnu.org; Sun, 03 Sep 2023 20:30:26 -0400
Received: from s.wrqvtzvf.outbound-mail.sendgrid.net ([149.72.126.143]:55678)
by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from
<bounces+21787432-9544-62700=debbugs.gnu.org@HIDDEN>)
id 1qcxTy-0007rJ-6N
for 62700 <at> debbugs.gnu.org; Sun, 03 Sep 2023 20:30:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com;
h=from:subject:in-reply-to:references:mime-version:to:cc:content-type:
content-transfer-encoding:cc:content-type:from:subject:to;
s=s1; bh=ntMjadfGIO/NkFhX+wj4gKonvzVmzUMJ/Ftk1h6w0w8=;
b=A8FwKPZr9rIjWcNVvpPa2dvScyHqGnp0Vbl0SR/fQ6fk3TyeWVvmd3speX6ZJjTDcwDL
OEutB5xPqBMU3T0wM1KyagnDL8+uKId2DihHqkmboKMbvFQo19Z3NjZBqD/ii0PxZzp6f6
cCKdLiNivjR8gDuDPCI5TgRz/yI49ilQTlcpfC+Y9pDIvXsW5bkJlTrMV5zF8NMNKB5GTL
7GsQLJ6qQ4hwMPJmZ+zbwMck8erhUsE+JHtSFdzFRDeHjhdt/oa3HIrtb2imotLS/vFzO2
T2IPLPWeFo7BFejiObhH9VWe2+NgrWAp/V9XCRdxJlbX7HkH0FF6tqkcPqaXuknA==
Received: by filterdrecv-65f68489c8-lx4fk with SMTP id
filterdrecv-65f68489c8-lx4fk-1-64F52518-20
2023-09-04 00:30:16.76350645 +0000 UTC m=+10025651.522729132
Received: from earth.catern.com (unknown) by geopod-ismtpd-20 (SG) with ESMTP
id j-2ajEujQd-nLWxijx7ysA Mon, 04 Sep 2023 00:30:16.637 +0000 (UTC)
X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost;
envelope-from=sbaugh@HIDDEN; receiver=linkov.net
Received: from localhost (localhost [IPv6:::1])
by earth.catern.com (Postfix) with ESMTPSA id 1238C635B9;
Sun, 3 Sep 2023 20:30:16 -0400 (EDT)
From: sbaugh@HIDDEN
Subject: Re: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion
behave unintuitively when point is not at end of buffer
In-Reply-To: <86edjfyx84.fsf@HIDDEN> (Juri Linkov's message of "Sun,
03 Sep 2023 20:37:15 +0300")
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN> <86wn1jutxv.fsf@HIDDEN>
<83zg6eby5t.fsf@HIDDEN> <83r0qjzj22.fsf@HIDDEN>
<86h6rccz9c.fsf@HIDDEN> <83v8fsw0r9.fsf@HIDDEN>
<86v8fruwur.fsf@HIDDEN> <83352vwb6v.fsf@HIDDEN>
<ier8rcngjtk.fsf@HIDDEN> <86edjfyx84.fsf@HIDDEN>
Date: Mon, 04 Sep 2023 00:30:16 +0000 (UTC)
Message-ID: <87bkeird9k.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
X-SG-EID: =?us-ascii?Q?ZgbRq7gjGrt0q=2FPjvxk7wM0yQFRdOkTJAtEbkjCkHbKG2FmG87xWwHKu9u96mK?=
=?us-ascii?Q?KKJwt0Y5HfzyF+Z3e559VDGna8QNyZqeU1En0wb?=
=?us-ascii?Q?BWvcG5jHoEwCinGEPzNLcp7VrRIFlUeEfJAc51M?=
=?us-ascii?Q?Me4J27embzEDWhvpmB3MvDMs6TRCJNqqjA1o5Ac?=
=?us-ascii?Q?MtxwvdIanfu5Orsa6z6hUx=2Ff4CN+cZ3ySkQ=3D=3D?=
To: Juri Linkov <juri@HIDDEN>
X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Juri Linkov <juri@HIDDEN> writes: >> Without this change,
only the minibuffer contents before point are >> cleared when a completion
is chosen, which results in stray text when >> point is in the middle of
the minibuffer. >> >> After [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in
bl.spamcop.net
[Blocked - see <https://www.spamcop.net/bl.shtml?149.72.126.143>]
0.0 RCVD_IN_MSPIKE_L3 RBL: Low reputation (-3)
[149.72.126.143 listed in bl.mailspike.net]
0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay
lines 0.0 RCVD_IN_MSPIKE_BL Mailspike blocklisted
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
Juri Linkov <juri@HIDDEN> writes:
>> Without this change, only the minibuffer contents before point are
>> cleared when a completion is chosen, which results in stray text when
>> point is in the middle of the minibuffer.
>>
>> After this change, we heuristically decide either to clear the whole
>> buffer or only part of it, taking into account the location of point.
>>
>> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
>> index 539206a19e4..d079dc0bcdf 100644
>> --- a/lisp/minibuffer.el
>> +++ b/lisp/minibuffer.el
>> @@ -2395,7 +2395,11 @@ minibuffer-completion-help
>> (prefix (unless (zerop base-size) (substring string 0 base-size)))
>> (base-prefix (buffer-substring (minibuffer--completion-prompt-end)
>> (+ start base-size)))
>> - (base-suffix (buffer-substring (point) (point-max)))
>> + (base-suffix
>> + (if (eq (alist-get 'category (cdr md)) 'file)
>> + (buffer-substring (save-excursion (or (search-forward "/" nil t) (point-max)))
>> + (point-max))
>> + ""))
>
> As was found in bug#64903, this change broke completion-in-region.
> For example, with (setq completion-use-base-affixes t)
> if there is some text in the current buffer after point,
> then typing 'M-C-i' and selecting a candidate to insert to the buffer,
> it replaces all the text after point with an empty string.
>
> Before this change, the suffix was set to the text after point,
> and after inserting the selected candidate the suffix was
> re-inserted to the same buffer.
How can this be the cause of bug#64903? Wasn't that bug reproduced on
Emacs 28? This change only went in to 29.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 3 Sep 2023 17:38:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Sep 03 13:38:10 2023
Received: from localhost ([127.0.0.1]:46817 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qcr34-00011g-Dx
for submit <at> debbugs.gnu.org; Sun, 03 Sep 2023 13:38:10 -0400
Received: from relay9-d.mail.gandi.net ([217.70.183.199]:48331)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1qcr32-00011Q-T4
for 62700 <at> debbugs.gnu.org; Sun, 03 Sep 2023 13:38:09 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id D0053FF803;
Sun, 3 Sep 2023 17:38:01 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Spencer Baugh <sbaugh@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <ier8rcngjtk.fsf@HIDDEN> (Spencer Baugh's message of
"Tue, 13 Jun 2023 16:59:19 -0400")
Organization: LINKOV.NET
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN> <86wn1jutxv.fsf@HIDDEN>
<83zg6eby5t.fsf@HIDDEN> <83r0qjzj22.fsf@HIDDEN>
<86h6rccz9c.fsf@HIDDEN> <83v8fsw0r9.fsf@HIDDEN>
<86v8fruwur.fsf@HIDDEN> <83352vwb6v.fsf@HIDDEN>
<ier8rcngjtk.fsf@HIDDEN>
Date: Sun, 03 Sep 2023 20:37:15 +0300
Message-ID: <86edjfyx84.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
> Without this change, only the minibuffer contents before point are
> cleared when a completion is chosen, which results in stray text when
> point is in the middle of the minibuffer.
>
> After this change, we heuristically decide either to clear the whole
> buffer or only part of it, taking into account the location of point.
>
> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
> index 539206a19e4..d079dc0bcdf 100644
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -2395,7 +2395,11 @@ minibuffer-completion-help
> (prefix (unless (zerop base-size) (substring string 0 base-size)))
> (base-prefix (buffer-substring (minibuffer--completion-prompt-end)
> (+ start base-size)))
> - (base-suffix (buffer-substring (point) (point-max)))
> + (base-suffix
> + (if (eq (alist-get 'category (cdr md)) 'file)
> + (buffer-substring (save-excursion (or (search-forward "/" nil t) (point-max)))
> + (point-max))
> + ""))
As was found in bug#64903, this change broke completion-in-region.
For example, with (setq completion-use-base-affixes t)
if there is some text in the current buffer after point,
then typing 'M-C-i' and selecting a candidate to insert to the buffer,
it replaces all the text after point with an empty string.
Before this change, the suffix was set to the text after point,
and after inserting the selected candidate the suffix was
re-inserted to the same buffer.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.Debbugs Internal Request <help-debbugs@HIDDEN>
to internal_control <at> debbugs.gnu.org.
Full text available.Juri Linkov <juri@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Debbugs Internal Request <help-debbugs@HIDDEN>
to internal_control <at> debbugs.gnu.org.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 14 Jun 2023 17:33:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jun 14 13:33:21 2023
Received: from localhost ([127.0.0.1]:45405 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q9UMz-0004yU-G6
for submit <at> debbugs.gnu.org; Wed, 14 Jun 2023 13:33:21 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:41283)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1q9UMy-0004yB-69
for 62700 <at> debbugs.gnu.org; Wed, 14 Jun 2023 13:33:20 -0400
X-GND-Sasl: juri@HIDDEN
X-GND-Sasl: juri@HIDDEN
X-GND-Sasl: juri@HIDDEN
X-GND-Sasl: juri@HIDDEN
Received: by mail.gandi.net (Postfix) with ESMTPSA id D603CE0005;
Wed, 14 Jun 2023 17:33:12 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Spencer Baugh <sbaugh@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <ier8rcngjtk.fsf@HIDDEN> (Spencer Baugh's message of
"Tue, 13 Jun 2023 16:59:19 -0400")
Organization: LINKOV.NET
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN> <86wn1jutxv.fsf@HIDDEN>
<83zg6eby5t.fsf@HIDDEN> <83r0qjzj22.fsf@HIDDEN>
<86h6rccz9c.fsf@HIDDEN> <83v8fsw0r9.fsf@HIDDEN>
<86v8fruwur.fsf@HIDDEN> <83352vwb6v.fsf@HIDDEN>
<ier8rcngjtk.fsf@HIDDEN>
Date: Wed, 14 Jun 2023 20:32:27 +0300
Message-ID: <86a5x2ospg.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>>> I looked at the patch that should be pushed to master, and noticed
>>> that probably it needs the same change that was applied in emacs-29.
>>> Maybe Spencer could confirm what would be the right patch for master.
>>
>> Yes, Spencer, please take a look.
>
> Indeed it needs the same change. Here's the version of the patch that
> should be pushed to master.
Thanks, now pushed to master.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 13 Jun 2023 20:59:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 13 16:59:26 2023
Received: from localhost ([127.0.0.1]:43169 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q9B6s-0005cv-39
for submit <at> debbugs.gnu.org; Tue, 13 Jun 2023 16:59:26 -0400
Received: from mxout5.mail.janestreet.com ([64.215.233.18]:45545)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <sbaugh@HIDDEN>) id 1q9B6q-0005cg-NW
for 62700 <at> debbugs.gnu.org; Tue, 13 Jun 2023 16:59:25 -0400
From: Spencer Baugh <sbaugh@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <83352vwb6v.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 13 Jun
2023 19:59:04 +0300")
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN> <86wn1jutxv.fsf@HIDDEN>
<83zg6eby5t.fsf@HIDDEN> <83r0qjzj22.fsf@HIDDEN>
<86h6rccz9c.fsf@HIDDEN> <83v8fsw0r9.fsf@HIDDEN>
<86v8fruwur.fsf@HIDDEN> <83352vwb6v.fsf@HIDDEN>
Date: Tue, 13 Jun 2023 16:59:19 -0400
Message-ID: <ier8rcngjtk.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
Eli Zaretskii <eliz@HIDDEN> writes:
>> From: Juri Linkov <juri@HIDDEN>
>> Cc: sbaugh@HIDDEN, 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN
>> Date: Tue, 13 Jun 2023 19:54:04 +0300
>>
>> >> I checked that no problems occurred in minibuffer.el on the master branch.
>> >
>> > Thanks. I wasn't sure that my manual resolution of the merge conflict
>> > in this case was correct.
>>
>> I looked at the patch that should be pushed to master, and noticed
>> that probably it needs the same change that was applied in emacs-29.
>> Maybe Spencer could confirm what would be the right patch for master.
>
> Yes, Spencer, please take a look.
Indeed it needs the same change. Here's the version of the patch that
should be pushed to master.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=0001-Handle-point-not-at-EOB-in-minibuffer-choose-complet.patch
From 4769e70e2e9af6eb68947d6c2ed0dcff0831def0 Mon Sep 17 00:00:00 2001
From: Spencer Baugh <sbaugh@HIDDEN>
Date: Mon, 24 Apr 2023 10:05:24 -0400
Subject: [PATCH] Handle point not at EOB in minibuffer-choose-completion
Without this change, only the minibuffer contents before point are
cleared when a completion is chosen, which results in stray text when
point is in the middle of the minibuffer.
After this change, we heuristically decide either to clear the whole
buffer or only part of it, taking into account the location of point.
* lisp/minibuffer.el (minibuffer-completion-help): Use point when
calculating completion-base-affixes. (Bug#62700)
---
lisp/minibuffer.el | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index 539206a19e4..d079dc0bcdf 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -2395,7 +2395,11 @@ minibuffer-completion-help
(prefix (unless (zerop base-size) (substring string 0 base-size)))
(base-prefix (buffer-substring (minibuffer--completion-prompt-end)
(+ start base-size)))
- (base-suffix (buffer-substring (point) (point-max)))
+ (base-suffix
+ (if (eq (alist-get 'category (cdr md)) 'file)
+ (buffer-substring (save-excursion (or (search-forward "/" nil t) (point-max)))
+ (point-max))
+ ""))
(all-md (completion--metadata (buffer-substring-no-properties
start (point))
base-size md
--
2.39.3
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 13 Jun 2023 16:58:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 13 12:58:54 2023
Received: from localhost ([127.0.0.1]:42931 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q97M6-0007P6-Ay
for submit <at> debbugs.gnu.org; Tue, 13 Jun 2023 12:58:54 -0400
Received: from eggs.gnu.org ([209.51.188.92]:39202)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1q97M4-0007Ot-6J
for 62700 <at> debbugs.gnu.org; Tue, 13 Jun 2023 12:58:53 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1q97Ly-0007ym-Dt; Tue, 13 Jun 2023 12:58:46 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=YiNJkL2iIJLvS1ybTIwbgX8UD/Kgr+W7oqKdpHy9Kqw=; b=gx4wOkb1Dq7W
vrL/kNIn+GPYbtCNroT8zirnOIJovD52jn3NFGLuTy4xntnEorW+v63AYJLPaaLgHwpvPgp8yw4EJ
kkuCapYuF2MbrovVwDG3yXOW8sSJZe++HK341Q8BLnNNR1qPHXvEjjhidDunzrUtKAWhp1kYOUfuf
eYlGMi7DnxWDzM9YPlo8ClXiiq6ijrl6xFdNABeMnLNpOZUvnr/jaDTLPrH0IIgJk9tjrYttFcQyZ
T/46vrV02AucFPujMvgEzPMUnuuGVfJe2jeOsyxddHLvAWTHRSVRWg1pBLgQYHYKpNQwleOkzXrHQ
OmnZWtEFoXoavUTXhRt6xw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1q97Lx-0007MV-Tn; Tue, 13 Jun 2023 12:58:46 -0400
Date: Tue, 13 Jun 2023 19:59:04 +0300
Message-Id: <83352vwb6v.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
In-Reply-To: <86v8fruwur.fsf@HIDDEN> (message from Juri Linkov on
Tue, 13 Jun 2023 19:54:04 +0300)
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN> <86wn1jutxv.fsf@HIDDEN>
<83zg6eby5t.fsf@HIDDEN> <83r0qjzj22.fsf@HIDDEN>
<86h6rccz9c.fsf@HIDDEN> <83v8fsw0r9.fsf@HIDDEN>
<86v8fruwur.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Juri Linkov <juri@HIDDEN>
> Cc: sbaugh@HIDDEN, 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN
> Date: Tue, 13 Jun 2023 19:54:04 +0300
>
> >> I checked that no problems occurred in minibuffer.el on the master branch.
> >
> > Thanks. I wasn't sure that my manual resolution of the merge conflict
> > in this case was correct.
>
> I looked at the patch that should be pushed to master, and noticed
> that probably it needs the same change that was applied in emacs-29.
> Maybe Spencer could confirm what would be the right patch for master.
Yes, Spencer, please take a look.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 13 Jun 2023 16:56:39 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 13 12:56:39 2023
Received: from localhost ([127.0.0.1]:42926 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q97Ju-0007Ln-SH
for submit <at> debbugs.gnu.org; Tue, 13 Jun 2023 12:56:39 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:39689)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1q97Jt-0007La-Tv
for 62700 <at> debbugs.gnu.org; Tue, 13 Jun 2023 12:56:38 -0400
X-GND-Sasl: juri@HIDDEN
X-GND-Sasl: juri@HIDDEN
X-GND-Sasl: juri@HIDDEN
X-GND-Sasl: juri@HIDDEN
Received: by mail.gandi.net (Postfix) with ESMTPSA id 5C916E000D;
Tue, 13 Jun 2023 16:56:29 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <83v8fsw0r9.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 13 Jun
2023 05:32:10 +0300")
Organization: LINKOV.NET
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN> <86wn1jutxv.fsf@HIDDEN>
<83zg6eby5t.fsf@HIDDEN> <83r0qjzj22.fsf@HIDDEN>
<86h6rccz9c.fsf@HIDDEN> <83v8fsw0r9.fsf@HIDDEN>
Date: Tue, 13 Jun 2023 19:54:04 +0300
Message-ID: <86v8fruwur.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>> > but today I merged from emacs-29 to master and got conflicts in
>> > minibuffer.el. The conflicts were strange: they seemed to be caused
>> > by gitmerge.el attempting to merge backported changes? That should
>> > not happen.
>>
>> The merge conflict occurred because the first commit e338a8ac41d
>> was pushed to emacs-29 with the keyword "backport", but 2a84ab905c8
>> without any keyword that would prevent an attempt of its merge to master.
>>
>> > Would you please look at minibuffer.el on the master branch and see if
>> > anything there needs fixing?
>>
>> I checked that no problems occurred in minibuffer.el on the master branch.
>
> Thanks. I wasn't sure that my manual resolution of the merge conflict
> in this case was correct.
I looked at the patch that should be pushed to master, and noticed
that probably it needs the same change that was applied in emacs-29.
Maybe Spencer could confirm what would be the right patch for master.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 13 Jun 2023 02:32:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 12 22:32:03 2023
Received: from localhost ([127.0.0.1]:41033 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q8tpD-0000pB-39
for submit <at> debbugs.gnu.org; Mon, 12 Jun 2023 22:32:03 -0400
Received: from eggs.gnu.org ([209.51.188.92]:41562)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1q8tpB-0000oh-6Y
for 62700 <at> debbugs.gnu.org; Mon, 12 Jun 2023 22:32:01 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1q8tp4-0000xp-0L; Mon, 12 Jun 2023 22:31:54 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=I/25OXrf5UPmCe/OFNigWNErU44/scH7mWFLlpNgT2c=; b=jhvq+I1IMSDe
diIHdxZfWDhOZ4dFDFHMyOI/ktLwNVYgUWp/1ne/Fxp4cIEkqZ665cXZzMd7IlKucLmOdlJD3+wkk
+F6Y+ySZxDYuP46MbI1V90jw+GV5IHyO3V6E8qZRMxbu3phfw8N0UzPciFq4Q6Z0owFr2Oaw8QKDt
umEtVTCeDNVp2KrKBX6lyoJiLJizKeznejOnwyoMgnaO1kXiwQWm/smB/04R2ykD6XPNGvGEaxMNB
o0aaTJ7ZXwE9JxzW9IJzKkgQa/J5l5Qj5jsOTI5KSjUsxF7v2/7ay/Xb7lhGK3eBt1lDPq0w+ckwp
XrJmlFlmvcopyGEvsC2Beg==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1q8tp3-00055o-0a; Mon, 12 Jun 2023 22:31:53 -0400
Date: Tue, 13 Jun 2023 05:32:10 +0300
Message-Id: <83v8fsw0r9.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
In-Reply-To: <86h6rccz9c.fsf@HIDDEN> (message from Juri Linkov on
Mon, 12 Jun 2023 21:27:11 +0300)
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN> <86wn1jutxv.fsf@HIDDEN>
<83zg6eby5t.fsf@HIDDEN> <83r0qjzj22.fsf@HIDDEN>
<86h6rccz9c.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Juri Linkov <juri@HIDDEN>
> Cc: sbaugh@HIDDEN, 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN
> Date: Mon, 12 Jun 2023 21:27:11 +0300
>
> > but today I merged from emacs-29 to master and got conflicts in
> > minibuffer.el. The conflicts were strange: they seemed to be caused
> > by gitmerge.el attempting to merge backported changes? That should
> > not happen.
>
> The merge conflict occurred because the first commit e338a8ac41d
> was pushed to emacs-29 with the keyword "backport", but 2a84ab905c8
> without any keyword that would prevent an attempt of its merge to master.
>
> > Would you please look at minibuffer.el on the master branch and see if
> > anything there needs fixing?
>
> I checked that no problems occurred in minibuffer.el on the master branch.
Thanks. I wasn't sure that my manual resolution of the merge conflict
in this case was correct.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 12 Jun 2023 18:29:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jun 12 14:29:35 2023
Received: from localhost ([127.0.0.1]:40501 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q8mII-0003CH-OM
for submit <at> debbugs.gnu.org; Mon, 12 Jun 2023 14:29:35 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:33335)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1q8mIG-0003C1-EL
for 62700 <at> debbugs.gnu.org; Mon, 12 Jun 2023 14:29:32 -0400
X-GND-Sasl: juri@HIDDEN
X-GND-Sasl: juri@HIDDEN
X-GND-Sasl: juri@HIDDEN
X-GND-Sasl: juri@HIDDEN
Received: by mail.gandi.net (Postfix) with ESMTPSA id 21E3CE0005;
Mon, 12 Jun 2023 18:29:24 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <83r0qjzj22.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 10 Jun
2023 13:51:49 +0300")
Organization: LINKOV.NET
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN> <86wn1jutxv.fsf@HIDDEN>
<83zg6eby5t.fsf@HIDDEN> <83r0qjzj22.fsf@HIDDEN>
Date: Mon, 12 Jun 2023 21:27:11 +0300
Message-ID: <86h6rccz9c.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>> > > Thanks, installed on the emacs-29 branch, and closing the bug.
>> >
>> > Should the original patch be installed to master now?
>>
>> It's up to you.
>
> I don't know what you did after this message,
I didn't install on master anything because I refrain from developing
new features on master until emacs-29 is released to avoid merge conflicts.
> but today I merged from emacs-29 to master and got conflicts in
> minibuffer.el. The conflicts were strange: they seemed to be caused
> by gitmerge.el attempting to merge backported changes? That should
> not happen.
The merge conflict occurred because the first commit e338a8ac41d
was pushed to emacs-29 with the keyword "backport", but 2a84ab905c8
without any keyword that would prevent an attempt of its merge to master.
> Would you please look at minibuffer.el on the master branch and see if
> anything there needs fixing?
I checked that no problems occurred in minibuffer.el on the master branch.
So probably I will continue installing postponed patches to master
since merge conflicts are really not a problem.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 10 Jun 2023 10:51:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jun 10 06:51:48 2023
Received: from localhost ([127.0.0.1]:33343 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q7wCB-0005iq-R3
for submit <at> debbugs.gnu.org; Sat, 10 Jun 2023 06:51:48 -0400
Received: from eggs.gnu.org ([209.51.188.92]:48530)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1q7wC9-0005iZ-C4
for 62700 <at> debbugs.gnu.org; Sat, 10 Jun 2023 06:51:46 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1q7wC3-0002Lh-Fo; Sat, 10 Jun 2023 06:51:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=WWNtV6Ojq8qSnI98ZC/QUCKthO/flWaxs4TQlVBNBcc=; b=XQIZPHEWSCrp
XLd3V9cBCP/VJMm1D0mDBURKU9T7y6RF2UJAvoWzajSFZbX4GGqbqVau721jqh1be+MF8s7Sd5vRX
Thw/qg0cV1/8bJcbFM2q4KwKu8hFE1D1ntRQoDTvZtU1LkJn0V3XRw+si2wIEXrI5EGck4GZV4C3r
QvFpiNYb5aJqLDZ9HsGWwpj/2ETH9zayjOLKXhQx0X2baR3IgLm0RmG/JJVjnwiVhqYAwaA0mRl3A
izAmAEgaHtcFcgtCBvSa/n5XPzERJT37wjbjjujwBweQ39Thglh7JsKRScLDD5XQbNQWZbMz2soJB
ChcdQpLP5rNZyE47Yp8Z7Q==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1q7wC2-0003bC-WF; Sat, 10 Jun 2023 06:51:39 -0400
Date: Sat, 10 Jun 2023 13:51:49 +0300
Message-Id: <83r0qjzj22.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: sbaugh@HIDDEN
In-Reply-To: <83zg6eby5t.fsf@HIDDEN> (message from Eli Zaretskii on Mon, 08
May 2023 19:11:58 +0300)
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN> <86wn1jutxv.fsf@HIDDEN>
<83zg6eby5t.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Date: Mon, 08 May 2023 19:11:58 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
> Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, sbaugh@HIDDEN
>
> > From: Juri Linkov <juri@HIDDEN>
> > Cc: sbaugh@HIDDEN, 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN
> > Date: Mon, 08 May 2023 18:48:12 +0300
> >
> > > Thanks, installed on the emacs-29 branch, and closing the bug.
> >
> > Should the original patch be installed to master now?
>
> It's up to you.
I don't know what you did after this message, but today I merged from
emacs-29 to master and got conflicts in minibuffer.el. The conflicts
were strange: they seemed to be caused by gitmerge.el attempting to
merge backported changes? That should not happen.
Would you please look at minibuffer.el on the master branch and see if
anything there needs fixing?
Thanks.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 4 Jun 2023 07:08:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jun 04 03:08:32 2023
Received: from localhost ([127.0.0.1]:44792 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q5hqq-0005il-C3
for submit <at> debbugs.gnu.org; Sun, 04 Jun 2023 03:08:32 -0400
Received: from eggs.gnu.org ([209.51.188.92]:34268)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1q5hqn-0005iX-NX
for 62700 <at> debbugs.gnu.org; Sun, 04 Jun 2023 03:08:30 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1q5hqh-00023w-Op; Sun, 04 Jun 2023 03:08:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=vIqunT7d1+Uq73tI86AB7/n9OdwPqbCJowx12J4yHMY=; b=Wvw+Wu2S8ZYz
+mTH2KvHuGQwee8BhGv1JUoZz0S6+U30/8dg1CsGVNGlOHgckxz9wEQdbQPDAMwmffe9zszb2GhCn
2MVsKdwZU4s35V25eMbjd0hT/798d2oMh6hqjjsf8UD5FC35FVGaxhZEwSMCqXDFv0ARa3cGyOZGg
y+3iT0zlKvamEoTll/3J/rloQoU9lOf7I9kOUMt5eDRzMSy75ynCei4A9t1wxYhqVGVKbu36FDUic
Tb1WOymamBbCrc7dhZqL/IGdxOraSJOzcSe/K0QH5/qm5YGxuU6GvxNbJSmVZoYAcqMHDPKALxmx4
2XY7QSHPpW0IByxOLRL4xw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1q5hqh-0004UW-8P; Sun, 04 Jun 2023 03:08:23 -0400
Date: Sun, 04 Jun 2023 10:09:16 +0300
Message-Id: <837csj7lgj.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Spencer Baugh <sbaugh@HIDDEN>
In-Reply-To: <ieredmtz7hv.fsf@HIDDEN> (message from Spencer Baugh on
Fri, 02 Jun 2023 20:58:52 -0400)
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN> <86wn1jutxv.fsf@HIDDEN>
<83zg6eby5t.fsf@HIDDEN> <ieredmtz7hv.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Spencer Baugh <sbaugh@HIDDEN>
> Cc: Juri Linkov <juri@HIDDEN>, 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN
> Date: Fri, 02 Jun 2023 20:58:52 -0400
>
> It turns out my patch doesn't fully fix the issue, when doing completion
> at the end of a file path. For example:
>
> 1. C-x C-f ~/src/emacs/emacs-29/lisp/.el
> 2. TAB to trigger completion, moving point to before .el
> 3. M-<down>
> 4. The filenames are inserted before the .el, so one gets for example
> ~/src/emacs/emacs-29/lisp/abbrev.el.el
>
> The attached patch for the Emacs 29 branch fixes this remaining case.
Thanks, installed.
Please in the future try to avoid using "path" for anything other than
PATH-style directory lists: the GNU Coding Standards frown on such
usage. (I fixed a couple of such uses in the commit log message
before pushing.)
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 3 Jun 2023 00:59:01 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 02 20:59:01 2023
Received: from localhost ([127.0.0.1]:41054 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1q5Fbg-0005Xd-Rx
for submit <at> debbugs.gnu.org; Fri, 02 Jun 2023 20:59:01 -0400
Received: from mxout5.mail.janestreet.com ([64.215.233.18]:50191)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <sbaugh@HIDDEN>) id 1q5Fbe-0005XO-5d
for 62700 <at> debbugs.gnu.org; Fri, 02 Jun 2023 20:58:59 -0400
From: Spencer Baugh <sbaugh@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <83zg6eby5t.fsf@HIDDEN> (Eli Zaretskii's message of "Mon, 08 May
2023 19:11:58 +0300")
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN> <86wn1jutxv.fsf@HIDDEN>
<83zg6eby5t.fsf@HIDDEN>
Date: Fri, 02 Jun 2023 20:58:52 -0400
Message-ID: <ieredmtz7hv.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain
It turns out my patch doesn't fully fix the issue, when doing completion
at the end of a file path. For example:
1. C-x C-f ~/src/emacs/emacs-29/lisp/.el
2. TAB to trigger completion, moving point to before .el
3. M-<down>
4. The filenames are inserted before the .el, so one gets for example
~/src/emacs/emacs-29/lisp/abbrev.el.el
The attached patch for the Emacs 29 branch fixes this remaining case.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=0001-Handle-point-in-last-file-path-component-in-minibuff.patch
From 33f9cfa6afb7ae232ed6d5bbc4692a463f57a7a8 Mon Sep 17 00:00:00 2001
From: Spencer Baugh <sbaugh@HIDDEN>
Date: Fri, 2 Jun 2023 20:57:32 -0400
Subject: [PATCH] Handle point in last file path component in minibuffer
completion
This is a followup to commit e338a8ac41d4a9fd798dda90275abe75ac071335
(Handle point not at EOB in minibuffer-choose-completion).
That added a heuristic, but the heuristic was insufficient: It still
had the original wrong behavior when completing the last file path
component (i.e., the completion category is 'file and there's no /
after point). This patch makes the heuristic cover that case too.
* lisp/minibuffer.el (minibuffer-next-completion)
(minibuffer-choose-completion): If in file completion and there's no /
after point, clear what's after point when we complete. (Bug#62700)
---
lisp/minibuffer.el | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index 298f3f8728d..a873e5f9747 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -4498,8 +4498,9 @@ minibuffer-next-completion
(base-suffix
(if (eq (alist-get 'category (cdr md)) 'file)
(with-current-buffer buf
- (buffer-substring (save-excursion (search-forward "/" nil t) (point))
- (point-max)))
+ (buffer-substring
+ (save-excursion (or (search-forward "/" nil t) (point-max)))
+ (point-max)))
""))
(completion-base-affixes (list (car completion-base-affixes) base-suffix)))
(choose-completion nil t t))))))
@@ -4524,8 +4525,9 @@ minibuffer-choose-completion
(let* ((md (completion--field-metadata (minibuffer--completion-prompt-end)))
(base-suffix
(if (eq (alist-get 'category (cdr md)) 'file)
- (buffer-substring (save-excursion (search-forward "/" nil t) (point))
- (point-max))
+ (buffer-substring
+ (save-excursion (or (search-forward "/" nil t) (point-max)))
+ (point-max))
"")))
(with-minibuffer-completions-window
(let ((completion-use-base-affixes t)
--
2.39.3
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 8 May 2023 16:11:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 08 12:11:06 2023
Received: from localhost ([127.0.0.1]:41403 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pw3S6-0004Xx-0N
for submit <at> debbugs.gnu.org; Mon, 08 May 2023 12:11:06 -0400
Received: from eggs.gnu.org ([209.51.188.92]:39704)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1pw3S4-0004XU-Ee
for 62700 <at> debbugs.gnu.org; Mon, 08 May 2023 12:11:04 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pw3Ry-0007ZA-76; Mon, 08 May 2023 12:10:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=KCV+NephUTqsmeddfBf9c+8YstgBWFfLxuCXyorr6Jk=; b=mursj1GuHk3z
1gfIX0KNxMvZx/kp6DoPvOkDkw0khxI5snsQUsuZEDdNJ53/fUIV+sv32mH554OYHWB0FM/tHhLQB
nXrKgjuaSSrJZ9YPzVvisu0DnKhPc3/7MmsGn4Ld9ZK5ayMZoPa4gsFDdCwqYmTFEP4Ksv8bhPX5a
ROt1c7vB4QtSHZV6EZkLiV34NuikmVQr0S1KnuPkaoQuAfe1uj1Gb+b+b4S6mOp698BArUvWbVA1R
oYGuOppqqXuylEBYcNtHurYa9wbot9I0XB6Rj/ikEsLKhNHTVJaVe0fHUU3rTVRnT2u5FY+fVqgiW
PsLUxegT1PTJAC6p1hod0Q==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pw3Rx-0006Mq-Mj; Mon, 08 May 2023 12:10:58 -0400
Date: Mon, 08 May 2023 19:11:58 +0300
Message-Id: <83zg6eby5t.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
In-Reply-To: <86wn1jutxv.fsf@HIDDEN> (message from Juri Linkov on
Mon, 08 May 2023 18:48:12 +0300)
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN> <86wn1jutxv.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Juri Linkov <juri@HIDDEN>
> Cc: sbaugh@HIDDEN, 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN
> Date: Mon, 08 May 2023 18:48:12 +0300
>
> > Thanks, installed on the emacs-29 branch, and closing the bug.
>
> Should the original patch be installed to master now?
It's up to you.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 8 May 2023 15:57:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 08 11:57:00 2023
Received: from localhost ([127.0.0.1]:41382 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pw3ES-0004A9-Ba
for submit <at> debbugs.gnu.org; Mon, 08 May 2023 11:57:00 -0400
Received: from relay5-d.mail.gandi.net ([217.70.183.197]:35309)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1pw3EQ-00049g-QG
for 62700 <at> debbugs.gnu.org; Mon, 08 May 2023 11:56:59 -0400
Received: (Authenticated sender: juri@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id 84B0F1C0006;
Mon, 8 May 2023 15:56:51 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <83lei6mxa0.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 02 May
2023 20:57:27 +0300")
Organization: LINKOV.NET
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
<83lei6mxa0.fsf@HIDDEN>
Date: Mon, 08 May 2023 18:48:12 +0300
Message-ID: <86wn1jutxv.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
> Thanks, installed on the emacs-29 branch, and closing the bug.
Should the original patch be installed to master now?
That is the simpler fix mentioned in the commit
e338a8ac41d4a9fd798dda90275abe75ac071335:
This is a backport for the Emacs 29 release branch of a simpler
fix in minibuffer-completion-help.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700-done) by debbugs.gnu.org; 2 May 2023 17:56:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 02 13:56:52 2023
Received: from localhost ([127.0.0.1]:44994 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ptuF9-0003zb-LW
for submit <at> debbugs.gnu.org; Tue, 02 May 2023 13:56:51 -0400
Received: from eggs.gnu.org ([209.51.188.92]:35022)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1ptuF7-0003zJ-Cq
for 62700-done <at> debbugs.gnu.org; Tue, 02 May 2023 13:56:49 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1ptuF0-0003ms-Ay; Tue, 02 May 2023 13:56:42 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=f04Jj35140i/RXkfKBxcLDXJXwR65FITEKXv1PXVRJw=; b=pnqcX8Zg+LPM
nkIX5/GMDvcoVRUlpT3HcPdRSGLTz1ekJxGzbCzNcr0M9jVHawAxJtEguViEsgouuOR2y7XMZb5Ug
uTvajmEVNFgFxMGLJoTpft/1OJQtnrvKx7sEnGAcfdBSCPumPAItBDSgqqct0y9ACmYEsb2ksH4/0
UKSvOEkMOsYylG2Sb3AAzfTcg1p9qEuL6LDo8aij6Zrm00z0rwyg06tgOBc3Kq15wAwnkQoqhxenI
5rpbopwvuZQg6AKtfcKmsCWcPbJ9iZ6fESGlhWrcgZanaOjZKgECJUSOv3bD6daGkKfWZAgbd3KCU
NcSvUjnxFwmDrO5Z1ZwMbQ==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1ptuEz-0003CX-KJ; Tue, 02 May 2023 13:56:41 -0400
Date: Tue, 02 May 2023 20:57:27 +0300
Message-Id: <83lei6mxa0.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: sbaugh@HIDDEN
In-Reply-To: <874jourckv.fsf@HIDDEN> (sbaugh@HIDDEN)
Subject: Re: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion
behave unintuitively when point is not at end of buffer
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <874jourckv.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700-done
Cc: 62700-done <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: sbaugh@HIDDEN
> Date: Tue, 02 May 2023 15:13:21 +0000 (UTC)
> Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
>
> OK, here's the patch with this change.
>
> (As discussed elsewhere in the thread, the patch includes changes to
> minibuffer-choose-completion because that function also is affected by
> the bug and also needs to be fixed)
Thanks, installed on the emacs-29 branch, and closing the bug.
Please in the future try to remember to mention the bug number in the
commit log messages, once the number is known. You forgot that in the
two changesets I just installed, so I needed to amend that manually.
Spencer Baugh <sbaugh@HIDDEN>:Eli Zaretskii <eliz@HIDDEN>:
Received: (at 62700) by debbugs.gnu.org; 2 May 2023 15:13:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 02 11:13:29 2023
Received: from localhost ([127.0.0.1]:44827 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ptrh2-0007L8-Ip
for submit <at> debbugs.gnu.org; Tue, 02 May 2023 11:13:29 -0400
Received: from s.wrqvwxzv.outbound-mail.sendgrid.net ([149.72.154.232]:38680)
by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from
<bounces+21787432-9544-62700=debbugs.gnu.org@HIDDEN>)
id 1ptrh0-0007Km-GF
for 62700 <at> debbugs.gnu.org; Tue, 02 May 2023 11:13:27 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com;
h=from:subject:in-reply-to:references:mime-version:to:cc:content-type:
cc:content-type:from:subject:to;
s=s1; bh=ZnNbtigu3k0Z/y0LGNq/fRyZR7sjjaFtj6GvUbkATik=;
b=lDOl21K4LjX9zt03jESV1FY6/FxKc7CXPpqmAc2SRlCTE4/Cko8cU2Fn5w9Oe3iN4/W/
mnsOBDQJ6DgexxUCBwU17jyUQ+7mQ9bvyJu1iM4GkHVD2yfN3Wm9rIMuZi/k6Ws6gQQ3F4
JdyQeKhRokWwRFbfD1DgdIHo5pW556O11O8T1xEPW6LrQwmfClQ1jleGX6nb2bfIlOXHCK
pDekTWkaDXB//JjY3jd8Yfv6PM993X8xeM4efRtfzk3pfIBveyIhBDBx63mqSs63mJUUFF
sI200Qmx8+ltiMCpnfX7iwR15jQcxGsT8Q1p9PG/TIi2Ubx8y9pDzNVSYD3PCSkA==
Received: by filterdrecv-59cb65cf6d-4lbfg with SMTP id
filterdrecv-59cb65cf6d-4lbfg-1-64512890-63
2023-05-02 15:13:20.991122311 +0000 UTC m=+4742398.070011593
Received: from earth.catern.com (unknown) by geopod-ismtpd-15 (SG) with ESMTP
id k1-ysBLKTeicTlcO7xc5CQ Tue, 02 May 2023 15:13:20.757 +0000 (UTC)
X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost;
envelope-from=sbaugh@HIDDEN; receiver=<UNKNOWN>
Received: from localhost (localhost [IPv6:::1])
by earth.catern.com (Postfix) with ESMTPSA id 2938260039;
Tue, 2 May 2023 11:13:20 -0400 (EDT)
From: sbaugh@HIDDEN
Subject: Re: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion
behave unintuitively when point is not at end of buffer
In-Reply-To: <83jzy419bk.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 22 Apr
2023 13:48:47 +0300")
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN>
Date: Tue, 02 May 2023 15:13:21 +0000 (UTC)
Message-ID: <874jourckv.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
X-SG-EID: =?us-ascii?Q?ZgbRq7gjGrt0q=2FPjvxk7wM0yQFRdOkTJAtEbkjCkHbKAsM+HLA4rmDqq=2FBwHmI?=
=?us-ascii?Q?PTg7x3e50VdOnU+cBNMinar0SLmr9l5xKXG=2FAgA?=
=?us-ascii?Q?1pIPabxEU02SqEtPVLtZ=2FgqCLX4o=2Fkrjoy1zgDT?=
=?us-ascii?Q?JhrOv46sbL4+oOygnF60s6JHyMkPymUlhdMnyU7?=
=?us-ascii?Q?zeWUmvwBHAPsMImjvCIZkXWZIx9eTPBE7mQ=3D=3D?=
To: Eli Zaretskii <eliz@HIDDEN>
X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q==
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> From:
sbaugh@HIDDEN >> Date: Fri,
21 Apr 2023 18:56:35 +0000 (UTC) >> Cc: Spencer Baugh <sbaugh@HIDDEN>,
62700 <at> debbugs.gnu.org, >> juri@HIDDEN >> >> >> Ah, I thought Eli still
wante [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in
bl.spamcop.net
[Blocked - see <https://www.spamcop.net/bl.shtml?149.72.154.232>]
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[149.72.154.232 listed in wl.mailspike.net]
0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay
lines
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
--=-=-=
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Eli Zaretskii <eliz@HIDDEN> writes:
>> From: sbaugh@HIDDEN
>> Date: Fri, 21 Apr 2023 18:56:35 +0000 (UTC)
>> Cc: Spencer Baugh <sbaugh@HIDDEN>, 62700 <at> debbugs.gnu.org,
>> juri@HIDDEN
>>
>> >> Ah, I thought Eli still wanted a backport version because this changes
>> >> code which has been on Emacs 29 for over a year.
>> >
>> > Indeed, that's what I would like to see on the release branch. Mainly
>> > because even if this is deemed a bug, it happens in a relatively rare
>> > situation, so I'd like to avoid risking breakage in code which affects
>> > other situations.
>>
>> Here's the backport for the release branch.
>
> Thanks, but I'd like to make this still safer for the release branch:
>
>> --- a/lisp/minibuffer.el
>> +++ b/lisp/minibuffer.el
>> @@ -4464,13 +4464,21 @@ minibuffer-next-completion
>> When `minibuffer-completion-auto-choose' is non-nil, then also
>> insert the selected completion to the minibuffer."
>> (interactive "p")
>> - (let ((auto-choose minibuffer-completion-auto-choose))
>> + (let* ((auto-choose minibuffer-completion-auto-choose)
>> + ;; Backported fix for bug#62700
>> + (md (completion--field-metadata (minibuffer--completion-prompt-end)))
>> + (base-suffix
>> + (if (eq (alist-get 'category (cdr md)) 'file)
>> + (buffer-substring (save-excursion (search-forward "/" nil t) (point))
>> + (point-max))
>> + "")))
>> (with-minibuffer-completions-window
>> (when completions-highlight-face
>> (setq-local cursor-face-highlight-nonselected-window t))
>> (next-completion (or n 1))
>> (when auto-choose
>> - (let ((completion-use-base-affixes t))
>> + (let ((completion-use-base-affixes t)
>> + (completion-base-affixes (list (car completion-base-affixes) base-suffix)))
>> (choose-completion nil t t))))))
>
> Here, the values used only when minibuffer-completion-auto-choose is
> non-nil should be computed only when that variable is non-nil,
> preferably inside the '(when auto-choose' clause.
OK, here's the patch with this change.
(As discussed elsewhere in the thread, the patch includes changes to
minibuffer-choose-completion because that function also is affected by
the bug and also needs to be fixed)
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=0001-Handle-point-not-at-EOB-in-minibuffer-choose-complet.patch
From d446bec7d59944e25f478a63bd6c980ca7ce48d6 Mon Sep 17 00:00:00 2001
From: Spencer Baugh <sbaugh@HIDDEN>
Date: Fri, 21 Apr 2023 14:55:00 -0400
Subject: [PATCH] Handle point not at EOB in minibuffer-choose-completion
Without this change, only the minibuffer contents before point are
cleared when a completion is chosen, which results in stray text when
point is in the middle of the minibuffer.
After this change, we heuristically decide either to clear the whole
buffer or only part of it, taking into account the location of point.
This is a backport for the Emacs 29 release branch of a simpler fix in
minibuffer-completion-help.
* lisp/minibuffer.el (minibuffer-next-completion):
(minibuffer-choose-completion):
Recalculate completion-base-affixes with point
---
lisp/minibuffer.el | 30 +++++++++++++++++++++++++-----
1 file changed, 25 insertions(+), 5 deletions(-)
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index 21d4607e7cf..f457ecfcf7d 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -4460,13 +4460,25 @@ minibuffer-next-completion
When `minibuffer-completion-auto-choose' is non-nil, then also
insert the selected completion to the minibuffer."
(interactive "p")
- (let ((auto-choose minibuffer-completion-auto-choose))
+ (let ((auto-choose minibuffer-completion-auto-choose)
+ (buf (current-buffer)))
(with-minibuffer-completions-window
(when completions-highlight-face
(setq-local cursor-face-highlight-nonselected-window t))
(next-completion (or n 1))
(when auto-choose
- (let ((completion-use-base-affixes t))
+ (let* ((completion-use-base-affixes t)
+ ;; Backported fix for bug#62700
+ (md
+ (with-current-buffer buf
+ (completion--field-metadata (minibuffer--completion-prompt-end))))
+ (base-suffix
+ (if (eq (alist-get 'category (cdr md)) 'file)
+ (with-current-buffer buf
+ (buffer-substring (save-excursion (search-forward "/" nil t) (point))
+ (point-max)))
+ ""))
+ (completion-base-affixes (list (car completion-base-affixes) base-suffix)))
(choose-completion nil t t))))))
(defun minibuffer-previous-completion (&optional n)
@@ -4485,9 +4497,17 @@ minibuffer-choose-completion
If NO-QUIT is non-nil, insert the completion at point to the
minibuffer, but don't quit the completions window."
(interactive "P")
- (with-minibuffer-completions-window
- (let ((completion-use-base-affixes t))
- (choose-completion nil no-exit no-quit))))
+ ;; Backported fix for bug#62700
+ (let* ((md (completion--field-metadata (minibuffer--completion-prompt-end)))
+ (base-suffix
+ (if (eq (alist-get 'category (cdr md)) 'file)
+ (buffer-substring (save-excursion (search-forward "/" nil t) (point))
+ (point-max))
+ "")))
+ (with-minibuffer-completions-window
+ (let ((completion-use-base-affixes t)
+ (completion-base-affixes (list (car completion-base-affixes) base-suffix)))
+ (choose-completion nil no-exit no-quit)))))
(defun minibuffer-complete-history ()
"Complete the minibuffer history as far as possible.
--
2.38.0
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 24 Apr 2023 11:22:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 24 07:22:42 2023
Received: from localhost ([127.0.0.1]:47692 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pquHK-0005zA-E2
for submit <at> debbugs.gnu.org; Mon, 24 Apr 2023 07:22:42 -0400
Received: from eggs.gnu.org ([209.51.188.92]:46298)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1pquHJ-0005yy-Fx
for 62700 <at> debbugs.gnu.org; Mon, 24 Apr 2023 07:22:41 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pquHB-0005B5-BU; Mon, 24 Apr 2023 07:22:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=1r4ZPqSC5vQPvLP3ckhEbGOloHkJUtz/On9JMxPTWwQ=; b=Vj21z36St17S
CcfiLInpNlh6CuaMsU8PToN2/hHTrcRHml2FntnF21GE5qgYWByUxBgn6RAxmVwC+Xk8HVJMLanUt
VpcTafP7X+BzePdTjqnEsC5/1FidMctFZmB1olwubRruhxoT6tKCMv7ucqqpBA1WcRAQjc4epE+pI
bGLAtJuxp0YH32YnriFq24q8bL12CqjM6MVVFk4RD8ist5BkreAJh+5PrWfoQlddVynD964YqmLsy
rNlja2rVXeJZaftA7qZnT2mlEhIMT1lhjYUOXxZ+MDjRZam8PTEOwzzAIblmWcmGLdzwu0NeqBYHG
3AJs6inrM2Ux0jtGDzUk7w==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pquHA-0006b9-Ho; Mon, 24 Apr 2023 07:22:33 -0400
Date: Mon, 24 Apr 2023 14:22:56 +0300
Message-Id: <83jzy1y167.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: sbaugh@HIDDEN
In-Reply-To: <87a5yylsym.fsf@HIDDEN> (sbaugh@HIDDEN)
Subject: Re: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion
behave unintuitively when point is not at end of buffer
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <87ildokraj.fsf@HIDDEN>
<837cu412jt.fsf@HIDDEN> <87cz3vlhqs.fsf@HIDDEN>
<83ttx7yvlt.fsf@HIDDEN> <87a5yylsym.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: sbaugh@HIDDEN
> Date: Sun, 23 Apr 2023 11:48:50 +0000 (UTC)
> Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
>
> Eli Zaretskii <eliz@HIDDEN> writes:
> >> From: sbaugh@HIDDEN
> >> Date: Sat, 22 Apr 2023 21:38:52 +0000 (UTC)
> >> Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
> >>
> >> Eli Zaretskii <eliz@HIDDEN> writes:
> >> > I asked for the changes to affect only code specific to M-<UP> and
> >> > M-<DOWN>, but the patch you posted doesn't limit itself to that,
> >> > AFAICT. Or what am I missing?
> >>
> >> Ah, I didn't realize that was what you were asking for. I can do that,
> >> certainly, but why not also cover M-RET? The bug exists in the exact
> >> same form for M-RET and it will be confusing (though better than
> >> nothing, definitely) if the fix applies to M-<UP> and M-<DOWN> but not
> >> M-RET.
> >
> > If the issue exists for M-RET, then fixing that case as well is okay.
> > The request was not to affect any code that handles also other
> > situation and other keys.
>
> M-RET is bound to minibuffer-choose-completion, so then why the
> objection to a patch which affects minibuffer-choose-completion?
Because we never talked about M-RET until now?
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 23 Apr 2023 11:48:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 23 07:48:58 2023
Received: from localhost ([127.0.0.1]:44688 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pqYDC-0005DK-6w
for submit <at> debbugs.gnu.org; Sun, 23 Apr 2023 07:48:58 -0400
Received: from s.wrqvtzvf.outbound-mail.sendgrid.net ([149.72.126.143]:61926)
by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from
<bounces+21787432-9544-62700=debbugs.gnu.org@HIDDEN>)
id 1pqYDA-0005D5-24
for 62700 <at> debbugs.gnu.org; Sun, 23 Apr 2023 07:48:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com;
h=from:subject:in-reply-to:references:mime-version:to:cc:content-type:
content-transfer-encoding:cc:content-type:from:subject:to;
s=s1; bh=WEe0WJUX2ulnjBM+3xV//xZoiTIXDJpTt5o3z1DWWfQ=;
b=P4DdySoV8QOcHfEGhpnrqJ/3yxeA7E53ozzldoRvRLU3tTM4kpG5GORkySFbBbctCcYv
K+pg73yXBw8DRqpgPlBvHWDSjXJYHH44qs4b1K6hyDUDYGOBvrrmK5hIgFe3YFsEecPcN8
23oIGrjtZQgtyRUxejw6Gr0+rymbmk45x5qTqkcSKD9frI5HqJ9Q8iaHura5sauUX83NUE
fS7zf1JHZs3dP3nlm6l65yD2bJMINcGK0u+ZVlmS7vSUZny/KaXTXfEJ7nzg5RwdILacS6
f+Y/ECEaH0kp5pBhliOyqGTQJNOcGlyoNdSXuhOwjnusxvrjV0bmNdmHOfJ4b1+w==
Received: by filterdrecv-7457b4c9b5-mpqcp with SMTP id
filterdrecv-7457b4c9b5-mpqcp-1-64451B22-5
2023-04-23 11:48:50.168666584 +0000 UTC m=+5228083.948754101
Received: from earth.catern.com (unknown) by geopod-ismtpd-16 (SG) with ESMTP
id EBcS4ZEgRJC2Pv2hcJnNww Sun, 23 Apr 2023 11:48:49.962 +0000 (UTC)
X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost;
envelope-from=sbaugh@HIDDEN; receiver=<UNKNOWN>
Received: from localhost (localhost [IPv6:::1])
by earth.catern.com (Postfix) with ESMTPSA id 6A59060066;
Sun, 23 Apr 2023 07:48:49 -0400 (EDT)
From: sbaugh@HIDDEN
Subject: Re: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion
behave unintuitively when point is not at end of buffer
In-Reply-To: <83ttx7yvlt.fsf@HIDDEN> (Eli Zaretskii's message of "Sun, 23 Apr
2023 09:13:18 +0300")
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <87ildokraj.fsf@HIDDEN>
<837cu412jt.fsf@HIDDEN> <87cz3vlhqs.fsf@HIDDEN>
<83ttx7yvlt.fsf@HIDDEN>
Date: Sun, 23 Apr 2023 11:48:50 +0000 (UTC)
Message-ID: <87a5yylsym.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
X-SG-EID: =?us-ascii?Q?ZgbRq7gjGrt0q=2FPjvxk7wM0yQFRdOkTJAtEbkjCkHbJ8SWLbmsXq3vLtFNXMv9?=
=?us-ascii?Q?FOsXvNTM5ivlBV9v5hFhTjSVolbe+2myTakClD5?=
=?us-ascii?Q?PMXdFBwtSSWa4Rw5tyh=2FHSEB9QQrf6w5tHhSTmB?=
=?us-ascii?Q?ZXlazIXbIpdxb7cWkaSNC6OmFg14pinAaDB2Pdc?=
=?us-ascii?Q?UCTFauzeAUu5L=2F0Ugr1lm7wChww7z65ygUw=3D=3D?=
To: Eli Zaretskii <eliz@HIDDEN>
X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> From:
sbaugh@HIDDEN
>> Date: Sat, 22 Apr 2023 21:38:52 +0000 (UTC) >> Cc: 62700 <at> debbugs.gnu.org,
sbaugh@HIDDEN, juri@HIDDEN >> >> Eli Zaretskii [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in
bl.spamcop.net
[Blocked - see <https://www.spamcop.net/bl.shtml?149.72.126.143>]
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[149.72.126.143 listed in wl.mailspike.net]
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay
lines
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
Eli Zaretskii <eliz@HIDDEN> writes:
>> From: sbaugh@HIDDEN
>> Date: Sat, 22 Apr 2023 21:38:52 +0000 (UTC)
>> Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
>>
>> Eli Zaretskii <eliz@HIDDEN> writes:
>> > I asked for the changes to affect only code specific to M-<UP> and
>> > M-<DOWN>, but the patch you posted doesn't limit itself to that,
>> > AFAICT. Or what am I missing?
>>
>> Ah, I didn't realize that was what you were asking for. I can do that,
>> certainly, but why not also cover M-RET? The bug exists in the exact
>> same form for M-RET and it will be confusing (though better than
>> nothing, definitely) if the fix applies to M-<UP> and M-<DOWN> but not
>> M-RET.
>
> If the issue exists for M-RET, then fixing that case as well is okay.
> The request was not to affect any code that handles also other
> situation and other keys.
M-RET is bound to minibuffer-choose-completion, so then why the
objection to a patch which affects minibuffer-choose-completion?
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 23 Apr 2023 06:13:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 23 02:13:10 2023
Received: from localhost ([127.0.0.1]:44519 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pqSyD-0001en-M8
for submit <at> debbugs.gnu.org; Sun, 23 Apr 2023 02:13:09 -0400
Received: from eggs.gnu.org ([209.51.188.92]:46800)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1pqSyC-0001eF-6Q
for 62700 <at> debbugs.gnu.org; Sun, 23 Apr 2023 02:13:08 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pqSy2-0004iT-IP; Sun, 23 Apr 2023 02:12:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=isCHFS8FWHO+sLYQOkXfg8jK/Mae4JCIi9K43M89i2I=; b=qSOPUStRsd02
6Auw2YhzzRhmWKRcSn+bftVHY1OkgID+9CS83VrlDlBWYaNEy6UyptoHPey0vSa4KiBmMOw+9O/ZZ
PsbVqTkPQjgt4OfFgnruU5wa92ijcm5cgjC9ONYMNmSJRjok3pIaKC5A5YGsnJAWDCf9Pxh086x9O
C+kSrrb8iXfdXSJjTvJp8zUgDs+h6cyjjutxdCalXy9qJXfMhZlmvct0DjQBMcpgRg4z/agSKhx4c
HaCxx9/pQCrvdvc7pckCuC9IckPqdSLu+V7I94TDigLXSflrZUUeo/aUQkTSintrQ/Aoh0TiZ0wal
AHdE7RmgKiX6h9lyWTY7Yw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pqSy1-0001ee-6C; Sun, 23 Apr 2023 02:12:58 -0400
Date: Sun, 23 Apr 2023 09:13:18 +0300
Message-Id: <83ttx7yvlt.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: sbaugh@HIDDEN
In-Reply-To: <87cz3vlhqs.fsf@HIDDEN> (sbaugh@HIDDEN)
Subject: Re: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion
behave unintuitively when point is not at end of buffer
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <87ildokraj.fsf@HIDDEN>
<837cu412jt.fsf@HIDDEN> <87cz3vlhqs.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: sbaugh@HIDDEN
> Date: Sat, 22 Apr 2023 21:38:52 +0000 (UTC)
> Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
>
> Eli Zaretskii <eliz@HIDDEN> writes:
> > I asked for the changes to affect only code specific to M-<UP> and
> > M-<DOWN>, but the patch you posted doesn't limit itself to that,
> > AFAICT. Or what am I missing?
>
> Ah, I didn't realize that was what you were asking for. I can do that,
> certainly, but why not also cover M-RET? The bug exists in the exact
> same form for M-RET and it will be confusing (though better than
> nothing, definitely) if the fix applies to M-<UP> and M-<DOWN> but not
> M-RET.
If the issue exists for M-RET, then fixing that case as well is okay.
The request was not to affect any code that handles also other
situation and other keys.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 22 Apr 2023 21:39:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 22 17:39:01 2023
Received: from localhost ([127.0.0.1]:44279 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pqKwf-00036F-Gy
for submit <at> debbugs.gnu.org; Sat, 22 Apr 2023 17:39:01 -0400
Received: from s.wrqvtbkv.outbound-mail.sendgrid.net ([149.72.123.24]:38736)
by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from
<bounces+21787432-9544-62700=debbugs.gnu.org@HIDDEN>)
id 1pqKwc-00035z-UT
for 62700 <at> debbugs.gnu.org; Sat, 22 Apr 2023 17:39:00 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com;
h=from:subject:in-reply-to:references:mime-version:to:cc:content-type:
content-transfer-encoding:cc:content-type:from:subject:to;
s=s1; bh=MwWS2xlkNghB6uCY8g9nKDNf8zCQZuFR9+TiDiwUw1Q=;
b=NvoIAg+gV0coq7oLgFeRESInWwj+Uxjru4sq2YaF6DirsTuaqfCKYv0naUngHBiJM70b
ghD67MVdv+4lYTKLw93J1LCHuT3uETkX9NJfYpfxU8RNblBlNk2olTMrm+KkJqhVYKiZBu
fIbkP0b4mvRBvjDZGWqs3DWxWl758n/g32ZMalNFVbn0xFwuV6oUFdSLimi4y+H5BUF6lT
aAGNQBw8cB2cM2vMq3q2/+7p/q1BYZ/ZsbTHQaiYFKER7sqPI4ZnR01a0XkvPdlS2pnxWb
h7IDWXJYKWMVZLb98+Im4tXGD2ccX5gMZAI0O/Jc1HF2kDN3Y/mM9Wftp0bV91YQ==
Received: by filterdrecv-68f8d557c9-vlqms with SMTP id
filterdrecv-68f8d557c9-vlqms-1-644453EC-17
2023-04-22 21:38:52.718170152 +0000 UTC m=+5177193.570931007
Received: from earth.catern.com (unknown) by geopod-ismtpd-25 (SG) with ESMTP
id 4UGSFTJxRUugizPIO-yMxg Sat, 22 Apr 2023 21:38:52.595 +0000 (UTC)
X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost;
envelope-from=sbaugh@HIDDEN; receiver=<UNKNOWN>
Received: from localhost (localhost [IPv6:::1])
by earth.catern.com (Postfix) with ESMTPSA id CFD3360044;
Sat, 22 Apr 2023 17:38:51 -0400 (EDT)
From: sbaugh@HIDDEN
Subject: Re: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion
behave unintuitively when point is not at end of buffer
In-Reply-To: <837cu412jt.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 22 Apr
2023 16:15:02 +0300")
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <87ildokraj.fsf@HIDDEN>
<837cu412jt.fsf@HIDDEN>
Date: Sat, 22 Apr 2023 21:38:52 +0000 (UTC)
Message-ID: <87cz3vlhqs.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
X-SG-EID: =?us-ascii?Q?ZgbRq7gjGrt0q=2FPjvxk7wM0yQFRdOkTJAtEbkjCkHbIUpJdxwHMujvCd8TBHvN?=
=?us-ascii?Q?UkCY93ByW8CZVvyiPZv37MRlxNr2ao7PWgdSLJD?=
=?us-ascii?Q?ZMZk1Ro3+DcEXPcQidHH5OSNUt1ZJ2u1ddeL0mT?=
=?us-ascii?Q?yB4+4FpEJNoi7ICGFY0XxSMwYHef5ofNPiumhLe?=
=?us-ascii?Q?ClpXa8zbYHZ7ycOi7JG2CztqGnlGRggzuyw=3D=3D?=
To: Eli Zaretskii <eliz@HIDDEN>
X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Eli Zaretskii <eliz@HIDDEN> writes:
>> From: sbaugh@HIDDEN
>> Date: Sat, 22 Apr 2023 12:57:57 +0000 (UTC)
>> Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
>>
>> Eli Zaretskii <eliz@HIDDEN> writes:
>>
>> > And here we seem to be modifying code that is not only for when
>> > minibuffer-completion-auto-choose is non-nil, or what am I missing?
>>
>> The bug happens regardless of the value of
>> minibuffer-completion-auto-choose. It doesn't relate to
>> minibuffer-completion-auto-choose.
>
> I asked for the changes to affect only code specific to M-<UP> and
> M-<DOWN>, but the patch you posted doesn't limit itself to that,
> AFAICT. Or what am I missing?
Ah, I didn't realize that was what you were asking for. I can do that,
certainly, but why not also cover M-RET? The bug exists in the exact
same form for M-RET and it will be confusing (though better than
nothing, definitely) if the fix applies to M-<UP> and M-<DOWN> but not
M-RET.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 22 Apr 2023 13:14:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 22 09:14:56 2023
Received: from localhost ([127.0.0.1]:42102 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pqD4p-0002Ii-N9
for submit <at> debbugs.gnu.org; Sat, 22 Apr 2023 09:14:56 -0400
Received: from eggs.gnu.org ([209.51.188.92]:49778)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1pqD4l-0002IO-T1
for 62700 <at> debbugs.gnu.org; Sat, 22 Apr 2023 09:14:54 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pqD4e-0006aJ-SU; Sat, 22 Apr 2023 09:14:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=6JQnwxrdJ2RJgB1OsMklwtCvKBYxQKFWo5Cc8DmDgog=; b=oMOfPSI8pSLZ
EUVEqI+tjj/VGr/3AuWPXqEBiuh+Vz62RYL27HWULzNO6YXchARP4ACn8hRcpySgQkTqJNzbg9LQb
Ng40jtodKO1Sp3PF6S7LeiHUjahjtP0cVz0WhYOpr2Wft7YFCaduBfeOYShUct0O7J1g3qCh9Lm5l
br+ghlEdWjiZbXYGr1hjQlqxOURSIcGXdvbwczDR8IVfvlGC7HT+zFtazGefBdnU+V8hG4uWOtNg2
ovlJFyyqRJUP5NnOdB6JqdTTPXt9Uy1V+jtNKa+LVdTiOTJe1+HLD75Si+/KVqCM6WqiatAGTnBv3
7NWLVsnWzbhIluZkqJTX5g==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pqD4d-000272-TT; Sat, 22 Apr 2023 09:14:44 -0400
Date: Sat, 22 Apr 2023 16:15:02 +0300
Message-Id: <837cu412jt.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: sbaugh@HIDDEN
In-Reply-To: <87ildokraj.fsf@HIDDEN> (sbaugh@HIDDEN)
Subject: Re: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion
behave unintuitively when point is not at end of buffer
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN> <87ildokraj.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: sbaugh@HIDDEN
> Date: Sat, 22 Apr 2023 12:57:57 +0000 (UTC)
> Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
>
> Eli Zaretskii <eliz@HIDDEN> writes:
>
> > And here we seem to be modifying code that is not only for when
> > minibuffer-completion-auto-choose is non-nil, or what am I missing?
>
> The bug happens regardless of the value of
> minibuffer-completion-auto-choose. It doesn't relate to
> minibuffer-completion-auto-choose.
I asked for the changes to affect only code specific to M-<UP> and
M-<DOWN>, but the patch you posted doesn't limit itself to that,
AFAICT. Or what am I missing?
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 22 Apr 2023 12:58:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 22 08:58:05 2023
Received: from localhost ([127.0.0.1]:42091 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pqCoW-0001r2-Hp
for submit <at> debbugs.gnu.org; Sat, 22 Apr 2023 08:58:04 -0400
Received: from s.wrqvwxzv.outbound-mail.sendgrid.net ([149.72.154.232]:1714)
by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from
<bounces+21787432-9544-62700=debbugs.gnu.org@HIDDEN>)
id 1pqCoV-0001qY-6M
for 62700 <at> debbugs.gnu.org; Sat, 22 Apr 2023 08:58:03 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com;
h=from:subject:in-reply-to:references:mime-version:to:cc:content-type:
content-transfer-encoding:cc:content-type:from:subject:to;
s=s1; bh=o9GfvmhB9cmqkLgSYNnC97jdm43TK53IS7RkLLFhnl0=;
b=iWN5Z8BWG8nEmRkmGeokY+gG4USK1zOhL3nsgre9aFS6O0yI/SZr+IhFr1rZfl/VRRxp
SxjwMIV7TsDfrnxWkcJPcS01H8tgMuKYGc0R5wa4Jg1l4AiDm3tAepcyImsvSrcIJDbUZR
n1fV7puR8a5cc5YG0NdsgFT6N3hpnqRn5+FW/MuumGvSW5VtsIXOZ0/+wERUB1a22+Y07t
K146LZ20wBNxCNHfj0RcAeLeRMwXMIf8ZuiwxRKcOLMkFDIJtc6ib1sWEW1LJc3p3T7Sal
F6QlSo+pPvmVvqLWSMR/8G5QNKfAe02bNrqSKxBcKb+CIA9vbr6bflFMSxC1BB9w==
Received: by filterdrecv-68f8d557c9-x9fxp with SMTP id
filterdrecv-68f8d557c9-x9fxp-1-6443D9D5-E
2023-04-22 12:57:57.61863529 +0000 UTC m=+5145870.235180732
Received: from earth.catern.com (unknown) by geopod-ismtpd-25 (SG) with ESMTP
id pEmkYM5pRLWeTjJkkpGsdA Sat, 22 Apr 2023 12:57:57.425 +0000 (UTC)
X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost;
envelope-from=sbaugh@HIDDEN; receiver=<UNKNOWN>
Received: from localhost (localhost [IPv6:::1])
by earth.catern.com (Postfix) with ESMTPSA id C226860066;
Sat, 22 Apr 2023 08:57:56 -0400 (EDT)
From: sbaugh@HIDDEN
Subject: Re: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion
behave unintuitively when point is not at end of buffer
In-Reply-To: <83jzy419bk.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 22 Apr
2023 13:48:47 +0300")
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
<83jzy419bk.fsf@HIDDEN>
Date: Sat, 22 Apr 2023 12:57:57 +0000 (UTC)
Message-ID: <87ildokraj.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
X-SG-EID: =?us-ascii?Q?ZgbRq7gjGrt0q=2FPjvxk7wM0yQFRdOkTJAtEbkjCkHbK2YcYSFaIwyx10ir8l0E?=
=?us-ascii?Q?B0cFpLRcLdQwPtlWfqfYqyJ9mFvZhuSXU9KkS4U?=
=?us-ascii?Q?cYi0mcFKoPjuDbCp5ho+25F4D5ADTxlCb21w6s9?=
=?us-ascii?Q?3o7KCjfwS2lxsReASNKEz1x7XNfiNFr0TKLBqya?=
=?us-ascii?Q?EQklcIsUu4KZBiZ4+hj4HMOo1ZPRegALILQ=3D=3D?=
To: Eli Zaretskii <eliz@HIDDEN>
X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> From:
sbaugh@HIDDEN >> Date: Fri,
21 Apr 2023 18:56:35 +0000 (UTC) >> Cc: Spencer Baugh <sbaugh@HIDDEN>,
62700 <at> debbugs.gnu.org, >> juri@HIDDEN >> >> >> Ah, I thought Eli still
wante [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in
bl.spamcop.net
[Blocked - see <https://www.spamcop.net/bl.shtml?149.72.154.232>]
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 SPF_PASS SPF: sender matches SPF record
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[149.72.154.232 listed in wl.mailspike.net]
0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay
lines
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
Eli Zaretskii <eliz@HIDDEN> writes:
>> From: sbaugh@HIDDEN
>> Date: Fri, 21 Apr 2023 18:56:35 +0000 (UTC)
>> Cc: Spencer Baugh <sbaugh@HIDDEN>, 62700 <at> debbugs.gnu.org,
>> juri@HIDDEN
>>
>> >> Ah, I thought Eli still wanted a backport version because this changes
>> >> code which has been on Emacs 29 for over a year.
>> >
>> > Indeed, that's what I would like to see on the release branch. Mainly
>> > because even if this is deemed a bug, it happens in a relatively rare
>> > situation, so I'd like to avoid risking breakage in code which affects
>> > other situations.
>>
>> Here's the backport for the release branch.
>
> Thanks, but I'd like to make this still safer for the release branch:
>
>> --- a/lisp/minibuffer.el
>> +++ b/lisp/minibuffer.el
>> @@ -4464,13 +4464,21 @@ minibuffer-next-completion
>> When `minibuffer-completion-auto-choose' is non-nil, then also
>> insert the selected completion to the minibuffer."
>> (interactive "p")
>> - (let ((auto-choose minibuffer-completion-auto-choose))
>> + (let* ((auto-choose minibuffer-completion-auto-choose)
>> + ;; Backported fix for bug#62700
>> + (md (completion--field-metadata (minibuffer--completion-prompt-end)))
>> + (base-suffix
>> + (if (eq (alist-get 'category (cdr md)) 'file)
>> + (buffer-substring (save-excursion (search-forward "/" nil t) (point))
>> + (point-max))
>> + "")))
>> (with-minibuffer-completions-window
>> (when completions-highlight-face
>> (setq-local cursor-face-highlight-nonselected-window t))
>> (next-completion (or n 1))
>> (when auto-choose
>> - (let ((completion-use-base-affixes t))
>> + (let ((completion-use-base-affixes t)
>> + (completion-base-affixes (list (car completion-base-affixes) base-suffix)))
>> (choose-completion nil t t))))))
>
> Here, the values used only when minibuffer-completion-auto-choose is
> non-nil should be computed only when that variable is non-nil,
> preferably inside the '(when auto-choose' clause.
>
>> @@ -4489,9 +4497,17 @@ minibuffer-choose-completion
>> If NO-QUIT is non-nil, insert the completion at point to the
>> minibuffer, but don't quit the completions window."
>> (interactive "P")
>> - (with-minibuffer-completions-window
>> - (let ((completion-use-base-affixes t))
>> - (choose-completion nil no-exit no-quit))))
>> + ;; Backported fix for bug#62700
>> + (let* ((md (completion--field-metadata (minibuffer--completion-prompt-end)))
>> + (base-suffix
>> + (if (eq (alist-get 'category (cdr md)) 'file)
>> + (buffer-substring (save-excursion (search-forward "/" nil t) (point))
>> + (point-max))
>> + "")))
>> + (with-minibuffer-completions-window
>> + (let ((completion-use-base-affixes t)
>> + (completion-base-affixes (list (car completion-base-affixes) base-suffix)))
>> + (choose-completion nil no-exit no-quit)))))
>
> And here we seem to be modifying code that is not only for when
> minibuffer-completion-auto-choose is non-nil, or what am I missing?
The bug happens regardless of the value of
minibuffer-completion-auto-choose. It doesn't relate to
minibuffer-completion-auto-choose.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 22 Apr 2023 10:48:41 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 22 06:48:41 2023
Received: from localhost ([127.0.0.1]:41922 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pqAnI-0003s6-Mb
for submit <at> debbugs.gnu.org; Sat, 22 Apr 2023 06:48:41 -0400
Received: from eggs.gnu.org ([209.51.188.92]:35492)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1pqAnE-0003rn-O2
for 62700 <at> debbugs.gnu.org; Sat, 22 Apr 2023 06:48:39 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pqAn6-0002VQ-Qd; Sat, 22 Apr 2023 06:48:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=h48zYfQzJPW0xao/LfkX4/BzQlZfSiP39iFdYHCTUtc=; b=mGBS/ZNsXM8v
IXHbTzuuJeI1nJGCpCrbkB66Z5YeVBINO9wc4Klkyq5hkPx1HYtPU2QQWFL5iF8+UE9apsaVc1Xh5
Ft46AMnYMNgoT+QajhkjU/d/y69XD3RfEaP5IYspetEDFwY3DVzrETTFGSdEZx+7R6RqtwL4E3E8r
O0Q7ZYCSWAMGCrGIFp+T6roz1/IXUYWf8tq/8dzCveMj0IYhx0FNJUKXp4yuGx2zpLdEmz6ENi07j
iJJCQHUETGOThgnrYoVl3rLVE5MZhH0YH60rq9vPTsf7Rta8PgJcmK8rqzUNdhlazNRUqECS2u20I
q7y3gmzUyABSJ6UXy4Fvsw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pqAn6-0000R8-AV; Sat, 22 Apr 2023 06:48:28 -0400
Date: Sat, 22 Apr 2023 13:48:47 +0300
Message-Id: <83jzy419bk.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: sbaugh@HIDDEN
In-Reply-To: <87pm7xkqsd.fsf@HIDDEN> (sbaugh@HIDDEN)
Subject: Re: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion
behave unintuitively when point is not at end of buffer
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN> <87pm7xkqsd.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: sbaugh@HIDDEN
> Date: Fri, 21 Apr 2023 18:56:35 +0000 (UTC)
> Cc: Spencer Baugh <sbaugh@HIDDEN>, 62700 <at> debbugs.gnu.org,
> juri@HIDDEN
>
> >> Ah, I thought Eli still wanted a backport version because this changes
> >> code which has been on Emacs 29 for over a year.
> >
> > Indeed, that's what I would like to see on the release branch. Mainly
> > because even if this is deemed a bug, it happens in a relatively rare
> > situation, so I'd like to avoid risking breakage in code which affects
> > other situations.
>
> Here's the backport for the release branch.
Thanks, but I'd like to make this still safer for the release branch:
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -4464,13 +4464,21 @@ minibuffer-next-completion
> When `minibuffer-completion-auto-choose' is non-nil, then also
> insert the selected completion to the minibuffer."
> (interactive "p")
> - (let ((auto-choose minibuffer-completion-auto-choose))
> + (let* ((auto-choose minibuffer-completion-auto-choose)
> + ;; Backported fix for bug#62700
> + (md (completion--field-metadata (minibuffer--completion-prompt-end)))
> + (base-suffix
> + (if (eq (alist-get 'category (cdr md)) 'file)
> + (buffer-substring (save-excursion (search-forward "/" nil t) (point))
> + (point-max))
> + "")))
> (with-minibuffer-completions-window
> (when completions-highlight-face
> (setq-local cursor-face-highlight-nonselected-window t))
> (next-completion (or n 1))
> (when auto-choose
> - (let ((completion-use-base-affixes t))
> + (let ((completion-use-base-affixes t)
> + (completion-base-affixes (list (car completion-base-affixes) base-suffix)))
> (choose-completion nil t t))))))
Here, the values used only when minibuffer-completion-auto-choose is
non-nil should be computed only when that variable is non-nil,
preferably inside the '(when auto-choose' clause.
> @@ -4489,9 +4497,17 @@ minibuffer-choose-completion
> If NO-QUIT is non-nil, insert the completion at point to the
> minibuffer, but don't quit the completions window."
> (interactive "P")
> - (with-minibuffer-completions-window
> - (let ((completion-use-base-affixes t))
> - (choose-completion nil no-exit no-quit))))
> + ;; Backported fix for bug#62700
> + (let* ((md (completion--field-metadata (minibuffer--completion-prompt-end)))
> + (base-suffix
> + (if (eq (alist-get 'category (cdr md)) 'file)
> + (buffer-substring (save-excursion (search-forward "/" nil t) (point))
> + (point-max))
> + "")))
> + (with-minibuffer-completions-window
> + (let ((completion-use-base-affixes t)
> + (completion-base-affixes (list (car completion-base-affixes) base-suffix)))
> + (choose-completion nil no-exit no-quit)))))
And here we seem to be modifying code that is not only for when
minibuffer-completion-auto-choose is non-nil, or what am I missing?
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 21 Apr 2023 18:56:43 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 21 14:56:43 2023
Received: from localhost ([127.0.0.1]:41157 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ppvw2-0001Sx-T0
for submit <at> debbugs.gnu.org; Fri, 21 Apr 2023 14:56:43 -0400
Received: from s.wrqvtbkv.outbound-mail.sendgrid.net ([149.72.123.24]:11200)
by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from
<bounces+21787432-9544-62700=debbugs.gnu.org@HIDDEN>)
id 1ppvw0-0001Sj-Bh
for 62700 <at> debbugs.gnu.org; Fri, 21 Apr 2023 14:56:41 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com;
h=from:subject:in-reply-to:references:mime-version:to:cc:content-type:
cc:content-type:from:subject:to;
s=s1; bh=bUXVRemgsl+C9gZCPflR5Q3quOclMnX4vvEpbs4hTwk=;
b=FQ1a31vc5p9VWmZ1D5kIFshjoKX2QPoj8kdTgPlzRPbn1hYeEapX9jKx/97RhLD/jXr+
cl91O/7FYsbitdRxrlQq0toMZpwM8oR5hDahqQ0yD3an37YNbociqa9h1dp7//OO/GpY2G
vzLFX7j/E1EKvKbswOR5zBAc0HwiC6oqh5pL4IoOWAdNovssmaGc0mfSf8NLxdrYMOdF6c
l0lFAXXbkw4P9vlXDy+Anfp3d1PWs8HI7CSh9Tc+7l8m8yKPqq6DnLaKSO+XOnAIBbFF1A
nmZPp8H1pnecQRYEpYtaT4gkeKVZO06O5I3Ej24WMArAs1rVVI11TZwW4ZO1eoHw==
Received: by filterdrecv-68f8d557c9-5hs8d with SMTP id
filterdrecv-68f8d557c9-5hs8d-1-6442DC63-A
2023-04-21 18:56:35.081827422 +0000 UTC m=+5081104.936067886
Received: from earth.catern.com (unknown) by geopod-ismtpd-16 (SG) with ESMTP
id C9-qPoW-QSmR0Uq0LN6sPg Fri, 21 Apr 2023 18:56:34.912 +0000 (UTC)
X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost;
envelope-from=sbaugh@HIDDEN; receiver=<UNKNOWN>
Received: from localhost (localhost [IPv6:::1])
by earth.catern.com (Postfix) with ESMTPSA id 4BF22600AA;
Fri, 21 Apr 2023 14:56:34 -0400 (EDT)
From: sbaugh@HIDDEN
Subject: Re: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion
behave unintuitively when point is not at end of buffer
In-Reply-To: <83r0se4bwf.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 20 Apr
2023 22:00:16 +0300")
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
<83r0se4bwf.fsf@HIDDEN>
Date: Fri, 21 Apr 2023 18:56:35 +0000 (UTC)
Message-ID: <87pm7xkqsd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
X-SG-EID: =?us-ascii?Q?ZgbRq7gjGrt0q=2FPjvxk7wM0yQFRdOkTJAtEbkjCkHbJc8QAZRidaYgdF8l6hSJ?=
=?us-ascii?Q?5NFnZnp1MG=2FcUBGqSxXJUjsXktJX=2F6WrEGAYgcy?=
=?us-ascii?Q?K69TTxb5gZolmMHiA7wx7CKIp0GAHJZy3jNzfWF?=
=?us-ascii?Q?xgr4K1AD5dCV1gC2f+Vijwpk8rQe4Tdk678ILI9?=
=?us-ascii?Q?i3Z7kZqXba9BjQ2dmQj130=2FlvCuJADZ9Qcw=3D=3D?=
To: Eli Zaretskii <eliz@HIDDEN>
X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q==
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>,
juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
--=-=-=
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Eli Zaretskii <eliz@HIDDEN> writes:
>> Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>
>> From: Spencer Baugh <sbaugh@HIDDEN>
>> Date: Thu, 20 Apr 2023 14:46:45 -0400
>>
>> Juri Linkov <juri@HIDDEN> writes:
>> >>>>> It just needs more testing for different categories of completion.
>> >>>>
>> >>>> Which categories do you have in mind?
>> >>>
>> >>> Actually, I can't find categories where it could fail.
>> >>> So your patch looks safe to push.
>> >>
>> >> Can we go ahead and push it to Emacs master, then? I will work on the
>> >> changing-only-new-code backport for Emacs 29 as Eli requested.
>> >
>> > But your patch changes only new code.
>>
>> Ah, I thought Eli still wanted a backport version because this changes
>> code which has been on Emacs 29 for over a year.
>
> Indeed, that's what I would like to see on the release branch. Mainly
> because even if this is deemed a bug, it happens in a relatively rare
> situation, so I'd like to avoid risking breakage in code which affects
> other situations.
Here's the backport for the release branch. (FYI, my papers have been
signed and the FSF copyright clerk has approved accepting my
contributions again)
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline;
filename=0001-Handle-point-not-at-EOB-in-minibuffer-choose-complet.patch
From a159cfb8ee80e24de180d002caa61119edc7afc1 Mon Sep 17 00:00:00 2001
From: Spencer Baugh <sbaugh@HIDDEN>
Date: Fri, 21 Apr 2023 14:55:00 -0400
Subject: [PATCH] Handle point not at EOB in minibuffer-choose-completion
Without this change, only the minibuffer contents before point are
cleared when a completion is chosen, which results in stray text when
point is in the middle of the minibuffer.
After this change, we heuristically decide either to clear the whole
buffer or only part of it, taking into account the location of point.
This is a backport for the Emacs 29 release branch of a simpler fix in
minibuffer-completion-help.
* lisp/minibuffer.el (minibuffer-next-completion):
(minibuffer-choose-completion):
Recalculate completion-base-affixes with point
---
lisp/minibuffer.el | 26 +++++++++++++++++++++-----
1 file changed, 21 insertions(+), 5 deletions(-)
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index dfb06b5b88f..86946ec9ce1 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -4464,13 +4464,21 @@ minibuffer-next-completion
When `minibuffer-completion-auto-choose' is non-nil, then also
insert the selected completion to the minibuffer."
(interactive "p")
- (let ((auto-choose minibuffer-completion-auto-choose))
+ (let* ((auto-choose minibuffer-completion-auto-choose)
+ ;; Backported fix for bug#62700
+ (md (completion--field-metadata (minibuffer--completion-prompt-end)))
+ (base-suffix
+ (if (eq (alist-get 'category (cdr md)) 'file)
+ (buffer-substring (save-excursion (search-forward "/" nil t) (point))
+ (point-max))
+ "")))
(with-minibuffer-completions-window
(when completions-highlight-face
(setq-local cursor-face-highlight-nonselected-window t))
(next-completion (or n 1))
(when auto-choose
- (let ((completion-use-base-affixes t))
+ (let ((completion-use-base-affixes t)
+ (completion-base-affixes (list (car completion-base-affixes) base-suffix)))
(choose-completion nil t t))))))
(defun minibuffer-previous-completion (&optional n)
@@ -4489,9 +4497,17 @@ minibuffer-choose-completion
If NO-QUIT is non-nil, insert the completion at point to the
minibuffer, but don't quit the completions window."
(interactive "P")
- (with-minibuffer-completions-window
- (let ((completion-use-base-affixes t))
- (choose-completion nil no-exit no-quit))))
+ ;; Backported fix for bug#62700
+ (let* ((md (completion--field-metadata (minibuffer--completion-prompt-end)))
+ (base-suffix
+ (if (eq (alist-get 'category (cdr md)) 'file)
+ (buffer-substring (save-excursion (search-forward "/" nil t) (point))
+ (point-max))
+ "")))
+ (with-minibuffer-completions-window
+ (let ((completion-use-base-affixes t)
+ (completion-base-affixes (list (car completion-base-affixes) base-suffix)))
+ (choose-completion nil no-exit no-quit)))))
(defun minibuffer-complete-history ()
"Complete the minibuffer history as far as possible.
--
2.38.0
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 20 Apr 2023 19:00:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 20 15:00:24 2023
Received: from localhost ([127.0.0.1]:38716 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ppZW4-0000fG-JC
for submit <at> debbugs.gnu.org; Thu, 20 Apr 2023 15:00:24 -0400
Received: from eggs.gnu.org ([209.51.188.92]:47578)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1ppZW2-0000f1-Hh
for 62700 <at> debbugs.gnu.org; Thu, 20 Apr 2023 15:00:22 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1ppZVu-0007aW-Fm; Thu, 20 Apr 2023 15:00:15 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=EjHnmfpjSJfDwQcgfHHGPg7/ANwZlvZVxN94gCGvq6k=; b=pAaufTCCSrkz
HYSbvV7un7eOW95B/DKQfv/6j2YuEvGSiq/TSnG4v0zYVWViyiTTEpRy619mJs7wKTKgPi3aFtYzb
sJAedg5M7yPNXqvfImzlsBuVFOUHf6aez0YDYmf/QuPLOId+Rqv4PfkiZRJTMgnS8puMJNHkm0DvZ
ZfauMPJk18A12eyHd5KvRXp/EoIAVEnPULAypiX9broENFnaxIW/5h9dbh6HX4Z5BMll3mYsa8sKn
3p9gDyGIBtHBB4t1GVYAapgMfj6CbV+gNqv/c0K0M6Nw5NL7r4KR5CpSOKDM5Xsxin9AyniDAP3Ev
mOfdW5BhZX5R5ph7Z6eHrw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1ppZVh-0005OC-Nt; Thu, 20 Apr 2023 15:00:05 -0400
Date: Thu, 20 Apr 2023 22:00:16 +0300
Message-Id: <83r0se4bwf.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Spencer Baugh <sbaugh@HIDDEN>
In-Reply-To: <iera5z2z90q.fsf@HIDDEN> (message from Spencer Baugh on
Thu, 20 Apr 2023 14:46:45 -0400)
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively
when point is not at end of buffer
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN> <iera5z2z90q.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>
> From: Spencer Baugh <sbaugh@HIDDEN>
> Date: Thu, 20 Apr 2023 14:46:45 -0400
>
> Juri Linkov <juri@HIDDEN> writes:
> >>>>> It just needs more testing for different categories of completion.
> >>>>
> >>>> Which categories do you have in mind?
> >>>
> >>> Actually, I can't find categories where it could fail.
> >>> So your patch looks safe to push.
> >>
> >> Can we go ahead and push it to Emacs master, then? I will work on the
> >> changing-only-new-code backport for Emacs 29 as Eli requested.
> >
> > But your patch changes only new code.
>
> Ah, I thought Eli still wanted a backport version because this changes
> code which has been on Emacs 29 for over a year.
Indeed, that's what I would like to see on the release branch. Mainly
because even if this is deemed a bug, it happens in a relatively rare
situation, so I'd like to avoid risking breakage in code which affects
other situations.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 20 Apr 2023 18:51:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 20 14:51:57 2023
Received: from localhost ([127.0.0.1]:38689 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ppZNs-0000LG-Iy
for submit <at> debbugs.gnu.org; Thu, 20 Apr 2023 14:51:57 -0400
Received: from eggs.gnu.org ([209.51.188.92]:35132)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1ppZNn-0000Kf-59
for 62700 <at> debbugs.gnu.org; Thu, 20 Apr 2023 14:51:54 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1ppZNg-0004PU-C7; Thu, 20 Apr 2023 14:51:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=GzuWQSKT4bul41bnpgLmqXjyYNWvlsjHl+dpFR8Li9I=; b=oL7/ot9ADWUN
BLDMRklkR6oC/vR8PqSA1O3Zn+rU5BNaslWtqVggPQC1A8M248Mmr1ZJZeZybYBg16irDN87+lJsQ
jeTZvKEntng7SvwyAr44Ia5K+QWHFwB3ISUDwyXiW5Jy+h3SCWOtDt1Xscp8ZVGize1fg0fHezcUL
SSpOkNVP3Fz05ZxuvddFwPfiV50qvoH4pkcWWDvvzPuvZ7sNm4ZRUTOwo3T8ZoZJmkJ+SSoWgP62I
R3OeoMD+zftMINU033YCacUNpPWUHlNxqHUR3b3VzLSC2co3p7fFSzteC95BTNEe7iJYmDyFPxDzk
cW6am9RJECUmMljZyvkUMQ==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1ppZNf-0005YQ-9p; Thu, 20 Apr 2023 14:51:43 -0400
Date: Thu, 20 Apr 2023 21:51:58 +0300
Message-Id: <83v8hq4ca9.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
In-Reply-To: <868rema032.fsf@HIDDEN> (message from Juri Linkov on
Thu, 20 Apr 2023 21:18:57 +0300)
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively
when point is not at end of buffer
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>
> From: Juri Linkov <juri@HIDDEN>
> Date: Thu, 20 Apr 2023 21:18:57 +0300
>
> >>>> It just needs more testing for different categories of completion.
> >>>
> >>> Which categories do you have in mind?
> >>
> >> Actually, I can't find categories where it could fail.
> >> So your patch looks safe to push.
> >
> > Can we go ahead and push it to Emacs master, then? I will work on the
> > changing-only-new-code backport for Emacs 29 as Eli requested.
>
> But your patch changes only new code.
For some definition of "new", yes.
> Maybe your patch still could be pushed to emacs-29 because it fixes
> the new feature.
Whether this is a bugfix is arguable.
In any case, we need to hold Spencer's contributions until his legal
paperwork is finished. So we cannot yet install any of this, not even
on master.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 20 Apr 2023 18:46:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 20 14:46:56 2023
Received: from localhost ([127.0.0.1]:38684 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ppZJ1-0008VW-Oa
for submit <at> debbugs.gnu.org; Thu, 20 Apr 2023 14:46:56 -0400
Received: from mxout5.mail.janestreet.com ([64.215.233.18]:46481)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <sbaugh@HIDDEN>) id 1ppZIx-0008VE-F5
for 62700 <at> debbugs.gnu.org; Thu, 20 Apr 2023 14:46:54 -0400
From: Spencer Baugh <sbaugh@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <868rema032.fsf@HIDDEN> (Juri Linkov's message of "Thu,
20 Apr 2023 21:18:57 +0300")
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
<868rema032.fsf@HIDDEN>
Date: Thu, 20 Apr 2023 14:46:45 -0400
Message-ID: <iera5z2z90q.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Juri Linkov <juri@HIDDEN> writes:
>>>>> It just needs more testing for different categories of completion.
>>>>
>>>> Which categories do you have in mind?
>>>
>>> Actually, I can't find categories where it could fail.
>>> So your patch looks safe to push.
>>
>> Can we go ahead and push it to Emacs master, then? I will work on the
>> changing-only-new-code backport for Emacs 29 as Eli requested.
>
> But your patch changes only new code.
Ah, I thought Eli still wanted a backport version because this changes
code which has been on Emacs 29 for over a year.
I'm happy either way. (well, of course I prefer to not make a backport
version, but happy to do it if Eli wants one)
>>>>> Maybe you could find another heuristic for insertion of completion?
>>>>> The code is located in the same function 'minibuffer-completion-help':
>>>>>
>>>>> (if (and (stringp start) (stringp end))
>>>>> (progn
>>>>> (delete-minibuffer-contents)
>>>>> (insert start choice)
>>>>> ;; Keep point after completion before suffix
>>>>> (save-excursion (insert end)))
>>>>>
>>>>> Currently it keeps point before the suffix.
>>>>
>>>> I will try. Although this is a case where completion-base-position feels
>>>> more suited than completion-base-affixes...
>>>
>>> Can you get the same info about positions by calculating the
>>> lengths of prefix/choice/suffix?
>>
>> Hm I have thought about it but I can't see a simple heuristic.
>>
>> It's not actually clear what behavior we want, anyway. When TAB
>> completes a string fully, it sends point to the end of the buffer. This
>> happens even if completion-cycle-threshold is non-nil, and
>> completion-cycle-threashold feels like a pretty similar feature to
>> minibuffer-{previous,next}-completion. So maybe that's correct for us to
>> do here too?
>>
>> But a different behavior feels like it could also makes sense. For
>> example, if I'm completing from ffap-|-path (| is point), I'm just
>> cycling between ffap-bib-path, ffap-c++-path, ffap-c-path, and it feels
>> like as I cycle through those, point should stay right before "-path",
>> like ffap-bib|-path, ffap-c++|-path, ffap-c|-path. No idea how to
>> achieve this behavior though.
>
> This also makes sense: ffap-|bib-path, ffap-|c++-path, ffap-|c-path.
Agreed.
> I tried it with this tentative patch and it feels quite natural,
> so maybe could be turned into an option:
>
> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
> index a6af65dfa14..733f7710378 100644
> --- a/lisp/minibuffer.el
> +++ b/lisp/minibuffer.el
> @@ -2366,6 +2371,7 @@ minibuffer-completion-help
> (let* ((start (or start (minibuffer--completion-prompt-end)))
> (end (or end (point-max)))
> (string (buffer-substring start end))
> + (pos (1- (point)))
> (md (completion--field-metadata start))
> (completions (completion-all-completions
> string
> @@ -2493,7 +2503,8 @@ minibuffer-completion-help
> (delete-minibuffer-contents)
> (insert start choice)
> ;; Keep point after completion before suffix
> - (save-excursion (insert end)))
> + (save-excursion (insert end))
> + (move-to-column pos))
> (unless (or (zerop (length prefix))
> (equal prefix
> (buffer-substring-no-properties
Interesting idea. Although it breaks down with ?, I notice:
1. C-h v ff-|-p
2. ? to pop up completions
3. M-<down> to select diff-font-lock-prettify
4. Get dif|f-font-lock-prettify which seems fairly wrong
>> Anyway, the behavior with my earlier patch now feels fine to me, I don't
>> think we need any improvements to point's behavior for now.
>
> Maybe your patch still could be pushed to emacs-29 because it fixes
> the new feature.
Agreed.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 20 Apr 2023 18:22:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 20 14:22:29 2023
Received: from localhost ([127.0.0.1]:38659 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ppYvN-0007tA-6K
for submit <at> debbugs.gnu.org; Thu, 20 Apr 2023 14:22:29 -0400
Received: from relay1-d.mail.gandi.net ([217.70.183.193]:35447)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1ppYvK-0007su-5s
for 62700 <at> debbugs.gnu.org; Thu, 20 Apr 2023 14:22:28 -0400
Received: (Authenticated sender: juri@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id 6A54B240009;
Thu, 20 Apr 2023 18:22:16 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Spencer Baugh <sbaugh@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <ierfs8uzebf.fsf@HIDDEN> (Spencer Baugh's message of
"Thu, 20 Apr 2023 12:52:20 -0400")
Organization: LINKOV.NET
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN> <ierfs8uzebf.fsf@HIDDEN>
Date: Thu, 20 Apr 2023 21:18:57 +0300
Message-ID: <868rema032.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>>>> It just needs more testing for different categories of completion.
>>>
>>> Which categories do you have in mind?
>>
>> Actually, I can't find categories where it could fail.
>> So your patch looks safe to push.
>
> Can we go ahead and push it to Emacs master, then? I will work on the
> changing-only-new-code backport for Emacs 29 as Eli requested.
But your patch changes only new code.
>>>> Maybe you could find another heuristic for insertion of completion?
>>>> The code is located in the same function 'minibuffer-completion-help':
>>>>
>>>> (if (and (stringp start) (stringp end))
>>>> (progn
>>>> (delete-minibuffer-contents)
>>>> (insert start choice)
>>>> ;; Keep point after completion before suffix
>>>> (save-excursion (insert end)))
>>>>
>>>> Currently it keeps point before the suffix.
>>>
>>> I will try. Although this is a case where completion-base-position feels
>>> more suited than completion-base-affixes...
>>
>> Can you get the same info about positions by calculating the
>> lengths of prefix/choice/suffix?
>
> Hm I have thought about it but I can't see a simple heuristic.
>
> It's not actually clear what behavior we want, anyway. When TAB
> completes a string fully, it sends point to the end of the buffer. This
> happens even if completion-cycle-threshold is non-nil, and
> completion-cycle-threashold feels like a pretty similar feature to
> minibuffer-{previous,next}-completion. So maybe that's correct for us to
> do here too?
>
> But a different behavior feels like it could also makes sense. For
> example, if I'm completing from ffap-|-path (| is point), I'm just
> cycling between ffap-bib-path, ffap-c++-path, ffap-c-path, and it feels
> like as I cycle through those, point should stay right before "-path",
> like ffap-bib|-path, ffap-c++|-path, ffap-c|-path. No idea how to
> achieve this behavior though.
This also makes sense: ffap-|bib-path, ffap-|c++-path, ffap-|c-path.
I tried it with this tentative patch and it feels quite natural,
so maybe could be turned into an option:
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index a6af65dfa14..733f7710378 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -2366,6 +2371,7 @@ minibuffer-completion-help
(let* ((start (or start (minibuffer--completion-prompt-end)))
(end (or end (point-max)))
(string (buffer-substring start end))
+ (pos (1- (point)))
(md (completion--field-metadata start))
(completions (completion-all-completions
string
@@ -2493,7 +2503,8 @@ minibuffer-completion-help
(delete-minibuffer-contents)
(insert start choice)
;; Keep point after completion before suffix
- (save-excursion (insert end)))
+ (save-excursion (insert end))
+ (move-to-column pos))
(unless (or (zerop (length prefix))
(equal prefix
(buffer-substring-no-properties
> Anyway, the behavior with my earlier patch now feels fine to me, I don't
> think we need any improvements to point's behavior for now.
Maybe your patch still could be pushed to emacs-29 because it fixes
the new feature.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 20 Apr 2023 16:52:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 20 12:52:29 2023
Received: from localhost ([127.0.0.1]:38607 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ppXWH-0005OR-H0
for submit <at> debbugs.gnu.org; Thu, 20 Apr 2023 12:52:29 -0400
Received: from mxout5.mail.janestreet.com ([64.215.233.18]:41853)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <sbaugh@HIDDEN>) id 1ppXWE-0005OC-Eh
for 62700 <at> debbugs.gnu.org; Thu, 20 Apr 2023 12:52:27 -0400
From: Spencer Baugh <sbaugh@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <8635574n10.fsf@HIDDEN> (Juri Linkov's message of "Mon,
10 Apr 2023 21:20:27 +0300")
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
<8635574n10.fsf@HIDDEN>
Date: Thu, 20 Apr 2023 12:52:20 -0400
Message-ID: <ierfs8uzebf.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Juri Linkov <juri@HIDDEN> writes:
>>> It just needs more testing for different categories of completion.
>>
>> Which categories do you have in mind?
>
> Actually, I can't find categories where it could fail.
> So your patch looks safe to push.
Can we go ahead and push it to Emacs master, then? I will work on the
changing-only-new-code backport for Emacs 29 as Eli requested.
>>> Maybe you could find another heuristic for insertion of completion?
>>> The code is located in the same function 'minibuffer-completion-help':
>>>
>>> (if (and (stringp start) (stringp end))
>>> (progn
>>> (delete-minibuffer-contents)
>>> (insert start choice)
>>> ;; Keep point after completion before suffix
>>> (save-excursion (insert end)))
>>>
>>> Currently it keeps point before the suffix.
>>
>> I will try. Although this is a case where completion-base-position feels
>> more suited than completion-base-affixes...
>
> Can you get the same info about positions by calculating the
> lengths of prefix/choice/suffix?
Hm I have thought about it but I can't see a simple heuristic.
It's not actually clear what behavior we want, anyway. When TAB
completes a string fully, it sends point to the end of the buffer. This
happens even if completion-cycle-threshold is non-nil, and
completion-cycle-threashold feels like a pretty similar feature to
minibuffer-{previous,next}-completion. So maybe that's correct for us to
do here too?
But a different behavior feels like it could also makes sense. For
example, if I'm completing from ffap-|-path (| is point), I'm just
cycling between ffap-bib-path, ffap-c++-path, ffap-c-path, and it feels
like as I cycle through those, point should stay right before "-path",
like ffap-bib|-path, ffap-c++|-path, ffap-c|-path. No idea how to
achieve this behavior though.
Anyway, the behavior with my earlier patch now feels fine to me, I don't
think we need any improvements to point's behavior for now.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 10 Apr 2023 18:25:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 10 14:25:22 2023
Received: from localhost ([127.0.0.1]:35887 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1plwCf-0006oA-Q3
for submit <at> debbugs.gnu.org; Mon, 10 Apr 2023 14:25:22 -0400
Received: from relay10.mail.gandi.net ([217.70.178.230]:44061)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1plwCd-0006nu-W4
for 62700 <at> debbugs.gnu.org; Mon, 10 Apr 2023 14:25:20 -0400
Received: (Authenticated sender: juri@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id 9691D240006;
Mon, 10 Apr 2023 18:25:12 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Spencer Baugh <sbaugh@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN> (Spencer
Baugh's message of "Mon, 10 Apr 2023 13:03:04 +0000 (UTC)")
Organization: LINKOV.NET
References: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
Date: Mon, 10 Apr 2023 21:20:27 +0300
Message-ID: <8635574n10.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>> It just needs more testing for different categories of completion.
>
> Which categories do you have in mind?
Actually, I can't find categories where it could fail.
So your patch looks safe to push.
>> Maybe you could find another heuristic for insertion of completion?
>> The code is located in the same function 'minibuffer-completion-help':
>>
>> (if (and (stringp start) (stringp end))
>> (progn
>> (delete-minibuffer-contents)
>> (insert start choice)
>> ;; Keep point after completion before suffix
>> (save-excursion (insert end)))
>>
>> Currently it keeps point before the suffix.
>
> I will try. Although this is a case where completion-base-position feels
> more suited than completion-base-affixes...
Can you get the same info about positions by calculating the
lengths of prefix/choice/suffix?
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 10 Apr 2023 13:03:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 10 09:03:14 2023
Received: from localhost ([127.0.0.1]:34542 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1plrAv-0000tI-VL
for submit <at> debbugs.gnu.org; Mon, 10 Apr 2023 09:03:14 -0400
Received: from s.wrqvtbkv.outbound-mail.sendgrid.net ([149.72.123.24]:7950)
by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from
<bounces+21787432-9544-62700=debbugs.gnu.org@HIDDEN>)
id 1plrAu-0000t4-1E
for 62700 <at> debbugs.gnu.org; Mon, 10 Apr 2023 09:03:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com;
h=subject:in-reply-to:from:mime-version:to:cc:content-type:
content-transfer-encoding:cc:content-type:from:subject:to;
s=s1; bh=SAp37kvQWEig+0nHAwDxCGzkqcdBX4CciXg2aGscr3w=;
b=YF4OWnYpDl2SRbWXj6rWXtp2FBCIm6ySg1/0d9NfIoLToPaJiHojHLVXw8jP51WX83q6
tQR+DQAFfVaDobkNMNa1fW9T98mbtG5UIaVj9Fl6cDU2Uud+XoRmJQYraZrcCQydrsSiDQ
7cWQDVRoGyFfpEfXE0aWJYCnyUqRKfRcKO2w/ilDC3TcdZJwx6BoTEhj2Zrtt9bGeuZOK/
0lmmdbhjDt7WBV4HISPCU2mWm9/Nuo6Uhkqd6mL5U7ljNluFvCE2IxC+JSZRsGlOBcTusR
IwipAuVurTqiB5jMQuNeuPtdmwE33D33pUc9xq0kDtAwWXvthkuncy3+s1uuv74g==
Received: by filterdrecv-68f8d557c9-cxx9p with SMTP id
filterdrecv-68f8d557c9-cxx9p-1-64340908-CA
2023-04-10 13:03:04.626989879 +0000 UTC m=+4109494.750825649
Received: from earth.catern.com (unknown) by geopod-ismtpd-5 (SG) with ESMTP
id F4BJBL4UQziqnWtaQFaOoQ Mon, 10 Apr 2023 13:03:04.466 +0000 (UTC)
Date: Mon, 10 Apr 2023 13:03:04 +0000 (UTC)
Subject: Re: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion
behave unintuitively when point is not at end of buffer
Message-ID: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
X-Android-Message-ID: <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@HIDDEN>
In-Reply-To: <864jpqdwrs.fsf@HIDDEN>
From: Spencer Baugh <sbaugh@HIDDEN>
Importance: Normal
X-Priority: 3
X-MSMail-Priority: Normal
MIME-Version: 1.0
X-SG-EID: =?us-ascii?Q?GW3oCMoYnalRiojMOuLzE6x2H5kORXvlCdz1UwQVRMVT4fbh9ODEfCogOe74cO?=
=?us-ascii?Q?rI4e0V+MFZgakz9Re5a6=2FCgtyGP4WoyAG0S+mE4?=
=?us-ascii?Q?BozWDNKqAiJRuJmoGyaZFNzH0t+gBaLfX93LL4U?=
=?us-ascii?Q?Kf0uMzjb0ECHZI=2FLNWG4XDkFRqA8hm+NZJlGgaZ?=
=?us-ascii?Q?B8SRb5qZPRVCai5=2FRLCi9pzIm96997CCIgZKYbj?=
=?us-ascii?Q?Xz811B=2FB+P1lC27TPhjmhrdgUsU5YQM=2FpQsXi1?=
To: Juri Linkov <juri@HIDDEN>
X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q==
Content-Type: text/html; charset=us-ascii
Content-Transfer-Encoding: base64
X-Spam-Score: 1.7 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: On Apr 8, 2023 14:30, Juri Linkov <juri@HIDDEN> wrote:
> Here's one heuristic which works decently well: > > The reasoning here
is that if completion returns the full string which > should be in the
minibuffer, then we should replace the minibuffer with > [...]
Content analysis details: (1.7 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[149.72.123.24 listed in wl.mailspike.net]
-0.0 SPF_PASS SPF: sender matches SPF record
0.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts
0.0 HTML_MESSAGE BODY: HTML included in message
0.0 MIME_BASE64_TEXT RAW: Message text disguised using base64
encoding
0.6 HTML_MIME_NO_HTML_TAG HTML-only message, but there is no HTML
tag
0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay
lines
1.0 MALF_HTML_B64 Malformatted base64-encoded HTML content
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.7 (/)
PGRpdiBkaXI9J2F1dG8nPjxkaXY+PGRpdiBjbGFzcz0iZ21haWxfZXh0cmEiPjxkaXYgY2xhc3M9
ImdtYWlsX3F1b3RlIj5PbiBBcHIgOCwgMjAyMyAxNDozMCwgSnVyaSBMaW5rb3YgJmx0O2p1cmlA
bGlua292Lm5ldCZndDsgd3JvdGU6PGJyIHR5cGU9ImF0dHJpYnV0aW9uIj48YmxvY2txdW90ZSBj
bGFzcz0icXVvdGUiIHN0eWxlPSJtYXJnaW46MCAwIDAgLjhleDtib3JkZXItbGVmdDoxcHggI2Nj
YyBzb2xpZDtwYWRkaW5nLWxlZnQ6MWV4Ij48cCBkaXI9Imx0ciI+Jmd0OyBIZXJlJ3Mgb25lIGhl
dXJpc3RpYyB3aGljaCB3b3JrcyBkZWNlbnRseSB3ZWxsOgo8YnI+CiZndDsKPGJyPgomZ3Q7IFRo
ZSByZWFzb25pbmcgaGVyZSBpcyB0aGF0IGlmIGNvbXBsZXRpb24gcmV0dXJucyB0aGUgZnVsbCBz
dHJpbmcgd2hpY2gKPGJyPgomZ3Q7IHNob3VsZCBiZSBpbiB0aGUgbWluaWJ1ZmZlciwgdGhlbiB3
ZSBzaG91bGQgcmVwbGFjZSB0aGUgbWluaWJ1ZmZlciB3aXRoCjxicj4KJmd0OyB0aGF0IHN0cmlu
Zywgc28gYmFzZS1zdWZmaXggc2hvdWxkIGJlICIiLiZuYnNwOyBCdXQgaWYgd2UncmUgY29tcGxl
dGluZyBvbmx5Cjxicj4KJmd0OyBwYXJ0IG9mIHRoZSBzdHJpbmcsIGJhc2Utc3VmZml4IHNob3Vs
ZCBiZSBzb21ldGhpbmcgZWxzZS4mbmJzcDsgQUZBSUsgb25seQo8YnI+CiZndDsgZmlsZSBjb21w
bGV0aW9uIGZhbGxzIGludG8gdGhlIGxhdHRlciBjYXRlZ29yeSwgYW5kIGl0IGFsd2F5cyBjb21w
bGV0ZXMKPGJyPgomZ3Q7IGp1c3Qgb25lIGNvbXBvbmVudCBvZiBhIHBhdGgsIHNvIEkgc2V0IGJh
c2Utc3VmZml4IHRvIG5vdCBpbmNsdWRlIHRoZQo8YnI+CiZndDsgY29tcG9uZW50IG9mIHRoZSBw
YXRoIHRoYXQgcG9pbnQgaXMgaW4sIHNvIHRoYXQgY29tcGxldGlvbiByZXBsYWNlcyBpdAo8YnI+
CiZndDsgZW50aXJlbHkuCjxicj4KJmd0Owo8YnI+CiZndDsgSSB0aGluayB0aGlzIGlzIGJhc2lj
YWxseSBhIHNhdGlzZmFjdG9yeSBoZXVyaXN0aWMsIGFsdGhvdWdoIEknbSBzdXJlCjxicj4KJmd0
OyBJJ20gbWlzc2luZyBzb21lIGNhdGVnb3JpZXMgb2YgY29tcGxldGlvbiBiZXNpZGVzIGZpbGUg
Y29tcGxldGlvbiB3aGljaAo8YnI+CiZndDsgY29tcGxldGUgb25seSBwYXJ0IG9mIHRoZSBzdHJp
bmcuCjxicj4KCjxicj4KVGhhbmtzLCB0aGlzIGxvb2tzIGxpa2UgYSBzYXRpc2ZhY3RvcnkgaGV1
cmlzdGljIGluZGVlZC4mbmJzcDsgSXQganVzdCBuZWVkcwo8YnI+Cm1vcmUgdGVzdGluZyBmb3Ig
ZGlmZmVyZW50IGNhdGVnb3JpZXMgb2YgY29tcGxldGlvbi4KPGJyPgoKPC9wPjwvYmxvY2txdW90
ZT48L2Rpdj48L2Rpdj48L2Rpdj48ZGl2IGRpcj0iYXV0byI+V2hpY2ggY2F0ZWdvcmllcyBkbyB5
b3UgaGF2ZSBpbiBtaW5kPzwvZGl2PjxkaXYgZGlyPSJhdXRvIj48ZGl2IGNsYXNzPSJnbWFpbF9l
eHRyYSI+PGRpdiBjbGFzcz0iZ21haWxfcXVvdGUiPjxibG9ja3F1b3RlIGNsYXNzPSJxdW90ZSIg
c3R5bGU9Im1hcmdpbjowIDAgMCAuOGV4O2JvcmRlci1sZWZ0OjFweCAjY2NjIHNvbGlkO3BhZGRp
bmctbGVmdDoxZXgiPjxwIGRpcj0ibHRyIj48YnI+CiZndDsgUmVnYXJkbGVzcyBvZiB3aGV0aGVy
IHRoaXMgaXMgYSBzYXRpc2ZhY3RvcnkgaGV1cmlzdGljLCBpdCdzIHJldmVhbGVkIHRvCjxicj4K
Jmd0OyBtZSBhbiB1bmV4cGVjdGVkIGJlaGF2aW9yIG9mIGEgc29sdXRpb24gdG8gdGhpcyBidWcg
dXNpbmcgYmFzZS1zdWZmaXgsCjxicj4KJmd0OyB3aGljaCBtYXkgb3IgbWF5IG5vdCBiZSBmaW5l
OiBQb2ludCBpcyBtb3ZlZCB0byB0aGUgZW5kIG9mIHRoZQo8YnI+CiZndDsgY29tcGxldGlvbiBp
bnNlcnRlZC4KPGJyPgomZ3Q7Cjxicj4KJmd0OyBTbyBlLmcuIGlmIHBvaW50IGlzIGF0IHwgYW5k
IEknbSBjb21wbGV0aW5nIHwtcGF0aCwgdGhlbiB3aGVuIEkgY2hvb3NlCjxicj4KJmd0OyB0aGUg
Y29tcGxldGlvbiBsb2FkLXBhdGgsIHBvaW50IHdpbGwgYmUgYXQgbG9hZC1wYXRofCByYXRoZXIg
dGhhbgo8YnI+CiZndDsgbG9hZHwtcGF0aC4mbmJzcDsgVGhpcyBpc24ndCBhIGh1Z2UgaXNzdWUg
YnV0IGl0IG1pZ2h0IGJlIGEgbGl0dGxlIGFubm95aW5nPwo8YnI+CiZndDsgSSBkb24ndCBrbm93
IGlmIHRoZXJlJ3MgYW55IHdheSB0byBmaXggdGhpcy4KPGJyPgoKPGJyPgpNYXliZSB5b3UgY291
bGQgZmluZCBhbm90aGVyIGhldXJpc3RpYyBmb3IgaW5zZXJ0aW9uIG9mIGNvbXBsZXRpb24/Cjxi
cj4KVGhlIGNvZGUgaXMgbG9jYXRlZCBpbiB0aGUgc2FtZSBmdW5jdGlvbiAnbWluaWJ1ZmZlci1j
b21wbGV0aW9uLWhlbHAnOgo8YnI+Cgo8YnI+CiZuYnNwOyAoaWYgKGFuZCAoc3RyaW5ncCBzdGFy
dCkgKHN0cmluZ3AgZW5kKSkKPGJyPgombmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgKHBy
b2duCjxicj4KJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IChkZWxl
dGUtbWluaWJ1ZmZlci1jb250ZW50cykKPGJyPgombmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz
cDsmbmJzcDsmbmJzcDsgKGluc2VydCBzdGFydCBjaG9pY2UpCjxicj4KJm5ic3A7Jm5ic3A7Jm5i
c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IDs7IEtlZXAgcG9pbnQgYWZ0ZXIgY29tcGxldGlv
biBiZWZvcmUgc3VmZml4Cjxicj4KJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7
Jm5ic3A7IChzYXZlLWV4Y3Vyc2lvbiAoaW5zZXJ0IGVuZCkpKQo8YnI+Cgo8YnI+CkN1cnJlbnRs
eSBpdCBrZWVwcyBwb2ludCBiZWZvcmUgdGhlIHN1ZmZpeC4KPGJyPgo8L3A+CjwvYmxvY2txdW90
ZT48L2Rpdj5JIHdpbGwgdHJ5LiBBbHRob3VnaCB0aGlzIGlzIGEgY2FzZSB3aGVyZSBjb21wbGV0
aW9uLWJhc2UtcG9zaXRpb24gZmVlbHMgbW9yZSBzdWl0ZWQgdGhhbiBjb21wbGV0aW9uLWJhc2Ut
YWZmaXhlcy4uLjwvZGl2PjwvZGl2PjwvZGl2Pg==
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 9 Apr 2023 17:37:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 09 13:37:57 2023
Received: from localhost ([127.0.0.1]:33601 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1plYzE-0001hw-Rk
for submit <at> debbugs.gnu.org; Sun, 09 Apr 2023 13:37:57 -0400
Received: from eggs.gnu.org ([209.51.188.92]:44274)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1plYzD-0001hj-NS
for 62700 <at> debbugs.gnu.org; Sun, 09 Apr 2023 13:37:56 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1plYz7-00020N-SJ; Sun, 09 Apr 2023 13:37:49 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=ruY0n+MbkIdvQURpChgtqUiobaz/pY78TzMFL8NDge8=; b=mqoXB0w9/EbT
UpDRq87sO5F/pacVcGT4IwugFfaiRO7GaecuOvXYJMhQhdOT6IL1q58wtnowKE3nKCS5kor1tsyjE
Q1Pm+AInCgbzsn8GXtXU6CMzzhXMJuirCpqt+HtI6bwZdeh9R0H4YdaMJPFfftFbZ1gg87mYg+yC/
Dr0qudcwre92o+hQMWm6Q8gT0P/gsoFEZG9JTRLZhyvE+PAdhBsAdJWFMoqSXIcz3bFszxAJl4NId
8xQzvw7am5esvxsNFTE/cJMxzi1wfcaf2RSr6VdmHsSHdxJcDJVdqozdMf5/C9k1AwdqNt6f+DE3M
8zti/W6J9xWDg8/tDskh6g==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1plYz7-0002CZ-4o; Sun, 09 Apr 2023 13:37:49 -0400
Date: Sun, 09 Apr 2023 20:38:27 +0300
Message-Id: <831qktlzvw.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
In-Reply-To: <863559xb3u.fsf@HIDDEN> (message from Juri Linkov on
Sun, 09 Apr 2023 19:40:37 +0300)
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
References: <iery1n4sxm4.fsf@HIDDEN> <864jpsrgaz.fsf@HIDDEN>
<iersfdcstme.fsf@HIDDEN> <86h6tr4pi8.fsf@HIDDEN>
<87sfdbmmmh.fsf@HIDDEN> <838rf2opa0.fsf@HIDDEN>
<86ttxqdwyp.fsf@HIDDEN> <83cz4emap9.fsf@HIDDEN>
<863559xb3u.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Juri Linkov <juri@HIDDEN>
> Cc: sbaugh@HIDDEN, 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN
> Date: Sun, 09 Apr 2023 19:40:37 +0300
>
> >> > If this is for master, I'm fine with such changes. But if you intend
> >> > to request installing this on emacs-29, then I will object making
> >> > non-trivial changes in any code that is not specific to the M-<UP> and
> >>
> >> Actually, a change for base-suffix in minibuffer-completion-help
> >> is a trivial change. What counts as a non-trivial change would be
> >> changing the API in completion-all-completions.
> >>
> >> > M-<DOWN> bindings that are new in Emacs 29. I don't want to risk any
> >> > regressions in general-purpose completion code at this late stage.
> >>
> >> These changes are specific to the M-<UP> and M-<DOWN> bindings:
> >> completion-use-base-affixes is nil, and it's let-bound to t
> >> in M-<UP> (minibuffer-previous-completion) and M-<DOWN>
> >> (minibuffer-next-completion).
> >
> > The change I reviewed and to which I responded was in code that was
> > there in Emacs 28 as well. Maybe we are talking about two different
> > sets of changes.
>
> That code was added in Emacs 29 a year ago in the commit
> 7aaffe25eb178f69027fb0af844a89a86db4b1f2.
Ah, you mean that part. Yes, but a year is a long time, and making
non-trivial changes there now is not something I'd like to do.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 9 Apr 2023 16:41:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Apr 09 12:41:56 2023
Received: from localhost ([127.0.0.1]:33584 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1plY72-0008Te-E9
for submit <at> debbugs.gnu.org; Sun, 09 Apr 2023 12:41:56 -0400
Received: from relay3-d.mail.gandi.net ([217.70.183.195]:59657)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1plY70-0008TO-MG
for 62700 <at> debbugs.gnu.org; Sun, 09 Apr 2023 12:41:55 -0400
Received: (Authenticated sender: juri@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id A6A0A6000B;
Sun, 9 Apr 2023 16:41:46 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <83cz4emap9.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 08 Apr
2023 22:32:34 +0300")
Organization: LINKOV.NET
References: <iery1n4sxm4.fsf@HIDDEN> <864jpsrgaz.fsf@HIDDEN>
<iersfdcstme.fsf@HIDDEN> <86h6tr4pi8.fsf@HIDDEN>
<87sfdbmmmh.fsf@HIDDEN> <838rf2opa0.fsf@HIDDEN>
<86ttxqdwyp.fsf@HIDDEN> <83cz4emap9.fsf@HIDDEN>
Date: Sun, 09 Apr 2023 19:40:37 +0300
Message-ID: <863559xb3u.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>> > If this is for master, I'm fine with such changes. But if you intend
>> > to request installing this on emacs-29, then I will object making
>> > non-trivial changes in any code that is not specific to the M-<UP> and
>>
>> Actually, a change for base-suffix in minibuffer-completion-help
>> is a trivial change. What counts as a non-trivial change would be
>> changing the API in completion-all-completions.
>>
>> > M-<DOWN> bindings that are new in Emacs 29. I don't want to risk any
>> > regressions in general-purpose completion code at this late stage.
>>
>> These changes are specific to the M-<UP> and M-<DOWN> bindings:
>> completion-use-base-affixes is nil, and it's let-bound to t
>> in M-<UP> (minibuffer-previous-completion) and M-<DOWN>
>> (minibuffer-next-completion).
>
> The change I reviewed and to which I responded was in code that was
> there in Emacs 28 as well. Maybe we are talking about two different
> sets of changes.
That code was added in Emacs 29 a year ago in the commit
7aaffe25eb178f69027fb0af844a89a86db4b1f2.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 8 Apr 2023 19:32:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 08 15:32:11 2023
Received: from localhost ([127.0.0.1]:59572 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1plEIF-00083a-0T
for submit <at> debbugs.gnu.org; Sat, 08 Apr 2023 15:32:11 -0400
Received: from eggs.gnu.org ([209.51.188.92]:46530)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1plEIC-00083J-Rj
for 62700 <at> debbugs.gnu.org; Sat, 08 Apr 2023 15:32:09 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1plEI6-00007Z-Ve; Sat, 08 Apr 2023 15:32:02 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=GJkLCGQY+TQSf/OOnWahwmpX/lySO0G7WzhKAOkcSqQ=; b=ci1b9nZNMwoD
k/vIVSoEEJTHnDTe1VvVtCEd9O7UEhrKoRABEwGYm20RfvLCYI9ofL6nZErbl9sSudcL/5MqZ4/aC
PEtj23sFthGSF0hOjEM6GfpE5JLx6Ia31pH51Ty2lV1vuRgvKwbgp1CgUel/PTy6Upa/CXf0Uuq99
HFR2SqfnMCgxGKIhT4Hu3AMrEXBL9tixJZ3x9tsoS7qLshR+ehVNQwLDKIoeYvoJBy289efIeYQx6
kYo9HL/JAUupXLutkoBuazPmpka7j2JwKqUXaUyr2/HoS6DMo7Q5XXbkOtLTxgyHVzgznXkwvNy/t
usImlhUP8yC82ntFExHAQw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1plEI3-0005HI-QN; Sat, 08 Apr 2023 15:32:01 -0400
Date: Sat, 08 Apr 2023 22:32:34 +0300
Message-Id: <83cz4emap9.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
In-Reply-To: <86ttxqdwyp.fsf@HIDDEN> (message from Juri Linkov on
Sat, 08 Apr 2023 21:36:30 +0300)
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
References: <iery1n4sxm4.fsf@HIDDEN> <864jpsrgaz.fsf@HIDDEN>
<iersfdcstme.fsf@HIDDEN> <86h6tr4pi8.fsf@HIDDEN>
<87sfdbmmmh.fsf@HIDDEN> <838rf2opa0.fsf@HIDDEN>
<86ttxqdwyp.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Juri Linkov <juri@HIDDEN>
> Cc: sbaugh@HIDDEN, 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN
> Date: Sat, 08 Apr 2023 21:36:30 +0300
>
> > If this is for master, I'm fine with such changes. But if you intend
> > to request installing this on emacs-29, then I will object making
> > non-trivial changes in any code that is not specific to the M-<UP> and
>
> Actually, a change for base-suffix in minibuffer-completion-help
> is a trivial change. What counts as a non-trivial change would be
> changing the API in completion-all-completions.
>
> > M-<DOWN> bindings that are new in Emacs 29. I don't want to risk any
> > regressions in general-purpose completion code at this late stage.
>
> These changes are specific to the M-<UP> and M-<DOWN> bindings:
> completion-use-base-affixes is nil, and it's let-bound to t
> in M-<UP> (minibuffer-previous-completion) and M-<DOWN>
> (minibuffer-next-completion).
The change I reviewed and to which I responded was in code that was
there in Emacs 28 as well. Maybe we are talking about two different
sets of changes.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 8 Apr 2023 19:03:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 08 15:03:24 2023
Received: from localhost ([127.0.0.1]:59541 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1plDqO-0007Jr-5g
for submit <at> debbugs.gnu.org; Sat, 08 Apr 2023 15:03:24 -0400
Received: from relay10.mail.gandi.net ([217.70.178.230]:50003)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1plDqM-0007JP-8W
for 62700 <at> debbugs.gnu.org; Sat, 08 Apr 2023 15:03:22 -0400
Received: (Authenticated sender: juri@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id 92C11240002;
Sat, 8 Apr 2023 19:03:14 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <838rf2opa0.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 08 Apr
2023 09:34:47 +0300")
Organization: LINKOV.NET
References: <iery1n4sxm4.fsf@HIDDEN> <864jpsrgaz.fsf@HIDDEN>
<iersfdcstme.fsf@HIDDEN> <86h6tr4pi8.fsf@HIDDEN>
<87sfdbmmmh.fsf@HIDDEN> <838rf2opa0.fsf@HIDDEN>
Date: Sat, 08 Apr 2023 21:36:30 +0300
Message-ID: <86ttxqdwyp.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>> > Changing the API will definitely cause problems with backwards-compatibility.
>> > But maybe you could find a simple heuristic that would decide what base-suffix
>> > to set in minibuffer-completion-help? Then no API changes will be needed.
>>
>> Thank you for the guidance and suggestion.
>>
>> Here's one heuristic which works decently well:
>
> If this is for master, I'm fine with such changes. But if you intend
> to request installing this on emacs-29, then I will object making
> non-trivial changes in any code that is not specific to the M-<UP> and
Actually, a change for base-suffix in minibuffer-completion-help
is a trivial change. What counts as a non-trivial change would be
changing the API in completion-all-completions.
> M-<DOWN> bindings that are new in Emacs 29. I don't want to risk any
> regressions in general-purpose completion code at this late stage.
These changes are specific to the M-<UP> and M-<DOWN> bindings:
completion-use-base-affixes is nil, and it's let-bound to t
in M-<UP> (minibuffer-previous-completion) and M-<DOWN>
(minibuffer-next-completion).
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 8 Apr 2023 19:03:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 08 15:03:22 2023
Received: from localhost ([127.0.0.1]:59538 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1plDqL-0007Jd-O1
for submit <at> debbugs.gnu.org; Sat, 08 Apr 2023 15:03:22 -0400
Received: from relay8-d.mail.gandi.net ([217.70.183.201]:50979)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1plDqJ-0007JK-1r
for 62700 <at> debbugs.gnu.org; Sat, 08 Apr 2023 15:03:19 -0400
Received: (Authenticated sender: juri@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id 772F61BF207;
Sat, 8 Apr 2023 19:03:10 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: sbaugh@HIDDEN
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <87sfdbmmmh.fsf@HIDDEN> (sbaugh@HIDDEN's message of "Fri,
07 Apr 2023 21:02:47 +0000 (UTC)")
Organization: LINKOV.NET
References: <iery1n4sxm4.fsf@HIDDEN> <864jpsrgaz.fsf@HIDDEN>
<iersfdcstme.fsf@HIDDEN> <86h6tr4pi8.fsf@HIDDEN>
<87sfdbmmmh.fsf@HIDDEN>
Date: Sat, 08 Apr 2023 21:30:39 +0300
Message-ID: <864jpqdwrs.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
> Here's one heuristic which works decently well:
>
> The reasoning here is that if completion returns the full string which
> should be in the minibuffer, then we should replace the minibuffer with
> that string, so base-suffix should be "". But if we're completing only
> part of the string, base-suffix should be something else. AFAIK only
> file completion falls into the latter category, and it always completes
> just one component of a path, so I set base-suffix to not include the
> component of the path that point is in, so that completion replaces it
> entirely.
>
> I think this is basically a satisfactory heuristic, although I'm sure
> I'm missing some categories of completion besides file completion which
> complete only part of the string.
Thanks, this looks like a satisfactory heuristic indeed. It just needs
more testing for different categories of completion.
> Regardless of whether this is a satisfactory heuristic, it's revealed to
> me an unexpected behavior of a solution to this bug using base-suffix,
> which may or may not be fine: Point is moved to the end of the
> completion inserted.
>
> So e.g. if point is at | and I'm completing |-path, then when I choose
> the completion load-path, point will be at load-path| rather than
> load|-path. This isn't a huge issue but it might be a little annoying?
> I don't know if there's any way to fix this.
Maybe you could find another heuristic for insertion of completion?
The code is located in the same function 'minibuffer-completion-help':
(if (and (stringp start) (stringp end))
(progn
(delete-minibuffer-contents)
(insert start choice)
;; Keep point after completion before suffix
(save-excursion (insert end)))
Currently it keeps point before the suffix.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 8 Apr 2023 13:19:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 08 09:19:32 2023
Received: from localhost ([127.0.0.1]:58005 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pl8Tb-0000iW-Pt
for submit <at> debbugs.gnu.org; Sat, 08 Apr 2023 09:19:32 -0400
Received: from eggs.gnu.org ([209.51.188.92]:56360)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1pl8TZ-0000iD-Ce
for 62700 <at> debbugs.gnu.org; Sat, 08 Apr 2023 09:19:29 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pl8TS-0001fQ-PQ; Sat, 08 Apr 2023 09:19:22 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=M8dTkFmQ1yFUr4XC0UB7t9Fl4WXqt6vz4Mt3dJA47z8=; b=KwoFEMqC5QKJ
Tr/5JcVo/6ROwC/GNOKV8H6RTV2n5wW1WWpeFY6/8ZSVwLXdGvLetZoZ8w4X2kIT6nkrQG1j53Q69
FKjUtCA9iUqtZSdNX9SKatGe0rEXafkxRVzz/D1maVveZCJw017BeXTUY8dXUbNnni5DzZtHypjOx
eRgYewz9XJL6WId5EMta5c4QmnoiUQDiBMoARQBrWWjpfW7SM9tHiFaB9RRRcX4J4bAJUUsDXTGtn
aYHOKT+YMBO+heH/oHuKr6qgPOdgzD+bkJSi9G/TZluafAS/uH4Hh+f7BHFHP7+G2+PsAcPy5i/UD
bye+lXKAhQUY5uyD4TaG8w==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pl8TR-00053R-Ss; Sat, 08 Apr 2023 09:19:22 -0400
Date: Sat, 08 Apr 2023 16:19:56 +0300
Message-Id: <83pm8emryb.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: sbaugh@HIDDEN
In-Reply-To: <87o7nymyhw.fsf@HIDDEN> (sbaugh@HIDDEN)
Subject: Re: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion
behave unintuitively when point is not at end of buffer
References: <iery1n4sxm4.fsf@HIDDEN> <864jpsrgaz.fsf@HIDDEN>
<iersfdcstme.fsf@HIDDEN> <86h6tr4pi8.fsf@HIDDEN>
<87sfdbmmmh.fsf@HIDDEN> <838rf2opa0.fsf@HIDDEN>
<87o7nymyhw.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: sbaugh@HIDDEN
> Date: Sat, 08 Apr 2023 10:58:36 +0000 (UTC)
> Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
>
> Eli Zaretskii <eliz@HIDDEN> writes:
> >
> > If this is for master, I'm fine with such changes. But if you intend
> > to request installing this on emacs-29, then I will object making
> > non-trivial changes in any code that is not specific to the M-<UP> and
> > M-<DOWN> bindings that are new in Emacs 29. I don't want to risk any
> > regressions in general-purpose completion code at this late stage.
>
> OK, that's no problem, this can be done by just let-binding
> completion-base-affixes in minibuffer-{previous,next,choose}-completion
> so that it only affects new code.
Thanks.
> That will be a bit uglier to read so I'll do that if this approach
> seems reasonable with some review.
We can install the cleaner change on master, and the "uglier" one only
on the release branch.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 8 Apr 2023 10:58:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 08 06:58:45 2023
Received: from localhost ([127.0.0.1]:57818 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pl6HN-0000IV-2I
for submit <at> debbugs.gnu.org; Sat, 08 Apr 2023 06:58:45 -0400
Received: from s.wrqvwxzv.outbound-mail.sendgrid.net ([149.72.154.232]:10820)
by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from
<bounces+21787432-9544-62700=debbugs.gnu.org@HIDDEN>)
id 1pl6HK-0000IF-HF
for 62700 <at> debbugs.gnu.org; Sat, 08 Apr 2023 06:58:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com;
h=from:subject:in-reply-to:references:mime-version:to:cc:content-type:
content-transfer-encoding:cc:content-type:from:subject:to;
s=s1; bh=obqPaUbs1G+bz2KVrN2c3nzmouOBmIopXjiOQPjnWqA=;
b=oTaXY+HY/PQoqoMVdEoYLvqo92IDDYZbP2Hr8SvhxvU9r0xJ/KICtv7HsHtutm+a68XI
dlDGkgslLXMBwoHtbXvhW5/M9wCFQhGKL6OIKd9CmtgIshDgKSc886X+ZaKl0pgnaFlY4K
Jr8fqw/UfHec/SIuyY2jCF3uJ6zmfAYC/f94/uaLYcaIAKL99g0WlB7ISBrTe9SUJFaAjm
mJ3SXVxSGGh641gNwcfk7E0ddTKnTyUpxVfQg/CasJloPZ157i08ISNNAhdKqMmXhZC0/8
zvH94o5E4d5jw1dPOj03I9ZxJ2rhPlTWXosJ+WBK0JYJelQwujdIT7qe06kImCbQ==
Received: by filterdrecv-7457b4c9b5-8g6rq with SMTP id
filterdrecv-7457b4c9b5-8g6rq-1-643148DC-8
2023-04-08 10:58:36.431887909 +0000 UTC m=+3929067.403543096
Received: from earth.catern.com (unknown) by geopod-ismtpd-21 (SG) with ESMTP
id UUQFZKz-S4CXAeY6AQ_pIA Sat, 08 Apr 2023 10:58:36.180 +0000 (UTC)
X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost;
envelope-from=sbaugh@HIDDEN; receiver=<UNKNOWN>
Received: from localhost (localhost [IPv6:::1])
by earth.catern.com (Postfix) with ESMTPSA id B801E60087;
Sat, 8 Apr 2023 06:58:35 -0400 (EDT)
From: sbaugh@HIDDEN
Subject: Re: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion
behave unintuitively when point is not at end of buffer
In-Reply-To: <838rf2opa0.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 08 Apr
2023 09:34:47 +0300")
References: <iery1n4sxm4.fsf@HIDDEN> <864jpsrgaz.fsf@HIDDEN>
<iersfdcstme.fsf@HIDDEN> <86h6tr4pi8.fsf@HIDDEN>
<87sfdbmmmh.fsf@HIDDEN> <838rf2opa0.fsf@HIDDEN>
Date: Sat, 08 Apr 2023 10:58:36 +0000 (UTC)
Message-ID: <87o7nymyhw.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
X-SG-EID: =?us-ascii?Q?ZgbRq7gjGrt0q=2FPjvxk7wM0yQFRdOkTJAtEbkjCkHbIuvspdchYWlOzP=2FLeaPJ?=
=?us-ascii?Q?BY99B=2Fwt77jJyMusF8N=2F+KTehVkrDIlPqzSES9Z?=
=?us-ascii?Q?YqLzIz35CcD2Nlugxo6OPzl5u7NFIj9yVon74Kb?=
=?us-ascii?Q?ZCpns+cU8uVEeJEnLlNkHZtIjstJ4at+wGdg2jf?=
=?us-ascii?Q?oQJbOdHb2AdFMWS=2FqijDyARKMxK28II3kEQ=3D=3D?=
To: Eli Zaretskii <eliz@HIDDEN>
X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> Cc:
62700 <at> debbugs.gnu.org,
Spencer Baugh <sbaugh@HIDDEN> >> From: sbaugh@HIDDEN >> Date:
Fri, 07 Apr 2023 21:02:47 +0000 (UTC) >> >> Juri Linkov <ju [...]
Content analysis details: (1.2 points, 10.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in
bl.spamcop.net
[Blocked - see <https://www.spamcop.net/bl.shtml?149.72.154.232>]
0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record
-0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)
[149.72.154.232 listed in wl.mailspike.net]
-0.0 SPF_PASS SPF: sender matches SPF record
0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay
lines
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)
Eli Zaretskii <eliz@HIDDEN> writes:
>> Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>
>> From: sbaugh@HIDDEN
>> Date: Fri, 07 Apr 2023 21:02:47 +0000 (UTC)
>>
>> Juri Linkov <juri@HIDDEN> writes:
>> > Changing the API will definitely cause problems with backwards-compatibility.
>> > But maybe you could find a simple heuristic that would decide what base-suffix
>> > to set in minibuffer-completion-help? Then no API changes will be needed.
>>
>> Thank you for the guidance and suggestion.
>>
>> Here's one heuristic which works decently well:
>
> If this is for master, I'm fine with such changes. But if you intend
> to request installing this on emacs-29, then I will object making
> non-trivial changes in any code that is not specific to the M-<UP> and
> M-<DOWN> bindings that are new in Emacs 29. I don't want to risk any
> regressions in general-purpose completion code at this late stage.
OK, that's no problem, this can be done by just let-binding
completion-base-affixes in minibuffer-{previous,next,choose}-completion
so that it only affects new code. That will be a bit uglier to read so
I'll do that if this approach seems reasonable with some review.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 8 Apr 2023 06:34:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 08 02:34:37 2023
Received: from localhost ([127.0.0.1]:57555 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pl29l-0006vP-4y
for submit <at> debbugs.gnu.org; Sat, 08 Apr 2023 02:34:37 -0400
Received: from eggs.gnu.org ([209.51.188.92]:37072)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1pl29g-0006vA-KK
for 62700 <at> debbugs.gnu.org; Sat, 08 Apr 2023 02:34:36 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pl29R-0001nI-0j; Sat, 08 Apr 2023 02:34:26 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=aZ8ZoQq7MhDkefnykFRE46fm89Tj8JC11GZrdaAZf98=; b=i+YL8G0OoF1d
i5Ud9Krr8evtBrgzM6GSQED8wwI7Ruz/zomvwvwX56ffdYQ5UEpd9/x3n939XsF0UY+6Izau2Nlsq
ah0XBXiwHQFMlIbV3bYG1Zo0Xdyktb86jSZJRxw4trYEibxhnX6jk0fyD5htj4xJL74eIM0vy4KkW
XXeafnxVFF0M/10LPwTF9+7NfxggvlRcSxgskyot+kvNVTyZLGh3EsfZdWhbWLXeALGIqbp+LtxRH
+IDmGtkRUM1krlmryU1CuRYSk87bC80wnNP+p3WnhB0XTH1caHsOWAQBwjN1ZsekzxKVHPNsPJJsC
wnat1cTBT3A+2aRUFQ1jOA==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pl29N-0006uh-Bb; Sat, 08 Apr 2023 02:34:13 -0400
Date: Sat, 08 Apr 2023 09:34:47 +0300
Message-Id: <838rf2opa0.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: sbaugh@HIDDEN
In-Reply-To: <87sfdbmmmh.fsf@HIDDEN> (sbaugh@HIDDEN)
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively
when point is not at end of buffer
References: <iery1n4sxm4.fsf@HIDDEN> <864jpsrgaz.fsf@HIDDEN>
<iersfdcstme.fsf@HIDDEN> <86h6tr4pi8.fsf@HIDDEN>
<87sfdbmmmh.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, sbaugh@HIDDEN, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>
> From: sbaugh@HIDDEN
> Date: Fri, 07 Apr 2023 21:02:47 +0000 (UTC)
>
> Juri Linkov <juri@HIDDEN> writes:
> > Changing the API will definitely cause problems with backwards-compatibility.
> > But maybe you could find a simple heuristic that would decide what base-suffix
> > to set in minibuffer-completion-help? Then no API changes will be needed.
>
> Thank you for the guidance and suggestion.
>
> Here's one heuristic which works decently well:
If this is for master, I'm fine with such changes. But if you intend
to request installing this on emacs-29, then I will object making
non-trivial changes in any code that is not specific to the M-<UP> and
M-<DOWN> bindings that are new in Emacs 29. I don't want to risk any
regressions in general-purpose completion code at this late stage.
Thanks.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 7 Apr 2023 21:02:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 07 17:02:56 2023
Received: from localhost ([127.0.0.1]:57296 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pktEV-0007lf-Ji
for submit <at> debbugs.gnu.org; Fri, 07 Apr 2023 17:02:55 -0400
Received: from s.wrqvtzvf.outbound-mail.sendgrid.net ([149.72.126.143]:38654)
by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from
<bounces+21787432-9544-62700=debbugs.gnu.org@HIDDEN>)
id 1pktET-0007lQ-LM
for 62700 <at> debbugs.gnu.org; Fri, 07 Apr 2023 17:02:54 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com;
h=from:subject:in-reply-to:references:mime-version:to:cc:content-type:
content-transfer-encoding:cc:content-type:from:subject:to;
s=s1; bh=IKZRQ/Sb6oY9hAncGw8mCt5QtAasOHcCjASRRmFCp6Y=;
b=v2fAO3tKfFkCa0d2SIh4bRz2zoJJ9Mt8YlEJPiu9XAebllbn0y4MYK7h0wRKHv6Nm7aT
W2ZF2Orcops81n7FkkdzL9cnEJcMdK0mYv59sM7bkOJmzv7EMaOnALP+3Ec5FufdxIL2ZE
wF7Rz3CGn/TWMAC+oNtP7t+6eG9+wMESWzvIEGt/+1cwKDnhQB9LQtFK17+50HOF301LbY
53pJNVYeW38WyAMSvgjwrhw0PtjBx0lC5h2gx/2ZFZFjPYnx8vTWKDOWQ6GIr9U7AhxfI0
J0eOH+cnAQtq2Exn4kvdcby1kqUqnye+z5cQyxLsgp/AmPcUBaPe3Utt+EAidviQ==
Received: by filterdrecv-7946957d94-bqdbw with SMTP id
filterdrecv-7946957d94-bqdbw-1-643084F7-61
2023-04-07 21:02:47.552718378 +0000 UTC m=+3879070.604264158
Received: from earth.catern.com (unknown) by geopod-ismtpd-11 (SG) with ESMTP
id JO6dp9n1QlKqyCDZDQxW0g Fri, 07 Apr 2023 21:02:47.213 +0000 (UTC)
X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost;
envelope-from=sbaugh@HIDDEN; receiver=<UNKNOWN>
Received: from localhost (localhost [IPv6:::1])
by earth.catern.com (Postfix) with ESMTPSA id A604E60087;
Fri, 7 Apr 2023 17:02:46 -0400 (EDT)
From: sbaugh@HIDDEN
Subject: Re: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion
behave unintuitively when point is not at end of buffer
In-Reply-To: <86h6tr4pi8.fsf@HIDDEN> (Juri Linkov's message of "Fri,
07 Apr 2023 19:37:51 +0300")
References: <iery1n4sxm4.fsf@HIDDEN> <864jpsrgaz.fsf@HIDDEN>
<iersfdcstme.fsf@HIDDEN> <86h6tr4pi8.fsf@HIDDEN>
Date: Fri, 07 Apr 2023 21:02:47 +0000 (UTC)
Message-ID: <87sfdbmmmh.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
X-SG-EID: =?us-ascii?Q?ZgbRq7gjGrt0q=2FPjvxk7wM0yQFRdOkTJAtEbkjCkHbLf9xoDvZI=2FsjLbat9p99?=
=?us-ascii?Q?rIMSCWUuMOEJBUt+p8e4ouUNyZ2rEwGmbs257Bh?=
=?us-ascii?Q?oVrZyg=2FbRxx07rLJrfGGTyOP=2Fi523qZr0f=2FvGuI?=
=?us-ascii?Q?K5=2FggOmpcP5+HRir4gq9INUc9Q99kDbGoYMki1S?=
=?us-ascii?Q?Wm=2FsG6B6KAwse7PrftWKNoZPrGQvdJKM+dA=3D=3D?=
To: Juri Linkov <juri@HIDDEN>
X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Juri Linkov <juri@HIDDEN> writes:
> Changing the API will definitely cause problems with backwards-compatibility.
> But maybe you could find a simple heuristic that would decide what base-suffix
> to set in minibuffer-completion-help? Then no API changes will be needed.
Thank you for the guidance and suggestion.
Here's one heuristic which works decently well:
diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index 21d4607e7cf..dfb06b5b88f 100644
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -2374,7 +2374,11 @@ minibuffer-completion-help
(prefix (unless (zerop base-size) (substring string 0 base-size)))
(base-prefix (buffer-substring (minibuffer--completion-prompt-end)
(+ start base-size)))
- (base-suffix (buffer-substring (point) (point-max)))
+ (base-suffix
+ (if (eq (alist-get 'category (cdr md)) 'file)
+ (buffer-substring (save-excursion (search-forward "/" nil t) (point))
+ (point-max))
+ ""))
(all-md (completion--metadata (buffer-substring-no-properties
start (point))
base-size md
The reasoning here is that if completion returns the full string which
should be in the minibuffer, then we should replace the minibuffer with
that string, so base-suffix should be "". But if we're completing only
part of the string, base-suffix should be something else. AFAIK only
file completion falls into the latter category, and it always completes
just one component of a path, so I set base-suffix to not include the
component of the path that point is in, so that completion replaces it
entirely.
I think this is basically a satisfactory heuristic, although I'm sure
I'm missing some categories of completion besides file completion which
complete only part of the string.
Regardless of whether this is a satisfactory heuristic, it's revealed to
me an unexpected behavior of a solution to this bug using base-suffix,
which may or may not be fine: Point is moved to the end of the
completion inserted.
So e.g. if point is at | and I'm completing |-path, then when I choose
the completion load-path, point will be at load-path| rather than
load|-path. This isn't a huge issue but it might be a little annoying?
I don't know if there's any way to fix this.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 7 Apr 2023 16:42:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 07 12:42:05 2023
Received: from localhost ([127.0.0.1]:57144 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pkpA4-0000XV-R0
for submit <at> debbugs.gnu.org; Fri, 07 Apr 2023 12:42:05 -0400
Received: from relay11.mail.gandi.net ([217.70.178.231]:38875)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1pkpA0-0000Wx-HA
for 62700 <at> debbugs.gnu.org; Fri, 07 Apr 2023 12:42:04 -0400
Received: (Authenticated sender: juri@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id 26AC6100003;
Fri, 7 Apr 2023 16:41:52 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Spencer Baugh <sbaugh@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <iersfdcstme.fsf@HIDDEN> (Spencer Baugh's message of
"Thu, 06 Apr 2023 15:22:49 -0400")
Organization: LINKOV.NET
References: <iery1n4sxm4.fsf@HIDDEN> <864jpsrgaz.fsf@HIDDEN>
<iersfdcstme.fsf@HIDDEN>
Date: Fri, 07 Apr 2023 19:37:51 +0300
Message-ID: <86h6tr4pi8.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>> I agree that it would be nice to fix this in Emacs 29.
>> But the problem is that this would require non-trivial changes.
>> We need to apply a small part of the patch mentioned in
>> bug#47711, bug#48356, bug#48841, bug#60313 and located at
>> https://lists.gnu.org/archive/html/emacs-devel/2021-08/msg00412.html
>> that implements the following FIXME item in 'completion-all-completions':
>
> Any updates on the status of this patch? I see you asked the same thing
> a year ago in one of those bugs.
A year ago I had a clear understanding how to do this but unfortunately
now forgot the details. The idea was to return from completion-all-completions
not only '("string" . number) where number is the start of the completion position,
but something like '("string" . (number1 number2)) where the second number is
the end of the completion position.
completion-all-completions is called from minibuffer-completion-help.
Then the second number could help to set the right base-suffix in
(setq-local completion-base-affixes
(list base-prefix base-suffix))
This base-suffix is used later by M-<up> and M-<down>.
When here base-suffix is "", then your test case will be fixed.
However, non-empty base-suffix is necessary in other cases
such as mentioned in bug#48356:
~/emacs/master/li|/calc
> I can try to prepare a more minimal version of this patch, just targeted
> at adding the ability to return the end of the completion position.
>
> Do you have any advice on an appropriate API for that? An alist as in
> that patch seems reasonable to me, but perhaps there's an even simpler
> approach?
Changing the API will definitely cause problems with backwards-compatibility.
But maybe you could find a simple heuristic that would decide what base-suffix
to set in minibuffer-completion-help? Then no API changes will be needed.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 6 Apr 2023 20:42:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 06 16:42:28 2023
Received: from localhost ([127.0.0.1]:55287 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pkWRA-0006R3-6a
for submit <at> debbugs.gnu.org; Thu, 06 Apr 2023 16:42:28 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:37401)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1pkWR5-0006Qm-T0
for 62700 <at> debbugs.gnu.org; Thu, 06 Apr 2023 16:42:26 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 316341000DC;
Thu, 6 Apr 2023 16:42:18 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A84641000BE;
Thu, 6 Apr 2023 16:42:16 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1680813736;
bh=kkqZCWRN5Q8GEmIWf/ouBsuP5ufDvytHi4VKboZ5fP0=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=pnvsJ38dnyKwwhHJRA4Xzie7dmuLLJtiuf/0XfUupFHyazoE0ZMWoG35rPIosW+/K
8NuPbuj5lfS6FqvWArQIj/x2p1DxdDgZuUOnsgMx936q+/PelhzRbkG3lf6gBH3B88
t5SY0mjvmzgnF8mbITvgGbK9/xNC/ysxDl7sKohrdN/ookDP3VwfeWbmSl5qpvc7Ue
6n5zM13NCeGVXAeTVCYwqinNmD4L7fKh52qQCqWf0BOtHe/s6yGPxieo6ycVVgB5ce
WfVj0fY+YDdUj5JcUdW6oDSpOAarq+EMtFbfd1KMEfWIwAOnFn6wq7nu+NnttdviXq
Be/3/TcPuJnfQ==
Received: from alfajor (unknown [45.44.229.252])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 74FAD1233A5;
Thu, 6 Apr 2023 16:42:16 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <83jzyoq040.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 06 Apr
2023 22:30:55 +0300")
Message-ID: <jwvsfdchhwc.fsf-monnier+emacs@HIDDEN>
References: <iery1n4sxm4.fsf@HIDDEN> <83r0swq39p.fsf@HIDDEN>
<ierv8i8suql.fsf@HIDDEN> <83jzyoq040.fsf@HIDDEN>
Date: Thu, 06 Apr 2023 16:42:13 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.004 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, Spencer Baugh <sbaugh@HIDDEN>,
juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
>> > I think it's the intended behavior. In this case, it looks not
>> > useful, because the string you typed before starting to use M-<UP> and
>> > M-<DOWN> happens to be at the end of each completion candidate. But
>> > this is not the only situation possible. Basically, completion always
>> > modifies only the text before point, leaving what's after point
>> > intact, so that the user could have after point stuff that completion
>> > should ignore, and that eventually will be appended to the selected
>> > candidate.
>>
>> Could you give an example of when this would be desirable?
>
> When completing on shell commands, for example: the text after point
> is usually the command-line arguments to the command, and the
> completion is on command names or on some file name.
That shouldn't be a worry: when you complete shell commands, you're not
really using "minibuffer completion" (as is the case in `C-h v`) but
"in-buffer completion" (i.e. TAB is bound to `completion-at-point`
rather than to `minibuffer-complete`), so the completion code knows that
you're only completing the command part and will (hopefully) be careful
not to touch anything before or after it.
More specifically, in `M-!` if you're at
echo hello; e!s world
where `!` shows where point is, the *Completions* buffer should show all
command that start with `e` and end in `s` (assuming we're using
`basic` or `partial-completion` styles) and if you use
minibuffer-{previous,next,choose}-completion, they should replace `e!s`
with the selection. IOW it should neither "leave the text after point
alone" nor "replace all the text after point".
>> For example, suppose I wanted to wanted to complete filenames starting
>> with x and ending in .c.
> I don't think the default completion supports such functionality, at
> least not with the styles we have by default in completion-styles.
The behavior Spencer describes is very much part of our default (it's
provided both by the `basic` and the `partial-completion` styles, both
of which are enabled by default).
Stefan
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 6 Apr 2023 19:30:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 06 15:30:37 2023
Received: from localhost ([127.0.0.1]:55184 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pkVJc-0007YF-Ka
for submit <at> debbugs.gnu.org; Thu, 06 Apr 2023 15:30:37 -0400
Received: from eggs.gnu.org ([209.51.188.92]:48104)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1pkVJX-0007Xz-RK
for 62700 <at> debbugs.gnu.org; Thu, 06 Apr 2023 15:30:34 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pkVJS-0002F5-20; Thu, 06 Apr 2023 15:30:26 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=NqwcnP0gWs0EU5xTVeFExiZvSQM6g3o5I1EtzLtq4Cc=; b=SUD0dKBskuTz
kOlAJ5RsnnsQkr/v9ZAzcQCJaovl7dd4J2XQyey4A63WTK7tY8MEYVRzI/eKFA6T4l4qrOhv6Jfv8
ycNizGTnR67ZRg5rk/xpqJBDKrHiI859H00dNDQWCWn1eK2JabPqPQOTUCHcRLGtv1ZPXCgWFi5bF
gkvEJt5boBEjytWCgYTtiP0f5CBi1t430PjM+TOQZFLUaZ/oxgctqLCUO4OSJBI9c8HUzYCyasccL
FCiBVNeJErBiDiHOCk62PgSBcRk6NvNY3zxlVOoASugcLEc0A4BlArSSywUO4Aay67vO2zf5iIUjD
pIVOMYVHpvANTgxpuq+paA==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pkVJR-0005Js-Ig; Thu, 06 Apr 2023 15:30:25 -0400
Date: Thu, 06 Apr 2023 22:30:55 +0300
Message-Id: <83jzyoq040.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Spencer Baugh <sbaugh@HIDDEN>,
Stefan Monnier <monnier@HIDDEN>
In-Reply-To: <ierv8i8suql.fsf@HIDDEN> (message from Spencer Baugh on
Thu, 06 Apr 2023 14:58:42 -0400)
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
References: <iery1n4sxm4.fsf@HIDDEN> <83r0swq39p.fsf@HIDDEN>
<ierv8i8suql.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Spencer Baugh <sbaugh@HIDDEN>
> Cc: 62700 <at> debbugs.gnu.org, juri@HIDDEN
> Date: Thu, 06 Apr 2023 14:58:42 -0400
>
> Eli Zaretskii <eliz@HIDDEN> writes:
>
> >> I think this is basically just a bug.
> >
> > I think it's the intended behavior. In this case, it looks not
> > useful, because the string you typed before starting to use M-<UP> and
> > M-<DOWN> happens to be at the end of each completion candidate. But
> > this is not the only situation possible. Basically, completion always
> > modifies only the text before point, leaving what's after point
> > intact, so that the user could have after point stuff that completion
> > should ignore, and that eventually will be appended to the selected
> > candidate.
>
> Could you give an example of when this would be desirable?
When completing on shell commands, for example: the text after point
is usually the command-line arguments to the command, and the
completion is on command names or on some file name.
> >> If this is intentional for some reason, I think the behavior should
> >> definitely be changed before Emacs 29 is released. Moving point around
> >> in the minibuffer while completing is an important part of using the
> >> default completion-styles
> >
> > It is? why?
>
> "basic" and "emacs22" are default completion-styles, and they both treat
> text after point differently from text before point.
This is intentional, AFAIK.
> For example, suppose I wanted to wanted to complete filenames starting
> with x and ending in .c.
I don't think the default completion supports such functionality, at
least not with the styles we have by default in completion-styles.
But maybe I'm missing something; adding Stefan to the discussion.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 6 Apr 2023 19:22:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 06 15:22:56 2023
Received: from localhost ([127.0.0.1]:55173 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pkVCC-0007Jj-DM
for submit <at> debbugs.gnu.org; Thu, 06 Apr 2023 15:22:56 -0400
Received: from mxout5.mail.janestreet.com ([64.215.233.18]:49217)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <sbaugh@HIDDEN>) id 1pkVCB-0007JW-1p
for 62700 <at> debbugs.gnu.org; Thu, 06 Apr 2023 15:22:55 -0400
From: Spencer Baugh <sbaugh@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <864jpsrgaz.fsf@HIDDEN> (Juri Linkov's message of "Thu,
06 Apr 2023 21:55:48 +0300")
References: <iery1n4sxm4.fsf@HIDDEN> <864jpsrgaz.fsf@HIDDEN>
Date: Thu, 06 Apr 2023 15:22:49 -0400
Message-ID: <iersfdcstme.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Juri Linkov <juri@HIDDEN> writes:
>> 6. C-h v -path
>> 7. C-a to move point to before -path
>> 8. <tab> to show completions of variables ending in -path
>> 9. Use M-<up> and M-<down> to switch between completions. Now as you
>> switch completions, they are inserted at point, *without* replacing the
>> text already in the buffer. So e.g. the minibuffer will contain
>> "load-path-path".
>> 10. Likewise, if you (setq minibuffer-completion-auto-choose nil), M-RET
>> inserts the completion string at point, without replacing the text in
>> the minibuffer, so you will get "load-path-path".
>>
>> I think this is basically just a bug. Hopefully we can fix this before
>> Emacs 29 is released, because this is the last thing which stops these
>> new commands from being a really great improvement to the Emacs
>> completion defaults.
>
> I agree that it would be nice to fix this in Emacs 29.
> But the problem is that this would require non-trivial changes.
> We need to apply a small part of the patch mentioned in
> bug#47711, bug#48356, bug#48841, bug#60313 and located at
> https://lists.gnu.org/archive/html/emacs-devel/2021-08/msg00412.html
> that implements the following FIXME item in 'completion-all-completions':
>
> ;; FIXME: We need to additionally return the info needed for the
> ;; second part of completion-base-position.
>
> When it will return from 'completion-all-completions' not only the start
> position of a completion, but also its end, then we could use this
> additional information for M-<up> and M-<down>.
Any updates on the status of this patch? I see you asked the same thing
a year ago in one of those bugs.
I can try to prepare a more minimal version of this patch, just targeted
at adding the ability to return the end of the completion position.
Do you have any advice on an appropriate API for that? An alist as in
that patch seems reasonable to me, but perhaps there's an even simpler
approach?
(BTW, the reason I really want to fix this in Emacs 29 is that I don't
want us to be concerned with being backwards-compatible with the current
behavior in 29, which seems much worse to me. But if we won't be
concerned about that, doing this in 30 seems totally fine. I can just
backport it for my users anyway :) )
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 6 Apr 2023 19:00:21 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 06 15:00:21 2023
Received: from localhost ([127.0.0.1]:55168 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pkUqL-0006o5-65
for submit <at> debbugs.gnu.org; Thu, 06 Apr 2023 15:00:21 -0400
Received: from relay1-d.mail.gandi.net ([217.70.183.193]:44095)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <juri@HIDDEN>) id 1pkUqJ-0006ns-KK
for 62700 <at> debbugs.gnu.org; Thu, 06 Apr 2023 15:00:20 -0400
Received: (Authenticated sender: juri@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id BF5C324000B;
Thu, 6 Apr 2023 19:00:11 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Spencer Baugh <sbaugh@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave
unintuitively when point is not at end of buffer
In-Reply-To: <iery1n4sxm4.fsf@HIDDEN> (Spencer Baugh's message of
"Thu, 06 Apr 2023 13:56:35 -0400")
Organization: LINKOV.NET
References: <iery1n4sxm4.fsf@HIDDEN>
Date: Thu, 06 Apr 2023 21:55:48 +0300
Message-ID: <864jpsrgaz.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
> 6. C-h v -path
> 7. C-a to move point to before -path
> 8. <tab> to show completions of variables ending in -path
> 9. Use M-<up> and M-<down> to switch between completions. Now as you
> switch completions, they are inserted at point, *without* replacing the
> text already in the buffer. So e.g. the minibuffer will contain
> "load-path-path".
> 10. Likewise, if you (setq minibuffer-completion-auto-choose nil), M-RET
> inserts the completion string at point, without replacing the text in
> the minibuffer, so you will get "load-path-path".
>
> I think this is basically just a bug. Hopefully we can fix this before
> Emacs 29 is released, because this is the last thing which stops these
> new commands from being a really great improvement to the Emacs
> completion defaults.
I agree that it would be nice to fix this in Emacs 29.
But the problem is that this would require non-trivial changes.
We need to apply a small part of the patch mentioned in
bug#47711, bug#48356, bug#48841, bug#60313 and located at
https://lists.gnu.org/archive/html/emacs-devel/2021-08/msg00412.html
that implements the following FIXME item in 'completion-all-completions':
;; FIXME: We need to additionally return the info needed for the
;; second part of completion-base-position.
When it will return from 'completion-all-completions' not only the start
position of a completion, but also its end, then we could use this
additional information for M-<up> and M-<down>.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 6 Apr 2023 18:58:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 06 14:58:52 2023
Received: from localhost ([127.0.0.1]:55164 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pkUot-0006k4-KI
for submit <at> debbugs.gnu.org; Thu, 06 Apr 2023 14:58:52 -0400
Received: from mxout5.mail.janestreet.com ([64.215.233.18]:47933)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <sbaugh@HIDDEN>) id 1pkUoq-0006jo-AH
for 62700 <at> debbugs.gnu.org; Thu, 06 Apr 2023 14:58:50 -0400
From: Spencer Baugh <sbaugh@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively when
point is not at end of buffer
In-Reply-To: <83r0swq39p.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 06 Apr
2023 21:22:42 +0300")
References: <iery1n4sxm4.fsf@HIDDEN> <83r0swq39p.fsf@HIDDEN>
Date: Thu, 06 Apr 2023 14:58:42 -0400
Message-ID: <ierv8i8suql.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Eli Zaretskii <eliz@HIDDEN> writes:
>> Cc: Juri Linkov <juri@HIDDEN>
>> From: Spencer Baugh <sbaugh@HIDDEN>
>> Date: Thu, 06 Apr 2023 13:56:35 -0400
>>
>> 6. C-h v -path
>> 7. C-a to move point to before -path
>> 8. <tab> to show completions of variables ending in -path
>> 9. Use M-<up> and M-<down> to switch between completions. Now as you
>> switch completions, they are inserted at point, *without* replacing the
>> text already in the buffer. So e.g. the minibuffer will contain
>> "load-path-path".
>> 10. Likewise, if you (setq minibuffer-completion-auto-choose nil), M-RET
>> inserts the completion string at point, without replacing the text in
>> the minibuffer, so you will get "load-path-path".
>>
>> I think this is basically just a bug.
>
> I think it's the intended behavior. In this case, it looks not
> useful, because the string you typed before starting to use M-<UP> and
> M-<DOWN> happens to be at the end of each completion candidate. But
> this is not the only situation possible. Basically, completion always
> modifies only the text before point, leaving what's after point
> intact, so that the user could have after point stuff that completion
> should ignore, and that eventually will be appended to the selected
> candidate.
Could you give an example of when this would be desirable?
>> Hopefully we can fix this before Emacs 29 is released, because this
>> is the last thing which stops these new commands from being a really
>> great improvement to the Emacs completion defaults.
>
> Why did you need to move point to the beginning of what you typed to
> begin with? Unless you explain that, I don't see how we can consider
> this issue important enough to fix at all, let alone for Emacs 29.
>
>> If this is intentional for some reason, I think the behavior should
>> definitely be changed before Emacs 29 is released. Moving point around
>> in the minibuffer while completing is an important part of using the
>> default completion-styles
>
> It is? why?
"basic" and "emacs22" are default completion-styles, and they both treat
text after point differently from text before point.
For example, suppose I wanted to wanted to complete filenames starting
with x and ending in .c. The way I would do this with the default
completion-styles is enter "x.c", placing point just before ".", and hit
TAB. (I could equivalently do x*.c and hit TAB, but that will move
point to right after the "*" and run into this same issue!)
Actually, * is another good example. If I input a * in my string to be
completed (which is provided by partial-completion, a default
completion-style), then when I hit TAB point is moved back to the site
of the *. This makes * very hard to use at the same time as
minibuffer-{previous,next}-completion, because of their behavior of not
modifying the text after point.
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at 62700) by debbugs.gnu.org; 6 Apr 2023 18:22:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 06 14:22:23 2023
Received: from localhost ([127.0.0.1]:55121 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pkUFb-0005Sv-3C
for submit <at> debbugs.gnu.org; Thu, 06 Apr 2023 14:22:23 -0400
Received: from eggs.gnu.org ([209.51.188.92]:55620)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1pkUFY-0005SX-Lo
for 62700 <at> debbugs.gnu.org; Thu, 06 Apr 2023 14:22:21 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pkUFR-0007Gg-Tb; Thu, 06 Apr 2023 14:22:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=gSWVzKoWrLCkxjnT33kVfcNKTYvYdCxOmw0uZfz1Tqs=; b=biVHDr2ODu/T
EzQUkAyPn21GjzuTxjf7w9fk//yNjWKlszYm74TWrnUqCI2lSrAWDqE5Qlp7sYtlNmYNI4N0M2srE
rg3toprSvnBP7R/7Kowj/4AnsyM3u2IwyXVUNT5LVFQ9XFZZNdQSJ5cFb+RAMlrbGwM7xo+2Cvc1C
a9f0b03Sv1VdLE0b+POgjOQcsyKotuAtQGsiju0T2tNh3dite2EsVcEOGV4c/1ns0d5sUOf033KrR
K4fIsGSCKFY2Tzp5q6qpOA06cmwOLD/aqAiWxQ58uLTFU1Pcn0YED/K0N9aB9IlBULkuiNTdd8fLc
tpBcZQxP3Ko88iAiOYoIGw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1pkUFR-0005L5-7c; Thu, 06 Apr 2023 14:22:13 -0400
Date: Thu, 06 Apr 2023 21:22:42 +0300
Message-Id: <83r0swq39p.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Spencer Baugh <sbaugh@HIDDEN>
In-Reply-To: <iery1n4sxm4.fsf@HIDDEN> (message from Spencer Baugh on
Thu, 06 Apr 2023 13:56:35 -0400)
Subject: Re: bug#62700: 29.0.60;
minibuffer-{previous,next,choose}-completion behave unintuitively
when point is not at end of buffer
References: <iery1n4sxm4.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62700
Cc: 62700 <at> debbugs.gnu.org, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> Cc: Juri Linkov <juri@HIDDEN>
> From: Spencer Baugh <sbaugh@HIDDEN>
> Date: Thu, 06 Apr 2023 13:56:35 -0400
>
> 6. C-h v -path
> 7. C-a to move point to before -path
> 8. <tab> to show completions of variables ending in -path
> 9. Use M-<up> and M-<down> to switch between completions. Now as you
> switch completions, they are inserted at point, *without* replacing the
> text already in the buffer. So e.g. the minibuffer will contain
> "load-path-path".
> 10. Likewise, if you (setq minibuffer-completion-auto-choose nil), M-RET
> inserts the completion string at point, without replacing the text in
> the minibuffer, so you will get "load-path-path".
>
> I think this is basically just a bug.
I think it's the intended behavior. In this case, it looks not
useful, because the string you typed before starting to use M-<UP> and
M-<DOWN> happens to be at the end of each completion candidate. But
this is not the only situation possible. Basically, completion always
modifies only the text before point, leaving what's after point
intact, so that the user could have after point stuff that completion
should ignore, and that eventually will be appended to the selected
candidate.
> Hopefully we can fix this before Emacs 29 is released, because this
> is the last thing which stops these new commands from being a really
> great improvement to the Emacs completion defaults.
Why did you need to move point to the beginning of what you typed to
begin with? Unless you explain that, I don't see how we can consider
this issue important enough to fix at all, let alone for Emacs 29.
> If this is intentional for some reason, I think the behavior should
> definitely be changed before Emacs 29 is released. Moving point around
> in the minibuffer while completing is an important part of using the
> default completion-styles
It is? why?
bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 6 Apr 2023 17:56:46 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Apr 06 13:56:46 2023
Received: from localhost ([127.0.0.1]:55098 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pkTqm-0004f5-Sr
for submit <at> debbugs.gnu.org; Thu, 06 Apr 2023 13:56:46 -0400
Received: from lists.gnu.org ([209.51.188.17]:57070)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <sbaugh@HIDDEN>) id 1pkTqi-0004et-Jl
for submit <at> debbugs.gnu.org; Thu, 06 Apr 2023 13:56:43 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <sbaugh@HIDDEN>)
id 1pkTqh-00080u-RR
for bug-gnu-emacs@HIDDEN; Thu, 06 Apr 2023 13:56:39 -0400
Received: from mxout5.mail.janestreet.com ([64.215.233.18])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <sbaugh@HIDDEN>)
id 1pkTqe-0002u8-Rd
for bug-gnu-emacs@HIDDEN; Thu, 06 Apr 2023 13:56:39 -0400
From: Spencer Baugh <sbaugh@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 29.0.60; minibuffer-{previous,next,choose}-completion behave
unintuitively when point is not at end of buffer
Date: Thu, 06 Apr 2023 13:56:35 -0400
Message-ID: <iery1n4sxm4.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=64.215.233.18; envelope-from=sbaugh@HIDDEN;
helo=mxout5.mail.janestreet.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)
1. emacs -Q
2. C-h v -path
3. <tab> to show completions of variables containing the string -path
4. Use M-<up> and M-<down> to switch between completions. Note that as
you switch completions, they replace the text already in the minibuffer.
5. C-g
6. C-h v -path
7. C-a to move point to before -path
8. <tab> to show completions of variables ending in -path
9. Use M-<up> and M-<down> to switch between completions. Now as you
switch completions, they are inserted at point, *without* replacing the
text already in the buffer. So e.g. the minibuffer will contain
"load-path-path".
10. Likewise, if you (setq minibuffer-completion-auto-choose nil), M-RET
inserts the completion string at point, without replacing the text in
the minibuffer, so you will get "load-path-path".
I think this is basically just a bug. Hopefully we can fix this before
Emacs 29 is released, because this is the last thing which stops these
new commands from being a really great improvement to the Emacs
completion defaults.
If this is intentional for some reason, I think the behavior should
definitely be changed before Emacs 29 is released. Moving point around
in the minibuffer while completing is an important part of using the
default completion-styles, so we should not make that harder. Other
completion packages for Emacs do not have this behavior, e.g. icomplete
or ido.
In GNU Emacs 29.0.60 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.15.12, Xaw scroll bars) of 2023-03-13 built on
igm-qws-u22796a
Repository revision: e759905d2e0828eac4c8164b09113b40f6899656
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: CentOS Linux 7 (Core)
Configured using:
'configure --with-x-toolkit=lucid --with-modules
--with-gif=ifavailable'
Configured features:
CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND
SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XINPUT2 XPM LUCID
ZLIB
Important settings:
value of $LANG: en_US.UTF-8
locale-coding-system: utf-8-unix
Major mode: Dired by name
Minor modes in effect:
jane-fe-minor-mode: t
editorconfig-mode: t
dired-omit-mode: t
which-function-mode: t
global-git-commit-mode: t
magit-auto-revert-mode: t
shell-dirtrack-mode: t
windmove-mode: t
savehist-mode: t
save-place-mode: t
tooltip-mode: t
global-eldoc-mode: t
show-paren-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tab-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
buffer-read-only: t
line-number-mode: t
transient-mark-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
Load-path shadows:
/usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/csharp-mode hides /home/sbaugh/.local/src/emacs29/lisp/progmodes/csharp-mode
/usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/eldoc hides /home/sbaugh/.local/src/emacs29/lisp/emacs-lisp/eldoc
/usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/auctex/lpath hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/dictionary/lpath
/home/sbaugh/.local/src/emacs29/lisp/net/dictionary hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/dictionary/dictionary
/usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/caml-font hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/ocaml/caml-font
/home/sbaugh/.local/src/emacs29/lisp/org/org-version hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-version
/home/sbaugh/.local/src/emacs29/lisp/org/org-loaddefs hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-loaddefs
/home/sbaugh/.local/src/emacs29/lisp/org/org-keys hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-keys
/home/sbaugh/.local/src/emacs29/lisp/org/ol hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol
/home/sbaugh/.local/src/emacs29/lisp/org/ob-perl hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-perl
/home/sbaugh/.local/src/emacs29/lisp/org/ob-core hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-core
/home/sbaugh/.local/src/emacs29/lisp/org/ox hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox
/home/sbaugh/.local/src/emacs29/lisp/org/ol-rmail hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-rmail
/home/sbaugh/.local/src/emacs29/lisp/org/ob-octave hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-octave
/home/sbaugh/.local/src/emacs29/lisp/org/ob-comint hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-comint
/home/sbaugh/.local/src/emacs29/lisp/org/ol-w3m hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-w3m
/home/sbaugh/.local/src/emacs29/lisp/org/ob-org hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-org
/home/sbaugh/.local/src/emacs29/lisp/org/ox-texinfo hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-texinfo
/home/sbaugh/.local/src/emacs29/lisp/org/org-inlinetask hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-inlinetask
/home/sbaugh/.local/src/emacs29/lisp/org/ol-mhe hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-mhe
/home/sbaugh/.local/src/emacs29/lisp/org/ob-ocaml hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-ocaml
/home/sbaugh/.local/src/emacs29/lisp/org/ob-clojure hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-clojure
/home/sbaugh/.local/src/emacs29/lisp/org/ox-publish hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-publish
/home/sbaugh/.local/src/emacs29/lisp/org/ol-irc hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-irc
/home/sbaugh/.local/src/emacs29/lisp/org/ob-calc hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-calc
/home/sbaugh/.local/src/emacs29/lisp/org/ox-odt hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-odt
/home/sbaugh/.local/src/emacs29/lisp/org/org-id hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-id
/home/sbaugh/.local/src/emacs29/lisp/org/ol-gnus hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-gnus
/home/sbaugh/.local/src/emacs29/lisp/org/ob-matlab hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-matlab
/home/sbaugh/.local/src/emacs29/lisp/org/ox-icalendar hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-icalendar
/home/sbaugh/.local/src/emacs29/lisp/org/org-footnote hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-footnote
/home/sbaugh/.local/src/emacs29/lisp/org/ol-bibtex hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-bibtex
/home/sbaugh/.local/src/emacs29/lisp/org/ob-lisp hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-lisp
/home/sbaugh/.local/src/emacs29/lisp/org/ob-C hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-C
/home/sbaugh/.local/src/emacs29/lisp/org/ox-org hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-org
/home/sbaugh/.local/src/emacs29/lisp/org/org-indent hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-indent
/home/sbaugh/.local/src/emacs29/lisp/org/ol-info hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-info
/home/sbaugh/.local/src/emacs29/lisp/org/ob-maxima hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-maxima
/home/sbaugh/.local/src/emacs29/lisp/org/ob-awk hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-awk
/home/sbaugh/.local/src/emacs29/lisp/org/ox-man hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-man
/home/sbaugh/.local/src/emacs29/lisp/org/org-goto hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-goto
/home/sbaugh/.local/src/emacs29/lisp/org/ox-md hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-md
/home/sbaugh/.local/src/emacs29/lisp/org/ol-eshell hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-eshell
/home/sbaugh/.local/src/emacs29/lisp/org/ob-lua hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-lua
/home/sbaugh/.local/src/emacs29/lisp/org/org-habit hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-habit
/home/sbaugh/.local/src/emacs29/lisp/org/ob-R hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-R
/home/sbaugh/.local/src/emacs29/lisp/org/ol-eww hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-eww
/home/sbaugh/.local/src/emacs29/lisp/org/ob-makefile hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-makefile
/home/sbaugh/.local/src/emacs29/lisp/org/ox-latex hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-latex
/home/sbaugh/.local/src/emacs29/lisp/org/ol-docview hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-docview
/home/sbaugh/.local/src/emacs29/lisp/org/ob-lob hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-lob
/home/sbaugh/.local/src/emacs29/lisp/org/ox-beamer hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-beamer
/home/sbaugh/.local/src/emacs29/lisp/org/org-faces hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-faces
/home/sbaugh/.local/src/emacs29/lisp/org/ob hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob
/home/sbaugh/.local/src/emacs29/lisp/org/ox-html hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-html
/home/sbaugh/.local/src/emacs29/lisp/org/org-feed hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-feed
/home/sbaugh/.local/src/emacs29/lisp/org/ol-bbdb hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-bbdb
/home/sbaugh/.local/src/emacs29/lisp/org/ob-lilypond hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-lilypond
/home/sbaugh/.local/src/emacs29/lisp/org/ox-ascii hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-ascii
/home/sbaugh/.local/src/emacs29/lisp/org/ob-latex hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-latex
/home/sbaugh/.local/src/emacs29/lisp/org/org hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org
/home/sbaugh/.local/src/emacs29/lisp/org/ob-tangle hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-tangle
/home/sbaugh/.local/src/emacs29/lisp/org/org-tempo hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-tempo
/home/sbaugh/.local/src/emacs29/lisp/org/org-duration hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-duration
/home/sbaugh/.local/src/emacs29/lisp/org/ob-sqlite hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-sqlite
/home/sbaugh/.local/src/emacs29/lisp/org/org-entities hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-entities
/home/sbaugh/.local/src/emacs29/lisp/org/ob-table hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-table
/home/sbaugh/.local/src/emacs29/lisp/org/ob-js hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-js
/home/sbaugh/.local/src/emacs29/lisp/org/org-table hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-table
/home/sbaugh/.local/src/emacs29/lisp/org/ob-sql hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-sql
/home/sbaugh/.local/src/emacs29/lisp/org/org-timer hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-timer
/home/sbaugh/.local/src/emacs29/lisp/org/org-element hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-element
/home/sbaugh/.local/src/emacs29/lisp/org/ob-java hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-java
/home/sbaugh/.local/src/emacs29/lisp/org/org-ctags hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-ctags
/home/sbaugh/.local/src/emacs29/lisp/org/ob-shell hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-shell
/home/sbaugh/.local/src/emacs29/lisp/org/ob-groovy hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-groovy
/home/sbaugh/.local/src/emacs29/lisp/org/org-src hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-src
/home/sbaugh/.local/src/emacs29/lisp/org/org-datetree hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-datetree
/home/sbaugh/.local/src/emacs29/lisp/org/ob-haskell hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-haskell
/home/sbaugh/.local/src/emacs29/lisp/org/org-plot hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-plot
/home/sbaugh/.local/src/emacs29/lisp/org/org-compat hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-compat
/home/sbaugh/.local/src/emacs29/lisp/org/ob-screen hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-screen
/home/sbaugh/.local/src/emacs29/lisp/org/ob-fortran hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-fortran
/home/sbaugh/.local/src/emacs29/lisp/org/org-protocol hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-protocol
/home/sbaugh/.local/src/emacs29/lisp/org/org-crypt hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-crypt
/home/sbaugh/.local/src/emacs29/lisp/org/ob-sed hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-sed
/home/sbaugh/.local/src/emacs29/lisp/org/ob-gnuplot hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-gnuplot
/home/sbaugh/.local/src/emacs29/lisp/org/org-pcomplete hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-pcomplete
/home/sbaugh/.local/src/emacs29/lisp/org/org-colview hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-colview
/home/sbaugh/.local/src/emacs29/lisp/org/ob-scheme hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-scheme
/home/sbaugh/.local/src/emacs29/lisp/org/ob-forth hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-forth
/home/sbaugh/.local/src/emacs29/lisp/org/org-num hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-num
/home/sbaugh/.local/src/emacs29/lisp/org/org-clock hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-clock
/home/sbaugh/.local/src/emacs29/lisp/org/ob-exp hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-exp
/home/sbaugh/.local/src/emacs29/lisp/org/org-mouse hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-mouse
/home/sbaugh/.local/src/emacs29/lisp/org/org-capture hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-capture
/home/sbaugh/.local/src/emacs29/lisp/org/ob-sass hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-sass
/home/sbaugh/.local/src/emacs29/lisp/org/ob-eval hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-eval
/home/sbaugh/.local/src/emacs29/lisp/org/ob-ref hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-ref
/home/sbaugh/.local/src/emacs29/lisp/org/ob-emacs-lisp hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-emacs-lisp
/home/sbaugh/.local/src/emacs29/lisp/org/org-mobile hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-mobile
/home/sbaugh/.local/src/emacs29/lisp/org/ob-ruby hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-ruby
/home/sbaugh/.local/src/emacs29/lisp/org/ob-eshell hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-eshell
/home/sbaugh/.local/src/emacs29/lisp/org/org-lint hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-lint
/home/sbaugh/.local/src/emacs29/lisp/org/org-agenda hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-agenda
/home/sbaugh/.local/src/emacs29/lisp/org/org-macro hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-macro
/home/sbaugh/.local/src/emacs29/lisp/org/org-attach-git hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-attach-git
/home/sbaugh/.local/src/emacs29/lisp/org/ob-processing hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-processing
/home/sbaugh/.local/src/emacs29/lisp/org/ob-css hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-css
/home/sbaugh/.local/src/emacs29/lisp/org/ob-dot hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-dot
/home/sbaugh/.local/src/emacs29/lisp/org/org-list hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-list
/home/sbaugh/.local/src/emacs29/lisp/org/org-macs hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-macs
/home/sbaugh/.local/src/emacs29/lisp/org/org-attach hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-attach
/home/sbaugh/.local/src/emacs29/lisp/org/org-archive hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-archive
/home/sbaugh/.local/src/emacs29/lisp/org/ob-python hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-python
/home/sbaugh/.local/src/emacs29/lisp/org/ob-plantuml hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-plantuml
/home/sbaugh/.local/src/emacs29/lisp/org/ob-ditaa hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-ditaa
/home/sbaugh/.local/src/emacs29/lisp/org/ob-julia hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/contrib/lisp/ob-julia
/home/sbaugh/.local/src/emacs29/lisp/org/ol-man hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/contrib/lisp/ol-man
/home/sbaugh/.local/src/emacs29/lisp/org/ox-koma-letter hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/contrib/lisp/ox-koma-letter
/home/sbaugh/.emacs.d/elpa/dash-2.19.1/dash hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/dash/dash
/home/sbaugh/.emacs.d/elpa/dash-2.19.1/dash-functional hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/dash/dash-functional
Features:
(shadow sort mail-extr emacsbug tabify cal-iso org-datetree org-capture
pcmpl-unix pcmpl-gnu dabbrev log-view vc vc-git vc-dispatcher
bug-reference shortdoc cc-mode cc-fonts cc-guess cc-menus cc-cmds
cc-styles cc-align cc-engine cc-vars cc-defs dired-aux pulse misearch
multi-isearch org-element org-persist org-id org-refile avl-tree
generator oc-basic ol-eww eww xdg url-queue mm-url ol-rmail ol-mhe
ol-irc ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime
smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom
gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap
nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range gnus-win gnus
nnheader range wid-edit ol-docview doc-view jka-compr image-mode exif
ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi find-dired sh-script
treesit executable goto-addr hl-line display-line-numbers cl-print
completion help-fns radix-tree vc-hg tramp tramp-loaddefs trampver
tramp-integration files-x tramp-compat parse-time iso8601 ls-lisp
jane-project jane-merlin merlin-imenu merlin-xref xref merlin-cap merlin
jane-async-merlin jane-completion jane-common jane-fe-menu ecaml_plugin
linum view gopcaml magit-bookmark bookmark image+ advice image-file
image-converter editorconfig editorconfig-core editorconfig-core-handle
editorconfig-fnmatch whitespace jane-auto-modes vba-mode markdown-mode
color jane jane-micro-features grep jane-diff unified-test-mode
shell-file core core-buffer core-error core-util ert pp ewoc debug
backtrace jane-sexp jane-ocaml jane-tuareg-theme tuareg tuareg-compat
tuareg-opam skeleton flymake-proc flymake warnings smie caml-types
caml-help caml-emacs find-file compile jane-cr jane-align
jane-deprecated jane-smerge gnu-elpa-keyring-update jane-ocp-indent
ocp-indent cl jane-util page-ext dired-x magit-extras project
magit-submodule magit-obsolete magit-blame magit-stash magit-reflog
magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote
magit-commit magit-sequence magit-notes magit-worktree magit-tag
magit-merge magit-branch magit-reset magit-files magit-refs magit-status
magit magit-repos magit-apply magit-wip magit-log which-func imenu
magit-diff smerge-mode diff diff-mode git-commit log-edit message
sendmail yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa
derived epg rfc6068 epg-config gnus-util text-property-search mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util
ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader
pcvs-util add-log magit-core magit-autorevert autorevert filenotify
magit-margin magit-transient magit-process with-editor shell server
magit-mode transient edmacro kmacro magit-git magit-section magit-utils
crm dash cl-extra help-mode windmove org ob ob-tangle ob-ref ob-lob
ob-table ob-exp org-macro org-src ob-comint org-pcomplete pcomplete
org-list org-footnote org-faces org-entities time-date noutline outline
icons ob-emacs-lisp ob-core ob-eval org-cycle org-table ol rx org-fold
org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar
cal-loaddefs org-version org-compat org-macs format-spec gdb-mi bindat
gud easy-mmode comint ansi-osc ansi-color ring ffap thingatpt vundo
pcase cyberpunk-theme savehist saveplace vundo-autoloads magit-autoloads
csv-mode-autoloads magit-section-autoloads cyberpunk-theme-autoloads
url-http-ntlm-autoloads url-auth git-commit-autoloads
with-editor-autoloads finder-inf info dash-autoloads package browse-url
url url-proxy url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x
map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc
iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind inotify dynamic-setting system-font-setting
font-render-setting cairo x-toolkit xinput2 x multi-tty
make-network-process emacs)
Memory information:
((conses 16 583321 56900)
(symbols 48 44810 0)
(strings 32 158814 5579)
(string-bytes 1 5346908)
(vectors 16 80875)
(vector-slots 8 1651451 169545)
(floats 8 540 459)
(intervals 56 11200 1394)
(buffers 976 38)
(heap 1024 63482 7231))
Spencer Baugh <sbaugh@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#62700; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.