Sean Whitton <spwhitton@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 62749) by debbugs.gnu.org; 12 Mar 2025 07:17:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Mar 12 03:17:43 2025 Received: from localhost ([127.0.0.1]:47121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tsGLX-0003Dz-6Z for submit <at> debbugs.gnu.org; Wed, 12 Mar 2025 03:17:43 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:39684) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1tsGLV-0003Di-3j for 62749 <at> debbugs.gnu.org; Wed, 12 Mar 2025 03:17:41 -0400 DKIM-Signature: a=rsa-sha256; b=ACvZUKhsYW1Cj75YwdpkKTdiZMZX1d0bJrgq6ZiJcwwgQX9cvF9UHlRhQfP/mRNAFbbbxhM9tFvDBaZbfFr6J9tiBHQCC5J8xYbUTI3QiumBdVXUNSL3qI8El3Y63rXvTrEU9mO3zDCXub5+TAgGnWo5hASmV4Q3NEWzLNlwwNbXaXU39TRa8350bbgwA+TjUKdIYnDoaMXnzpEeO7Dg4rvgDoI+S4Va5TfSGDpx3q/s8Ui7CxjDhUSLRemPFGqFvylXeF+wrjXVGufnSLaj+Am8BemajZpvq2fUkO0FgaeD8rZcrC3W8D++9n8jhB/OM/xqIzFcFetuSvlTDirBPQ==; s=purelymail1; d=spwhitton.name; v=1; bh=gDFswIaStQMi9I10h5jpWB4wTY1En158aANVq3DHMKk=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=rsvtlDKfrQBrVkKFSUAPO/zay8fVwEpUtG0I13YI+c5wW1lgz8LNKkKUR5JQN+BiwxWZZMMJ/tb1KzNyviQ5e2KdM1CjbggTOozApqd9mLUxkzFt9z2Vzl1amAYuEPxYqwRbSUsutkjyed5F2OXvFLD80cBksbVCWlBpRriWyorjPF8zVz8t2Gguo+jaIjLpTS5kRihPIOAtXeRzscJJnGFb3EfEjiwkT6BFzHGAPUm3IP153hOiWy4PBNOB2jptBl9KFEi62uXZm6UUZ4alNwALeJOiqhs6Zs8u2n9qTeKSW+pBum8xjZQxPDSjO9VKY9MkiieLMs001j6Qpolaow==; s=purelymail1; d=purelymail.com; v=1; bh=gDFswIaStQMi9I10h5jpWB4wTY1En158aANVq3DHMKk=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 62749 <at> debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -793891043; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 12 Mar 2025 07:17:28 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id D47C17EE0C4; Wed, 12 Mar 2025 15:17:25 +0800 (CST) From: Sean Whitton <spwhitton@HIDDEN> To: Juri Linkov <juri@HIDDEN> Subject: Re: bug#62749: 28.2; add-log-current-defun doesn't clean up its temporary buffers In-Reply-To: <87a59ro57i.fsf@HIDDEN> References: <vriuh6to9btf.fsf@HIDDEN> <ffd5bbf9-1edc-d112-1552-d38b4d8096f1@HIDDEN> <CAFNJpnjy=LjSyXQOrvfFgsut5SnyF1S-ruOqdpq8bN+jRXUfBg@HIDDEN> <86ttwdlffv.fsf@HIDDEN> <6241918f-0933-7086-e3e8-d2b2df62c302@HIDDEN> <86y1lomh92.fsf@HIDDEN> <87bju7dbrd.fsf_-_@HIDDEN> <87a59ro57i.fsf@HIDDEN> Date: Wed, 12 Mar 2025 15:17:25 +0800 Message-ID: <87y0xa90qi.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62749 Cc: Dmitry Gutov <dmitry@HIDDEN>, control <at> debbugs.gnu.org, Stefan Kangas <stefankangas@HIDDEN>, 62749 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) retitle 62749 28.2; add-log-current-defun doesn't clean up its temporary buffers thanks On Tue 11 Mar 2025 at 07:19pm +02, Juri Linkov wrote: > This was already fixed long ago: there is '(delay-mode-hooks (set-auto-mode))' > in 'diff-syntax-fontify-props'. Oh, great. >>> I guess this is related to another annoying bug: after every commit need >>> to spend much time killing all buffers created by the commit command. >> >> I'm not sure what you're referring to here, could you expand? > > 'which-function' uses 'add-log-current-defun' that creates the buffers > for files it visits, but never kills these temporary buffers afterwards. Okay, retitling this bug, then. Thanks. -- Sean Whitton
bug-gnu-emacs@HIDDEN:bug#62749; Package emacs.
Full text available.Received: (at 62749) by debbugs.gnu.org; 11 Mar 2025 17:23:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 11 13:23:13 2025 Received: from localhost ([127.0.0.1]:45399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ts3Jw-0000Ho-MT for submit <at> debbugs.gnu.org; Tue, 11 Mar 2025 13:23:13 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:37925) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1ts3Ir-0000Ek-2n for 62749 <at> debbugs.gnu.org; Tue, 11 Mar 2025 13:22:05 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id A11A220479; Tue, 11 Mar 2025 17:21:56 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Sean Whitton <spwhitton@HIDDEN> Subject: Re: bug#62749: 28.2; Disabling minor modes in diff-mode hunk temporary buffers In-Reply-To: <87bju7dbrd.fsf_-_@HIDDEN> Organization: LINKOV.NET References: <vriuh6to9btf.fsf@HIDDEN> <ffd5bbf9-1edc-d112-1552-d38b4d8096f1@HIDDEN> <CAFNJpnjy=LjSyXQOrvfFgsut5SnyF1S-ruOqdpq8bN+jRXUfBg@HIDDEN> <86ttwdlffv.fsf@HIDDEN> <6241918f-0933-7086-e3e8-d2b2df62c302@HIDDEN> <86y1lomh92.fsf@HIDDEN> <87bju7dbrd.fsf_-_@HIDDEN> Date: Tue, 11 Mar 2025 19:19:29 +0200 Message-ID: <87a59ro57i.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduvddvkedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepgedprhgtphhtthhopeeivdejgeelseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepshhtvghfrghnkhgrnhhgrghssehgmhgrihhlrdgtohhmpdhrtghpthhtohepughmihhtrhihsehguhhtohhvrdguvghvpdhrtghpthhtohepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62749 Cc: Dmitry Gutov <dmitry@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN>, 62749 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> The problem is that 'which-func-mode' is enabled in diff-mode. >> 'which-function' calls 'add-log-current-defun' that calls >> 'add-log-current-defun-function' that is 'diff-current-defun' >> in diff-mode. Finally, 'diff-find-source-location' visits >> the source files without killing them afterwards. > > In commit 53977213522 Stefan K. fixed a similar sort of problem for > Paredit users. Specifically, when trying to use C-c C-w in a Log Edit > buffer, diff-add-log-current-defuns tries to enable Paredit in its > *diff-other-text* temporary buffers. > > Paredit calls check-parens, which fails because it's just a small > portion of the file and so the parens aren't balanced. > This signalled a user-error which interrupts the whole operation. > > What is similar in these two cases is that diff-mode code is setting up > temporary buffers for hunks in which only the major mode matters, but > there are various possible minor modes that could get in the way because > they expect to be enabled in buffers visiting whole files. > > So I think this your problem here, Juri, might be fixable in a similar > way to 53977213522, by using delay-mode-hooks ? This was already fixed long ago: there is '(delay-mode-hooks (set-auto-mode))' in 'diff-syntax-fontify-props'. >> I guess this is related to another annoying bug: after every commit need >> to spend much time killing all buffers created by the commit command. > > I'm not sure what you're referring to here, could you expand? 'which-function' uses 'add-log-current-defun' that creates the buffers for files it visits, but never kills these temporary buffers afterwards.
bug-gnu-emacs@HIDDEN:bug#62749; Package emacs.
Full text available.Sean Whitton <spwhitton@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 62749) by debbugs.gnu.org; 11 Mar 2025 11:53:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 11 07:53:47 2025 Received: from localhost ([127.0.0.1]:41973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1tryB9-0008Pm-01 for submit <at> debbugs.gnu.org; Tue, 11 Mar 2025 07:53:47 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:47304) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1tryB2-0008PP-2f for 62749 <at> debbugs.gnu.org; Tue, 11 Mar 2025 07:53:41 -0400 DKIM-Signature: a=rsa-sha256; b=h6VZFD6qkjB4wZhIo6JHmR6eznkiRvzDiVxrqZA0dfswOL39e7OdxffOB5yZDyxSLGK7oFvK4GXZQ1bA3S9YMiRzDkT1zDJ7foJECp3s1x/e3gD1enV54vmVPjGMqd+bkztKYBC60NYcNq2DY5z6wgrRMi9Qv5ILunidiDO3m+7cX1rdIk/6Hi2YWohoWOrKy5IuQBrou6qrTCMZqWsAC+O/5ZkjwjwoeRTh/c1w3+ZL/c8O0+wifuo0/5/CCAs2pUapm3FAMBaWeEsolm/jurovuMCkLQ5tEw49MfZAy7x+2+k5Wcxg4jw6bnfr2SlSXLMk0lqsCWvWYzXN6o0qWw==; s=purelymail1; d=spwhitton.name; v=1; bh=Cln/I34ChvY4nhEJlTXfQWqPXh7uzeS0dZA8oZLIwMk=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=UlBpDIY4DJB+TLHU8RPJX4F6yysbBn8D1KTch8wGIP/U3DT9+ZHwng13Np+jxf8OTQyGNkxwqHfjf6oRAe+92W62ut3Q/Dh7MBFN5vbAAQEU8t/yVfL2cDcu5OxCB5xLSDnGvNRPXsKA/vCTW9DqfLXFm2d4CkyaJn3qi/wc9xyb2wXYQ3YOJ7C9aWMci5T+DEyDfMNYFr6WXbSCjhBf+QZHd6T8SseJJoJp63Yb/akRG1xaqM3fhAKLznJUr0fZWWiLMph9BEeGdlfKIUjruFKDmD6F4wQ+Y282ZogvuHwmTtqXnt9nrD9EB8xDVgjirGO7HXMInm3ee4q3gEGrgg==; s=purelymail1; d=purelymail.com; v=1; bh=Cln/I34ChvY4nhEJlTXfQWqPXh7uzeS0dZA8oZLIwMk=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 62749 <at> debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 718083269; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 11 Mar 2025 11:53:31 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id BF8377ED8EF; Tue, 11 Mar 2025 19:53:26 +0800 (CST) From: Sean Whitton <spwhitton@HIDDEN> To: Juri Linkov <juri@HIDDEN>, Dmitry Gutov <dmitry@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN> Subject: Re: bug#62749: 28.2; Disabling minor modes in diff-mode hunk temporary buffers In-Reply-To: <86y1lomh92.fsf@HIDDEN> References: <vriuh6to9btf.fsf@HIDDEN> <ffd5bbf9-1edc-d112-1552-d38b4d8096f1@HIDDEN> <CAFNJpnjy=LjSyXQOrvfFgsut5SnyF1S-ruOqdpq8bN+jRXUfBg@HIDDEN> <86ttwdlffv.fsf@HIDDEN> <6241918f-0933-7086-e3e8-d2b2df62c302@HIDDEN> <86y1lomh92.fsf@HIDDEN> Date: Tue, 11 Mar 2025 19:53:26 +0800 Message-ID: <87bju7dbrd.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62749 Cc: control <at> debbugs.gnu.org, 62749 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) retitle 62749 28.2; Disabling minor modes in diff-mode hunk temporary buffers thanks On Tue 16 May 2023 at 07:44pm +03, Juri Linkov wrote: > The problem is that 'which-func-mode' is enabled in diff-mode. > 'which-function' calls 'add-log-current-defun' that calls > 'add-log-current-defun-function' that is 'diff-current-defun' > in diff-mode. Finally, 'diff-find-source-location' visits > the source files without killing them afterwards. In commit 53977213522 Stefan K. fixed a similar sort of problem for Paredit users. Specifically, when trying to use C-c C-w in a Log Edit buffer, diff-add-log-current-defuns tries to enable Paredit in its *diff-other-text* temporary buffers. Paredit calls check-parens, which fails because it's just a small portion of the file and so the parens aren't balanced. This signalled a user-error which interrupts the whole operation. What is similar in these two cases is that diff-mode code is setting up temporary buffers for hunks in which only the major mode matters, but there are various possible minor modes that could get in the way because they expect to be enabled in buffers visiting whole files. So I think this your problem here, Juri, might be fixable in a similar way to 53977213522, by using delay-mode-hooks ? > I guess this is related to another annoying bug: after every commit need > to spend much time killing all buffers created by the commit command. I'm not sure what you're referring to here, could you expand? -- Sean Whitton
bug-gnu-emacs@HIDDEN:bug#62749; Package emacs.
Full text available.Received: (at 62749) by debbugs.gnu.org; 16 May 2023 16:52:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 16 12:52:14 2023 Received: from localhost ([127.0.0.1]:47212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pyxuI-00079F-LH for submit <at> debbugs.gnu.org; Tue, 16 May 2023 12:52:14 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:53199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1pyxuE-00078l-Jn for 62749 <at> debbugs.gnu.org; Tue, 16 May 2023 12:52:10 -0400 Received: (Authenticated sender: juri@HIDDEN) by mail.gandi.net (Postfix) with ESMTPSA id 9D4181BF204; Tue, 16 May 2023 16:52:03 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Dmitry Gutov <dmitry@HIDDEN> Subject: Re: bug#62749: 28.2; Emacs keeps opening related file from vc-diff buffer In-Reply-To: <6241918f-0933-7086-e3e8-d2b2df62c302@HIDDEN> (Dmitry Gutov's message of "Tue, 16 May 2023 14:46:36 +0300") Organization: LINKOV.NET References: <vriuh6to9btf.fsf@HIDDEN> <ffd5bbf9-1edc-d112-1552-d38b4d8096f1@HIDDEN> <CAFNJpnjy=LjSyXQOrvfFgsut5SnyF1S-ruOqdpq8bN+jRXUfBg@HIDDEN> <86ttwdlffv.fsf@HIDDEN> <6241918f-0933-7086-e3e8-d2b2df62c302@HIDDEN> Date: Tue, 16 May 2023 19:44:25 +0300 Message-ID: <86y1lomh92.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62749 Cc: 62749 <at> debbugs.gnu.org, Oleksandr Gavenko <gavenkoa@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >>> After bisecting my long .emacs config I pinpointed the culprit: >>> >>> (which-func-mode 1) >> >> Maybe 'diff-syntax-fontify' could have a similar list of minor modes >> that should be ignored. Then such a list should at least contain >> 'which-func-mode' by default. > > Do you mean that it's not feasible to fix the behavior when which-func-mode > is enabled? After debugging I realized it's not related to diff-font-lock-syntax. The problem is that 'which-func-mode' is enabled in diff-mode. 'which-function' calls 'add-log-current-defun' that calls 'add-log-current-defun-function' that is 'diff-current-defun' in diff-mode. Finally, 'diff-find-source-location' visits the source files without killing them afterwards. I guess this is related to another annoying bug: after every commit need to spend much time killing all buffers created by the commit command.
bug-gnu-emacs@HIDDEN:bug#62749; Package emacs.
Full text available.Received: (at 62749) by debbugs.gnu.org; 16 May 2023 11:46:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue May 16 07:46:48 2023 Received: from localhost ([127.0.0.1]:45411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pyt8h-00043j-Vq for submit <at> debbugs.gnu.org; Tue, 16 May 2023 07:46:48 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:60683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1pyt8f-00043V-N1 for 62749 <at> debbugs.gnu.org; Tue, 16 May 2023 07:46:47 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 935DB5C01E9; Tue, 16 May 2023 07:46:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 16 May 2023 07:46:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1684237599; x=1684323999; bh=iOYcOAgibeGFX+xwPHkINDGN7fE5icAlMKx 12+IMubo=; b=ZiVP9tfxDPT2MXpyT5sTMhrs6BRyFW0+MRgHfuEg9mQx6AyNvzf G5JjZfSe9MPmEw/NOkD/6z1v5ZrgAocOAfYQU0AwaJxL7FDcsH8BTPboqdDqcq/M gcniX/GcH9wIKYFwMH55EoxoQeaEoHCT71wwsx6WFf4ARmiKdUXJaeFfclwgEpcm 6D3STsc6fKKoocvFZRhHZO3MVVwo9L5FkC/sDCtmipoHwyU+PN4RFHFW5IZEP3YM GLUr+MwIwljDGtxa8CY1Yt1kufVZdVKTywCXbnnSx7AKVpZ4HJRFKw8SB2MIu5IW 8o9JT2Bie0SAEuhYluIoELwPby4+Pk/5dow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1684237599; x=1684323999; bh=iOYcOAgibeGFX+xwPHkINDGN7fE5icAlMKx 12+IMubo=; b=bhN35Q4fD2/l2j1dEZqESykjGpezRKKRAe939wjE9OE2rDkX8dO 7lsY1ZuYaQCyMWxTFs5X2/j5enBUzjUp5kn/WuxZxtgvVc3I3v+F0QJHPsaPKpSg MpVmedFoycuJIi0w0ckKYsFgJwrOdwB4tPHxKPHZnwQFWDvJagMg9fq0b23V4Y/N hE3CGE9N+yyyHMTOy6kTEl8RhxG86d4sz8O6YBry5AKdQb+T3nz7KACXCH2caCf6 gR3Mdim5p6MtHCB0pQpRnFqHvxEiHboUQGnM5VYsIEI/mwmHk0xXth0Yh5zYByK5 5T15WeESf4GU/yORg+V9w7lZmaGJtcZf3Yg== X-ME-Sender: <xms:H21jZIUvj78shGyU2KY59JtH0KPVPJMAfbzbGSY76G326o3LhSN-fw> <xme:H21jZMnVOqFJg6GW3rR9I96vhUqZeGYZ3_KGafYuMJFvZFJhYAugPnhkU2KMIIBee 0npRC3OGdIoZ7Mh9ME> X-ME-Received: <xmr:H21jZMb0y9x4us3v1n0jDrPAzEI98rtf1V16qrtyUeXNFoQnUHfOdPDHpULZP7Y> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeehledggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: <xmx:H21jZHWILODvLmfIXTo5-BObWCLlLWCgEmlWzATB-nWnPOxZ3Bcdeg> <xmx:H21jZCn8rvP2m-HFxJNsjOtgC8FqWKzwxijcYmHfk0n5gFxpSl1Z-w> <xmx:H21jZMfPwHwKY9p4sxMRM6mGmP6iBzZ6-sIJhVNErTZcqxdw2pGDMw> <xmx:H21jZGtNvg2pJ-vm7DIqQXSJ2M-8oebzEjitOFgqrK6Oy_66ayYuqg> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 16 May 2023 07:46:38 -0400 (EDT) Message-ID: <6241918f-0933-7086-e3e8-d2b2df62c302@HIDDEN> Date: Tue, 16 May 2023 14:46:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: bug#62749: 28.2; Emacs keeps opening related file from vc-diff buffer Content-Language: en-US To: Juri Linkov <juri@HIDDEN>, Oleksandr Gavenko <gavenkoa@HIDDEN> References: <vriuh6to9btf.fsf@HIDDEN> <ffd5bbf9-1edc-d112-1552-d38b4d8096f1@HIDDEN> <CAFNJpnjy=LjSyXQOrvfFgsut5SnyF1S-ruOqdpq8bN+jRXUfBg@HIDDEN> <86ttwdlffv.fsf@HIDDEN> From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <86ttwdlffv.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 62749 Cc: 62749 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.9 (--) On 15/05/2023 19:46, Juri Linkov wrote: >> After bisecting my long .emacs config I pinpointed the culprit: >> >> (which-func-mode 1) >> >> During the movement through a diff buffer this mode loads corresponding >> files: >> >> if the cursor reaches a new hunk - the corresponding file is opened (( >> >> This is done one by one file while I scroll down with the cursor. >> >> Removing the line significantly improved performance during scromming in VC >> diff buffer in Cygwin and no more new files opened! > This is an interesting problem, I can reproduce it by > 'M-x which-function-mode'. > >> I think which-function-mode is broken for diff-mode, the workaround for >> those who wants this mode is to deal with: >> >> (defcustom which-func-modes t >> ;; '(emacs-lisp-mode c-mode c++-mode objc-mode perl-mode cperl-mode python-mode >> ;; makefile-mode sh-mode fortran-mode f90-mode ada-mode >> ;; diff-mode) >> "List of major modes for which Which Function mode should be used. >> For other modes it is disabled. If this is equal to t, >> then Which Function mode is enabled in any major mode that supports it." >> >> What are the next actions? > Maybe 'diff-syntax-fontify' could have a similar list of minor modes > that should be ignored. Then such a list should at least contain > 'which-func-mode' by default. Do you mean that it's not feasible to fix the behavior when which-func-mode is enabled?
bug-gnu-emacs@HIDDEN:bug#62749; Package emacs.
Full text available.Received: (at 62749) by debbugs.gnu.org; 15 May 2023 17:05:31 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 15 13:05:31 2023 Received: from localhost ([127.0.0.1]:44251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pybda-0005tH-QT for submit <at> debbugs.gnu.org; Mon, 15 May 2023 13:05:31 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:38923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1pybdY-0005sx-0f for 62749 <at> debbugs.gnu.org; Mon, 15 May 2023 13:05:28 -0400 Received: (Authenticated sender: juri@HIDDEN) by mail.gandi.net (Postfix) with ESMTPSA id 5562A24000C; Mon, 15 May 2023 17:05:19 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Oleksandr Gavenko <gavenkoa@HIDDEN> Subject: Re: bug#62749: 28.2; Emacs keeps opening related file from vc-diff buffer In-Reply-To: <CAFNJpnjy=LjSyXQOrvfFgsut5SnyF1S-ruOqdpq8bN+jRXUfBg@HIDDEN> (Oleksandr Gavenko's message of "Sun, 14 May 2023 13:59:49 +0300") Organization: LINKOV.NET References: <vriuh6to9btf.fsf@HIDDEN> <ffd5bbf9-1edc-d112-1552-d38b4d8096f1@HIDDEN> <CAFNJpnjy=LjSyXQOrvfFgsut5SnyF1S-ruOqdpq8bN+jRXUfBg@HIDDEN> Date: Mon, 15 May 2023 19:46:36 +0300 Message-ID: <86ttwdlffv.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62749 Cc: Dmitry Gutov <dmitry@HIDDEN>, 62749 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > After bisecting my long .emacs config I pinpointed the culprit: > > (which-func-mode 1) > > During the movement through a diff buffer this mode loads corresponding > files: > > if the cursor reaches a new hunk - the corresponding file is opened (( > > This is done one by one file while I scroll down with the cursor. > > Removing the line significantly improved performance during scromming in VC > diff buffer in Cygwin and no more new files opened! This is an interesting problem, I can reproduce it by 'M-x which-function-mode'. > I think which-function-mode is broken for diff-mode, the workaround for > those who wants this mode is to deal with: > > (defcustom which-func-modes t > ;; '(emacs-lisp-mode c-mode c++-mode objc-mode perl-mode cperl-mode python-mode > ;; makefile-mode sh-mode fortran-mode f90-mode ada-mode > ;; diff-mode) > "List of major modes for which Which Function mode should be used. > For other modes it is disabled. If this is equal to t, > then Which Function mode is enabled in any major mode that supports it." > > What are the next actions? Maybe 'diff-syntax-fontify' could have a similar list of minor modes that should be ignored. Then such a list should at least contain 'which-func-mode' by default.
bug-gnu-emacs@HIDDEN:bug#62749; Package emacs.
Full text available.Received: (at 62749) by debbugs.gnu.org; 14 May 2023 11:00:08 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 14 07:00:08 2023 Received: from localhost ([127.0.0.1]:40412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1py9SR-0004ms-PS for submit <at> debbugs.gnu.org; Sun, 14 May 2023 07:00:08 -0400 Received: from mail-ej1-f48.google.com ([209.85.218.48]:49522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <gavenkoa@HIDDEN>) id 1py9SQ-0004ln-Fb for 62749 <at> debbugs.gnu.org; Sun, 14 May 2023 07:00:07 -0400 Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-96b0235c10bso112760866b.3 for <62749 <at> debbugs.gnu.org>; Sun, 14 May 2023 04:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684062000; x=1686654000; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hogY2tl4ttjcFr11GmpNRkzgXV7/x4DFABU+z/kp0Rk=; b=VjjXNkT/Zjtz3CWgAwLISA3rrc8mexNZQzMwUhqTsU39Keo+aDi6XL0jRM3Qpufj3d +ajVJ32mjF3jzzMWw9yWrdydHsQVS+IBe/bUNQ4EwgJTUWb1OIHAJBn4dHUFUaV4mUKi Ch7mxqLWHM9FhA/pboJngMmoXILtiLpdiAxDnNj2cSpDXKLL2BZxrXyKQUrkOu9Ns3na 7UB+AX9vIO8sxTBiEpY1WbpJinQLutHA+R0ahUda/Q+kWKhJaZzfu9Nyy1FWgBUIyOTH tUZahSkYI/9gPqlo3UedWRYxSg/dNpznXLcAMPq3jCcjb1HzFHWdrkEAzIW9y560xwrP n5pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684062000; x=1686654000; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hogY2tl4ttjcFr11GmpNRkzgXV7/x4DFABU+z/kp0Rk=; b=OEtd1XaJp0bMy9vl/3sWqytnYVK0d6rl2WvImmjcMPjTFRXr4Gp4DiPG8MQNujhp1q 0JaU2Fk+asM3e94C/9gYBbbK2uT3vVgeJ/apzAryCzdvJAUlqJI7mSGQGLK/EOJp6uGz pzcWcRZ8qzVM5V4sUO9hZ2wpc8v9PQf6fAcu+udiN+ERHiY1MCReI69+d4LrIMChILwt gLp2xYSWpGJINxPdbuyW/+/m/I5VDlUzs2Ny/guakJgcJ8MR0JeBqAEG0u71VPDZUoSi c44Cr2Aio67pa56pdH6ghXmxp+vkBldl0Qpv5JMrW0JUXEL7RpKzgrP2OxcYDSeojLRW d3jg== X-Gm-Message-State: AC+VfDwrrcKctePhQ4laiexubqBDHicIHoHiUP54kT/VFJA8g/qPpciE DMI34Kefc1gDTzxe2kdMJeKzHFK58n4PSBW55bRGQ0nG X-Google-Smtp-Source: ACHHUZ6JJ3TMLnXGVeq+xmM2x+7rlw+H4bxl6KAfLSZBmcMT7aON5ZdtaFGAFvhHKSS0txfRXCTkHW9yXuF1WFQZS1E= X-Received: by 2002:a17:906:9c83:b0:94f:449e:75db with SMTP id fj3-20020a1709069c8300b0094f449e75dbmr28872991ejc.52.1684062000316; Sun, 14 May 2023 04:00:00 -0700 (PDT) MIME-Version: 1.0 References: <vriuh6to9btf.fsf@HIDDEN> <ffd5bbf9-1edc-d112-1552-d38b4d8096f1@HIDDEN> In-Reply-To: <ffd5bbf9-1edc-d112-1552-d38b4d8096f1@HIDDEN> From: Oleksandr Gavenko <gavenkoa@HIDDEN> Date: Sun, 14 May 2023 13:59:49 +0300 Message-ID: <CAFNJpnjy=LjSyXQOrvfFgsut5SnyF1S-ruOqdpq8bN+jRXUfBg@HIDDEN> Subject: Re: bug#62749: 28.2; Emacs keeps opening related file from vc-diff buffer To: Dmitry Gutov <dmitry@HIDDEN> Content-Type: multipart/alternative; boundary="0000000000004f054805fba53d1c" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62749 Cc: 62749 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --0000000000004f054805fba53d1c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable After bisecting my long .emacs config I pinpointed the culprit: (which-func-mode 1) During the movement through a diff buffer this mode loads corresponding files: if the cursor reaches a new hunk - the corresponding file is opened (( This is done one by one file while I scroll down with the cursor. Removing the line significantly improved performance during scromming in VC diff buffer in Cygwin and no more new files opened! I think which-function-mode is broken for diff-mode, the workaround for those who wants this mode is to deal with: (defcustom which-func-modes t ;; '(emacs-lisp-mode c-mode c++-mode objc-mode perl-mode cperl-mode python-mode ;; makefile-mode sh-mode fortran-mode f90-mode ada-mode ;; diff-mode) "List of major modes for which Which Function mode should be used. For other modes it is disabled. If this is equal to t, then Which Function mode is enabled in any major mode that supports it." What are the next actions? On Tue, Apr 11, 2023 at 1:23=E2=80=AFAM Dmitry Gutov <dmitry@HIDDEN> wro= te: > Hi! Thanks for the report. > > On 10/04/2023 15:11, Oleksandr Gavenko wrote: > > In GNU Emacs 28.2 (build 1, x86_64-pc-cygwin) > > of 2022-09-16 built on fv-az140-985 > > Repository revision: 70134aa8264ded36d80248204b2ba43ae3d8f599 > > > > Whenever I open vc-diff buffer by "d" (log-view-diff) to read repositor= y > > history from "C-x v L" (vc-print-root-log) Emacs opens all files > referenced by > > diff. > > > > The diff might be very big so: > > > > * I end with lots of opened files that I need eventually close. > > * Emacs pollutes recentf history - I don't want robotically opened file > mixed > > with human opened files. > > * Cygwin is slow (especially under antivirus supervision) file opening > delays > > Emacs for many seconds. > > > > Initially I asked for help in Emacs 27.1: > > > > > https://emacs.stackexchange.com/questions/61760/lags-when-navigating-vc-r= oot-diff-buffer/ > > > > and found workaround with: > > > > (setq diff-font-lock-syntax nil) > > This workaround should help, in particular to improve performance under > Cygwin. > > The thing about opened files is quite odd, though: > diff-syntax-fontify-hunk does not visit any new files. It either uses an > existing buffer, or fetches file contents using insert-file-contents, or > calls vc-find-revision-no-save which, again, inserts the previous' > revision file contents into the provided buffer, without visiting a file. > > Perhaps you could edebug diff-syntax-fontify-hunk to find the exact > place where a file is visited (and added to recentf), if that indeed > happens. > --0000000000004f054805fba53d1c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>After bisecting my long .emacs config I pinpointed th= e culprit:</div><div><br></div><div>(which-func-mode 1)<br></div><div><br><= /div><div>During the movement through a diff buffer this mode loads corresp= onding files:</div><div><br></div><div>=C2=A0 if the cursor reaches a new h= unk - the corresponding file is opened ((</div><div><br></div><div>This is = done one by one file while I scroll down with the cursor.</div><div><br></d= iv><div>Removing the line significantly improved performance during scrommi= ng in VC diff buffer in Cygwin and no more new files opened!</div><div><br>= </div><div>I think which-function-mode is broken for diff-mode, the workaro= und for those who wants this mode is to deal with:</div><div><br></div><div= >(defcustom which-func-modes t<br>=C2=A0 ;; '(emacs-lisp-mode c-mode c+= +-mode objc-mode perl-mode cperl-mode python-mode<br>=C2=A0 ;;=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 makefile-mod= e sh-mode fortran-mode f90-mode ada-mode<br>=C2=A0 ;;=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 diff-mode)<br>=C2=A0 = "List of major modes for which Which Function mode should be used.<br>= For other modes it is disabled.=C2=A0 If this is equal to t,<br>then Which = Function mode is enabled in any major mode that supports it."<br></div= ><div><br></div><div>What are the next actions?<br></div></div><br><div cla= ss=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Apr 11, 20= 23 at 1:23=E2=80=AFAM Dmitry Gutov <<a href=3D"mailto:dmitry@HIDDEN">= dmitry@HIDDEN</a>> wrote:<br></div><blockquote class=3D"gmail_quote" = style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pa= dding-left:1ex">Hi! Thanks for the report.<br> <br> On 10/04/2023 15:11, Oleksandr Gavenko wrote:<br> > In GNU Emacs 28.2 (build 1, x86_64-pc-cygwin)<br> >=C2=A0 =C2=A0of 2022-09-16 built on fv-az140-985<br> > Repository revision: 70134aa8264ded36d80248204b2ba43ae3d8f599<br> > <br> > Whenever I open vc-diff buffer by "d" (log-view-diff) to rea= d repository<br> > history from "C-x v L" (vc-print-root-log) Emacs opens all f= iles referenced by<br> > diff.<br> > <br> > The diff might be very big so:<br> > <br> > * I end with lots of opened files that I need eventually close.<br> > * Emacs pollutes recentf history - I don't want robotically opened= file mixed<br> >=C2=A0 =C2=A0 with human opened files.<br> > * Cygwin is slow (especially under antivirus supervision) file opening= delays<br> >=C2=A0 =C2=A0 Emacs for many seconds.<br> > <br> > Initially I asked for help in Emacs 27.1:<br> > <br> >=C2=A0 =C2=A0 <a href=3D"https://emacs.stackexchange.com/questions/6176= 0/lags-when-navigating-vc-root-diff-buffer/" rel=3D"noreferrer" target=3D"_= blank">https://emacs.stackexchange.com/questions/61760/lags-when-navigating= -vc-root-diff-buffer/</a><br> > <br> > and found workaround with:<br> > <br> >=C2=A0 =C2=A0 (setq diff-font-lock-syntax nil)<br> <br> This workaround should help, in particular to improve performance under <br= > Cygwin.<br> <br> The thing about opened files is quite odd, though: <br> diff-syntax-fontify-hunk does not visit any new files. It either uses an <b= r> existing buffer, or fetches file contents using insert-file-contents, or <b= r> calls vc-find-revision-no-save which, again, inserts the previous' <br> revision file contents into the provided buffer, without visiting a file.<b= r> <br> Perhaps you could edebug diff-syntax-fontify-hunk to find the exact <br> place where a file is visited (and added to recentf), if that indeed <br> happens.<br> </blockquote></div> --0000000000004f054805fba53d1c--
bug-gnu-emacs@HIDDEN:bug#62749; Package emacs.
Full text available.Received: (at 62749) by debbugs.gnu.org; 10 Apr 2023 22:23:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 10 18:23:30 2023 Received: from localhost ([127.0.0.1]:36077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1plzv8-0007g0-FP for submit <at> debbugs.gnu.org; Mon, 10 Apr 2023 18:23:30 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:33635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dmitry@HIDDEN>) id 1plzv6-0007fm-4L for 62749 <at> debbugs.gnu.org; Mon, 10 Apr 2023 18:23:28 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id D134158202B; Mon, 10 Apr 2023 18:23:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 10 Apr 2023 18:23:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681165402; x=1681169002; bh=bI6XZ91gMc9AFKk4VNgRLJY37R2/SfVsMAs NA9UFVhk=; b=SoG79czOq6JXEkj+L+5u5jCihgpfO3iDGoCITBuYWH+hXpA7gyH pyFVN4QErXDYChiG4yH7qzuckKbYYo6cgi9rUV/QGj9+JbBPeTH+f8d+u+N8QZ6W eHUX+i9EHrDoQ7xo7nKAeptqfTrB6ShHUBeZh458JxE1T7IZ50RAsOEBoZi1f4eR zrINN+TFn9pa6duMr0133rwHkdzEaRFqN3ygypUqYXui95j2TpHJrQ4PJ+OKUJ4f b9gUMAasXUIL6TyhVC3GfQPvamSeCwTqGRErVtjzfID7175GnK8RDNnTS3MhvtRg c+Db5/4vzRgoW5lhWtx21D8OaCSyqOwUdCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1681165402; x= 1681169002; bh=bI6XZ91gMc9AFKk4VNgRLJY37R2/SfVsMAsNA9UFVhk=; b=c FY278xd6LprxmoJveZ3agIYUaXRMS1SMEK+t3BJIpF2/3KiCBcp/ixXM1gme0p7m BwTPS/0ZPSA/fnAu8VvImgnrjNkVkiCqxOXycROfRpcpjKpohIqW6PNODgFoOArS 5pQxmmdJlj7K0w+aamiiKB+sabi5TnXlmm5kcOz2cA8taQ0DXv74GGrxA06LOgQp lwMifSZ9wKtzcHCVRMQzHQwGsJofG2xBgW6dyd261NTTD57lKy2CDIe2j6zDyxrP ycYJ9ooFTvXB7FPLdo1rn4f6xAyGIEWkgOA5sgdvG6iefyJ7xwYjVXklcK85HKMu VBfDRtBKlvOC6rjDlHEIw== X-ME-Sender: <xms:Wow0ZHUWzie_HuPUYq9uVI0Zd19-1Egod0nVe1p2dFSa-tGV0zl3-w> <xme:Wow0ZPnJvoybb2l6Eu-Rg1d2kU_UH1uBnQ4qe0091FXNk2_zeCHdh6jakAtqr-G_r pLYQ2iA1wMf2U4Xd5U> X-ME-Received: <xmr:Wow0ZDYNnm15FxuKfCSBf0_XdWYcek-cgyadfHMyZhstS3T1BRL5AU8_9xiebH9l> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekfedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpedvteeuieefgeefveejvdekjeegleeiffettdelfedugfekhfegteefffeitddt ieenucffohhmrghinhepshhtrggtkhgvgigthhgrnhhgvgdrtghomhenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhuthho vhdruggvvh X-ME-Proxy: <xmx:Wow0ZCWQ1fKlRwl4i3Z4T3b8HhTlqZaPUI3toASdt3vtUr1uP-nbZQ> <xmx:Wow0ZBliz3jEKOhfZx5F8i9s_67E26R4r7BPJE-gDIC9daITweX1Hw> <xmx:Wow0ZPfWYWAgBg4Zn_T3ytVb8w2lUzJSDneZqw6smvoFoWe8pLx8Ww> <xmx:Wow0ZAtbr-ZIwVi00F5yV6O6H-YtuU5OF1UzWRQir84E3lcDtWon8Q> Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 Apr 2023 18:23:21 -0400 (EDT) Message-ID: <ffd5bbf9-1edc-d112-1552-d38b4d8096f1@HIDDEN> Date: Tue, 11 Apr 2023 01:23:19 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: bug#62749: 28.2; Emacs keeps opening related file from vc-diff buffer Content-Language: en-US To: Oleksandr Gavenko <gavenkoa@HIDDEN>, 62749 <at> debbugs.gnu.org References: <vriuh6to9btf.fsf@HIDDEN> From: Dmitry Gutov <dmitry@HIDDEN> In-Reply-To: <vriuh6to9btf.fsf@HIDDEN> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 62749 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.0 (--) Hi! Thanks for the report. On 10/04/2023 15:11, Oleksandr Gavenko wrote: > In GNU Emacs 28.2 (build 1, x86_64-pc-cygwin) > of 2022-09-16 built on fv-az140-985 > Repository revision: 70134aa8264ded36d80248204b2ba43ae3d8f599 > > Whenever I open vc-diff buffer by "d" (log-view-diff) to read repository > history from "C-x v L" (vc-print-root-log) Emacs opens all files referenced by > diff. > > The diff might be very big so: > > * I end with lots of opened files that I need eventually close. > * Emacs pollutes recentf history - I don't want robotically opened file mixed > with human opened files. > * Cygwin is slow (especially under antivirus supervision) file opening delays > Emacs for many seconds. > > Initially I asked for help in Emacs 27.1: > > https://emacs.stackexchange.com/questions/61760/lags-when-navigating-vc-root-diff-buffer/ > > and found workaround with: > > (setq diff-font-lock-syntax nil) This workaround should help, in particular to improve performance under Cygwin. The thing about opened files is quite odd, though: diff-syntax-fontify-hunk does not visit any new files. It either uses an existing buffer, or fetches file contents using insert-file-contents, or calls vc-find-revision-no-save which, again, inserts the previous' revision file contents into the provided buffer, without visiting a file. Perhaps you could edebug diff-syntax-fontify-hunk to find the exact place where a file is visited (and added to recentf), if that indeed happens.
bug-gnu-emacs@HIDDEN:bug#62749; Package emacs.
Full text available.Received: (at 62749) by debbugs.gnu.org; 10 Apr 2023 12:14:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 10 08:14:58 2023 Received: from localhost ([127.0.0.1]:34491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1plqQE-0007r4-F4 for submit <at> debbugs.gnu.org; Mon, 10 Apr 2023 08:14:58 -0400 Received: from mail-ed1-f41.google.com ([209.85.208.41]:62501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <gavenkoa@HIDDEN>) id 1plqQD-0007qr-1N for 62749 <at> debbugs.gnu.org; Mon, 10 Apr 2023 08:14:57 -0400 Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-50263dfe37dso17422878a12.0 for <62749 <at> debbugs.gnu.org>; Mon, 10 Apr 2023 05:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681128891; x=1683720891; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=PpV7VWAE5qHXMFNlSdJdOYE+Pyv3Ke8Xkuyhh608+s0=; b=DodHVj0bfwUuhqxlFdQHr7igsFwQMaMyamYZcHhC0y7N2xhWkiYdzKC7r/RJlwDRrZ 6r7Q/oHBomxiSW0dLHcMFJVee4lm/EkoZuhb8KQqe+sL1OXhkSh0IYGR6WMcuy/XCnDD DLdM0uZBaJWz0mfxJgz7BDrUkNGZi3QhudYXVY0e0TuYF3i6B3ZLyn3co9MOp1mqnKA4 2Z848QcvOkTBtpfmpKM6Xng+bYaUaWpJv3lPXvb8XC4JHSTxFbEQ0LHK4FUgF8D+0W9+ jLPrbdnKOoXdxPrD8wMNtCR4U6IjY4AwM2iefUKZalGMF8vruV4MXZuFSzfNOcchMr74 fMEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681128891; x=1683720891; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PpV7VWAE5qHXMFNlSdJdOYE+Pyv3Ke8Xkuyhh608+s0=; b=vJLFb007ryP4fWwPuflRMWutIj47ZQvRiqIxKr5jmAfcRslk/UwmW+KYUJo9zzw0uD SOuE6VlwLJ5hnFSrP1fXUz3rCPjsNm6OwfvbHNr7W/Xto8NfJwmPgsbkW85R5deUMTUT 64LisNdEcAykRAfncgZMujSmp3pyghyCLK1fVg8SEhOknfbSPjL1nXA+x4a4hhd4c5pB EGEMLCSAHve8BnMVjuUKszOLckt/jXkCKJRCApXZjC/AJ9rTekXF5xDbbbHMgH+KFmF7 GUL2pdCuPtT/ZF6UETGXrXoOulefAj7x6boq1cTxwas77k3sjjD1eif2+jlLQIQ9WuZQ SnsA== X-Gm-Message-State: AAQBX9egNDsKlBrsnkrE4hHWvYNPDNChWDydrBt2m4eIhYX7S9B46hUM 5qylNiUioPcxu6s4xdVeyHJUP28pXRgnWj+REcU3gqSb X-Google-Smtp-Source: AKy350a9uN+BcJcbYOpHKwV7KBQxddpxdYzuIBHcgvhc3p/ukkGUeq0uRsUO+cWrHtrVxCCY8H14wod0D9zdAE20yjQ= X-Received: by 2002:a05:6402:3506:b0:504:a254:ecce with SMTP id b6-20020a056402350600b00504a254eccemr1762757edd.1.1681128890847; Mon, 10 Apr 2023 05:14:50 -0700 (PDT) MIME-Version: 1.0 From: Oleksandr Gavenko <gavenkoa@HIDDEN> Date: Mon, 10 Apr 2023 15:14:40 +0300 Message-ID: <CAFNJpnjRXy-+cf1O6hbJvsf9ma8zSsa0a1+uJPS-4G-FSVmqxA@HIDDEN> Subject: 28.2; Emacs keeps opening related file from vc-diff buffer To: 62749 <at> debbugs.gnu.org Content-Type: multipart/alternative; boundary="0000000000005c556c05f8fa527c" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62749 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --0000000000005c556c05f8fa527c Content-Type: text/plain; charset="UTF-8" Seems the problem is related to syntax highlighting parsers in diffs. I don't need syntax highlighting at the cost of slowness and polluted recentf history. --0000000000005c556c05f8fa527c Content-Type: text/html; charset="UTF-8" <div dir="ltr"><div>Seems the problem is related to syntax highlighting parsers in diffs.</div><div><br></div><div>I don't need syntax highlighting at the cost of slowness and polluted recentf history.<br></div></div> --0000000000005c556c05f8fa527c--
bug-gnu-emacs@HIDDEN:bug#62749; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 10 Apr 2023 12:11:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 10 08:11:32 2023 Received: from localhost ([127.0.0.1]:34473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1plqMt-0007lB-SZ for submit <at> debbugs.gnu.org; Mon, 10 Apr 2023 08:11:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:49836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <gavenkoa@HIDDEN>) id 1plqMs-0007l4-7L for submit <at> debbugs.gnu.org; Mon, 10 Apr 2023 08:11:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <gavenkoa@HIDDEN>) id 1plqMr-0004Kq-EE for bug-gnu-emacs@HIDDEN; Mon, 10 Apr 2023 08:11:29 -0400 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <gavenkoa@HIDDEN>) id 1plqMp-0005Xw-KA for bug-gnu-emacs@HIDDEN; Mon, 10 Apr 2023 08:11:29 -0400 Received: by mail-ej1-x62f.google.com with SMTP id ud9so11825618ejc.7 for <bug-gnu-emacs@HIDDEN>; Mon, 10 Apr 2023 05:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681128685; x=1683720685; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=gGyfIMz5lOfyKWazZB/HiLCTKGNB0DhbM4WImQvfbs4=; b=ffz/+/rI9ciHQoE9DrZU5KppZF9THb1nuVyHnUI/3mwtQMkCBa+nCQiV0TVnZlG72E mSqqozg1178YQcEtY3pvrdInwijdNKpv2QWQadc+n27s3enXEpGUFtbk1yf4Uir5KTSd xQayQHlH+OUDbnpqv77Xnxu7j18A4unmhciWNP2U7431J6VOPwUFgnWrpoIDU4R4zUuL XSdRrA0Tiyr+CYHv22escCSq370p6VEO8KtjMDgznOgXHSG89Xpb7jIXTbmdacKtPf+R AbC5NI+Tz9DxDF/qtNvZ7EZ0MgWfM6XN2u6V5vaE+ZMVJbgmDcnS94ZO00G6OmoRbJ15 U3RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681128685; x=1683720685; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gGyfIMz5lOfyKWazZB/HiLCTKGNB0DhbM4WImQvfbs4=; b=IfhOQi5STihC+baxjXxqdPKo68hhVadTyP5DJBrO4tBzE+GpYbo8qtoCEBB6rh8Y/1 U3uWB2W7KPAybjnnNTEvAQKIBgAN18SIq+ECPZFTt5zyxDaPiQ7CYC/ZXPPCpETViKGO rJDwEGqk/tUa2caMXj2k6/VTaaA1KBXfM1Knr2SGWkCSNvgkQxS/KlAbqdrYRNXa6oX/ 67GLzNubL5rh42RbzfVGyLnb4enkY63HC6J2lKacWGUzW4Vfzf0dGc+bn8nU4A2pWf78 GW3fVvUAzJlAM0RE+yXZZcw0pfljKv03/VEXywDAqid9BORKMtBNtP6Go/26Na3uHi9p C/zg== X-Gm-Message-State: AAQBX9dCeNWYXvmGeTxMg3L/y8G1q05gMVoFVxsY24R9G8uolQSIGX3E YQ9zHiWggeHug9HnYygIpz0HMRD9F5c= X-Google-Smtp-Source: AKy350YF2f2wRr7xWuAzPFo+xn/VGBTAzQPdjxX6DVWZSNwRtIAS0bM3T1GJzLOjQwP28uMXEOyzJA== X-Received: by 2002:a17:907:8dc6:b0:94a:4eba:45d3 with SMTP id tg6-20020a1709078dc600b0094a4eba45d3mr5555728ejc.30.1681128685605; Mon, 10 Apr 2023 05:11:25 -0700 (PDT) Received: from msi ([46.118.60.213]) by smtp.gmail.com with ESMTPSA id n14-20020a1709065dae00b009334219656dsm5017242ejv.56.2023.04.10.05.11.24 for <bug-gnu-emacs@HIDDEN> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Apr 2023 05:11:25 -0700 (PDT) From: Oleksandr Gavenko <gavenkoa@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 28.2; Emacs keeps opening related file from vc-diff buffer Date: Mon, 10 Apr 2023 15:11:24 +0300 Message-ID: <vriuh6to9btf.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::62f; envelope-from=gavenkoa@HIDDEN; helo=mail-ej1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_PDS_OTHER_BAD_TLD=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) In GNU Emacs 28.2 (build 1, x86_64-pc-cygwin) of 2022-09-16 built on fv-az140-985 Repository revision: 70134aa8264ded36d80248204b2ba43ae3d8f599 Whenever I open vc-diff buffer by "d" (log-view-diff) to read repository history from "C-x v L" (vc-print-root-log) Emacs opens all files referenced by diff. The diff might be very big so: * I end with lots of opened files that I need eventually close. * Emacs pollutes recentf history - I don't want robotically opened file mixed with human opened files. * Cygwin is slow (especially under antivirus supervision) file opening delays Emacs for many seconds. Initially I asked for help in Emacs 27.1: https://emacs.stackexchange.com/questions/61760/lags-when-navigating-vc-root-diff-buffer/ and found workaround with: (setq diff-font-lock-syntax nil) But with Emacs v28.2 it doesn't work, I asked for help once more: https://emacs.stackexchange.com/questions/76728/modern-emacs-keeps-opening-related-file-from-vc-diff-buffer -- http://defun.work/
Oleksandr Gavenko <gavenkoa@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#62749; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.