Received: (at 62767) by debbugs.gnu.org; 19 Apr 2023 05:11:31 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 19 01:11:30 2023 Received: from localhost ([127.0.0.1]:60890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pp06M-00053S-H4 for submit <at> debbugs.gnu.org; Wed, 19 Apr 2023 01:11:30 -0400 Received: from sonic306-20.consmr.mail.ne1.yahoo.com ([66.163.189.82]:33781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <sunlin7@HIDDEN>) id 1pp06J-00053D-RI for 62767 <at> debbugs.gnu.org; Wed, 19 Apr 2023 01:11:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681881082; bh=yqA9yUlNpb4zi0QJ73BuL/TGUJ62xIrD76B13T/s4cc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From:Subject:Reply-To; b=nZIqxx1GJrhNpbP3uiB8q4q+iodCO3lUZlx7WllZPAi3KlzBCoH7fuNPdWyu79wlA0INKKR00Csk4zEs/0VFq5rV6X1qsvvdLj351CpGhiJYCkjze57tZmqRzd5NQGOWjuN17XPHLeEK2tsb7gvkJ9En7+qtid25+Kp/vp1/ZQ63WSyt4yJyROZcDsY8elKI9U3wuEqRqK7jmTAkUqPSE3QjPU4GWR4Thn6TsJ38Tbdk4ZsVncZ7KcZxLKqjeI5ra/rA2AGw7kYEmoC+bP54JK4XnOXmKjv9IzX+bZ4h4gLw1aCIQhwK/yN3y6hZtPzgE0G4ocg/+Gpyiw3R45w/VA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681881082; bh=n68/f3PujGDRzL0HWMP5/aGtNgJqiNwBUEz3CxdcsxI=; h=X-Sonic-MF:From:Date:Subject:To:From:Subject; b=XdXfV1UiLp59jfRv8nhIALvKByKS2WufjKBW5oJKAxwF0V6v2szNO3dZflfdgyqFK99RI1uP42YRgLYkjZaaRMCTkUx0tpGVs6ENnJHfmt0FwevBNDrRVi/gGwxeeCUw36D20MWYdvkNR30Af7d7owF63U3afjV/3tYp1/Lom++HyY7QERYYeKSMyNyeAvmvu9RLxLJaKxdda0zMsqBwg/2keMkuoz5fEQkgnof2uuM+BKxmx4YwDXWUZTbpEptL9es2VPBEgD8kUdqd0LSRivYdCKo3Cz0nKIRAVqYzvYMbAr7N4gkhMDBIqUyyKefSKd6ecYHCU1naWhIq/d+NmA== X-YMail-OSG: 2VmRljwVM1knzxjHiBNuHaZ3Qz0bV8tEmNZNTz4MqQ7dlonJEQ.mm1pE2fcBc4X T1NiEMUSLjBzw_Rl3cfPSx3I_1iqvKb1eKrpveUYVO48pGCS_I1zurt.0yoalpwcpZoXtdAZGodB kRzADmqAURBX8_VxXSvjRqgKor4TdRcp14MG0vxitcVxRAVvhlWzf0zLyCVX5aTl2eUNBOZm77O1 7ufLMyBdXzmuPeFZxMXQUf5wTtYdg3csksyOsrkgsq0f2Aq.VA2H3QJmBOvdRBJIjDMVqzYhu6fq BeJPExcD_BPXOBlhHZCA046fo.hm9h6IoS9c6hhNVkwgo0X8Xxhnb5Ig1P.qxJP1dlKSpWajHw.2 W76lkAvC5KtAaP9WOcw33.bWkqKgjPv91OkW.Vbj0HkORo42ZOfHxPXiY0vEl9UH4ktVDL.YaK3S BX1tyLPFXo5mYX7ueXKztWgXH_ZufS59foKZSwnhYZqiVCOMKd_AWNQyROa5WRX.xZuyL4rvRPLL JRupwJ1L.EdqYnO.9VXGJugAYMDAnW_8g4R14nxJxF.99te_dabuZR8nZvZo3IsiHIIlRfdz.XcT qb.ZU164bCfBI1qewwiErRQkXp8UYf42JkqKLamgGTf7xh4pBBRBo2jrHANGRp62Bd8QxzGvv5RU jY1w.4xzrE4veEN6yT1vn.8UWj63v8SXbyon__RLyo9jO6D3mZ9pQni6P0c.igSgTdksCXoS0Muj Wrz9313YAKXMr_vdmFFQ3JASwVDAnC5iyohBsbtWS75H7EgieKXDcWWXPLbfaCEl1hYzr9VD3YZZ Am5IDL34E3OWRhAinB1IOWs9eNj.mKMGFiGZw.dWyAC4a77C3XatF_sI7Vp9LB.X316Jx18WGA8B pd.FQJiUzg1KgyfYYLJtVANBvVQxfv47RQ3nUN_11H6VBjiSoANI_vvw4M9iEY6YCNNvCrZOV5fL oJTxE5giRm3DZMN0oWxBwN_EZ2gCyhqizgFZsCwt_rm4tcHBmt6qgZ.OUP3sfgAOLbqQ_TvITnHV P83BSQ1k2SSdQsI7IFiFbUFUMYCm4kWi9VoT6mQa.UT8E4jeF5x.et.aPhQuTo1lDuEWV3y9epTB 5Z.Fo2PqmJzNQn8LCNbR.zuU3mL8QMdpunGLUQqi6cwTZ08FzTTWvtv4fOzUz8wG_GRUsqezblNq XZUMUj7bElV9UzCjOM5nou9GUdxK4k4vPKJdel2q4fqFQjVDZOdgTQu3N_q7ndbvoH8TU_8zrrkL GtT_0gbbXsyHxhjdtgmfUbWro03qel_Q5hTfM4PUsUFollnLSySJTkwSZ9gBMTyeYOkVADg_LQHE hZAKYpWwiEYN8J2grvq4IvqEGiEOIHBV_3hLFO84bFxx2qoajwVQeYwh1Yvp5LCLqIu2njUbgqXk SQGSDNOU8dKcJyk66sE5T7IPZte7czO6zzMOKI67mpSooZbIK.TqFigjE2RgW4XcaPBnyJERuSYd RxCYY0oB2IX21vSYfQpd7URW_A9W8mTNl2z0ISSaOiJ26vRjPJudK1VVvVkxpnIuBufiYJk4gVjL bkJ6VLl53HMtk8ZEBJqsFqseYG.Syqb3wbPRMiKZNuqlTXr1LWTEejFGSvesv5ssOHZ7SfHd.0ZZ yMZjeToRxdJiRDrdz1jSzyoiK77Fxd.ol0SLjrEQ8X.GJpWrlfEQXevRH2.J0Hlqloh7qTpQ6R1L uxuqzzb6rf9WmBCOVVRq5Iq1o4omBfg6dNelGzscfgW85cVf_xB5zEnIwipl65.ydbMxUBVv5Dhc dzbtbL6MWGhbv3WFFG_rdQmsGZk3tfHnzmwxDVHKeQLzLsJWseMjrPyNkK.3N1PEzEje1XMgYvmn Uyy3XPApOQD9dhufznvYo5qXzJOsBUpjAWcq5Z5GP8n0Xarcygi44IRIzlV2Gebf_1biT.lwx1OM _tiKoCwSlteI5X2OSANZkgFpLgCcJvzzIFESoZ63YTbn2.ydj8sS9AkbplfzQJftx13pfO3JIJ0h unX_0OOVa_uh5k4MaDMsfS2BERc8MqWEBbpwfvj3MxmEEk9gTalafwwGcLurAOytJGJYlnx_mBsX ghaEgqFbk2RjSQMsvoT8tB.6Kw9VU8gMP.AmS8bQHE9cHU0ayhDvrHHG3Pge53uwwBDPE71wIZXu QRYoacK_HXmrcefvg3LLF_O.vpxM71RkinFPHbj.ipYZxxH_wpo57CXmraSS3Qy.FyRM78DGN8Jj XOQ5c0zPE1ii6GpmNERDgvlMMZDFX7OwPYZC19iU1YGdWN16xeyvsoVMNTYQxvz4sZQXwYWo- X-Sonic-MF: <sunlin7@HIDDEN> X-Sonic-ID: 62dcdc05-ee2b-4f8c-b2ac-0a893fd20c83 Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Wed, 19 Apr 2023 05:11:22 +0000 Received: by hermes--production-ir2-74cd8fc864-ggn56 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e02188be47386765eec654992e9c67d1; Wed, 19 Apr 2023 05:11:16 +0000 (UTC) Received: by mail-ej1-f44.google.com with SMTP id u3so26589384ejj.12 for <62767 <at> debbugs.gnu.org>; Tue, 18 Apr 2023 22:11:16 -0700 (PDT) X-Gm-Message-State: AAQBX9etzQS2UzcM8kcr4pg+E9Nat5JNZGMoKOkZGh146aafn+BMU0di 7ZxqAwRj6Kc0cMKv75vegKRjVvBwTzIlriKgSYo= X-Google-Smtp-Source: AKy350ZMwihBe8fuFS/bcBeGrao134ymDRM+2xEwCdMvEHa/fmjhjHpol3sUcMgpQrr1Ns0dsIZyHlHcyO9U3gL2JDM= X-Received: by 2002:a17:906:fac1:b0:94e:cf98:32f2 with SMTP id lu1-20020a170906fac100b0094ecf9832f2mr13656633ejb.33.1681881075093; Tue, 18 Apr 2023 22:11:15 -0700 (PDT) MIME-Version: 1.0 References: <1181651021.466162.1581309285621.ref@HIDDEN> <1181651021.466162.1581309285621@HIDDEN> <CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN> <CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN> <CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN> <CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN> <CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN> <CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN> <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN> <87sfd2ns6d.fsf@HIDDEN> <833551ecb2.fsf@HIDDEN> <87ttxh4e9i.fsf@HIDDEN> <CABCREdomqNHQ7Q018WEQ=X2-e1ZKdRCOBvtiof4yLKEzZXhVGw@HIDDEN> <87bkjmiqtz.fsf@HIDDEN> <jwv354y8p3p.fsf-monnier+emacs@HIDDEN> In-Reply-To: <jwv354y8p3p.fsf-monnier+emacs@HIDDEN> From: lin Sun <sunlin7@HIDDEN> Date: Wed, 19 Apr 2023 05:11:03 +0000 X-Gmail-Original-Message-ID: <CABCREdpqVFNs+90sONO1NNoLvAL8f2wAWLSMZCEChirKE6Yp7Q@HIDDEN> Message-ID: <CABCREdpqVFNs+90sONO1NNoLvAL8f2wAWLSMZCEChirKE6Yp7Q@HIDDEN> Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package To: Stefan Monnier <monnier@HIDDEN> Content-Type: multipart/mixed; boundary="000000000000092a7d05f9a9740e" X-Mailer: WebService/1.1.21365 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 4705 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 62767 Cc: 62767 <at> debbugs.gnu.org, Philip Kaludercic <philipk@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.8 (/) --000000000000092a7d05f9a9740e Content-Type: text/plain; charset="UTF-8" Hi Eli, I had researched the `info.el', and found the variable `Info-default-directory-list' is a more proper variable than the original `Info-directory-list', which is an autoload customer variable. Then the patch can be simpler than the previous one, I attached the new patch, it avoided to require 'info. I verified it on my local. Please help review the change, thanks ! --000000000000092a7d05f9a9740e Content-Type: text/x-patch; charset="US-ASCII"; name="0001-lisp-emacs-lisp-package.el-avoid-to-load-the-entire-.patch" Content-Disposition: attachment; filename="0001-lisp-emacs-lisp-package.el-avoid-to-load-the-entire-.patch" Content-Transfer-Encoding: base64 Content-ID: <f_lgn8k44e0> X-Attachment-Id: f_lgn8k44e0 RnJvbSAxYjkzYzU0NjljOTgyNTRlMWM2YWI3NDk0MjcyNDAxYzVlOTdkZGY1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBU dWUsIDExIEFwciAyMDIzIDAwOjAwOjEzICswMDAwClN1YmplY3Q6IFtQQVRDSF0gKmxpc3AvZW1h Y3MtbGlzcC9wYWNrYWdlLmVsOiBhdm9pZCB0byBsb2FkIHRoZSBlbnRpcmUgaW5mbwogcGFja2Fn ZQoKLS0tCiBsaXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbCB8IDE5ICsrKysrKystLS0tLS0tLS0t LS0KIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsIGIvbGlzcC9lbWFjcy1saXNwL3Bh Y2thZ2UuZWwKaW5kZXggZmZhNjI3MmRkMS4uZmIyNmNmZjQ2MyAxMDA2NDQKLS0tIGEvbGlzcC9l bWFjcy1saXNwL3BhY2thZ2UuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwKQEAg LTgxOSw3ICs4MTksNyBAQCBwYWNrYWdlLS1hdXRvbG9hZHMtZmlsZS1uYW1lCiAgICAoZm9ybWF0 ICIlcy1hdXRvbG9hZHMiIChwYWNrYWdlLWRlc2MtbmFtZSBwa2ctZGVzYykpCiAgICAocGFja2Fn ZS1kZXNjLWRpciBwa2ctZGVzYykpKQogCi0oZGVmdmFyIEluZm8tZGlyZWN0b3J5LWxpc3QpCiso ZGVmdmFyIEluZm8tZGVmYXVsdC1kaXJlY3RvcnktbGlzdCkKIChkZWNsYXJlLWZ1bmN0aW9uIGlu Zm8taW5pdGlhbGl6ZSAiaW5mbyIgKCkpCiAKIChkZWZ2YXIgcGFja2FnZS0tcXVpY2tzdGFydC1w a2dzIHQKQEAgLTkwNywxMCArOTA3LDcgQEAgcGFja2FnZS1hY3RpdmF0ZS0xCiAgICAgICAgIChh ZGQtdG8tbGlzdCAnbG9hZC1wYXRoIChkaXJlY3RvcnktZmlsZS1uYW1lIHBrZy1kaXIpKSkKICAg ICAgIDs7IEFkZCBpbmZvIG5vZGUuCiAgICAgICAod2hlbiAoZmlsZS1leGlzdHMtcCAoZXhwYW5k LWZpbGUtbmFtZSAiZGlyIiBwa2ctZGlyKSkKLSAgICAgICAgOzsgRklYTUU6IG5vdCB0aGUgZnJp ZW5kbGllc3QsIGJ1dCBzaW1wbGUuCi0gICAgICAgIChyZXF1aXJlICdpbmZvKQotICAgICAgICAo aW5mby1pbml0aWFsaXplKQotICAgICAgICAoYWRkLXRvLWxpc3QgJ0luZm8tZGlyZWN0b3J5LWxp c3QgcGtnLWRpcikpCisgICAgICAgIChhZGQtdG8tbGlzdCAnSW5mby1kZWZhdWx0LWRpcmVjdG9y eS1saXN0IHBrZy1kaXIpKQogICAgICAgKHB1c2ggbmFtZSBwYWNrYWdlLWFjdGl2YXRlZC1saXN0 KQogICAgICAgOzsgRG9uJ3QgcmV0dXJuIG5pbC4KICAgICAgIHQpKSkKQEAgLTQ0NTgsNyArNDQ1 NSw2IEBAIHBhY2thZ2UtcXVpY2tzdGFydC1yZWZyZXNoCiAgICIoUmUpR2VuZXJhdGUgdGhlIGBw YWNrYWdlLXF1aWNrc3RhcnQtZmlsZScuIgogICAoaW50ZXJhY3RpdmUpCiAgIChwYWNrYWdlLWlu aXRpYWxpemUgJ25vLWFjdGl2YXRlKQotICAocmVxdWlyZSAnaW5mbykKICAgKGxldCAoKHBhY2th Z2UtLXF1aWNrc3RhcnQtcGtncyAoKSkKICAgICAgICAgOzsgUHJldGVuZCB3ZSBoYXZlbid0IGFj dGl2YXRlZCBhbnl0aGluZyB5ZXQhCiAgICAgICAgIChwYWNrYWdlLWFjdGl2YXRlZC1saXN0ICgp KQpAQCAtNDQ2OCw3ICs0NDY0LDcgQEAgcGFja2FnZS1xdWlja3N0YXJ0LXJlZnJlc2gKICAgICAg ICAgOzsgYXJlbid0IHRydW5jYXRlZC4KICAgICAgICAgKHByaW50LWxlbmd0aCBuaWwpCiAgICAg ICAgIChwcmludC1sZXZlbCBuaWwpCi0gICAgICAgIChJbmZvLWRpcmVjdG9yeS1saXN0ICcoIiIp KSkKKyAgICAgICAgKEluZm8tZGVmYXVsdC1kaXJlY3RvcnktbGlzdCAnKCIiKSkpCiAgICAgKGRv bGlzdCAoZWx0IHBhY2thZ2UtYWxpc3QpCiAgICAgICAoY29uZGl0aW9uLWNhc2UgZXJyCiAgICAg ICAgICAgKHBhY2thZ2UtYWN0aXZhdGUgKGNhciBlbHQpKQpAQCAtNDUwMSwxMiArNDQ5NywxMSBA QCBwYWNrYWdlLXF1aWNrc3RhcnQtcmVmcmVzaAogICAgICAgICAgICAgICAgICAgKGFwcGVuZCAn LChtYXBjYXIgIydwYWNrYWdlLWRlc2MtbmFtZSBwYWNrYWdlLS1xdWlja3N0YXJ0LXBrZ3MpCiAg ICAgICAgICAgICAgICAgICAgICAgICAgIHBhY2thZ2UtYWN0aXZhdGVkLWxpc3QpKSkKICAgICAg ICAgICAoY3VycmVudC1idWZmZXIpKQotICAgICAgKGxldCAoKGluZm8tZGlycyAoYnV0bGFzdCBJ bmZvLWRpcmVjdG9yeS1saXN0KSkpCisgICAgICAobGV0ICgoaW5mby1kaXJzIChidXRsYXN0IElu Zm8tZGVmYXVsdC1kaXJlY3RvcnktbGlzdCkpKQogICAgICAgICAod2hlbiBpbmZvLWRpcnMKLSAg ICAgICAgICAocHAgYChwcm9nbiAocmVxdWlyZSAnaW5mbykKLSAgICAgICAgICAgICAgICAgICAg ICAoaW5mby1pbml0aWFsaXplKQotICAgICAgICAgICAgICAgICAgICAgIChzZXRxIEluZm8tZGly ZWN0b3J5LWxpc3QKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYXBwZW5kICcsaW5mby1k aXJzIEluZm8tZGlyZWN0b3J5LWxpc3QpKSkKKyAgICAgICAgICAocHAgYChkZWZ2YXIgSW5mby1k ZWZhdWx0LWRpcmVjdG9yeS1saXN0KSAoY3VycmVudC1idWZmZXIpKQorICAgICAgICAgIChwcCBg KHNldHEgSW5mby1kZWZhdWx0LWRpcmVjdG9yeS1saXN0CisgICAgICAgICAgICAgICAgICAgICAo YXBwZW5kICcsaW5mby1kaXJzIEluZm8tZGVmYXVsdC1kaXJlY3RvcnktbGlzdCkpCiAgICAgICAg ICAgICAgIChjdXJyZW50LWJ1ZmZlcikpKSkKICAgICAgIDs7IFVzZSBgXHMnIGluc3RlYWQgb2Yg YSBzcGFjZSBjaGFyYWN0ZXIsIHNvIHRoaXMgY29kZSBjaHVuayBpcyBub3QKICAgICAgIDs7IG1p c3Rha2VuIGZvciBhbiBhY3R1YWwgZmlsZS1sb2NhbCBzZWN0aW9uIG9mIHBhY2thZ2UuZWwuCi0t IAoyLjIwLjUKCg== --000000000000092a7d05f9a9740e--
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.Received: (at 62767) by debbugs.gnu.org; 17 Apr 2023 17:25:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 17 13:25:47 2023 Received: from localhost ([127.0.0.1]:55947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1poSbq-0004qQ-OI for submit <at> debbugs.gnu.org; Mon, 17 Apr 2023 13:25:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1poSbo-0004qB-CB for 62767 <at> debbugs.gnu.org; Mon, 17 Apr 2023 13:25:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1poSbi-0000ca-Jb; Mon, 17 Apr 2023 13:25:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=hIvzYmy4JIOoz+bTyV8pe8AcSs3WKV1CmLAkizj9bIk=; b=Rm+VClPvrxrU 5f0M5TKMTkTAJNWaKBlT+8WXIMlJWE0ibXcCngdUkKQ4coxC+nCz0mrPcTosrQIsIVNCB934sh1wX sey7UhxRY9aNdZdlK7i8giytfzGHAlIXoggPuBwIwPdsKFGm3x1fzjs32zsDCaVKI6yAY2VW76oh0 baD1M/gvFHx3hkhsR9IAx0k24Wd6jEyIZOQjyBSa4BT5MZa/n0P7RR2UmMl2b5GSjTHsIwYIcLnwC vDNz24tbCUlEG1107Ivjtqt0CJ/+KIqPYSCmEUTDhlmIgW2q7V84wj66671sUBn3H/qYRq9p006UR yylP8907ME3JK9km1KmZ9w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1poSbi-0004ls-3r; Mon, 17 Apr 2023 13:25:38 -0400 Date: Mon, 17 Apr 2023 20:25:43 +0300 Message-Id: <83cz42a0a0.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: lin Sun <sunlin7@HIDDEN> In-Reply-To: <CABCREdqYGqTRocmNagp7-uzjHQECD1YG5xNdn9mkHNtZLOO_3A@HIDDEN> (message from lin Sun on Mon, 17 Apr 2023 15:27:09 +0000) Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package References: <1181651021.466162.1581309285621.ref@HIDDEN> <1181651021.466162.1581309285621@HIDDEN> <CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN> <CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN> <CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN> <CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN> <CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN> <CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN> <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN> <87sfd2ns6d.fsf@HIDDEN> <833551ecb2.fsf@HIDDEN> <87ttxh4e9i.fsf@HIDDEN> <CABCREdomqNHQ7Q018WEQ=X2-e1ZKdRCOBvtiof4yLKEzZXhVGw@HIDDEN> <87bkjmiqtz.fsf@HIDDEN> <CABCREdqYGqTRocmNagp7-uzjHQECD1YG5xNdn9mkHNtZLOO_3A@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62767 Cc: 62767 <at> debbugs.gnu.org, philipk@HIDDEN, monnier@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: lin Sun <sunlin7@HIDDEN> > Date: Mon, 17 Apr 2023 15:27:09 +0000 > Cc: Eli Zaretskii <eliz@HIDDEN>, 62767 <at> debbugs.gnu.org, > Stefan Monnier <monnier@HIDDEN> > > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -892,10 +892,9 @@ package-activate-1 > (add-to-list 'load-path (directory-file-name pkg-dir))) > ;; Add info node. > (when (file-exists-p (expand-file-name "dir" pkg-dir)) > - ;; FIXME: not the friendliest, but simple. > - (require 'info) > - (info-initialize) > - (add-to-list 'Info-directory-list pkg-dir)) > + (with-eval-after-load 'info > + (info-initialize) > + (add-to-list 'Info-directory-list pkg-dir))) > (push name package-activated-list) > ;; Don't return nil. > t))) > @@ -4427,7 +4426,7 @@ package-quickstart-refresh > "(Re)Generate the `package-quickstart-file'." > (interactive) > (package-initialize 'no-activate) > - (require 'info) > + (require 'info) ; ensure Info-directory-list available for package-activate > (let ((package--quickstart-pkgs ()) > ;; Pretend we haven't activated anything yet! > (package-activated-list ()) > @@ -4472,10 +4471,10 @@ package-quickstart-refresh > (current-buffer)) > (let ((info-dirs (butlast Info-directory-list))) > (when info-dirs > - (pp `(progn (require 'info) > - (info-initialize) > - (setq Info-directory-list > - (append ',info-dirs Info-directory-list))) > + (pp `(with-eval-after-load 'info > + (info-initialize) > + (setq Info-directory-list > + (append ',info-dirs Info-directory-list))) > (current-buffer)))) > ;; Use `\s' instead of a space character, so this code chunk is not > ;; mistaken for an actual file-local section of package.el. > -- > 2.20.5 I don't know yet whether I'm okay with this change, but if this does go in, this tricky/unusual code must have comments explaining why on Earth we do it this way, and only with info.el.
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.
Received: (at 62767) by debbugs.gnu.org; 17 Apr 2023 16:30:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 17 12:30:30 2023
Received: from localhost ([127.0.0.1]:55918 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1poRkL-0003GQ-Vi
for submit <at> debbugs.gnu.org; Mon, 17 Apr 2023 12:30:30 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47374)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <monnier@HIDDEN>) id 1poRkJ-0003G9-Jg
for 62767 <at> debbugs.gnu.org; Mon, 17 Apr 2023 12:30:28 -0400
Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E692F1000BF;
Mon, 17 Apr 2023 12:30:21 -0400 (EDT)
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7AFC61000A3;
Mon, 17 Apr 2023 12:30:20 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1681749020;
bh=8qxFY6FQ0/M6AnWhjof28nGz3BZvMROZzZy+GFegSG0=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=k7PGDm2S1luhPrppqEWdXS9hc1mjDXjzVpRK7vYYla8rLCdcHNqbmwe+nCx3aMkrT
QYtqdbs8KmQJZ8ODStxZFJsitNKp6icGqnXZ1ilLtVkW7nfjYdT3B7S/UKPjPWq3xu
teBsLMhXotXraZmtw5DyddWgff3kB+TefNYUdl8ifphdG3AvCD+wR/OnwNtDEH+B+y
Z26dUV/PhDpoBC1478DZtqhY6blh5gR8Gwi1LvA6NjQJ+GTRyvsgzguFe8JAFiksij
eWIh0Q9PyZAhniMRgw9iKQu29vcyoiusKNpMrpSdA9Da65quW6Di7p8ADdBLGYTGcD
bxFCKbDbMMtMw==
Received: from alfajor (unknown [45.44.229.252])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 526951203D4;
Mon, 17 Apr 2023 12:30:20 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Philip Kaludercic <philipk@HIDDEN>
Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set
variables after info package
In-Reply-To: <87bkjmiqtz.fsf@HIDDEN> (Philip Kaludercic's message of "Mon,
17 Apr 2023 13:24:56 +0000")
Message-ID: <jwv354y8p3p.fsf-monnier+emacs@HIDDEN>
References: <1181651021.466162.1581309285621.ref@HIDDEN>
<1181651021.466162.1581309285621@HIDDEN>
<CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN>
<CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN>
<CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN>
<CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN>
<CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN>
<CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN>
<CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN>
<87sfd2ns6d.fsf@HIDDEN> <833551ecb2.fsf@HIDDEN>
<87ttxh4e9i.fsf@HIDDEN>
<CABCREdomqNHQ7Q018WEQ=X2-e1ZKdRCOBvtiof4yLKEzZXhVGw@HIDDEN>
<87bkjmiqtz.fsf@HIDDEN>
Date: Mon, 17 Apr 2023 12:30:19 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.016 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain T_SCC_BODY_TEXT_LINE -0.01 -
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62767
Cc: 62767 <at> debbugs.gnu.org, lin Sun <sunlin7@HIDDEN>,
Eli Zaretskii <eliz@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> OK, then we still have to find out if these changes are safe. As
> mentioned before, I hesitate in using `with-eval-after-load', probably
> because of the complicated history of `eval-after-load'. I suppose that
> Stefan might know more (as it is due to him that I am careful here), so
> I have added him to the thread.
The problem with eval-after-load is not the history but the fact that
it has various corner-case caveats.
(with-eval-after-load "compile" ...) for example makes it unclear
exactly when it should be executed, e.g.:
(load "compile") => yes clearly.
(load "compile.el") => probably, yes.
(load "srecode/compile.el") => probably not.
(load "/foo/bar/lisp/compile.el") => hmm... yeah, I think so.
(load "/foo/bar/lisp/srecode/compile.el") => hmm... nah, maybe not.
The next game is to try and guess what the code does, to see when it
matches expectations.
The use (with-eval-after-load 'info ...) is much better in this respect
because it's not linked to the file name but to the feature name, which
is precise.
But there's still the issue of exactly when this is executed. Should it
be executed just the next time the file is loaded (usually what's
wanted), or every other time after that as well (what actually happens)?
Also the implementation for the good case where we provide a feature
name rather than a file name is a bit roundabout/fiddly. This is an
internal problem, so any bug there can be fixed, thus it's probably not
a good reason not to use it, but it still makes me prefer to avoid it :-)
I wish there was an easier way to add to `Info-directory-list`.
That variable is set in a fairly delicate manner, so I think Eli would
be better placed to come up with a better long term solution.
Maybe we should just add a (preloaded) `Info-extra-directory-list`?
In the mean time, Lin Sun's patch is probably "as good as it gets" if
you want to load `info.el` lazily (which I obviously didn't bother to do
when I wrote that code :-)
Stefan
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.
Received: (at 62767) by debbugs.gnu.org; 17 Apr 2023 16:03:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 17 12:03:35 2023
Received: from localhost ([127.0.0.1]:55876 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1poRKJ-0002Wz-AN
for submit <at> debbugs.gnu.org; Mon, 17 Apr 2023 12:03:35 -0400
Received: from mout02.posteo.de ([185.67.36.66]:45769)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <philipk@HIDDEN>) id 1poRKG-0002WZ-5R
for 62767 <at> debbugs.gnu.org; Mon, 17 Apr 2023 12:03:32 -0400
Received: from submission (posteo.de [185.67.36.169])
by mout02.posteo.de (Postfix) with ESMTPS id A7C45240242
for <62767 <at> debbugs.gnu.org>; Mon, 17 Apr 2023 18:03:26 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
t=1681747406; bh=KHKj4TgAjdbNwHpJYLvPY9h0hU0Dl+gXiofdg97YSU4=;
h=From:To:Cc:Subject:Autocrypt:Date:From;
b=NRoOEQv/DrE7yqRuaR+tlDdnlkLkY1yJvAqfsBn8gHHWRLRvO49DpZjDrwQSJ6Gq7
Ach7vQYISULO8x3E1bS2eo8bDz0Ce6m19ji+K6D3MKOh8tw8QgRciD6ewEcrfL1Mq/
685YxIE5sHXg6Hl+6ueNDEzi3bUaE0KWlaI/BQ1iO/qG8kfO9RFKxau0IyOnyhaC7j
YOQXjBQ3NX6APjqLVl9CWAYmIvSTc4YB5xNqHi2Wvz5Uufy/+kI7/g8PoEv+QmFS4Q
otoYKIcbY6asszR7iMw7/HaqPcQ997WI2w/1q1ZPgrvbd3IM45cuVqoUkMV9zau5l3
B5F2DepGOhNEA==
Received: from customer (localhost [127.0.0.1])
by submission (posteo.de) with ESMTPSA id 4Q0X0F6sM1z6tyL;
Mon, 17 Apr 2023 18:03:25 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: lin Sun <sunlin7@HIDDEN>
Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set
variables after info package
In-Reply-To: <CABCREdqYGqTRocmNagp7-uzjHQECD1YG5xNdn9mkHNtZLOO_3A@HIDDEN>
(lin Sun's message of "Mon, 17 Apr 2023 15:27:09 +0000")
References: <1181651021.466162.1581309285621.ref@HIDDEN>
<1181651021.466162.1581309285621@HIDDEN>
<CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN>
<CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN>
<CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN>
<CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN>
<CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN>
<CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN>
<CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN>
<87sfd2ns6d.fsf@HIDDEN> <833551ecb2.fsf@HIDDEN>
<87ttxh4e9i.fsf@HIDDEN>
<CABCREdomqNHQ7Q018WEQ=X2-e1ZKdRCOBvtiof4yLKEzZXhVGw@HIDDEN>
<87bkjmiqtz.fsf@HIDDEN>
<CABCREdqYGqTRocmNagp7-uzjHQECD1YG5xNdn9mkHNtZLOO_3A@HIDDEN>
Autocrypt: addr=philipk@HIDDEN; keydata=
mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo
aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI
BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0
mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB
BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE
Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK
NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof
z4oM
Date: Mon, 17 Apr 2023 16:03:56 +0000
Message-ID: <87r0sih4wj.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62767
Cc: 62767 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>,
Stefan Monnier <monnier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
lin Sun <sunlin7@HIDDEN> writes:
> Hi Philip,
>
>> How did you come to the conclusion about the second one?
> The 2nd one is necessary because the following lines will use the full
> `Info-directory-list` to print its values into the
> package-quickstart.el, whose value was modified by the function
> `package-activate'.
> If I comment out or use the `eval-after-load` on the 2nd one, the
> `Info-directory-list` will be empty, and missed in the
> package-quickstart.el file.
OK, I get it now. I was confused because it seemed as though
`Info-directory-list' could just be bound and declared using a defvar
before the function, but if we do not load info then the
with-eval-after-load blocks in `package-activate-1' that are invoked for
the side effect of manipulating `Info-directory-list' do not get
evaluated, which is why we see that the value is empty.
But as the function `package-quickstart-refresh' is not invoked on
startup, but as `package-quickstart' says
This requires the use of `package-quickstart-refresh' every time the
activations need to be changed, such as when `package-load-list' is
modified.
This should be fine.
> Hi Ruijie,
>
>> "insure" -> "ensure"?
> You're right.
> I had fixed my typo in the patch file (only typo in comment), and
> attached the new one, please help review again. Thanks
Again, assuming that there is no issue with `with-eval-after-load', the
code should be fine. The commit message looks a bit distorted though?
Did you generate it using C-c C-w? I get this template when I apply
your commit:
* lisp/emacs-lisp/package.el (package-activate-1):
(package-quickstart-refresh):
Also, it would make sense to motivate the changes in more detail. What
do the changes improve?
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.Received: (at 62767) by debbugs.gnu.org; 17 Apr 2023 15:27:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 17 11:27:35 2023 Received: from localhost ([127.0.0.1]:55805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1poQlT-0001BT-02 for submit <at> debbugs.gnu.org; Mon, 17 Apr 2023 11:27:35 -0400 Received: from sonic316-20.consmr.mail.ne1.yahoo.com ([66.163.187.146]:45435) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <sunlin7@HIDDEN>) id 1poQlQ-0001BE-Ja for 62767 <at> debbugs.gnu.org; Mon, 17 Apr 2023 11:27:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681745246; bh=spud8qIqYsAX8/5TNx3kjgZle005/U+PZm/GlS35y84=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From:Subject:Reply-To; b=qUn7qsd+sDBvmy8yASwq+qFMu7FWJvcLMIsKS2YqEd5W/AdMQByE9R44vylhavWlT6sfo/72SAOxfEIF9lvvwmaDDNYhvPbWTmQYNHpohAtsRgf7OMfObOQxjC+dgasfqgN7KJZSK2WDcgvOJP/hQTLW1qZtS846q9T1T3b0/A8zndN0Eg8I4knj2EQIBorkF47Q41wEzFNMBHbJEhgF0611tzCDiu8xd6BDHiV9dhfEgSJEpocepzIoZVbstqGXnOIlHoScTMyGpwkQDOh7glhg+Ji9Ezrb16kYmmHZcK73BU8yACLvi1rbtd9lDSEoDSR/Bt0yFF8+V7kh4jZ7JQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681745246; bh=xzVg/5tIFKUXh4YUdTAUv7DQkKUQSxOd0EodnF579ix=; h=X-Sonic-MF:From:Date:Subject:To:From:Subject; b=o4lfsTZfCO0X/eiqem85xq/iog2Y1Fl0J0w/qnavpGk8wJ0Uyn8PA1gWfyHZ2CvU34W+yp/pNY12W/MeCpFxWU/hj3JTrqlBQME2WC3gDezfnlEOg59hQlQo0T7qr1IKgRZH3jiqIKH/rULOY1JzVEpJCkDKn73y6Y3BkQcPQ/LsLNI6BgArwwYjb/0k3gEIvmkiTu5GUPFIo5vlRV2eweg5mtmp18bQbuBq4Ve683waGaXws/wQD7+dx7raofCnqadVnATpIpQgbnixQjwCJG4LT2aXu9jL4fQRbimZ43JeCogPG7fJ1Ra779zeLC/OQu7+SZh3srQgfAa0C2cIhw== X-YMail-OSG: 3s5G4XMVM1kNM0Z0IXvHbAdLh61nXLNTzSqHVxamjinMqLD7yWu_eYU7E.WSaI5 JoQAjs6VTLQisqjqo3TjumV95AVhyO4cekaWz8gZqKA5TxRyNBVB7jP9kEnz9FhxM_OvXTKgCEl4 cIkvMJ5zUXEjj4H36aFRNRE_oHI8fKj01D7X20aztJRDzyI4wVwiTrIHRaI7I7xvA70r82VrUzv9 tISQEEX3ANd.K7nHHv6gNwS5enblya0YeIu_72jRPGKQGpBnW1nt19PwFb.9sZr5_s2uc5dp.qcI bSfHWquTkA9aK5e_BwnHAJjpZIrn4eV.hTNIOnvRYhHv1dk5tw9g_4HcO4wN1q1fBsHT6CZRXj2H ByZwZpLY2o19LrApk6VFGV1TPZ.DyEBPfbZ2N5K0mLZDaWitfKs5_nOfBpA_2weUSMuM6Sljwgwp Ey47.VkyBOEmZboNybT2HmD3V3WGa6Zd8NMi7iNqI0RQ9ptjA22x0XczwMdgh_7aw9UwG.QLuH1_ TF2.99tFHxagMOYtBdWNDUg8Hp9pD_ojltwb0PfE6nMAi4Ov.fzV0OY81LGHpuZStbXQ8vIQsMDo 42qurr1yGgLdMqFoe2S5CtUTo.VZsGt6aVL7tg98QBX7croYs9TmKrqD86dpl3SlX3y9y3vyGmWb cmQHX1yJFx7frwN2dVt9tlBM.EaGp7htR3cVRq17.Dt0khv2EdvGnmgZ40NN1F4hIGN8ar2_qZ2c p7qEZ_XGuXOxdeQYnIH9f1wJKVjHDdkNEgkDbnKTuWuc4fJag2S6sKrCrN7vpmcApNb4CkrvF3B7 sqKhaIJpsfJ7Gjy9Cmv5wDeVYew1fGXU37bJHQavohBepQH0SmR0LQ.ZqVVJQ8UAEDYGyD3JtxHp bTfOT6mU1ysvyQi60Ti7CjTNmJelmeCzn7.3_sgoVM.L09AOOcOJv99LqgS0QUog217zWpH625cf 2oEUeU1O_BRWJptr3Iw0.xPNriYlgpEQe4ETZS7UaAl8dN_MNlY47xjVRF_aSbtwkFGCC4ymuBql c4v4S2RXDSnEVZZGzsQ.qJ4ubF_pnH_sWSq87Fs9Xpn0DK2crywpbPBLRWjQo5P2SwtC5byIbc0D EcVN8uTq2E1oBs3VJRql9xOyZw92GJd7iDJsnAie7FiKOc0JWxRCHLNxB07ZkkHlQrclTusPCK5o rlGqoumjCBZah96XeMG2JkR4V3I6RPTQEpTDaDpOCWvU8jBqo3mITYN18_TZu6_e1Iq9iSgR470P flx72tXdFY_eMmfDgHQBWjIwmvzl17CpS65wmBXo11Tu7C2uWUHy50ClWNRxlFL5J4fYPCdqKAi5 3STnnjtOczpbvA3_zuqmTfBojF.leig2FSnF4bm59L2Dk6sgMv5n5GT2klVt8jdOdA2B2bBrPXiH HzgELM1JFCWeF1QT1cOfbRnhQJ5GRL3DuViDbi8VxvB2lWcSzwgApPoTQ9hPt4hm.8OQocbQWXsS Ul87Vi.0n7Dwq_2aAM6tCwmFKpc4TXesfs.tNsFg9Ietxa4ZnRqfqKQ2OVQJQd4UW7O9xFHhVMbV aaV006UBNio_kQ1n.iDR_.RknNX3tu9DTQqIfydyEv7w6J.8cOyagBQL7QBsOWCKydta_labm8hY EEkiPP9n7Q39Pd1IwGqBgesQcVQ538KQriECZ._N1aWTUWsMDTl7KBuCriQp45TMbzdwvKkl0JVX QopMDbc_4nx2N6TSiFkpuiotaAgKxhFm6we90._Y3h8Jg5bNzFvqSx6IJg23JrIEXSrBBRMs7zpE v2rMhpPtcXDaf1n2lT4C8Gk1ZddRvmPURsF.LQcgp6KNWWxphPMxiu0CnahQMa3E.hJvq1IzPZ6t WUhyGlkPjcp4ND3lnrCgajkIIxbpiKTrCkhUXcFMF617nG_XvtFfQlXR4cXksTweuRea3auZsLxX xcbbe7vxY8YYQ6xIVcv5ZionrS.6uh0c.01jT81nviibgfJ4.VgS2jPqw9kPxEeaW2hRl1a2nior 6ddXN.0yveoRLPjnR2LjkeJ6iHMpHx_bktv71SubjuyW12Z.uFtYPGqsR9cAIrHLS3CCuIkZv8O1 ywRdAWzX.LKx1WYnUG_au_fURpJL9J8StbIzkBKhHsdPdx1wDMISGCYHm0WAlzCzHXUgJ_trSKAX nI8UockkQUvF6SPfCevwGEEwa6ZQNxPpC.Wc2tkOzDbHW6TeZgoxu4lIksO4nskRhH6Uiexn9Py6 ffDGwR_SjR4qWdBl5J80VHEB4FS3mKieODoutbv3YepfLTB4j_egW8FRHw5jLpJRf0fZ1pPQ- X-Sonic-MF: <sunlin7@HIDDEN> X-Sonic-ID: 82dc9367-4dfe-4622-bef1-0e93563397fa Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Mon, 17 Apr 2023 15:27:26 +0000 Received: by hermes--production-ir2-74cd8fc864-db5p9 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b08d5e3af8683c9f7dc07e77744c3e26; Mon, 17 Apr 2023 15:27:22 +0000 (UTC) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-94a34a0b531so595365166b.1 for <62767 <at> debbugs.gnu.org>; Mon, 17 Apr 2023 08:27:22 -0700 (PDT) X-Gm-Message-State: AAQBX9dEJtwH7ujMGUgC328Sev4q31ciLdhDUwhaQEBW3qq9QpGzZYwb RP2s0fuzFY8xGbrqdSTGGLk83PFT8PvJOwsGEVE= X-Google-Smtp-Source: AKy350ZKMe41RFTGnjSOztIPWi9//xJv8em69obHjN9M5+azcf29edktK9A19Z1rMypNlAIrjFuHQ3yfkew0hERr/4Y= X-Received: by 2002:a50:f696:0:b0:506:71e7:1b5c with SMTP id d22-20020a50f696000000b0050671e71b5cmr7373229edn.5.1681745241331; Mon, 17 Apr 2023 08:27:21 -0700 (PDT) MIME-Version: 1.0 References: <1181651021.466162.1581309285621.ref@HIDDEN> <1181651021.466162.1581309285621@HIDDEN> <CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN> <CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN> <CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN> <CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN> <CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN> <CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN> <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN> <87sfd2ns6d.fsf@HIDDEN> <833551ecb2.fsf@HIDDEN> <87ttxh4e9i.fsf@HIDDEN> <CABCREdomqNHQ7Q018WEQ=X2-e1ZKdRCOBvtiof4yLKEzZXhVGw@HIDDEN> <87bkjmiqtz.fsf@HIDDEN> In-Reply-To: <87bkjmiqtz.fsf@HIDDEN> From: lin Sun <sunlin7@HIDDEN> Date: Mon, 17 Apr 2023 15:27:09 +0000 X-Gmail-Original-Message-ID: <CABCREdqYGqTRocmNagp7-uzjHQECD1YG5xNdn9mkHNtZLOO_3A@HIDDEN> Message-ID: <CABCREdqYGqTRocmNagp7-uzjHQECD1YG5xNdn9mkHNtZLOO_3A@HIDDEN> Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package To: Philip Kaludercic <philipk@HIDDEN> Content-Type: multipart/mixed; boundary="000000000000b69f5805f989d381" X-Mailer: WebService/1.1.21365 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 4005 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 62767 Cc: 62767 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) --000000000000b69f5805f989d381 Content-Type: text/plain; charset="UTF-8" Hi Philip, > How did you come to the conclusion about the second one? The 2nd one is necessary because the following lines will use the full `Info-directory-list` to print its values into the package-quickstart.el, whose value was modified by the function `package-activate'. If I comment out or use the `eval-after-load` on the 2nd one, the `Info-directory-list` will be empty, and missed in the package-quickstart.el file. Hi Ruijie, > "insure" -> "ensure"? You're right. I had fixed my typo in the patch file (only typo in comment), and attached the new one, please help review again. Thanks --000000000000b69f5805f989d381 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-lisp-emacs-lisp-package.el-better-way-to-load-the-in.patch" Content-Disposition: attachment; filename="0001-lisp-emacs-lisp-package.el-better-way-to-load-the-in.patch" Content-Transfer-Encoding: base64 Content-ID: <f_lgkzoa360> X-Attachment-Id: f_lgkzoa360 RnJvbSA5MWE0YmRiY2NjNmYzMjEwZjQzZjQ2ODkxMDc3YzU3YWZkMTI4ODMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBU dWUsIDExIEFwciAyMDIzIDAwOjAwOjEzICswMDAwClN1YmplY3Q6IFtQQVRDSF0gKmxpc3AvZW1h Y3MtbGlzcC9wYWNrYWdlLmVsOiBiZXR0ZXIgd2F5IHRvIGxvYWQgdGhlIGluZm8KIHBhY2thZ2UK Ci0tLQogbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwgfCAxNyArKysrKysrKy0tLS0tLS0tLQog MSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbCBiL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdl LmVsCmluZGV4IGY5MmFmZTU2YjcuLjk4MTUzYTQ5YzcgMTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3Mt bGlzcC9wYWNrYWdlLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsCkBAIC04OTIs MTAgKzg5Miw5IEBAIHBhY2thZ2UtYWN0aXZhdGUtMQogICAgICAgICAoYWRkLXRvLWxpc3QgJ2xv YWQtcGF0aCAoZGlyZWN0b3J5LWZpbGUtbmFtZSBwa2ctZGlyKSkpCiAgICAgICA7OyBBZGQgaW5m byBub2RlLgogICAgICAgKHdoZW4gKGZpbGUtZXhpc3RzLXAgKGV4cGFuZC1maWxlLW5hbWUgImRp ciIgcGtnLWRpcikpCi0gICAgICAgIDs7IEZJWE1FOiBub3QgdGhlIGZyaWVuZGxpZXN0LCBidXQg c2ltcGxlLgotICAgICAgICAocmVxdWlyZSAnaW5mbykKLSAgICAgICAgKGluZm8taW5pdGlhbGl6 ZSkKLSAgICAgICAgKGFkZC10by1saXN0ICdJbmZvLWRpcmVjdG9yeS1saXN0IHBrZy1kaXIpKQor ICAgICAgICAod2l0aC1ldmFsLWFmdGVyLWxvYWQgJ2luZm8KKyAgICAgICAgICAoaW5mby1pbml0 aWFsaXplKQorICAgICAgICAgIChhZGQtdG8tbGlzdCAnSW5mby1kaXJlY3RvcnktbGlzdCBwa2ct ZGlyKSkpCiAgICAgICAocHVzaCBuYW1lIHBhY2thZ2UtYWN0aXZhdGVkLWxpc3QpCiAgICAgICA7 OyBEb24ndCByZXR1cm4gbmlsLgogICAgICAgdCkpKQpAQCAtNDQyNyw3ICs0NDI2LDcgQEAgcGFj a2FnZS1xdWlja3N0YXJ0LXJlZnJlc2gKICAgIihSZSlHZW5lcmF0ZSB0aGUgYHBhY2thZ2UtcXVp Y2tzdGFydC1maWxlJy4iCiAgIChpbnRlcmFjdGl2ZSkKICAgKHBhY2thZ2UtaW5pdGlhbGl6ZSAn bm8tYWN0aXZhdGUpCi0gIChyZXF1aXJlICdpbmZvKQorICAocmVxdWlyZSAnaW5mbykgOyBlbnN1 cmUgSW5mby1kaXJlY3RvcnktbGlzdCBhdmFpbGFibGUgZm9yIHBhY2thZ2UtYWN0aXZhdGUKICAg KGxldCAoKHBhY2thZ2UtLXF1aWNrc3RhcnQtcGtncyAoKSkKICAgICAgICAgOzsgUHJldGVuZCB3 ZSBoYXZlbid0IGFjdGl2YXRlZCBhbnl0aGluZyB5ZXQhCiAgICAgICAgIChwYWNrYWdlLWFjdGl2 YXRlZC1saXN0ICgpKQpAQCAtNDQ3MiwxMCArNDQ3MSwxMCBAQCBwYWNrYWdlLXF1aWNrc3RhcnQt cmVmcmVzaAogICAgICAgICAgIChjdXJyZW50LWJ1ZmZlcikpCiAgICAgICAobGV0ICgoaW5mby1k aXJzIChidXRsYXN0IEluZm8tZGlyZWN0b3J5LWxpc3QpKSkKICAgICAgICAgKHdoZW4gaW5mby1k aXJzCi0gICAgICAgICAgKHBwIGAocHJvZ24gKHJlcXVpcmUgJ2luZm8pCi0gICAgICAgICAgICAg ICAgICAgICAgKGluZm8taW5pdGlhbGl6ZSkKLSAgICAgICAgICAgICAgICAgICAgICAoc2V0cSBJ bmZvLWRpcmVjdG9yeS1saXN0Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgKGFwcGVuZCAn LGluZm8tZGlycyBJbmZvLWRpcmVjdG9yeS1saXN0KSkpCisgICAgICAgICAgKHBwIGAod2l0aC1l dmFsLWFmdGVyLWxvYWQgJ2luZm8KKyAgICAgICAgICAgICAgICAgKGluZm8taW5pdGlhbGl6ZSkK KyAgICAgICAgICAgICAgICAgKHNldHEgSW5mby1kaXJlY3RvcnktbGlzdAorICAgICAgICAgICAg ICAgICAgICAgICAoYXBwZW5kICcsaW5mby1kaXJzIEluZm8tZGlyZWN0b3J5LWxpc3QpKSkKICAg ICAgICAgICAgICAgKGN1cnJlbnQtYnVmZmVyKSkpKQogICAgICAgOzsgVXNlIGBccycgaW5zdGVh ZCBvZiBhIHNwYWNlIGNoYXJhY3Rlciwgc28gdGhpcyBjb2RlIGNodW5rIGlzIG5vdAogICAgICAg OzsgbWlzdGFrZW4gZm9yIGFuIGFjdHVhbCBmaWxlLWxvY2FsIHNlY3Rpb24gb2YgcGFja2FnZS5l bC4KLS0gCjIuMjAuNQoK --000000000000b69f5805f989d381--
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.Received: (at 62767) by debbugs.gnu.org; 17 Apr 2023 13:24:35 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 17 09:24:35 2023 Received: from localhost ([127.0.0.1]:54009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1poOqR-0001wc-54 for submit <at> debbugs.gnu.org; Mon, 17 Apr 2023 09:24:35 -0400 Received: from mout02.posteo.de ([185.67.36.66]:40339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <philipk@HIDDEN>) id 1poOqP-0001wK-6C for 62767 <at> debbugs.gnu.org; Mon, 17 Apr 2023 09:24:33 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 481CF2401A0 for <62767 <at> debbugs.gnu.org>; Mon, 17 Apr 2023 15:24:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1681737867; bh=x6d7xOeWo+hjqQFBqMTKrScxopMBSUUvPR3YGutYBOg=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=VnISSvptvd8ssGkd6kX1MKFQdMqHd3QWdBIgB2SO4mwI1rPXEaaLN3Pk2/g1l1mJO owC3Ybc06KVHk59RZAR+TvsUFt4o4FeQn/GnJ7RmJt9ZD9LFUjasxTTM0sMMXWnwPK 36VEaE1DRtaga9dOnGPRPKeBX3lDKl6U3vePU6DzvfuA7xELc6PJrtNHBY2yOhCin+ QCGiDhpns1wk8KlEd/RPrbN7FAq/1UjbMkfRZc1akOuBDKc3Dp0CpZtSTcymf2hdwt tj9yssJb77Rg6n3RIBhwnX1QD+Liu6uZEN7d10GBcsLJLOuEkvM6VrQtXJSPuYluOW 04eg2Q+I2n4Qg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q0SSp4RPMz6txM; Mon, 17 Apr 2023 15:24:25 +0200 (CEST) From: Philip Kaludercic <philipk@HIDDEN> To: lin Sun <sunlin7@HIDDEN> Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package In-Reply-To: <CABCREdomqNHQ7Q018WEQ=X2-e1ZKdRCOBvtiof4yLKEzZXhVGw@HIDDEN> (lin Sun's message of "Mon, 17 Apr 2023 06:13:16 +0000") References: <1181651021.466162.1581309285621.ref@HIDDEN> <1181651021.466162.1581309285621@HIDDEN> <CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN> <CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN> <CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN> <CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN> <CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN> <CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN> <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN> <87sfd2ns6d.fsf@HIDDEN> <833551ecb2.fsf@HIDDEN> <87ttxh4e9i.fsf@HIDDEN> <CABCREdomqNHQ7Q018WEQ=X2-e1ZKdRCOBvtiof4yLKEzZXhVGw@HIDDEN> Autocrypt: addr=philipk@HIDDEN; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Mon, 17 Apr 2023 13:24:56 +0000 Message-ID: <87bkjmiqtz.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62767 Cc: 62767 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN>, Stefan Monnier <monnier@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) lin Sun <sunlin7@HIDDEN> writes: > Hi Philip, > > I had researched these three calls with the "require 'info", and > updated the patch for better performance. > The 1 th and 3rd can be rewritten with the new form, OK, then we still have to find out if these changes are safe. As mentioned before, I hesitate in using `with-eval-after-load', probably because of the complicated history of `eval-after-load'. I suppose that Stefan might know more (as it is due to him that I am careful here), so I have added him to the thread. > but the 2nd one > is necessary, and should not be changed. How did you come to the conclusion about the second one? > Please help review the new attached patch file. Thanks. > > Hi Eli, >> And this is the only place in Emacs where we have (require 'FOO) and >> FOO is not necessary for Emacs to start up? > My configuration will load the package.el at startup, so I tracked the > initial packages, and found the "require `info" will take ~1 seconds > on my old PC. > I didn't pay attention to other packages, if I found a heavy one, I'll > post it on the mail list. > > From 91a4bdbccc6f3210f43f46891077c57afd128830 Mon Sep 17 00:00:00 2001 > From: Lin Sun <sunlin7@HIDDEN> > Date: Tue, 11 Apr 2023 00:00:13 +0000 > Subject: [PATCH] *lisp/emacs-lisp/package.el: better way to load the info > package > > --- > lisp/emacs-lisp/package.el | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index f92afe56b7..98153a49c7 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -892,10 +892,9 @@ package-activate-1 > (add-to-list 'load-path (directory-file-name pkg-dir))) > ;; Add info node. > (when (file-exists-p (expand-file-name "dir" pkg-dir)) > - ;; FIXME: not the friendliest, but simple. > - (require 'info) > - (info-initialize) > - (add-to-list 'Info-directory-list pkg-dir)) > + (with-eval-after-load 'info > + (info-initialize) > + (add-to-list 'Info-directory-list pkg-dir))) > (push name package-activated-list) > ;; Don't return nil. > t))) > @@ -4427,7 +4426,7 @@ package-quickstart-refresh > "(Re)Generate the `package-quickstart-file'." > (interactive) > (package-initialize 'no-activate) > - (require 'info) > + (require 'info) ; insure Info-directory-list avaliable for package-activate > (let ((package--quickstart-pkgs ()) > ;; Pretend we haven't activated anything yet! > (package-activated-list ()) > @@ -4472,10 +4471,10 @@ package-quickstart-refresh > (current-buffer)) > (let ((info-dirs (butlast Info-directory-list))) > (when info-dirs > - (pp `(progn (require 'info) > - (info-initialize) > - (setq Info-directory-list > - (append ',info-dirs Info-directory-list))) > + (pp `(with-eval-after-load 'info > + (info-initialize) > + (setq Info-directory-list > + (append ',info-dirs Info-directory-list))) > (current-buffer)))) > ;; Use `\s' instead of a space character, so this code chunk is not > ;; mistaken for an actual file-local section of package.el.
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 17 Apr 2023 07:00:14 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 17 03:00:14 2023 Received: from localhost ([127.0.0.1]:52987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1poIqU-0004Fb-A2 for submit <at> debbugs.gnu.org; Mon, 17 Apr 2023 03:00:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:59646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ruijie@HIDDEN>) id 1poIqI-0004Dg-Jf for submit <at> debbugs.gnu.org; Mon, 17 Apr 2023 03:00:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ruijie@HIDDEN>) id 1poIqH-0001pf-Lo for bug-gnu-emacs@HIDDEN; Mon, 17 Apr 2023 03:00:01 -0400 Received: from netyu.xyz ([152.44.41.246] helo=mail.netyu.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ruijie@HIDDEN>) id 1poIqG-0000tB-5S; Mon, 17 Apr 2023 03:00:01 -0400 Received: from fw.net.yu.netyu.xyz (<unknown> [222.248.4.98]) by netyu.xyz (OpenSMTPD) with ESMTPSA id 74fa5049 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 17 Apr 2023 06:59:58 +0000 (UTC) References: <1181651021.466162.1581309285621.ref@HIDDEN> <1181651021.466162.1581309285621@HIDDEN> <CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN> <CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN> <CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN> <CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN> <CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN> <CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN> <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN> <87sfd2ns6d.fsf@HIDDEN> <833551ecb2.fsf@HIDDEN> <87ttxh4e9i.fsf@HIDDEN> <CABCREdomqNHQ7Q018WEQ=X2-e1ZKdRCOBvtiof4yLKEzZXhVGw@HIDDEN> <sdvy1mruhag.fsf@HIDDEN> User-agent: mu4e 1.9.22; emacs 30.0.50 From: Ruijie Yu <ruijie@HIDDEN> To: Ruijie Yu <ruijie@HIDDEN> Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package Date: Mon, 17 Apr 2023 14:59:00 +0800 In-reply-to: <sdvy1mruhag.fsf@HIDDEN> Message-ID: <sdvttxfuh7n.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=152.44.41.246; envelope-from=ruijie@HIDDEN; helo=mail.netyu.xyz X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: 62767 <at> debbugs.gnu.org, lin Sun <sunlin7@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Philip Kaludercic <philipk@HIDDEN>, bug-gnu-emacs@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.4 (-) Ruijie Yu <ruijie@HIDDEN> writes: > lin Sun via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> writes: > >> (let ((package--quickstart-pkgs ()) >> ;; Pretend we haven't activated anything yet! >> (package-activated-list ()) >> @@ -4472,10 +4471,10 @@ package-quickstart-refresh >> (current-buffer)) >> (let ((info-dirs (butlast Info-directory-list))) >> (when info-dirs >> - (pp `(progn (require 'info) >> - (info-initialize) >> - (setq Info-directory-list >> - (append ',info-dirs Info-directory-list))) >> + (pp `(with-eval-after-load 'info >> + (info-initialize) >> + (setq Info-directory-list >> + (append ',info-dirs Info-directory-list))) >> (current-buffer)))) > > I did some testing, and noticed that `with-eval-after-load' returns nil > to its caller when the feature is not loaded. That is, when `info' is > not already loaded, you are effectively calling (pp nil). This is not > feature-equivalent to the original code, so this might require the > `require' form. Sorry, I misread the code. Please ignore this portion of my previous email. -- Best, RY
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.Received: (at 62767) by debbugs.gnu.org; 17 Apr 2023 07:00:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 17 03:00:01 2023 Received: from localhost ([127.0.0.1]:52983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1poIqG-0004D2-W2 for submit <at> debbugs.gnu.org; Mon, 17 Apr 2023 03:00:01 -0400 Received: from netyu.xyz ([152.44.41.246]:41042 helo=mail.netyu.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ruijie@HIDDEN>) id 1poIqF-0004Cs-13 for 62767 <at> debbugs.gnu.org; Mon, 17 Apr 2023 02:59:59 -0400 Received: from fw.net.yu.netyu.xyz (<unknown> [222.248.4.98]) by netyu.xyz (OpenSMTPD) with ESMTPSA id 74fa5049 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 17 Apr 2023 06:59:58 +0000 (UTC) References: <1181651021.466162.1581309285621.ref@HIDDEN> <1181651021.466162.1581309285621@HIDDEN> <CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN> <CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN> <CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN> <CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN> <CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN> <CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN> <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN> <87sfd2ns6d.fsf@HIDDEN> <833551ecb2.fsf@HIDDEN> <87ttxh4e9i.fsf@HIDDEN> <CABCREdomqNHQ7Q018WEQ=X2-e1ZKdRCOBvtiof4yLKEzZXhVGw@HIDDEN> <sdvy1mruhag.fsf@HIDDEN> User-agent: mu4e 1.9.22; emacs 30.0.50 From: Ruijie Yu <ruijie@HIDDEN> To: Ruijie Yu <ruijie@HIDDEN> Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package Date: Mon, 17 Apr 2023 14:59:00 +0800 In-reply-to: <sdvy1mruhag.fsf@HIDDEN> Message-ID: <sdvttxfuh7n.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62767 Cc: 62767 <at> debbugs.gnu.org, lin Sun <sunlin7@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, Philip Kaludercic <philipk@HIDDEN>, bug-gnu-emacs@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) Ruijie Yu <ruijie@HIDDEN> writes: > lin Sun via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> writes: > >> (let ((package--quickstart-pkgs ()) >> ;; Pretend we haven't activated anything yet! >> (package-activated-list ()) >> @@ -4472,10 +4471,10 @@ package-quickstart-refresh >> (current-buffer)) >> (let ((info-dirs (butlast Info-directory-list))) >> (when info-dirs >> - (pp `(progn (require 'info) >> - (info-initialize) >> - (setq Info-directory-list >> - (append ',info-dirs Info-directory-list))) >> + (pp `(with-eval-after-load 'info >> + (info-initialize) >> + (setq Info-directory-list >> + (append ',info-dirs Info-directory-list))) >> (current-buffer)))) > > I did some testing, and noticed that `with-eval-after-load' returns nil > to its caller when the feature is not loaded. That is, when `info' is > not already loaded, you are effectively calling (pp nil). This is not > feature-equivalent to the original code, so this might require the > `require' form. Sorry, I misread the code. Please ignore this portion of my previous email. -- Best, RY
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.Received: (at 62767) by debbugs.gnu.org; 17 Apr 2023 06:58:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 17 02:58:23 2023 Received: from localhost ([127.0.0.1]:52975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1poIoh-00049u-0t for submit <at> debbugs.gnu.org; Mon, 17 Apr 2023 02:58:23 -0400 Received: from netyu.xyz ([152.44.41.246]:59552 helo=mail.netyu.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ruijie@HIDDEN>) id 1poIog-00049m-3W for 62767 <at> debbugs.gnu.org; Mon, 17 Apr 2023 02:58:22 -0400 Received: from fw.net.yu.netyu.xyz (<unknown> [222.248.4.98]) by netyu.xyz (OpenSMTPD) with ESMTPSA id c4417944 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 17 Apr 2023 06:58:20 +0000 (UTC) References: <1181651021.466162.1581309285621.ref@HIDDEN> <1181651021.466162.1581309285621@HIDDEN> <CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN> <CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN> <CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN> <CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN> <CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN> <CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN> <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN> <87sfd2ns6d.fsf@HIDDEN> <833551ecb2.fsf@HIDDEN> <87ttxh4e9i.fsf@HIDDEN> <CABCREdomqNHQ7Q018WEQ=X2-e1ZKdRCOBvtiof4yLKEzZXhVGw@HIDDEN> User-agent: mu4e 1.9.22; emacs 30.0.50 From: Ruijie Yu <ruijie@HIDDEN> To: lin Sun <sunlin7@HIDDEN> Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package Date: Mon, 17 Apr 2023 14:53:50 +0800 In-reply-to: <CABCREdomqNHQ7Q018WEQ=X2-e1ZKdRCOBvtiof4yLKEzZXhVGw@HIDDEN> Message-ID: <sdvy1mruhag.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62767 Cc: 62767 <at> debbugs.gnu.org, Philip Kaludercic <philipk@HIDDEN>, bug-gnu-emacs@HIDDEN, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 0.0 (/) lin Sun via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> writes: > Hi Philip, > > I had researched these three calls with the "require 'info", and > updated the patch for better performance. > The 1 th and 3rd can be rewritten with the new form, but the 2nd one > is necessary, and should not be changed. > @@ -4427,7 +4426,7 @@ package-quickstart-refresh > "(Re)Generate the `package-quickstart-file'." > (interactive) > (package-initialize 'no-activate) > - (require 'info) > + (require 'info) ; insure Info-directory-list avaliable for package-activate "insure" -> "ensure"? > (let ((package--quickstart-pkgs ()) > ;; Pretend we haven't activated anything yet! > (package-activated-list ()) > @@ -4472,10 +4471,10 @@ package-quickstart-refresh > (current-buffer)) > (let ((info-dirs (butlast Info-directory-list))) > (when info-dirs > - (pp `(progn (require 'info) > - (info-initialize) > - (setq Info-directory-list > - (append ',info-dirs Info-directory-list))) > + (pp `(with-eval-after-load 'info > + (info-initialize) > + (setq Info-directory-list > + (append ',info-dirs Info-directory-list))) > (current-buffer)))) I did some testing, and noticed that `with-eval-after-load' returns nil to its caller when the feature is not loaded. That is, when `info' is not already loaded, you are effectively calling (pp nil). This is not feature-equivalent to the original code, so this might require the `require' form. -- Best, RY
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 17 Apr 2023 06:58:32 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 17 02:58:32 2023 Received: from localhost ([127.0.0.1]:52978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1poIoq-0004AN-Dd for submit <at> debbugs.gnu.org; Mon, 17 Apr 2023 02:58:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:53148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ruijie@HIDDEN>) id 1poIoo-0004AF-L8 for submit <at> debbugs.gnu.org; Mon, 17 Apr 2023 02:58:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ruijie@HIDDEN>) id 1poIoo-0001Z3-9q for bug-gnu-emacs@HIDDEN; Mon, 17 Apr 2023 02:58:30 -0400 Received: from netyu.xyz ([152.44.41.246] helo=mail.netyu.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ruijie@HIDDEN>) id 1poIok-0000V8-1H; Mon, 17 Apr 2023 02:58:29 -0400 Received: from fw.net.yu.netyu.xyz (<unknown> [222.248.4.98]) by netyu.xyz (OpenSMTPD) with ESMTPSA id c4417944 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 17 Apr 2023 06:58:20 +0000 (UTC) References: <1181651021.466162.1581309285621.ref@HIDDEN> <1181651021.466162.1581309285621@HIDDEN> <CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN> <CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN> <CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN> <CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN> <CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN> <CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN> <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN> <87sfd2ns6d.fsf@HIDDEN> <833551ecb2.fsf@HIDDEN> <87ttxh4e9i.fsf@HIDDEN> <CABCREdomqNHQ7Q018WEQ=X2-e1ZKdRCOBvtiof4yLKEzZXhVGw@HIDDEN> User-agent: mu4e 1.9.22; emacs 30.0.50 From: Ruijie Yu <ruijie@HIDDEN> To: lin Sun <sunlin7@HIDDEN> Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package Date: Mon, 17 Apr 2023 14:53:50 +0800 In-reply-to: <CABCREdomqNHQ7Q018WEQ=X2-e1ZKdRCOBvtiof4yLKEzZXhVGw@HIDDEN> Message-ID: <sdvy1mruhag.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=152.44.41.246; envelope-from=ruijie@HIDDEN; helo=mail.netyu.xyz X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 62767 <at> debbugs.gnu.org, Philip Kaludercic <philipk@HIDDEN>, bug-gnu-emacs@HIDDEN, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.4 (-) lin Sun via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@HIDDEN> writes: > Hi Philip, > > I had researched these three calls with the "require 'info", and > updated the patch for better performance. > The 1 th and 3rd can be rewritten with the new form, but the 2nd one > is necessary, and should not be changed. > @@ -4427,7 +4426,7 @@ package-quickstart-refresh > "(Re)Generate the `package-quickstart-file'." > (interactive) > (package-initialize 'no-activate) > - (require 'info) > + (require 'info) ; insure Info-directory-list avaliable for package-activate "insure" -> "ensure"? > (let ((package--quickstart-pkgs ()) > ;; Pretend we haven't activated anything yet! > (package-activated-list ()) > @@ -4472,10 +4471,10 @@ package-quickstart-refresh > (current-buffer)) > (let ((info-dirs (butlast Info-directory-list))) > (when info-dirs > - (pp `(progn (require 'info) > - (info-initialize) > - (setq Info-directory-list > - (append ',info-dirs Info-directory-list))) > + (pp `(with-eval-after-load 'info > + (info-initialize) > + (setq Info-directory-list > + (append ',info-dirs Info-directory-list))) > (current-buffer)))) I did some testing, and noticed that `with-eval-after-load' returns nil to its caller when the feature is not loaded. That is, when `info' is not already loaded, you are effectively calling (pp nil). This is not feature-equivalent to the original code, so this might require the `require' form. -- Best, RY
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.Received: (at 62767) by debbugs.gnu.org; 17 Apr 2023 06:13:43 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 17 02:13:43 2023 Received: from localhost ([127.0.0.1]:52960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1poI7T-0002ho-4P for submit <at> debbugs.gnu.org; Mon, 17 Apr 2023 02:13:43 -0400 Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:40803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <sunlin7@HIDDEN>) id 1poI7Q-0002hX-AF for 62767 <at> debbugs.gnu.org; Mon, 17 Apr 2023 02:13:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681712013; bh=q6nuOsu8RojezA/adn79sqyL7BWVjkSb+5DWGCVcTiY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From:Subject:Reply-To; b=fFCmCiHap9g1TXMm37o1fxRtMW7t6lStXtT2S8cysx6FlAuWNb+Wz0pyV+XZZRW1RdjJDKM49tMG9aW+/yMsQIheJsELayJHZfjlSgxpqf7wPUL9kgUJRbPTv2YLc4C0W89KG7OKaBv4JAwsXnxEtB8BOalu+oZ3S15ULBRYBEWsDjDjNFOFDWDgSd7zrb77K7tnKDh+QdREsqgxEVR+uuMvxLdGL04XwLO4NdA62Tk2X5H4WHn9hz/jmuSKy4v+RYtM5XlKcvYyZ1q7a3TfPvz2P2VuAX+ortH0lKeE8peT1gD3xwB0ageCGS9k+ha/5Ib6UT5YQR5u80SxGQR0bQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681712013; bh=9Ag1YvnvUO0r4qM4TDkXCfnp7DGT7z96UjvaCdM0E8W=; h=X-Sonic-MF:From:Date:Subject:To:From:Subject; b=TiBBcWZAq7mWFSj5WtaSCupjpFoE+JxxokrdxShfCbKTk0dnYmaZKr6MXiuHIEsb0zVuDYyHBSAI8swecu+M1adaf5sdNlhB3Wmtj2atjhkH8I0dTgnv2qtjSe/QdPeKbLkl3Aj6Me34lvVNO6GIjTTfef7Bq1N/PXReLXk/JYy0ND3m4gLCxsHDbvAhLB1vALr/6Q0/V7TGLS8T5t60qSdgRx97kIkw+L/6osYm3vNXWDhpY4Znytft7JySiOce6jhcB/8skek6AEhQ+qPv+hJwyq3znO/t9et67ab5NZCf17iXEQA5wfYBcysJ4u23vZRGQyIBzq+vOHgADTZbPg== X-YMail-OSG: xfthARoVM1lgUdXUWsGrYenuA31clNijCipOfz4_NN9.f3QNDbWoZx3fdATI7o2 exPhw7UiKOB4i227fH.5WbQz68C_qAW0XL26I0RkejS.3sjjwX79.4h464LyqTSesLWrHf548ZBz 21gO80.CC6_iZCKTEkvlt4KuUwYyLgGoh.tGiengMDES7pT6IGNJH3EVYG9VPKS7tWTQWTUnNHd5 Gn.Z1sje3ZTXTb4mCbhhHqJlk9M95jhrSRw20cXPBEiaJqJXGvNLQDBTg8n0wCsXUxibNAAluzRv 8e0vheY0J8vZey4oghvl0wg_1pxHMgMzSL0klxPVVN93q.em4cvzvNJu9bOLBse5fgFCo4CB4wo2 X9RqZDXYvLpzWKbzSGcyGndrdzqKPN9lHckZ2JRO7MmzbiC4qG4NNlkSV.RtMpWg6RT1vWCdTDq. ItrJsgeWKbfz3g3Id4beXp.WqLxXNZHL723D2wCrZ_aek6shQ.L1SBBj6R2ZquwLxg2ogdvilgi6 K90BGYd.Gmgr5cFM_m_hkNGNHuTR_08SX7T0CWK2ILNZMIpTtrt8sklnuzG.VydGzcJ4My2tXAkG WOtwjAPvACIeas9dHClKAweMNIYuZU8t4uwI4JpehMVLnxA.oFFZ4RRczV6WyhZTSP1jePS9yUOS GzoAM9EIvtpSV8EjAyv.S0X7C.G4au2tIzYD09ONsootSBn2uDFfsMeBlZPGiH2LU4uF6DmyLtvc goLiwVfO0MC.gJXPVvD45iY_CuTyV6Pe65Ta411eSgDdbunxoj2A.HnKKAP0DgOgNFwIsTloDDq6 1o8z9N7y3oAQVD5YWvr3CotghqClHyzjGQEmj9h.xe406K4kDN2iiwlFMj2KwAhONVQkaI2n_Djf 5fpBqz6NkXrN3WHHmPlMq1SJ9F7mt7wZmzhfaLVvcz4eqZwmaRm1OYQnThU38YNKSAqhVxDS2e1p upFd.rlGEm0JgEfD9mUMi1a3FL4pjfzITrRRJ4JEKcg5TfbpoeWK47Aw_sIzRcVo2tDHgOO_iiAP Mggm.HLY9spVo1g3AIL76ngKuLiXXFLIpFqJFaR1CRr0GBa_mGT4nH.VuhwIcUlIRiYdNGO90IfA wnwkFGpVeqGAyHk4N7C2yNJduihUfVtQt_40C5weFL0snvN.V1_cAoyCLNm7ynMnTNMveqpW7njB _FtJyphmmghSM4Ugk87YnaIteRvBl2V1oq5IOdbKNN7kPKbO8j8QgjOWff49nFvv5q4g9Db1AVES GoWqEuUp12G_X.wpT6V.GgfTrqu86OLg1zGBGq0Prg88iJvvV9c27I6W9kD58P3lVlzHMhWxsSnk b_BNlTMTIXJMYinCLmE8XbOuPKagvKCqh9wuT7kT.uZz0TVthN6cG.SzDW8Xa1QQo6xvpxYkt4Ae L5vu4sYn6p6U.jeOMmICM.newz91awgT3ZhPPOn_rWsgq5ANlPC20240oWIFOb7hSw8Og13Stfqt 86hywqeq6FZQCmvNmsOtAwWdaKX2hUbr52UTTRQMe7ZrLl3uqXhUKNcla1s54cCFEYK2NV5Ga2dT oZxHnhQ6kC9aM5ugwYQ9R7nMm573Rq7L1B1VQvUZdnXni21F6eQZyucAuCErJwrF0.XniiPv2TnP 9zZU5tO2lV7gc4HxvUgXDrwf0RlbCFSoH2aADjp.2j5tMWedLffpHF9zN26y9ecolDhdxYBvOhDJ te6PQQK4lmB4ei9uFQzYSr9V0Uv6DOwT6bSz9Vk8qQttIqVx_34iHwVmuiehSyMFUvzO405oOCXo 4LPL78kOpLf7HDgvHu737Q4jY448fEBTnrSvsCO2HGNIPbGN1KO3bcy7xwV2bc1kRS7Hi2zkZarK C0.enDfgGUasUziSJOuceCMZnk9A1RFf8rW1N67P9VtdZTuK4eOPtkzehPXIIBS4dGtDMomDjLSE x3Y5miquV5X4PmTkvVUSBjvcWZnqotk_5nS_p8gNtayfiHL0uJlYtNnZ54xmQDC5hNPPj4Sfo8YY 8yZHuVo5pJRBVDn3HlD.6qAU901B2BJfiCy0YmcSeMLgkCId4e_mtZVOPGs.iTM7dREKCXvvh0L8 EgufVVrcQ_NPVuxRMCZqvlaRZDZ9qtDrKzx7vm6_zPBdoPE892dPD9WWEX1vXhYU3D_AGaTsd387 tKE4PaU.u3bcerNx13n3voWVO9F..eJrx5XmhO8qEwO6GcYZSBR4_RFwqLZAtcTCNBfihgbS7ckL 7OKdc7i5ZVNbzcaMf0xrLnym1h_xesAUnHo6KvBPqtU1gCafVzIqM.xvvg8vDWYxhKXqxTTo- X-Sonic-MF: <sunlin7@HIDDEN> X-Sonic-ID: e90f5947-da21-450b-a28c-f42275ab53c6 Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Mon, 17 Apr 2023 06:13:33 +0000 Received: by hermes--production-ir2-74cd8fc864-rnn7v (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 606bc5f2dff008ecbf65bf09adbd6612; Mon, 17 Apr 2023 06:13:30 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-505934ccc35so3720912a12.2 for <62767 <at> debbugs.gnu.org>; Sun, 16 Apr 2023 23:13:30 -0700 (PDT) X-Gm-Message-State: AAQBX9dKXyzt1XGfkmLNzdXwASFhjKt+gOO3E8OtsxfvxZrvzd0qApUL Lj2gc/AbtnPqoi/QpYfMs81oG+xVJTc9Kpo2Wbw= X-Google-Smtp-Source: AKy350bO3qSWtYShx1qVDEfMeKrzSczwOm5d5DQCiFITFMUT8XRQ9qChoc3ZWybS/63pedAec2nvUxMXGVhatKzjP7o= X-Received: by 2002:a50:f696:0:b0:506:71e7:1b5c with SMTP id d22-20020a50f696000000b0050671e71b5cmr6612181edn.5.1681712008879; Sun, 16 Apr 2023 23:13:28 -0700 (PDT) MIME-Version: 1.0 References: <1181651021.466162.1581309285621.ref@HIDDEN> <1181651021.466162.1581309285621@HIDDEN> <CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN> <CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN> <CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN> <CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN> <CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN> <CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN> <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN> <87sfd2ns6d.fsf@HIDDEN> <833551ecb2.fsf@HIDDEN> <87ttxh4e9i.fsf@HIDDEN> In-Reply-To: <87ttxh4e9i.fsf@HIDDEN> From: lin Sun <sunlin7@HIDDEN> Date: Mon, 17 Apr 2023 06:13:16 +0000 X-Gmail-Original-Message-ID: <CABCREdomqNHQ7Q018WEQ=X2-e1ZKdRCOBvtiof4yLKEzZXhVGw@HIDDEN> Message-ID: <CABCREdomqNHQ7Q018WEQ=X2-e1ZKdRCOBvtiof4yLKEzZXhVGw@HIDDEN> Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package To: Philip Kaludercic <philipk@HIDDEN> Content-Type: multipart/mixed; boundary="000000000000e78e0b05f982168c" X-Mailer: WebService/1.1.21365 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 4069 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 62767 Cc: 62767 <at> debbugs.gnu.org, Eli Zaretskii <eliz@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) --000000000000e78e0b05f982168c Content-Type: text/plain; charset="UTF-8" Hi Philip, I had researched these three calls with the "require 'info", and updated the patch for better performance. The 1 th and 3rd can be rewritten with the new form, but the 2nd one is necessary, and should not be changed. Please help review the new attached patch file. Thanks. Hi Eli, > And this is the only place in Emacs where we have (require 'FOO) and > FOO is not necessary for Emacs to start up? My configuration will load the package.el at startup, so I tracked the initial packages, and found the "require `info" will take ~1 seconds on my old PC. I didn't pay attention to other packages, if I found a heavy one, I'll post it on the mail list. --000000000000e78e0b05f982168c Content-Type: text/x-patch; charset="US-ASCII"; name="0001-lisp-emacs-lisp-package.el-better-way-to-load-the-in.patch" Content-Disposition: attachment; filename="0001-lisp-emacs-lisp-package.el-better-way-to-load-the-in.patch" Content-Transfer-Encoding: base64 Content-ID: <f_lgkfw9yo0> X-Attachment-Id: f_lgkfw9yo0 RnJvbSA5MWE0YmRiY2NjNmYzMjEwZjQzZjQ2ODkxMDc3YzU3YWZkMTI4ODMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBU dWUsIDExIEFwciAyMDIzIDAwOjAwOjEzICswMDAwClN1YmplY3Q6IFtQQVRDSF0gKmxpc3AvZW1h Y3MtbGlzcC9wYWNrYWdlLmVsOiBiZXR0ZXIgd2F5IHRvIGxvYWQgdGhlIGluZm8KIHBhY2thZ2UK Ci0tLQogbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwgfCAxNyArKysrKysrKy0tLS0tLS0tLQog MSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbCBiL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdl LmVsCmluZGV4IGY5MmFmZTU2YjcuLjk4MTUzYTQ5YzcgMTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3Mt bGlzcC9wYWNrYWdlLmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsCkBAIC04OTIs MTAgKzg5Miw5IEBAIHBhY2thZ2UtYWN0aXZhdGUtMQogICAgICAgICAoYWRkLXRvLWxpc3QgJ2xv YWQtcGF0aCAoZGlyZWN0b3J5LWZpbGUtbmFtZSBwa2ctZGlyKSkpCiAgICAgICA7OyBBZGQgaW5m byBub2RlLgogICAgICAgKHdoZW4gKGZpbGUtZXhpc3RzLXAgKGV4cGFuZC1maWxlLW5hbWUgImRp ciIgcGtnLWRpcikpCi0gICAgICAgIDs7IEZJWE1FOiBub3QgdGhlIGZyaWVuZGxpZXN0LCBidXQg c2ltcGxlLgotICAgICAgICAocmVxdWlyZSAnaW5mbykKLSAgICAgICAgKGluZm8taW5pdGlhbGl6 ZSkKLSAgICAgICAgKGFkZC10by1saXN0ICdJbmZvLWRpcmVjdG9yeS1saXN0IHBrZy1kaXIpKQor ICAgICAgICAod2l0aC1ldmFsLWFmdGVyLWxvYWQgJ2luZm8KKyAgICAgICAgICAoaW5mby1pbml0 aWFsaXplKQorICAgICAgICAgIChhZGQtdG8tbGlzdCAnSW5mby1kaXJlY3RvcnktbGlzdCBwa2ct ZGlyKSkpCiAgICAgICAocHVzaCBuYW1lIHBhY2thZ2UtYWN0aXZhdGVkLWxpc3QpCiAgICAgICA7 OyBEb24ndCByZXR1cm4gbmlsLgogICAgICAgdCkpKQpAQCAtNDQyNyw3ICs0NDI2LDcgQEAgcGFj a2FnZS1xdWlja3N0YXJ0LXJlZnJlc2gKICAgIihSZSlHZW5lcmF0ZSB0aGUgYHBhY2thZ2UtcXVp Y2tzdGFydC1maWxlJy4iCiAgIChpbnRlcmFjdGl2ZSkKICAgKHBhY2thZ2UtaW5pdGlhbGl6ZSAn bm8tYWN0aXZhdGUpCi0gIChyZXF1aXJlICdpbmZvKQorICAocmVxdWlyZSAnaW5mbykgOyBpbnN1 cmUgSW5mby1kaXJlY3RvcnktbGlzdCBhdmFsaWFibGUgZm9yIHBhY2thZ2UtYWN0aXZhdGUKICAg KGxldCAoKHBhY2thZ2UtLXF1aWNrc3RhcnQtcGtncyAoKSkKICAgICAgICAgOzsgUHJldGVuZCB3 ZSBoYXZlbid0IGFjdGl2YXRlZCBhbnl0aGluZyB5ZXQhCiAgICAgICAgIChwYWNrYWdlLWFjdGl2 YXRlZC1saXN0ICgpKQpAQCAtNDQ3MiwxMCArNDQ3MSwxMCBAQCBwYWNrYWdlLXF1aWNrc3RhcnQt cmVmcmVzaAogICAgICAgICAgIChjdXJyZW50LWJ1ZmZlcikpCiAgICAgICAobGV0ICgoaW5mby1k aXJzIChidXRsYXN0IEluZm8tZGlyZWN0b3J5LWxpc3QpKSkKICAgICAgICAgKHdoZW4gaW5mby1k aXJzCi0gICAgICAgICAgKHBwIGAocHJvZ24gKHJlcXVpcmUgJ2luZm8pCi0gICAgICAgICAgICAg ICAgICAgICAgKGluZm8taW5pdGlhbGl6ZSkKLSAgICAgICAgICAgICAgICAgICAgICAoc2V0cSBJ bmZvLWRpcmVjdG9yeS1saXN0Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgKGFwcGVuZCAn LGluZm8tZGlycyBJbmZvLWRpcmVjdG9yeS1saXN0KSkpCisgICAgICAgICAgKHBwIGAod2l0aC1l dmFsLWFmdGVyLWxvYWQgJ2luZm8KKyAgICAgICAgICAgICAgICAgKGluZm8taW5pdGlhbGl6ZSkK KyAgICAgICAgICAgICAgICAgKHNldHEgSW5mby1kaXJlY3RvcnktbGlzdAorICAgICAgICAgICAg ICAgICAgICAgICAoYXBwZW5kICcsaW5mby1kaXJzIEluZm8tZGlyZWN0b3J5LWxpc3QpKSkKICAg ICAgICAgICAgICAgKGN1cnJlbnQtYnVmZmVyKSkpKQogICAgICAgOzsgVXNlIGBccycgaW5zdGVh ZCBvZiBhIHNwYWNlIGNoYXJhY3Rlciwgc28gdGhpcyBjb2RlIGNodW5rIGlzIG5vdAogICAgICAg OzsgbWlzdGFrZW4gZm9yIGFuIGFjdHVhbCBmaWxlLWxvY2FsIHNlY3Rpb24gb2YgcGFja2FnZS5l bC4KLS0gCjIuMjAuNQoK --000000000000e78e0b05f982168c--
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.Received: (at 62767) by debbugs.gnu.org; 15 Apr 2023 10:58:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 15 06:58:12 2023 Received: from localhost ([127.0.0.1]:48352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pndbg-0001SW-7c for submit <at> debbugs.gnu.org; Sat, 15 Apr 2023 06:58:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pndbe-0001SI-JQ for 62767 <at> debbugs.gnu.org; Sat, 15 Apr 2023 06:58:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pndbZ-0005uB-8S; Sat, 15 Apr 2023 06:58:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lfy1OzvtlMOJRgdbteWZj5ZBU6AZJXIsgSaGO4kD/dU=; b=OH0Om21Gw2A+ StiPBxTWS5sI6udICnTBJiJZIsePFqM/qTOJOKE+0FY8kMu/nIB/1KfmA/wn+5PwL9ttDmYtQldis Io3qG4fBsbL7MT+i6aq8I8miETzjzDdlKZ/lk0a72pdrkD9USOgxM5ytQiy+R9V07wSAStkSmTG5w 5TAIoaYah4f2hh3Y0w/402ew4/YC8lw/7VcNv/ARbdGeaLBQM0c7fTOTRKJXNqWMaelTv7nP63lTg cTrNGLchClO1BKM7+HXyxS62GfKctZX1MUwDC0sYECBI1ir49+eFRJMoGOCYrrRYkfYZ0UYB7nw4x JQ+QFaR0xdSAKUm6mmy71g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pndbY-0007aq-Ga; Sat, 15 Apr 2023 06:58:04 -0400 Date: Sat, 15 Apr 2023 13:58:05 +0300 Message-Id: <83leitcszm.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Philip Kaludercic <philipk@HIDDEN> In-Reply-To: <87ttxh4e9i.fsf@HIDDEN> (message from Philip Kaludercic on Sat, 15 Apr 2023 10:43:21 +0000) Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package References: <1181651021.466162.1581309285621.ref@HIDDEN> <1181651021.466162.1581309285621@HIDDEN> <CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN> <CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN> <CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN> <CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN> <CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN> <CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN> <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN> <87sfd2ns6d.fsf@HIDDEN> <833551ecb2.fsf@HIDDEN> <87ttxh4e9i.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62767 Cc: 62767 <at> debbugs.gnu.org, sunlin7@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Philip Kaludercic <philipk@HIDDEN> > Cc: sunlin7@HIDDEN, 62767 <at> debbugs.gnu.org > Date: Sat, 15 Apr 2023 10:43:21 +0000 > > Eli Zaretskii <eliz@HIDDEN> writes: > > >> From: Philip Kaludercic <philipk@HIDDEN> > >> Cc: 62767 <at> debbugs.gnu.org, eliz@HIDDEN > >> Date: Fri, 14 Apr 2023 20:07:54 +0000 > >> > >> lin Sun <sunlin7@HIDDEN> writes: > >> > >> > Hi, > >> > > >> > The package.el will always require the entire `info.el` on its package > >> > activating function. > >> > Using the `with-eval-after-load` to arrange the work can avoid the > >> > unnecessary loading the `info` package. > >> > >> Note that this is not the only place where info is required. If this is > >> an acceptable solution (which I am not sure since `with-eval-after-load' > >> is something I usually encounter in user configurations), then we should > >> think about consistently addressing the issue: > > > > What exactly are the problems with requiring info.el? We require > > packages that define some function in gazillion other places, so what > > makes this one case special? > > Some people optimise the startup time of Emacs and want to avoid loading > files that are not necessary for Emacs to start-up. And this is the only place in Emacs where we have (require 'FOO) and FOO is not necessary for Emacs to start up? I'd be surprised.
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.Received: (at 62767) by debbugs.gnu.org; 15 Apr 2023 10:43:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 15 06:43:29 2023 Received: from localhost ([127.0.0.1]:48332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pndNR-0000ny-Ji for submit <at> debbugs.gnu.org; Sat, 15 Apr 2023 06:43:29 -0400 Received: from mout01.posteo.de ([185.67.36.65]:52857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <philipk@HIDDEN>) id 1pndNP-0000ng-OH for 62767 <at> debbugs.gnu.org; Sat, 15 Apr 2023 06:43:28 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 2827D240153 for <62767 <at> debbugs.gnu.org>; Sat, 15 Apr 2023 12:43:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1681555402; bh=9cv9VfRJ1K0N74QPyT8D7Et/Y/yarWRi00EmAIlpucU=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=fkVwHJWgrJb85TgNXaBtKhGEXYUVt1DYuXlESwSo+a1H4OPZcSrZrDbQjclCEgD/R DxTwltsXVqBmQBlt8ZYf0RxQ4amaRMpliTqUjJ7Dw9vjC8G/2Uz1Og0hHA8R2+TwNn 3y8rPMZSJdHclhMQ6Xo//3HAqChvzYmyfSBwCS6tcqUsuawBrNQM2UD81LfS/jnEKC tuPSUiKedoL9y9KI/z3+FwZN2kGvOiE8lH9C0G3IlWwO/2rd0PeZeUzDDVizHF8AtZ ts/fxUURZ7cgzcD0u4HwbntbzVeZs42AD2gw/bshDjRfq9N3at+14zA6/ut+emDN23 RnMA4prk1ZuRg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Pz8zs4QL6z9rxN; Sat, 15 Apr 2023 12:43:21 +0200 (CEST) From: Philip Kaludercic <philipk@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package In-Reply-To: <833551ecb2.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 15 Apr 2023 12:15:29 +0300") References: <1181651021.466162.1581309285621.ref@HIDDEN> <1181651021.466162.1581309285621@HIDDEN> <CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN> <CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN> <CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN> <CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN> <CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN> <CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN> <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN> <87sfd2ns6d.fsf@HIDDEN> <833551ecb2.fsf@HIDDEN> Autocrypt: addr=philipk@HIDDEN; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sat, 15 Apr 2023 10:43:21 +0000 Message-ID: <87ttxh4e9i.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62767 Cc: 62767 <at> debbugs.gnu.org, sunlin7@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) Eli Zaretskii <eliz@HIDDEN> writes: >> From: Philip Kaludercic <philipk@HIDDEN> >> Cc: 62767 <at> debbugs.gnu.org, eliz@HIDDEN >> Date: Fri, 14 Apr 2023 20:07:54 +0000 >> >> lin Sun <sunlin7@HIDDEN> writes: >> >> > Hi, >> > >> > The package.el will always require the entire `info.el` on its package >> > activating function. >> > Using the `with-eval-after-load` to arrange the work can avoid the >> > unnecessary loading the `info` package. >> >> Note that this is not the only place where info is required. If this is >> an acceptable solution (which I am not sure since `with-eval-after-load' >> is something I usually encounter in user configurations), then we should >> think about consistently addressing the issue: > > What exactly are the problems with requiring info.el? We require > packages that define some function in gazillion other places, so what > makes this one case special? Some people optimise the startup time of Emacs and want to avoid loading files that are not necessary for Emacs to start-up. -- Philip Kaludercic
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.Received: (at 62767) by debbugs.gnu.org; 15 Apr 2023 09:15:39 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 15 05:15:38 2023 Received: from localhost ([127.0.0.1]:48229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pnc0Q-0003wk-KX for submit <at> debbugs.gnu.org; Sat, 15 Apr 2023 05:15:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1pnc0O-0003wW-GW for 62767 <at> debbugs.gnu.org; Sat, 15 Apr 2023 05:15:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pnc0I-0000yn-5c; Sat, 15 Apr 2023 05:15:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UsKkkJRj1UUSucm9/O4sDItgnk+939Z7NLk+blDBbiM=; b=obMZkksUT49V FtUT7e+iGZgVwtfuX6e+5nhDuxRPhhiQ1oklmZLGtwvFXpDCh/LHhi/Q+uJZdyhpfGz40ozq8uDAq bHVP3Mb3smcRHr2I0I8bQUOEfTHh1jULtY39yRa6xBq/Ai1TDdK9xtpGPwliFA+/wrLGNQ1zhGTcR V2/DQnzjI6iRWMzx5K4TKLDAn6GlXIJ/b366HjuR3Vpq2HY8KT2Dw3p4rCgMscFqUUgTdEc4JnJXE YiYa2UDLjmQb5tr6Q5h6KxaZpWExnQ3QZN3kky7ehvITk3eHkjpkgC33Up5PXGf8Mxx3gdLZX4RNX 60C0wTVh1jvmZIRACbhNeA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1pnc0H-0001TX-DR; Sat, 15 Apr 2023 05:15:29 -0400 Date: Sat, 15 Apr 2023 12:15:29 +0300 Message-Id: <833551ecb2.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Philip Kaludercic <philipk@HIDDEN> In-Reply-To: <87sfd2ns6d.fsf@HIDDEN> (message from Philip Kaludercic on Fri, 14 Apr 2023 20:07:54 +0000) Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package References: <1181651021.466162.1581309285621.ref@HIDDEN> <1181651021.466162.1581309285621@HIDDEN> <CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN> <CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN> <CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN> <CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN> <CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN> <CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN> <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN> <87sfd2ns6d.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62767 Cc: 62767 <at> debbugs.gnu.org, sunlin7@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Philip Kaludercic <philipk@HIDDEN> > Cc: 62767 <at> debbugs.gnu.org, eliz@HIDDEN > Date: Fri, 14 Apr 2023 20:07:54 +0000 > > lin Sun <sunlin7@HIDDEN> writes: > > > Hi, > > > > The package.el will always require the entire `info.el` on its package > > activating function. > > Using the `with-eval-after-load` to arrange the work can avoid the > > unnecessary loading the `info` package. > > Note that this is not the only place where info is required. If this is > an acceptable solution (which I am not sure since `with-eval-after-load' > is something I usually encounter in user configurations), then we should > think about consistently addressing the issue: What exactly are the problems with requiring info.el? We require packages that define some function in gazillion other places, so what makes this one case special?
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.Received: (at 62767) by debbugs.gnu.org; 14 Apr 2023 22:13:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 14 18:13:24 2023 Received: from localhost ([127.0.0.1]:47857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pnRfL-0004xS-OP for submit <at> debbugs.gnu.org; Fri, 14 Apr 2023 18:13:24 -0400 Received: from sonic308-9.consmr.mail.ne1.yahoo.com ([66.163.187.32]:37972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <sunlin7@HIDDEN>) id 1pnRfJ-0004xG-Uu for 62767 <at> debbugs.gnu.org; Fri, 14 Apr 2023 18:13:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681510384; bh=hpOWrDdBMo8yChT5qKOUZ8vffdrGr27z6R2t+EloPbE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From:Subject:Reply-To; b=sfOq/E5AFHo2gHvzBJm1otXJleJy6oRM3SzU3HlZGxiFSdrCQGoqN5YyqhGpV9XnZUUDwtl2N4UT1VD9tRk/mYjHcVvtd1VDQeuoUMwX6sw6v26qL6lNTsrp+ovYYyjYpEoopk2+1Uwq8O7Uz1J+tUxm4ZNfDMBDHZiX7uhyepZALu3Q0EmDv/toltvikaH5KHLj2o3REiij0FeBJIeQDImYhn8zBM5qsHVz0BFD4g6A8rhHbHY0KvhmdJt1wclrU85sOUr64Rtqnx+slIUt0nPcsGlgjB6dB7wkrDLw9CUB8e14v/b7V2RNFs4c6X/mK5QTVPK97bGNusx5xeZLRQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681510384; bh=dAfMYgVJQeukZPyvVbskU5oSsP1LM2HD4qU3/Mngoqr=; h=X-Sonic-MF:From:Date:Subject:To:From:Subject; b=fWCLaK4trL2noBB1b1CKIyZrAFx3aQK2vsfcJg4dLCjNDMwzjbq2+ESB57KN9WODa77QtpvLE7lx+kLIshwvcdCBKU2M3KqRqVsuqwJzsZS99VmNq93ehxDemiPLwunaRts9ny9t+2FY9SZ650bT+HuP/q1u5b9KMUyN5Z1b+oWjqZ7l6nMgsWD8p+AArFkV0NpXsHt/ni0axWW3QBaB9QIbKkYJ3lTBKDLcgcYy7uVZ/YAvoSDeYd0qv4EW9QMPBF3a1XUd2hsXkhi+ftOSHDZkdhKgIXsuFP1kukfJZ20fWaFh4rgHjIFTSzHbCNk33kf+Asyd1B+zVx1rzB9K1g== X-YMail-OSG: wEbOpIkVM1n_0iVyiUwy129.s3AI4bFsyiwhvIX0ONl3QNz9wO8Kf.toKhC6GOE bwbINsVeBAt.oLb4V55gpUCbcsii71qIHbgF072HNTZdYp_lXsHQ5PkY2wf.cMGMqJwFBX8HYaIR qu_jSm2hPcgxinUc8BFzwYxpZnU6B9AigH.Czu.yDeKQO_wFXyZLYFZKonGhGOH4q2VFOsfcaNes Re2p1g.K0Di.__AsgGGS5DJpC1MIC7VeeSRSI_JM7X3cQe2XMmTClLEwBEPEFyzp.Q6immC4LFVK b0uBRr.vVJViOxojl7KqCt9mfBI5t73k27eplrmsgMdOlmO6tAdmlySnsr4K77bsedMtRi7_mhQS 2OBWClvXeRehygiWHu4146SwYbYoi6BZL4B4i6x4lNWbd4BmYssXFqLtaCN2L10wLpA7jvDViU1G bYd5hITPf7i7bwzvkelrFIvoK4S21WeWKO4A3dSC9Pep4iF5oBpNGcVk5biGPM7_RUMLXPFAKwpR F7QZuiSY3j4rv1SzMFUWCMwAggVexi0FaNNNEfErxyMHQ_vo2Kt9fVGwkZZa26mbGuBJJKGS8c6z BWaEahK8_NDK.ZsD68qdItyk79jg6eJBrE.Xyy9l7KQT0PfLf9bl4EUlSjNYvfN.fwoDU0QV6.FV tbsURWzDwErOU3VKW_qhI.GE0Mp79tHOc5YOGqHE5.btaZn9yypddyIaOwG9FsTdiWkZVN7Dkxog 52zCklOh1lLv5J27oimlyCbzFMdGpE9IH8hKZVgid7XZp7kJtUm_.F1fBDbtwwyBVOFZDFa1t7Ef tfuBUw6hh1TmEwkNwSj1iT1SrfwJP5vhCFWQ0T96RpPjc3_oOfm1gw7NpUaiqViNgz0Vh1MAUkvI YTrlk.1nj8ex27ZMrGh0ewtnueBPykdA0opCmoFhIN913o5qaVmcxhodU3cYCvAtHWdjFmjnK4uG fUQ0IV8iJ97nIIs.1ulAl3CtS1FAO7P1dsaOD34fAS.83Py1Oitd0359CWmCcQ1QndosIR1svFRg U8H7TAaBlCsvtsYWvDeSqgvLxF_17HTjme1iT7Fu3XkEWR.uelpg4MULiJIuzqAsnzzS6l7wI1jQ Jilx3dzdSqT9TBUkR4cf7jX3Frl2pditxFxPArUmy__3WVk45PRr1n3YfOuk7ik5E27cFfqpCbvD paBrwkclF9G2fY8O791JzgztKlilOAa1LWL2.41gbXzhFeJQHByjwio1poo.CYkquyowEe97jIuG Jm7NTEOostpc1fN7zNYfjfCQSTO19Pft2hStWsyEy9NsEi1nTVc8x2Rrm.4RjqaKON7Kbhu8lrPj nluv5qrgrZnQICCaEoDH80rBM3h5EYkfWotFqcggR1fT_L5IrZLpBUv04E49qWbkMs3Ibx8kFVxT Dz5StSaG5a6kSold3sd9iHZD7Agx.3Zyv5jNnP8ypEnO1azaci.6ZeQVOs0xFv7T.0Mxru754gYs LHbUg1KxrWtR8rS31DTqOQJulHRgRiUD5lUPnkH.2yS6xReo2ZXLRqp1V.xALzt3nj_PT3F_QiNf xJOuCZYovxKhkpIAK8.eEmHFjPHmVnNPgTLFm1iLRfZmCiI9kGarulrB.wbb7PptXlIGIXpzWnMO gKPV6_zBSgTsx_BgPoFVkK3FHAYFjgaiqJj91CiF68Yc3kYDnHZAE2l0F4R27_XintfhQbwLKcSO PEtkxz.hAHPmCJMyjbRtsVnJSXNoi7tDfzVsbQhIORdorCo2_RS4I9UgsKJSlmnZYxe2BHcLQ6ME HefnfMD4vqAI.rQiQYdGIBVbU8kYUZA0y0zbT1D9wPfVEmrhJ9O3thQSZJQOPZ6h7KZeexa6DwtB rVdFDV7FWMrglJMmgBJEkdNz1bH8imTXx_GQSdtCT5O3_fpGme_0Ap1z_.uAzgAq8ne3FdGIa.GA ovIgZ7RznbDn20MqWcZMRrXtJgF5sb_oi7WpyyYzt6gVQbx_6vBWv1oiMlFv3HosyH1o5wC.oFaC D1guAJidS6e6zleuGgI.eAa68swUCiYRelGkO3RveOxLPAoqOASduFAzdaT1c31CHSAlz1SaGqLs 4GCHJZ4.J1fLQxEPZB5WN0C.yWJ7leZ6GzD.vQVYulgRVTeMgxgb7WDrW7tz0TSe8v0ER3XyLvWH ee0Zk75Ph3hZmkhR4CEACIuGTVKoPu2HX1E9a8Dt.07kpQrf5M6e7T0o0Om7jesEcFBVAPkHIgbp amQcBcdWdUN5gyqKbsVOJ4le1VarhWo9lbMa7aOMiCaqZ7hanGLRrgwYiOafOBJ0w9loS2LUL X-Sonic-MF: <sunlin7@HIDDEN> X-Sonic-ID: 891d9cf6-e592-4f5a-ba22-2531ccad0cfd Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Fri, 14 Apr 2023 22:13:04 +0000 Received: by hermes--production-ir2-74cd8fc864-4bl68 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e41374705336fa21ea88409692a0666d; Fri, 14 Apr 2023 22:13:01 +0000 (UTC) Received: by mail-ej1-f43.google.com with SMTP id dx24so5074364ejb.11 for <62767 <at> debbugs.gnu.org>; Fri, 14 Apr 2023 15:13:01 -0700 (PDT) X-Gm-Message-State: AAQBX9cO0kuShw2x5fShwWxd7ywsvuJfAmV0KxxvMXTGp4xFuPqWmrCg ui1Kdzpjt+apmoMWaQIhNEUHTr/nxrVRmkGtXnE= X-Google-Smtp-Source: AKy350buMmU98pBSkrza7ieQSQp7LO1nZRhxMY2IS+Y56HVGGQ8N1tuAspCYFWmNxXTJ//w22KGSusmriKIIbOknKVk= X-Received: by 2002:a17:906:38d:b0:8df:dc64:30d2 with SMTP id b13-20020a170906038d00b008dfdc6430d2mr303870eja.1.1681510379697; Fri, 14 Apr 2023 15:12:59 -0700 (PDT) MIME-Version: 1.0 References: <1181651021.466162.1581309285621.ref@HIDDEN> <1181651021.466162.1581309285621@HIDDEN> <CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN> <CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN> <CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN> <CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN> <CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN> <CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN> <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN> <87sfd2ns6d.fsf@HIDDEN> In-Reply-To: <87sfd2ns6d.fsf@HIDDEN> From: lin Sun <sunlin7@HIDDEN> Date: Fri, 14 Apr 2023 22:12:48 +0000 X-Gmail-Original-Message-ID: <CABCREdq-QpiGWTVACEhJY_+U9O3EG1B2LadnoPAcd3yXmQO1Vg@HIDDEN> Message-ID: <CABCREdq-QpiGWTVACEhJY_+U9O3EG1B2LadnoPAcd3yXmQO1Vg@HIDDEN> Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package To: Philip Kaludercic <philipk@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Mailer: WebService/1.1.21365 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 248 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 62767 Cc: 62767 <at> debbugs.gnu.org, eliz@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.7 (/) Hi Philip, Thanks for the comment. I'm tracking the startup performance issue on my local, and found the line 896, after change to the patched lines, it works for me several weeks without regression. I'll check other lines you mentioned, thanks
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.
Received: (at 62767) by debbugs.gnu.org; 14 Apr 2023 20:07:33 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 14 16:07:33 2023
Received: from localhost ([127.0.0.1]:47790 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1pnPhk-0000rK-NF
for submit <at> debbugs.gnu.org; Fri, 14 Apr 2023 16:07:33 -0400
Received: from mout01.posteo.de ([185.67.36.65]:57407)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <philipk@HIDDEN>) id 1pnPhi-0000r4-9m
for 62767 <at> debbugs.gnu.org; Fri, 14 Apr 2023 16:07:30 -0400
Received: from submission (posteo.de [185.67.36.169])
by mout01.posteo.de (Postfix) with ESMTPS id C7CFE2401F7
for <62767 <at> debbugs.gnu.org>; Fri, 14 Apr 2023 22:07:24 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
t=1681502844; bh=gEg3YqnOm9/DNB3v4b6SNLsNOgj6/hEyxU8aKaC90ds=;
h=From:To:Cc:Subject:Autocrypt:Date:From;
b=neRv0IB2hJoAlex4vqQE7zDwMwZuOQB9BBhCIbNLQBXkMpGzDdVNS2KJXqLPBt7Ta
kYfJJun2pC2lztBniicK6h6VT1Gjlu8ZH2YAhQRlLg2Doh6GXxCPTRECKpMFFBT4dG
tFDe0EypruFlAhDr+vApNRaQChavnACfX/S2mFgNR3QMODIkOtLmv/nVMPhvIxBqSY
N6M04EIxr1PjulesNUCgEASivaRtYA8RTfwYTl0RMaKHMKEncZIT5cunRLKwaYGpuQ
oKZyTGVoy7nzisj10gVZkOJXEzDHFh1Mzbztg3dLmzETsaV5t6ny8yVQuwcXGILIk+
tK+fenzqABPIQ==
Received: from customer (localhost [127.0.0.1])
by submission (posteo.de) with ESMTPSA id 4PynY82LxHz6tw5;
Fri, 14 Apr 2023 22:07:24 +0200 (CEST)
From: Philip Kaludercic <philipk@HIDDEN>
To: lin Sun <sunlin7@HIDDEN>
Subject: Re: bug#62767: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set
variables after info package
In-Reply-To: <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN>
(lin Sun's message of "Tue, 11 Apr 2023 05:15:45 +0000")
References: <1181651021.466162.1581309285621.ref@HIDDEN>
<1181651021.466162.1581309285621@HIDDEN>
<CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN>
<CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN>
<CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN>
<CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN>
<CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN>
<CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN>
<CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN>
Autocrypt: addr=philipk@HIDDEN; keydata=
mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo
aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0
ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI
BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0
mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB
BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE
Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK
NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof
z4oM
Date: Fri, 14 Apr 2023 20:07:54 +0000
Message-ID: <87sfd2ns6d.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62767
Cc: 62767 <at> debbugs.gnu.org, eliz@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
--=-=-=
Content-Type: text/plain
lin Sun <sunlin7@HIDDEN> writes:
> Hi,
>
> The package.el will always require the entire `info.el` on its package
> activating function.
> Using the `with-eval-after-load` to arrange the work can avoid the
> unnecessary loading the `info` package.
Note that this is not the only place where info is required. If this is
an acceptable solution (which I am not sure since `with-eval-after-load'
is something I usually encounter in user configurations), then we should
think about consistently addressing the issue:
--=-=-=
Content-Type: text/plain
Content-Disposition: inline
3 matches for "require 'info" in buffer: package.el
: (add-to-list 'load-path (directory-file-name pkg-dir)))
: ;; Add info node.
: (when (file-exists-p (expand-file-name "dir" pkg-dir))
: ;; FIXME: not the friendliest, but simple.
896: (require 'info)
: (info-initialize)
: (add-to-list 'Info-directory-list pkg-dir))
: (push name package-activated-list)
: ;; Don't return nil.
-------
:(defun package-quickstart-refresh ()
: "(Re)Generate the `package-quickstart-file'."
: (interactive)
: (package-initialize 'no-activate)
4444: (require 'info)
: (let ((package--quickstart-pkgs ())
: ;; Pretend we haven't activated anything yet!
: (package-activated-list ())
: ;; Make sure we can load this file without load-source-file-function.
-------
: package-activated-list)))
: (current-buffer))
: (let ((info-dirs (butlast Info-directory-list)))
: (when info-dirs
4489: (pp `(progn (require 'info)
: (info-initialize)
: (setq Info-directory-list
: (append ',info-dirs Info-directory-list)))
: (current-buffer))))
--=-=-=
Content-Type: text/plain
> Please help review the patch. Thanks.
>
> Best regards
> Lin
>
> From 4908999eefa315cfa1a1434baf891ce98ee8d871 Mon Sep 17 00:00:00 2001
> From: Lin Sun <sunlin7@HIDDEN>
> Date: Tue, 11 Apr 2023 00:00:13 +0000
> Subject: [PATCH] *lisp/emacs-lisp/package.el: set variables after info package
> be loaded
>
> ---
> lisp/emacs-lisp/package.el | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
> index f92afe56b7..bb0491e509 100644
> --- a/lisp/emacs-lisp/package.el
> +++ b/lisp/emacs-lisp/package.el
> @@ -892,10 +892,9 @@ package-activate-1
> (add-to-list 'load-path (directory-file-name pkg-dir)))
> ;; Add info node.
> (when (file-exists-p (expand-file-name "dir" pkg-dir))
> - ;; FIXME: not the friendliest, but simple.
> - (require 'info)
> - (info-initialize)
> - (add-to-list 'Info-directory-list pkg-dir))
> + (with-eval-after-load 'info
> + (info-initialize)
> + (add-to-list 'Info-directory-list pkg-dir)))
> (push name package-activated-list)
> ;; Don't return nil.
> t)))
--=-=-=--
bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 11 Apr 2023 05:16:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 11 01:16:13 2023 Received: from localhost ([127.0.0.1]:36330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pm6MX-0004vm-9T for submit <at> debbugs.gnu.org; Tue, 11 Apr 2023 01:16:13 -0400 Received: from lists.gnu.org ([209.51.188.17]:35310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <sunlin7@HIDDEN>) id 1pm6MV-0004vf-M2 for submit <at> debbugs.gnu.org; Tue, 11 Apr 2023 01:16:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <sunlin7@HIDDEN>) id 1pm6MV-0003rx-Ce for bug-gnu-emacs@HIDDEN; Tue, 11 Apr 2023 01:16:11 -0400 Received: from sonic303-20.consmr.mail.ne1.yahoo.com ([66.163.188.146]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <sunlin7@HIDDEN>) id 1pm6MS-0003am-U1 for bug-gnu-emacs@HIDDEN; Tue, 11 Apr 2023 01:16:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681190163; bh=pxyYeOBjPuKUVAON6E0FWQumeOzqYKOIe9gMAhrxwXo=; h=References:In-Reply-To:From:Date:Subject:To:From:Subject:Reply-To; b=TIQ+XZ+gmtvI83CqJiOEKzvX7IsfZae2bmteFs6tz7AoPcqPYOSIVApepc4O0uQG2QSoIrwtW0imHET2GGJHKa8SkFFdY6auf90/9jjZnnn8678JwmX9menEWt7tvJC8LiKE8I5u6kCh6eMyj+LM2gmp47LXow4BYkrRvLvIQZURfXeOfVWpjemzRVaDucj2vFz7ldrDsG7EeRWX//NfK5rmI0zZK7iBtKscnx+DHZA3bIhvFObnZcf8vlIi/GDpFT7CRDKBmHHuLpk0MiP5zZK1DcQm5wRUcMu/YpcFhcCn2fEWuOQsi9U0heJ9qhxh/MDFRTx2Jret650rgKlCuA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1681190163; bh=XaH3ZrChfTp86T7Etwz+bvqhKCkhtlRBRrELTBQldWt=; h=X-Sonic-MF:From:Date:Subject:To:From:Subject; b=IbY4/MfATCUQVfsqAlpCZNumpF/Z3PbTI2pj/BQWhKWfPCCoA/Xptfb9ShSWrBvjSxUGttRBxYumj/Y5/CfbYFyQ2fIS+5+4D+7irnS8V1cMxFSv18n3OoMAJNkdc2kBwQidcu8caN5bhYsuYrlxxtByLnKsbuG56F8bw6HUUue0xRZwF0FhLbcYEq50UicvKlB7jeyGYuu1ER25K9zmQ3l3X2VpwDnqH9YduAPJ4SQRuzhHN0Oah2MBu1heK6vWvF66zQN3eAnsQ5gXUSrPZT6Q0HXLI3EMCMgjDK2luJ4/B2gVt1p8MMo8t/91vp4hiHmyxYoqvxBsnahyFIdgPg== X-YMail-OSG: J8G9WMkVM1nBLoQg9qWMewSTEthAuvyjGBS8mNrlxnBmNTc6gXWptR7sKq8TiPV A4oVwVLJtCJpb5UjpYim5iQ8kjUuMcOWQmzjFkSqwgHQL7XU_OQWHgXXeZc.MmTSu.6JgMOYsXTA ykNWhZ.1ETlg6RcmYHXlZdJSXUakTQsX.6As7HsGwYkDFG4lajYwmNgorRTpZJh_61XzmqwCuFC2 LlPMEH8B9gBVwyvXpeOJbU8O1p7Dz4XJ2z1YqVAQx7kytT93R.64sNVq_ohBgvx2G0hMjpVpexb1 sA3te8uJQZXaD4vZ8r2_oKP.NdntWwFWqNTFHVCZTGmomuTT9Z0uP..HC4aCX.XSmsYQkRUwSxPj _KUN8zAVmw0lHJzeOUdA1hS6OLpVwHuHzN3J1pt7odIOd_TzxX7JN9O.ZTK8pD23NIMsUxQGW9li r9eb0nkyNjQHfcFR0F8TxM1qLeVKdkCvaFjyIxAxTOFERYHjYxUZcJie2hUllceTHaTXTf0ylxgI uR07E8C1KtdhlH7IwRprpqQikxRlzCSfJNT_.eSqyxjIsO67h3V6dAh35mDdRwn8HgvGk5xIHPAX ZGJDbOQo1JC7.YS7vAH6rvbrRp7LuUyw7qKnTWceUc3YqFo83MZ3HEYs.PBc6fY5dQSvrkz0nfKm SjPqNDxp4RVQPYc8Sh8OsDwr.fQvZgkeg6E1HhCHWAJJfsg.KEkx3cr8wVZ03cZQFUN4LBln0fRd 0e6uqK5vbtRpomXgeSf1eL9ozakritRzNKofTi_IfbZUHWGMIV.R0W1FtLFxRj.5_JUP9Ry6U2Wt UyBXbZCR1dYekhIBg7f.C.u4C_Ow0OXGsFtVm5dLtbpHAjHODh4WpUBR4CpMsTEi6ACHSFBqWyRw IO038JRUC2czdHek39QTTU__lYxDrDi4DXeKH.S4UloQRAtRQkI6Lojxc5PmKoh_X5IdMpRXbonu 8Qa.20R5.bpL4FFrw.A.hdr7hQJPVS3b9RDmaoe89EvL2kn4LCgjKxSUtHH5bBDRNiOUHB544E.E Y2IgE_vPjNrNrMZAkgXbR8t694LThPhn6SMXJqCEySr54lj5zcUUucFeUKxLV3MMzIA4vuFRA92s q.2CeR4s04RefK8juRpmJd8sX50Kx4ZwSZZ4wfqsPOT8M.BGC69OXoPY.p5vS2MCl7aJz7hFUnnJ RCjWb1Lezb_ePaH.UsaT97Iw5a26uFr6g3tLKRrll8OjlfoMYKeRVSCv8ht.uufAmDT2mYzDPFgs h5IJnJsVaapHsyy4ULFUPg9a4kJeErBRMIao3YdkdSzx9iEgE91m.f91RUkvJ1gdzvqka2b0Ks9e JIrb17Q9Ikip7p236q_mwKy.dUffE8omTt.Ic_5OwcyUUkVmiIGLoMKJn6BffbXNz6naguatzszS vBDIuSCrfVSVcyPBC.RG4JPT8VLph3iqQYzsdlG.0BlUh82mmDAcqQAw8SJxzkW5cl7S_SJcsmJ. ORczGh1ZhKb5LRR93JC_Rw2H9V2.IvPF4Y5Xgs_2qSGT0itYoCAny9W1rF6O27e13NS8Z1mbvacA 0ZfWOE__tZHvPnh4NVImLBxghUmXWqYZ5n1LyKtQ5L0toTIddRQW2omW8.sbfYx.xu9dXPM.JUrY ZyL8rx9dZaIC4APbb5MsfPwe2c2BS5NoEQaatYx_PRZ_og9fTFS3Ri3NGdSeZF6KGkvBHy2gpnk9 G39me8lfXTsP.yCGJi77aoU2cnv5ZNlfWxIFN8w14u702IMX_bqE9a9WgIlJcQvd_w_Ml.G4BSOV 8Fnn6V4HxttS3FGf_lQf_pCf3l1xtHVeuFY3wujo7j05rRbWOvnNtRuHHVJwasyAYiId9RMb9z1H DaECO1Qz4B32URURolsfX.8aM7RKpr8.aKNMtE8mNX9zDEtqx9vNthbG.nT6AeKcVv7CENdY0S8Z cikF_qqzQIm.e45vEaWyxWGbrMgmWyM6j.4K5WMaqwt_Pg5c7KmNqN8zjbrj_xoHXM0Q6o9K8lbO 4A7FpotUmbWZgGXlDJjOGZTd.wOnQiTynHxY03xppwYV_lVhHwwad0lLA69OnS0sgQ.Y.BZLT2R9 jfNCEud.I_zq.Y2Pgmc2sYw_zFY6xpNh5Sh6erBENez0yDBHEgwdxTyflZmi1BCgggBp.6tKnnr8 ywiryxFHB0IC4Fv0fCL.4iLx1RsLvhaHmRYCAWNpMJnzpa6HqCQNFRyeRaL_jdiSONt8n0A8VswP DglY308y_PapVwHw8OFEbbDTxFc65dCVcZiw44LCvAjuBC0vDZiYbcIJIftl7D3Kkwg-- X-Sonic-MF: <sunlin7@HIDDEN> X-Sonic-ID: 69dc2853-ab2e-45ef-afc1-5acb04e04035 Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Tue, 11 Apr 2023 05:16:03 +0000 Received: by hermes--production-ir2-74cd8fc864-qfvhg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e0c3d3bdc5220d5fcd0fdb28f7d0595b; Tue, 11 Apr 2023 05:15:58 +0000 (UTC) Received: by mail-ej1-f53.google.com with SMTP id gb34so17503029ejc.12; Mon, 10 Apr 2023 22:15:58 -0700 (PDT) X-Gm-Message-State: AAQBX9ea7CXFv2rW6OFZUWbtwI0e+unArEECnKyOWKdinQkf6c7IiV3J tQ54JdZhp59FwV3WPGWQ6ShTNDGZVdQJgEfdffA= X-Google-Smtp-Source: AKy350ZHSC01gg+Qn93z1WrJvkjHoxHy+hf+y2oDPKsEbX4LaOiCkBgeK/FTk44cxJ6NvdF7KauN7sF/dwhigps04gI= X-Received: by 2002:a17:906:a92:b0:931:c1a:b526 with SMTP id y18-20020a1709060a9200b009310c1ab526mr3752806ejf.5.1681190157385; Mon, 10 Apr 2023 22:15:57 -0700 (PDT) MIME-Version: 1.0 References: <1181651021.466162.1581309285621.ref@HIDDEN> <1181651021.466162.1581309285621@HIDDEN> <CABCREdqX-nrN+r48UxsAFKZY3CZXxnRtH4HS7bxqsh=EBYmn4g@HIDDEN> <CABCREdoM9Etd_yFa=ttGC6qMpNbN3otKt-WRzSFhdvo3XmXczA@HIDDEN> <CABCREdrzYXahFe2WnG_GcJZa22D-5_rLDS4jqu1uiAX5h5vXrA@HIDDEN> <CABCREdq6NP0cGxTJKO-v9iDkwoOAzP2xo0-p5qcXL9CARN=+kw@HIDDEN> <CABCREdq229_uR180WBrCHUqK20F9VDAsAXHWoTBQR654UiehTw@HIDDEN> <CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN> In-Reply-To: <CABCREdojDr56zAi62=pEoi-Oh5tAcCzTNoPFaNKRFVoJgVVVCA@HIDDEN> From: lin Sun <sunlin7@HIDDEN> Date: Tue, 11 Apr 2023 05:15:45 +0000 X-Gmail-Original-Message-ID: <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN> Message-ID: <CABCREdp94_CzjVg3SxZUJeTdHpErQOpFmYWyP6AJV4=MiZqTRA@HIDDEN> Subject: 29.0.90; [PATCH] *lisp/emacs-lisp/package.el: set variables after info package To: "bug-gnu-emacs@HIDDEN" <bug-gnu-emacs@HIDDEN>, Eli Zaretskii <eliz@HIDDEN> Content-Type: multipart/mixed; boundary="00000000000021aeae05f9089679" X-Mailer: WebService/1.1.21365 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 2164 Received-SPF: pass client-ip=66.163.188.146; envelope-from=sunlin7@HIDDEN; helo=sonic303-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.4 (-) --00000000000021aeae05f9089679 Content-Type: text/plain; charset="UTF-8" Hi, The package.el will always require the entire `info.el` on its package activating function. Using the `with-eval-after-load` to arrange the work can avoid the unnecessary loading the `info` package. Please help review the patch. Thanks. Best regards Lin --00000000000021aeae05f9089679 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-lisp-emacs-lisp-package.el-set-variables-after-info-.patch" Content-Disposition: attachment; filename="0001-lisp-emacs-lisp-package.el-set-variables-after-info-.patch" Content-Transfer-Encoding: base64 Content-ID: <f_lgbt705a0> X-Attachment-Id: f_lgbt705a0 RnJvbSA0OTA4OTk5ZWVmYTMxNWNmYTFhMTQzNGJhZjg5MWNlOThlZThkODcxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW4gU3VuIDxzdW5saW43QGhvdG1haWwuY29tPgpEYXRlOiBU dWUsIDExIEFwciAyMDIzIDAwOjAwOjEzICswMDAwClN1YmplY3Q6IFtQQVRDSF0gKmxpc3AvZW1h Y3MtbGlzcC9wYWNrYWdlLmVsOiBzZXQgdmFyaWFibGVzIGFmdGVyIGluZm8gcGFja2FnZQogYmUg bG9hZGVkCgotLS0KIGxpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsIHwgNyArKystLS0tCiAxIGZp bGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsIGIvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwK aW5kZXggZjkyYWZlNTZiNy4uYmIwNDkxZTUwOSAxMDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNw L3BhY2thZ2UuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwKQEAgLTg5MiwxMCAr ODkyLDkgQEAgcGFja2FnZS1hY3RpdmF0ZS0xCiAgICAgICAgIChhZGQtdG8tbGlzdCAnbG9hZC1w YXRoIChkaXJlY3RvcnktZmlsZS1uYW1lIHBrZy1kaXIpKSkKICAgICAgIDs7IEFkZCBpbmZvIG5v ZGUuCiAgICAgICAod2hlbiAoZmlsZS1leGlzdHMtcCAoZXhwYW5kLWZpbGUtbmFtZSAiZGlyIiBw a2ctZGlyKSkKLSAgICAgICAgOzsgRklYTUU6IG5vdCB0aGUgZnJpZW5kbGllc3QsIGJ1dCBzaW1w bGUuCi0gICAgICAgIChyZXF1aXJlICdpbmZvKQotICAgICAgICAoaW5mby1pbml0aWFsaXplKQot ICAgICAgICAoYWRkLXRvLWxpc3QgJ0luZm8tZGlyZWN0b3J5LWxpc3QgcGtnLWRpcikpCisgICAg ICAgICh3aXRoLWV2YWwtYWZ0ZXItbG9hZCAnaW5mbworICAgICAgICAgIChpbmZvLWluaXRpYWxp emUpCisgICAgICAgICAgKGFkZC10by1saXN0ICdJbmZvLWRpcmVjdG9yeS1saXN0IHBrZy1kaXIp KSkKICAgICAgIChwdXNoIG5hbWUgcGFja2FnZS1hY3RpdmF0ZWQtbGlzdCkKICAgICAgIDs7IERv bid0IHJldHVybiBuaWwuCiAgICAgICB0KSkpCi0tIAoyLjIwLjUKCg== --00000000000021aeae05f9089679--
lin Sun <sunlin7@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#62767; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.