GNU bug report logs - #62814
[PATCH] Clarify substitute* docstring with an additional example

Previous Next

Package: guix-patches;

Reported by: "Wicki Gabriel (wicg)" <wicg <at> zhaw.ch>

Date: Thu, 13 Apr 2023 11:50:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62814 in the body.
You can then email your comments to 62814 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#62814; Package guix-patches. (Thu, 13 Apr 2023 11:50:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to "Wicki Gabriel (wicg)" <wicg <at> zhaw.ch>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 13 Apr 2023 11:50:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Wicki Gabriel (wicg)" <wicg <at> zhaw.ch>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] Clarify substitute* docstring with an additional example
Date: Thu, 13 Apr 2023 11:44:11 +0000

[Message part 1 (text/plain, inline)]
Hello

I've created this little patch after wondering how to match (and substitute*) against end-of-line. My patch is based on
982698c52fb388e278dc4cec4b124406f23f102a.

Thanks for review and merge.

gabber

[Message part 2 (text/html, inline)]
[0001-guix-build-utils-Clarify-substitute-docstring-with-a.patch (text/x-patch, attachment)]
Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Thu, 11 May 2023 12:40:02 GMT) Full text and rfc822 format available.
Notification sent to "Wicki Gabriel (wicg)" <wicg <at> zhaw.ch>:
bug acknowledged by developer. (Thu, 11 May 2023 12:40:02 GMT) Full text and rfc822 format available.

Message #10 received at 62814-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Wicki Gabriel (wicg)" <wicg <at> zhaw.ch>
Cc: 62814-done <at> debbugs.gnu.org
Subject: Re: bug#62814: [PATCH] Clarify substitute* docstring with an
 additional example
Date: Thu, 11 May 2023 14:38:56 +0200

Hi,

"Wicki Gabriel (wicg)" <wicg <at> zhaw.ch> skribis:

> From 5ae3c5512e85189a47c859c6128adfd3bfc63159 Mon Sep 17 00:00:00 2001
> From: Gabriel Wicki <gabriel <at> erlikon.ch>
> Date: Thu, 13 Apr 2023 10:31:57 +0200
> Subject: [PATCH] guix: build: utils: Clarify substitute* docstring with an
>  example.
>
> * guix/build/utils.scm (substitute*):  Add an example on how to match
> end-of-line.
> * doc/guix.texi (Build Utilities): Update the corresponding passage.

[...]

>  Be careful about using @code{$} to match the end of a line; by itself it
> -won't match the terminating newline of a line.
> +won't match the terminating newline of a line, e.g. to match a whole
> +line ending with a backslash, one needs a regex like @code{"(.*)\\\\\n$"}.

Applied with a minor tweak and without the (guix build utils) change,
which would entail a world rebuild.

Thanks!

Ludo’.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 09 Jun 2023 11:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 336 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.