GNU logs - #62825, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#62825: 29.0.90; c-ts-mode doesn't recognize DEFUN functions
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 14 Apr 2023 06:45:01 +0000
Resent-Message-ID: <handler.62825.B.168145467310181 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 62825 <at> debbugs.gnu.org
Date: Fri, 14 Apr 2023 09:44:22 +0300
Message-Id: <831qkngdyx.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Evaluating '(treesit-defun-at-point)' inside a function defined via
the DEFUN macro yields nil, when the buffer is under c-ts-mode.  This
gets in the way of significant functionalities, like
c-ts-mode-indent-defun and generating ChangeLog-style log entries
using "C-x 4 a" and the likes.

To reproduce, visit any of the Emacs C source files, like treesit.c,
with c-ts-mode, move point to a function defined via DEFUN, and type
"C-x 4 a".  The resulting ChangeLog entry will have the file name, but
not the expected function name in parentheses.

Please fix this ASAP, this is a bad regression for those, like myself,
who want to use c-ts-mode.

In GNU Emacs 29.0.90 (build 2, i686-pc-mingw32) of 2023-04-10 built on
 HOME-C4E4A596F7
Windowing system distributor 'Microsoft Corp.', version 5.1.2600
System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600)

Configured using:
 'configure --prefix=/d/usr --with-wide-int --with-native-compilation
 'CFLAGS=-O2 -gdwarf-4 -g3''

Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB

Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1255

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra
help-mode bytecomp byte-compile cl-lib sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv
eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win
w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads w32notify w32 lcms2 multi-tty make-network-process
native-compile emacs)

Memory information:
((conses 16 83196 14093)
 (symbols 48 8277 0)
 (strings 16 22852 2978)
 (string-bytes 1 598231)
 (vectors 16 16223)
 (vector-slots 8 320282 14191)
 (floats 8 30 46)
 (intervals 40 293 0)
 (buffers 888 12))

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Eli Zaretskii <eliz@HIDDEN>
Subject: bug#62825: Acknowledgement (29.0.90; c-ts-mode doesn't recognize
 DEFUN functions)
Message-ID: <handler.62825.B.168145467310181.ack <at> debbugs.gnu.org>
References: <831qkngdyx.fsf@HIDDEN>
X-Gnu-PR-Message: ack 62825
X-Gnu-PR-Package: emacs
Reply-To: 62825 <at> debbugs.gnu.org
Date: Fri, 14 Apr 2023 06:45:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 62825 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
62825: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D62825
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#62825: 29.0.90; c-ts-mode doesn't recognize DEFUN functions
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 14 Apr 2023 07:00:02 +0000
Resent-Message-ID: <handler.62825.B62825.168145559512476 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Yuan Fu <casouri@HIDDEN>, Theodor Thornhill <theo@HIDDEN>
Cc: 62825 <at> debbugs.gnu.org
Date: Fri, 14 Apr 2023 09:59:42 +0300
Message-Id: <83v8hzeyox.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <831qkngdyx.fsf@HIDDEN> (message from Eli Zaretskii on Fri, 14
 Apr 2023 09:44:22 +0300)
References: <831qkngdyx.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> Date: Fri, 14 Apr 2023 09:44:22 +0300
> From: Eli Zaretskii <eliz@HIDDEN>
> 
> Evaluating '(treesit-defun-at-point)' inside a function defined via
> the DEFUN macro yields nil, when the buffer is under c-ts-mode.  This
> gets in the way of significant functionalities, like
> c-ts-mode-indent-defun and generating ChangeLog-style log entries
> using "C-x 4 a" and the likes.
> 
> To reproduce, visit any of the Emacs C source files, like treesit.c,
> with c-ts-mode, move point to a function defined via DEFUN, and type
> "C-x 4 a".  The resulting ChangeLog entry will have the file name, but
> not the expected function name in parentheses.
> 
> Please fix this ASAP, this is a bad regression for those, like myself,
> who want to use c-ts-mode.

Using treesit-explore-mode I see that c-ts-mode regards DEFUN
functions as a sequence of 2 expression_statement nodes.  Here's the
tree corresponding to the DEFUN macro call:

  (expression_statement
   (call_expression
    function: 
     (call_expression function: (identifier) <<<<<<<<<<<<<<<<<<<
      arguments: 
       (argument_list (
	(string_literal " ")
	, (identifier) , (identifier) , (number_literal) , (number_literal) ,
		      (number_literal)
	, (identifier)
	(ERROR :)
	(comment) )))
    arguments: 
     (argument_list ( (identifier)
      (ERROR (identifier))
      , (identifier)
      (ERROR (identifier))
      )))
   ;)

The identifier node on the line indicated with "<<<<<" is "DEFUN", so
maybe we can recognize this.  The body of the DEFUN is another
compound_statement node, following the DEFUN's node.

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#62825: 29.0.90; c-ts-mode doesn't recognize DEFUN functions
Resent-From: Yuan Fu <casouri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 14 Apr 2023 20:20:02 +0000
Resent-Message-ID: <handler.62825.B62825.16815036014826 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 62825 <at> debbugs.gnu.org, Theodor Thornhill <theo@HIDDEN>
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\))
From: Yuan Fu <casouri@HIDDEN>
In-Reply-To: <83v8hzeyox.fsf@HIDDEN>
Date: Fri, 14 Apr 2023 13:19:41 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <E23597F9-F868-4D04-B814-52B43427DA3D@HIDDEN>
References: <831qkngdyx.fsf@HIDDEN> <83v8hzeyox.fsf@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>



> On Apr 13, 2023, at 11:59 PM, Eli Zaretskii <eliz@HIDDEN> wrote:
>=20
>> Date: Fri, 14 Apr 2023 09:44:22 +0300
>> From: Eli Zaretskii <eliz@HIDDEN>
>>=20
>> Evaluating '(treesit-defun-at-point)' inside a function defined via
>> the DEFUN macro yields nil, when the buffer is under c-ts-mode.  This
>> gets in the way of significant functionalities, like
>> c-ts-mode-indent-defun and generating ChangeLog-style log entries
>> using "C-x 4 a" and the likes.
>>=20
>> To reproduce, visit any of the Emacs C source files, like treesit.c,
>> with c-ts-mode, move point to a function defined via DEFUN, and type
>> "C-x 4 a".  The resulting ChangeLog entry will have the file name, =
but
>> not the expected function name in parentheses.
>>=20
>> Please fix this ASAP, this is a bad regression for those, like =
myself,
>> who want to use c-ts-mode.
>=20
> Using treesit-explore-mode I see that c-ts-mode regards DEFUN
> functions as a sequence of 2 expression_statement nodes.  Here's the
> tree corresponding to the DEFUN macro call:
>=20
>  (expression_statement
>   (call_expression
>    function:=20
>     (call_expression function: (identifier) <<<<<<<<<<<<<<<<<<<
>      arguments:=20
>       (argument_list (
> (string_literal " ")
> , (identifier) , (identifier) , (number_literal) , (number_literal) ,
>      (number_literal)
> , (identifier)
> (ERROR :)
> (comment) )))
>    arguments:=20
>     (argument_list ( (identifier)
>      (ERROR (identifier))
>      , (identifier)
>      (ERROR (identifier))
>      )))
>   ;)
>=20
> The identifier node on the line indicated with "<<<<<" is "DEFUN", so
> maybe we can recognize this.  The body of the DEFUN is another
> compound_statement node, following the DEFUN's node.

Ok, I fixed indent-defund and add-log. Because a DEFUN is made of two =
nodes in the parse tree rather than one, it=E2=80=99s a bit hard to =
incorporate it into the normal treesit-defun-at-point, etc, functions. =
And we probably have to fix DEFUN case-by-case.

Yuan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#62825: 29.0.90; c-ts-mode doesn't recognize DEFUN functions
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 15 Apr 2023 07:50:01 +0000
Resent-Message-ID: <handler.62825.B62825.16815449465208 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 62825
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Yuan Fu <casouri@HIDDEN>
Cc: 62825 <at> debbugs.gnu.org, theo@HIDDEN
Received: via spool by 62825-submit <at> debbugs.gnu.org id=B62825.16815449465208
          (code B ref 62825); Sat, 15 Apr 2023 07:50:01 +0000
Received: (at 62825) by debbugs.gnu.org; 15 Apr 2023 07:49:06 +0000
Received: from localhost ([127.0.0.1]:48165 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pnaef-0001Lw-La
	for submit <at> debbugs.gnu.org; Sat, 15 Apr 2023 03:49:05 -0400
Received: from eggs.gnu.org ([209.51.188.92]:58958)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pnaed-0001LS-Fx
 for 62825 <at> debbugs.gnu.org; Sat, 15 Apr 2023 03:49:04 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pnaeX-0003KI-Bo; Sat, 15 Apr 2023 03:48:57 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=bYo7ZuM5kcO3dKZzMRGoaXsbJXYe1ToOcOs3TLrTQ1Y=; b=H41lhiqBiiDBI2a/mLpW
 w7gZdaA1GIBw/1ib/qkeQo8dDnNl6qyWI46A115RK6LMk0hH0nMsMFqsPULPWsAUiCwL930cTBkew
 JscBAbkxo2G5x3RwBsHjGyHlRGHQ+SHZAQWnI0LBcByxGBLwY16be9O4+tzrIF5epsQEOm+tPE0YR
 vPlT8iP4QFQy/sB/zMonZS9nv+Pg0PL0Tp1wAXCedNDmTzNh1VZif2BgxI0XPgrC8/+y4FwL/oBGN
 5d4p0rsJPSz0FT7JgcQBWC55uWoysaOMPTvV3dTSiQ2GxT23p4jb+9BxTtutxaowEwrPIK+VB/ykI
 F+d/cYCJ6F4Iyw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pnaeW-0007z8-Hk; Sat, 15 Apr 2023 03:48:57 -0400
Date: Sat, 15 Apr 2023 10:48:54 +0300
Message-Id: <83fs91egbd.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <E23597F9-F868-4D04-B814-52B43427DA3D@HIDDEN> (message from
 Yuan Fu on Fri, 14 Apr 2023 13:19:41 -0700)
References: <831qkngdyx.fsf@HIDDEN> <83v8hzeyox.fsf@HIDDEN>
 <E23597F9-F868-4D04-B814-52B43427DA3D@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Yuan Fu <casouri@HIDDEN>
> Date: Fri, 14 Apr 2023 13:19:41 -0700
> Cc: Theodor Thornhill <theo@HIDDEN>,
>  62825 <at> debbugs.gnu.org
> 
> Ok, I fixed indent-defund and add-log. Because a DEFUN is made of two nodes in the parse tree rather than one, it’s a bit hard to incorporate it into the normal treesit-defun-at-point, etc, functions. And we probably have to fix DEFUN case-by-case.

Thanks.  But I wonder why do we need the c-ts-mode-emacs-devel knob.
Why not recognize DEFUN by default everywhere?  CC Mode does that,
AFAIK, so why shouldn't c-ts-mode do the same?

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#62825: 29.0.90; c-ts-mode doesn't recognize DEFUN functions
References: <831qkngdyx.fsf@HIDDEN>
In-Reply-To: <831qkngdyx.fsf@HIDDEN>
Resent-From: Yuan Fu <casouri@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 16 Apr 2023 05:38:02 +0000
Resent-Message-ID: <handler.62825.B62825.168162344313506 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 62825
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Eli Zaretskii <eliz@HIDDEN>
Cc: theo@HIDDEN, 62825 <at> debbugs.gnu.org
Received: via spool by 62825-submit <at> debbugs.gnu.org id=B62825.168162344313506
          (code B ref 62825); Sun, 16 Apr 2023 05:38:02 +0000
Received: (at 62825) by debbugs.gnu.org; 16 Apr 2023 05:37:23 +0000
Received: from localhost ([127.0.0.1]:50470 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pnv4k-0003Vl-JS
	for submit <at> debbugs.gnu.org; Sun, 16 Apr 2023 01:37:22 -0400
Received: from mail-pj1-f54.google.com ([209.85.216.54]:42568)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <casouri@HIDDEN>) id 1pnv4i-0003VX-9Q
 for 62825 <at> debbugs.gnu.org; Sun, 16 Apr 2023 01:37:20 -0400
Received: by mail-pj1-f54.google.com with SMTP id
 fw22-20020a17090b129600b00247255b2f40so8889708pjb.1
 for <62825 <at> debbugs.gnu.org>; Sat, 15 Apr 2023 22:37:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20221208; t=1681623434; x=1684215434;
 h=to:cc:date:message-id:subject:mime-version
 :content-transfer-encoding:from:from:to:cc:subject:date:message-id
 :reply-to; bh=HcNM5N6RUiQAkWK0cY8MfL0xUSwBw7TAecS5AL6ypWs=;
 b=Roq7rfJMISo7pH1m584hh8I7b+OM2u1Gtsu51D+6fM+W3viiKmWXIObnPHnkZ2wvKy
 MJ1dCE5dPFYu3hepbSBaGOCgj4phlvNfV44MEwirxncaZPy6hDNFOtpWaKmqTSXcFgSS
 b7TZI59HQHGnK/dFSB9HmJxoRYFrqnUVGaqtfcLDWaX3ZTzVp9432ZyV6hcAKePyx7K4
 WJ+HQfbVspB8YhrYqY/TB5gLFqB6CaYQqoDVxEuZ/XMu6ftu8FaCjyz0ltIlZhKGIO/y
 mkByj4oDg0JrP2sq0QBCBEVWwa3HSGMTlKTMyOqa6TWbP31u40kTRIM551gnCVQh7bN4
 CxNA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20221208; t=1681623434; x=1684215434;
 h=to:cc:date:message-id:subject:mime-version
 :content-transfer-encoding:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=HcNM5N6RUiQAkWK0cY8MfL0xUSwBw7TAecS5AL6ypWs=;
 b=lpBwlgap9T3Y0y15fZQauugWCxG3cF/PmW1LC4aEDitwOev+rP5Rm24RSb6EReLtID
 cXonWB6+fYqeCaX2o7gpLId+Pn21ZGk+MnKgPDLUtOqKbECeFSCewddNqcG9n+8iHTwN
 zIVz88ipzTULWw2e7ebVzvQILL+f8T7dgGZ4soOV5oodiVof+PW+5r6I1T+sos0H+pn5
 VoTU75lOeFdabHnGScCzCpH908Hq1YF1wAjEyS0xbOG+e1iCJ35XLs2C4MjJGHuws3P0
 TgWEdd3r4RnL20JeEZiBoXUcNBwny/u4WQd41Tln9FZJ8QkqRwYBfGH+15KErjOlPiPR
 ukOQ==
X-Gm-Message-State: AAQBX9cQJfykv6YCoKK198n3f4xOQ94ISfsTSLRrQsp+dAY4FCfNTllv
 7qPw6ka5FLO4t5kjIKDtNrU=
X-Google-Smtp-Source: AKy350b86JHz69JueKNO4oVYjEQF8ZSA2ZuHmyfp283HWbn2JhjjXui5WjtetSTjhwLz/x4bF6oK1Q==
X-Received: by 2002:a17:902:e747:b0:1a6:6090:7114 with SMTP id
 p7-20020a170902e74700b001a660907114mr9858829plf.69.1681623434542; 
 Sat, 15 Apr 2023 22:37:14 -0700 (PDT)
Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com.
 [172.117.161.177]) by smtp.gmail.com with ESMTPSA id
 6-20020a170902c20600b001a6d08dc847sm244505pll.173.2023.04.15.22.37.13
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Sat, 15 Apr 2023 22:37:14 -0700 (PDT)
From: Yuan Fu <casouri@HIDDEN>
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\))
Message-Id: <80353D80-21FD-4ADE-8982-4B67C59B7E7B@HIDDEN>
Date: Sat, 15 Apr 2023 22:37:02 -0700
X-Mailer: Apple Mail (2.3731.500.231)
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


Eli Zaretskii <eliz@HIDDEN> writes:

>> From: Yuan Fu <casouri@HIDDEN>
>> Date: Fri, 14 Apr 2023 13:19:41 -0700
>> Cc: Theodor Thornhill <theo@HIDDEN>,
>>  62825 <at> debbugs.gnu.org
>>=20
>> Ok, I fixed indent-defund and add-log. Because a DEFUN is made of
>> two nodes in the parse tree rather than one, it=E2=80=99s a bit hard =
to
>> incorporate it into the normal treesit-defun-at-point, etc,
>> functions. And we probably have to fix DEFUN case-by-case.
>
> Thanks.  But I wonder why do we need the c-ts-mode-emacs-devel knob.
> Why not recognize DEFUN by default everywhere?  CC Mode does that,
> AFAIK, so why shouldn't c-ts-mode do the same?

I just thought the fix is a bit hacky, and does add some overhead, so
people who don=E2=80=99t need it might not be happy to know that they =
can=E2=80=99t turn
it off.

Yuan

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#62825: 29.0.90; c-ts-mode doesn't recognize DEFUN functions
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sun, 16 Apr 2023 08:15:01 +0000
Resent-Message-ID: <handler.62825.B62825.16816328738593 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 62825
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Yuan Fu <casouri@HIDDEN>
Cc: theo@HIDDEN, 62825 <at> debbugs.gnu.org
Received: via spool by 62825-submit <at> debbugs.gnu.org id=B62825.16816328738593
          (code B ref 62825); Sun, 16 Apr 2023 08:15:01 +0000
Received: (at 62825) by debbugs.gnu.org; 16 Apr 2023 08:14:33 +0000
Received: from localhost ([127.0.0.1]:50572 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pnxWr-0002EX-GV
	for submit <at> debbugs.gnu.org; Sun, 16 Apr 2023 04:14:33 -0400
Received: from eggs.gnu.org ([209.51.188.92]:55350)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pnxWp-0002EJ-Mo
 for 62825 <at> debbugs.gnu.org; Sun, 16 Apr 2023 04:14:32 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pnxWi-0001rD-Sc; Sun, 16 Apr 2023 04:14:24 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=FdvCjDUzCOaGFtTWKbM0OQEe4rMW9vOv/Dy/uSeyl8s=; b=FovoAl4n6z4zvo/lROmD
 EvrbAfAunpBuMDH1INExvIABglqylWZdAUfrbiScGFOp8/zurvN7K5sqqdYR1SGYyVP6C4rz9cOBQ
 s+dvzcgewCtLCzDRz/YpkfxLsVzAp+xRjxS+0f7Yl1j3PP79xQYGus5ifE0ZybdLW5ThnkofPgmkw
 G7E7C5NQmnfx426ii73eM92SepcPPYAX+vyUXdmcnRBrq/fcrYf/ZTANKcYQxHZUUDmjcoSRqNmxm
 2+oOwLT6zMn3p6gc3Qo0U4MhrL9TS7BEaOn1kaf0va8emlw+4VN5TVe6VJyhB3g1K8gCODNnXbOo2
 BCYIzZWz+j8j2Q==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pnxWg-0001PI-PY; Sun, 16 Apr 2023 04:14:24 -0400
Date: Sun, 16 Apr 2023 11:14:25 +0300
Message-Id: <83jzycb5we.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <80353D80-21FD-4ADE-8982-4B67C59B7E7B@HIDDEN> (message from
 Yuan Fu on Sat, 15 Apr 2023 22:37:02 -0700)
References: <80353D80-21FD-4ADE-8982-4B67C59B7E7B@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Yuan Fu <casouri@HIDDEN>
> Date: Sat, 15 Apr 2023 22:37:02 -0700
> Cc: 62825 <at> debbugs.gnu.org,
>  theo@HIDDEN
> 
> 
> Eli Zaretskii <eliz@HIDDEN> writes:
> 
> > Thanks.  But I wonder why do we need the c-ts-mode-emacs-devel knob.
> > Why not recognize DEFUN by default everywhere?  CC Mode does that,
> > AFAIK, so why shouldn't c-ts-mode do the same?
> 
> I just thought the fix is a bit hacky, and does add some overhead, so
> people who don’t need it might not be happy to know that they can’t turn
> it off.

OK, but I made it into a defcustom and turned this on by default.  I
also renamed a few symbols, please take a look.

Btw, should the code you added to c-ts-mode--defun-name recognize
DEFUN nodes only when this variable is non-nil?

Last modified: Sun, 16 Apr 2023 08:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.