GNU bug report logs - #62922
[PATCH] gnu: python-lazr-restfulclient: Add missing dependency

Previous Next

Package: guix-patches;

Reported by: Tom Willemse <tom <at> ryuslash.org>

Date: Tue, 18 Apr 2023 08:13:02 UTC

Severity: normal

Tags: patch

To reply to this bug, email your comments to 62922 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#62922; Package guix-patches. (Tue, 18 Apr 2023 08:13:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Tom Willemse <tom <at> ryuslash.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 18 Apr 2023 08:13:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tom Willemse <tom <at> ryuslash.org>
To: guix-patches <at> gnu.org
Cc: Tom Willemse <tom <at> ryuslash.org>
Subject: [PATCH] gnu: python-lazr-restfulclient: Add missing dependency
Date: Tue, 18 Apr 2023 01:12:23 -0700
* gnu/packages/python-web.scm (python-lazr-restfulclient): Add missing
dependency: python-six
---
Trying to rebuild my guix home config I ran into the following error:

starting phase `sanity-check'
validating 'lazr.restfulclient' /gnu/store/llar0l72885zagk7km0hvjlq4hb3g2sx-python-lazr-restfulclient-0.14.4/lib/python3.9/site-packages
...checking requirements: ERROR: lazr.restfulclient==0.14.4 DistributionNotFound(Requirement.parse('six'), {'lazr.restfulclient'})
error: in phase 'sanity-check': uncaught exception:
%exception #<&invoke-error program: "python" arguments: ("/gnu/store/35ix1m6m8a5s21j02ajhdyqxb2xkshfb-sanity-check.py" "/gnu/store/llar0l72885zagk7km0hvjlq4hb3g2sx-python-lazr-restfulclient-0.14.4/lib/python3.9/site-packages") exit-status: 1 term-signal: #f stop-signal: #f>
phase `sanity-check' failed after 0.2 seconds
command "python" "/gnu/store/35ix1m6m8a5s21j02ajhdyqxb2xkshfb-sanity-check.py" "/gnu/store/llar0l72885zagk7km0hvjlq4hb3g2sx-python-lazr-restfulclient-0.14.4/lib/python3.9/site-packages" failed with status 1

From what I understand from the text it indicates that the requirements.txt of
the lazr restfulclient project specifies a dependency on six, but that package
hasn't been installed in the environment. Adding this dependency fixes the issue
for me.

 gnu/packages/python-web.scm | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index d84b5efdf9..051346c66a 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -127,21 +127,19 @@ (define-public python-lazr-restfulclient
   (package
     (name "python-lazr-restfulclient")
     (version "0.14.4")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (pypi-uri "lazr.restfulclient" version))
-       (sha256
-        (base32 "11yhlqmdf2cqbdfzn8gdmzvmcivh4fflr18zf412sflvfjrdc3xz"))))
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "lazr.restfulclient" version))
+              (sha256
+               (base32
+                "11yhlqmdf2cqbdfzn8gdmzvmcivh4fflr18zf412sflvfjrdc3xz"))))
     (build-system python-build-system)
     ;; Disable the test suite to avoid the lazr.authentication requirement,
     ;; which requires the ancient 'oauth', a Python 2 only library.
-    (arguments (list #:tests? #f))
-    (propagated-inputs
-     (list python-distro
-           python-httplib2
-           python-oauthlib
-           python-wadllib))
+    (arguments
+     (list #:tests? #f))
+    (propagated-inputs (list python-distro python-httplib2 python-oauthlib
+                             python-wadllib python-six))
     (home-page "https://launchpad.net/lazr.restfulclient")
     (synopsis "Web client Python library extending wadlib")
     (description "This package provides a programmable client library that

base-commit: 79b2221ce43b8026eae6461a9269466cae946cac
-- 
2.40.0





Information forwarded to lars <at> 6xq.net, jgart <at> dismail.de, guix-patches <at> gnu.org:
bug#62922; Package guix-patches. (Tue, 16 May 2023 20:32:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tom Willemse <tom <at> ryuslash.org>
To: guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: python-lazr-restfulclient: Add missing dependency
Date: Tue, 16 May 2023 13:31:14 -0700
Hello!

Tom Willemse <tom <at> ryuslash.org> writes:

> * gnu/packages/python-web.scm (python-lazr-restfulclient): Add missing
> dependency: python-six
> ---
> Trying to rebuild my guix home config I ran into the following error:
>
> starting phase `sanity-check'
> validating 'lazr.restfulclient' /gnu/store/llar0l72885zagk7km0hvjlq4hb3g2sx-python-lazr-restfulclient-0.14.4/lib/python3.9/site-packages
> ...checking requirements: ERROR: lazr.restfulclient==0.14.4 DistributionNotFound(Requirement.parse('six'), {'lazr.restfulclient'})
> error: in phase 'sanity-check': uncaught exception:
> %exception #<&invoke-error program: "python" arguments: ("/gnu/store/35ix1m6m8a5s21j02ajhdyqxb2xkshfb-sanity-check.py" "/gnu/store/llar0l72885zagk7km0hvjlq4hb3g2sx-python-lazr-restfulclient-0.14.4/lib/python3.9/site-packages") exit-status: 1 term-signal: #f stop-signal: #f>
> phase `sanity-check' failed after 0.2 seconds
> command "python" "/gnu/store/35ix1m6m8a5s21j02ajhdyqxb2xkshfb-sanity-check.py" "/gnu/store/llar0l72885zagk7km0hvjlq4hb3g2sx-python-lazr-restfulclient-0.14.4/lib/python3.9/site-packages" failed with status 1
>
> From what I understand from the text it indicates that the requirements.txt of
> the lazr restfulclient project specifies a dependency on six, but that package
> hasn't been installed in the environment. Adding this dependency fixes the issue
> for me.
>
>  gnu/packages/python-web.scm | 22 ++++++++++------------
>  1 file changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index d84b5efdf9..051346c66a 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -127,21 +127,19 @@ (define-public python-lazr-restfulclient
>    (package
>      (name "python-lazr-restfulclient")
>      (version "0.14.4")
> -    (source
> -     (origin
> -       (method url-fetch)
> -       (uri (pypi-uri "lazr.restfulclient" version))
> -       (sha256
> -        (base32 "11yhlqmdf2cqbdfzn8gdmzvmcivh4fflr18zf412sflvfjrdc3xz"))))
> +    (source (origin
> +              (method url-fetch)
> +              (uri (pypi-uri "lazr.restfulclient" version))
> +              (sha256
> +               (base32
> +                "11yhlqmdf2cqbdfzn8gdmzvmcivh4fflr18zf412sflvfjrdc3xz"))))
>      (build-system python-build-system)
>      ;; Disable the test suite to avoid the lazr.authentication requirement,
>      ;; which requires the ancient 'oauth', a Python 2 only library.
> -    (arguments (list #:tests? #f))
> -    (propagated-inputs
> -     (list python-distro
> -           python-httplib2
> -           python-oauthlib
> -           python-wadllib))
> +    (arguments
> +     (list #:tests? #f))
> +    (propagated-inputs (list python-distro python-httplib2 python-oauthlib
> +                             python-wadllib python-six))
>      (home-page "https://launchpad.net/lazr.restfulclient")
>      (synopsis "Web client Python library extending wadlib")
>      (description "This package provides a programmable client library that
>
> base-commit: 79b2221ce43b8026eae6461a9269466cae946cac
> -- 
> 2.40.0

Apologies if this is the wrong way to go about it to add some people to
the CC, but it was pointed out to me that I should have included the
area owners in the first place.

If you would be so kind as to have a look, this issue is preventing me
from upgrading my guix installation because one of the packages I
install uses Bazaar to get the source, which is actually aliased to
Breezy, which requires the package in this patch.




Information forwarded to guix-patches <at> gnu.org:
bug#62922; Package guix-patches. (Mon, 22 May 2023 18:39:02 GMT) Full text and rfc822 format available.

Message #11 received at 62922 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: 62922 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: python-lazr-restfulclient: Add missing dependencies.
Date: Mon, 22 May 2023 20:38:17 +0200
[Message part 1 (text/plain, inline)]
Fixes <https://issues.guix.gnu.org/62922>.

* gnu/packages/python-web.scm (python-lazr-restfulclient): Add missing
dependencies.
[propagated-inputs] Add python-pyparsing and python-six.
---
The original patch from Tom Willemse still issued a DistributionNotFound error
on pyparsing.  This alternative version adds both dependencies (without extra
reformatting).  Thanks Tom for the initiative!

 gnu/packages/python-web.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
index b6ad489626..262309032f 100644
--- a/gnu/packages/python-web.scm
+++ b/gnu/packages/python-web.scm
@@ -59,6 +59,7 @@
 ;;; Copyright © 2022 Michael Rohleder <mike <at> rohleder.de>
 ;;; Copyright © 2022 Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
 ;;; Copyright © 2023 John Kehayias <john.kehayias <at> protonmail.com>
+;;; Copyright © 2023 Ivan Vilata-i-Balaguer <ivan <at> selidor.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -143,6 +144,8 @@ (define-public python-lazr-restfulclient
      (list python-distro
            python-httplib2
            python-oauthlib
+           python-pyparsing
+           python-six
            python-wadllib))
     (home-page "https://launchpad.net/lazr.restfulclient")
     (synopsis "Web client Python library extending wadlib")

base-commit: dff1689bb37e5303868584d3f1d7a33cbcb7f51e
-- 
2.39.2


-- 
Ivan Vilata i Balaguer -- https://elvil.net/
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#62922; Package guix-patches. (Tue, 23 May 2023 07:28:02 GMT) Full text and rfc822 format available.

Message #14 received at 62922 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Vilata i Balaguer <ivan <at> selidor.net>
To: Ivan Vilata i Balaguer <ivan <at> selidor.net>
Cc: 62922 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: python-lazr-restfulclient: Add missing
 dependencies.
Date: Tue, 23 May 2023 09:27:25 +0200
[Message part 1 (text/plain, inline)]
An equivalent patch was commited by jgart:
87d75d915152b150c3800d7011b04b4d11cd339c.

This issue can be closed now, thanks!


Ivan Vilata i Balaguer (2023-05-22 20:38:17 +0200) wrote:

> Fixes <https://issues.guix.gnu.org/62922>.
> 
> * gnu/packages/python-web.scm (python-lazr-restfulclient): Add missing
> dependencies.
> [propagated-inputs] Add python-pyparsing and python-six.
> ---
> The original patch from Tom Willemse still issued a DistributionNotFound error
> on pyparsing.  This alternative version adds both dependencies (without extra
> reformatting).  Thanks Tom for the initiative!
> 
>  gnu/packages/python-web.scm | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index b6ad489626..262309032f 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -59,6 +59,7 @@
>  ;;; Copyright © 2022 Michael Rohleder <mike <at> rohleder.de>
>  ;;; Copyright © 2022 Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
>  ;;; Copyright © 2023 John Kehayias <john.kehayias <at> protonmail.com>
> +;;; Copyright © 2023 Ivan Vilata-i-Balaguer <ivan <at> selidor.net>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -143,6 +144,8 @@ (define-public python-lazr-restfulclient
>       (list python-distro
>             python-httplib2
>             python-oauthlib
> +           python-pyparsing
> +           python-six
>             python-wadllib))
>      (home-page "https://launchpad.net/lazr.restfulclient")
>      (synopsis "Web client Python library extending wadlib")
> 
> base-commit: dff1689bb37e5303868584d3f1d7a33cbcb7f51e
> -- 
> 2.39.2

-- 
Ivan Vilata i Balaguer -- https://elvil.net/
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 330 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.