GNU bug report logs - #62940
29.0.60; vc: no easy way to get diff of all outgoing changes

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: Spencer Baugh <sbaugh@HIDDEN>; dated Tue, 18 Apr 2023 19:13:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Severity set to 'wishlist' from 'normal' Request was from Stefan Kangas <stefankangas@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 62940 <at> debbugs.gnu.org:


Received: (at 62940) by debbugs.gnu.org; 16 Aug 2023 07:52:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 16 03:52:48 2023
Received: from localhost ([127.0.0.1]:38746 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qWBKi-0003Xu-7E
	for submit <at> debbugs.gnu.org; Wed, 16 Aug 2023 03:52:48 -0400
Received: from relay9-d.mail.gandi.net ([217.70.183.199]:53289)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1qWBKe-0003Xe-A9
 for 62940 <at> debbugs.gnu.org; Wed, 16 Aug 2023 03:52:46 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id 3D6BCFF808;
 Wed, 16 Aug 2023 07:52:35 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Spencer Baugh <sbaugh@HIDDEN>
Subject: Re: bug#62940: 29.0.60; vc: no easy way to get diff of all outgoing
 changes
In-Reply-To: <ier5y5hqul4.fsf@HIDDEN> (Spencer Baugh's message of
 "Mon, 14 Aug 2023 15:42:31 -0400")
Organization: LINKOV.NET
References: <iermt35xavm.fsf@HIDDEN> <m2bkjlkjvo.fsf@HIDDEN>
 <640746f7-fa1c-dfb9-aaab-f9d8effdf64f@HIDDEN>
 <86y1mo5pur.fsf@HIDDEN> <ier5y5hqul4.fsf@HIDDEN>
Date: Wed, 16 Aug 2023 10:48:18 +0300
Message-ID: <86il9fbf7h.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62940
Cc: Dmitry Gutov <dmitry@HIDDEN>, 62940 <at> debbugs.gnu.org,
 Filipp Gunbin <fgunbin@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>>>   C-x v O C-x h =
>>>
>>> Which would be D. in the original message. It doesn't support uncommitted
>>> changes, but I would be surprised if it did.
>>
>> It's supported only for vc that inserts a text header in logs like RCS.
>> I proposed to insert extra line that represents uncommitted git changes,
>> and I'm using this feature all the time.
>
> Is your patch for this available somewhere?  I find myself wanting the
> same thing for hg.

Searching the right version in the archives would take much time,
so it's easier just to send the version that I use every day.
Here it is, just 3 new lines:

diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index a7763360795..37dc619da5e 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -1419,6 +1419,9 @@ vc-git-print-log
     ;; read-only.
     (let ((inhibit-read-only t))
       (with-current-buffer buffer
+        (when (memq vc-log-view-type '(long short))
+          (insert (propertize "(Type 'd' here to show diffs with working version)\n"
+                              'font-lock-face 'shadow)))
 	(apply #'vc-git-command buffer
 	       'async files
 	       (append

>> But the problem is that it's inserted even when 'C-x v b l' lists
>> another branch where such line makes no sense.
>
> Maybe we could only insert this line if there are actually uncommitted
> changes?

Good idea.  Also this line should not be shown in the output of
'vc-print-branch-log'.

PS: Sorry that answering your other requests about the project features
will take a little more time.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#62940; Package emacs. Full text available.

Message received at 62940 <at> debbugs.gnu.org:


Received: (at 62940) by debbugs.gnu.org; 14 Aug 2023 19:42:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Aug 14 15:42:40 2023
Received: from localhost ([127.0.0.1]:34434 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qVdSZ-0000kk-Se
	for submit <at> debbugs.gnu.org; Mon, 14 Aug 2023 15:42:40 -0400
Received: from mxout6.mail.janestreet.com ([64.215.233.21]:52383)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <sbaugh@HIDDEN>) id 1qVdSX-0000kW-IB
 for 62940 <at> debbugs.gnu.org; Mon, 14 Aug 2023 15:42:38 -0400
From: Spencer Baugh <sbaugh@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#62940: 29.0.60; vc: no easy way to get diff of all outgoing
 changes
In-Reply-To: <86y1mo5pur.fsf@HIDDEN> (Juri Linkov's message of "Wed, 
 19 Apr 2023 09:49:00 +0300")
References: <iermt35xavm.fsf@HIDDEN> <m2bkjlkjvo.fsf@HIDDEN>
 <640746f7-fa1c-dfb9-aaab-f9d8effdf64f@HIDDEN>
 <86y1mo5pur.fsf@HIDDEN>
Date: Mon, 14 Aug 2023 15:42:31 -0400
Message-ID: <ier5y5hqul4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 62940
Cc: Dmitry Gutov <dmitry@HIDDEN>, 62940 <at> debbugs.gnu.org,
 Filipp Gunbin <fgunbin@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Juri Linkov <juri@HIDDEN> writes:
>>   C-x v O C-x h =
>>
>> Which would be D. in the original message. It doesn't support uncommitted
>> changes, but I would be surprised if it did.
>
> It's supported only for vc that inserts a text header in logs like RCS.
> I proposed to insert extra line that represents uncommitted git changes,
> and I'm using this feature all the time.

Is your patch for this available somewhere?  I find myself wanting the
same thing for hg.

> But the problem is that it's inserted even when 'C-x v b l' lists
> another branch where such line makes no sense.

Maybe we could only insert this line if there are actually uncommitted
changes?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#62940; Package emacs. Full text available.

Message received at 62940 <at> debbugs.gnu.org:


Received: (at 62940) by debbugs.gnu.org; 22 Apr 2023 19:27:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 22 15:27:42 2023
Received: from localhost ([127.0.0.1]:44153 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pqIta-00058c-EZ
	for submit <at> debbugs.gnu.org; Sat, 22 Apr 2023 15:27:42 -0400
Received: from eggs.gnu.org ([209.51.188.92]:50100)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pqItU-00058I-T2
 for 62940 <at> debbugs.gnu.org; Sat, 22 Apr 2023 15:27:40 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pqItO-0004d5-Ss; Sat, 22 Apr 2023 15:27:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=ZY+REjCJKcdBLS/dpSaZCMpSATr889nFarLIIRDt1J0=; b=o/dmhD5ZMOWF
 VN/MmJxdmhG5D7dVmqV+8oeFJMdbwhDY3I4e7/IkDdsDbHl5UHulxUOY5WJOKMHRMvZKQKHt9nM3k
 p4y7ftdabVbajEhbtnq3iuo4TCgN/KD7oGbrb2wV0FsRgXvBNMMyLN4/mbOC5Ha4wjaUdQMYgiqD+
 8BdlV04vw2OwJoZSuNinmrnK0lodSfS2LpDkNGt0fr1D/0oXWS/dVV8fN6L4v9deTgzhpH44AvN1r
 yWv87Xi0FEt2sNuXluw9qsv2Uc0eLa1ThCAq0pt/YYONVNN1XTLq4QwcXy8YpyAy1FakB6SJMkN0l
 1F2aDZPFxDMYSUjnr8eaoA==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pqItO-00078d-By; Sat, 22 Apr 2023 15:27:30 -0400
Date: Sat, 22 Apr 2023 22:27:48 +0300
Message-Id: <83zg6zzphn.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <6bfd4eb6-f2f6-944b-196c-cbb6957e890e@HIDDEN> (message from
 Dmitry Gutov on Sat, 22 Apr 2023 21:33:35 +0300)
Subject: Re: bug#62940: 29.0.60; vc: no easy way to get diff of all outgoing
 changes
References: <iermt35xavm.fsf@HIDDEN> <m2bkjlkjvo.fsf@HIDDEN>
 <ierjzy8yhpi.fsf@HIDDEN> <87sfctkrqn.fsf@HIDDEN>
 <83jzy42yll.fsf@HIDDEN> <87fs8skr5s.fsf@HIDDEN> <835y9o12fl.fsf@HIDDEN>
 <6bfd4eb6-f2f6-944b-196c-cbb6957e890e@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62940
Cc: sbaugh@HIDDEN, 62940 <at> debbugs.gnu.org, fgunbin@HIDDEN,
 sbaugh@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Date: Sat, 22 Apr 2023 21:33:35 +0300
> Cc: sbaugh@HIDDEN, 62940 <at> debbugs.gnu.org, fgunbin@HIDDEN
> From: Dmitry Gutov <dmitry@HIDDEN>
> 
> On 22/04/2023 16:17, Eli Zaretskii wrote:
> > I don't think it is TRT to change the behavior of "C-x v O" in the
> > above scenario.  Because it will make it much harder to see the
> > changes for all the files, since in Emacs you are almost always "in
> > some file-visiting buffer".
> > 
> > So the above can only be optional behavior, not the default.
> 
> We could add a couple of new commands, with -fileset- in their names. 
> Couple - for incoming and outgoing.

That would work, of course.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#62940; Package emacs. Full text available.

Message received at 62940 <at> debbugs.gnu.org:


Received: (at 62940) by debbugs.gnu.org; 22 Apr 2023 18:33:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 22 14:33:48 2023
Received: from localhost ([127.0.0.1]:44137 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pqI3Q-0003bJ-3L
	for submit <at> debbugs.gnu.org; Sat, 22 Apr 2023 14:33:48 -0400
Received: from new3-smtp.messagingengine.com ([66.111.4.229]:35111)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dmitry@HIDDEN>) id 1pqI3N-0003b4-Pi
 for 62940 <at> debbugs.gnu.org; Sat, 22 Apr 2023 14:33:47 -0400
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailnew.nyi.internal (Postfix) with ESMTP id 6C00F5812B8;
 Sat, 22 Apr 2023 14:33:39 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Sat, 22 Apr 2023 14:33:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
 :cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to; s=fm2; t=
 1682188419; x=1682192019; bh=RjAJILyFI3vrx0Izna+jNZetmZTUSeH5Qd+
 Ea8AlfJY=; b=mwbMf0Ok0FxPUQHYZxATjX6ExUtxhrQ8WL89GJTQCUc6KNxs0sc
 jksAlTo4vMBNU1qS/wZ3mpfoc0Tx7rqFqBk7pUQdEWRplb1GEDyjWUBEfhcUWPL7
 BZ0Hx6vzqA7TWb9l8LjYrEmu7VDpaM+f3Wi+URBWz8kHywJSUJ77bjYBlbFBW6Jr
 WBpneXoklLf/TXUex5sWfBk0VVOn0g7yqdr/lkOSRSk6LEKQRdKXc1Cs61nD7DBD
 hFL8gdxeHFkBhu6FtTn5K4wk+zsyNSn5/hku8ARZFgzsC8pESgFc+9WRqk1zJ7Je
 DLAr8YYbzS4jXAIPANEbGxTpOjw2DZDc1VA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
 1682188419; x=1682192019; bh=RjAJILyFI3vrx0Izna+jNZetmZTUSeH5Qd+
 Ea8AlfJY=; b=JuWKnmlG1ghB2xjFL3x0LvsnMY0RfyS21uK+y5vHJogL8z8s4xL
 mHZDEWoAu2K6yLL3B9tYPV5rQid1u3uwzZqqzdX8q4laVSzQH8GDDKup9ojQcLtE
 /m25vHlDE9M86z9a3t3x5+01Q+yNE82NAmtOHLKuNd8mkr6zeoy7w8YkNE7Iknq4
 6c8BOcXeUMKyRVmNLcAeM43fzt20atKa0e8KRIkFY2c33o5UecR1qSlD+6FcrgQB
 V7F2m3RuCFFXrHDjkqVAOTmz49Dz4Q0/CGOgvS0y71vlMsDv36EdK3v/+UHT6GG/
 tt308N1UPURjwy8va1oJn8RVsRPe4scqxLQ==
X-ME-Sender: <xms:gihEZKtJEl8fon_i7kwLcioerPOZgFlhAd40_Ehf26hJaKP25L1FyA>
 <xme:gihEZPcbk2QCF5aiqcQx4mq3zeCbPzqdEQWd0oRVmX5cbgCGfRk57EVnfCa7mt9eV
 8L7jWCNmVK5ZrqaHYY>
X-ME-Received: <xmr:gihEZFwq1-4TuNKyZ-uPFAiQuFsU0bhYs2e6_NfIfQVumno1w82d-GcDDmoSaL8>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtiedguddviecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhm
 ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg
 htthgvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeev
 ledvveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe
 gumhhithhrhiesghhuthhovhdruggvvh
X-ME-Proxy: <xmx:gihEZFMdXxuN-3Z0qTmkRgGY5ZsQjOJKphMrNzs73EG-7SiiChCZig>
 <xmx:gihEZK_Sn1o72d5fsGzt0faxyYk_SIcNQoyYrzJyO8wpTYGqxAIB9g>
 <xmx:gihEZNWKkKkkHDg4iDehzTY_tWGP4hQKXfSpuvkGL1b1a0aLuh5zeA>
 <xmx:gyhEZBaWTeMTL8hMnIy77RTVae0_SOwVcX8OhHUvn64psG5VcubOyw>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 22 Apr 2023 14:33:36 -0400 (EDT)
Message-ID: <6bfd4eb6-f2f6-944b-196c-cbb6957e890e@HIDDEN>
Date: Sat, 22 Apr 2023 21:33:35 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: bug#62940: 29.0.60; vc: no easy way to get diff of all outgoing
 changes
Content-Language: en-US
To: Eli Zaretskii <eliz@HIDDEN>, sbaugh@HIDDEN
References: <iermt35xavm.fsf@HIDDEN> <m2bkjlkjvo.fsf@HIDDEN>
 <ierjzy8yhpi.fsf@HIDDEN> <87sfctkrqn.fsf@HIDDEN>
 <83jzy42yll.fsf@HIDDEN> <87fs8skr5s.fsf@HIDDEN> <835y9o12fl.fsf@HIDDEN>
From: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <835y9o12fl.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -1.9 (-)
X-Debbugs-Envelope-To: 62940
Cc: sbaugh@HIDDEN, 62940 <at> debbugs.gnu.org, fgunbin@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.9 (--)

On 22/04/2023 16:17, Eli Zaretskii wrote:
>> From:sbaugh@HIDDEN
>> Date: Sat, 22 Apr 2023 13:00:48 +0000 (UTC)
>> Cc:sbaugh@HIDDEN,62940 <at> debbugs.gnu.org,fgunbin@HIDDEN
>>
>> 1. View a file buffer
>> 2. Hit C-x v O
>> 3. See outgoing changes only for that file
> I don't think it is TRT to change the behavior of "C-x v O" in the
> above scenario.  Because it will make it much harder to see the
> changes for all the files, since in Emacs you are almost always "in
> some file-visiting buffer".
> 
> So the above can only be optional behavior, not the default.
> 
> 
> 

We could add a couple of new commands, with -fileset- in their names. 
Couple - for incoming and outgoing.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#62940; Package emacs. Full text available.

Message received at 62940 <at> debbugs.gnu.org:


Received: (at 62940) by debbugs.gnu.org; 22 Apr 2023 13:17:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 22 09:17:28 2023
Received: from localhost ([127.0.0.1]:42107 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pqD7I-0002Nl-9w
	for submit <at> debbugs.gnu.org; Sat, 22 Apr 2023 09:17:28 -0400
Received: from eggs.gnu.org ([209.51.188.92]:34488)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pqD7F-0002NY-VN
 for 62940 <at> debbugs.gnu.org; Sat, 22 Apr 2023 09:17:27 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pqD76-0007IQ-2P; Sat, 22 Apr 2023 09:17:16 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=/+Zm7as5932oVqo1Rm8BkSR+u6nvI1U88qswEdvSnmQ=; b=YwQ1e2bRRDfE
 RvEqlbTAhrakhsC410/OoQmFy7y9tGrtVkgEmsbq+2wncJpjqtxX+S0bBtFQUkk5Olk+dwpEKQHdt
 kdzACBhK5d+fSBr5plrG9Mx3YdgI5LQBlD9AzNKG6HwN6TlFHmLTfcRUnenWwywk89QRRr9bE8wq5
 gDbkRe6xFRq3VqLSzkqAlyyNHUIAY09KVjZASwwTOxsAmEXmew+HCjc58LjWSLlA2sw7EUM7xBGFs
 OnwyRfXRWUuBNEaD3RiPzhuHLj5YqwThwHsJmvYWS8YEjt6eVB3O+govNQySjZRQEalMDD7v9QxG1
 EeJ+Qt7o2b1QP90lfbGSAg==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pqD75-0002Wi-DD; Sat, 22 Apr 2023 09:17:15 -0400
Date: Sat, 22 Apr 2023 16:17:34 +0300
Message-Id: <835y9o12fl.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: sbaugh@HIDDEN
In-Reply-To: <87fs8skr5s.fsf@HIDDEN> (sbaugh@HIDDEN)
Subject: Re: bug#62940: 29.0.60; vc: no easy way to get diff of all outgoing
 changes
References: <iermt35xavm.fsf@HIDDEN> <m2bkjlkjvo.fsf@HIDDEN>
 <ierjzy8yhpi.fsf@HIDDEN> <87sfctkrqn.fsf@HIDDEN>
 <83jzy42yll.fsf@HIDDEN> <87fs8skr5s.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62940
Cc: sbaugh@HIDDEN, 62940 <at> debbugs.gnu.org, fgunbin@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: sbaugh@HIDDEN
> Date: Sat, 22 Apr 2023 13:00:48 +0000 (UTC)
> Cc: sbaugh@HIDDEN, 62940 <at> debbugs.gnu.org, fgunbin@HIDDEN
> 
> 1. View a file buffer
> 2. Hit C-x v O
> 3. See outgoing changes only for that file

I don't think it is TRT to change the behavior of "C-x v O" in the
above scenario.  Because it will make it much harder to see the
changes for all the files, since in Emacs you are almost always "in
some file-visiting buffer".

So the above can only be optional behavior, not the default.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#62940; Package emacs. Full text available.

Message received at 62940 <at> debbugs.gnu.org:


Received: (at 62940) by debbugs.gnu.org; 22 Apr 2023 13:00:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 22 09:00:55 2023
Received: from localhost ([127.0.0.1]:42096 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pqCrH-0001x7-7W
	for submit <at> debbugs.gnu.org; Sat, 22 Apr 2023 09:00:55 -0400
Received: from s.wrqvwxzv.outbound-mail.sendgrid.net ([149.72.154.232]:16602)
 by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from
 <bounces+21787432-c625-62940=debbugs.gnu.org@HIDDEN>)
 id 1pqCrF-0001wr-BD
 for 62940 <at> debbugs.gnu.org; Sat, 22 Apr 2023 09:00:54 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com;
 h=from:subject:in-reply-to:references:mime-version:to:cc:content-type:
 content-transfer-encoding:cc:content-type:from:subject:to;
 s=s1; bh=FkFb6P3Ko8mEslsucsab9iw8M9osyb1qZ0JHrBeG3b8=;
 b=ubo3D6HQPFhx/3fnvUEY8nCMkpaMG72Lz6I+wMJ/JGeFcARBIGc7ed2RbNNVAVGoFc70
 daxqoy1Q0ffgOwySrl7nsoWU4/hCXyX6+Nx4zREByBGYB9xPbZGq7d2DmDloP+pmPX5gNg
 34+7NtpAfKTV4SvvKApoAY1aIY1GElG91YbYD9X0hV+bCA2LuQEHEvIDv1UdSEI53VMymb
 uaRIdGXoc+g05SV/gzGlaUcNE85gKN2dGXZgxDGqQVetoHh/fIJ0jLmYJDRyxWQqxvLaKN
 aZIEjlwReX6oCeG267rbhk377lTp40v2VfSfBVMNn4+bZEQR663pN9ofx+eNBWSw==
Received: by filterdrecv-68f8d557c9-cxx9p with SMTP id
 filterdrecv-68f8d557c9-cxx9p-1-6443DA80-9
 2023-04-22 13:00:48.071156184 +0000 UTC m=+5146158.194991992
Received: from earth.catern.com (unknown) by geopod-ismtpd-6 (SG) with ESMTP
 id Mn_E7kT6SemvniDJuNSYNw Sat, 22 Apr 2023 13:00:47.984 +0000 (UTC)
X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost;
 envelope-from=sbaugh@HIDDEN; receiver=<UNKNOWN> 
Received: from localhost (localhost [IPv6:::1])
 by earth.catern.com (Postfix) with ESMTPSA id 8EEBA60044;
 Sat, 22 Apr 2023 09:00:47 -0400 (EDT)
From: sbaugh@HIDDEN
Subject: Re: bug#62940: 29.0.60; vc: no easy way to get diff of all outgoing
 changes
In-Reply-To: <83jzy42yll.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 22 Apr
 2023 09:57:26 +0300")
References: <iermt35xavm.fsf@HIDDEN> <m2bkjlkjvo.fsf@HIDDEN>
 <ierjzy8yhpi.fsf@HIDDEN> <87sfctkrqn.fsf@HIDDEN>
 <83jzy42yll.fsf@HIDDEN>
Date: Sat, 22 Apr 2023 13:00:48 +0000 (UTC)
Message-ID: <87fs8skr5s.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
X-SG-EID: =?us-ascii?Q?ZgbRq7gjGrt0q=2FPjvxk7wM0yQFRdOkTJAtEbkjCkHbJi0=2FNfEqtDN69CarfFQS?=
 =?us-ascii?Q?RMmBxCMf6JAzJLLUJn=2FsgBPD77qsJiUZ2XMRafg?=
 =?us-ascii?Q?nmSUQbZMEcLDi5Fud+xL4T+hiZD8NVoHZSw5xFo?=
 =?us-ascii?Q?uv4rxc9Gfy+RffFwMJPBdfPjSuVcRDL2O3Apk=2FU?=
 =?us-ascii?Q?O+gO1qRuRAMwhTZmcN0i3OYO2hwRXssTP+g=3D=3D?=
To: Eli Zaretskii <eliz@HIDDEN>
X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Spam-Score: 1.2 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview: Eli Zaretskii <eliz@HIDDEN> writes: >> Cc:
 62940 <at> debbugs.gnu.org, 
 Filipp Gunbin <fgunbin@HIDDEN> >> From: sbaugh@HIDDEN >> Date: Fri,
 21 Apr 2023 18:36:01 +0000 (UTC) >> >> After using it fo [...] 
 Content analysis details:   (1.2 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in
 bl.spamcop.net
 [Blocked - see <https://www.spamcop.net/bl.shtml?149.72.154.232>]
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
 [149.72.154.232 listed in wl.mailspike.net]
 0.0 UNPARSEABLE_RELAY      Informational: message has unparseable relay
 lines
X-Debbugs-Envelope-To: 62940
Cc: sbaugh@HIDDEN, 62940 <at> debbugs.gnu.org, fgunbin@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.2 (/)

Eli Zaretskii <eliz@HIDDEN> writes:
>> Cc: 62940 <at> debbugs.gnu.org, Filipp Gunbin <fgunbin@HIDDEN>
>> From: sbaugh@HIDDEN
>> Date: Fri, 21 Apr 2023 18:36:01 +0000 (UTC)
>> 
>> After using it for a bit, one issue is that C-x v O shows changes in all
>> files; it would be nice if there was a way to get outgoing
>> changes/commits only for the current fileset.
>
> What is the current fileset for "C-x v O"? isn't that "all files"
> anyway?

Well, yes, that's the issue.  When my current fileset is not "all files"
(for example when I am in an individual file without marking files in a
vc-dir buffer) I would like to be able to see outgoing changes on just
those files.  C-x v O overrides the fileset to be "all files" instead.

> I could understand if you were talking about a VC command invoked from
> a vc-dir buffer or a Dired buffer, where you can mark files to be
> considered as the current fileset.  That would mean your comment is
> about the vc-dir command 'O' or the equivalent in Dired.  But
> otherwise, I'm not sure I understand the UI you have in mind.

1. View a file buffer
2. Hit C-x v O
3. See outgoing changes only for that file

> And then there's the issue of whether the backend supports what you
> want, of course.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#62940; Package emacs. Full text available.

Message received at 62940 <at> debbugs.gnu.org:


Received: (at 62940) by debbugs.gnu.org; 22 Apr 2023 06:57:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 22 02:57:22 2023
Received: from localhost ([127.0.0.1]:41557 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pq7BR-0005GB-Vv
	for submit <at> debbugs.gnu.org; Sat, 22 Apr 2023 02:57:22 -0400
Received: from eggs.gnu.org ([209.51.188.92]:59636)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1pq7BN-0005Fs-Gk
 for 62940 <at> debbugs.gnu.org; Sat, 22 Apr 2023 02:57:20 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pq7BH-0003kd-IM; Sat, 22 Apr 2023 02:57:11 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=Lk9DZImh3LQm3lJnDtpo+mSsFlmWQCFIiYOU2lWYw4w=; b=LBF4WGIBdrMz
 DYpLGBL/fbNZ6Dv2c08fUWzjN7MrL3VqmPpcDnw4JEHEM2W3UY91tsGRAwPC5oN5Mrh7NeqFgRjZ9
 sSvx4VPNN/NxjooW4VYV6AgQipaGTMkm6/YCZGgQJklc3cMCOhW742pajDx3S6Ex6VsZb7kCWz6E1
 TxPQmeNSHnHmdzZLa7rmNQIYou87uodICYR37zZLttTmF7pupd2VRfypRj/zsxcAkHkdlIId0eR17
 UF5RK0xB+qQ+C8pd4z0Jv+nSNMMQR6aT8E1jw/orUQyam4kJFeBSdypT6vNnQ/VMElaLnDjquzOM1
 /wSRHKbMkVp2O/vaLzrg1g==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1pq7BE-0004xZ-KQ; Sat, 22 Apr 2023 02:57:11 -0400
Date: Sat, 22 Apr 2023 09:57:26 +0300
Message-Id: <83jzy42yll.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: sbaugh@HIDDEN
In-Reply-To: <87sfctkrqn.fsf@HIDDEN> (sbaugh@HIDDEN)
Subject: Re: bug#62940: 29.0.60;
 vc: no easy way to get diff of all outgoing changes
References: <iermt35xavm.fsf@HIDDEN> <m2bkjlkjvo.fsf@HIDDEN>
 <ierjzy8yhpi.fsf@HIDDEN> <87sfctkrqn.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 62940
Cc: sbaugh@HIDDEN, 62940 <at> debbugs.gnu.org, fgunbin@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Cc: 62940 <at> debbugs.gnu.org, Filipp Gunbin <fgunbin@HIDDEN>
> From: sbaugh@HIDDEN
> Date: Fri, 21 Apr 2023 18:36:01 +0000 (UTC)
> 
> After using it for a bit, one issue is that C-x v O shows changes in all
> files; it would be nice if there was a way to get outgoing
> changes/commits only for the current fileset.

What is the current fileset for "C-x v O"? isn't that "all files"
anyway?

I could understand if you were talking about a VC command invoked from
a vc-dir buffer or a Dired buffer, where you can mark files to be
considered as the current fileset.  That would mean your comment is
about the vc-dir command 'O' or the equivalent in Dired.  But
otherwise, I'm not sure I understand the UI you have in mind.

And then there's the issue of whether the backend supports what you
want, of course.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#62940; Package emacs. Full text available.

Message received at 62940 <at> debbugs.gnu.org:


Received: (at 62940) by debbugs.gnu.org; 21 Apr 2023 18:36:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 21 14:36:11 2023
Received: from localhost ([127.0.0.1]:41127 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ppvcB-0000lh-0W
	for submit <at> debbugs.gnu.org; Fri, 21 Apr 2023 14:36:11 -0400
Received: from s.wrqvtzvf.outbound-mail.sendgrid.net ([149.72.126.143]:64006)
 by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from
 <bounces+21787432-c625-62940=debbugs.gnu.org@HIDDEN>)
 id 1ppvc7-0000lE-Te
 for 62940 <at> debbugs.gnu.org; Fri, 21 Apr 2023 14:36:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com;
 h=from:subject:in-reply-to:references:mime-version:to:cc:content-type:
 content-transfer-encoding:cc:content-type:from:subject:to;
 s=s1; bh=bVkoNB8t6YPMCRc7lsJSYuPiiD2ooLvQ0fmGnILEKMU=;
 b=jW5i+NIrCWarp0qV16DlZc5Imsf/5kgZkAg49yKjJCLEgtcysuE4q9cxi4e1x1Nh0aAm
 etsMj6oqj+VBGcJdnWvmga/n3whKn9usvsQaT6/sAR+CCLqeyJ/Z9Y47JgjPso+SnJaA0H
 dVfTf/zBkDTgiYD0NPsSQQZ008GxbAb2M4TTT5spcfb9gOyXCjCBcAs8guY1eaftOgd3lt
 wS/GIVjMKzPuNOfquGiBJz0lXrTkZOvJASnR9LZHCOxvQX7Rig1GldTNoQ6yNSIWc5+DvW
 bUOuvW4ZKfdknwFB6Ch1r4gb83FHg8CJkR64kjsjVvBT9C2Q9JgqbVwUbRc6TEOA==
Received: by filterdrecv-7457b4c9b5-kcwqs with SMTP id
 filterdrecv-7457b4c9b5-kcwqs-1-6442D791-17
 2023-04-21 18:36:01.270693171 +0000 UTC m=+5079738.575890474
Received: from earth.catern.com (unknown) by geopod-ismtpd-8 (SG) with ESMTP
 id TN5d-WS4RM2vpgRWefVZBw Fri, 21 Apr 2023 18:36:01.117 +0000 (UTC)
X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost;
 envelope-from=sbaugh@HIDDEN; receiver=<UNKNOWN> 
Received: from localhost (localhost [IPv6:::1])
 by earth.catern.com (Postfix) with ESMTPSA id 763E760044;
 Fri, 21 Apr 2023 14:36:00 -0400 (EDT)
From: sbaugh@HIDDEN
Subject: Re: bug#62940: 29.0.60; vc: no easy way to get diff of all outgoing
 changes
In-Reply-To: <ierjzy8yhpi.fsf@HIDDEN> (Spencer Baugh's message of
 "Tue, 18 Apr 2023 17:59:53 -0400")
References: <iermt35xavm.fsf@HIDDEN> <m2bkjlkjvo.fsf@HIDDEN>
 <ierjzy8yhpi.fsf@HIDDEN>
Date: Fri, 21 Apr 2023 18:36:01 +0000 (UTC)
Message-ID: <87sfctkrqn.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
X-SG-EID: =?us-ascii?Q?ZgbRq7gjGrt0q=2FPjvxk7wM0yQFRdOkTJAtEbkjCkHbL4uVBr+uNIXAiyJTgQ71?=
 =?us-ascii?Q?R6LqXZRBT6t9iJeXuhy55kYgS+PjDz9hrMc2FIz?=
 =?us-ascii?Q?wpVndDoHFLcinLwHoggwHaHGmVMgxp9oX3qPyLk?=
 =?us-ascii?Q?N7xV7IoG3M=2FYMjgbhABlGV0EBkx7v34Z=2FGhCk72?=
 =?us-ascii?Q?+8jLJOm6MCJYsEfli64yNPyX+zkFa8PkSlw=3D=3D?=
To: Spencer Baugh <sbaugh@HIDDEN>
X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q==
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 62940
Cc: 62940 <at> debbugs.gnu.org, Filipp Gunbin <fgunbin@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Spencer Baugh <sbaugh@HIDDEN> writes:
> Filipp Gunbin <fgunbin@HIDDEN> writes:
>> Usually I just do C-x v L, select commits that interest me (via region),
>> and do M-x log-view-diff.
>>
>> Have you tried that?  What do you miss there?
>
> Wow, amazing, I did not think to try that!  After some further
> improvements to my vc backend, that is perfect!

After using it for a bit, one issue is that C-x v O shows changes in all
files; it would be nice if there was a way to get outgoing
changes/commits only for the current fileset.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#62940; Package emacs. Full text available.

Message received at 62940 <at> debbugs.gnu.org:


Received: (at 62940) by debbugs.gnu.org; 19 Apr 2023 06:51:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 19 02:51:18 2023
Received: from localhost ([127.0.0.1]:60940 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pp1ew-0001rZ-49
	for submit <at> debbugs.gnu.org; Wed, 19 Apr 2023 02:51:18 -0400
Received: from relay2-d.mail.gandi.net ([217.70.183.194]:45687)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1pp1er-0001qX-WE
 for 62940 <at> debbugs.gnu.org; Wed, 19 Apr 2023 02:51:16 -0400
Received: (Authenticated sender: juri@HIDDEN)
 by mail.gandi.net (Postfix) with ESMTPSA id 3AEF74000D;
 Wed, 19 Apr 2023 06:51:04 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Dmitry Gutov <dmitry@HIDDEN>
Subject: Re: bug#62940: 29.0.60; vc: no easy way to get diff of all outgoing
 changes
In-Reply-To: <640746f7-fa1c-dfb9-aaab-f9d8effdf64f@HIDDEN> (Dmitry Gutov's
 message of "Tue, 18 Apr 2023 23:43:55 +0300")
Organization: LINKOV.NET
References: <iermt35xavm.fsf@HIDDEN> <m2bkjlkjvo.fsf@HIDDEN>
 <640746f7-fa1c-dfb9-aaab-f9d8effdf64f@HIDDEN>
Date: Wed, 19 Apr 2023 09:49:00 +0300
Message-ID: <86y1mo5pur.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62940
Cc: Spencer Baugh <sbaugh@HIDDEN>, 62940 <at> debbugs.gnu.org,
 Filipp Gunbin <fgunbin@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

>   C-x v O C-x h =
>
> Which would be D. in the original message. It doesn't support uncommitted
> changes, but I would be surprised if it did.

It's supported only for vc that inserts a text header in logs like RCS.
I proposed to insert extra line that represents uncommitted git changes,
and I'm using this feature all the time.  But the problem is that
it's inserted even when 'C-x v b l' lists another branch
where such line makes no sense.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#62940; Package emacs. Full text available.

Message received at 62940 <at> debbugs.gnu.org:


Received: (at 62940) by debbugs.gnu.org; 18 Apr 2023 22:00:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 18 18:00:03 2023
Received: from localhost ([127.0.0.1]:60605 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1potMo-00015J-QG
	for submit <at> debbugs.gnu.org; Tue, 18 Apr 2023 18:00:03 -0400
Received: from mxout5.mail.janestreet.com ([64.215.233.18]:55163)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <sbaugh@HIDDEN>) id 1potMl-000147-3x
 for 62940 <at> debbugs.gnu.org; Tue, 18 Apr 2023 18:00:01 -0400
From: Spencer Baugh <sbaugh@HIDDEN>
To: Filipp Gunbin <fgunbin@HIDDEN>
Subject: Re: bug#62940: 29.0.60; vc: no easy way to get diff of all outgoing
 changes
In-Reply-To: <m2bkjlkjvo.fsf@HIDDEN> (Filipp Gunbin's message of "Tue, 18
 Apr 2023 23:36:43 +0300")
References: <iermt35xavm.fsf@HIDDEN> <m2bkjlkjvo.fsf@HIDDEN>
Date: Tue, 18 Apr 2023 17:59:53 -0400
Message-ID: <ierjzy8yhpi.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 62940
Cc: 62940 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Filipp Gunbin <fgunbin@HIDDEN> writes:
> Usually I just do C-x v L, select commits that interest me (via region),
> and do M-x log-view-diff.
>
> Have you tried that?  What do you miss there?

Wow, amazing, I did not think to try that!  After some further
improvements to my vc backend, that is perfect!




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#62940; Package emacs. Full text available.

Message received at 62940 <at> debbugs.gnu.org:


Received: (at 62940) by debbugs.gnu.org; 18 Apr 2023 20:44:10 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 18 16:44:10 2023
Received: from localhost ([127.0.0.1]:60529 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1posBL-0007Dy-8z
	for submit <at> debbugs.gnu.org; Tue, 18 Apr 2023 16:44:10 -0400
Received: from new2-smtp.messagingengine.com ([66.111.4.224]:43333)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <dmitry@HIDDEN>) id 1posBI-0007DC-F8
 for 62940 <at> debbugs.gnu.org; Tue, 18 Apr 2023 16:44:05 -0400
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailnew.nyi.internal (Postfix) with ESMTP id 4970A582081;
 Tue, 18 Apr 2023 16:43:59 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Tue, 18 Apr 2023 16:43:59 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc
 :cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to; s=fm1; t=
 1681850639; x=1681854239; bh=t2LQCTHpF6bj8q/Wr5JKP258fcG9HdcMIj/
 6gx4+S+I=; b=q+kqgUT0OE7skENcjgDUKxlmjRPPTbiqn821LO0D1Tpmm9MbzFq
 v7stshzuZchbodFC9P0+oL44eVAEdLdLsGSlmHdqWcCutGCtGHUwt6xo4klF4BCy
 OY73enQ5ECyOt90t/RIiulU4+i3itrdP1UBCaW74fAOFVAfU2LQS+W5FFe1PR9R8
 Dj8Drx8Za2nUSKmQyEO1+GmWnMrUwGBcrbBT4G5RUL0j2ywQ7VCCxkJZ8kk7h7dF
 YBugmXGRFIVy7SpDTRMlteGd98ekSb/Ufzg0iDmKO3BhduWKBg1av9SbHimyEhHA
 lQciPHrp8iE9AXBWImTMZPYjcw/At6Ph0eQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:sender:subject:subject:to:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=
 1681850639; x=1681854239; bh=t2LQCTHpF6bj8q/Wr5JKP258fcG9HdcMIj/
 6gx4+S+I=; b=hVTzybO9cZ1jNasEL3IAoCJ1J8dwWBpZDbVjjmDAB9N+Njl5flh
 Yrp2CrRfEjuYveR/+sTUKJmto90ou7EpQ9u6rGD9eua4Do9c5mACmYtlkS71I6VD
 bXjIfDokxsJ945g9rd2TCzPrQ5Ch7cC+sDNX5BNGb/4bDnsADzf1walFmOG68cwB
 lJq4AB0t7y99s+rc28PueDd2/TZjf3/882PY1urFNE+ti8gr4IeXsTzYXydQrcUz
 eu14DKLwF3DEe1lrcFKeZOxgQvSpHRTCC7waMNV6yu5B2GU6o62mVfqa8M/9g9cP
 5L+x3uYEekcg5dMBcGlT5TpcIlEI2UAn3zw==
X-ME-Sender: <xms:DgE_ZLo7_SXk1ASeOVkcnaitlR5qQ2qg9265FOeqv7J3OSEEk9mKQQ>
 <xme:DgE_ZFqm6VMVzs6k6pPqeVCJOw05k9zwBTi5Fl7jTtmi3yoebud3hQhdathiM_1BT
 b1u4XqNbEYafCQdvZ8>
X-ME-Received: <xmr:DgE_ZIMISQS6kW0nMiXbcF0K1sSnQ80R-DlmcEcUhKMgNiSk-vrYKSg2kDy9RGU>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdelkedgudehvdcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhm
 ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg
 htthgvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeev
 ledvveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe
 gumhhithhrhiesghhuthhovhdruggvvh
X-ME-Proxy: <xmx:DgE_ZO69ZSi_tQ1Qh2rAbAg7MBcglejKOOmlGdMircaMWs4oTngdoA>
 <xmx:DgE_ZK52oVMAc-dYAHSnIe27VlPfQoS3Bq9LGUI2fOXiY4RyFwZ85Q>
 <xmx:DgE_ZGh4rnkoGdKK4HHfU9-X-dK4ohzjG8DF3btO3TLqXJY7yu8pug>
 <xmx:DwE_ZARZ0cbqcO4B1A9NIeXz8ZP7JcL6aMFopjUm4i9jR45h4-RX6w>
Feedback-ID: i0e71465a:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 18 Apr 2023 16:43:57 -0400 (EDT)
Message-ID: <640746f7-fa1c-dfb9-aaab-f9d8effdf64f@HIDDEN>
Date: Tue, 18 Apr 2023 23:43:55 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: bug#62940: 29.0.60; vc: no easy way to get diff of all outgoing
 changes
Content-Language: en-US
To: Filipp Gunbin <fgunbin@HIDDEN>, Spencer Baugh <sbaugh@HIDDEN>
References: <iermt35xavm.fsf@HIDDEN> <m2bkjlkjvo.fsf@HIDDEN>
From: Dmitry Gutov <dmitry@HIDDEN>
In-Reply-To: <m2bkjlkjvo.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: -1.9 (-)
X-Debbugs-Envelope-To: 62940
Cc: 62940 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.8 (--)

On 18/04/2023 23:36, Filipp Gunbin wrote:
> Usually I just do C-x v L, select commits that interest me (via region),
> and do M-x log-view-diff.

Just in case: 'log-view-diff' is bound to '='.

That's what I wanted to suggest, too. Or use 'vc-log-outgoing':

   C-x v O C-x h =

Which would be D. in the original message. It doesn't support 
uncommitted changes, but I would be surprised if it did.

But one can also try this:

   C-u C-x v D origin/master ^J

Where origin/master is the name of the upstream branch ref. This should 
include uncommitted changes.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#62940; Package emacs. Full text available.

Message received at 62940 <at> debbugs.gnu.org:


Received: (at 62940) by debbugs.gnu.org; 18 Apr 2023 20:36:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 18 16:36:59 2023
Received: from localhost ([127.0.0.1]:60510 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pos4R-00072c-8n
	for submit <at> debbugs.gnu.org; Tue, 18 Apr 2023 16:36:59 -0400
Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:53357)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <fgunbin@HIDDEN>) id 1pos4M-00072O-M2
 for 62940 <at> debbugs.gnu.org; Tue, 18 Apr 2023 16:36:57 -0400
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id 5479E320092B;
 Tue, 18 Apr 2023 16:36:48 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute3.internal (MEProxy); Tue, 18 Apr 2023 16:36:48 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h=
 cc:cc:content-type:content-type:date:date:from:from:in-reply-to
 :in-reply-to:message-id:mime-version:references:reply-to:sender
 :subject:subject:to:to; s=fm3; t=1681850207; x=1681936607; bh=z8
 +/y8szLdRtzAspWbHy1CNNbuQgo/U5ayLNiGYOYIo=; b=bAc8y3vob4QLXZ0HwA
 vwQH61P57kC5gBKdPgB2B1pIO5Q2/qZCmNCJOGoz/5LM7i2ZAwzOkT4WSBON7/IM
 pJqoMDgqBaeBpUCTcbgYV8EmqZkUMWsJzZFyVLkNeyP+1QGtsQwsPKXMpF6Kx47/
 Arxoxv/fPjNV9/LwTrspm02744Wq9NZ6CpHvcA4giD60+iE8dgRI0NMjFhLasamu
 2gxCdTw9dhNKnPNTdLjyT8RyK3s89X884gkNVg3UCOTo5dvMBGoyzty+522NX71O
 1dFvvDC4tid9pWSAiHy7FijqMvPrQjjIOG/U5fxvpc7igDeoJSikPU9o5Q52t9YY
 ++GQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-type:content-type:date:date
 :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
 :message-id:mime-version:references:reply-to:sender:subject
 :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm3; t=1681850207; x=1681936607; bh=z8+/y8szLdRtz
 AspWbHy1CNNbuQgo/U5ayLNiGYOYIo=; b=FjiQPrq4xS5Wdp7juBVbtV57lhrcU
 ZinVcsG5sPvBClS3997vKf+QWdQ0/8mMZ91T8+1fMBmRfGP5no3GS2iuF8NV4y8m
 FxV/H+YfVSQndlcEN1+jRFEVf0z19WcwDbaIClKH/HgPp5xxSBDRTY4WPnrG0lYe
 c9jr2cTxOSk2GzhTs+N9+BgASuxLRjpQ/6fm05i61NFXQBY7rdXJZFbD480/6+O/
 RatWyzLywaF2zBgpbztaGiW1mYiFDRCpE4hQ+gqSREs9zPGzWOTxctKhloWXvxY6
 NkJu707Qa4aG4OtQRAsHrmprJeeL3UX/MeV2kgLVDHM12Jj4W3s4/Br0g==
X-ME-Sender: <xms:X_8-ZHo-mkxcRptE4rLnZtfDTJNyclemfuYDT3iEke2zKxYxrvvTeQ>
 <xme:X_8-ZBpSPN5qVDaoccb8cdgUeqtNa7IMLnTESReb8ZlfkKfBRx7xFB1zLz5Izih1x
 9CCD3DG7ruQfY6L>
X-ME-Received: <xmr:X_8-ZEOpygRyiwkmL8BzJmt4XXurvRpqEKWeHBEFesi8R4CMJmaH5IA_hkSTSPgeag>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdelkedgudehtdcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpefhvfevufgjfhgffffkgggtsehttdertddtredtnecuhfhrohhmpefhihhl
 ihhpphcuifhunhgsihhnuceofhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmheqnecugg
 ftrfgrthhtvghrnhepfffhjeevieeiiedutefgheffleeiveeffeeftdekleehledufeeu
 ueduheevieffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
 homhepfhhguhhnsghinhesfhgrshhtmhgrihhlrdhfmh
X-ME-Proxy: <xmx:X_8-ZK6vA4eReYRdUKYncTVMdjlGF8emI89oJQrEHyeIIKq4Kosa4w>
 <xmx:X_8-ZG7lE-EjIPWkEg6ue9VbzuUzlAEMtCZtFDeNgkoriSfq5uyAfQ>
 <xmx:X_8-ZCgg6BtE9OyijKJy8z42ATejdBaHFUWgdEh2fO9miOIc6uEILg>
 <xmx:X_8-ZLiLPLl08IVAOQO-0x3TWcflqRvbHlwLsn7YFM0vjmJ3-SRYqw>
Feedback-ID: id48c41f1:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 18 Apr 2023 16:36:46 -0400 (EDT)
From: Filipp Gunbin <fgunbin@HIDDEN>
To: Spencer Baugh <sbaugh@HIDDEN>
Subject: Re: bug#62940: 29.0.60; vc: no easy way to get diff of all outgoing
 changes
In-Reply-To: <iermt35xavm.fsf@HIDDEN> (Spencer Baugh's message of
 "Tue, 18 Apr 2023 15:12:45 -0400")
References: <iermt35xavm.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
Date: Tue, 18 Apr 2023 23:36:43 +0300
Message-ID: <m2bkjlkjvo.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 62940
Cc: 62940 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On 18/04/2023 15:12 -0400, Spencer Baugh wrote:

> Reproduction:
> 1. Make some local changes and commits
> 2. C-x v O to see the list of local commits that will be pushed
> 3. But there's no quick way to get a diff combining all those changes,
> which is useful if you've made multiple changes to the same function
> over the course of multiple commits, or if you want to review your
> changes overall before sending them out for review, or any other things
> like that.
>
> C-u C-x v = lets you specify two commits to diff, and the second commit
> even defaults to the working revision, but there's no easy way to get
> the "base" commit that is before all your local changes.  If you're
> using git, you can try to remember your upstream branch and type that
> in, but that's just a matter of memory.  For other VCSs (e.g. hg)
> there's no easy way.
>

[...]

> Thoughts, suggestions?

Usually I just do C-x v L, select commits that interest me (via region),
and do M-x log-view-diff.

Have you tried that?  What do you miss there?




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#62940; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 18 Apr 2023 19:13:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 18 15:13:00 2023
Received: from localhost ([127.0.0.1]:60398 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1poqlA-0004Nw-4y
	for submit <at> debbugs.gnu.org; Tue, 18 Apr 2023 15:13:00 -0400
Received: from lists.gnu.org ([209.51.188.17]:38744)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <sbaugh@HIDDEN>) id 1poql3-0004Ni-Bb
 for submit <at> debbugs.gnu.org; Tue, 18 Apr 2023 15:12:58 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <sbaugh@HIDDEN>)
 id 1poqkz-0002k4-UB
 for bug-gnu-emacs@HIDDEN; Tue, 18 Apr 2023 15:12:50 -0400
Received: from mxout5.mail.janestreet.com ([64.215.233.18])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <sbaugh@HIDDEN>)
 id 1poqky-0001aP-JD
 for bug-gnu-emacs@HIDDEN; Tue, 18 Apr 2023 15:12:49 -0400
From: Spencer Baugh <sbaugh@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 29.0.60; vc: no easy way to get diff of all outgoing changes
Date: Tue, 18 Apr 2023 15:12:45 -0400
Message-ID: <iermt35xavm.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=64.215.233.18; envelope-from=sbaugh@HIDDEN;
 helo=mxout5.mail.janestreet.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)


Reproduction:
1. Make some local changes and commits
2. C-x v O to see the list of local commits that will be pushed
3. But there's no quick way to get a diff combining all those changes,
which is useful if you've made multiple changes to the same function
over the course of multiple commits, or if you want to review your
changes overall before sending them out for review, or any other things
like that.

C-u C-x v = lets you specify two commits to diff, and the second commit
even defaults to the working revision, but there's no easy way to get
the "base" commit that is before all your local changes.  If you're
using git, you can try to remember your upstream branch and type that
in, but that's just a matter of memory.  For other VCSs (e.g. hg)
there's no easy way.

I'm working on adding an easy way to do this in vc, but there are
several ways to approach it and I wanted to check first.

A. (my preferred way) Support a M-1 prefix argument for C-x v =, which
will do a diff against the "base" revision, whatever that is.

B. Add a new keybinding in vc-read-revision which will insert the "base"
revision, so you can just use C-u C-x v = and then insert the base
revision at the first prompt.  Seems hard to make compatible with
non-default completion frameworks.

C. Add new equivalents to C-x v = and C-x v D which diff against the
base revision.  Seems like ugly duplication of keybindings.

D. Make some way to go from a log-view like C-x v O to a diff which
combines all those commits.  Could be nice, but seems a little
unintuitive, and also doesn't support including uncommitted changes in
the diff.

Thoughts, suggestions?




Acknowledgement sent to Spencer Baugh <sbaugh@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#62940; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 11 Sep 2023 23:30:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.