Received: (at 62988) by debbugs.gnu.org; 6 Sep 2025 09:00:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 06 05:00:46 2025 Received: from localhost ([127.0.0.1]:34353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uuomr-0004uW-Op for submit <at> debbugs.gnu.org; Sat, 06 Sep 2025 05:00:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38882) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1uuomn-0004uE-Qd for 62988 <at> debbugs.gnu.org; Sat, 06 Sep 2025 05:00:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1uuomf-0000t4-R5; Sat, 06 Sep 2025 05:00:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zxQ2i4hYJ9ofavbFsOZyCysFSWaIpI4qtHFlj/qXTsg=; b=Bz8No1LWGVVo Jb7U6WaC7PmUEqLzEe24LUllZIoX/Ix/ns4jy8KTtDkGtvATsHq2JNYJRWAyfAWu9wS2xuSrdwv7Q HWEkMkGe+d7Q+kzriHe0ysTAZdUXFQg0NTZEGdCHtHHRCAS/YwaxM4admsqcqKBB1J28NyikXCeFX jis9zmKscvWO4ufHjW+Z0Eo6gISyHP1x72VtctMgZOp6/odwCenNWzS2anfQftPTn5/TGbSW15NT+ kGNwKIKkPGGYSvwtBl4ApuOxLRk2GBCSUEN89dEZArxnZtgV7uL//RP05JDeSoPsFBEpTgwgzXwpU 70ThI6CYALaMwz7B7QFIgw==; Date: Sat, 06 Sep 2025 12:00:28 +0300 Message-Id: <86v7lwez0z.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN> In-Reply-To: <SN6PR06MB393500F68C5D73DE06AAA6B58B05A@HIDDEN> (message from Gabriel do Nascimento Ribeiro on Sat, 30 Aug 2025 18:28:31 +0000) Subject: Re: bug#62988: 30.0.50; Add highlight line-or-region command to pulse.el References: <PH8PR19MB7070793A676262112DC66AEA8B609@HIDDEN> <CADwFkmm3OY7VT5GJCSVv9a=FmJsYcSaGyKok4w7VpmMHZRY92g@HIDDEN> <SN6PR06MB393507888D978BE18E11DF848B38A@HIDDEN> <868qj4t4ek.fsf@HIDDEN> <SN6PR06MB393500F68C5D73DE06AAA6B58B05A@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62988 Cc: stefankangas@HIDDEN, 62988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN> > CC: "stefankangas@HIDDEN" <stefankangas@HIDDEN>, "62988 <at> debbugs.gnu.org" > <62988 <at> debbugs.gnu.org> > Date: Sat, 30 Aug 2025 18:28:31 +0000 > > Thank you the suggestions. Please find below an updated patch. Thanks, I have a few minor comments below. > >From 679f29c24e96b881ce4e2804c8257247c6f16e14 Mon Sep 17 00:00:00 2001 > From: Gabriel Ribeiro <gabriel376@HIDDEN> > Date: Sat, 30 Aug 2025 15:17:40 -0300 > Subject: [PATCH] Add new command to pulse current region or line > > * lisp/pulse.el > (pulse-momentary-highlight-line-or-region): New command. The log message should also mention the change in NEWS. > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -71,6 +71,12 @@ done from early-init.el, such as adding to 'package-directory-list'. > > * Changes in Emacs 31.1 > > +** New command 'pulse-momentary-highlight-line-or-region'. > +This new command combines the existing functions > +'pulse-momentary-highlight-region' and > +'pulse-momentary-highlight-one-line' to highlight the current region, > +when active, or current line, otherwise. This entry should be marked with "---", since we don't think it should be in the manuals. > --- a/lisp/pulse.el > +++ b/lisp/pulse.el > @@ -217,6 +217,17 @@ pulse-momentary-highlight-region > (overlay-put o 'pulse-delete t) > (pulse-momentary-highlight-overlay o face))) > > +;;;###autoload > +(defun pulse-momentary-highlight-line-or-region () > + "Pulse highlighting of region between BEG and END. The function's signature and the body were not modified to use arguments BEG and END mentioned in the doc string. So I think there must be some kind of misunderstanding with respct to this?
bug-gnu-emacs@HIDDEN:bug#62988; Package emacs.
Full text available.
Received: (at 62988) by debbugs.gnu.org; 30 Aug 2025 18:28:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Aug 30 14:28:44 2025
Received: from localhost ([127.0.0.1]:49756 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1usQJf-0000NV-Ol
for submit <at> debbugs.gnu.org; Sat, 30 Aug 2025 14:28:44 -0400
Received: from mail-bn8nam11olkn2091.outbound.protection.outlook.com
([40.92.20.91]:31843 helo=NAM11-BN8-obe.outbound.protection.outlook.com)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <gabriel376@HIDDEN>)
id 1usQJa-0000Mv-UB
for 62988 <at> debbugs.gnu.org; Sat, 30 Aug 2025 14:28:41 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=SQs+F1tmDG20XVv3kdwanbY121BLUzazrFY1D00rrjHuKtzQjGKkM4l80ZpkkcLXvty60kddL4lkRemiqQfLiHHTOqBPlHrGpSMrGBCdJln1szE3yn3xvvtPp2zZa0+xg0vaX7Mex41fU7/EH7C4n2jbZg74wWiO0460CjcEN1jh1Pcg4efe2KbWbkpU2uAZQBeWxio7h/v2dQFEZKst3Ojhj/9ASa08Vh1qsas63eecGni9QSZv4G3hPKCJqNjyqJ1Uk3Mo/ohBS1EpR5MPcO2aOpW2bVBkIAiKhuU+x0F8SzazkIRQjQt58JKN9VfTT49Nqd2PmRsCo3Cadpsq2A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=8jHpN1Cb33voQsQR1rp1YnKiw/HbdY2n//MzdqYxhK4=;
b=I4yMh/VCZe4xRzORZmPMA6hrg229TRYSGul3TBUkK0Bm9lR7GISL2cpu5zNZAyYRPFJPcuTLfkQV6HAfdBaYQYqdjEefZSVStWKtU6Amcukv32Kyydx6k1OLGGcPzh4hcVykMyvm9yNMfB8cRFq16pvmQ02fkrAUCZeOahqCmW4OtVyy57ZHUURykuHrM7NNeULASlMHPXOc3273gXjZkc+Nb95KhjD3TlfW6PC6I/DjGbN6FrJsmH7ls9FiVXCRhOj0baMJYAm2v+5PKMZax1mcCA9YxE+kwEuQqHaZNrsAacQGQvpNnT4gTxC4HANRE4oOTS3ElbGldiLrdzTOQQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=8jHpN1Cb33voQsQR1rp1YnKiw/HbdY2n//MzdqYxhK4=;
b=YDGs/VZIk9X5xWa6GE7jn1wh+u5dAt9j/waPD5TCxg1Zj+SMcJPa10XR7KUT9dU154vucZLXv7U9w9EedVNpIFK5VnGpax3zU+6D+PTxZ9RAg+6CtBkPoh4+5Kat1Ffpr+6/IOmCi9ATqvFFPIt/3G4G7le9AJvNoOcsffnaWoSfAA9uOQzzsFE5zwZeydjzT0y/+VHxwGyy/NEQyDiqWkQcpE/mMlSALIw9k8gg1laqwW4KpMS9OIItJm+tx3KaUhvLUt+QHznAU9B1hG6L/4bH2t8TuHZJZEaJ52ifoL2k6k0hUQNMhNtJX9WHTzxBxch/GJ2P9c2XRZGcZNbdPA==
Received: from SN6PR06MB3935.namprd06.prod.outlook.com (2603:10b6:805:21::11)
by CO1PR06MB8042.namprd06.prod.outlook.com (2603:10b6:303:e5::19)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.21; Sat, 30 Aug
2025 18:28:31 +0000
Received: from SN6PR06MB3935.namprd06.prod.outlook.com
([fe80::9f7:a06a:fd92:9751]) by SN6PR06MB3935.namprd06.prod.outlook.com
([fe80::9f7:a06a:fd92:9751%3]) with mapi id 15.20.9052.019; Sat, 30 Aug 2025
18:28:31 +0000
From: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#62988: 30.0.50; Add highlight line-or-region command to
pulse.el
Thread-Topic: bug#62988: 30.0.50; Add highlight line-or-region command to
pulse.el
Thread-Index: AQHZdBc3FasbZREI90WFxbdzMvVJvrANQqsThG7/zE2AAIpZDoAEAB1o
Date: Sat, 30 Aug 2025 18:28:31 +0000
Message-ID: <SN6PR06MB393500F68C5D73DE06AAA6B58B05A@HIDDEN>
References: <PH8PR19MB7070793A676262112DC66AEA8B609@HIDDEN>
<CADwFkmm3OY7VT5GJCSVv9a=FmJsYcSaGyKok4w7VpmMHZRY92g@HIDDEN>
<SN6PR06MB393507888D978BE18E11DF848B38A@HIDDEN>
<868qj4t4ek.fsf@HIDDEN>
In-Reply-To: <868qj4t4ek.fsf@HIDDEN>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SN6PR06MB3935:EE_|CO1PR06MB8042:EE_
x-ms-office365-filtering-correlation-id: 711fc80f-31de-4ec1-d281-08dde7f3058a
x-ms-exchange-slblob-mailprops: laRBL560oLT/z5vudnqSE/O7qQNjjjS4pqn1SX69pSdYdLloM1NvT8M6FVVVQJ8chcXOOcP7uyQtElXTtsCNVgcXN0aO9fB9auN1QRLplZt7hmRltXCpmoJfoVUq9lI6I3hYvla1qXc9PcQwNRXXy2QowwGITA+Y3B+0Iu0Q51++TEPbRRyHk/YtoXjQyqQjwdZ4o1Q5za/nVMjae5epkAbz/YiyPVKbIXscx2nsTAxQNX7g5eaTsS6hjaOmwvuUP90jWlkK+xHPLG17jvKKS+w1UMWYOyzZzsEn6xIaReSsmGQNH0k0zK0f2i6HQNSUWSs5hzZ7mFyzqYgGD294mA1E1AMMnWeyHRo8AIb5VN5H0srzCSbBotuWdLRmKtzHD5iv8qs0Xo7nmv4iNx65vMY12VrgTLndEz7wE2Q1wKsSJ+d6KLuUhQw/nq5Wpx148Pw7LCGGhzKaCqcYHhPe5z31dTihAJbqsSZLd6wYH3oWH813sS+00D0BCbT2s5Tv/6HA55P5tpFg34kE4ppcnCb6Htn0MRvWOPoGrgR7fCkI+nwAdvbRukikIX5FIraO+CNFerSZLX8049wgQvgMN603K7xdS/y6GPqXpB0yiDcE6eF5uOdrR/gA9RPd1jXliJdHOFAPp8On2Yen/EPXZOvnICxah58sKR5raOj5DuD4V3qBgFkwy2ZHXZ2PwgS48OGSPyJlbm7e9TjhbTNH80olCFgy+7VOMK7yZ9nJmwVK51fTEfkXVd9jvE7dETdrNkwWpJj4ZjPxsfBYxF4HpYfvxT6bgVY/
x-microsoft-antispam: BCL:0;
ARA:14566002|8060799015|19110799012|8062599012|461199028|41001999006|31061999003|15030799006|15080799012|3412199025|440099028|40105399003|102099032;
x-microsoft-antispam-message-info: =?iso-8859-1?Q?amzIfG8G/Pnvh4WhjtIx64EtiIZ4oj4AEQypVkiDzW5oKluczaFrNyp8gt?=
=?iso-8859-1?Q?ALtkHkIXEqIiTHx4yDuYZa4R4iextnpOICS0AuhEYhi9K2VuPBjGmGDT+2?=
=?iso-8859-1?Q?BokgHiHisJXPpH25wNMD/jSgJBlNwzLjfX0cAa7rUPzFjzGNTAmO6xFS16?=
=?iso-8859-1?Q?qpym1xnLfMKHCH7Pedug6v+jOawh3O48i41FQYrchX2cCcQvYjH3b4h7Oi?=
=?iso-8859-1?Q?rUyaO+VsA9rOx+DZ2q8L8BIsW3QEDPhMqqv816qDn7eRPc5fatVVy/uos2?=
=?iso-8859-1?Q?oyuJH4aBUHNJSHyD91gCD9iYW6s1ou0gBQ6RDATyz7a/ws4/BuN6EHM9i9?=
=?iso-8859-1?Q?RprfLUpuXjYltT2HGRZzKYNTzyE3wYJnFMf3fSrr9arUKSDTtfWF/qARfA?=
=?iso-8859-1?Q?G+lSkN/paUfnSiqGUZKf7QypYfpl2YLti6Z2xlLIJXrc8Xy6yjX4OTPHRd?=
=?iso-8859-1?Q?bwaVLcRXzih7qAd0Fcb03Pmaj+78j32R+B0+e3SVAkY7eih4v5pMAdBSnV?=
=?iso-8859-1?Q?OJyySMemPNdkMrWjI/HeANR26wK6nBqyyCVXFwsYuMOLFQXBODBGIz3FyD?=
=?iso-8859-1?Q?rbThV+Pot1GDOPQo+BBBrKOn7tL394lVsrJ//I4+grGo0jElDDbZD0lj4O?=
=?iso-8859-1?Q?5Ku+nnw26TyAWGnNO1FBJhfz+bKQXbMLqDa7JEjzUYzpYlM59TO5ZBVi4M?=
=?iso-8859-1?Q?JXV5zh6nOMXttOqrHOFO561RwIfhI+W+h+2MHaaE28dCKN3j5xMoHImrbX?=
=?iso-8859-1?Q?pPSfYLBlthyByJpMoRQD0TYsBpy71NlCX7grDUUTSucqZIs1ZroLwxuq28?=
=?iso-8859-1?Q?OJda9eNwJxG68qKDGJTXbYoLre4JXEjANzts2WCBFLIQVG/Mmp+2jVimTj?=
=?iso-8859-1?Q?xbjhmQ8k3FgTQPRO7r9mlW5GCgMFZ4Y30Q1KDLzeEuyYzC1iw9vf1YhzTp?=
=?iso-8859-1?Q?kLqT3zuIzagx4BC5aCVOLFfgTY7o1KWzAqBFIutgy8YYMKkSXYGw3s16FC?=
=?iso-8859-1?Q?mPQbNzFz1whpuAymLPfbry4jnp33zwzUtoeOBfXcV1DCuAbvq7zrFBG1rt?=
=?iso-8859-1?Q?Fl73cO3qxEtVkUBQBSa1SKdSjJRgq/ZdvMF85iNSqKKjy0kv/v5+OgzAiF?=
=?iso-8859-1?Q?td0x4jX/h1GduYJ+57dCECwQB0+NYazJ7ITufQDtl7MrRa4v53RWwXhPTn?=
=?iso-8859-1?Q?q1gDLDAIoowFChimuxcf9gBTQwB2phd+8tNMhMoov79debQkL4Rt4gpIrt?=
=?iso-8859-1?Q?WYksub9wovRQ6zNseJJw=3D=3D?=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?stU4h/aFzIi7bEp7GAt/cRT4L/Aem1HnGjOVxLxH9X+qZMWkN24Y0YetyY?=
=?iso-8859-1?Q?VG1WUzIMDJ2DQeKhe4le571BIO2eJu9HTpAQOwM1mM9Z7Y+N7GOpv4tQnA?=
=?iso-8859-1?Q?Z07y2ZHoBdJx9guovBeEXdR+S/9hd9k5k9F4OI6mrrSyuuEetbef76WDez?=
=?iso-8859-1?Q?31krIu7md6WfGFYSfQOhtC3rUdjyGoDonpo0r0L26jXm/Q9Oyu7WYZu08/?=
=?iso-8859-1?Q?zXcZcgMCnXTnSVCG8wtr4tNDaDtX7rfpzFsMz14Mhb33nIKeiEq712Ij3d?=
=?iso-8859-1?Q?A8473l1C3huao/W0KiNRtKFMQFfYpVYxH5UHDVGXj3URDsEBspHwSgtFx2?=
=?iso-8859-1?Q?qEoLYYJ/qX+JEoQJjpsLDKLpZQrScSPjvlQI0LZmef0ICER4a0w6fVXZ4h?=
=?iso-8859-1?Q?2rhjn35fHseyHBT0F7t+97hHTqIn4pSKXLCZNYOdRDzOsQNc007agj+p8z?=
=?iso-8859-1?Q?9UlpREQj3b3HTJPdkcDQORn/SC4CsLDBnQtTQpq94+EojcV78p2IPBqfPS?=
=?iso-8859-1?Q?EVIO441QsYgY4QdAOxKyZsCIXfT8pSVPFANQNPDjey8teZ3KNykPxjyKV6?=
=?iso-8859-1?Q?I6sT3OyyLm0saZtyfF8BSYFUYLRtLBogfrAU9khl9nhFfcLbaBrNEDyGfU?=
=?iso-8859-1?Q?4+LIGoJBjpKEiv6XRejyF4pWe2liKEKS56XbeFzNRhyt6EeXXrw2vtbAtM?=
=?iso-8859-1?Q?xQ0ngfTf8QhP7+NCFPNjVTJvYpkifhXSBtom3oVnL9lPyFKlVX6/fGZPpr?=
=?iso-8859-1?Q?MwzYFJvGYNPv+ELYONWGlUJ8khlEt2umlPSgC+aBqOc+InCQOsB+lJAupX?=
=?iso-8859-1?Q?aUx+oP2mj0JxOgzBYfiWno6/r1IrCErY9F2iMwXcY3qpnevCLPbhhKuj7g?=
=?iso-8859-1?Q?hEeU67YZC/wUqhYwgn9vE5jE+rY0hNcVGY5zRx5Rr1oe436CW5bne7fqa6?=
=?iso-8859-1?Q?fgsJ67lOEl8A9Tm1d93/58AJxLQf3BhKxdyMvDww9SNMEgCSe9mgIROCmH?=
=?iso-8859-1?Q?zshIva3W0Zd3oOaNQoSkxqK8C0uGfFLaM8jaJ08PgLNXjogjFD5ngQQsVO?=
=?iso-8859-1?Q?UfyonCrK1gFaSvE27rk9nAu2yVEmCsn38QCpCWM1r0i6ux51N0X9KWuDLR?=
=?iso-8859-1?Q?wKJaVp+hUU/olIZh2KaTJ+IE02eXOHvj9+dj9BkgjP4VajvND5O6tgY9z3?=
=?iso-8859-1?Q?L20rWnXAVYlVzNjCbRqws86DOxA8kP2JHdP8WDXTcRxHaRptRl4kpZgt4n?=
=?iso-8859-1?Q?2ys9Vom6LpTkoINcMiMvHCuy0V5awjbWPpyjYSUzY=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-a1430.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR06MB3935.namprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 711fc80f-31de-4ec1-d281-08dde7f3058a
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2025 18:28:31.2416 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR06MB8042
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: 62988
Cc: "stefankangas@HIDDEN" <stefankangas@HIDDEN>,
"62988 <at> debbugs.gnu.org" <62988 <at> debbugs.gnu.org>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)
Hi Eli,=0A=
=0A=
Thank you the suggestions. Please find below an updated patch.=0A=
=0A=
=0A=
> Finally, there's a question what to do in non-interactive invocations:=0A=
> should BEG and END be obeyed regardless of whether the region is=0A=
> active or not. WDYT?=0A=
=0A=
I think this function should behave exactly the same in interactive and=0A=
non-interactive invocations. This way, users can use it in hooks, for exam=
ple:=0A=
=0A=
(add-hook 'window-state-change-hook=0A=
#'pulse-momentary-highlight-line-or-region)=0A=
=0A=
I don't know how to make '(interactive "r")' work with non-interactive=0A=
invocations (maybe using &optional?), that's why I opted for a plain=0A=
'(interactive)'. Suggestions?=0A=
=0A=
=0A=
From 679f29c24e96b881ce4e2804c8257247c6f16e14 Mon Sep 17 00:00:00 2001=0A=
From: Gabriel Ribeiro <gabriel376@HIDDEN>=0A=
Date: Sat, 30 Aug 2025 15:17:40 -0300=0A=
Subject: [PATCH] Add new command to pulse current region or line=0A=
=0A=
* lisp/pulse.el=0A=
(pulse-momentary-highlight-line-or-region): New command.=0A=
---=0A=
etc/NEWS | 6 ++++++=0A=
lisp/pulse.el | 11 +++++++++++=0A=
2 files changed, 17 insertions(+)=0A=
=0A=
diff --git a/etc/NEWS b/etc/NEWS=0A=
index af6dd0c2151..0e0a28f11ec 100644=0A=
--- a/etc/NEWS=0A=
+++ b/etc/NEWS=0A=
@@ -71,6 +71,12 @@ done from early-init.el, such as adding to 'package-dire=
ctory-list'.=0A=
=0C=0A=
* Changes in Emacs 31.1=0A=
=0A=
+** New command 'pulse-momentary-highlight-line-or-region'.=0A=
+This new command combines the existing functions=0A=
+'pulse-momentary-highlight-region' and=0A=
+'pulse-momentary-highlight-one-line' to highlight the current region,=0A=
+when active, or current line, otherwise.=0A=
+=0A=
** 'prettify-symbols-mode' attempts to ignore undisplayable characters.=0A=
Previously, such characters would be rendered as, e.g., white boxes.=0A=
=0A=
diff --git a/lisp/pulse.el b/lisp/pulse.el=0A=
index 3f0fbbab3bb..51ce9782732 100644=0A=
--- a/lisp/pulse.el=0A=
+++ b/lisp/pulse.el=0A=
@@ -217,6 +217,17 @@ pulse-momentary-highlight-region=0A=
(overlay-put o 'pulse-delete t)=0A=
(pulse-momentary-highlight-overlay o face)))=0A=
=0A=
+;;;###autoload=0A=
+(defun pulse-momentary-highlight-line-or-region ()=0A=
+ "Pulse highlighting of region between BEG and END.=0A=
+=0A=
+ Interactively, BEG and END are the mark and point if the region is=0A=
+ active, and the beginning and end of the current line otherwise."=0A=
+ (interactive)=0A=
+ (if (use-region-p)=0A=
+ (pulse-momentary-highlight-region (region-beginning) (region-end))=
=0A=
+ (pulse-momentary-highlight-one-line)))=0A=
+=0A=
;;; Random integration with other tools=0A=
=0A=
(defvar pulse-command-advice-flag nil)=0A=
-- =0A=
2.34.1=0A=
=0A=
=0A=
---=0A=
Gabriel=0A=
=0A=
bug-gnu-emacs@HIDDEN:bug#62988; Package emacs.
Full text available.Received: (at 62988) by debbugs.gnu.org; 28 Aug 2025 05:13:36 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Aug 28 01:13:36 2025 Received: from localhost ([127.0.0.1]:37916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1urUx5-0006dp-18 for submit <at> debbugs.gnu.org; Thu, 28 Aug 2025 01:13:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38104) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1urUx3-0006cp-2Q for 62988 <at> debbugs.gnu.org; Thu, 28 Aug 2025 01:13:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1urUwx-0003VL-9L; Thu, 28 Aug 2025 01:13:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KwXpY8lTuPk5QT9N6Cxw98A3HOppP/ekDTfgluaIxjY=; b=WwR3tbiffUGy rpvnYWI9O4kBmFKhc8TxkTfjjcQ92/Qgl9D2/TTiNZkRtKML0iCMp+iFPbEyvbgYLj/H+fu2EqWL2 Hgfa6Dwom1UCVhT591XWxq+aScGnxTXyW1HEAfT0Ntn/xXN+AWSBlbmDavhoOwmAT0IHHRkRN++h1 mZ2WH2pGRda9crnb+JQfgNKI1gONFat4oG7AC4kmojmZ+TrdFVDIZXncixHXiL/km7naqGvESXhQj UjbT6Obt2tw0z29wbpxWvi8SuC8AGyo9rE1afZajntjx6wexLC11lpBUZ2hlgs1XZNAWxF4ux8LZg hmN5TVqPCYo5le+ioVEprA==; Date: Thu, 28 Aug 2025 08:13:23 +0300 Message-Id: <868qj4t4ek.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN> In-Reply-To: <SN6PR06MB393507888D978BE18E11DF848B38A@HIDDEN> (message from Gabriel do Nascimento Ribeiro on Wed, 27 Aug 2025 21:00:09 +0000) Subject: Re: bug#62988: 30.0.50; Add highlight line-or-region command to pulse.el References: <PH8PR19MB7070793A676262112DC66AEA8B609@HIDDEN> <CADwFkmm3OY7VT5GJCSVv9a=FmJsYcSaGyKok4w7VpmMHZRY92g@HIDDEN> <SN6PR06MB393507888D978BE18E11DF848B38A@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62988 Cc: stefankangas@HIDDEN, 62988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: "62988 <at> debbugs.gnu.org" <62988 <at> debbugs.gnu.org> > From: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN> > Date: Wed, 27 Aug 2025 21:00:09 +0000 > > > Your patch and the feature makes sense to me, and I guess some users > > might want it. I think it should be called out in NEWS, and then it can > > go in. > > Please find below the patch with etc/NEWS updated, as suggested. Thanks. > +** New command 'pulse-momentary-highlight-line-or-region' Heading lines in NEWS should end in a period. > +This new command combines the existing functions 'pulse-momentary-highlight-region' This line is too long; please reformat the entry in accordance with the value of fill-column set by emacs-news-mode (72 AFAICT). > +;;;###autoload > +(defun pulse-momentary-highlight-line-or-region () > + "Highlight current region, when active, or current line, otherwise." > + (interactive) > + (if (use-region-p) > + (pulse-momentary-highlight-region (region-beginning) (region-end)) > + (pulse-momentary-highlight-one-line))) Commands that use the region are better defined using (interactive "r") and then should have BEG and END in their arguments, to allow an easier invocation from Lisp. Also, we usually phrase such doc strings with this style: Pulse highlighting of region between BEG and END. Interactively, BEG and END are the mark and point if the region is active, and the beginning and end of the current line otherwise. Finally, there's a question what to do in non-interactive invocations: should BEG and END be obeyed regardless of whether the region is active or not. WDYT?
bug-gnu-emacs@HIDDEN:bug#62988; Package emacs.
Full text available.
Received: (at 62988) by debbugs.gnu.org; 27 Aug 2025 21:00:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Aug 27 17:00:28 2025
Received: from localhost ([127.0.0.1]:36766 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1urNFp-0002kI-Jp
for submit <at> debbugs.gnu.org; Wed, 27 Aug 2025 17:00:28 -0400
Received: from mail-mw2nam10olkn20805.outbound.protection.outlook.com
([2a01:111:f403:2c12::805]:41856
helo=NAM10-MW2-obe.outbound.protection.outlook.com)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <gabriel376@HIDDEN>)
id 1urNFi-0002fM-4P
for 62988 <at> debbugs.gnu.org; Wed, 27 Aug 2025 17:00:20 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=An2R88Vgj2Lnn4D8TrCnH/JEAfygLd+mdOEI4cCbIEKJpiA7df2rhyuKSVvZDQR9jpVjwPFqzTR7w2j9BRszIUbuP7NawQOGpwwU7g5dB9LbQsFbRjy/UYmb0hsFQfTI5PNVDXAnnOyyKhhs++X9hHGS/ob6/XvS+dkMi+rvJl1TcwawByGdQZYr8x5FosUB05dWaUJtJWFG8y1yFCc28oRdxUgmeieCyC490CMgwG5nVnyYnaRkQ0ugOIjwBUa+Uv2a5s1J2Oy9dygs9JdokekI7/sfFcxCxe6jpkHkba4NY4da76x525gL47DEpek95uSm5F3u2JblWVQUa6F5Tw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=ddwa70JNC3C9S7WcG5uUQ8Vk410jDRFsQXWoegi51AA=;
b=ZMy7bNWwrYuGngh2SF+W1wcLGGUTDSRp/cJDf9lZgxWNBtFN8Qi5p/xPqwVj9/X8ZOEY+4N4Z6tred5D1u4Uzw6aBiKLK6BegCXBD3m3Ynn1+Zv+C/21tPuqau7vCA7GU4Wrx1uqxn6ty1/tf8GvxoialV2ieCdTei3hSvVJQ+HuIJ3oownz0vQ2UEvk2cWM7UlcMVcLvK7HvaaspaLddu2d2ub5RhODvmQZOadfUzMQYhSRgPEthTFu2SZ+wv5jSQRBKrkV1ympz7Rim7n6dKrS1mWZ2YfsfD4ydXkovVy2yZB5ecfEQqmndRsvAX03zcqKr7dqWm9OM1TCEt22Og==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=ddwa70JNC3C9S7WcG5uUQ8Vk410jDRFsQXWoegi51AA=;
b=LluZBHhJVZOigWyLzKHY9TA7oVqkJwKuICMP5u3N24BWgjt25cz940usMuaTkskxnWItES/o316gir2oOmzTeYRRc+fTg6ODolVuiOFfm56Kkgtkl0UE9Hv25aB2L0oiRm3DvCHOfw9CkO1yJdHL0wJp0Gg61uMY3ybrFfR3LgDh7NDKTr6DyFxnd/nUqWfeAp27aFlHjPmbXYm35pm0CZZ2iBE9cOexfRSz+Unx9eLMbwDILpw2+WL6Il6w8FvkgT1E9c1emz0H2sk9qrVDZeyebShb1ngHhkZpEQsNXOLpqlc9/52JF5/ePNfneDqtI3ofj0xW7yGCPtjnFDfrug==
Received: from SN6PR06MB3935.namprd06.prod.outlook.com (2603:10b6:805:21::11)
by MW4PR06MB8969.namprd06.prod.outlook.com (2603:10b6:303:1bc::11)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.13; Wed, 27 Aug
2025 21:00:09 +0000
Received: from SN6PR06MB3935.namprd06.prod.outlook.com
([fe80::9f7:a06a:fd92:9751]) by SN6PR06MB3935.namprd06.prod.outlook.com
([fe80::9f7:a06a:fd92:9751%3]) with mapi id 15.20.9052.019; Wed, 27 Aug 2025
21:00:09 +0000
From: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>
Subject: Re: bug#62988: 30.0.50; Add highlight line-or-region command to
pulse.el
Thread-Topic: bug#62988: 30.0.50; Add highlight line-or-region command to
pulse.el
Thread-Index: AQHZdBc3FasbZREI90WFxbdzMvVJvrANQqsThG7/zE0=
Date: Wed, 27 Aug 2025 21:00:09 +0000
Message-ID: <SN6PR06MB393507888D978BE18E11DF848B38A@HIDDEN>
References: <PH8PR19MB7070793A676262112DC66AEA8B609@HIDDEN>
<CADwFkmm3OY7VT5GJCSVv9a=FmJsYcSaGyKok4w7VpmMHZRY92g@HIDDEN>
In-Reply-To: <CADwFkmm3OY7VT5GJCSVv9a=FmJsYcSaGyKok4w7VpmMHZRY92g@HIDDEN>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SN6PR06MB3935:EE_|MW4PR06MB8969:EE_
x-ms-office365-filtering-correlation-id: 728ec581-5c83-4faa-345d-08dde5acb526
x-ms-exchange-slblob-mailprops: qdrM8TqeFBtg1x3yx1r6QKZAk6LGeuzayK7+LarnmdzixEir7tGThAqI5UD/up7ui+cdkJn5X1OzSs/2CHJ15rBq3LwQNLvZ3qqYkyNwyuqv9KK77exfuVDh3P/ugKvi048eXMCg7V/6NvmzendtUCEAFoIADS0jNa4rI2Q26PdTHD6JV04H9FqhIARV3kEYbJXDE97kmp8saYqlH0u4KOyZeDeDPgY9qrNKijIX89ja+owIX5M00SU5V0+YMX1xiloGjj0CV4efsp1LNIdiNdlJpl8NMCyCYVYsqBJ1OOmWxqj/jCapFll7LFWzwJ5bl7osY8ShX3gG2JwUjCaSRp8rfSH7y9W8KLTXCZs2ycQl45AFWeDs8TibTOD+CAun6BKNb3ZF5lcN4pURXugoR3fLAF5pkuBWaTBwy84abSpbVYFJ0oFFG6Ne+oo4TARtpZR5iJBZ/yRS45tQ3cD86IRpKIQ1VpgynvljoO/obrDsFUtzXc7q9iwdQoRJ1hqY89GNLa6U0XAK8W76ch8pO5eLJlpCzb2nfrEl1bkZdbcD7FvrwS+vwMA1XrQniZZ3FgXEm1/hhdUgh+VsfyNoJKIBht1mRGtcCYWZha6z3puTINvSZqFDYT+NS+p09ug8u98r20snR6Qv4W0vfLhcHkDdNX6Bhh62KC7gm2hr3d4aHfM9rotOCQ4DPtPmFlIZKnimyVFSVetStqsusmP53iEvVI5hQCNMSq3WOjez1n686sgUocWQrKX9V9hX9Q2Cl9IGWaiJumm8DxOJCleNiua4AZlvGjgY
x-microsoft-antispam: BCL:0;
ARA:14566002|41001999006|15030799006|15080799012|8062599012|19110799012|8060799015|461199028|31061999003|7071999006|3412199025|40105399003|39105399003|51005399003|440099028|102099032;
x-microsoft-antispam-message-info: =?us-ascii?Q?BmWK0e7/yahOTbXYkUvsxmI1F3s5GGlrUjDudZzW2k6whBr/TyMtTovFSMJt?=
=?us-ascii?Q?bac1wmJbXBQsO56rv2i74EKDyQrw+BeBqhbYn7C6ozeT7YwxHxzkMZKZh08g?=
=?us-ascii?Q?6hTq6QVp4xbyzLu1hMIlvx8ntDuwIebdDw9bAltlz4BNt6/+zhqMNF1kt+7P?=
=?us-ascii?Q?b51d12j7UZMBrrBfh6GDA9eHpr0masQL8dL8eAk8tYmN6sAQWtCsbGNi08af?=
=?us-ascii?Q?ptGwdiL/nmRAe8AyHvYFBqfnZdr1w1AKPsr4bGyVSHF1LLvuEIwt4inNFfps?=
=?us-ascii?Q?eM69aw4IVaueA76c4xFvUmXA+efJyTCW2WawIPeLBwYcyQnqwbsoXwtGCWLM?=
=?us-ascii?Q?0Rb3I+8EUJH0ablZh47l53HmBmDNgy2G9JOKAE/LT4VGZ3jnjTtHD36yRmfV?=
=?us-ascii?Q?RyIFxwWR/czhlZxALwifKZPe9VPwuKA4flesh23Hj2Wa7+PpjnMJaoT3gzBl?=
=?us-ascii?Q?lBKKFfdHFm1+i9uJp9lZG9CUvbF/cHQWERbhqWuqO1SACaAa0rbC5/1ixV3X?=
=?us-ascii?Q?mIoAVZ9zuDQJodilyAcb9WYj8amhCVfdyPzNTmCWq0+h0+2xhuS5gbXj68Kr?=
=?us-ascii?Q?NGMJzxoar//J5LAtJNDjfvKb29wkmBum1pVB0csvno7LzuQCLDvMsDaFaoUQ?=
=?us-ascii?Q?XsRwnmf1ZwjIAwFJsqJNXsHaGd6+BQlITWv8NbaatJCRj3t4awBPvz76YsKs?=
=?us-ascii?Q?rMpq5JEMZvvf/EIULFIj1bJtCN+7KAj3appjEAxDNa9ugCooC8SFuDKkXyYe?=
=?us-ascii?Q?+HireaVmpWtYBuLby9pHxCw0wtY1f0hcotrGZRv8cbBrBQ3By57IE9qXIYoQ?=
=?us-ascii?Q?RnasQupAGgkPI/fNaC22HLpaJGS1EyQTniUO+kOaXZzBgty+kYpaSfxFY5Jb?=
=?us-ascii?Q?cRhaVFrQ0yvUPM+4klZBVUSfC1nGNCI6BZ+o3ybrdEH1Rkblvm5OCY/FBIM/?=
=?us-ascii?Q?RTI66MVtci8cKpS4xDfXb9U4yJvruC5SQ8XdxZCQoHMkZysjG7AW32+Fr6mI?=
=?us-ascii?Q?UNsuS4WKX1wXgqEC9KdUXvk5gAFqYOx5HdU4JsegpbtEu6rP8lD+LtKLW7qQ?=
=?us-ascii?Q?vzcnTxtHQ8AHZcxNIauI207e5OCZPJp36ftBOcqmGXjk5wyvqGIw0+sGS0QB?=
=?us-ascii?Q?0/l8SrLIQ86nc7SspMTlqNCEJb3o1IuUS7lHz5903EOgYlUO3etojeJF/nWR?=
=?us-ascii?Q?euO7U7NQ+Wro1efkXtjPfuvEBXiSjArIjKjOaljFvqygO4g++PYmdaILGcGq?=
=?us-ascii?Q?bhRypACgvA9nWHLGj+OsPF9buivAAOX39W+OsgRbaa/FA4zidL57M20Q4YzC?=
=?us-ascii?Q?i8M=3D?=
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XuocUv4X/Ae2mG8TvGe3GkeWNWgXfOUdHF8pd/1hpEzvMyjbcouEjnsDCOAc?=
=?us-ascii?Q?XESmtWNR6ETwpWivdKrKpw/eQEpg4TGmY5jfndensLZgRgURTs1nRXbAVWdT?=
=?us-ascii?Q?6pFjPTNNBuOnVRoFlzH8ds2dioVkwn70mxIHued/UP98JgRKr1iMBkV8dOVX?=
=?us-ascii?Q?BVx5HQP0YCGitdLr0tEbttPt9k8M07ycrzToS2M4/yxRgvSKLfG85rGL5gFK?=
=?us-ascii?Q?U4JwDwUmPQDRbzAf47KXBEu1frngOTrGyyQtEt9nPxRZrQ1F36pqZUninTmt?=
=?us-ascii?Q?s0mC3vOg4pfFE9UdodaPkOOSnrMMC6rwvQv8vSYTRLcg7rJZBuLidPL2Oxjq?=
=?us-ascii?Q?x5v7NEXgVrgI7U+HbHo7SqyzTl3sUlFEkklLq7kiNoO6aQ6z3AzGDaefmhHD?=
=?us-ascii?Q?fHdEARffHDi1bG6vobnSrrnQS5CNNF56FR0ExuIyjBrQgBtRlX9kSCoGoZcj?=
=?us-ascii?Q?mmp/jzeVSuTE5XFsNvXZW6oawAVF/S+lIQLMOz1Mt+T7bBvNO/0QIyQyVVyA?=
=?us-ascii?Q?5NINvYBxFXGU4saIB57t6oRJ32bLrXVlhvcDNWi5NhAKqdBxRT2G4Ji3wobw?=
=?us-ascii?Q?arF4xhRKes5nFco4tR969yiofTXTmvn+Y5EtD6WUlxFbylEueB90nSIQaloG?=
=?us-ascii?Q?CJ8RAhUZ1odUG0m4UklrykgA2xTueNlupvWRmwcZdcBNidSX2hieqULzrkzC?=
=?us-ascii?Q?Dei6SbdxtINra75kY84Ux7LvvE2ZR3jIegguwC9lWHNH2TKpXDmh20pgmIMm?=
=?us-ascii?Q?YNbv9bEIznVMiVZ/EsS2/2uoWq4w60Ldq7ZBs6XXdAMlOE3csWIxMpCq9zVT?=
=?us-ascii?Q?KA2p/QnR9/zyDfDJFLuLoAY1/s+GD1Q6gQEHUKUXABcg6AFaVdGz5aGaIgaC?=
=?us-ascii?Q?Kvoc+hvKxaliN1ZpAWZ1+tQpUGtDxfKBktYT78kDMBhfwocU1D/E5WOaQQro?=
=?us-ascii?Q?Rsk0TgGYZ+wc1Aj9uC14SCiR/IbhiDC2Y2MacY+MCPBwGmQeINNwp/7vY24Z?=
=?us-ascii?Q?t9LQJIxHivU1IK46oFiV1s6X/PXraiIm7cz+eNbU7XAiNEmS7wg+HGAALzQ/?=
=?us-ascii?Q?PTioM15Nvv68vqBd4aT9zziKYtk5/c3z6vYh3rd+yQrzj4sFZ35FU9SQFrru?=
=?us-ascii?Q?LYBwtyzYbudgfmE+oNwmVtVXxQ0Fbx8C5cd/ZH4Vgwa8g/+HeeYgO3qTDD2b?=
=?us-ascii?Q?ed05+1EMLQ1hiFg263BvXvQXX8CtHybix4Ll8plkcBhdt0wWnAJB2dIbcwhx?=
=?us-ascii?Q?Hin4O8UVzb3fKS0Lc7NZ3NjzgAW1oCnqPsvdyAQo3q7QMX8nAdg6zvzrN8i6?=
=?us-ascii?Q?Lz8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-a1430.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR06MB3935.namprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 728ec581-5c83-4faa-345d-08dde5acb526
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2025 21:00:09.2580 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR06MB8969
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 62988
Cc: "62988 <at> debbugs.gnu.org" <62988 <at> debbugs.gnu.org>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)
> Your patch and the feature makes sense to me, and I guess some users
> might want it. I think it should be called out in NEWS, and then it can
> go in.
Please find below the patch with etc/NEWS updated, as suggested.
From 109ab44bf0cdb7f76f08b894da960a6107db4fb5 Mon Sep 17 00:00:00 2001
From: Gabriel Ribeiro <gabriel376@HIDDEN>
Date: Wed, 27 Aug 2025 17:55:30 -0300
Subject: [PATCH] Add new command to pulse current region or line
* lisp/pulse.el
(pulse-momentary-highlight-line-or-region): New command.
---
etc/NEWS | 5 +++++
lisp/pulse.el | 8 ++++++++
2 files changed, 13 insertions(+)
diff --git a/etc/NEWS b/etc/NEWS
index bd2ce33b851..d97032048b1 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -71,6 +71,11 @@ done from early-init.el, such as adding to 'package-dire=
ctory-list'.
* Changes in Emacs 31.1
+** New command 'pulse-momentary-highlight-line-or-region'
+This new command combines the existing functions 'pulse-momentary-highligh=
t-region'
+and 'pulse-momentary-highlight-one-line' to highlight the current region,
+when active, or current line, otherwise.
+
** 'prettify-symbols-mode' attempts to ignore undisplayable characters.
Previously, such characters would be rendered as, e.g., white boxes.
diff --git a/lisp/pulse.el b/lisp/pulse.el
index 3f0fbbab3bb..3448120a2d4 100644
--- a/lisp/pulse.el
+++ b/lisp/pulse.el
@@ -217,6 +217,14 @@ pulse-momentary-highlight-region
(overlay-put o 'pulse-delete t)
(pulse-momentary-highlight-overlay o face)))
+;;;###autoload
+(defun pulse-momentary-highlight-line-or-region ()
+ "Highlight current region, when active, or current line, otherwise."
+ (interactive)
+ (if (use-region-p)
+ (pulse-momentary-highlight-region (region-beginning) (region-end))
+ (pulse-momentary-highlight-one-line)))
+
;;; Random integration with other tools
(defvar pulse-command-advice-flag nil)
--
2.34.1
---
Gabriel
________________________________________
From: Stefan Kangas <stefankangas@HIDDEN>
Sent: Tuesday, September 5, 2023 1:24 PM
To: Gabriel
Cc: 62988 <at> debbugs.gnu.org
Subject: Re: bug#62988: 30.0.50; Add highlight line-or-region command to pu=
lse.el
Gabriel <gabriel376@HIDDEN> writes:
> My suggestion is to add a new command (i.e. an interactive function) to
> pulse.el to highlight the current line or region. The basic functions
> already exist, but no command is provided. This command is useful, for
> example, in videos, demos or pair-programming sessions where the user
> wish to highlight the current line or region for the audience.
>
> Although pulse.el is part of CEDET, it provides general-purpose
> functions not coupled to CEDET.
Indeed. I guess this is only in the lisp/cedet for hysterical raisins.
> Example: apply patch and bind the new command to F1 key
>
> (keymap-set global-map
> "<f1>"
> #'pulse-momentary-highlight-line-or-region)
Your patch and the feature makes sense to me, and I guess some users
might want it. I think it should be called out in NEWS, and then it can
go in.
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>
>>From 30681b98fed3e90a653a741a644c94ee4f89a719 Mon Sep 17 00:00:00 2001
> From: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN>
> Date: Fri, 21 Apr 2023 02:51:47 -0300
> Subject: [PATCH 1/1] Add command to highlight line or region to pulse.el
>
> * lisp/cedet/pulse.el
> (pulse-momentary-highlight-line-or-region): New command.
> ---
> lisp/cedet/pulse.el | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el
> index 37b41fbe8c3..c76668152f7 100644
> --- a/lisp/cedet/pulse.el
> +++ b/lisp/cedet/pulse.el
> @@ -215,6 +215,14 @@ pulse-momentary-highlight-region
> (overlay-put o 'pulse-delete t)
> (pulse-momentary-highlight-overlay o face)))
>
> +;;;###autoload
> +(defun pulse-momentary-highlight-line-or-region ()
> + "Highlight current region, when active, or current line, otherwise."
> + (interactive)
> + (if (use-region-p)
> + (pulse-momentary-highlight-region (region-beginning) (region-end))
> + (pulse-momentary-highlight-one-line)))
> +
> ;;; Random integration with other tools
>
> (defvar pulse-command-advice-flag nil)
bug-gnu-emacs@HIDDEN:bug#62988; Package emacs.
Full text available.Received: (at 62988) by debbugs.gnu.org; 5 Sep 2023 16:24:30 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Sep 05 12:24:29 2023 Received: from localhost ([127.0.0.1]:58215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qdYqr-0005Qp-GQ for submit <at> debbugs.gnu.org; Tue, 05 Sep 2023 12:24:29 -0400 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:48194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1qdYqo-0005QZ-45 for 62988 <at> debbugs.gnu.org; Tue, 05 Sep 2023 12:24:28 -0400 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-500b0f06136so4763756e87.0 for <62988 <at> debbugs.gnu.org>; Tue, 05 Sep 2023 09:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693931059; x=1694535859; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=vWh247LIMAu8v/VduAGScBEwVeAkF9t88twc4o4Kk40=; b=fiGrO3S23pG5PUpzyB3/cwR25Y29iZbY0DSyjvzgRrmVUM8y1sGVA6SBdGp9MGYKs8 OS4YXNX1mlqM1G7TCN7hZqE70RNk1gbIbysOtJL2JI4l1YNP8JFH0HhX/V2sTWt2rkgc av9ARlfIgydRH4XypxN09uSSmWBdm9BUxkliitSk5/YQK2zhLP1q3A+WNX7WX37/Li7F epQqtHlsudJi1Ul79XtmQxo1cxAc3Q4wSp6rgGRWUaZPRwJv5dK3Tv4RK9XNovsXuEmg NaNZj57Zr814jk16Z5flyNXoDrCdER1ZytdaO3y8HvFICFqODh3ADyPqzwQreEcggCgq x50g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693931059; x=1694535859; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vWh247LIMAu8v/VduAGScBEwVeAkF9t88twc4o4Kk40=; b=W0+Vcw6Jl2J9JlDSEvZzkD+6AcyvYtOhNEiTv0jTTawJ1JBr/hFQYvXIWcx/ltVm47 B12Yd1pwMjylda786EM47ucGVzoHkcg3len60cbYOch0wen5dW7RfQbiQQeOTODOIgHk iLVWO9ILw64ZDFdnJgnwzT0blDr0ufSSK9PDJBQJ9iENHAYy+kucms+zxve/kqjjc81A anE0G5kXJy/RUJqEOgXQPgKj6rHQvvyjPWgzlNldOK/EoC/xM421QBxfHpguEIWMfk/a tH8os1mMYoemCJiVKoqJ6R816x0AeWZdQSafW+Yt/kfkrdOM6HSguUZsqFeDBt1iLbhy /2fw== X-Gm-Message-State: AOJu0Yy3/Cdyy3gzXzxQ8SaMqCgyMd19JHzOj15uJ08Tg1SWbUNv/vIi knPt6BfeddeR8khpQCRisGVveG9keY5MWTHp30c= X-Google-Smtp-Source: AGHT+IGt3Or8jWfG3bOzMnCg40OZV2jIJBNt8svWtaAw4LFgicKqgotsXHFgoLfOqznxZXofEgk/iZNtFL6NZrp7CBc= X-Received: by 2002:a05:6512:3454:b0:500:75f1:c22e with SMTP id j20-20020a056512345400b0050075f1c22emr228657lfr.40.1693931058878; Tue, 05 Sep 2023 09:24:18 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 Sep 2023 09:24:18 -0700 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <PH8PR19MB7070793A676262112DC66AEA8B609@HIDDEN> (Gabriel's message of "Fri, 21 Apr 2023 03:04:49 -0300") References: <PH8PR19MB7070793A676262112DC66AEA8B609@HIDDEN> MIME-Version: 1.0 Date: Tue, 5 Sep 2023 09:24:18 -0700 Message-ID: <CADwFkmm3OY7VT5GJCSVv9a=FmJsYcSaGyKok4w7VpmMHZRY92g@HIDDEN> Subject: Re: bug#62988: 30.0.50; Add highlight line-or-region command to pulse.el To: Gabriel <gabriel376@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62988 Cc: 62988 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gabriel <gabriel376@HIDDEN> writes: > My suggestion is to add a new command (i.e. an interactive function) to > pulse.el to highlight the current line or region. The basic functions > already exist, but no command is provided. This command is useful, for > example, in videos, demos or pair-programming sessions where the user > wish to highlight the current line or region for the audience. > > Although pulse.el is part of CEDET, it provides general-purpose > functions not coupled to CEDET. Indeed. I guess this is only in the lisp/cedet for hysterical raisins. > Example: apply patch and bind the new command to F1 key > > (keymap-set global-map > "<f1>" > #'pulse-momentary-highlight-line-or-region) Your patch and the feature makes sense to me, and I guess some users might want it. I think it should be called out in NEWS, and then it can go in. > ============================================================ > >>From 30681b98fed3e90a653a741a644c94ee4f89a719 Mon Sep 17 00:00:00 2001 > From: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN> > Date: Fri, 21 Apr 2023 02:51:47 -0300 > Subject: [PATCH 1/1] Add command to highlight line or region to pulse.el > > * lisp/cedet/pulse.el > (pulse-momentary-highlight-line-or-region): New command. > --- > lisp/cedet/pulse.el | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el > index 37b41fbe8c3..c76668152f7 100644 > --- a/lisp/cedet/pulse.el > +++ b/lisp/cedet/pulse.el > @@ -215,6 +215,14 @@ pulse-momentary-highlight-region > (overlay-put o 'pulse-delete t) > (pulse-momentary-highlight-overlay o face))) > > +;;;###autoload > +(defun pulse-momentary-highlight-line-or-region () > + "Highlight current region, when active, or current line, otherwise." > + (interactive) > + (if (use-region-p) > + (pulse-momentary-highlight-region (region-beginning) (region-end)) > + (pulse-momentary-highlight-one-line))) > + > ;;; Random integration with other tools > > (defvar pulse-command-advice-flag nil)
bug-gnu-emacs@HIDDEN:bug#62988; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 21 Apr 2023 06:10:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 21 02:10:18 2023
Received: from localhost ([127.0.0.1]:39126 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ppjyM-0005Bi-JP
for submit <at> debbugs.gnu.org; Fri, 21 Apr 2023 02:10:18 -0400
Received: from lists.gnu.org ([209.51.188.17]:55812)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gabriel376@HIDDEN>) id 1ppjyL-0005Ba-45
for submit <at> debbugs.gnu.org; Fri, 21 Apr 2023 02:10:17 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <gabriel376@HIDDEN>)
id 1ppjyI-0001pe-2U
for bug-gnu-emacs@HIDDEN; Fri, 21 Apr 2023 02:10:15 -0400
Received: from mail-mw2nam12olkn2080f.outbound.protection.outlook.com
([2a01:111:f400:fe5a::80f]
helo=NAM12-MW2-obe.outbound.protection.outlook.com)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <gabriel376@HIDDEN>)
id 1ppjyE-0001Eh-VZ
for bug-gnu-emacs@HIDDEN; Fri, 21 Apr 2023 02:10:12 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=IClxAX9GxL1oH9nVQwK0tuI60xbNhl2dQ2Wneb0Y6sgyyUo9zlmhLMdS673BsVx0F3Fj2h98gMKCOgAOEltSfhzBnAlFpvKwBI7difXLIxaWMkNQZuen4Z6phJ8Ts8iL2Qw7rpRd16uRRx+l0xCWh280QKionpu3WJ22kskesMXe/LounB8cX3rw6Xe2asIHEz1iRbpSZw+HK9WtT7Y62sQg7wtOdl5+fCPVzREeE7qu1HZt8PsXq6LtyNWM5vpNwC8vWwoidpnZY3hyrltgjo6aGS2ICoOy8sCLR12HFDGehJrsnm5h+uqyZ4DGrl9Oe/WgFeACYx5zdLwFzZDH+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=YS2kVZ22f58EYWu7a/9q0YIIB2LtgtcVV1C+2qq62cI=;
b=KsHJtF4o7PRb44+ARojUvax8UCwqZ77nyPG2rIci3OyyiYxYGbbB7uvDGAilyC7kHajzuk/4HmN7feTQy0PMvNBxK1uEudIDnXbHOyv9WdqzA4YjTqbtcc7LrzZ6gUXOs2UUhsaLk8Ix0Bq+ipmEaqvdw0ZgxXgEE9CLliYNjwlOYkM3XcoiS+LQy2oxrQWxUAbskc+rN3lWbXY+M6ENy4WhhYM9iZP6wOrOgbvUwYqoGzlwGBiGA2fJoRYsD85y3E3AheB+s0mk27RxIoXBTAzNrF+HANwlKWXL0DcyKFOjqmGF9a/tvoHyrZnQB1A1Xx3tCOquggrH2+sgImL6Gw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=YS2kVZ22f58EYWu7a/9q0YIIB2LtgtcVV1C+2qq62cI=;
b=LKEplYbo8HcRqsdYs73ppsv7Ot8ni466phTRMrUpVfCsMZXIERdvc2n7FhU8g/TJS5Nkl1+bSZd4kqfrJJYOT0UjzsWaJ5egyWAuGirYaZpn2csZL8DgRtyzb+zx7dK7rdKuqRF7SE14136vLzIDQhNojBO+teWfTUHGQkR2ggR4RN2E6vD+LZ5Qt+wOZw5U+JPc8ya91xwLNGIBRGmamYxWQMSWmWMtLLJBTPp3U5n6tjg4hodoeRgVLw2FDMDAIqlpAkCznI5bhv26SFSKpJSIqWC8/zHglZwkIMV1O6O0Aqvx4REcdQrRBdPGoemnc4oLcHmEMXCg7KHhDDMmrQ==
Received: from PH8PR19MB7070.namprd19.prod.outlook.com (2603:10b6:510:222::9)
by DM6PR19MB3865.namprd19.prod.outlook.com (2603:10b6:5:1::20) with
Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.6319.22; Fri, 21 Apr 2023 06:05:05 +0000
Received: from PH8PR19MB7070.namprd19.prod.outlook.com
([fe80::eb52:9bfc:f218:8635]) by PH8PR19MB7070.namprd19.prod.outlook.com
([fe80::eb52:9bfc:f218:8635%6]) with mapi id 15.20.6298.045; Fri, 21 Apr 2023
06:05:04 +0000
From: Gabriel <gabriel376@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 30.0.50; Add highlight line-or-region command to pulse.el
Date: Fri, 21 Apr 2023 03:04:49 -0300
Message-ID: <PH8PR19MB7070793A676262112DC66AEA8B609@HIDDEN>
Content-Type: multipart/mixed; boundary="=-=-="
X-TMN: [YFyWkRu/nc2SsJLICApVMZYVUydfuO4jeR3wQrK1+BsVPdtpujLlNMee+qccUaXN]
X-ClientProxiedBy: CP0PR80CA0020.lamprd80.prod.outlook.com
(2603:10d6:103:14::32) To PH8PR19MB7070.namprd19.prod.outlook.com
(2603:10b6:510:222::9)
X-Microsoft-Original-Message-ID: <87wn25srcu.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: PH8PR19MB7070:EE_|DM6PR19MB3865:EE_
X-MS-Office365-Filtering-Correlation-Id: 4c3a4a90-3dd1-4033-b346-08db422e59b5
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: /0lJsQJlFmuNtC7SjM5P+5LQb8xywhhdNfpoV+pRbFr8k9bdJ1spqmdrEsgP6mRjPYJcKAFa3+wMItGiffys+dD6aemebjIzvOCdHbyNGTzl5gbXca1DSk/Ij5reyjxZbV2vUlpBYXA2wHY4BfYtvNdRpEBNGhYntUgR4UOi2nmxplh90ii1NmKkn6dfsNsxl04WsoeDEKphiscqxkP/OxfznJWelgYIaPv6tmrsW1bA7/5KqHpVUu/PwfbKePxe01wvgngiCXgHEDTH1VLPqwj44a+1Og7jQYlfolP1O7vKqaHlB5wtm8pVVcWRbR0AaUni17pXHlzdxs0GKnEuA5o+Xp2LLiRxyHibZLfAiD8ozyM+wfA/rs01kignFmNOXtnxXNSQ61ukcq7bsg4tbHFYamSv1+Hd1eSYz4S3B+d9auvMF4t6/pmOp4dbKPio6J9bp64Djw0X9IZkUEnawAnxpNdgVfJQsGaE+PLsT2BUWsJtYip1J/dAKz8rbgk0EXhdZ5W9Mqn0jlTkTIeFjgU0DjuLYV59BoY690ixl3+pI8NJ7s7NyCw+V0P1Us+F
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LRIlOybPf+87Tr5q47I/HzdjrzEyRa4wXZvsNchlyXEaO+XUnW9nEFhIO5jh?=
=?us-ascii?Q?DlSkBxJmukV+WljEE5bECfbHL/V2ABkJQNT02xDbKsElUvJ7wXlgoCaNGReZ?=
=?us-ascii?Q?bfttErta7Kt99Zh6j9ynepHRg//9nTDJM9MnXg+633rLYHwQG2I7EwD1EOcs?=
=?us-ascii?Q?MfNwQuVfCl6l1C5oeHjmSSywzIz8QVjGUhDX0QSl8w7vNpNVWXiXBVwFgQAx?=
=?us-ascii?Q?IXcKiPAk5SV514667orEEHq/n8J7YXlPmOtS1QLVmxaECXWP3RqotJERL7FE?=
=?us-ascii?Q?88ZPg+rOliadd6yy7abqHkbBgFWHQgvODygGI+ylaWJXasdFhleOeou2yuK8?=
=?us-ascii?Q?8o6HsDlJgCZOEMiEmVe57K50RDT8XpJmYRGwfuaAQ9QGjkZCG5fz3OLHPvw5?=
=?us-ascii?Q?IwvzxQf27t7mXSEUv7mDG48WfkK/eF+CfNlTTUyBblpnBUGwSqhIJBax8RIM?=
=?us-ascii?Q?BAylFEvPLCCAIEMuHaVJvLHIm444813jPkwP9yt/dsTOkfAXHpWYQXfjaEYk?=
=?us-ascii?Q?VnGfRVhhIvfYVKlOoMgf88qnsLZBAP7A5W/M+O5rjGxK8ZfeE5oc6y6TEi3R?=
=?us-ascii?Q?+x1mP9iGZ0Xg2lxlsyG0czFLY/qN7MKDFNvrzNIEP2Fw5YheR9+58XHKVWEz?=
=?us-ascii?Q?C6PQDMKzpuRmQyflR7M+DpSoALT6Ubm8YFL5Wl5zgndHVqyb/vL41qlKseRY?=
=?us-ascii?Q?ZZZPoos7Z8fuGWkyegR1KA1E9OOJzdGU73kXOvnm/ksdR5Ar6a+D9xW4NIqc?=
=?us-ascii?Q?Ab1EEJLcB2vi2N6z80iHYPdvAWBl3usfXTa6RkiOGfrJoIjLPQXH9PU0L3UR?=
=?us-ascii?Q?r9fIfpaE1mop79LuDnW9pWp/zv5KO4/cQKO+6oZ1/VbmIVX5WLpAL1vQSpQL?=
=?us-ascii?Q?MtiacixFJlUtv4y2x3HvcZZhedDcSatZaU8FCwbh247L1iux62Q9owKDqMKN?=
=?us-ascii?Q?jOoDqbssvN8KXJuPtAWXtSutiXg6Cuu5XMhgPL5GMAH032JWdx6cSe+ePNIh?=
=?us-ascii?Q?Zy7+EtLjwAhIqLVnf3ozKrsrjOTYCgX/+vSzCs0pWKjRjQDdrZznUW5r1k9f?=
=?us-ascii?Q?9DZAMY1YeDapfm5t1r2a3kLgUhFnsovpV8orZb6r5h//Dr+ztWd49UA9ROe7?=
=?us-ascii?Q?syshH7zi4Xopmb9yacc46u8WABSVP4YPg1aTPlTDJV0bl+P/ziv7jDZRmjBW?=
=?us-ascii?Q?qG0BcBr/eiadNQ3DvoTznYKRWScG/4iVmNKrxrw4SnQOe3qs+zb4j/BJuban?=
=?us-ascii?Q?Tbb0a4tUObeGxo1Zz8NqUw/2552SQWm0kIRJU5X8oSDg9IlVBRBKTDD/WqsV?=
=?us-ascii?Q?BpY=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-e7757.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c3a4a90-3dd1-4033-b346-08db422e59b5
X-MS-Exchange-CrossTenant-AuthSource: PH8PR19MB7070.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2023 06:05:04.7971 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR19MB3865
Received-SPF: pass client-ip=2a01:111:f400:fe5a::80f;
envelope-from=gabriel376@HIDDEN;
helo=NAM12-MW2-obe.outbound.protection.outlook.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001,
SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)
--=-=-=
Content-Type: text/plain
severity: wishlist
My suggestion is to add a new command (i.e. an interactive function) to
pulse.el to highlight the current line or region. The basic functions
already exist, but no command is provided. This command is useful, for
example, in videos, demos or pair-programming sessions where the user
wish to highlight the current line or region for the audience.
Although pulse.el is part of CEDET, it provides general-purpose
functions not coupled to CEDET.
Example: apply patch and bind the new command to F1 key
(keymap-set global-map
"<f1>"
#'pulse-momentary-highlight-line-or-region)
============================================================
--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
filename=0001-Add-command-to-highlight-line-or-region-to-pulse.el.patch
From 30681b98fed3e90a653a741a644c94ee4f89a719 Mon Sep 17 00:00:00 2001
From: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN>
Date: Fri, 21 Apr 2023 02:51:47 -0300
Subject: [PATCH 1/1] Add command to highlight line or region to pulse.el
* lisp/cedet/pulse.el
(pulse-momentary-highlight-line-or-region): New command.
---
lisp/cedet/pulse.el | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el
index 37b41fbe8c3..c76668152f7 100644
--- a/lisp/cedet/pulse.el
+++ b/lisp/cedet/pulse.el
@@ -215,6 +215,14 @@ pulse-momentary-highlight-region
(overlay-put o 'pulse-delete t)
(pulse-momentary-highlight-overlay o face)))
+;;;###autoload
+(defun pulse-momentary-highlight-line-or-region ()
+ "Highlight current region, when active, or current line, otherwise."
+ (interactive)
+ (if (use-region-p)
+ (pulse-momentary-highlight-region (region-beginning) (region-end))
+ (pulse-momentary-highlight-one-line)))
+
;;; Random integration with other tools
(defvar pulse-command-advice-flag nil)
--
2.34.1
--=-=-=
Content-Type: text/plain
============================================================
---
Gabriel
--=-=-=--
Gabriel <gabriel376@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#62988; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.