GNU bug report logs - #63095
[PATCH] gnu: ffmpeg: add svt-av1 support

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63095 in the body.
You can then email your comments to 63095 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: ffmpeg: add svt-av1 support
Date: Wed, 26 Apr 2023 11:11:08 -0700

[Message part 1 (text/plain, inline)]

[0001-gnu-ffmpeg-add-svt-av1-support.patch (text/x-patch, attachment)]

Message #8 received at 63095 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 63105-done <at> debbugs.gnu.org, 63095 <at> debbugs.gnu.org, iyzsong <at> envs.net,
 Andy Tai <atai <at> atai.org>
Subject: Re: bug#63105: [PATCH v2] gnu: svt-av1: Update to 1.7.0.
Date: Tue, 12 Sep 2023 10:36:27 -0400 (EDT)

On Tue, 12 Sep 2023, Christopher Baines wrote:

> I've gone ahead and pushed this* to master as
> 3acd355455a74a6e08bdcecc72e314c27e7c56b3.
>
> Thanks both,
>
> Chris

* svt-av1 update in https://issues.guix.gnu.org/63105

Very cool, thank you. Maybe now's a good time to review Andy's other patch 
adding svt-av1 support to ffmpeg? https://issues.guix.gnu.org/63095

I've tested it and it works for me (and a nice speed boost for machines 
with avx2). The only nits I have are some extranious indentation changes.

Best,
Jack

Message #11 received at 63095 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: guix-patches <at> gnu.org,
	63095 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH v2] gnu: ffmpeg: add svt-av1 support
Date: Tue,  3 Oct 2023 23:02:56 -0700

* gnu/packages/video.scm (ffmpeg): Add support for svt-av1
[inputs]: Add svt-av1
[arguments] (configure-flags): Add "--enable-libsvtav1"
---
 gnu/packages/video.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index bb6cf75821..a97d6b2593 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1624,6 +1624,7 @@ (define-public ffmpeg
             soxr
             speex
             srt
+            svt-av1
             twolame
             vidstab
             x265
@@ -1712,6 +1713,7 @@ (define-public ffmpeg
          "--enable-libsoxr"
          "--enable-libspeex"
          "--enable-libsrt"
+         "--enable-libsvtav1"
          "--enable-libtheora"
          "--enable-libtwolame"
          "--enable-libvidstab"

base-commit: abf7a1e986f93f8fade230ae6f95b04cc998041b
-- 
2.41.0

Message #19 received at 63095 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 63095 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH v3] gnu: ffmpeg: add svt-av1 support
Date: Sun,  8 Oct 2023 11:24:29 -0700

* gnu/packages/video.scm (ffmpeg): Add support for svt-av1
[inputs]: Add svt-av1
[arguments] (configure-flags): Add "--enable-libsvtav1"
---
 gnu/packages/video.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index bb6ce0cbf1..a2d9fe054c 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1624,6 +1624,7 @@ (define-public ffmpeg
             soxr
             speex
             srt
+            svt-av1
             twolame
             vidstab
             x265
@@ -1712,6 +1713,7 @@ (define-public ffmpeg
          "--enable-libsoxr"
          "--enable-libspeex"
          "--enable-libsrt"
+         "--enable-libsvtav1"
          "--enable-libtheora"
          "--enable-libtwolame"
          "--enable-libvidstab"

base-commit: 00a28bc435606dc98925fbae1ebe314881f35c90
-- 
2.41.0

Message #22 received at 63095 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 63095 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH v4] gnu: ffmpeg: add svt-av1 support
Date: Tue, 10 Oct 2023 08:32:23 -0700

* gnu/packages/video.scm (ffmpeg): Add support for svt-av1
[inputs]: Add svt-av1
[arguments] (configure-flags): Add "--enable-libsvtav1"
---
 gnu/packages/video.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index bb6ce0cbf1..a2d9fe054c 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1624,6 +1624,7 @@ (define-public ffmpeg
             soxr
             speex
             srt
+            svt-av1
             twolame
             vidstab
             x265
@@ -1712,6 +1713,7 @@ (define-public ffmpeg
          "--enable-libsoxr"
          "--enable-libspeex"
          "--enable-libsrt"
+         "--enable-libsvtav1"
          "--enable-libtheora"
          "--enable-libtwolame"
          "--enable-libvidstab"

base-commit: f4e8baf3806e79d7111d2943859865ae4ee0b59d
-- 
2.41.0

Message #25 received at 63095 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 63095 <at> debbugs.gnu.org
Subject: Fwd: Guix QA "Unable to apply patches"
Date: Tue, 10 Oct 2023 09:00:20 -0700

---------- Forwarded message ---------
From: Andy Tai <atai <at> atai.org>
Date: Fri, Oct 6, 2023 at 12:15 PM
Subject: Guix QA "Unable to apply patches"
To: <guix-devel <at> gnu.org>


Hi, for one of my package patches, Guix QA shows

"Unable to apply patches"

in https://qa.guix.gnu.org/issue/63095

even though I double checked the patch applies cleanly on the current
head of the master branch.

Guix QA shows no hint as what the failure is (no log, etc.)   Curious
how to investigate the problem?

Message #28 received at 63095 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Andy Tai <atai <at> atai.org>
Cc: guix-devel <at> gnu.org, 63095 <at> debbugs.gnu.org
Subject: Re: Guix QA "Unable to apply patches"
Date: Tue, 10 Oct 2023 18:02:43 +0100

[Message part 1 (text/plain, inline)]

Andy Tai <atai <at> atai.org> writes:

> Hi, for one of my package patches, Guix QA shows
>
> "Unable to apply patches"
>
> in https://qa.guix.gnu.org/issue/63095
>
> even though I double checked the patch applies cleanly on the current
> head of the master branch.
>
> Guix QA shows no hint as what the failure is (no log, etc.)   Curious
> how to investigate the problem?

That message was appearing incorrectly, which I've now fixed. The
qa-frontpage hadn't attempted to apply the patch, which is why the log
showed #f.

The reason why QA hasn't looked at this issue is that it's too old. To
avoid resource problems, QA only currently looks at a fixed number of
recent issues. The limiting factor is currently data service storage
space.

Unfortunately none of that is very helpful in getting this patch looked
at though.

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 63095 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: 63095 <at> debbugs.gnu.org, 66460 <at> debbugs.gnu.org, Andy Tai <atai <at> atai.org>
Subject: Re: [bug#66460] [PATCH] gnu: ffmpeg: add svt-av1 support
Date: Wed, 11 Oct 2023 11:26:09 -0400

Hi,

Bruno Victal <mirai <at> makinata.eu> writes:

> Hi Andy,
>
> Does svt-av1 imply the use of AVX2?
> Maxim has observed some breakage in [1] with the use of svt-hevc.

It seems not an issue, reading
<https://gitlab.com/AOMediaCodec/SVT-AV1/-/merge_requests/1917/diffs>.
If there's no AVX2 support, SSE2 will be used, which will be slower but
backward compatible with all x86_64 CPUs made after the year 2000 :-).

-- 
Thanks,
Maxim

Message #40 received at 63095 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 63095 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH v6] gnu: ffmpeg: add svt-av1 support
Date: Fri, 20 Oct 2023 22:55:58 -0700

* gnu/packages/video.scm (ffmpeg): Add support for svt-av1
[inputs]: Add svt-av1
[arguments] (configure-flags): Add "--enable-libsvtav1"
---
 gnu/packages/video.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index bb6ce0cbf1..a2d9fe054c 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1624,6 +1624,7 @@ (define-public ffmpeg
             soxr
             speex
             srt
+            svt-av1
             twolame
             vidstab
             x265
@@ -1712,6 +1713,7 @@ (define-public ffmpeg
          "--enable-libsoxr"
          "--enable-libspeex"
          "--enable-libsrt"
+         "--enable-libsvtav1"
          "--enable-libtheora"
          "--enable-libtwolame"
          "--enable-libvidstab"

base-commit: 68fe73cf39cb9347ecb4c87f466ddf1fd044269c
-- 
2.41.0

Message #43 received at 63095 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 63095 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH core-updates v7] gnu: ffmpeg: add svt-av1 support
Date: Mon, 20 Nov 2023 00:20:30 -0800

* gnu/packages/video.scm (ffmpeg): Add support for svt-av1
[inputs]: Add svt-av1
[arguments] (configure-flags): Add "--enable-libsvtav1"
---
 gnu/packages/video.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 561268aabd..ac47a33633 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1625,6 +1625,7 @@ (define-public ffmpeg
             soxr
             speex
             srt
+            svt-av1
             twolame
             vidstab
             x265
@@ -1713,6 +1714,7 @@ (define-public ffmpeg
          "--enable-libsoxr"
          "--enable-libspeex"
          "--enable-libsrt"
+         "--enable-libsvtav1"
          "--enable-libtheora"
          "--enable-libtwolame"
          "--enable-libvidstab"

base-commit: 71b92466430acb8c91841522dc0eb7d766af4388
-- 
2.41.0

Message #46 received at 63095 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 63095 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH core-updates v8] gnu: ffmpeg: add svt-av1 support
Date: Sat,  6 Jan 2024 17:42:54 -0800

* gnu/packages/video.scm (ffmpeg): Add support for svt-av1
[inputs]: Add svt-av1
[arguments] (configure-flags): Add "--enable-libsvtav1"
---
 gnu/packages/video.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index e70aa5352e..21f8a9f7be 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1701,6 +1701,7 @@ (define-public ffmpeg
             soxr
             speex
             srt
+            svt-av1
             twolame
             vidstab
             x265
@@ -1789,6 +1790,7 @@ (define-public ffmpeg
          "--enable-libsoxr"
          "--enable-libspeex"
          "--enable-libsrt"
+         "--enable-libsvtav1"
          "--enable-libtheora"
          "--enable-libtwolame"
          "--enable-libvidstab"

base-commit: 157ad70182ade608203e9c0a42fb45b022039698
-- 
2.41.0

Message #49 received at 63095 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 63095 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [PATCH core-updates v7] gnu: ffmpeg: add svt-av1 support
Date: Mon, 15 Jan 2024 10:19:48 -0800

Maxim, you updated ffmpeg in the core-updates branch of Guix.  Can the
patch in issue 63095

https://issues.guix.gnu.org/63095#14

be also pushed into the core-updates branch if it looks good to you?
else ffmpeg updates will cause rebuild of more than 1000 packages and
this just cnnnot be passed on Guix QA as Guix Qa cannot rebuild that
many packages now for building check of packages. Nor it makes sense
to have a feature branch just for this change. Thanks

On Mon, Nov 20, 2023 at 12:20 AM Andy Tai <atai <at> atai.org> wrote:
>
> * gnu/packages/video.scm (ffmpeg): Add support for svt-av1
> [inputs]: Add svt-av1
> [arguments] (configure-flags): Add "--enable-libsvtav1"
> ---
>  gnu/packages/video.scm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index 561268aabd..ac47a33633 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -1625,6 +1625,7 @@ (define-public ffmpeg
>              soxr
>              speex
>              srt
> +            svt-av1
>              twolame
>              vidstab
>              x265
> @@ -1713,6 +1714,7 @@ (define-public ffmpeg
>           "--enable-libsoxr"
>           "--enable-libspeex"
>           "--enable-libsrt"
> +         "--enable-libsvtav1"
>           "--enable-libtheora"
>           "--enable-libtwolame"
>           "--enable-libvidstab"
>
> base-commit: 71b92466430acb8c91841522dc0eb7d766af4388
> --
> 2.41.0
>

Message #52 received at 63095 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 63095 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH core-updates v9] gnu: ffmpeg: add svt-av1 support
Date: Mon, 12 Feb 2024 23:17:06 -0800

* gnu/packages/video.scm (ffmpeg): Add support for svt-av1
[inputs]: Add svt-av1
[arguments] (configure-flags): Add "--enable-libsvtav1"
---
 gnu/packages/video.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 1123fd0a44..2abffd52ef 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1710,6 +1710,7 @@ (define-public ffmpeg
             soxr
             speex
             srt
+            svt-av1
             twolame
             vidstab
             x265
@@ -1798,6 +1799,7 @@ (define-public ffmpeg
          "--enable-libsoxr"
          "--enable-libspeex"
          "--enable-libsrt"
+         "--enable-libsvtav1"
          "--enable-libtheora"
          "--enable-libtwolame"
          "--enable-libvidstab"

base-commit: 5f86eebd240958001ab4f178005f355d24d9b7f1
-- 
2.34.1

Message #61 received at 63095 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: William <willbilly <at> fedora.email>, help-guix <at> gnu.org
Cc: 63095 <at> debbugs.gnu.org
Subject: Re: Inconsistency between resolved issues/patches and source files.
Date: Thu, 21 Mar 2024 11:21:33 -0700

[Message part 1 (text/plain, inline)]

On 2024-03-21, William wrote:
> A few days ago I tried reencoding several video files I have laying
> around to save storage, using libsvtav1 through ffmpeg, and then to my
> surprise (and frustration) I realized that ffmpeg distributed by
> GNU/Guix does not include such encoding library.
>
> I checked the issue tracker and found out issues that indeed commented
> on this library missing, strangely enough, an issue with a patch was
> marked as solved on 16 February 2024[0], over a month ago, however when
> I check the source files I notice that the patch that includes a flag to
> enable this library is still not present on the latest build of ffmpeg
> yet[1].

It appears to be applied in core-updates as
9400188b2b57cea2f3efc998a2f3b24769db04b7, but not yet merged into the
master branch. This is probably because it would trigger too many
rebuilds...


> Why? How does the merging process work on Guix? Why are issues marked
> as solved/done yet patches are still one month due, to submit upstream?
> Am I missing something or this is a mistake on the mantainers side?

When closing an issue, ideally such information (commit hash and branch
if not on master) should be included in the closing message to avoid
having to look it up. :)


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.