GNU bug report logs - #63096
[PATCH] Note that Emacs pauses when handling sentinel errors

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63096 in the body.
You can then email your comments to 63096 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Note that Emacs pauses when handling sentinel errors
Date: Wed, 26 Apr 2023 18:04:05 -0400

[Message part 1 (text/plain, inline)]

Tags: patch


For emacs-29, since this variable is new in Emacs 29.

In GNU Emacs 29.0.60 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2023-03-13 built on
 igm-qws-u22796a
Repository revision: e759905d2e0828eac4c8164b09113b40f6899656
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: CentOS Linux 7 (Core)

Configured using:
 'configure --with-x-toolkit=lucid --with-modules
 --with-gif=ifavailable'

[0001-Note-that-Emacs-pauses-when-handling-sentinel-errors.patch (text/patch, attachment)]

Message #8 received at 63096 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: 63096 <at> debbugs.gnu.org
Subject: Re: bug#63096: [PATCH] Note that Emacs pauses when handling sentinel
 errors
Date: Thu, 27 Apr 2023 08:35:21 +0300

> From: Spencer Baugh <sbaugh <at> janestreet.com>
> Date: Wed, 26 Apr 2023 18:04:05 -0400
> 
> For emacs-29, since this variable is new in Emacs 29.

Thanks.

> diff --git a/doc/lispref/processes.texi b/doc/lispref/processes.texi
> index 50e67475d8e..39d1ee64e43 100644
> --- a/doc/lispref/processes.texi
> +++ b/doc/lispref/processes.texi
> @@ -2159,7 +2159,9 @@ Sentinels
>  programs was running when the sentinel was started.  However, if
>  @code{debug-on-error} is non-@code{nil},  errors are not caught.
>  This makes it possible to use the Lisp debugger to debug the
> -sentinel.  @xref{Debugger}.
> +sentinel.  @xref{Debugger}.  Additionally, Emacs pauses for

Why "Additionally"?  What you are describing is not in addition to
what was described before that.

> +@var{process-error-pause-time} seconds so that the user sees the
> +error.  @xref{Asynchronous Processes}

If we are mentioning this variable here, let's also mention it where
filter functions are described, since it is also relevant to those.

Message #11 received at 63096 <at> debbugs.gnu.org (full text, mbox):

From: sbaugh <at> catern.com
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Spencer Baugh <sbaugh <at> janestreet.com>, 63096 <at> debbugs.gnu.org
Subject: Re: bug#63096: [PATCH] Note that Emacs pauses when handling sentinel
 errors
Date: Tue, 02 May 2023 14:46:22 +0000 (UTC)

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Spencer Baugh <sbaugh <at> janestreet.com>
>> Date: Wed, 26 Apr 2023 18:04:05 -0400
>> 
>> For emacs-29, since this variable is new in Emacs 29.
>
> Thanks.
>
>> diff --git a/doc/lispref/processes.texi b/doc/lispref/processes.texi
>> index 50e67475d8e..39d1ee64e43 100644
>> --- a/doc/lispref/processes.texi
>> +++ b/doc/lispref/processes.texi
>> @@ -2159,7 +2159,9 @@ Sentinels
>>  programs was running when the sentinel was started.  However, if
>>  @code{debug-on-error} is non-@code{nil},  errors are not caught.
>>  This makes it possible to use the Lisp debugger to debug the
>> -sentinel.  @xref{Debugger}.
>> +sentinel.  @xref{Debugger}.  Additionally, Emacs pauses for
>
> Why "Additionally"?  What you are describing is not in addition to
> what was described before that.
>
>> +@var{process-error-pause-time} seconds so that the user sees the
>> +error.  @xref{Asynchronous Processes}
>
> If we are mentioning this variable here, let's also mention it where
> filter functions are described, since it is also relevant to those.

OK, fixed.

[0001-Note-that-Emacs-pauses-when-handling-sentinel-errors.patch (text/x-patch, inline)]

From ce5909f81485d0cfb0e4622251816e83ef422a5c Mon Sep 17 00:00:00 2001
From: Spencer Baugh <sbaugh <at> catern.com>
Date: Tue, 2 May 2023 10:42:11 -0400
Subject: [PATCH] Note that Emacs pauses when handling sentinel errors

Noting this behavior and variable here makes it easier to understand
the behavior of Emacs when a sentinel has an error.

* doc/lispref/processes.texi (Filter Functions): Note that Emacs
pauses when handling sentinel errors.
(Sentinels): Note that Emacs pauses when handling sentinel errors.
---
 doc/lispref/processes.texi | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/lispref/processes.texi b/doc/lispref/processes.texi
index 50e67475d8e..f55ed7887d2 100644
--- a/doc/lispref/processes.texi
+++ b/doc/lispref/processes.texi
@@ -1755,7 +1755,9 @@ Filter Functions
 program was running when the filter function was started.  However, if
 @code{debug-on-error} is non-@code{nil}, errors are not caught.
 This makes it possible to use the Lisp debugger to debug filter
-functions.  @xref{Debugger}.
+functions.  @xref{Debugger}.  If an error is caught, Emacs pauses for
+@var{process-error-pause-time} seconds so that the user sees the
+error.  @xref{Asynchronous Processes}
 
   Many filter functions sometimes (or always) insert the output in the
 process's buffer, mimicking the actions of the default filter.
@@ -2159,7 +2161,9 @@ Sentinels
 programs was running when the sentinel was started.  However, if
 @code{debug-on-error} is non-@code{nil},  errors are not caught.
 This makes it possible to use the Lisp debugger to debug the
-sentinel.  @xref{Debugger}.
+sentinel.  @xref{Debugger}.  If an error is caught, Emacs pauses for
+@var{process-error-pause-time} seconds so that the user sees the
+error.  @xref{Asynchronous Processes}
 
   While a sentinel is running, the process sentinel is temporarily
 set to @code{nil} so that the sentinel won't run recursively.
-- 
2.38.0

Message #14 received at 63096 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: sbaugh <at> catern.com
Cc: Spencer Baugh <sbaugh <at> janestreet.com>, Eli Zaretskii <eliz <at> gnu.org>,
 63096 <at> debbugs.gnu.org
Subject: Re: bug#63096: [PATCH] Note that Emacs pauses when handling
 sentinel errors
Date: Tue, 02 May 2023 17:01:23 +0200

>>>>> On Tue, 02 May 2023 14:46:22 +0000 (UTC), sbaugh <at> catern.com said:
    sbaugh> +functions.  @xref{Debugger}.  If an error is caught, Emacs pauses for
    sbaugh> +@var{process-error-pause-time} seconds so that the user sees the
    sbaugh> +error.  @xref{Asynchronous Processes}

@var{} is for formal parameters to functions (they end up
upcased), but this is a variable, so you need @code{}

    sbaugh>    Many filter functions sometimes (or always) insert the output in the
    sbaugh>  process's buffer, mimicking the actions of the default filter.
    sbaugh> @@ -2159,7 +2161,9 @@ Sentinels
    sbaugh>  programs was running when the sentinel was started.  However, if
    sbaugh>  @code{debug-on-error} is non-@code{nil},  errors are not caught.
    sbaugh>  This makes it possible to use the Lisp debugger to debug the
    sbaugh> -sentinel.  @xref{Debugger}.
    sbaugh> +sentinel.  @xref{Debugger}.  If an error is caught, Emacs pauses for
    sbaugh> +@var{process-error-pause-time} seconds so that the user sees the
    sbaugh> +error.  @xref{Asynchronous Processes}

Similarly here.

Robert
-- 

Message #17 received at 63096 <at> debbugs.gnu.org (full text, mbox):

From: sbaugh <at> catern.com
To: Robert Pluim <rpluim <at> gmail.com>
Cc: Spencer Baugh <sbaugh <at> janestreet.com>, Eli Zaretskii <eliz <at> gnu.org>,
 63096 <at> debbugs.gnu.org
Subject: Re: bug#63096: [PATCH] Note that Emacs pauses when handling sentinel
 errors
Date: Tue, 02 May 2023 15:38:54 +0000 (UTC)

[Message part 1 (text/plain, inline)]

Robert Pluim <rpluim <at> gmail.com> writes:

>>>>>> On Tue, 02 May 2023 14:46:22 +0000 (UTC), sbaugh <at> catern.com said:
>     sbaugh> +functions.  @xref{Debugger}.  If an error is caught, Emacs pauses for
>     sbaugh> +@var{process-error-pause-time} seconds so that the user sees the
>     sbaugh> +error.  @xref{Asynchronous Processes}
>
> @var{} is for formal parameters to functions (they end up
> upcased), but this is a variable, so you need @code{}
>
>     sbaugh>    Many filter functions sometimes (or always) insert the output in the
>     sbaugh>  process's buffer, mimicking the actions of the default filter.
>     sbaugh> @@ -2159,7 +2161,9 @@ Sentinels
>     sbaugh>  programs was running when the sentinel was started.  However, if
>     sbaugh>  @code{debug-on-error} is non-@code{nil},  errors are not caught.
>     sbaugh>  This makes it possible to use the Lisp debugger to debug the
>     sbaugh> -sentinel.  @xref{Debugger}.
>     sbaugh> +sentinel.  @xref{Debugger}.  If an error is caught, Emacs pauses for
>     sbaugh> +@var{process-error-pause-time} seconds so that the user sees the
>     sbaugh> +error.  @xref{Asynchronous Processes}
>
> Similarly here.
>
> Robert

Fixed.

[0001-Note-that-Emacs-pauses-when-handling-sentinel-errors.patch (text/x-patch, inline)]

From 2d5fe79761683d3d6b84b3d9dacb1a997a7e19fc Mon Sep 17 00:00:00 2001
From: Spencer Baugh <sbaugh <at> catern.com>
Date: Tue, 2 May 2023 11:37:48 -0400
Subject: [PATCH] Note that Emacs pauses when handling sentinel errors

Noting this behavior and variable here makes it easier to understand
the behavior of Emacs when a sentinel has an error.

* doc/lispref/processes.texi (Filter Functions): Note that Emacs
pauses when handling sentinel errors.
(Sentinels): Note that Emacs pauses when handling sentinel errors.
---
 doc/lispref/processes.texi | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/lispref/processes.texi b/doc/lispref/processes.texi
index 50e67475d8e..c901215d35d 100644
--- a/doc/lispref/processes.texi
+++ b/doc/lispref/processes.texi
@@ -1755,7 +1755,9 @@ Filter Functions
 program was running when the filter function was started.  However, if
 @code{debug-on-error} is non-@code{nil}, errors are not caught.
 This makes it possible to use the Lisp debugger to debug filter
-functions.  @xref{Debugger}.
+functions.  @xref{Debugger}.  If an error is caught, Emacs pauses for
+@code{process-error-pause-time} seconds so that the user sees the
+error.  @xref{Asynchronous Processes}
 
   Many filter functions sometimes (or always) insert the output in the
 process's buffer, mimicking the actions of the default filter.
@@ -2159,7 +2161,9 @@ Sentinels
 programs was running when the sentinel was started.  However, if
 @code{debug-on-error} is non-@code{nil},  errors are not caught.
 This makes it possible to use the Lisp debugger to debug the
-sentinel.  @xref{Debugger}.
+sentinel.  @xref{Debugger}.  If an error is caught, Emacs pauses for
+@code{process-error-pause-time} seconds so that the user sees the
+error.  @xref{Asynchronous Processes}
 
   While a sentinel is running, the process sentinel is temporarily
 set to @code{nil} so that the sentinel won't run recursively.
-- 
2.38.0

Message #22 received at 63096-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: sbaugh <at> catern.com
Cc: sbaugh <at> janestreet.com, rpluim <at> gmail.com, 63096-done <at> debbugs.gnu.org
Subject: Re: bug#63096: [PATCH] Note that Emacs pauses when handling sentinel
 errors
Date: Tue, 02 May 2023 20:52:27 +0300

> From: sbaugh <at> catern.com
> Date: Tue, 02 May 2023 15:38:54 +0000 (UTC)
> Cc: Spencer Baugh <sbaugh <at> janestreet.com>, Eli Zaretskii <eliz <at> gnu.org>,
> 	63096 <at> debbugs.gnu.org
> 
> Fixed.

Thanks, installed on the emacs-29 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.