GNU bug report logs - #63107
30.0.50; display-buffer-in-childframe sometimes crashes Emacs on Mac

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63107 in the body.
You can then email your comments to 63107 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Bug Report Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 30.0.50; display-buffer-in-childframe sometimes crashes Emacs on Mac
Date: Thu, 27 Apr 2023 00:38:33 -0700

[Message part 1 (text/plain, inline)]

X-Debbugs-CC: alan <at> idiocy.org

Reproduction is pretty easy, just evaluate

(display-buffer-in-child-frame (get-buffer-create "*test*") nil)

Perhaps I'm missing something? Because packages that uses childframe like eldoc-box are working fine. I tried using the same ALIST as eldoc-box, and various buffers like newly created buffer and current buffer, but it always crashes


In GNU Emacs 30.0.50 (build 46, x86_64-apple-darwin22.4.0, NS
appkit-2299.50 Version 13.3.1 (Build 22E261)) of 2023-04-16 built on
Brown
Repository revision: 6c81ef4cf985dad908fc473f31c0daf662fd2dad
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2299
System Description:  macOS 13.3.1

Configured using:
'configure --with-pdumper=yes --with-ns
PKG_CONFIG_PATH=/usr/local/lib/pkgconfig'

Configured features:
ACL DBUS GLIB GNUTLS JSON LCMS2 LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER
PNG RSVG SQLITE3 THREADS TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM ZLIB

Important settings:
  value of $LC_CTYPE: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind kqueue cocoa ns
lcms2 multi-tty make-network-process emacs)

Memory information:
((conses 16 36193 12385)
(symbols 48 5099 0)
(strings 32 12577 1962)
(string-bytes 1 351234)
(vectors 16 9352)
(vector-slots 8 147536 10497)
(floats 8 21 17)
(intervals 56 202 0)
(buffers 984 11))

[backtrace.log (application/octet-stream, attachment)]

[Message part 3 (text/plain, inline)]

Message #8 received at 63107 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Martín <mardani29 <at> yahoo.es>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 63107 <at> debbugs.gnu.org, alan <at> idiocy.org
Subject: Re: bug#63107: 30.0.50; display-buffer-in-childframe sometimes
 crashes Emacs on Mac
Date: Thu, 27 Apr 2023 18:58:40 +0200

Yuan Fu <casouri <at> gmail.com> writes:

> X-Debbugs-CC: alan <at> idiocy.org
>
> Reproduction is pretty easy, just evaluate
>
> (display-buffer-in-child-frame (get-buffer-create "*test*") nil)
>
> Perhaps I'm missing something? Because packages that uses childframe
> like eldoc-box are working fine. I tried using the same ALIST as
> eldoc-box, and various buffers like newly created buffer and current
> buffer, but it always crashes
>

This seems to be a regression since Emacs 28.2.  I've bisected and the
first bad commit seems to be

commit 9d20b47ad34ff8b409e83198406883f70782c295
Author: Alan Third <alan <at> idiocy.org>
Date:   Wed Mar 30 22:40:03 2022 +0100
    Fix scrollbars on macOS 10.13 and below (bug#54623)
    
    Make any build on macOS 10.13 and below follow the same drawing path
    as the GNUstep port.  macOS 10.14 and above will use EmacsLayer.
    
    * src/nsterm.h (EmacsLayer):
    * src/nsterm.m ([EmacsView makeBackingLayer]):
    ([EmacsView unlockFocus]):
    ([EmacsView windowDidChangeBackingProperties:]):
    ([EmacsView copyRect:to:]): Remove any code required for macOS 10.13
    and below, and fix the #if's to enforce strict separation of the
    drawing paths.
    (ns_update_end):
    (ns_unfocus): Fix #ifs so that flushWindow is called on old macOS
    versions as well as GNUstep.
 src/nsterm.h |   4 +-
 src/nsterm.m | 128 ++++++++++++++++++++++-------------------------------------
 2 files changed, 50 insertions(+), 82 deletions(-)

Message #11 received at 63107 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Daniel Martín <mardani29 <at> yahoo.es>
Cc: Yuan Fu <casouri <at> gmail.com>, 63107 <at> debbugs.gnu.org
Subject: Re: bug#63107: 30.0.50; display-buffer-in-childframe sometimes
 crashes Emacs on Mac
Date: Thu, 27 Apr 2023 19:39:06 +0100

package emacs
merge 63107 55687
thankyou

On Thu, Apr 27, 2023 at 06:58:40PM +0200, Daniel Martín wrote:
> Yuan Fu <casouri <at> gmail.com> writes:
> 
> > X-Debbugs-CC: alan <at> idiocy.org
> >
> > Reproduction is pretty easy, just evaluate
> >
> > (display-buffer-in-child-frame (get-buffer-create "*test*") nil)
> >
> > Perhaps I'm missing something? Because packages that uses childframe
> > like eldoc-box are working fine. I tried using the same ALIST as
> > eldoc-box, and various buffers like newly created buffer and current
> > buffer, but it always crashes
> >
> 
> This seems to be a regression since Emacs 28.2.

Looks like it's probably the same as bug#55687.

The small patch in that thread might fix this immediate crash, but I
expect it will introduce further problems elsewhere.
-- 
Alan Third

Message #14 received at 63107 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Third <alan <at> idiocy.org>
Cc: casouri <at> gmail.com, 63107 <at> debbugs.gnu.org, mardani29 <at> yahoo.es
Subject: Re: bug#63107: 30.0.50;
 display-buffer-in-childframe sometimes crashes Emacs on Mac
Date: Thu, 27 Apr 2023 21:44:04 +0300

> Cc: Yuan Fu <casouri <at> gmail.com>, 63107 <at> debbugs.gnu.org
> Date: Thu, 27 Apr 2023 19:39:06 +0100
> From: Alan Third <alan <at> idiocy.org>
> 
> > This seems to be a regression since Emacs 28.2.
> 
> Looks like it's probably the same as bug#55687.
> 
> The small patch in that thread might fix this immediate crash, but I
> expect it will introduce further problems elsewhere.

If we don't install that patch, we will never know whether it
introduces further problems.

Message #17 received at 63107 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Daniel Martín <mardani29 <at> yahoo.es>,
 Yuan Fu <casouri <at> gmail.com>, 63107 <at> debbugs.gnu.org
Subject: Re: bug#63107: 30.0.50; display-buffer-in-childframe sometimes
 crashes Emacs on Mac
Date: Thu, 27 Apr 2023 19:43:54 +0100

On Thu, Apr 27, 2023 at 07:39:06PM +0100, Alan Third wrote:
> On Thu, Apr 27, 2023 at 06:58:40PM +0200, Daniel Martín wrote:
> > Yuan Fu <casouri <at> gmail.com> writes:
> > 
> > > X-Debbugs-CC: alan <at> idiocy.org
> > >
> > > Reproduction is pretty easy, just evaluate
> > >
> > > (display-buffer-in-child-frame (get-buffer-create "*test*") nil)
> > >
> > > Perhaps I'm missing something? Because packages that uses childframe
> > > like eldoc-box are working fine. I tried using the same ALIST as
> > > eldoc-box, and various buffers like newly created buffer and current
> > > buffer, but it always crashes
> > >
> > 
> > This seems to be a regression since Emacs 28.2.
> 
> Looks like it's probably the same as bug#55687.
> 
> The small patch in that thread might fix this immediate crash, but I
> expect it will introduce further problems elsewhere.

OK, so that bug has been closed, but the issue Aaron Jensen ran into
in that thread appears to have been another issue, the same as this.
-- 
Alan Third

Message #20 received at 63107 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Daniel Martín <mardani29 <at> yahoo.es>,
 Yuan Fu <casouri <at> gmail.com>, 63107 <at> debbugs.gnu.org
Subject: Re: bug#63107: 30.0.50; display-buffer-in-childframe sometimes
 crashes Emacs on Mac
Date: Thu, 27 Apr 2023 20:13:14 +0100

[Message part 1 (text/plain, inline)]

On Thu, Apr 27, 2023 at 07:43:54PM +0100, Alan Third wrote:
> On Thu, Apr 27, 2023 at 07:39:06PM +0100, Alan Third wrote:
> > On Thu, Apr 27, 2023 at 06:58:40PM +0200, Daniel Martín wrote:
> > > Yuan Fu <casouri <at> gmail.com> writes:
> > > 
> > > > X-Debbugs-CC: alan <at> idiocy.org
> > > >
> > > > Reproduction is pretty easy, just evaluate
> > > >
> > > > (display-buffer-in-child-frame (get-buffer-create "*test*") nil)
> > > >
> > > > Perhaps I'm missing something? Because packages that uses childframe
> > > > like eldoc-box are working fine. I tried using the same ALIST as
> > > > eldoc-box, and various buffers like newly created buffer and current
> > > > buffer, but it always crashes
> > > >
> > > 
> > > This seems to be a regression since Emacs 28.2.
> > 
> > Looks like it's probably the same as bug#55687.
> > 
> > The small patch in that thread might fix this immediate crash, but I
> > expect it will introduce further problems elsewhere.
> 
> OK, so that bug has been closed, but the issue Aaron Jensen ran into
> in that thread appears to have been another issue, the same as this.

Entirely untested patch attached. I can't even try compiling it.

Good luck.
-- 
Alan Third

[0001-Fix-crash-when-creating-a-child-frame-in-NS-bug-6310.patch (text/x-diff, attachment)]

Message #23 received at 63107 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Alan Third <alan <at> idiocy.org>
Cc: 63107 <at> debbugs.gnu.org, Daniel Martín <mardani29 <at> yahoo.es>
Subject: Re: bug#63107: 30.0.50; display-buffer-in-childframe sometimes
 crashes Emacs on Mac
Date: Thu, 27 Apr 2023 13:36:28 -0700

> On Apr 27, 2023, at 12:13 PM, Alan Third <alan <at> idiocy.org> wrote:
> 
> On Thu, Apr 27, 2023 at 07:43:54PM +0100, Alan Third wrote:
>> On Thu, Apr 27, 2023 at 07:39:06PM +0100, Alan Third wrote:
>>> On Thu, Apr 27, 2023 at 06:58:40PM +0200, Daniel Martín wrote:
>>>> Yuan Fu <casouri <at> gmail.com> writes:
>>>> 
>>>>> X-Debbugs-CC: alan <at> idiocy.org
>>>>> 
>>>>> Reproduction is pretty easy, just evaluate
>>>>> 
>>>>> (display-buffer-in-child-frame (get-buffer-create "*test*") nil)
>>>>> 
>>>>> Perhaps I'm missing something? Because packages that uses childframe
>>>>> like eldoc-box are working fine. I tried using the same ALIST as
>>>>> eldoc-box, and various buffers like newly created buffer and current
>>>>> buffer, but it always crashes
>>>>> 
>>>> 
>>>> This seems to be a regression since Emacs 28.2.
>>> 
>>> Looks like it's probably the same as bug#55687.
>>> 
>>> The small patch in that thread might fix this immediate crash, but I
>>> expect it will introduce further problems elsewhere.
>> 
>> OK, so that bug has been closed, but the issue Aaron Jensen ran into
>> in that thread appears to have been another issue, the same as this.
> 
> Entirely untested patch attached. I can't even try compiling it.
> 
> Good luck.
> -- 
> Alan Third
> <0001-Fix-crash-when-creating-a-child-frame-in-NS-bug-6310.patch>

Uh oh, I tried it and it crashed on startup.

2023-04-27 13:29:59.275 emacs[53693:9000283] -[EmacsView createToolbar:]: unrecognized selector sent to instance 0x7fc84a753b10
2023-04-27 13:29:59.276 emacs[53693:9000283] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[EmacsView createToolbar:]: unrecognized selector sent to instance 0x7fc84a753b10'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007ff804c871ba __exceptionPreprocess + 242
	1   libobjc.A.dylib                     0x00007ff8047ad42b objc_exception_throw + 48
	2   CoreFoundation                      0x00007ff804d2301f -[NSObject(NSObject) __retain_OA] + 0
	3   CoreFoundation                      0x00007ff804bf28d7 ___forwarding___ + 1392
	4   CoreFoundation                      0x00007ff804bf22d8 _CF_forwarding_prep_0 + 120
	5   emacs                               0x0000000105a499a0 -[EmacsView initFrameFromEmacs:] + 592
	6   emacs                               0x0000000105a5bd17 Fx_create_frame + 4551
	7   emacs                               0x00000001059e7ae0 exec_byte_code + 3376
	8   emacs                               0x0000000105996ed8 Ffuncall + 456
	9   emacs                               0x00000001059e7ae0 exec_byte_code + 3376
	10  emacs                               0x0000000105999d96 apply_lambda + 406
	11  emacs                               0x00000001059947bb eval_sub + 1499
	12  emacs                               0x0000000105999b5d Feval + 77
	13  emacs                               0x0000000105997ecb internal_condition_case + 283
	14  emacs                               0x000000010591585d top_level_1 + 45
	15  emacs                               0x00000001059975e7 internal_catch + 295
	16  emacs                               0x0000000105a92166 command_loop.cold.1 + 54
	17  emacs                               0x0000000105900644 command_loop + 132
	18  emacs                               0x000000010590052e recursive_edit_1 + 142
	19  emacs                               0x000000010590085f Frecursive_edit + 319
	20  emacs                               0x00000001058ff366 main + 8534
	21  dyld                                0x00007ff8047da41f start + 1903
)
libc++abi: terminating due to uncaught exception of type NSException
Fatal error 6: Aborted
fish: Job 1, 'src/emacs' terminated by signal SIGABRT (Abort)

Yuan

Message #26 received at 63107 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 63107 <at> debbugs.gnu.org,
 Daniel Martín <mardani29 <at> yahoo.es>
Subject: Re: bug#63107: 30.0.50; display-buffer-in-childframe sometimes
 crashes Emacs on Mac
Date: Fri, 28 Apr 2023 20:35:51 +0100

[Message part 1 (text/plain, inline)]

On Thu, Apr 27, 2023 at 01:36:28PM -0700, Yuan Fu wrote:
> 
> > 
> > Entirely untested patch attached. I can't even try compiling it.
> > 
> > Good luck.
> 
> Uh oh, I tried it and it crashed on startup.

I did say it was untested. ;)

I made a silly mistake. Updated patch attached.
-- 
Alan Third

[v2-0001-Fix-crash-when-creating-a-child-frame-in-NS-bug-6.patch (text/x-diff, attachment)]

Message #29 received at 63107 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Alan Third <alan <at> idiocy.org>
Cc: 63107 <at> debbugs.gnu.org, Daniel Martín <mardani29 <at> yahoo.es>
Subject: Re: bug#63107: 30.0.50; display-buffer-in-childframe sometimes
 crashes Emacs on Mac
Date: Fri, 28 Apr 2023 13:00:07 -0700

> On Apr 28, 2023, at 12:35 PM, Alan Third <alan <at> idiocy.org> wrote:
> 
> On Thu, Apr 27, 2023 at 01:36:28PM -0700, Yuan Fu wrote:
>> 
>>> 
>>> Entirely untested patch attached. I can't even try compiling it.
>>> 
>>> Good luck.
>> 
>> Uh oh, I tried it and it crashed on startup.
> 
> I did say it was untested. ;)
> 
> I made a silly mistake. Updated patch attached.

Compiles and runs perfectly. Solves the display-buffer-in-child-frame crash too. I’ll be running with this for a couple of days. Any particular operations I could test to expose potential problems?

Yuan

Message #32 received at 63107 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 63107 <at> debbugs.gnu.org,
 Daniel Martín <mardani29 <at> yahoo.es>
Subject: Re: bug#63107: 30.0.50; display-buffer-in-childframe sometimes
 crashes Emacs on Mac
Date: Fri, 28 Apr 2023 21:03:40 +0100

On Fri, Apr 28, 2023 at 01:00:07PM -0700, Yuan Fu wrote:
> 
> 
> > On Apr 28, 2023, at 12:35 PM, Alan Third <alan <at> idiocy.org> wrote:
> > 
> > On Thu, Apr 27, 2023 at 01:36:28PM -0700, Yuan Fu wrote:
> >> 
> >>> 
> >>> Entirely untested patch attached. I can't even try compiling it.
> >>> 
> >>> Good luck.
> >> 
> >> Uh oh, I tried it and it crashed on startup.
> > 
> > I did say it was untested. ;)
> > 
> > I made a silly mistake. Updated patch attached.
> 
> Compiles and runs perfectly. Solves the
> display-buffer-in-child-frame crash too. I’ll be running with this
> for a couple of days. Any particular operations I could test to
> expose potential problems?

Just doing things with the toolbar, like turning on and off frame
decorations, going into fullscreen and back, etc. to make sure it
appears when it should and doesn't when it shouldn't.
-- 
Alan Third

Message #35 received at 63107 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Alan Third <alan <at> idiocy.org>
Cc: 63107 <at> debbugs.gnu.org, Daniel Martín <mardani29 <at> yahoo.es>
Subject: Re: bug#63107: 30.0.50; display-buffer-in-childframe sometimes 
 crashes Emacs on Mac
Date: Sat, 6 May 2023 16:01:57 -0700

Alan Third <alan <at> idiocy.org> writes:

> On Fri, Apr 28, 2023 at 01:00:07PM -0700, Yuan Fu wrote:
>> 
>> 
>> > On Apr 28, 2023, at 12:35 PM, Alan Third <alan <at> idiocy.org> wrote:
>> > 
>> > On Thu, Apr 27, 2023 at 01:36:28PM -0700, Yuan Fu wrote:
>> >> 
>> >>> 
>> >>> Entirely untested patch attached. I can't even try compiling it.
>> >>> 
>> >>> Good luck.
>> >> 
>> >> Uh oh, I tried it and it crashed on startup.
>> > 
>> > I did say it was untested. ;)
>> > 
>> > I made a silly mistake. Updated patch attached.
>> 
>> Compiles and runs perfectly. Solves the
>> display-buffer-in-child-frame crash too. I’ll be running with this
>> for a couple of days. Any particular operations I could test to
>> expose potential problems?
>
> Just doing things with the toolbar, like turning on and off frame
> decorations, going into fullscreen and back, etc. to make sure it
> appears when it should and doesn't when it shouldn't.

I’ve been using this patch for a couple of days (I always have tool bar
enabled), I also tried maximizing/minimizing, toggling tool-bar-mode,
toggling frame decorations, and clicking on toolbar icons. Everything
seems to be just fine.

Yuan

Message #38 received at 63107 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 63107 <at> debbugs.gnu.org,
 Daniel Martín <mardani29 <at> yahoo.es>
Subject: Re: bug#63107: 30.0.50; display-buffer-in-childframe sometimes
 crashes Emacs on Mac
Date: Sun, 7 May 2023 23:56:19 +0100

On Sat, May 06, 2023 at 04:01:57PM -0700, Yuan Fu wrote:
> 
> Alan Third <alan <at> idiocy.org> writes:
> 
> > On Fri, Apr 28, 2023 at 01:00:07PM -0700, Yuan Fu wrote:
> >> 
> >> 
> >> > On Apr 28, 2023, at 12:35 PM, Alan Third <alan <at> idiocy.org> wrote:
> >> > 
> >> > On Thu, Apr 27, 2023 at 01:36:28PM -0700, Yuan Fu wrote:
> >> >> 
> >> >>> 
> >> >>> Entirely untested patch attached. I can't even try compiling it.
> >> >>> 
> >> >>> Good luck.
> >> >> 
> >> >> Uh oh, I tried it and it crashed on startup.
> >> > 
> >> > I did say it was untested. ;)
> >> > 
> >> > I made a silly mistake. Updated patch attached.
> >> 
> >> Compiles and runs perfectly. Solves the
> >> display-buffer-in-child-frame crash too. I’ll be running with this
> >> for a couple of days. Any particular operations I could test to
> >> expose potential problems?
> >
> > Just doing things with the toolbar, like turning on and off frame
> > decorations, going into fullscreen and back, etc. to make sure it
> > appears when it should and doesn't when it shouldn't.
> 
> I’ve been using this patch for a couple of days (I always have tool bar
> enabled), I also tried maximizing/minimizing, toggling tool-bar-mode,
> toggling frame decorations, and clicking on toolbar icons. Everything
> seems to be just fine.

Thanks.

I just pushed this to master as
3adc1e7f37901235bda83ea65a90644b7b0a8dbf, but on reflection I'm
wondering if it should have gone into the emacs-29 branch instead?

I've no idea what the status of the various branches is just now...

-- 
Alan Third

Message #41 received at 63107 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Third <alan <at> idiocy.org>
Cc: casouri <at> gmail.com, 63107 <at> debbugs.gnu.org, mardani29 <at> yahoo.es
Subject: Re: bug#63107: 30.0.50;
 display-buffer-in-childframe sometimes crashes Emacs on Mac
Date: Mon, 08 May 2023 05:27:24 +0300

> Cc: 63107 <at> debbugs.gnu.org, Daniel Martín <mardani29 <at> yahoo.es>
> Date: Sun, 7 May 2023 23:56:19 +0100
> From: Alan Third <alan <at> idiocy.org>
> 
> > I’ve been using this patch for a couple of days (I always have tool bar
> > enabled), I also tried maximizing/minimizing, toggling tool-bar-mode,
> > toggling frame decorations, and clicking on toolbar icons. Everything
> > seems to be just fine.
> 
> Thanks.
> 
> I just pushed this to master as
> 3adc1e7f37901235bda83ea65a90644b7b0a8dbf, but on reflection I'm
> wondering if it should have gone into the emacs-29 branch instead?

It's regression since Emacs 28.2, so it should go to the emacs-29
branch, indeed.

Message #46 received at 63107-done <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <alan <at> idiocy.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: casouri <at> gmail.com, 63107-done <at> debbugs.gnu.org, mardani29 <at> yahoo.es
Subject: Re: bug#63107: 30.0.50; display-buffer-in-childframe sometimes
 crashes Emacs on Mac
Date: Mon, 8 May 2023 09:52:18 +0100

On Mon, May 08, 2023 at 05:27:24AM +0300, Eli Zaretskii wrote:
> > Cc: 63107 <at> debbugs.gnu.org, Daniel Martín <mardani29 <at> yahoo.es>
> > Date: Sun, 7 May 2023 23:56:19 +0100
> > From: Alan Third <alan <at> idiocy.org>
> > 
> > > I’ve been using this patch for a couple of days (I always have tool bar
> > > enabled), I also tried maximizing/minimizing, toggling tool-bar-mode,
> > > toggling frame decorations, and clicking on toolbar icons. Everything
> > > seems to be just fine.
> > 
> > Thanks.
> > 
> > I just pushed this to master as
> > 3adc1e7f37901235bda83ea65a90644b7b0a8dbf, but on reflection I'm
> > wondering if it should have gone into the emacs-29 branch instead?
> 
> It's regression since Emacs 28.2, so it should go to the emacs-29
> branch, indeed.

OK, I've cherry picked it into emacs-29.

Thanks!
-- 
Alan Third

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.