GNU bug report logs - #63123
[PATCH] Make vc-hg-annotate-command async

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63123 in the body.
You can then email your comments to 63123 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Make vc-hg-annotate-command async
Date: Thu, 27 Apr 2023 12:12:08 -0400

[Message part 1 (text/plain, inline)]

Tags: patch





In GNU Emacs 29.0.60 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2023-03-13 built on
 igm-qws-u22796a
Repository revision: e759905d2e0828eac4c8164b09113b40f6899656
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: CentOS Linux 7 (Core)

Configured using:
 'configure --with-x-toolkit=lucid --with-modules
 --with-gif=ifavailable'

[0001-Make-vc-hg-annotate-command-async.patch (text/patch, attachment)]

Message #8 received at 63123 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: 63123 <at> debbugs.gnu.org
Subject: Re: bug#63123: [PATCH] Make vc-hg-annotate-command async
Date: Mon, 01 May 2023 07:17:58 +0000

This should be fine, do you have any larger  mercurial repositories that
could be used to test the async behaviour?

Message #11 received at 63123 <at> debbugs.gnu.org (full text, mbox):

From: sbaugh <at> catern.com
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 63123 <at> debbugs.gnu.org, Spencer Baugh <sbaugh <at> janestreet.com>
Subject: Re: bug#63123: [PATCH] Make vc-hg-annotate-command async
Date: Tue, 02 May 2023 13:48:03 +0000 (UTC)

Philip Kaludercic <philipk <at> posteo.net> writes:
> This should be fine, do you have any larger  mercurial repositories that
> could be used to test the async behaviour?

I don't, but at least running C-x v g on setup.py in
https://www.mercurial-scm.org/repo/hg there's a perceptible delay which
is no longer present when it's async.

Message #14 received at 63123 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Spencer Baugh <sbaugh <at> janestreet.com>, 63123 <at> debbugs.gnu.org,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#63123: [PATCH] Make vc-hg-annotate-command async
Date: Thu, 4 May 2023 02:03:03 +0300

Hi!

On 27/04/2023 19:12, Spencer Baugh wrote:
> -  (apply #'vc-hg-command buffer 0 file "annotate" "-dq" "-n"
> +  (apply #'vc-hg-command buffer 'async file "annotate" "-dq" "-n"

Looking good, thanks.

Eli, is this for master only?

It might not really be a "fix" (an improvement rather), but it seems 
obviously correct: vc-git-annotate-command does this already.

Message #17 received at 63123 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 63123 <at> debbugs.gnu.org, sbaugh <at> janestreet.com
Subject: Re: bug#63123: [PATCH] Make vc-hg-annotate-command async
Date: Thu, 04 May 2023 08:39:12 +0300

> Date: Thu, 4 May 2023 02:03:03 +0300
> From: Dmitry Gutov <dmitry <at> gutov.dev>
> 
> On 27/04/2023 19:12, Spencer Baugh wrote:
> > -  (apply #'vc-hg-command buffer 0 file "annotate" "-dq" "-n"
> > +  (apply #'vc-hg-command buffer 'async file "annotate" "-dq" "-n"
> 
> Looking good, thanks.
> 
> Eli, is this for master only?

Yes, it's a new feature.

> It might not really be a "fix" (an improvement rather), but it seems 
> obviously correct: vc-git-annotate-command does this already.

Is it really awfully important to do this ASAP for Mercurial?

Message #22 received at 63123-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 63123-done <at> debbugs.gnu.org, sbaugh <at> janestreet.com
Subject: Re: bug#63123: [PATCH] Make vc-hg-annotate-command async
Date: Fri, 5 May 2023 02:43:53 +0300

On 04/05/2023 08:39, Eli Zaretskii wrote:
>> Date: Thu, 4 May 2023 02:03:03 +0300
>> From: Dmitry Gutov <dmitry <at> gutov.dev>
>>
>> On 27/04/2023 19:12, Spencer Baugh wrote:
>>> -  (apply #'vc-hg-command buffer 0 file "annotate" "-dq" "-n"
>>> +  (apply #'vc-hg-command buffer 'async file "annotate" "-dq" "-n"
>>
>> Looking good, thanks.
>>
>> Eli, is this for master only?
> 
> Yes, it's a new feature.

All right.

>> It might not really be a "fix" (an improvement rather), but it seems
>> obviously correct: vc-git-annotate-command does this already.
> 
> Is it really awfully important to do this ASAP for Mercurial?

No, probably not.

Pushed to master and closing. Thanks all!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.